From unknown Sun Jun 22 17:11:34 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#25677 <25677@debbugs.gnu.org> To: bug#25677 <25677@debbugs.gnu.org> Subject: Status: [PATCH 01/22] oldXMenu: add missing #include Reply-To: bug#25677 <25677@debbugs.gnu.org> Date: Mon, 23 Jun 2025 00:11:34 +0000 retitle 25677 [PATCH 01/22] oldXMenu: add missing #include reassign 25677 emacs submitter 25677 Michal Nazarewicz severity 25677 minor tag 25677 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 10 13:16:57 2017 Received: (at submit) by debbugs.gnu.org; 10 Feb 2017 18:16:57 +0000 Received: from localhost ([127.0.0.1]:34983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccFke-0001pj-Fw for submit@debbugs.gnu.org; Fri, 10 Feb 2017 13:16:57 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccFkb-0001pV-Uj for submit@debbugs.gnu.org; Fri, 10 Feb 2017 13:16:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ccFkV-0007Vi-FL for submit@debbugs.gnu.org; Fri, 10 Feb 2017 13:16:48 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45675) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ccFkV-0007Vc-CA for submit@debbugs.gnu.org; Fri, 10 Feb 2017 13:16:47 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ccFkU-0001Ma-54 for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 13:16:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ccFkS-0007US-RE for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 13:16:46 -0500 Received: from mail-wr0-x235.google.com ([2a00:1450:400c:c0c::235]:33955) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ccFkS-0007SB-J4 for bug-gnu-emacs@gnu.org; Fri, 10 Feb 2017 13:16:44 -0500 Received: by mail-wr0-x235.google.com with SMTP id o16so114061821wra.1 for ; Fri, 10 Feb 2017 10:16:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=2J+BC68YHur4mrVX+tV6ZqkOeAU/lUDJiozok8RrZy8=; b=cNyomPJyOIBA2TNp+Yh4csNDcNghhu9tggFXLkZDD04v1Zv3LdOM0zNl4zvpsyOcCz Ntfqny18kp8TEBQ8Tsr2EVU2pyTrOAvKYjHBUQX0YscFo0Wi0mWNHrFBwkjcGv7uYFzc WddeijI/u9HhvvTVpjEzpu3L6zy2hCybHL1iQBoHxNDvThTaR/LD9NBKGglm9oXijoia fWs8l1z8IKt8XUUsdTh3UJ8MzwbAVvKbsauPIoaqdyxHkwFnzC0PHTC0YoQVM2KhL842 XRSy2m5bz0fXorZFGG2WX1kip0tIJvPQz8JNxWApZ0R5uBeagxZzcbGAkP25JqOMEP76 JSlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version:content-transfer-encoding; bh=2J+BC68YHur4mrVX+tV6ZqkOeAU/lUDJiozok8RrZy8=; b=C4lqZMbOmp/zMAYe9U5HHkG1Ki7A3G+trlMM1gkW5fryL3lsQrbDCfeyOvp+y80vk8 S/23L6jEYD4eUzezk3FKvscGitN8KmxiVYnM2VFtSYw5W9g8bNsluJRyB4WVvNIUEhj+ Du1jNRz48XAlBV9+FAFFl4QFzKiB5YiRaCBDg2SFhjyee0drwvPZDYFEWs/NsLB0V/TN ekAPCdQ3PfXSf2PsBT86ca5wYzGm/yyebjVBoItPNirNnzTjIvtc6yevLKTh8OR+kIoC 3s0Ai30M1jWwB7Ozq1EeJlZGJrYnEDRusX21uPX7Cr4FyvAfPs6G8HOYDPxOYvjFhqHc SKsw== X-Gm-Message-State: AMke39mD+/XNI5ZTrFKa0Lk+whPlBRnUXK1W9KZOQqGp+6oTCAyOkTzDLDSB7cryKV/3yaYM X-Received: by 10.223.150.183 with SMTP id u52mr8828402wrb.180.1486750601367; Fri, 10 Feb 2017 10:16:41 -0800 (PST) Received: from mpn.zrh.corp.google.com ([2620:0:105f:303:918e:7044:fab0:2453]) by smtp.gmail.com with ESMTPSA id h3sm3720174wrb.31.2017.02.10.10.16.39 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Feb 2017 10:16:40 -0800 (PST) Received: by mpn.zrh.corp.google.com (Postfix, from userid 126942) id 3B83D1E0263; Fri, 10 Feb 2017 19:16:39 +0100 (CET) From: Michal Nazarewicz To: bug-gnu-emacs@gnu.org Subject: [PATCH 01/22] oldXMenu: add missing #include Date: Fri, 10 Feb 2017 19:16:37 +0100 Message-Id: <20170210181637.15565-1-mina86@mina86.com> X-Mailer: git-send-email 2.11.0.483.g087da7b7c-goog MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Some of the files in oldXMenu use functions from string.h without including that header which results in compile warnings: ChgPane.c:46:5: warning: implicit declaration of function ‘strlen’ ChgPane.c:46:20: warning: incompatible implicit declaration of built-in function ‘strlen’ ChgSel.c:62:2: warning: implicit declaration of function ‘strlen’ ChgSel.c:62:17: warning: incompatible implicit declaration of built-in function ‘strlen’ Create.c:220:5: warning: implicit declaration of function ‘strcmp’ InsPane.c:65:5: warning: implicit declaration of function ‘strlen’ InsPane.c:65:20: warning: incompatible implicit declaration of built-in function ‘strlen’ InsSel.c:68:5: warning: implicit declaration of function ‘strlen’ InsSel.c:68:20: warning: incompatible implicit declaration of built-in function ‘strlen’ InsSel.c:75:5: warning: implicit declaration of function ‘strcmp’ Add the necessary ‘#include ’. oldXMenu/ChgPane.c, oldXMenu/ChgSel.c, oldXMenu/Create.c, oldXMenu/InsPane.c, oldXMenu/InsSel.c: add missing #include --- oldXMenu/ChgPane.c | 1 + oldXMenu/ChgSel.c | 1 + oldXMenu/Create.c | 1 + oldXMenu/InsPane.c | 1 + oldXMenu/InsSel.c | 1 + 5 files changed, 5 insertions(+) Unless there are some objections I’ll commit this in a few days. diff --git a/oldXMenu/ChgPane.c b/oldXMenu/ChgPane.c index d2977b73faf..733f65950f5 100644 --- a/oldXMenu/ChgPane.c +++ b/oldXMenu/ChgPane.c @@ -14,6 +14,7 @@ */ #include "XMenuInt.h" +#include int XMenuChangePane(register XMenu *menu, register int p_num, char *label) diff --git a/oldXMenu/ChgSel.c b/oldXMenu/ChgSel.c index d24e61f56d5..5a46b5cf587 100644 --- a/oldXMenu/ChgSel.c +++ b/oldXMenu/ChgSel.c @@ -14,6 +14,7 @@ */ #include "XMenuInt.h" +#include int XMenuChangeSelection(Display *display, register XMenu *menu, register int p_num, register int s_num, char *data, int data_sw, char *label, int label_sw) diff --git a/oldXMenu/Create.c b/oldXMenu/Create.c index 0e72a2d2e58..a0913685365 100644 --- a/oldXMenu/Create.c +++ b/oldXMenu/Create.c @@ -31,6 +31,7 @@ along with this program. If not, see . */ #include "XMenuInt.h" #include +#include #ifdef EMACS_BITMAP_FILES #include "../src/bitmaps/dimple1.xbm" diff --git a/oldXMenu/InsPane.c b/oldXMenu/InsPane.c index d8470f3a5bf..da92f49aa77 100644 --- a/oldXMenu/InsPane.c +++ b/oldXMenu/InsPane.c @@ -15,6 +15,7 @@ */ #include "XMenuInt.h" +#include int XMenuInsertPane(register XMenu *menu, register int p_num, char *label, int active) diff --git a/oldXMenu/InsSel.c b/oldXMenu/InsSel.c index 66f4968197d..f5380437958 100644 --- a/oldXMenu/InsSel.c +++ b/oldXMenu/InsSel.c @@ -14,6 +14,7 @@ */ #include "XMenuInt.h" +#include int XMenuInsertSelection(register XMenu *menu, register int p_num, register int s_num, char *data, char *label, int active) -- 2.11.0.483.g087da7b7c-goog From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 15 11:13:23 2017 Received: (at 25677-close) by debbugs.gnu.org; 15 Feb 2017 16:13:23 +0000 Received: from localhost ([127.0.0.1]:41221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ce2Cp-0008TP-8u for submit@debbugs.gnu.org; Wed, 15 Feb 2017 11:13:23 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:38723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ce2Cn-0008TC-Gi for 25677-close@debbugs.gnu.org; Wed, 15 Feb 2017 11:13:22 -0500 Received: by mail-wm0-f46.google.com with SMTP id r141so44486004wmg.1 for <25677-close@debbugs.gnu.org>; Wed, 15 Feb 2017 08:13:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:from:to:subject:in-reply-to:organization:references :user-agent:face:date:message-id:mime-version :content-transfer-encoding; bh=/1TljiwIih+itp7Hb8UfKpWqNsyrdOQ7Pm6sC/6nP8Q=; b=uStDbZOLs/yPolSZ4ln/SJrjzH48xg5cRejo4l0B60cMXDFRpnpAQhXwKRLAI/8RCf tGrbObV46pydONaqfI+4g1b0P8Np+4ewMl+Y4kVglOtFGCgS4gGh1ujF/MugifTTu1Lw dUc/da+oOJpipRbUo0cL95/g3M+GM6N5YTlBRwAhdFZkeSpO+tc2+8otngHcKwKIuPYb MIW3rtq3cafbfCvpD4Gw7foL4XBknQOEnie583603TpiCq6sjyiiBDG0ZVH3oT2oAf8Z uEUX7ku80AUwHXqaMQmpLAElgEaIfdbxN3x+4kWm9Gs64/nF8QOKRUayJFzj7yTGojYE JD+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:in-reply-to:organization :references:user-agent:face:date:message-id:mime-version :content-transfer-encoding; bh=/1TljiwIih+itp7Hb8UfKpWqNsyrdOQ7Pm6sC/6nP8Q=; b=lrk3rrRAY/yFvKKlWVTWdt/c2DeAjUqJyVH5h6Ren0/5TIzH3pr0m6qiq4ZSsIhXNp xc+egpOdwSqCSlmN/6uEiZqJBbNo3vBOPaWnjXg2Uz+laabCEI5eevVTboPR9rGjTy9R 8kHNWYpSeApnUV4cAfUWUcv4eE/h3FW5tf7rzzGHf8aqScr3QXJiI+Gbl7x1nqP2sH1H cYtC2ZgXQ7bEn32nEhaoKBxjm6+LzvrZoKrimohQWAyFHAav3Bs7jh+qNV1WOMABXrm1 Mwg4eo7ms+7b3VH9X60NDeo3jerE1RbKRO9pNztvGldKPxeT2lOG4sD0xfQ0R0E1HM/F yaRw== X-Gm-Message-State: AMke39mFVv2rh/M+zCw5APKDTdVUfsHkhDc2aosKAPNnN64bV86Eo2p/SpQMj/KR4FoObVwJ X-Received: by 10.28.210.139 with SMTP id j133mr8514856wmg.67.1487175195152; Wed, 15 Feb 2017 08:13:15 -0800 (PST) Received: from mpn-glaptop ([2620:0:105f:fd00:f09e:2be:ab0:bcd7]) by smtp.gmail.com with ESMTPSA id t202sm8074588wmt.28.2017.02.15.08.13.13 for <25677-close@debbugs.gnu.org> (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 15 Feb 2017 08:13:14 -0800 (PST) From: Michal Nazarewicz To: 25677-close@debbugs.gnu.org Subject: Re: [PATCH 01/22] oldXMenu: add missing #include In-Reply-To: <20170210181637.15565-1-mina86@mina86.com> Organization: http://mina86.com/ References: <20170210181637.15565-1-mina86@mina86.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/26.0.50.1 (x86_64-unknown-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix, O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:170215:bug-gnu-emacs@gnu.org::RV3oVfp7jTMyOY3g:00000000000000000000000000000000000000000rUB Date: Wed, 15 Feb 2017 17:13:13 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25677-close X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Fri, Feb 10 2017, Michal Nazarewicz wrote: > Some of the files in oldXMenu use functions from string.h without > including that header which results in compile warnings: > > ChgPane.c:46:5: warning: implicit declaration of function =E2=80=98strle= n=E2=80=99 > ChgPane.c:46:20: warning: incompatible implicit declaration of > built-in function =E2=80=98strlen=E2=80=99 > ChgSel.c:62:2: warning: implicit declaration of function =E2=80=98strlen= =E2=80=99 > ChgSel.c:62:17: warning: incompatible implicit declaration of built-in > function =E2=80=98strlen=E2=80=99 > Create.c:220:5: warning: implicit declaration of function =E2=80=98strcm= p=E2=80=99 > InsPane.c:65:5: warning: implicit declaration of function =E2=80=98strle= n=E2=80=99 > InsPane.c:65:20: warning: incompatible implicit declaration of > built-in function =E2=80=98strlen=E2=80=99 > InsSel.c:68:5: warning: implicit declaration of function =E2=80=98strlen= =E2=80=99 > InsSel.c:68:20: warning: incompatible implicit declaration of built-in > function =E2=80=98strlen=E2=80=99 > InsSel.c:75:5: warning: implicit declaration of function =E2=80=98strcmp= =E2=80=99 > > Add the necessary =E2=80=98#include =E2=80=99. > > oldXMenu/ChgPane.c, oldXMenu/ChgSel.c, oldXMenu/Create.c, oldXMenu/InsPan= e.c, > oldXMenu/InsSel.c: add missing #include Pushed. > --- > oldXMenu/ChgPane.c | 1 + > oldXMenu/ChgSel.c | 1 + > oldXMenu/Create.c | 1 + > oldXMenu/InsPane.c | 1 + > oldXMenu/InsSel.c | 1 + > 5 files changed, 5 insertions(+) > > Unless there are some objections I=E2=80=99ll commit this in a few days. > > diff --git a/oldXMenu/ChgPane.c b/oldXMenu/ChgPane.c > index d2977b73faf..733f65950f5 100644 > --- a/oldXMenu/ChgPane.c > +++ b/oldXMenu/ChgPane.c > @@ -14,6 +14,7 @@ > */ >=20=20 > #include "XMenuInt.h" > +#include >=20=20 > int > XMenuChangePane(register XMenu *menu, register int p_num, char *label) > diff --git a/oldXMenu/ChgSel.c b/oldXMenu/ChgSel.c > index d24e61f56d5..5a46b5cf587 100644 > --- a/oldXMenu/ChgSel.c > +++ b/oldXMenu/ChgSel.c > @@ -14,6 +14,7 @@ > */ >=20=20 > #include "XMenuInt.h" > +#include >=20=20 > int > XMenuChangeSelection(Display *display, register XMenu *menu, register in= t p_num, register int s_num, char *data, int data_sw, char *label, int labe= l_sw) > diff --git a/oldXMenu/Create.c b/oldXMenu/Create.c > index 0e72a2d2e58..a0913685365 100644 > --- a/oldXMenu/Create.c > +++ b/oldXMenu/Create.c > @@ -31,6 +31,7 @@ along with this program. If not, see . */ >=20=20 > #include "XMenuInt.h" > #include > +#include >=20=20 > #ifdef EMACS_BITMAP_FILES > #include "../src/bitmaps/dimple1.xbm" > diff --git a/oldXMenu/InsPane.c b/oldXMenu/InsPane.c > index d8470f3a5bf..da92f49aa77 100644 > --- a/oldXMenu/InsPane.c > +++ b/oldXMenu/InsPane.c > @@ -15,6 +15,7 @@ > */ >=20=20 > #include "XMenuInt.h" > +#include >=20=20 > int > XMenuInsertPane(register XMenu *menu, register int p_num, char *label, i= nt active) > diff --git a/oldXMenu/InsSel.c b/oldXMenu/InsSel.c > index 66f4968197d..f5380437958 100644 > --- a/oldXMenu/InsSel.c > +++ b/oldXMenu/InsSel.c > @@ -14,6 +14,7 @@ > */ >=20=20 > #include "XMenuInt.h" > +#include >=20=20 > int > XMenuInsertSelection(register XMenu *menu, register int p_num, register = int s_num, char *data, char *label, int active) > --=20 > 2.11.0.483.g087da7b7c-goog > --=20 Best regards =E3=83=9F=E3=83=8F=E3=82=A6 =E2=80=9C=F0=9D=93=B6=F0=9D=93=B2=F0=9D=93=B7= =F0=9D=93=AA86=E2=80=9D =E3=83=8A=E3=82=B6=E3=83=AC=E3=83=B4=E3=82=A4=E3=83= =84 =C2=ABIf at first you don=E2=80=99t succeed, give up skydiving=C2=BB From unknown Sun Jun 22 17:11:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 16 Mar 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator