From unknown Tue Jun 24 22:34:25 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#25656 <25656@debbugs.gnu.org> To: bug#25656 <25656@debbugs.gnu.org> Subject: Status: 25.1; remember-notes-mode makes every temporary buffer created from it unkillable Reply-To: bug#25656 <25656@debbugs.gnu.org> Date: Wed, 25 Jun 2025 05:34:25 +0000 retitle 25656 25.1; remember-notes-mode makes every temporary buffer create= d from it unkillable reassign 25656 emacs submitter 25656 Vasilij Schneidermann severity 25656 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 08 18:12:45 2017 Received: (at submit) by debbugs.gnu.org; 8 Feb 2017 23:12:45 +0000 Received: from localhost ([127.0.0.1]:60615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbbPp-00030i-DM for submit@debbugs.gnu.org; Wed, 08 Feb 2017 18:12:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbbPn-00030V-2m for submit@debbugs.gnu.org; Wed, 08 Feb 2017 18:12:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbbPh-0004Ap-1v for submit@debbugs.gnu.org; Wed, 08 Feb 2017 18:12:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50353) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cbbPg-0004Ac-W8 for submit@debbugs.gnu.org; Wed, 08 Feb 2017 18:12:37 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbbPg-00063Z-3p for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 18:12:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbbPf-0004A6-8t for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 18:12:36 -0500 Received: from mail-ot0-x22b.google.com ([2607:f8b0:4003:c0f::22b]:34044) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cbbPf-00049k-4x for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 18:12:35 -0500 Received: by mail-ot0-x22b.google.com with SMTP id f9so117913otd.1 for ; Wed, 08 Feb 2017 15:12:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=uPn6ikWzLqGxFPHzxVIswB8JXEt/3yGC9EOMU66FEp8=; b=tedLg6wcqe+yXzXNsvESzjP2iljIruXeJ9fLgELYz+SaWm80M63yUCgd55EA3/CRqZ xzR5wXnkHa4mLBfp0OSPk9GxbJ1bzEoHpVAVYMt6Ic8XJhf+/CuWn2LWgRupU0HKPaGq jqKxo0LqK0w+HRsBlL6tu9GUvAmwUMrOkoK7VL2BWUwLYV7vM5K62ukc1x8Lpsi2l5W0 HeasPzdJQEujQgpxNfngwIaYKAQGrwdIcmHP3nEkWczPRvSOoy8mbhzsJvRnv1+4XYA7 fkn1fwj7EneYTyEFGkHOxYJklG4UVbyxCj0UIU7S3pQvcA9kKTR3MprefOF+MQMcJ7kx bROA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=uPn6ikWzLqGxFPHzxVIswB8JXEt/3yGC9EOMU66FEp8=; b=IGu3nt13KwaG82CNrtT9tywGi804wSB0/kNMvtxpmIy+HX8eFz4GqFJ8v53hdZnBE+ 8seSRHBgGbHiVpUkTZE0TR6Wc2wl//0AEA6Q+OWhICw2cN4UEndAsKqbu/iIGs4g7LZG RMHZdgkVoZEVkxAAnblHSJvvRj9oib88+bRXO8/hBz3z2xpYoRQ+7YuH1z2tzYpTuJ6d 43rtUQ/pPnJ1AGqwos0//CZVMlVk8zQyY8KW83IbdPe3TppwXOdT3j2i9Sr5f1SCgcyZ czGGyV3S109FHA/uOW0qjbSXm2lUUH5fWyi7x43tMpL7VOxn7e0NZ1x22ErOEqTQQsPx Ym5A== X-Gm-Message-State: AMke39kMwnbj8OlKrEgjq0dZkfOTYyl9K9oQr1eRyYnKkTIt0SCyXgRu8IcYaAFso6DfFfm6L9Q57ou1LQHTVA== X-Received: by 10.157.29.251 with SMTP id w56mr24726otw.13.1486595552698; Wed, 08 Feb 2017 15:12:32 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.0.34 with HTTP; Wed, 8 Feb 2017 15:12:32 -0800 (PST) From: Vasilij Schneidermann Date: Thu, 9 Feb 2017 00:12:32 +0100 Message-ID: Subject: 25.1; remember-notes-mode makes every temporary buffer created from it unkillable To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) I wrote an Emacs package that takes an Org file, processes it with Org's element API and exports to a file. Later I've noticed that if I use it on an Org buffer created with remember-notes-mode, it creates ~500 temporary buffers that cannot be killed. Bisection reveals that this is the fault of `remember-notes--kill-buffer-query` which is added locally to `kill-buffer-query-functions` and returns nil if `remember-notes-bury-on-kill` hasn't been customized. This raises an interesting question, should a temporary buffer as created by `with-temp-buffer` let-bind potentially troublesome hooks including, but not limited to `kill-buffer-query-functions`? Another example coming to mind is `buffer-list-update-hook`, adding a function to it that scans the buffer list makes creating and killing temporary buffers an expensive action. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 24 02:40:44 2017 Received: (at 25656) by debbugs.gnu.org; 24 Feb 2017 07:40:44 +0000 Received: from localhost ([127.0.0.1]:53486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chAUe-0007n8-86 for submit@debbugs.gnu.org; Fri, 24 Feb 2017 02:40:44 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:36537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chAUc-0007mW-W0 for 25656@debbugs.gnu.org; Fri, 24 Feb 2017 02:40:43 -0500 Received: by mail-wr0-f196.google.com with SMTP id o22so374737wro.3 for <25656@debbugs.gnu.org>; Thu, 23 Feb 2017 23:40:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QUmhdb2JlgTAFuzoQMUWDadtBh3UY5ylScxN4IpArJQ=; b=N/9UUry1EXCDxOigVwIRyhRWeUHioc0MFxSkLzFAbdt4A5gv4rw58qir5Pg1vgDM/P 0OnJstrMbheWUwnBw5x4+Xe1dK9BIp8n6ljM8l6TWw6ThTDO7ZNGqMxIl+VYHYv4nIvg AxGZSPR2HD+1Cw2RzM8hhL/igMkm9mgCoKZSa+qtokfbnqjIwzpCThTHlxINMkxLmbDk jdMNUbj8nwgJNandHRMVJ9iWRjXT/MN+iDyJjYpYGzPTwGi6vcYrLo+K2W6B37dLMiiu jJMnmlKsE69yDeC7kMDlAovp7CKggTh0j21iGhzIVRkn84SyGPoKZ5O65Sx3kTHLhn5v NS5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QUmhdb2JlgTAFuzoQMUWDadtBh3UY5ylScxN4IpArJQ=; b=kaKtF8KzwlEG0XOLQK02rdZfQ3cjTg6sXl5pyU7i9lPnGWCxemnoYqP5WPvZXinAQ/ BzCQyBCncQah+VJR2bS7rVF3eJGMODbDTpUGgGYxzNFk3vkgX/3uA1w2ub915OzkoyxV jxtxY9+uFJTX3USm3fc2CSIdbyjjoGI1/TsCwgA1htAmJlWG5tkQkui/g/MFw71e4VqK T5foi1bJSFliuvmJXx/UlLsBkqWuf1LN+A5myLlhjkq3JhcRQMEYcQyt3PDmXhg7iGo0 cKXgfocczsCaVIChFsxesgPq6L6FtdtdcN6QZksmP9IUgJJArBsLrdNWnrofUWAy2s9G UR5w== X-Gm-Message-State: AMke39nF+yNPp2uU6bKZtAFw3vRMcMFQSvsYIzbBEpcgNnqv9VWYCemNW62fPeAl5mubAA== X-Received: by 10.223.156.2 with SMTP id f2mr1341162wrc.4.1487922036753; Thu, 23 Feb 2017 23:40:36 -0800 (PST) Received: from localhost (dslb-092-072-006-155.092.072.pools.vodafone-ip.de. [92.72.6.155]) by smtp.gmail.com with ESMTPSA id 96sm9207592wrb.14.2017.02.23.23.40.35 for <25656@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Feb 2017 23:40:35 -0800 (PST) Date: Fri, 24 Feb 2017 08:40:34 +0100 From: Vasilij Schneidermann Subject: Re: [PATCH] 25.1; remember-notes-mode makes every temporary buffer created from it unkillable Message-ID: <20170224074034.GA615@odonien.localdomain> References: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="17pEHd4RhPHOinZp" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I wrote a simple patch for merely checking whether the buffer about to be killed happens to be the remember-notes buffer. From b1f95cf53fdb3574525f3644df668f357405f4a1 Mon Sep 17 00:00:00 2001 From: Vasilij Schneidermann Date: Fri, 24 Feb 2017 08:36:38 +0100 Subject: [PATCH] Make only remember-notes buffer unkillable [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [209.85.128.196 listed in dnsbl.sorbs.net] -0.6 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.196 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 1.2 MISSING_HEADERS Missing To: header 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (v.schneidermann[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.128.196 listed in list.dnswl.org] 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: 25656 Cc: 25656@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I wrote a simple patch for merely checking whether the buffer about to be killed happens to be the remember-notes buffer. From b1f95cf53fdb3574525f3644df668f357405f4a1 Mon Sep 17 00:00:00 2001 From: Vasilij Schneidermann Date: Fri, 24 Feb 2017 08:36:38 +0100 Subject: [PATCH] Make only remember-notes buffer unkillable [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.6 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.196 listed in wl.mailspike.net] 0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [209.85.128.196 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.128.196 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 1.2 MISSING_HEADERS Missing To: header 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (v.schneidermann[at]gmail.com) 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid --17pEHd4RhPHOinZp Content-Type: text/plain; charset=utf-8 Content-Disposition: inline I wrote a simple patch for merely checking whether the buffer about to be killed happens to be the remember-notes buffer. --17pEHd4RhPHOinZp Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="0001-Make-only-remember-notes-buffer-unkillable.patch" >From b1f95cf53fdb3574525f3644df668f357405f4a1 Mon Sep 17 00:00:00 2001 From: Vasilij Schneidermann Date: Fri, 24 Feb 2017 08:36:38 +0100 Subject: [PATCH] Make only remember-notes buffer unkillable * remember.el (remember-notes--kill-buffer-query): Check whether buffer to be killed is the remember-notes buffer --- lisp/textmodes/remember.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/textmodes/remember.el b/lisp/textmodes/remember.el index 388e49cfdc..a217357471 100644 --- a/lisp/textmodes/remember.el +++ b/lisp/textmodes/remember.el @@ -649,7 +649,8 @@ Save the current buffer if modified. If `remember-notes-bury-on-kill' is non-nil, bury it and return nil; otherwise return t." (when (buffer-modified-p) (save-buffer)) - (if remember-notes-bury-on-kill + (if (and remember-notes-bury-on-kill + (equal (buffer-name (current-buffer)) remember-notes-buffer-name)) (progn ;; bury-buffer always returns nil, but let's be explicit. (bury-buffer) -- 2.11.0 --17pEHd4RhPHOinZp-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 24 20:14:57 2017 Received: (at 25656) by debbugs.gnu.org; 25 Feb 2017 01:14:57 +0000 Received: from localhost ([127.0.0.1]:55033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chQwr-0001Tp-GV for submit@debbugs.gnu.org; Fri, 24 Feb 2017 20:14:57 -0500 Received: from mail-it0-f46.google.com ([209.85.214.46]:35865) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chQwo-0001Tb-SK for 25656@debbugs.gnu.org; Fri, 24 Feb 2017 20:14:55 -0500 Received: by mail-it0-f46.google.com with SMTP id h10so34597335ith.1 for <25656@debbugs.gnu.org>; Fri, 24 Feb 2017 17:14:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jr0gWQMJyIEG8oM860+maLaZ6IjXrMgqp8xraCf772k=; b=bYtre68rNhENG0DhUza5lqQDuQf7AsiW8wrSuVxwkg883CaINu91yHF/ZMjbiP2/N7 0+eOFcUYZwDI/ixHHnP+jK3pg27TBQ7U9q8/JgZVWModAes1OoiUF8RZxoWpES8ivzHl mF1+LqhYZ9LSpVgOKmyoigMaHNtFplHeVICAaIYsLe0Fez4aRNbU6atTxbTBczK3khBA NTl4KBAVpcq4iCpuPGgaR6wFOa6rIdVgk1AZzECrGlIWM1+mPGVZWvesUptV7MxEh/RF zFRk5JUndwmgLQCwwcLfZn+FKK6ijRZQF6fZXBspikKObnmN3GBKlePM4SuKw2Us8Is8 uZIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=jr0gWQMJyIEG8oM860+maLaZ6IjXrMgqp8xraCf772k=; b=Ptmp9TTxVmkNyrwdloD1uOXhhiJtsQpJy6yGbyDvUsaE2WjR4M+/KJkaQ8EWuMFnIW G5HrDRJjQSaUlrP8V/KCY/IS0wmCw4MhAFFw3WThMww3/fMJecE8hGBs2l9RAYS9AynS 0KdxdCXPIXsKNjRp+fnjZkap7hGcpCaNIUQRjP5I0gv4x8TqfirqG1LeWDcdDtTV3D2G /PUnMY+ZYw0NgfFjrT0tle+EkpuYzAcZad/3nS4p2OG12zKAaa3/H1pHgqgUjxbd+xFa uk2veenOAajGbLcR01euxt7zvnvW4XrmJcEvxu+1egfL5kMXJLV4PcFR0QitGt9FM/CC xczw== X-Gm-Message-State: AMke39lo9m79OVpe5c+z/XuwClrkjYoLcMQvmuMhtfev+ayv83UHpttwpjmpv8aKBrPiaw== X-Received: by 10.36.67.133 with SMTP id s127mr5502684itb.57.1487985289417; Fri, 24 Feb 2017 17:14:49 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id j14sm1472867itd.0.2017.02.24.17.14.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Feb 2017 17:14:48 -0800 (PST) From: npostavs@users.sourceforge.net To: Vasilij Schneidermann Subject: Re: bug#25656: [PATCH] 25.1; remember-notes-mode makes every temporary buffer created from it unkillable References: <20170224074034.GA615@odonien.localdomain> Date: Fri, 24 Feb 2017 20:16:02 -0500 In-Reply-To: <20170224074034.GA615@odonien.localdomain> (Vasilij Schneidermann's message of "Fri, 24 Feb 2017 08:40:34 +0100") Message-ID: <87innzf4tp.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25656 Cc: 25656@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Vasilij Schneidermann writes: > I wrote a simple patch for merely checking whether the buffer about to > be killed happens to be the remember-notes buffer. I think that's a sensible change, but doesn't the fact that remember-mode adds the hook buffer-locally mean that temp buffers (or any other buffers) aren't affected? (add-hook 'kill-buffer-query-functions 'XXXX nil t) (with-temp-buffer kill-buffer-query-functions) ;=> (process-kill-buffer-query-function) From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 25 04:47:19 2017 Received: (at 25656) by debbugs.gnu.org; 25 Feb 2017 09:47:19 +0000 Received: from localhost ([127.0.0.1]:55182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chYwh-0006EJ-Iw for submit@debbugs.gnu.org; Sat, 25 Feb 2017 04:47:19 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chYwg-0006E6-G7 for 25656@debbugs.gnu.org; Sat, 25 Feb 2017 04:47:18 -0500 Received: by mail-wm0-f66.google.com with SMTP id r18so6255004wmd.3 for <25656@debbugs.gnu.org>; Sat, 25 Feb 2017 01:47:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Qq2fRO+kw0UtHetRtm8s+bUARt/DXruztS7X4WuNaHA=; b=qxMNLnu8zR6skWEZMcVmqj1rD1dPSRi3F/7kQGbNdU69BhTHPYZ/HXgATRrvMX3JHX 8vfKrhR9v1/L7lJi+3KDRIgpJVaIysc19P7g3eSZss5oICDv+dBLL4Svt4X8XmNt14Zb vei0T3QbcxoXlXxNp1IswPo6L8X1phwbShAFBoywcWxsZTs4RhTwgRYvGjtbD+ZuzoSv o+Ls6KF6ia8mGOExFoDlkY/+R6hwgmiUuHaCCe1HyGqqJwZ4v9jwXwNeVUEJeRaURTag 9qB0LiC86P6196EQ3dDPDvvysS+RdroN+v291LgaVoDzdhUl9oEbBBZw0mzNOo0qKQ9Q 7WkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Qq2fRO+kw0UtHetRtm8s+bUARt/DXruztS7X4WuNaHA=; b=TuDYim8NxLcHKquDkA3LuICam4MA2fDtQopKrKKAkENv6zI2zYi1sCFha5NPuTDsWl NCfh2dUxrV6VkNq7ZoaB67cMwOk2aMiJ+If3T5v125NNR77wBDEAWejOT+13jcec6PO0 f4mBHXWrjPZuxW7OxvpbPr70nXPtkQTTHsaPRy0BmWB/gk6bD8CjiVhc6r2wl3qZjqWj 1HyPcQcVHk15FmpPmkti4dK30EWwRewiVzX18DsmD57Naei05lTpa+kJnkMYRjuR/b4v k80GgmDFwE8kzA4NXXIhoZ9rdYRMo+4llSPPzIWsM2dG5TvDKIluvUZ2LG69iHxjNHiw +O4w== X-Gm-Message-State: AMke39kZSKdsgbxx0hFBRFAI9jpwb3twvMzmJQW/a3BRUB2Q8d38s8QnGGtUqhJqaNealA== X-Received: by 10.28.142.73 with SMTP id q70mr6470880wmd.3.1488016032771; Sat, 25 Feb 2017 01:47:12 -0800 (PST) Received: from localhost (dslb-088-078-197-190.088.078.pools.vodafone-ip.de. [88.78.197.190]) by smtp.gmail.com with ESMTPSA id 40sm13713928wry.22.2017.02.25.01.47.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 Feb 2017 01:47:12 -0800 (PST) Date: Sat, 25 Feb 2017 10:47:11 +0100 From: Vasilij Schneidermann To: npostavs@users.sourceforge.net Subject: Re: bug#25656: [PATCH] 25.1; remember-notes-mode makes every temporary buffer created from it unkillable Message-ID: <20170225094711.GA1340@odonien.localdomain> References: <20170224074034.GA615@odonien.localdomain> <87innzf4tp.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87innzf4tp.fsf@users.sourceforge.net> User-Agent: Mutt/1.7.2 (2016-11-26) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25656 Cc: 25656@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) > I think that's a sensible change, but doesn't the fact that > remember-mode adds the hook buffer-locally mean that temp buffers (or > any other buffers) aren't affected? Hm, you're right, I can't repro this with a minimal example. However I'm sure that it has to do something with Org copying buffers and failing to kill them, so I'll investigate a bit harder to see what it could be, outside of its gratuitious use of `with-temp-buffer`. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 25 07:12:58 2017 Received: (at 25656) by debbugs.gnu.org; 25 Feb 2017 12:12:58 +0000 Received: from localhost ([127.0.0.1]:55216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chbDe-00018y-99 for submit@debbugs.gnu.org; Sat, 25 Feb 2017 07:12:58 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:35486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chbDc-00018m-I7 for 25656@debbugs.gnu.org; Sat, 25 Feb 2017 07:12:56 -0500 Received: by mail-wr0-f194.google.com with SMTP id q39so5091315wrb.2 for <25656@debbugs.gnu.org>; Sat, 25 Feb 2017 04:12:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=G0hPXMUChM9f+FEDOUtqelpb66xKS7//uL+9m2jYCjg=; b=tGZNi37KgFMf9vJvwzJxFW5bhXVqfdwoTherQmKQfqRS7kwTWXgYHix6lK4NRL4S9X Ap0xZ3pNMY1vdWk39HYmQPZ/W6+3g9pEwV1po61xZ03mF8fqQb3cvQymy4dx0jbAir0f rLKhqCJ1GjFY8tOtUWeGBFTDbNB0m23AvhJeabFpE4zS1c35bkyiBUxVrO/Zg0lfC/26 7CGem/5BV5NqwQ0EZ/12i/L43ytkpqu9GszpmnWgknjy2bsijQ/TfGKhcCgye5rpDbnB W6CFDDkfG8tGhLINyIYg6rx3HbY8X2rzjNUfUbxUQy7EaL5TC6mAPYNYjHqchLRCJOt8 QUzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=G0hPXMUChM9f+FEDOUtqelpb66xKS7//uL+9m2jYCjg=; b=A34jbno4C1dH0+HpFJXMG4xaXI3HLdyorxaND36b67QtDzN6qYlK+OFdbPGtZKFUcd 5EXjqcjffq6pbpetiHVchx3r3LbwCzCTlbXAf9+yRCail8Dqmwgi/jMB0eeriYBaZd8m rIN9z4cYOmOVR6/hdP1NbzfvpbZoUsgxIQJCo5hP4SLXr08P8E65fTCKlh6Hkwz5/Edl Dafaq2blGMO1vTjcHbc+R/bKiSZ0wKCvw71V4vUlZIgY8N+NVPb6u/L+gIBQTO8ZWXhA J4qncYrhe+K+wO3zKnVfP7PDi248m5Ins2uPJlbUZ8WIrKRMJzO9q9sPqxILdpWsFl5f WvdQ== X-Gm-Message-State: AMke39l73vQrNrQL/lYCrMp93/5tFkU17bXmqLL7CBmN7vW42Ci/tV4RKYUB3E1IluEJaA== X-Received: by 10.223.167.138 with SMTP id j10mr6739117wrc.178.1488024770767; Sat, 25 Feb 2017 04:12:50 -0800 (PST) Received: from localhost (dslb-088-078-197-190.088.078.pools.vodafone-ip.de. [88.78.197.190]) by smtp.gmail.com with ESMTPSA id r6sm6154568wmd.4.2017.02.25.04.12.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 Feb 2017 04:12:50 -0800 (PST) Date: Sat, 25 Feb 2017 13:12:49 +0100 From: Vasilij Schneidermann To: npostavs@users.sourceforge.net Subject: Re: bug#25656: [PATCH] 25.1; remember-notes-mode makes every temporary buffer created from it unkillable Message-ID: <20170225121249.GB669@odonien.localdomain> References: <20170224074034.GA615@odonien.localdomain> <87innzf4tp.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87innzf4tp.fsf@users.sourceforge.net> User-Agent: Mutt/1.7.2 (2016-11-26) X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 25656 Cc: 25656@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) OK, I think I've figured out what's going on. I'm calling a command in a remember-notes buffer that happens to hold an org file. It's set up to be unkillable by having a locally added `kill-buffer-query-functions` hook that returns nil. Now, my command calls a number of things including `org-table-export` which does a zillion of things, eventually cloning the buffer it's working on with the `org-export-with-buffer-copy` macro. This macro is so good at cloning buffers it preserves its buffer-local variables, including `kill-buffer-query-functions`. Although it tries killing the buffer afterwards, it fails doing so because the hook forbids it. The result of this avalanche of failures is that for every table cell, an unkillable buffer is created. The lesson from this is to be careful with using Org's APIs, while some of them look reusable, most aren't. While I could patch `remember-notes--kill-buffer-query` to work around this problem, I'll just customize `remember-notes-bury-on-kill` and raise an issue with Org's bug tracker. Thanks for responding to this, Noam! From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 25 07:15:54 2017 Received: (at 25656-done) by debbugs.gnu.org; 25 Feb 2017 12:15:54 +0000 Received: from localhost ([127.0.0.1]:55224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chbGU-0001Dd-4i for submit@debbugs.gnu.org; Sat, 25 Feb 2017 07:15:54 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:32769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1chbGS-0001DO-M5 for 25656-done@debbugs.gnu.org; Sat, 25 Feb 2017 07:15:52 -0500 Received: by mail-wm0-f67.google.com with SMTP id v77so6644125wmv.0 for <25656-done@debbugs.gnu.org>; Sat, 25 Feb 2017 04:15:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=pmT9wTGLGOcpQAxgPNYRp4Htfchbn02I1Pao7y8s4F4=; b=fEMYjs+gjrPpmaWPOSz3L/W7jajo71jFfTAARYUOAEkUOXezWgYijJ6itbRm7/FRyV uhJs76YRWLUfmPCXjMdPaVjG9iVMMcK0ydWYKoUXdk00FBDI2EhJcfg9gWVLbbfrqOpl 8RoqywjuAFG/hvNvua0Kpfscit29OdE6CaSafKlj9tJ3FXCXiBUvB+9sqEdLUV3+xz/N dBongWU2NnfIehiIvhM2UhdqCTRNUkzACBA+Up9PeCySP76koaY+ePQyvZiF944jva0n ZbU6ThuwoJF9LvATzdsYALF0x10dm4XVMQknTQ0k6Q2LSVBpgkkjkulECDeuIDv4OJJt 9MKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=pmT9wTGLGOcpQAxgPNYRp4Htfchbn02I1Pao7y8s4F4=; b=twceuuCYGTJZU8dXUGv0ne3SjnV/G/ZX9u+AduBuGEHVyi9usmiURfIB8dM6Rz9rza nrQfOR6k5nupynKY1h6fNISWoJRKkQGwjoNipWGxjzvRsHtQdfbvTo/Jgl41+It6ClPg Q2BkrTUIfLbm2no/Z+ggTgxKXsFSIlf2gM0peuvc5thXtWdULlD7TPlWlrvj1WmogkPS Msc6PRhnalRjAKIHs2PP+gKGGOxsvektWgrXOMLEtufVfAo8CjiHcTfjfv9mdLiECIvP wTZ5huBx1zzkBgZU5QsrNhZdW46YX/3fk0sdQ2I7KB0hUMEN8wNISBCK/kVOcrh4hJhm NCkw== X-Gm-Message-State: AMke39laxTpaid73znxXnL5MfmC8GuHexhbdS4YAR1aq2HN3mx2capg2RauQn01Ednvhvw== X-Received: by 10.28.157.67 with SMTP id g64mr6294301wme.111.1488024946968; Sat, 25 Feb 2017 04:15:46 -0800 (PST) Received: from localhost (dslb-088-078-197-190.088.078.pools.vodafone-ip.de. [88.78.197.190]) by smtp.gmail.com with ESMTPSA id j184sm5722296wmd.31.2017.02.25.04.15.46 for <25656-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 Feb 2017 04:15:46 -0800 (PST) Date: Sat, 25 Feb 2017 13:15:45 +0100 From: Vasilij Schneidermann To: 25656-done@debbugs.gnu.org Subject: Re: bug#25656: [PATCH] 25.1; remember-notes-mode makes every temporary buffer created from it unkillable Message-ID: <20170225121545.GC669@odonien.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.7.2 (2016-11-26) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25656-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Bug reason found in Org, resubmitting issue on their bug tracker. From unknown Tue Jun 24 22:34:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 26 Mar 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator