GNU bug report logs - #25631
epiphany: Ad blocker does not work.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25631 in the body.
You can then email your comments to 25631 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: "'bug-guix\@gnu.org'" <bug-guix <at> gnu.org>
Subject: epiphany: Ad blocker does not work.
Date: Mon, 06 Feb 2017 12:02:25 +0100

Epiphany comes with an ad blocker extension that can be enabled in the
settings.  When starting epiphany, however, the following message can be
seen on VT1:

** (WebKitWebProcess:12345): WARNING **: Error retrieving adblock filter: Operation not supported

In fact, Epiphany does not store any filter list anywhere and as a
result no ads are blocked.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #8 received at 25631 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 25631 <at> debbugs.gnu.org
Subject: Re: bug#25631: epiphany: Ad blocker does not work.
Date: Mon, 06 Feb 2017 13:02:42 +0100

“g_file_new_for_uri” triggers the download via dbus, so it must be made
aware of the dbus session.  When running “dbus-launch epiphany” the
error changes to

    ** (WebKitWebProcess:30867): WARNING **: Error retrieving adblock filter: HTTP Error: TLS/SSL support not available; install glib-networking

If I first export the same environment variables (for GIO modules) that
are set in the epiphany wrapper the error disappears:

    guix environment --ad-hoc dbus
    source <(sed $(readlink -f $(which epiphany)) -e "s/exec.*//")
    dbus-launch epiphany

Should we use dbus-launch in the wrapper script or should we ensure
system-wide that after logging in the DBUS_SESSION_BUS_ADDRESS is
exported?

I’m using stumpwm so I don’t know if GNOME usually takes care of this.
Maybe it is sufficient to run “dbus-launch” in .xsession and eval the
variable definitions it generates.

If this is so, should we handle this by default in some global file like
/etc/environment or similar?

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #11 received at 25631 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 25631 <at> debbugs.gnu.org
Subject: Re: bug#25631: epiphany: Ad blocker does not work.
Date: Tue, 07 Feb 2017 05:14:15 -0500

Ricardo Wurmus <rekado <at> elephly.net> writes:

> “g_file_new_for_uri” triggers the download via dbus, so it must be made
> aware of the dbus session.  When running “dbus-launch epiphany” the
> error changes to
>
>     ** (WebKitWebProcess:30867): WARNING **: Error retrieving adblock filter: HTTP Error: TLS/SSL support not available; install glib-networking
>
> If I first export the same environment variables (for GIO modules) that
> are set in the epiphany wrapper the error disappears:
>
>     guix environment --ad-hoc dbus
>     source <(sed $(readlink -f $(which epiphany)) -e "s/exec.*//")
>     dbus-launch epiphany
>
> Should we use dbus-launch in the wrapper script or should we ensure
> system-wide that after logging in the DBUS_SESSION_BUS_ADDRESS is
> exported?
>
> I’m using stumpwm so I don’t know if GNOME usually takes care of this.

It seems that both GNOME and Xfce take care of setting
DBUS_SESSION_BUS_ADDRESS, since that variable is set on both my x86_64
GuixSD system running GNOME and my mips64el GuixSD system running Xfce.

      Mark

Message #14 received at 25631 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Mark H Weaver <mhw <at> netris.org>
Cc: 25631 <at> debbugs.gnu.org
Subject: Re: bug#25631: epiphany: Ad blocker does not work.
Date: Tue, 07 Feb 2017 11:29:18 +0100

Mark H Weaver <mhw <at> netris.org> writes:

> Ricardo Wurmus <rekado <at> elephly.net> writes:
>
[…]
>> Should we use dbus-launch in the wrapper script or should we ensure
>> system-wide that after logging in the DBUS_SESSION_BUS_ADDRESS is
>> exported?
>>
>> I’m using stumpwm so I don’t know if GNOME usually takes care of this.
>
> It seems that both GNOME and Xfce take care of setting
> DBUS_SESSION_BUS_ADDRESS, since that variable is set on both my x86_64
> GuixSD system running GNOME and my mips64el GuixSD system running Xfce.

Thanks for confirming.

Recent versions of systemd’s pam-systemd set DBUS_SESSION_BUS_ADDRESS as
well.  Our version of elogind does not.  I just backported the changes
from systemd 226 to elogind and will test this on my system.

Doing this in pam-elogind would probably be best.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #19 received at 25631-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 25631-done <at> debbugs.gnu.org
Subject: Re: bug#25631: epiphany: Ad blocker does not work.
Date: Wed, 29 Aug 2018 20:19:53 -0400

[Message part 1 (text/plain, inline)]

On Mon, Feb 06, 2017 at 12:02:25PM +0100, Ricardo Wurmus wrote:
> Epiphany comes with an ad blocker extension that can be enabled in the
> settings.  When starting epiphany, however, the following message can be
> seen on VT1:
> 
> ** (WebKitWebProcess:12345): WARNING **: Error retrieving adblock filter: Operation not supported
> 
> In fact, Epiphany does not store any filter list anywhere and as a
> result no ads are blocked.

Epiphany's ad blocker is now working for me on GuixSD with GNOME and a
foreign distro.

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 25631-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 25631-done <at> debbugs.gnu.org
Subject: Re: bug#25631: epiphany: Ad blocker does not work.
Date: Thu, 30 Aug 2018 09:54:36 +0200

Leo Famulari <leo <at> famulari.name> writes:

> On Mon, Feb 06, 2017 at 12:02:25PM +0100, Ricardo Wurmus wrote:
>> Epiphany comes with an ad blocker extension that can be enabled in the
>> settings.  When starting epiphany, however, the following message can be
>> seen on VT1:
>>
>> ** (WebKitWebProcess:12345): WARNING **: Error retrieving adblock filter: Operation not supported
>>
>> In fact, Epiphany does not store any filter list anywhere and as a
>> result no ads are blocked.
>
> Epiphany's ad blocker is now working for me on GuixSD with GNOME and a
> foreign distro.

Yes, it does work in GNOME.  I think I used it in StumpWM when it didn’t
work.  The session was not wrapped in dbus-launch.  Now I’m using EXWM,
which is started within dbus-launch, and the ad blocker does work.

I suspect that the only problem was that DBus wasn’t working properly
when starting StumpWM without the dbus-launch wrapper.  I hope this
information will be helpful to people from the future who find this old
bug report through a web search.

--
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.