From unknown Sat Sep 06 01:11:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25628: 26.0.50; [PATCH] sql-mode w/ sqlite: In-memory database Resent-From: Rolf Ade Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Feb 2017 19:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 25628@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14863221984595 (code B ref -1); Sun, 05 Feb 2017 19:17:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 Feb 2017 19:16:38 +0000 Received: from localhost ([127.0.0.1]:56904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1caSIf-0001C1-SC for submit@debbugs.gnu.org; Sun, 05 Feb 2017 14:16:38 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1caSIe-0001Bo-8d for submit@debbugs.gnu.org; Sun, 05 Feb 2017 14:16:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1caSIY-0007ql-9E for submit@debbugs.gnu.org; Sun, 05 Feb 2017 14:16:31 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42857) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1caSIY-0007qh-6F for submit@debbugs.gnu.org; Sun, 05 Feb 2017 14:16:30 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1caSIX-0006Hj-0w for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2017 14:16:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1caSIT-0007p8-SY for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2017 14:16:29 -0500 Received: from mxout3.interscholz.de ([85.236.196.238]:36726) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1caSIT-0007ox-MO for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2017 14:16:25 -0500 Received: from localhost (mxout3 [127.0.0.1]) by mxout3.interscholz.de (Postfix) with ESMTP id 9D83F274D9 for ; Sun, 5 Feb 2017 20:16:19 +0100 (CET) X-Virus-Scanned: interscholz amavisd-new at mxout3.interscholz.de Received: from server.web01.interscholz.net (server.web01.interscholz.net [85.236.196.138]) by mxout3.interscholz.de (Postfix) with ESMTP id 17BBE21467 for ; Sun, 5 Feb 2017 20:16:19 +0100 (CET) Received: from point (x5d842f34.dyn.telefonica.de [93.132.47.52]) by server.web01.interscholz.net (Postfix) with ESMTPSA id 1E6D4F0001; Sun, 5 Feb 2017 20:16:18 +0100 (CET) From: Rolf Ade Date: Sun, 05 Feb 2017 20:19:04 +0100 Message-ID: <8737fsv42f.fsf@point> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) >From 8ea7a41eab9465bba14349cb948d779748bc9516 Mon Sep 17 00:00:00 2001 From: Rolf Ade Date: Sun, 5 Feb 2017 19:46:24 +0100 Subject: [PATCH] sql-mode w/ sqlite: In-memory database Enable the usage of an in-memory database. Prior to this, sql-mode w/ sqlite could only be used with file databases. * list/progmodes/sql.el (sql-get-login-ext): Don't expand an empty file name provided by the user, but call sub-process sqlite with that, in which case it use an in-memory database. Copyright-paperwork-exempt: yes --- lisp/progmodes/sql.el | 25 ++++++++++++++----------- 1 files changed, 14 insertions(+), 11 deletions(-) diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el index 8868343..634c6b5 100644 --- a/lisp/progmodes/sql.el +++ b/lisp/progmodes/sql.el @@ -2952,17 +2952,20 @@ sql-get-login-ext (use-dialog-box nil)) (cond ((plist-member plist :file) - (expand-file-name - (read-file-name prompt - (file-name-directory last-value) default 'confirm - (file-name-nondirectory last-value) - (when (plist-get plist :file) - `(lambda (f) - (if (not (file-regular-p f)) - t - (string-match - (concat "\\<" ,(plist-get plist :file) "\\>") - (file-name-nondirectory f)))))))) + (let ((file-name + (read-file-name prompt + (file-name-directory last-value) default 'confirm + (file-name-nondirectory last-value) + (when (plist-get plist :file) + `(lambda (f) + (if (not (file-regular-p f)) + t + (string-match + (concat "\\<" ,(plist-get plist :file) "\\>") + (file-name-nondirectory f)))))))) + (if (string= file-name "") + "" + (expand-file-name file-name)))) ((plist-member plist :completion) (completing-read prompt-def (plist-get plist :completion) nil t -- 1.7.3 In GNU Emacs 26.0.50.7 (i686-pc-linux-gnu, GTK+ Version 2.12.9) of 2017-02-04 built on point Repository revision: f6ff7bb1fcd062fe4ebf6c89890524110501583e From unknown Sat Sep 06 01:11:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25628: 26.0.50; [PATCH] sql-mode w/ sqlite: In-memory database Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Mar 2017 13:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Rolf Ade Cc: 25628@debbugs.gnu.org Received: via spool by 25628-submit@debbugs.gnu.org id=B25628.148846166014304 (code B ref 25628); Thu, 02 Mar 2017 13:35:02 +0000 Received: (at 25628) by debbugs.gnu.org; 2 Mar 2017 13:34:20 +0000 Received: from localhost ([127.0.0.1]:35480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjQs7-0003ie-V0 for submit@debbugs.gnu.org; Thu, 02 Mar 2017 08:34:20 -0500 Received: from mail-io0-f181.google.com ([209.85.223.181]:33951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjQs6-0003iQ-FY for 25628@debbugs.gnu.org; Thu, 02 Mar 2017 08:34:19 -0500 Received: by mail-io0-f181.google.com with SMTP id 90so53025576ios.1 for <25628@debbugs.gnu.org>; Thu, 02 Mar 2017 05:34:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=bfRaxeGIBi1BrFuw73tuHoHUZ16GOCJTB/ErKbiDmWk=; b=s9JXVy7Y7KxrFBwQjtQ6TUm3XyjPJEXxIUKq1hJi49pxGTRh/PEB4Fcb2YcG26AYcA GEQgOghbKvgU2H7qzsl2O9xM/qEbV11n30o9jM6qEIcXnFhOS7nSqVvKov0PLiiHAx4E JMfdjWyq0B7gdu7mFMkhKRYEx8hrYd0KjNl1oqsnsi5CNo4gFW/GpF7LI3idqpogDMjd 0S3olQbFwDmCbSy+ywxKYjBjMYueFVzlAGTyd10lzlzyRIOq6KG9ZUtP7ZtAhMkQ1lGg k6i3RDStPXTxzb4crxoYhkRtMmDNeBOowrDWqPc9oglf/OAKv6mB1pWTzRa6N9KStkfS IlLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=bfRaxeGIBi1BrFuw73tuHoHUZ16GOCJTB/ErKbiDmWk=; b=nhq28d0pDMyL4qdMAX33hHtd1N2yplSaAcA+u6l3xqNfxSCO5b0ylaPQkYTNz7qAyD +8zFRwmhc6Ge0wXhJdKloZs2Hf2/RZBHo8cQIPpJ5HLHnQSJFRRMf5uYsDHBmSRW8mDD MDNALIre6eokuPB1P+U0Hrdo+x9KiVyyl3qSmHhTdUaXC6hWojQGCk9fuTzXu/3UiVcB RCSZwTzho8u1YDloesv/GpspUNVLt6xzhm5De/tKi31xl3wVqj0gg0OEHHdoRyl+d2GF fYj1y08P4TftuV3NguLcyYdulV2T7L3ctyd0WBa5TNbmgtp1va1I5rhx5hiIlBtp2UZK l2hQ== X-Gm-Message-State: AMke39l0FS5JZI1+gtjgYIeRbT4/UE8Ru/avSRGsBcyoROkVZ9rT6IR4Ms8JAt5t3I9+dA== X-Received: by 10.107.146.198 with SMTP id u189mr6677018iod.173.1488461652724; Thu, 02 Mar 2017 05:34:12 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id h143sm3430905ith.1.2017.03.02.05.34.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Mar 2017 05:34:11 -0800 (PST) From: npostavs@users.sourceforge.net References: <8737fsv42f.fsf@point> Date: Thu, 02 Mar 2017 08:35:25 -0500 In-Reply-To: <8737fsv42f.fsf@point> (Rolf Ade's message of "Sun, 05 Feb 2017 20:19:04 +0100") Message-ID: <87fuivby3m.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) > From: Rolf Ade > Date: Sun, 5 Feb 2017 19:46:24 +0100 > Subject: [PATCH] sql-mode w/ sqlite: In-memory database > > Enable the usage of an in-memory database. Prior to this, sql-mode w/ > sqlite could only be used with file databases. > * list/progmodes/sql.el (sql-get-login-ext): Don't expand an empty > file name provided by the user, but call sub-process sqlite with that, > in which case it use an in-memory database. Could this potentially cause problems for users of a non-sqlite database? From unknown Sat Sep 06 01:11:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25628: 26.0.50; [PATCH] sql-mode w/ sqlite: In-memory database Resent-From: rolf@linux-qg7d.i-did-not-set--mail-host-address--so-tickle-me Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Mar 2017 16:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: npostavs@users.sourceforge.net Cc: 25628@debbugs.gnu.org Received: via spool by 25628-submit@debbugs.gnu.org id=B25628.14884738371744 (code B ref 25628); Thu, 02 Mar 2017 16:58:02 +0000 Received: (at 25628) by debbugs.gnu.org; 2 Mar 2017 16:57:17 +0000 Received: from localhost ([127.0.0.1]:36769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjU2X-0000S1-H7 for submit@debbugs.gnu.org; Thu, 02 Mar 2017 11:57:17 -0500 Received: from mxout3.interscholz.de ([85.236.196.238]:45641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjU1R-0000Ps-Kg for 25628@debbugs.gnu.org; Thu, 02 Mar 2017 11:56:10 -0500 Received: from localhost (mxout3 [127.0.0.1]) by mxout3.interscholz.de (Postfix) with ESMTP id CA99122034; Thu, 2 Mar 2017 17:56:06 +0100 (CET) X-Virus-Scanned: interscholz amavisd-new at mxout3.interscholz.de Received: from server.web01.interscholz.net (server.web01.interscholz.net [85.236.196.138]) by mxout3.interscholz.de (Postfix) with ESMTP id 112FE20C2A; Thu, 2 Mar 2017 17:56:06 +0100 (CET) Received: from linux-qg7d (p4FFBEF81.dip0.t-ipconnect.de [79.251.239.129]) by server.web01.interscholz.net (Postfix) with ESMTPSA id 6F9D434025D; Thu, 2 Mar 2017 17:56:02 +0100 (CET) From: rolf@linux-qg7d.i-did-not-set--mail-host-address--so-tickle-me In-Reply-To: <87fuivby3m.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Thu, 02 Mar 2017 08:35:25 -0500") References: <8737fsv42f.fsf@point> <87fuivby3m.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Date: Thu, 02 Mar 2017 17:56:01 +0100 Message-ID: <87d1dzsjmm.fsf@pointsman.de> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.3 (/) X-Mailman-Approved-At: Thu, 02 Mar 2017 11:57:16 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Am 03/02/2017 02:35 PM, npostavs@users.sourceforge.net wrote: > >> From: Rolf Ade Date: Sun, 5 Feb 2017 19:46:24 >> +0100 Subject: [PATCH] sql-mode w/ sqlite: In-memory database >> >> Enable the usage of an in-memory database. Prior to this, sql-mode >> w/ sqlite could only be used with file databases. * >> list/progmodes/sql.el (sql-get-login-ext): Don't expand an empty >> file name provided by the user, but call sub-process sqlite with >> that, in which case it use an in-memory database. > > Could this potentially cause problems for users of a non-sqlite > database? "Impossible" is a strong word and therefor I'm shy to use it, but it comes really close to that. To start with: The product "sqlite" is the only product of the currently supported db engines, that use the :file property by default. In theory, a user could have customized another product to use the :file property for the login parameters, but even after thinking about this (again) for a few minutes I don't see, how this could make sense (they are client/server db systems). But even then: my patch changes only one special case - the user enters the empty string on the read-file-name prompt - and for every other input everything still is, as it was. And this one single case, that is altered by my patch, wasn't a resonable input even after the changes of #23566. But an even stronger argument is: Prior to the unreleased changes from #23566 it was in fact impossible (without changing the source file or effectively replace this part of the implementation with something else by advice overwrite), to enter the empty string on the read-file-name prompt (because of the third argument to the read-file-name parameters). Thanks for taking care. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 02 19:11:01 2017 Received: (at control) by debbugs.gnu.org; 3 Mar 2017 00:11:01 +0000 Received: from localhost ([127.0.0.1]:37138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjaoH-0006LB-0k for submit@debbugs.gnu.org; Thu, 02 Mar 2017 19:11:01 -0500 Received: from mail-it0-f66.google.com ([209.85.214.66]:32969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjaoE-0006Ku-QF; Thu, 02 Mar 2017 19:10:59 -0500 Received: by mail-it0-f66.google.com with SMTP id 68so716773itg.0; Thu, 02 Mar 2017 16:10:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=QnNOzECK2KyAxwU8ImUA2PDrOHG4FnwlNYFBb4IgA0I=; b=Y42XIA0KR/hxdvtu/XPqkrNkeqH5yZJxpko+MX6xr8n/ieoX9skh+iawwGGClBT5xp cwxQnbrlEKTfdxyaUMd/yAKmHivbfeTSY00VkC2jg/aRG8y+UNpGP0UmA/bMZlZ2qH0J 5dvqc31ZAA0KwaITs8lQNL/Dz8KkG2ST/46rtdSpgJvbadDJ0F1sk/+AoYEyt9RvSXAR WJHDZpzbCjYaSmTZxQyRy1dA2GrHGcsjUSJo0JHEIHcnw6wNpvC1heALo6r2NqpgJRVy uGR9OMCzCaulux/Yp9DQsgYC+0NzZ/GfcOMdKwaPTrjKgiZB1cRK6b7uwzH1C6CBfeKJ G/Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=QnNOzECK2KyAxwU8ImUA2PDrOHG4FnwlNYFBb4IgA0I=; b=QmJ75j9SI8iLsvJw5Vq6dIxyr+sOQhsShMi9c5xEKuqQIq9ICZ9XA3YrGqHngJJZ/e mqO4fJw/41xc7br+rSrd4UQjp3NM3clzO0cNT9JsWYic2wOrDqpgGfWl5hLnf++twPJz LNhigV1/7RNosvl9GK9GDojie12H++O0hPjPz/G1ApXjkO+jRfp5eOm4JQ7vcyW55frr ffNExQen7RHzYOrX/wYbiSONfkd7/+bO+EQUwXGtUnesbmwxEvGEHcw26pHeJe9WEdZq 8bu9t3TBLFZIOHZbM490FMivG9m5rjgRuhxeyn2CTso8IthXZYQ5f8utDETEd4NmzpUa 36fg== X-Gm-Message-State: AMke39m3aVnzvRl8Luo4EWnAHgth4iNRN60DoTU9hvJdfeObu6WeHYUCt74NOJhUS052Fg== X-Received: by 10.36.122.208 with SMTP id a199mr503124itc.74.1488499853221; Thu, 02 Mar 2017 16:10:53 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 62sm1363717itl.1.2017.03.02.16.10.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Mar 2017 16:10:52 -0800 (PST) From: npostavs@users.sourceforge.net To: Subject: Re: bug#25628: 26.0.50; [PATCH] sql-mode w/ sqlite: In-memory database References: <8737fsv42f.fsf@point> <87fuivby3m.fsf@users.sourceforge.net> <87d1dzsjmm.fsf@pointsman.de> Date: Thu, 02 Mar 2017 19:12:06 -0500 In-Reply-To: <87d1dzsjmm.fsf@pointsman.de> (rolf@linux-qg7d.i-did-not-set--mail-host-address--so-tickle-me's message of "Thu, 02 Mar 2017 17:56:01 +0100") Message-ID: <878tonb4mh.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: control Cc: 25628@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) tags 25628 fixed close 25628 26.1 quit Okay, sounds reasonable, pushed to master [1: 71871670c8]. 1: 2017-03-02 19:01:18 -0500 71871670c816f2ecc4383ef0fe516cbd9c9f781f sql-mode w/ sqlite: In-memory database