From unknown Sun Aug 17 06:57:12 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#25612 <25612@debbugs.gnu.org> To: bug#25612 <25612@debbugs.gnu.org> Subject: Status: 26.0.50; Slightly suboptimal message for disabled commands Reply-To: bug#25612 <25612@debbugs.gnu.org> Date: Sun, 17 Aug 2025 13:57:12 +0000 retitle 25612 26.0.50; Slightly suboptimal message for disabled commands reassign 25612 emacs submitter 25612 Philipp Stephani severity 25612 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 03 07:34:27 2017 Received: (at submit) by debbugs.gnu.org; 3 Feb 2017 12:34:28 +0000 Received: from localhost ([127.0.0.1]:54536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZd4N-0002Yo-LM for submit@debbugs.gnu.org; Fri, 03 Feb 2017 07:34:27 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39277) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZd4L-0002Ya-6K for submit@debbugs.gnu.org; Fri, 03 Feb 2017 07:34:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZd4E-0002Kn-W1 for submit@debbugs.gnu.org; Fri, 03 Feb 2017 07:34:20 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58917) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cZd4E-0002Kf-Si for submit@debbugs.gnu.org; Fri, 03 Feb 2017 07:34:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZd4D-0003KO-Hz for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2017 07:34:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZd49-0002Gw-S2 for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2017 07:34:15 -0500 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:32977) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cZd49-0002G8-L0 for bug-gnu-emacs@gnu.org; Fri, 03 Feb 2017 07:34:13 -0500 Received: by mail-wm0-x231.google.com with SMTP id t18so14332049wmt.0 for ; Fri, 03 Feb 2017 04:34:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=mDtm9Tsje8G98V4WADvDpEKomjYW8tHkUwTbidc/CFw=; b=uVNqUg8geVA8JkT+aj//QeALw8+FiJiICPrcZkbs0LrZI+7831wRBWwwykNTG72wcn CdqdquXwFGGjtOLLtWsKuEkCgZPwY0NnwdtBoAt/rtcstj2LFt1R6KSPbgfAB/ISExy7 TZXpGcAvkJ/wv95BfzaF1mcATRj+o3dMhTy6m30NaJVbx1imtNoGeGMQK9965quy6yKU vVbo3jEJNOGiAiYl38OMc3BLsabIxMXYaXxqgUXsMiH/LK0QqGbi4NI8+j7kuT+GTIN6 8ZPU2qdaCIsAvij9ZIOrfd/zRnSxcXvyiRVc87De5qq/B8xFf0I76gwOCZk30uTD8a4k wtXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=mDtm9Tsje8G98V4WADvDpEKomjYW8tHkUwTbidc/CFw=; b=e0kYFAMnokBmpgvlLPAf/g698mtaH2W1VDGkHbYYgBX6yKpmO0OQ7JdGp+Qg0URb2k wYwjuWUpIFwwyq7JBXxrZUXd2nQbbdEwIHC7td0DzF3lI8Pp3yfcZ50qtw+Dc9nHqHwU xivTjBVQCjkwxFccUpZ+QfMzLCDI/16y2a4IXqpsHcVR1iU56MmvAlxZWWl2cbxRCyxg 5KIKlg0ozKL2B+JM1JqhNSd2itA99fxFqnpDQB2o/tXnqZIexav5WLqBpyiCJEq+dJjK 30X/bpNk3HuMlqH5VtsquqtA+t8Hd5RcWrwzdSnAHCXbJ6QTLGeAmXi0CFvQRQE1gvFe pwgg== X-Gm-Message-State: AIkVDXJT9d2bR2KXEw7XiTqOIluMgO/D/fGqYWkwj7bXF0hHTD6LZmXgiyMUsBkvlNr/gA== X-Received: by 10.223.163.136 with SMTP id l8mr13638724wrb.42.1486125251859; Fri, 03 Feb 2017 04:34:11 -0800 (PST) Received: from a.muc.corp.google.com ([2a00:79e0:15:4:5962:9a03:30a8:2b0c]) by smtp.gmail.com with ESMTPSA id d42sm44850154wrd.7.2017.02.03.04.34.10 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 03 Feb 2017 04:34:11 -0800 (PST) From: Philipp Stephani To: bug-gnu-emacs@gnu.org Subject: 26.0.50; Slightly suboptimal message for disabled commands Date: Fri, 03 Feb 2017 13:34:09 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) Run M-x erase-buffer. The *Disabled Command* buffer that shows up contains You have typed RET, invoking disabled command erase-buffer. This should rather be You have typed M-x erase-buffer RET, invoking disabled command erase-buffer. The RET alone of course didn't invoke the command, it just happens to be the last keystroke, so this message might be somewhat confusing. In GNU Emacs 26.0.50.42 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8) of 2017-02-03 built on localhost Repository revision: e080d019f41d2738ba0db721c1b89ea57413439b Windowing system distributor 'The X.Org Foundation', version 11.0.11501000 System Description: Ubuntu 14.04 LTS Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --with-modules --enable-checking --enable-check-lisp-object-type 'CFLAGS=3D-ggdb3 -O0'' Configured features: XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY GNUTLS FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv bytecomp byte-compile cl-extra help-mode cconv cl-loaddefs pcase cl-lib dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 97811 8600) (symbols 48 20258 1) (miscs 40 331 131) (strings 32 18045 4554) (string-bytes 1 593455) (vectors 16 14074) (vector-slots 8 472888 6594) (floats 8 182 70) (intervals 56 218 0) (buffers 976 12) (heap 1024 29048 1021)) --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Matthew Scott Sucherman, Paul Terence Manicle Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und l=C3= =B6schen Sie die E-Mail und alle Anh=C3=A4nge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do = not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 03 08:19:32 2017 Received: (at 25612) by debbugs.gnu.org; 3 Feb 2017 13:19:32 +0000 Received: from localhost ([127.0.0.1]:54617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZdlz-0003dO-Oy for submit@debbugs.gnu.org; Fri, 03 Feb 2017 08:19:31 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZdlx-0003dC-PU for 25612@debbugs.gnu.org; Fri, 03 Feb 2017 08:19:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZdlp-00089K-Dg for 25612@debbugs.gnu.org; Fri, 03 Feb 2017 08:19:24 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZdlp-00089F-A4; Fri, 03 Feb 2017 08:19:21 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3250 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cZdlm-0007d7-D0; Fri, 03 Feb 2017 08:19:21 -0500 Date: Fri, 03 Feb 2017 15:19:02 +0200 Message-Id: <831svfv2d5.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-reply-to: (message from Philipp Stephani on Fri, 03 Feb 2017 13:34:09 +0100) Subject: Re: bug#25612: 26.0.50; Slightly suboptimal message for disabled commands References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25612 Cc: 25612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Philipp Stephani > Date: Fri, 03 Feb 2017 13:34:09 +0100 > > Run M-x erase-buffer. The *Disabled Command* buffer that shows up > contains > > You have typed RET, invoking disabled command erase-buffer. > > This should rather be > > You have typed M-x erase-buffer RET, invoking disabled command > erase-buffer. > > The RET alone of course didn't invoke the command, it just happens to be > the last keystroke, so this message might be somewhat confusing. Depending on your POV, it could be argued that RET is the one that actually invoked the command. Perhaps the message should avoid showing the key sequence at all? From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 03 09:15:49 2017 Received: (at 25612) by debbugs.gnu.org; 3 Feb 2017 14:15:49 +0000 Received: from localhost ([127.0.0.1]:54624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZeeT-0004s1-6e for submit@debbugs.gnu.org; Fri, 03 Feb 2017 09:15:49 -0500 Received: from mail-ot0-f179.google.com ([74.125.82.179]:34229) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZeeQ-0004rn-Mp for 25612@debbugs.gnu.org; Fri, 03 Feb 2017 09:15:47 -0500 Received: by mail-ot0-f179.google.com with SMTP id f9so15070973otd.1 for <25612@debbugs.gnu.org>; Fri, 03 Feb 2017 06:15:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sToZwVirtNNibPFEYrRVxTuwQFTBkeKj+CL4nTyKLBU=; b=ZcDzUoIMdFxMUwVBaGDBRpcsREcWYl1p+xKsSHJP88ikRnVdxSUuieA3lPeZOXJWvi RaBlGqcWDCsi+ZRCwjgeK92Zq/0HPFql2Ef+0n/R4UwNC87Kibwxq5gHRvsRoD4g/8dU +ao5FlyLPAxNS0T1NqOcYUEyfXjYPftiVpn7J7GSwgTAahXsL+F947RM3fA6EmST7+Pj HPL6n31FsPa3ZgtYttmhl8Nkv2NXszisI6EdoX8x6JzO0DxxhIWdG3cVLytgKBl6bgHs /HMEQWLlsdAdU2klQCWUGt2VEwzpLrgiEHfQUekr22zvOoo7nR6BWlMkgJj+F9mreU+t CA8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sToZwVirtNNibPFEYrRVxTuwQFTBkeKj+CL4nTyKLBU=; b=sD+epSDcjXyr363kmj6HkMxoa6S50zjXTHccK4ttIu5XEBJn82yvjUt2iFj+HKGa2g AKQOBFHAj+e8QcYRdqABDj3THUbdIUL6OumuRfa5Z0wKhxJyOpddeF+2b8/rGHpCPrJ4 bkiA0NsV4ldBaCrWhMje/QRYf4OBr55QkrZB15hi/78L2BmgxAT8f/u2lGiYmAulyafE 1QYuzg5jK8jutrflFhdAstpk9ZiXOo5aAddqhDEc7j7MoAHDwq9+AT5A8FiUQBH9B5fU Q9pL3Qz0/oFVWZvprSdauS4SXAxL0XynlkWz2YD08SAEcERgPzmAp3zBf2UlIw50aJf3 3+zA== X-Gm-Message-State: AIkVDXJdKbQbFyT6jqMXH3oKvE74wDAaSbm/dXEohgF0Ljnp289W/2dVdUmBZsjsVGsRTyEoS5EmGflrHjYwpg== X-Received: by 10.157.15.186 with SMTP id d55mr7553221otd.146.1486131340981; Fri, 03 Feb 2017 06:15:40 -0800 (PST) MIME-Version: 1.0 References: <831svfv2d5.fsf@gnu.org> In-Reply-To: <831svfv2d5.fsf@gnu.org> From: Philipp Stephani Date: Fri, 03 Feb 2017 14:15:30 +0000 Message-ID: Subject: Re: bug#25612: 26.0.50; Slightly suboptimal message for disabled commands To: Eli Zaretskii Content-Type: multipart/alternative; boundary=001a113deb20ab3ac90547a0eaf3 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 25612 Cc: 25612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --001a113deb20ab3ac90547a0eaf3 Content-Type: text/plain; charset=UTF-8 Eli Zaretskii schrieb am Fr., 3. Feb. 2017 um 14:19 Uhr: > > From: Philipp Stephani > > Date: Fri, 03 Feb 2017 13:34:09 +0100 > > > > Run M-x erase-buffer. The *Disabled Command* buffer that shows up > > contains > > > > You have typed RET, invoking disabled command erase-buffer. > > > > This should rather be > > > > You have typed M-x erase-buffer RET, invoking disabled command > > erase-buffer. > > > > The RET alone of course didn't invoke the command, it just happens to be > > the last keystroke, so this message might be somewhat confusing. > > Depending on your POV, it could be argued that RET is the one that > actually invoked the command. > > Perhaps the message should avoid showing the key sequence at all? > It seems that this is the intention of lines 54 through 62 in novice.el, but it doesn't seem to work any more. This is a regression: it still works as expected in Emacs 23.4, but no longer in Emacs 24.3. Probably something about this-command-keys or command-execute changed in the meantime so that the code in novice.el no longer works as expected. --001a113deb20ab3ac90547a0eaf3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Fr., 3. Feb. 2017 um 14:19=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Fri, 03 Feb 2017 13:34:09 +0100
>
> Run M-x erase-buffer.=C2=A0 The *Disabled Command* buffer that shows u= p
> contains
>
>=C2=A0 =C2=A0You have typed RET, invoking disabled command erase-buffer= .
>
> This should rather be
>
>=C2=A0 =C2=A0You have typed M-x erase-buffer RET, invoking disabled com= mand
>=C2=A0 =C2=A0erase-buffer.
>
> The RET alone of course didn't invoke the command, it just happens= to be
> the last keystroke, so this message might be somewhat confusing.

Depending on your POV, it could be argued that RET is the one that
actually invoked the command.

Perhaps the message should avoid showing the key sequence at all?

It seems that this is the i= ntention of lines 54 through 62 in novice.el, but it doesn't seem to wo= rk any more.
This is a regression: it still works as expected in = Emacs 23.4, but no longer in Emacs 24.3. Probably something about this-comm= and-keys or command-execute changed in the meantime so that the code in nov= ice.el no longer works as expected.
--001a113deb20ab3ac90547a0eaf3-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 03 10:10:45 2017 Received: (at 25612) by debbugs.gnu.org; 3 Feb 2017 15:10:45 +0000 Received: from localhost ([127.0.0.1]:55289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZfVd-0006Fe-Cz for submit@debbugs.gnu.org; Fri, 03 Feb 2017 10:10:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZfVb-0006FS-OX for 25612@debbugs.gnu.org; Fri, 03 Feb 2017 10:10:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZfVT-0008Db-Bf for 25612@debbugs.gnu.org; Fri, 03 Feb 2017 10:10:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZfVT-0008DX-81; Fri, 03 Feb 2017 10:10:35 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4047 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cZfVS-0005wO-0H; Fri, 03 Feb 2017 10:10:35 -0500 Date: Fri, 03 Feb 2017 17:10:18 +0200 Message-Id: <83wpd7tin9.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-reply-to: (message from Philipp Stephani on Fri, 03 Feb 2017 14:15:30 +0000) Subject: Re: bug#25612: 26.0.50; Slightly suboptimal message for disabled commands References: <831svfv2d5.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25612 Cc: 25612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Philipp Stephani > Date: Fri, 03 Feb 2017 14:15:30 +0000 > Cc: 25612@debbugs.gnu.org > > Perhaps the message should avoid showing the key sequence at all? > > It seems that this is the intention of lines 54 through 62 in novice.el, but it doesn't seem to work any more. Indeed. > This is a regression: it still works as expected in Emacs 23.4, but no longer in Emacs 24.3. Probably > something about this-command-keys or command-execute changed in the meantime so that the code in > novice.el no longer works as expected. Yes, this-command-keys returns just "^M" instead of the expected "\370erase-buffer^M" it returned in Emacs 24.2 and older. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 03 10:54:24 2017 Received: (at 25612) by debbugs.gnu.org; 3 Feb 2017 15:54:24 +0000 Received: from localhost ([127.0.0.1]:55309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZgBs-0007Fm-KR for submit@debbugs.gnu.org; Fri, 03 Feb 2017 10:54:24 -0500 Received: from mail-oi0-f43.google.com ([209.85.218.43]:32781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZgBq-0007FZ-WD for 25612@debbugs.gnu.org; Fri, 03 Feb 2017 10:54:23 -0500 Received: by mail-oi0-f43.google.com with SMTP id w204so13348756oiw.0 for <25612@debbugs.gnu.org>; Fri, 03 Feb 2017 07:54:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NNe0mLtEhhSKssaFsrpLtD/whvtE7cCMok2aAhf6ORo=; b=CHzWCMhkBnHZv30iXErUxvO2SqMTuHziH6MUcPVopOCkB4iObbUL9qxROg3UIjbZI5 1acFBUrQL/kUR9UeqQHAHzSmI9Hd+VEayzRY+fV2AQHiZC5LZylovo3ufIXSA9lgP3nQ 4tIJGEZ4NxVtqcTg6JLT4VPlLv60hRMwEytVJU8bEExlpmzGJcumCWanEUAvI3cmHwXc CbJppPetiFvi2Qj3QlWFh4WUSe6l0CRt8UsCbyj0YChKXBE461VYFoJTNyr+AW1/SKBi zK4EOhKdnVFJ2FFFJ6u6CzdOwbnBBNVsg53TfP9FmIdtS0fMFbbBbASLJTtuJDaSwvY6 3Ldg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NNe0mLtEhhSKssaFsrpLtD/whvtE7cCMok2aAhf6ORo=; b=G61bBJHTBTEK522LLAquUoMsZskJGJ4j5KAVnJ80D52H53sJxjst+An2QwoQ7GKGNR UQnzVz6PcRrH0deLIJzwVJiDsX91CkcctIBmlXWvOCyy7y5KuobpNuBJ/d8k2MPcIN4b lO78R9+eUWgrIFIqY7DbrrYMDIEduKz/obD8LifjQTYG+996nPr9X/4O95BE95EBpN7R H6H8/aGHTs9eYT1ZPvrZS3zxLVD3zmNsX8oDgSDIt29nu5rpIw8/hnvoEJj1XBc6mfbB l+WHO/c6hnTwCa7t1ss6ZUwyB9Ctwn++jHiE++hjrCwNP7tounaRyQyHAZdViVGeT8Az gxmg== X-Gm-Message-State: AIkVDXIqKxUba0imG3isy8G3Xq6dmZ/xzsOys6xQ44ZKFPSdIwJpqmIL0VdelPuHy5GEhDOxQ3uPbg8zovA+Yw== X-Received: by 10.202.179.9 with SMTP id c9mr6318234oif.152.1486137257335; Fri, 03 Feb 2017 07:54:17 -0800 (PST) MIME-Version: 1.0 References: <831svfv2d5.fsf@gnu.org> <83wpd7tin9.fsf@gnu.org> In-Reply-To: <83wpd7tin9.fsf@gnu.org> From: Philipp Stephani Date: Fri, 03 Feb 2017 15:54:06 +0000 Message-ID: Subject: Re: bug#25612: 26.0.50; Slightly suboptimal message for disabled commands To: Eli Zaretskii Content-Type: multipart/alternative; boundary=001a113ce6024fa3500547a24b23 X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 25612 Cc: 25612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) --001a113ce6024fa3500547a24b23 Content-Type: text/plain; charset=UTF-8 Eli Zaretskii schrieb am Fr., 3. Feb. 2017 um 16:10 Uhr: > > > This is a regression: it still works as expected in Emacs 23.4, but no > longer in Emacs 24.3. Probably > > something about this-command-keys or command-execute changed in the > meantime so that the code in > > novice.el no longer works as expected. > > Yes, this-command-keys returns just "^M" instead of the expected > "\370erase-buffer^M" it returned in Emacs 24.2 and older. > git bisect says b593d6a999b21dfee6939b24866a5ec6fbe7d11b is the first bad commit commit b593d6a999b21dfee6939b24866a5ec6fbe7d11b Author: Aaron S. Hawley Date: Tue May 1 12:10:02 2012 -0400 Reimplement execute-extended-command in Elisp. * src/keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings): Move to simple.el. * lisp/simple.el (suggest-key-bindings, execute-extended-command): Move from keyboard.c. :040000 040000 980a3efdb92bf89c1042883830e7fbd1da063f3e 997099bae8bf4663aed645559b102345912f19fa M lisp :040000 040000 832414759411034e7cea2c694fdb77273c422b05 ccf76976dd740fc43ccf84c35ddaf9efe19d5ec2 M src That looks reasonable given that it touches code closely related to the disabled command functionality. --001a113ce6024fa3500547a24b23 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Fr., 3. Feb. 2017 um 16:10=C2=A0Uhr:

> This is a regression: it still works as expected in Emacs 23.4, but no= longer in Emacs 24.3. Probably
> something about this-command-keys or command-execute changed in the me= antime so that the code in
> novice.el no longer works as expected.

Yes, this-command-keys returns just "^M" instead of the expected<= br class=3D"gmail_msg"> "\370erase-buffer^M" it returned in Emacs 24.2 and older.


git bisect = says

b593d6a999b21dfee6939b24866a5ec6fbe7d11b is t= he first bad commit
commit b593d6a999b21dfee6939b24866a5ec6fbe7d1= 1b
Author: Aaron S. Hawley <aaron.s.hawley@gmail.com>
Date: =C2=A0 Tue May 1= 12:10:02 2012 -0400

=C2=A0 =C2=A0 Reimplement exe= cute-extended-command in Elisp.
=C2=A0 =C2=A0 * src/keyboard.c (F= execute_extended_command, Vsuggest_key_bindings):
=C2=A0 =C2=A0 M= ove to simple.el.
=C2=A0 =C2=A0 * lisp/simple.el (suggest-key-bin= dings, execute-extended-command):
=C2=A0 =C2=A0 Move from keyboar= d.c.

:040000 040000 980a3efdb92bf89c1042883830e7fb= d1da063f3e 997099bae8bf4663aed645559b102345912f19fa M lisp
:040000 040000 83= 2414759411034e7cea2c694fdb77273c422b05 ccf76976dd740fc43ccf84c35ddaf9efe19d= 5ec2 M src<= /div>

That looks reasonable given that it touches code c= losely related to the disabled command functionality.=C2=A0
--001a113ce6024fa3500547a24b23-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 03 12:36:52 2017 Received: (at control) by debbugs.gnu.org; 3 Feb 2017 17:36:52 +0000 Received: from localhost ([127.0.0.1]:55323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZhn2-00016G-8h for submit@debbugs.gnu.org; Fri, 03 Feb 2017 12:36:52 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZhn1-000164-90 for control@debbugs.gnu.org; Fri, 03 Feb 2017 12:36:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZhmv-000669-Cf for control@debbugs.gnu.org; Fri, 03 Feb 2017 12:36:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZhmv-00065z-AP for control@debbugs.gnu.org; Fri, 03 Feb 2017 12:36:45 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1cZhmu-0006nl-VM for control@debbugs.gnu.org; Fri, 03 Feb 2017 12:36:45 -0500 Subject: control message for bug 24655 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Fri, 03 Feb 2017 12:36:44 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) block 24655 by 25607 25612 From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 03 16:16:51 2017 Received: (at 25612) by debbugs.gnu.org; 3 Feb 2017 21:16:51 +0000 Received: from localhost ([127.0.0.1]:55398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZlDv-0002m3-6b for submit@debbugs.gnu.org; Fri, 03 Feb 2017 16:16:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39175) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZlDu-0002ls-4O for 25612@debbugs.gnu.org; Fri, 03 Feb 2017 16:16:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZlDj-00065J-Gb for 25612@debbugs.gnu.org; Fri, 03 Feb 2017 16:16:44 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37390) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZlDj-00065B-Cj; Fri, 03 Feb 2017 16:16:39 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4246 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cZlDi-0004EC-E8; Fri, 03 Feb 2017 16:16:39 -0500 Date: Fri, 03 Feb 2017 23:16:27 +0200 Message-Id: <83vasrt1p0.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-reply-to: (message from Philipp Stephani on Fri, 03 Feb 2017 15:54:06 +0000) Subject: Re: bug#25612: 26.0.50; Slightly suboptimal message for disabled commands References: <831svfv2d5.fsf@gnu.org> <83wpd7tin9.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25612 Cc: 25612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Philipp Stephani > Date: Fri, 03 Feb 2017 15:54:06 +0000 > Cc: 25612@debbugs.gnu.org > > Yes, this-command-keys returns just "^M" instead of the expected > "\370erase-buffer^M" it returned in Emacs 24.2 and older. > > git bisect says > > b593d6a999b21dfee6939b24866a5ec6fbe7d11b is the first bad commit > commit b593d6a999b21dfee6939b24866a5ec6fbe7d11b > Author: Aaron S. Hawley > Date: Tue May 1 12:10:02 2012 -0400 > > Reimplement execute-extended-command in Elisp. > * src/keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings): > Move to simple.el. > * lisp/simple.el (suggest-key-bindings, execute-extended-command): > Move from keyboard.c. Yes, when execute-extended-command was reimplemented in Lisp, the special code which produced "\370erase-buffer^M" was lost. Does the change below produce good results? If so, can anyone suggest a more elegant way of squirreling M-x into this-command-keys? diff --git a/lisp/simple.el b/lisp/simple.el index 441713a..c0dad2d 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -1733,6 +1733,9 @@ execute-extended-command (where-is-internal function overriding-local-map t)))) (unless (commandp function) (error "`%s' is not a valid command name" command-name)) + ;; Some features, such as novice.el, rely on this-command-keys + ;; including M-x COMMAND-NAME RET. + (set--this-command-keys (concat "\M-x" (symbol-name function) "\r")) (setq this-command function) ;; Normally `real-this-command' should never be changed, but here we really ;; want to pretend that M-x RET is nothing more than a "key diff --git a/src/keyboard.c b/src/keyboard.c index a86e7c5..b1eeb03 100644 --- a/src/keyboard.c +++ b/src/keyboard.c @@ -10001,6 +10001,28 @@ See also `this-command-keys-vector'. */) XVECTOR (this_command_keys)->contents); } +DEFUN ("set--this-command-keys", Fset__this_command_keys, + Sset__this_command_keys, 1, 1, 0, + doc: /* Set the vector to be returned by `this-command-keys'. +The argument KEYS must be a string. +Internal use only. */) + (Lisp_Object keys) +{ + CHECK_STRING (keys); + + this_command_key_count = 0; + this_single_command_key_start = 0; + int key0 = SREF (keys, 0); + + if (key0 == 248) + add_command_key (make_number ('x' | meta_modifier)); + else + add_command_key (make_number (key0)); + for (int i = 1; i < SCHARS (keys); i++) + add_command_key (make_number (SREF (keys, i))); + return Qnil; +} + DEFUN ("this-command-keys-vector", Fthis_command_keys_vector, Sthis_command_keys_vector, 0, 0, 0, doc: /* Return the key sequence that invoked this command, as a vector. However, if the command has called `read-key-sequence', it returns @@ -11211,6 +11233,7 @@ syms_of_keyboard (void) defsubr (&Sthis_command_keys_vector); defsubr (&Sthis_single_command_keys); defsubr (&Sthis_single_command_raw_keys); + defsubr (&Sset__this_command_keys); defsubr (&Sclear_this_command_keys); defsubr (&Ssuspend_emacs); defsubr (&Sabort_recursive_edit); From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 10 04:00:10 2017 Received: (at 25612-done) by debbugs.gnu.org; 10 Feb 2017 09:00:10 +0000 Received: from localhost ([127.0.0.1]:33792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cc73p-000258-NQ for submit@debbugs.gnu.org; Fri, 10 Feb 2017 04:00:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cc73n-00023s-Pz for 25612-done@debbugs.gnu.org; Fri, 10 Feb 2017 04:00:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cc73e-0008Lx-Ea for 25612-done@debbugs.gnu.org; Fri, 10 Feb 2017 04:00:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cc73e-0008Ls-Bw; Fri, 10 Feb 2017 03:59:58 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4546 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cc73d-0004JQ-Ke; Fri, 10 Feb 2017 03:59:58 -0500 Date: Fri, 10 Feb 2017 11:00:05 +0200 Message-Id: <83d1eq4e0a.fsf@gnu.org> From: Eli Zaretskii To: p.stephani2@gmail.com In-reply-to: <83vasrt1p0.fsf@gnu.org> (message from Eli Zaretskii on Fri, 03 Feb 2017 23:16:27 +0200) Subject: Re: bug#25612: 26.0.50; Slightly suboptimal message for disabled commands References: <831svfv2d5.fsf@gnu.org> <83wpd7tin9.fsf@gnu.org> <83vasrt1p0.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25612-done Cc: 25612-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Fri, 03 Feb 2017 23:16:27 +0200 > From: Eli Zaretskii > Cc: 25612@debbugs.gnu.org > > > From: Philipp Stephani > > Date: Fri, 03 Feb 2017 15:54:06 +0000 > > Cc: 25612@debbugs.gnu.org > > > > Yes, this-command-keys returns just "^M" instead of the expected > > "\370erase-buffer^M" it returned in Emacs 24.2 and older. > > > > git bisect says > > > > b593d6a999b21dfee6939b24866a5ec6fbe7d11b is the first bad commit > > commit b593d6a999b21dfee6939b24866a5ec6fbe7d11b > > Author: Aaron S. Hawley > > Date: Tue May 1 12:10:02 2012 -0400 > > > > Reimplement execute-extended-command in Elisp. > > * src/keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings): > > Move to simple.el. > > * lisp/simple.el (suggest-key-bindings, execute-extended-command): > > Move from keyboard.c. > > Yes, when execute-extended-command was reimplemented in Lisp, the > special code which produced "\370erase-buffer^M" was lost. > > Does the change below produce good results? If so, can anyone suggest > a more elegant way of squirreling M-x into this-command-keys? No further comments, so I pushed my kludgey solution, and I'm marking this bug done. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 10:12:49 2017 Received: (at 25612-done) by debbugs.gnu.org; 12 Feb 2017 15:12:50 +0000 Received: from localhost ([127.0.0.1]:37150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccvpZ-0005fx-Lo for submit@debbugs.gnu.org; Sun, 12 Feb 2017 10:12:49 -0500 Received: from mail-ot0-f179.google.com ([74.125.82.179]:36829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccvpY-0005fl-5D for 25612-done@debbugs.gnu.org; Sun, 12 Feb 2017 10:12:48 -0500 Received: by mail-ot0-f179.google.com with SMTP id 32so54577556oth.3 for <25612-done@debbugs.gnu.org>; Sun, 12 Feb 2017 07:12:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yBjdsKbeBgyo4oLTdZS6SUB/fsKQlSQIzQLqvmQy/Nw=; b=uC/G+SHGJ9GA33wggiK+1lLNV+vwCGtBiQLutXKzNyAY4SeApUQe8pSYfQ74sCH6bY kbzxoPb1ic4Ptdapx1QTrZpmqI9JXHsgJ33YT7+Zm2Nb7/YTGPz7qGWfHZew/4yn1ocJ GN0WU43NQs0KfsJK4aa1tamBLK1cKTc9CyHATaobPHoppleae9X4zgjczQvgb7vIajeM M688PWd5VZ8fKgxRJXDaPH7V0fBPHrL446H7kElbvusTww+0w+T2cEJBrts14q2Ikr01 FTi+bDgn0MiOIG34qqJKs4BBvZgZjCbSyv1rSe2YbQAdA79suQutsL7fUSpRUGd45mVw sIeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yBjdsKbeBgyo4oLTdZS6SUB/fsKQlSQIzQLqvmQy/Nw=; b=g6Bcq1D8GRAiXorF8G6U21sgV4AF53m62He7E9vf890ksjOVIiBDmOXcY1THTbo/w0 H0KIYAZB32o6TbTMHZY+leUSRymvfAZdiENcMwo2rx2zfZAILIrvtMGkyeI+0bukvoNt lfOynzBZS4sO3OKTG/EI+rXgwdw83pdJpFHivVa7eRC74XvZLA8E6Vr6hYpWXONOxQqG ptjkV6MLfZZEgr7N3L8HEEnQCZrne43TMeYMdHXpll+9CW5ZIEBpcuJkyayKo9jSxxzt nlqxOuqd42huClZLPNNErupDJ2eFM1VwL/nFCPDqYeEDZaQiozrZPz03sGymHurvcjm4 LeDQ== X-Gm-Message-State: AMke39nals5ZBAVR0rZOAh7oHOSmrhgzL0ZtUYTP8XnHLPJiarONgaG43GuVHiYTg902okJmKP+CpU1C5y/LHw== X-Received: by 10.157.3.209 with SMTP id f75mr9209784otf.261.1486912362428; Sun, 12 Feb 2017 07:12:42 -0800 (PST) MIME-Version: 1.0 References: <831svfv2d5.fsf@gnu.org> <83wpd7tin9.fsf@gnu.org> <83vasrt1p0.fsf@gnu.org> <83d1eq4e0a.fsf@gnu.org> In-Reply-To: <83d1eq4e0a.fsf@gnu.org> From: Philipp Stephani Date: Sun, 12 Feb 2017 15:12:31 +0000 Message-ID: Subject: Re: bug#25612: 26.0.50; Slightly suboptimal message for disabled commands To: Eli Zaretskii Content-Type: multipart/alternative; boundary=94eb2c03c8ce2cc27e054856c381 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 25612-done Cc: 25612-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --94eb2c03c8ce2cc27e054856c381 Content-Type: text/plain; charset=UTF-8 Eli Zaretskii schrieb am Fr., 10. Feb. 2017 um 10:00 Uhr: > > Date: Fri, 03 Feb 2017 23:16:27 +0200 > > From: Eli Zaretskii > > Cc: 25612@debbugs.gnu.org > > > > > From: Philipp Stephani > > > Date: Fri, 03 Feb 2017 15:54:06 +0000 > > > Cc: 25612@debbugs.gnu.org > > > > > > Yes, this-command-keys returns just "^M" instead of the expected > > > "\370erase-buffer^M" it returned in Emacs 24.2 and older. > > > > > > git bisect says > > > > > > b593d6a999b21dfee6939b24866a5ec6fbe7d11b is the first bad commit > > > commit b593d6a999b21dfee6939b24866a5ec6fbe7d11b > > > Author: Aaron S. Hawley > > > Date: Tue May 1 12:10:02 2012 -0400 > > > > > > Reimplement execute-extended-command in Elisp. > > > * src/keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings): > > > Move to simple.el. > > > * lisp/simple.el (suggest-key-bindings, execute-extended-command): > > > Move from keyboard.c. > > > > Yes, when execute-extended-command was reimplemented in Lisp, the > > special code which produced "\370erase-buffer^M" was lost. > > > > Does the change below produce good results? If so, can anyone suggest > > a more elegant way of squirreling M-x into this-command-keys? > > No further comments, so I pushed my kludgey solution, and I'm marking > this bug done. > > Sorry for not responding earlier, the fix works fine. My only nitpick would be to add a comment for the magic number 248 in the code. I can guess it's 0x80 | 'x', but that might not be obvious to casual readers. --94eb2c03c8ce2cc27e054856c381 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Fr., 10. Feb. 2017 um 10:00=C2=A0Uhr:
> Date: Fri, 03 Feb 2017 23:16:27 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 25612@debbugs.gnu.org
>
> > From: Philipp Stephani <p.stephani2@gmail.com>
> > Date: Fri, 03 Feb 2017 15:54:06 +0000
> > Cc: 25612@debbugs.gnu.org
> >
> >=C2=A0 Yes, this-command-keys returns just "^M" instead = of the expected
> >=C2=A0 "\370erase-buffer^M" it returned in Emacs 24.2 an= d older.
> >
> > git bisect says
> >
> > b593d6a999b21dfee6939b24866a5ec6fbe7d11b is the first bad commit<= br class=3D"gmail_msg"> > > commit b593d6a999b21dfee6939b24866a5ec6fbe7d11b
> > Author: Aaron S. Hawley <aaron.s.hawley@gmail.com&g= t;
> > Date: Tue May 1 12:10:02 2012 -0400
> >
> > Reimplement execute-extended-command in Elisp.
> > * src/keyboard.c (Fexecute_extended_command, Vsuggest_key_binding= s):
> > Move to simple.el.
> > * lisp/simple.el (suggest-key-bindings, execute-extended-command)= :
> > Move from keyboard.c.
>
> Yes, when execute-extended-command was reimplemented in Lisp, the
> special code which produced "\370erase-buffer^M" was lost. >
> Does the change below produce good results?=C2=A0 If so, can anyone su= ggest
> a more elegant way of squirreling M-x into this-command-keys?

No further comments, so I pushed my kludgey solution, and I'm marking this bug done.


Sorry for not resp= onding earlier, the fix works fine. My only nitpick would be to add a comme= nt for the magic number 248 in the code. I can guess it's 0x80 | 'x= ', but that might not be obvious to casual readers.=C2=A0
--94eb2c03c8ce2cc27e054856c381-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 18 05:31:23 2017 Received: (at 25612) by debbugs.gnu.org; 18 Feb 2017 10:31:23 +0000 Received: from localhost ([127.0.0.1]:44185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf2IV-0005DV-3Q for submit@debbugs.gnu.org; Sat, 18 Feb 2017 05:31:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf2IT-0005DG-Lp for 25612@debbugs.gnu.org; Sat, 18 Feb 2017 05:31:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cf2IL-0001aU-HR for 25612@debbugs.gnu.org; Sat, 18 Feb 2017 05:31:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44192) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cf2IL-0001aF-Dv; Sat, 18 Feb 2017 05:31:13 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1161 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cf2IK-0000cM-NN; Sat, 18 Feb 2017 05:31:13 -0500 Date: Sat, 18 Feb 2017 12:31:43 +0200 Message-Id: <83bmtzrdrk.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-reply-to: (message from Philipp Stephani on Sun, 12 Feb 2017 15:12:31 +0000) Subject: Re: bug#25612: 26.0.50; Slightly suboptimal message for disabled commands References: <831svfv2d5.fsf@gnu.org> <83wpd7tin9.fsf@gnu.org> <83vasrt1p0.fsf@gnu.org> <83d1eq4e0a.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25612 Cc: 25612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Philipp Stephani > Date: Sun, 12 Feb 2017 15:12:31 +0000 > Cc: 25612-done@debbugs.gnu.org > > No further comments, so I pushed my kludgey solution, and I'm marking > this bug done. > > Sorry for not responding earlier, the fix works fine. My only nitpick would be to add a comment for the magic > number 248 in the code. I can guess it's 0x80 | 'x', but that might not be obvious to casual readers. Thanks, I added a comment there. From unknown Sun Aug 17 06:57:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 18 Mar 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator