From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 01 18:56:52 2017 Received: (at submit) by debbugs.gnu.org; 1 Feb 2017 23:56:52 +0000 Received: from localhost ([127.0.0.1]:53697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZ4lf-0007VJ-Gw for submit@debbugs.gnu.org; Wed, 01 Feb 2017 18:56:52 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZ4lb-0007Us-DH for submit@debbugs.gnu.org; Wed, 01 Feb 2017 18:56:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZ4lU-0007mM-02 for submit@debbugs.gnu.org; Wed, 01 Feb 2017 18:56:42 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51161) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cZ4lT-0007mE-Sg for submit@debbugs.gnu.org; Wed, 01 Feb 2017 18:56:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54631) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZ4lR-0000EM-0D for bug-gnu-emacs@gnu.org; Wed, 01 Feb 2017 18:56:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZ4lO-0007jr-Fe for bug-gnu-emacs@gnu.org; Wed, 01 Feb 2017 18:56:37 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:48756) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cZ4lO-0007j9-1m for bug-gnu-emacs@gnu.org; Wed, 01 Feb 2017 18:56:34 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0A9F716007E for ; Wed, 1 Feb 2017 15:56:33 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id OedU0LGLpn20; Wed, 1 Feb 2017 15:56:31 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 23D6216007A; Wed, 1 Feb 2017 15:56:31 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id BoS2Qto1nznb; Wed, 1 Feb 2017 15:56:31 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id ECF32160061; Wed, 1 Feb 2017 15:56:30 -0800 (PST) From: Paul Eggert To: bug-gnu-emacs@gnu.org Subject: [DRAFT PATCH 2/2] =?UTF-8?q?Signal=20list=20cycles=20in=20?= =?UTF-8?q?=E2=80=98length=E2=80=99=20etc.?= Date: Wed, 1 Feb 2017 15:56:22 -0800 Message-Id: <20170201235622.30836-2-eggert@cs.ucla.edu> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170201235622.30836-1-eggert@cs.ucla.edu> References: <20170201235622.30836-1-eggert@cs.ucla.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Use macros like FOR_EACH_TAIL instead of maybe_quit to catch list cycles automatically instead of relying on the user becoming impatient and typing C-g. * src/fns.c (Flength, Fmember, Fmemq, Fmemql, Fassq, Fassoc, Frassq) (Frassoc, Fdelete, Freverse): Use FOR_EACH_TAIL instead of maybe_quit. (Fnreverse): Use simple EQ to check for circular list instead of rarely_quit, as this suffices in this unusual case. (Fplist_put, Flax_plist_put, Flax_plist_put): Use FOR_EACH_TAIL_CONS instead of maybe_quit. (internal_equal): Use FOR_EACH_TAIL_CONS to check lists, instead of by-hand tail recursion that did not catch cycles. * src/fns.c (Fsafe_length, Fplist_get): * src/xdisp.c (display_mode_element): Use FOR_EACH_TAIL_SAFE instead of by-hand Floyd=E2=80=99s algorithm. * src/lisp.h (QUIT_COUNT_HEURISTIC): Remove; no longer needed. (rarely_quit): Simply count toward USHRT_MAX + 1, since the fancier versions are no longer needed. (FOR_EACH_TAIL_CONS, FOR_EACH_TAIL_SAFE) (FOR_EACH_TAIL_INTERNAL): New macros, the last with definiens mostly taken from FOR_EACH_TAIL. (FOR_EACH_TAIL): Rewrite in terms of FOR_EACH_TAIL_INTERNAL. --- etc/NEWS | 3 + src/fns.c | 290 +++++++++++++++++++++++-------------------------------= ------ src/lisp.h | 35 +++++--- src/xdisp.c | 37 +++----- 4 files changed, 149 insertions(+), 216 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 86a8385..23e5111 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -872,6 +872,9 @@ collection). +++ ** 'car' and 'cdr' compositions 'cXXXr' and 'cXXXXr' are now part of Eli= sp. =20 +** Low-level list functions like 'length' and 'member' now do a better +job of signaling list cycles instead of looping indefinitely. + +++ ** The new functions 'make-nearby-temp-file' and 'temporary-file-directo= ry' can be used for creation of temporary files of remote or mounted directo= ries. diff --git a/src/fns.c b/src/fns.c index 4de74a5..b5508fb 100644 --- a/src/fns.c +++ b/src/fns.c @@ -108,23 +108,11 @@ To get the number of bytes, use `string-bytes'. */= ) XSETFASTINT (val, ASIZE (sequence) & PSEUDOVECTOR_SIZE_MASK); else if (CONSP (sequence)) { - EMACS_INT i =3D 0; - - do - { - ++i; - if ((i & (QUIT_COUNT_HEURISTIC - 1)) =3D=3D 0) - { - if (MOST_POSITIVE_FIXNUM < i) - error ("List too long"); - maybe_quit (); - } - sequence =3D XCDR (sequence); - } - while (CONSP (sequence)); - - CHECK_LIST_END (sequence, sequence); - + intptr_t i =3D 0; + FOR_EACH_TAIL (sequence) + i++; + if (MOST_POSITIVE_FIXNUM < i) + error ("List too long"); val =3D make_number (i); } else if (NILP (sequence)) @@ -142,38 +130,10 @@ it returns 0. If LIST is circular, it returns a fi= nite value which is at least the number of distinct elements. */) (Lisp_Object list) { - Lisp_Object tail, halftail; - double hilen =3D 0; - uintmax_t lolen =3D 1; - - if (! CONSP (list)) - return make_number (0); - - /* halftail is used to detect circular lists. */ - for (tail =3D halftail =3D list; ; ) - { - tail =3D XCDR (tail); - if (! CONSP (tail)) - break; - if (EQ (tail, halftail)) - break; - lolen++; - if ((lolen & 1) =3D=3D 0) - { - halftail =3D XCDR (halftail); - if ((lolen & (QUIT_COUNT_HEURISTIC - 1)) =3D=3D 0) - { - maybe_quit (); - if (lolen =3D=3D 0) - hilen +=3D UINTMAX_MAX + 1.0; - } - } - } - - /* If the length does not fit into a fixnum, return a float. - On all known practical machines this returns an upper bound on - the true length. */ - return hilen ? make_float (hilen + lolen) : make_fixnum_or_float (lole= n); + intptr_t len =3D 0; + FOR_EACH_TAIL_SAFE (list) + len++; + return make_fixnum_or_float (len); } =20 DEFUN ("string-bytes", Fstring_bytes, Sstring_bytes, 1, 1, 0, @@ -1383,15 +1343,9 @@ DEFUN ("member", Fmember, Smember, 2, 2, 0, The value is actually the tail of LIST whose car is ELT. */) (Lisp_Object elt, Lisp_Object list) { - unsigned short int quit_count =3D 0; - Lisp_Object tail; - for (tail =3D list; CONSP (tail); tail =3D XCDR (tail)) - { - if (! NILP (Fequal (elt, XCAR (tail)))) - return tail; - rarely_quit (++quit_count); - } - CHECK_LIST_END (tail, list); + FOR_EACH_TAIL (list) + if (! NILP (Fequal (elt, XCAR (li.tail)))) + return li.tail; return Qnil; } =20 @@ -1400,15 +1354,9 @@ DEFUN ("memq", Fmemq, Smemq, 2, 2, 0, The value is actually the tail of LIST whose car is ELT. */) (Lisp_Object elt, Lisp_Object list) { - unsigned short int quit_count =3D 0; - Lisp_Object tail; - for (tail =3D list; CONSP (tail); tail =3D XCDR (tail)) - { - if (EQ (XCAR (tail), elt)) - return tail; - rarely_quit (++quit_count); - } - CHECK_LIST_END (tail, list); + FOR_EACH_TAIL (list) + if (EQ (XCAR (li.tail), elt)) + return li.tail; return Qnil; } =20 @@ -1420,16 +1368,12 @@ The value is actually the tail of LIST whose car = is ELT. */) if (!FLOATP (elt)) return Fmemq (elt, list); =20 - unsigned short int quit_count =3D 0; - Lisp_Object tail; - for (tail =3D list; CONSP (tail); tail =3D XCDR (tail)) + FOR_EACH_TAIL (list) { - Lisp_Object tem =3D XCAR (tail); + Lisp_Object tem =3D XCAR (li.tail); if (FLOATP (tem) && internal_equal (elt, tem, 0, 0, Qnil)) - return tail; - rarely_quit (++quit_count); + return li.tail; } - CHECK_LIST_END (tail, list); return Qnil; } =20 @@ -1439,15 +1383,9 @@ The value is actually the first element of LIST wh= ose car is KEY. Elements of LIST that are not conses are ignored. */) (Lisp_Object key, Lisp_Object list) { - unsigned short int quit_count =3D 0; - Lisp_Object tail; - for (tail =3D list; CONSP (tail); tail =3D XCDR (tail)) - { - if (CONSP (XCAR (tail)) && EQ (XCAR (XCAR (tail)), key)) - return XCAR (tail); - rarely_quit (++quit_count); - } - CHECK_LIST_END (tail, list); + FOR_EACH_TAIL (list) + if (CONSP (XCAR (li.tail)) && EQ (XCAR (XCAR (li.tail)), key)) + return XCAR (li.tail); return Qnil; } =20 @@ -1468,17 +1406,13 @@ DEFUN ("assoc", Fassoc, Sassoc, 2, 2, 0, The value is actually the first element of LIST whose car equals KEY. *= /) (Lisp_Object key, Lisp_Object list) { - unsigned short int quit_count =3D 0; - Lisp_Object tail; - for (tail =3D list; CONSP (tail); tail =3D XCDR (tail)) + FOR_EACH_TAIL (list) { - Lisp_Object car =3D XCAR (tail); + Lisp_Object car =3D XCAR (li.tail); if (CONSP (car) && (EQ (XCAR (car), key) || !NILP (Fequal (XCAR (car), key)))) return car; - rarely_quit (++quit_count); } - CHECK_LIST_END (tail, list); return Qnil; } =20 @@ -1503,15 +1437,9 @@ DEFUN ("rassq", Frassq, Srassq, 2, 2, 0, The value is actually the first element of LIST whose cdr is KEY. */) (Lisp_Object key, Lisp_Object list) { - unsigned short int quit_count =3D 0; - Lisp_Object tail; - for (tail =3D list; CONSP (tail); tail =3D XCDR (tail)) - { - if (CONSP (XCAR (tail)) && EQ (XCDR (XCAR (tail)), key)) - return XCAR (tail); - rarely_quit (++quit_count); - } - CHECK_LIST_END (tail, list); + FOR_EACH_TAIL (list) + if (CONSP (XCAR (li.tail)) && EQ (XCDR (XCAR (li.tail)), key)) + return XCAR (li.tail); return Qnil; } =20 @@ -1520,17 +1448,13 @@ DEFUN ("rassoc", Frassoc, Srassoc, 2, 2, 0, The value is actually the first element of LIST whose cdr equals KEY. *= /) (Lisp_Object key, Lisp_Object list) { - unsigned short int quit_count =3D 0; - Lisp_Object tail; - for (tail =3D list; CONSP (tail); tail =3D XCDR (tail)) + FOR_EACH_TAIL (list) { - Lisp_Object car =3D XCAR (tail); + Lisp_Object car =3D XCAR (li.tail); if (CONSP (car) && (EQ (XCDR (car), key) || !NILP (Fequal (XCDR (car), key)))) return car; - rarely_quit (++quit_count); } - CHECK_LIST_END (tail, list); return Qnil; } =0C @@ -1668,23 +1592,20 @@ changing the value of a sequence `foo'. */) } else { - unsigned short int quit_count =3D 0; - Lisp_Object tail, prev; + Lisp_Object prev =3D Qnil; =20 - for (tail =3D seq, prev =3D Qnil; CONSP (tail); tail =3D XCDR (tai= l)) + FOR_EACH_TAIL (seq) { - if (!NILP (Fequal (elt, XCAR (tail)))) + if (!NILP (Fequal (elt, (XCAR (li.tail))))) { if (NILP (prev)) - seq =3D XCDR (tail); + seq =3D XCDR (li.tail); else - Fsetcdr (prev, XCDR (tail)); + Fsetcdr (prev, XCDR (li.tail)); } else - prev =3D tail; - rarely_quit (++quit_count); + prev =3D li.tail; } - CHECK_LIST_END (tail, seq); } =20 return seq; @@ -1702,15 +1623,17 @@ This function may destructively modify SEQ to pro= duce the value. */) return Freverse (seq); else if (CONSP (seq)) { - unsigned short int quit_count =3D 0; Lisp_Object prev, tail, next; =20 for (prev =3D Qnil, tail =3D seq; CONSP (tail); tail =3D next) { next =3D XCDR (tail); + /* If SEQ contains a cycle, attempting to reverse it + in-place will inevitably come back to SEQ. */ + if (EQ (next, seq)) + circular_list (seq); Fsetcdr (tail, prev); prev =3D tail; - rarely_quit (++quit_count); } CHECK_LIST_END (tail, seq); seq =3D prev; @@ -1753,13 +1676,9 @@ See also the function `nreverse', which is used mo= re often. */) return Qnil; else if (CONSP (seq)) { - unsigned short int quit_count =3D 0; - for (new =3D Qnil; CONSP (seq); seq =3D XCDR (seq)) - { - new =3D Fcons (XCAR (seq), new); - rarely_quit (++quit_count); - } - CHECK_LIST_END (seq, seq); + new =3D Qnil; + FOR_EACH_TAIL (seq) + new =3D Fcons (XCAR (li.tail), new); } else if (VECTORP (seq)) { @@ -2011,18 +1930,14 @@ corresponding to the given PROP, or nil if PROP i= s not one of the properties on the list. This function never signals an error. */) (Lisp_Object plist, Lisp_Object prop) { - Lisp_Object tail, halftail; - - /* halftail is used to detect circular lists. */ - tail =3D halftail =3D plist; - while (CONSP (tail) && CONSP (XCDR (tail))) + FOR_EACH_TAIL_SAFE (plist) { - if (EQ (prop, XCAR (tail))) - return XCAR (XCDR (tail)); - - tail =3D XCDR (XCDR (tail)); - halftail =3D XCDR (halftail); - if (EQ (tail, halftail)) + if (! CONSP (XCDR (li.tail))) + break; + if (EQ (prop, XCAR (li.tail))) + return XCAR (XCDR (li.tail)); + li.tail =3D XCDR (li.tail); + if (EQ (li.tail, li.tortoise)) break; } =20 @@ -2048,19 +1963,22 @@ use `(setq x (plist-put x prop val))' to be sure = to use the new value. The PLIST is modified by side effects. */) (Lisp_Object plist, Lisp_Object prop, Lisp_Object val) { - unsigned short int quit_count =3D 0; Lisp_Object prev =3D Qnil; - for (Lisp_Object tail =3D plist; CONSP (tail) && CONSP (XCDR (tail)); - tail =3D XCDR (XCDR (tail))) + FOR_EACH_TAIL_CONS (plist) { - if (EQ (prop, XCAR (tail))) + if (! CONSP (XCDR (li.tail))) + break; + + if (EQ (prop, XCAR (li.tail))) { - Fsetcar (XCDR (tail), val); + Fsetcar (XCDR (li.tail), val); return plist; } =20 - prev =3D tail; - rarely_quit (++quit_count); + prev =3D li.tail; + li.tail =3D XCDR (li.tail); + if (EQ (li.tail, li.tortoise)) + circular_list (plist); } Lisp_Object newcell =3D Fcons (prop, Fcons (val, NILP (prev) ? plist : XCDR (XCDR (prev)= ))); @@ -2089,20 +2007,16 @@ corresponding to the given PROP, or nil if PROP i= s not one of the properties on the list. */) (Lisp_Object plist, Lisp_Object prop) { - unsigned short int quit_count =3D 0; - Lisp_Object tail; - - for (tail =3D plist; - CONSP (tail) && CONSP (XCDR (tail)); - tail =3D XCDR (XCDR (tail))) + FOR_EACH_TAIL_CONS (plist) { - if (! NILP (Fequal (prop, XCAR (tail)))) - return XCAR (XCDR (tail)); - rarely_quit (++quit_count); + if (! CONSP (XCDR (li.tail))) + break; + if (! NILP (Fequal (prop, XCAR (li.tail)))) + return XCAR (XCDR (li.tail)); + li.tail =3D XCDR (li.tail); + if (EQ (li.tail, li.tortoise)) + circular_list (plist); } - - CHECK_LIST_END (tail, prop); - return Qnil; } =20 @@ -2116,19 +2030,22 @@ use `(setq x (lax-plist-put x prop val))' to be s= ure to use the new value. The PLIST is modified by side effects. */) (Lisp_Object plist, Lisp_Object prop, Lisp_Object val) { - unsigned short int quit_count =3D 0; Lisp_Object prev =3D Qnil; - for (Lisp_Object tail =3D plist; CONSP (tail) && CONSP (XCDR (tail)); - tail =3D XCDR (XCDR (tail))) + FOR_EACH_TAIL_CONS (plist) { - if (! NILP (Fequal (prop, XCAR (tail)))) + if (! CONSP (XCDR (li.tail))) + break; + + if (! NILP (Fequal (prop, XCAR (li.tail)))) { - Fsetcar (XCDR (tail), val); + Fsetcar (XCDR (li.tail), val); return plist; } =20 - prev =3D tail; - rarely_quit (++quit_count); + prev =3D li.tail; + li.tail =3D XCDR (li.tail); + if (EQ (li.tail, li.tortoise)) + circular_list (plist); } Lisp_Object newcell =3D list2 (prop, val); if (NILP (prev)) @@ -2206,9 +2123,7 @@ internal_equal (Lisp_Object o1, Lisp_Object o2, int= depth, bool props, } } =20 - unsigned short int quit_count =3D 0; tail_recurse: - rarely_quit (++quit_count); if (EQ (o1, o2)) return 1; if (XTYPE (o1) !=3D XTYPE (o2)) @@ -2228,12 +2143,24 @@ internal_equal (Lisp_Object o1, Lisp_Object o2, i= nt depth, bool props, } =20 case Lisp_Cons: - if (!internal_equal (XCAR (o1), XCAR (o2), depth + 1, props, ht)) - return 0; - o1 =3D XCDR (o1); - o2 =3D XCDR (o2); - /* FIXME: This inf-loops in a circular list! */ - goto tail_recurse; + { + Lisp_Object tail1 =3D o1; + FOR_EACH_TAIL_CONS (o1) + { + if (! CONSP (o2)) + return false; + if (! internal_equal (XCAR (li.tail), XCAR (o2), depth + 1, + props, ht)) + return false; + tail1 =3D XCDR (li.tail); + o2 =3D XCDR (o2); + if (EQ (tail1, o2)) + return true; + } + o1 =3D tail1; + depth++; + goto tail_recurse; + } =20 case Lisp_Misc: if (XMISCTYPE (o1) !=3D XMISCTYPE (o2)) @@ -2247,6 +2174,7 @@ internal_equal (Lisp_Object o1, Lisp_Object o2, int= depth, bool props, return 0; o1 =3D XOVERLAY (o1)->plist; o2 =3D XOVERLAY (o2)->plist; + depth++; goto tail_recurse; } if (MARKERP (o1)) @@ -2397,7 +2325,6 @@ Only the last argument is not altered, and need not= be a list. usage: (nconc &rest LISTS) */) (ptrdiff_t nargs, Lisp_Object *args) { - unsigned short int quit_count =3D 0; Lisp_Object val =3D Qnil; =20 for (ptrdiff_t argnum =3D 0; argnum < nargs; argnum++) @@ -2413,13 +2340,8 @@ usage: (nconc &rest LISTS) */) CHECK_CONS (tem); =20 Lisp_Object tail; - do - { - tail =3D tem; - tem =3D XCDR (tail); - rarely_quit (++quit_count); - } - while (CONSP (tem)); + FOR_EACH_TAIL_CONS (tem) + tail =3D li.tail; =20 tem =3D args[argnum + 1]; Fsetcdr (tail, tem); @@ -2841,14 +2763,20 @@ property and a property with the value nil. The value is actually the tail of PLIST whose car is PROP. */) (Lisp_Object plist, Lisp_Object prop) { - unsigned short int quit_count =3D 0; - while (CONSP (plist) && !EQ (XCAR (plist), prop)) + FOR_EACH_TAIL (plist) { - plist =3D XCDR (plist); - plist =3D CDR (plist); - rarely_quit (++quit_count); + if (EQ (XCAR (li.tail), prop)) + return li.tail; + if (!CONSP (XCDR (li.tail))) + { + CHECK_LIST_END (XCDR (li.tail), plist); + return Qnil; + } + li.tail =3D XCDR (li.tail); + if (EQ (li.tail, li.tortoise)) + circular_list (plist); } - return plist; + return Qnil; } =20 DEFUN ("widget-put", Fwidget_put, Swidget_put, 3, 3, 0, diff --git a/src/lisp.h b/src/lisp.h index 2d74d44..275e0fc 100644 --- a/src/lisp.h +++ b/src/lisp.h @@ -3129,20 +3129,14 @@ extern void maybe_quit (void); =20 #define QUITP (!NILP (Vquit_flag) && NILP (Vinhibit_quit)) =20 -/* Heuristic on how many iterations of a tight loop can be safely done - before it's time to do a quit. This must be a power of 2. It - is nice but not necessary for it to equal USHRT_MAX + 1. */ - -enum { QUIT_COUNT_HEURISTIC =3D 1 << 16 }; - /* Process a quit rarely, based on a counter COUNT, for efficiency. - "Rarely" means once per QUIT_COUNT_HEURISTIC or per USHRT_MAX + 1 - times, whichever is smaller (somewhat arbitrary, but often faster). = */ + "Rarely" means once per USHRT_MAX + 1 times; this is somewhat + arbitrary, but efficient. */ =20 INLINE void rarely_quit (unsigned short int count) { - if (! (count & (QUIT_COUNT_HEURISTIC - 1))) + if (! count) maybe_quit (); } =0C @@ -4599,13 +4593,32 @@ enum http://maths-people.anu.edu.au/~brent/pd/rpb051i.pdf */ =20 #define FOR_EACH_TAIL(list) \ + FOR_EACH_TAIL_INTERNAL (list, CHECK_LIST_END (li.tail, list), \ + circular_list (list)) + +/* Like FOR_EACH_TAIL (LIST), except check only for cycles. */ + +#define FOR_EACH_TAIL_CONS(list) \ + FOR_EACH_TAIL_INTERNAL (list, (void) 0, circular_list (list)) + +/* Like FOR_EACH_TAIL (LIST), except check for neither dotted lists + nor cycles. */ + +#define FOR_EACH_TAIL_SAFE(list) \ + FOR_EACH_TAIL_INTERNAL (list, (void) 0, (void) (li.tail =3D Qnil)) + +/* Like FOR_EACH_TAIL (LIST), except evaluate DOTTED or CYCLE, + respectively, if a dotted list or cycle is found. This is an + internal macro intended for use only by the above macros. */ + +#define FOR_EACH_TAIL_INTERNAL(list, dotted, cycle) \ for (struct { Lisp_Object tail, tortoise; intptr_t n, max; } li \ =3D { list, list, 2, 2 }; \ - CONSP (li.tail) || (CHECK_LIST_END (li.tail, list), false); \ + CONSP (li.tail) || (dotted, false); \ (li.tail =3D XCDR (li.tail), \ (li.n-- =3D=3D 0 \ ? (void) (li.n =3D li.max <<=3D 1, li.tortoise =3D li.tail) \ - : EQ (li.tail, li.tortoise) ? circular_list (list) : (void) 0))) + : EQ (li.tail, li.tortoise) ? (cycle) : (void) 0))) =20 /* Do a `for' loop over alist values. */ =20 diff --git a/src/xdisp.c b/src/xdisp.c index 33661c8..31c1fe1 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -23055,30 +23055,19 @@ display_mode_element (struct it *it, int depth,= int field_width, int precision, goto tail_recurse; } else if (STRINGP (car) || CONSP (car)) - { - Lisp_Object halftail =3D elt; - int len =3D 0; - - while (CONSP (elt) - && (precision <=3D 0 || n < precision)) - { - n +=3D display_mode_element (it, depth, - /* Do padding only after the last - element in the list. */ - (! CONSP (XCDR (elt)) - ? field_width - n - : 0), - precision - n, XCAR (elt), - props, risky); - elt =3D XCDR (elt); - len++; - if ((len & 1) =3D=3D 0) - halftail =3D XCDR (halftail); - /* Check for cycle. */ - if (EQ (halftail, elt)) - break; - } - } + FOR_EACH_TAIL_SAFE (elt) + { + if (0 < precision && precision <=3D n) + break; + n +=3D display_mode_element (it, depth, + /* Pad after only the last + list element. */ + (! CONSP (XCDR (li.tail)) + ? field_width - n + : 0), + precision - n, XCAR (li.tail), + props, risky); + } } break; =20 --=20 2.9.3 From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 02 12:28:47 2017 Received: (at 25606) by debbugs.gnu.org; 2 Feb 2017 17:28:47 +0000 Received: from localhost ([127.0.0.1]:54230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZLBf-0001Yz-4B for submit@debbugs.gnu.org; Thu, 02 Feb 2017 12:28:47 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZLBd-0001Yl-LV for 25606@debbugs.gnu.org; Thu, 02 Feb 2017 12:28:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZLBX-0007Qg-QC for 25606@debbugs.gnu.org; Thu, 02 Feb 2017 12:28:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZLBS-0007Oq-4Y; Thu, 02 Feb 2017 12:28:34 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2394 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cZLBR-0006VG-BQ; Thu, 02 Feb 2017 12:28:33 -0500 Date: Thu, 02 Feb 2017 19:28:19 +0200 Message-Id: <83wpd8v6x8.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <20170201235622.30836-2-eggert@cs.ucla.edu> (message from Paul Eggert on Wed, 1 Feb 2017 15:56:22 -0800) Subject: Re: bug#25606: [DRAFT PATCH 2/2] Signal list cycles in =?utf-8?B?4oCYbGVuZ3Ro4oCZ?= etc. References: <20170201235622.30836-1-eggert@cs.ucla.edu> <20170201235622.30836-2-eggert@cs.ucla.edu> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25606 Cc: eggert@cs.ucla.edu, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Paul Eggert > Date: Wed, 1 Feb 2017 15:56:22 -0800 > Cc: Paul Eggert > > Use macros like FOR_EACH_TAIL instead of maybe_quit to > catch list cycles automatically instead of relying on the > user becoming impatient and typing C-g. I don't think this is a good idea. We don't know when the user will become impatient, and on busy systems the counter could be very low by that time. I think we shouldn't second-guess users this way, and should always leave them the possibility of interrupting a possibly prolonged calculation. Also, could we please have tests for these functions? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 02 18:01:26 2017 Received: (at 25606) by debbugs.gnu.org; 2 Feb 2017 23:01:26 +0000 Received: from localhost ([127.0.0.1]:54298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZQNa-0000u7-CR for submit@debbugs.gnu.org; Thu, 02 Feb 2017 18:01:26 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:35512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZQNX-0000ts-Vq for 25606@debbugs.gnu.org; Thu, 02 Feb 2017 18:01:24 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B5F68160083; Thu, 2 Feb 2017 15:01:17 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Qa1OuwlT85YL; Thu, 2 Feb 2017 15:01:17 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id F2D2D1600DA; Thu, 2 Feb 2017 15:01:16 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ntgq9PvU21qQ; Thu, 2 Feb 2017 15:01:16 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id DA0D4160083; Thu, 2 Feb 2017 15:01:16 -0800 (PST) Subject: =?UTF-8?Q?Re:_bug#25606:_[DRAFT_PATCH_2/2]_Signal_list_cycles_in_?= =?UTF-8?B?4oCYbGVuZ3Ro4oCZIGV0Yy4=?= To: Eli Zaretskii References: <20170201235622.30836-1-eggert@cs.ucla.edu> <20170201235622.30836-2-eggert@cs.ucla.edu> <83wpd8v6x8.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <0a01d2ce-ef3e-7db0-6854-1b5e46d49be4@cs.ucla.edu> Date: Thu, 2 Feb 2017 15:01:16 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <83wpd8v6x8.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25606 Cc: 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On 02/02/2017 09:28 AM, Eli Zaretskii wrote: > could we please have tests for these functions? Good point, I'll look into adding some. > I think we shouldn't second-guess users this way, and > should always leave them the possibility of interrupting a possibly > prolonged calculation. Sure, but we shouldn't insert maybe_quit calls after every nanosecond's worth of computation; that'd be overkill and would slow down Emacs unnecessarily. We should insert a maybe_quit call only when Emacs may have done enough computation that it would be annoying if the user typed C-g and Emacs did not respond for that period of time. A reasonable rule of thumb is that if an operation can take longer than a garbage collection, then we should insert a maybe_quit in its loop body. Conversely, if an operation is always significantly faster then GC, then we needn't bother inserting maybe_quit, as Emacs cannot quit in the middle of GC anyway (and if we ever get around to fixing *that* problem then we will likely be able use the fix approach to attack the problem everywhere, not just in GC). This rule of thumb corresponds pretty closely to what Emacs is already doing. For example, Emacs does a maybe_quit while doing regex searching, as in practice buffers can be quite large and searching them can easily take longer than a GC. In contrast, Emacs does not do a maybe_quit when FACE_FOR_CHAR searches font-encoding-charset-alist, as in practice that list is never so long that the a user would notice any C-g delay (and if the list actually did contain billions of elements (!), GC would be slow too as it would have to mark the list). With cycle checking, all the loops containing removed maybe_quits are waaaay faster than a GC would be, which is why these loops don't need those maybe_quit calls once they start checking for list cycles. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 03 02:56:21 2017 Received: (at 25606) by debbugs.gnu.org; 3 Feb 2017 07:56:21 +0000 Received: from localhost ([127.0.0.1]:54442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZYjE-0002um-Su for submit@debbugs.gnu.org; Fri, 03 Feb 2017 02:56:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZYjD-0002uZ-KF for 25606@debbugs.gnu.org; Fri, 03 Feb 2017 02:56:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZYj5-0008AG-4S for 25606@debbugs.gnu.org; Fri, 03 Feb 2017 02:56:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZYj5-0008AC-0u; Fri, 03 Feb 2017 02:56:11 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2882 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cZYj4-0001Dq-7H; Fri, 03 Feb 2017 02:56:10 -0500 Date: Fri, 03 Feb 2017 09:55:57 +0200 Message-Id: <83efzfvhbm.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <0a01d2ce-ef3e-7db0-6854-1b5e46d49be4@cs.ucla.edu> (message from Paul Eggert on Thu, 2 Feb 2017 15:01:16 -0800) Subject: Re: bug#25606: [DRAFT PATCH 2/2] Signal list cycles in =?utf-8?B?4oCYbGVuZ3Ro4oCZ?= etc. References: <20170201235622.30836-1-eggert@cs.ucla.edu> <20170201235622.30836-2-eggert@cs.ucla.edu> <83wpd8v6x8.fsf@gnu.org> <0a01d2ce-ef3e-7db0-6854-1b5e46d49be4@cs.ucla.edu> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25606 Cc: 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 25606@debbugs.gnu.org > From: Paul Eggert > Date: Thu, 2 Feb 2017 15:01:16 -0800 > > On 02/02/2017 09:28 AM, Eli Zaretskii wrote: > > > could we please have tests for these functions? > Good point, I'll look into adding some. Thanks. > > I think we shouldn't second-guess users this way, and > > should always leave them the possibility of interrupting a possibly > > prolonged calculation. > > Sure, but we shouldn't insert maybe_quit calls after every nanosecond's > worth of computation; that'd be overkill and would slow down Emacs > unnecessarily. No, not that frequently, I agree. So perhaps rarely_quit is a better possibility in these places. But in general, data structures on which these primitives work could be rather large, and processing them could take a tangible amount of time. Moreover, on a memory-starved system or a system under heavy computational load, the processing could take a long elapsed time even if the CPU time used by Emacs is very small. Users get annoyed by elapsed time, because that's what they perceive. So making these uninterruptible except in case of glaring bugs sounds like losing a valuable fire escape to me. > We should insert a maybe_quit call only when Emacs may have done > enough computation that it would be annoying if the user typed C-g > and Emacs did not respond for that period of time. Sure. But do we have a reliable device to measure this quantity? Once again, the elapsed time tends to annoy users regardless of the real computational resources used by Emacs. IOW, the removal is probably justified for 90% of use cases, maybe even more, but it could be a problem for a small fraction of use cases. And since quitting is a kind of zero-level troubleshooting in Emacs, I think we should be biased towards those rare cases here. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 03 15:29:24 2017 Received: (at 25606) by debbugs.gnu.org; 3 Feb 2017 20:29:24 +0000 Received: from localhost ([127.0.0.1]:55382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZkU0-0001i9-4Q for submit@debbugs.gnu.org; Fri, 03 Feb 2017 15:29:24 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:44586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZkTx-0001hq-So for 25606@debbugs.gnu.org; Fri, 03 Feb 2017 15:29:22 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C5E2616006A; Fri, 3 Feb 2017 12:29:15 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id x7U8ERzjlGY9; Fri, 3 Feb 2017 12:29:15 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EF26D16008B; Fri, 3 Feb 2017 12:29:14 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id OBsqZu_IcDEG; Fri, 3 Feb 2017 12:29:14 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id D2D5616006A; Fri, 3 Feb 2017 12:29:14 -0800 (PST) Subject: =?UTF-8?Q?Re:_bug#25606:_[DRAFT_PATCH_2/2]_Signal_list_cycles_in_?= =?UTF-8?B?4oCYbGVuZ3Ro4oCZIGV0Yy4=?= To: Eli Zaretskii References: <20170201235622.30836-1-eggert@cs.ucla.edu> <20170201235622.30836-2-eggert@cs.ucla.edu> <83wpd8v6x8.fsf@gnu.org> <0a01d2ce-ef3e-7db0-6854-1b5e46d49be4@cs.ucla.edu> <83efzfvhbm.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <08b0e359-3a9b-49f2-1299-51e899f86712@cs.ucla.edu> Date: Fri, 3 Feb 2017 12:29:11 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <83efzfvhbm.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------18EE4DC2DA9AA5EE14CFA383" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25606 Cc: 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --------------18EE4DC2DA9AA5EE14CFA383 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 02/02/2017 11:55 PM, Eli Zaretskii wrote: > the removal is probably justified for 90% of use cases, maybe > even more It's 100%, as in practice any use case that has trouble because of the code removal will have significantly worse trouble on every GC (which is also noninterruptible). memq calls maybe_quit because of circular lists, not because of lists of length 1 billion, as huge lists don't work well with Emacs anyway (due to GC). I wrote a little benchmark to try this out (attached), which used the new memq. On my workstation at UCLA the results were either: 1. The benchmark was so large that Emacs froze my system while building the test-case list, i.e., before any of the newly-affected code was executed. This was due to page thrashing. Obviously the draft change is irrelevant here. 2. The benchmark was so small that it finished instantly, from the user's viewpoint. Obviously not a problem. 3. The benchmark was medium sized (in my case, this was a list with 100 million entries), so that Emacs was painfully slow but still barely usable while the test case was being built or while garbage collection was being done. In this case, the new memq was the least of the user's problems, as the new memq was 4x faster than a garbage collect so the C-g was delayed annoyingly for GC anyway. That is, GC makes Emacs so painful to use even with length-100-million lists that people won't use Emacs that way and we don't need to worry about treating such lists specially. Of course I can't test all possible use cases. But if there's a practical use case where the draft patch will cause a problem, I haven't seen it yet. By the way, I have found many cases where Emacs master will loop forever and will ignore C-g. If you like, I can privately send you an Elisp expression that, if you evaluate it, you cannot C-g out of. This problem is independent of the draft patch, and is far more serious than the somewhat-theoretical discussion we're having about memq and friends. --------------18EE4DC2DA9AA5EE14CFA383 Content-Type: text/plain; charset=UTF-8; name="bigmemq.el" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="bigmemq.el" KGRlZnVuIGJpZ21lbXEgKG4pCiAgKGxldCAoKHQwIChmbG9hdC10aW1lIChjdXJyZW50LXRp bWUpKSkpCiAgICAobWVzc2FnZSAiUnVubmluZyBtYWtlLWxpc3QuLi4iKQogICAgKGxldCAo KGxvbmcgKG1ha2UtbGlzdCBuIG5pbCkpCiAgICAgICAgICAodDEgKGZsb2F0LXRpbWUgKGN1 cnJlbnQtdGltZSkpKSkKICAgICAgKG1lc3NhZ2UgIlJ1bm5pbmcgbWFrZS1saXN0Li4uIGRv bmUgaW4gJXMgc2Vjb25kcyIgKC0gdDEgdDApKQogICAgICAobWVzc2FnZSAiUnVubmluZyBt ZW1xLi4uIikKICAgICAgKGxldCAoKHJlc3VsdCAobWVtcSB0IGxvbmcpKQogICAgICAgICAg ICAodDIgKGZsb2F0LXRpbWUgKGN1cnJlbnQtdGltZSkpKSkKICAgICAgICAobWVzc2FnZSAi UnVubmluZyBtZW1xLi4uIGRvbmUgaW4gJXMgc2Vjb25kcyIgKC0gdDIgdDEpKQogICAgICAg IChtZXNzYWdlICJSdW5uaW5nIGdhcmJhZ2UtY29sbGVjdC4uLiIpCiAgICAgICAgKGdhcmJh Z2UtY29sbGVjdCkKICAgICAgICAobGV0ICgodDMgKGZsb2F0LXRpbWUgKGN1cnJlbnQtdGlt ZSkpKSkKICAgICAgICAgIChtZXNzYWdlICJSdW5uaW5nIGdhcmJhZ2UtY29sbGVjdC4uLiBk b25lIGluICVzIHNlY29uZHMiICgtIHQzIHQyKSkpCiAgICAgICAgcmVzdWx0KSkpKQo= --------------18EE4DC2DA9AA5EE14CFA383-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 04 04:05:35 2017 Received: (at 25606) by debbugs.gnu.org; 4 Feb 2017 09:05:35 +0000 Received: from localhost ([127.0.0.1]:55494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZwHm-00054A-PR for submit@debbugs.gnu.org; Sat, 04 Feb 2017 04:05:34 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZwHk-00053x-NY for 25606@debbugs.gnu.org; Sat, 04 Feb 2017 04:05:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZwHb-0008PO-7E for 25606@debbugs.gnu.org; Sat, 04 Feb 2017 04:05:27 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46811) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZwHb-0008PK-3i; Sat, 04 Feb 2017 04:05:23 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4849 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cZwHT-0006kL-Rq; Sat, 04 Feb 2017 04:05:17 -0500 Date: Sat, 04 Feb 2017 11:05:06 +0200 Message-Id: <83y3xm8gxp.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <08b0e359-3a9b-49f2-1299-51e899f86712@cs.ucla.edu> (message from Paul Eggert on Fri, 3 Feb 2017 12:29:11 -0800) Subject: Re: bug#25606: [DRAFT PATCH 2/2] Signal list cycles in =?utf-8?B?4oCYbGVuZ3Ro4oCZ?= etc. References: <20170201235622.30836-1-eggert@cs.ucla.edu> <20170201235622.30836-2-eggert@cs.ucla.edu> <83wpd8v6x8.fsf@gnu.org> <0a01d2ce-ef3e-7db0-6854-1b5e46d49be4@cs.ucla.edu> <83efzfvhbm.fsf@gnu.org> <08b0e359-3a9b-49f2-1299-51e899f86712@cs.ucla.edu> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25606 Cc: 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 25606@debbugs.gnu.org > From: Paul Eggert > Date: Fri, 3 Feb 2017 12:29:11 -0800 > > On 02/02/2017 11:55 PM, Eli Zaretskii wrote: > > > the removal is probably justified for 90% of use cases, maybe > > even more > > It's 100% There is no 100% in real life, so if you want to convince me, you will never use such arguments. > as in practice any use case that has trouble because of the > code removal will have significantly worse trouble on every GC (which is > also noninterruptible). memq calls maybe_quit because of circular lists, > not because of lists of length 1 billion, as huge lists don't work well > with Emacs anyway (due to GC). I don't see how arguments related to GC are relevant to the issue at hand. I'm interested in only one aspect of this change: how it is a good idea to lose the ability to interrupt long loops processing large Lisp data structures. > 1. The benchmark was so large that Emacs froze my system while building > the test-case list, i.e., before any of the newly-affected code was > executed. This was due to page thrashing. Obviously the draft change is > irrelevant here. I disagree that a use case with a paging system is irrelevant. > 3. The benchmark was medium sized (in my case, this was a list with 100 > million entries), so that Emacs was painfully slow but still barely > usable while the test case was being built or while garbage collection > was being done. In this case, the new memq was the least of the user's > problems, as the new memq was 4x faster than a garbage collect so the > C-g was delayed annoyingly for GC anyway. That is, GC makes Emacs so > painful to use even with length-100-million lists that people won't use > Emacs that way and we don't need to worry about treating such lists > specially. Once again, the issue with GC is not relevant. And the fact that removing some code makes loops faster is trivial and also not relevant. I'm sorry, but I remain unconvinced that we should remove these calls. I'm okay with replacing maybe_quit with rarely_quit, which should strike some hopefully more optimal middle ground. > By the way, I have found many cases where Emacs master will loop forever > and will ignore C-g. If you like, I can privately send you an Elisp > expression that, if you evaluate it, you cannot C-g out of. This problem > is independent of the draft patch, and is far more serious than the > somewhat-theoretical discussion we're having about memq and friends. We need to solve those problems, but that doesn't mean we should introduce new ones elsewhere. Being able to interrupt long loops in Emacs is an important feature. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 04 14:12:15 2017 Received: (at 25606) by debbugs.gnu.org; 4 Feb 2017 19:12:15 +0000 Received: from localhost ([127.0.0.1]:56301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ca5ks-0005ZH-Qw for submit@debbugs.gnu.org; Sat, 04 Feb 2017 14:12:14 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:46922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ca5kq-0005Z3-OR for 25606@debbugs.gnu.org; Sat, 04 Feb 2017 14:12:13 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id AE49E160061; Sat, 4 Feb 2017 11:12:06 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id cGRMZbEEbYzd; Sat, 4 Feb 2017 11:12:06 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0633716006A; Sat, 4 Feb 2017 11:12:06 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id icX58hixLpZ4; Sat, 4 Feb 2017 11:12:05 -0800 (PST) Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id DF4C8160061; Sat, 4 Feb 2017 11:12:05 -0800 (PST) Subject: =?UTF-8?Q?Re:_bug#25606:_[DRAFT_PATCH_2/2]_Signal_list_cycles_in_?= =?UTF-8?B?4oCYbGVuZ3Ro4oCZIGV0Yy4=?= To: Eli Zaretskii References: <20170201235622.30836-1-eggert@cs.ucla.edu> <20170201235622.30836-2-eggert@cs.ucla.edu> <83wpd8v6x8.fsf@gnu.org> <0a01d2ce-ef3e-7db0-6854-1b5e46d49be4@cs.ucla.edu> <83efzfvhbm.fsf@gnu.org> <08b0e359-3a9b-49f2-1299-51e899f86712@cs.ucla.edu> <83y3xm8gxp.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: Date: Sat, 4 Feb 2017 11:11:48 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <83y3xm8gxp.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25606 Cc: 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii wrote: > I remain unconvinced that we should remove these calls. I've provided several use cases and test code, all of which suggest that = the=20 maybe_quit calls are unnecessary. You have given no use cases that sugges= t=20 otherwise. So I'm puzzled as to why you remain convinced that these calls= are=20 needed. All I'm asking for is a practical use case; it shouldn't be that = hard to=20 give one, if the calls are really important. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 04 14:53:22 2017 Received: (at 25606) by debbugs.gnu.org; 4 Feb 2017 19:53:22 +0000 Received: from localhost ([127.0.0.1]:56318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ca6Og-0006V7-JY for submit@debbugs.gnu.org; Sat, 04 Feb 2017 14:53:22 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ca6Oe-0006Uu-Q0 for 25606@debbugs.gnu.org; Sat, 04 Feb 2017 14:53:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ca6OW-0002dq-Dn for 25606@debbugs.gnu.org; Sat, 04 Feb 2017 14:53:15 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ca6OW-0002dl-Ag; Sat, 04 Feb 2017 14:53:12 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2462 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ca6OU-0005zK-VW; Sat, 04 Feb 2017 14:53:12 -0500 Date: Sat, 04 Feb 2017 21:52:59 +0200 Message-Id: <838tpl91ic.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: (message from Paul Eggert on Sat, 4 Feb 2017 11:11:48 -0800) Subject: Re: bug#25606: [DRAFT PATCH 2/2] Signal list cycles in =?utf-8?B?4oCYbGVuZ3Ro4oCZ?= etc. References: <20170201235622.30836-1-eggert@cs.ucla.edu> <20170201235622.30836-2-eggert@cs.ucla.edu> <83wpd8v6x8.fsf@gnu.org> <0a01d2ce-ef3e-7db0-6854-1b5e46d49be4@cs.ucla.edu> <83efzfvhbm.fsf@gnu.org> <08b0e359-3a9b-49f2-1299-51e899f86712@cs.ucla.edu> <83y3xm8gxp.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25606 Cc: 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 25606@debbugs.gnu.org > From: Paul Eggert > Date: Sat, 4 Feb 2017 11:11:48 -0800 > > Eli Zaretskii wrote: > > I remain unconvinced that we should remove these calls. > > I've provided several use cases and test code, all of which suggest that the > maybe_quit calls are unnecessary. You have given no use cases that suggest > otherwise. So I'm puzzled as to why you remain convinced that these calls are > needed. All I'm asking for is a practical use case; it shouldn't be that hard to > give one, if the calls are really important. I did provide use cases, you just dismiss them as unimportant. They are rare and perhaps even marginal, but they do exist. And this feature exists precisely for rare and marginal situations. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 04 16:45:31 2017 Received: (at 25606) by debbugs.gnu.org; 4 Feb 2017 21:45:31 +0000 Received: from localhost ([127.0.0.1]:56352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ca89C-00010A-QO for submit@debbugs.gnu.org; Sat, 04 Feb 2017 16:45:31 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ca89A-0000tM-IN for 25606@debbugs.gnu.org; Sat, 04 Feb 2017 16:45:29 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7063F160061; Sat, 4 Feb 2017 13:45:22 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 1GO_oN2qSR5m; Sat, 4 Feb 2017 13:45:21 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C214116006A; Sat, 4 Feb 2017 13:45:21 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 6bwOoO_zs2a1; Sat, 4 Feb 2017 13:45:21 -0800 (PST) Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id A6E1F160061; Sat, 4 Feb 2017 13:45:21 -0800 (PST) Subject: =?UTF-8?Q?Re:_bug#25606:_[DRAFT_PATCH_2/2]_Signal_list_cycles_in_?= =?UTF-8?B?4oCYbGVuZ3Ro4oCZIGV0Yy4=?= To: Eli Zaretskii References: <20170201235622.30836-1-eggert@cs.ucla.edu> <20170201235622.30836-2-eggert@cs.ucla.edu> <83wpd8v6x8.fsf@gnu.org> <0a01d2ce-ef3e-7db0-6854-1b5e46d49be4@cs.ucla.edu> <83efzfvhbm.fsf@gnu.org> <08b0e359-3a9b-49f2-1299-51e899f86712@cs.ucla.edu> <83y3xm8gxp.fsf@gnu.org> <838tpl91ic.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <6e0e2bd1-8000-a210-f8f2-d2f91b178058@cs.ucla.edu> Date: Sat, 4 Feb 2017 13:45:21 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <838tpl91ic.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25606 Cc: 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii wrote: > I did provide use cases, you just dismiss them as unimportant. You mentioned use cases consisting of "a memory-starved system or a syste= m under=20 heavy computational load". My test code attempted to exercise both=20 possibilities, under different scenarios. My tests came up empty: there w= ere no=20 cases that caused new problems. Perhaps I misunderstood what you were dri= ving=20 at, but if so I would like to know what it was. Possibly there is a=20 more-efficient change that would satisfy your concerns, once I understand= them. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 05 13:46:10 2017 Received: (at 25606) by debbugs.gnu.org; 5 Feb 2017 18:46:10 +0000 Received: from localhost ([127.0.0.1]:56881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1caRpC-0000Um-Bf for submit@debbugs.gnu.org; Sun, 05 Feb 2017 13:46:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1caRp9-0000UI-R0 for 25606@debbugs.gnu.org; Sun, 05 Feb 2017 13:46:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1caRp0-0000qD-Rz for 25606@debbugs.gnu.org; Sun, 05 Feb 2017 13:46:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37913) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1caRp0-0000q7-Oc; Sun, 05 Feb 2017 13:45:58 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3824 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1caRoz-0000XA-FP; Sun, 05 Feb 2017 13:45:58 -0500 Date: Sun, 05 Feb 2017 20:45:48 +0200 Message-Id: <83r33c79yb.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <6e0e2bd1-8000-a210-f8f2-d2f91b178058@cs.ucla.edu> (message from Paul Eggert on Sat, 4 Feb 2017 13:45:21 -0800) Subject: Re: bug#25606: [DRAFT PATCH 2/2] Signal list cycles in =?utf-8?B?4oCYbGVuZ3Ro4oCZ?= etc. References: <20170201235622.30836-1-eggert@cs.ucla.edu> <20170201235622.30836-2-eggert@cs.ucla.edu> <83wpd8v6x8.fsf@gnu.org> <0a01d2ce-ef3e-7db0-6854-1b5e46d49be4@cs.ucla.edu> <83efzfvhbm.fsf@gnu.org> <08b0e359-3a9b-49f2-1299-51e899f86712@cs.ucla.edu> <83y3xm8gxp.fsf@gnu.org> <838tpl91ic.fsf@gnu.org> <6e0e2bd1-8000-a210-f8f2-d2f91b178058@cs.ucla.edu> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25606 Cc: 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 25606@debbugs.gnu.org > From: Paul Eggert > Date: Sat, 4 Feb 2017 13:45:21 -0800 > > Eli Zaretskii wrote: > > > I did provide use cases, you just dismiss them as unimportant. > > You mentioned use cases consisting of "a memory-starved system or a system under > heavy computational load". My test code attempted to exercise both > possibilities, under different scenarios. My tests came up empty: there were no > cases that caused new problems. That was your interpretation of the results. It isn't mine: I don't think that the fact that in your particular testing GC was a bugger problem than the uninterruptible loop means the ability to interrupt those loops has no value. Besides, one particular simulation of the problem is not convincing enough anyway. > Perhaps I misunderstood what you were driving at, but if so I would > like to know what it was. I don't see what else can I explain in addition to what I already did. > Possibly there is a more-efficient change that would satisfy your > concerns, once I understand them. How about if I turn the table and ask why is it so important to remove those calls? From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 05 16:17:10 2017 Received: (at 25606) by debbugs.gnu.org; 5 Feb 2017 21:17:10 +0000 Received: from localhost ([127.0.0.1]:56964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1caUBK-0003wa-Gv for submit@debbugs.gnu.org; Sun, 05 Feb 2017 16:17:10 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:39108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1caUBI-0003wN-Ee for 25606@debbugs.gnu.org; Sun, 05 Feb 2017 16:17:08 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7B04916006A; Sun, 5 Feb 2017 13:17:01 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id zSNO9HOsoJtj; Sun, 5 Feb 2017 13:17:00 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CA35016007E; Sun, 5 Feb 2017 13:17:00 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id LZJPY9HMuRKM; Sun, 5 Feb 2017 13:17:00 -0800 (PST) Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id AC76316006A; Sun, 5 Feb 2017 13:17:00 -0800 (PST) Subject: =?UTF-8?Q?Re:_bug#25606:_[DRAFT_PATCH_2/2]_Signal_list_cycles_in_?= =?UTF-8?B?4oCYbGVuZ3Ro4oCZIGV0Yy4=?= To: Eli Zaretskii References: <20170201235622.30836-1-eggert@cs.ucla.edu> <20170201235622.30836-2-eggert@cs.ucla.edu> <83wpd8v6x8.fsf@gnu.org> <0a01d2ce-ef3e-7db0-6854-1b5e46d49be4@cs.ucla.edu> <83efzfvhbm.fsf@gnu.org> <08b0e359-3a9b-49f2-1299-51e899f86712@cs.ucla.edu> <83y3xm8gxp.fsf@gnu.org> <838tpl91ic.fsf@gnu.org> <6e0e2bd1-8000-a210-f8f2-d2f91b178058@cs.ucla.edu> <83r33c79yb.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: Date: Sun, 5 Feb 2017 13:17:00 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <83r33c79yb.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25606 Cc: 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii wrote: > How about if I turn the table and ask why is it so important to remove > those calls? Because they make Emacs bigger and slower for no good reason. A vague feeling that there might be a need for them in an unrealistic use case is not a good reason. However, your mind is made up and we're wasting time discussing this, so I give up and will install a patch with the unnecessary code. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 05 16:31:03 2017 Received: (at 25606) by debbugs.gnu.org; 5 Feb 2017 21:31:03 +0000 Received: from localhost ([127.0.0.1]:56970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1caUOl-0004H1-0S for submit@debbugs.gnu.org; Sun, 05 Feb 2017 16:31:03 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:40442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1caUOj-0004GP-5v; Sun, 05 Feb 2017 16:31:01 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8673D16006A; Sun, 5 Feb 2017 13:30:55 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 0W7VKPMP63rD; Sun, 5 Feb 2017 13:30:54 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B645C16007E; Sun, 5 Feb 2017 13:30:54 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 2FtXn0A2LRgF; Sun, 5 Feb 2017 13:30:54 -0800 (PST) Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 94FDC16006A; Sun, 5 Feb 2017 13:30:54 -0800 (PST) To: 25606@debbugs.gnu.org, 25605@debbugs.gnu.org From: Paul Eggert Subject: patches installed for 25605, 25606 Organization: UCLA Computer Science Department Message-ID: <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> Date: Sun, 5 Feb 2017 13:30:54 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25606 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) I installed patches for Bug#25605 and Bug#25606, along with all suggested revisions to the patches, and am closing the bug reports. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 06 11:04:37 2017 Received: (at 25606) by debbugs.gnu.org; 6 Feb 2017 16:04:37 +0000 Received: from localhost ([127.0.0.1]:57975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1calmP-0007oD-4i for submit@debbugs.gnu.org; Mon, 06 Feb 2017 11:04:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1calmN-0007o1-EY for 25606@debbugs.gnu.org; Mon, 06 Feb 2017 11:04:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1calmF-0006BZ-DB for 25606@debbugs.gnu.org; Mon, 06 Feb 2017 11:04:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1calm6-000673-Lo; Mon, 06 Feb 2017 11:04:18 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4635 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1calm5-0005BS-Qn; Mon, 06 Feb 2017 11:04:18 -0500 Date: Mon, 06 Feb 2017 18:04:14 +0200 Message-Id: <83bmuf71c1.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> (message from Paul Eggert on Sun, 5 Feb 2017 13:30:54 -0800) Subject: Re: bug#25606: patches installed for 25605, 25606 References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25606 Cc: 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Paul Eggert > Date: Sun, 5 Feb 2017 13:30:54 -0800 > > I installed patches for Bug#25605 and Bug#25606, along with all suggested > revisions to the patches, and am closing the bug reports. Thanks. Any reasons why the tests are in manual/cyclic-tests.el, and not in src/fns-tests.el? The tests don't need to be run interactively, do they? From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 07 01:53:45 2017 Received: (at 25606) by debbugs.gnu.org; 7 Feb 2017 06:53:45 +0000 Received: from localhost ([127.0.0.1]:58254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cazer-0004sF-Jf for submit@debbugs.gnu.org; Tue, 07 Feb 2017 01:53:45 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:42074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cazeo-0004rv-Fz; Tue, 07 Feb 2017 01:53:43 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 61289160058; Mon, 6 Feb 2017 22:53:36 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id O8XFzHfFPX6S; Mon, 6 Feb 2017 22:53:35 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8DF4A16007F; Mon, 6 Feb 2017 22:53:35 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id MbgRHQvHGuNI; Mon, 6 Feb 2017 22:53:35 -0800 (PST) Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 6FA4F160058; Mon, 6 Feb 2017 22:53:35 -0800 (PST) Subject: Re: bug#25606: patches installed for 25605, 25606 To: Eli Zaretskii References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> Date: Mon, 6 Feb 2017 22:53:35 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <83bmuf71c1.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25606 Cc: 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii wrote: > Any reasons why the tests are in manual/cyclic-tests.el, and not in > src/fns-tests.el? No particular reason, no. I don't know my way around the test directories well; please feel free to move them. > The tests don't need to be run interactively, do > they? Only if they fail (i.e., loop forever). From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 07 07:47:23 2017 Received: (at 25606) by debbugs.gnu.org; 7 Feb 2017 12:47:23 +0000 Received: from localhost ([127.0.0.1]:58379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cb5B5-0006Ja-K1 for submit@debbugs.gnu.org; Tue, 07 Feb 2017 07:47:23 -0500 Received: from mail-oi0-f42.google.com ([209.85.218.42]:35022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cb5B3-0006JH-S3; Tue, 07 Feb 2017 07:47:22 -0500 Received: by mail-oi0-f42.google.com with SMTP id j15so63891202oih.2; Tue, 07 Feb 2017 04:47:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7VCTG2OlQ41wntOxxS4/lN4wZ85XnfehcR0mxoIhMTM=; b=Xx/CQy0gfnVJeusl3yepHVHv0GZocBDJMGvNK7LogtXODppMnBqhDSkP0GPFh3u2Js /QoP0xp2bHGYORJRGPfVTJsyOPq3c1NcBJlW30S50eLZ754ooLV+AJPTnu+TzBM4WrrT BqvFo3hkEGiLzfVCWEHypDWYNG1z5Vbt8MBwp8DdRFano7fp7G5Oe005zw//Cc/mdo4T moa7+w0iW2HZXeq7AwqmVI7MXB8pKXSpO/4EBYqAqdKpKVzIrsE/FPoWJYFAfGhdfctQ BQSs7V5X0znG93Pm4dkHn00ZUmXY9UUdM0fMEgX9EOlA12INP/WNr9xXfgxBcJ3XbY+p sM4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7VCTG2OlQ41wntOxxS4/lN4wZ85XnfehcR0mxoIhMTM=; b=T/rB27q5u8vS3V0X8aub/4Eefc1vihPmRmLwfoONstZOrR5fcqkmqtIpqdum/IqYNv uoD//LC4Nkn4fZo23SriG9ybnzuut/iDLC7NhkuzdA6jHcNtFW3SCM27AGvjLbhRfNiu khzjEHaL6cwIAme7yw7hn86dScyM3veOTZldqKTM1dv2OUZ8QqVJvZ0Fe5gr9BgEvlzM c0wxABeT03DZoCiAsIyXwUS59pglYAXHYZQZzMaIqN/LvN+bZoq9LxRfahjk0vRX9vpZ gCZVMh0tQv1EVjxViXIAs2+cjdv6YM8wXqSTKbmGajQ7q+tHNVSEOWZq7C0f5OpGBQcD /0Zg== X-Gm-Message-State: AMke39mAIFLBKkpI+8j9Mrf3oOY+jVDWM66F9X3egt1LMmzHAfj7HCR7/HtZZqvhNKciZUHubZLbmMj4F1GRsA== X-Received: by 10.202.235.215 with SMTP id j206mr7948275oih.74.1486471636065; Tue, 07 Feb 2017 04:47:16 -0800 (PST) MIME-Version: 1.0 References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> In-Reply-To: <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> From: Philipp Stephani Date: Tue, 07 Feb 2017 12:47:05 +0000 Message-ID: Subject: Re: bug#25606: patches installed for 25605, 25606 To: Paul Eggert , Eli Zaretskii Content-Type: multipart/alternative; boundary=001a113ce900d623e80547f0259f X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 25606 Cc: 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --001a113ce900d623e80547f0259f Content-Type: text/plain; charset=UTF-8 Paul Eggert schrieb am Di., 7. Feb. 2017 um 07:54 Uhr: > > > The tests don't need to be run interactively, do > > they? > > Only if they fail (i.e., loop forever). > > If they fail, shouldn't the test runner that runs these tests time out after some time and mark them as failures? --001a113ce900d623e80547f0259f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Paul E= ggert <eggert@cs.ucla.edu> = schrieb am Di., 7. Feb. 2017 um 07:54=C2=A0Uhr:

> The tests don't need to be run interactively, do
> they?

Only if they fail (i.e., loop forever).


If they fail, shouldn't the test runne= r that runs these tests time out after some time and mark them as failures?= =C2=A0
--001a113ce900d623e80547f0259f-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 07 11:32:40 2017 Received: (at 25606) by debbugs.gnu.org; 7 Feb 2017 16:32:40 +0000 Received: from localhost ([127.0.0.1]:59189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cb8h5-0003UB-Tg for submit@debbugs.gnu.org; Tue, 07 Feb 2017 11:32:40 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:39414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cb8h3-0003Tn-EP; Tue, 07 Feb 2017 11:32:38 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 65EDB160058; Tue, 7 Feb 2017 08:32:31 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id MFclPStbyTfr; Tue, 7 Feb 2017 08:32:30 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B8835160088; Tue, 7 Feb 2017 08:32:30 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id y49k4ox2ZP2L; Tue, 7 Feb 2017 08:32:30 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9F3D2160058; Tue, 7 Feb 2017 08:32:30 -0800 (PST) Subject: Re: bug#25606: patches installed for 25605, 25606 To: Philipp Stephani , Eli Zaretskii References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <42bf63df-416e-7623-8f59-862fbd55f2f3@cs.ucla.edu> Date: Tue, 7 Feb 2017 08:32:27 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25606 Cc: 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On 02/07/2017 04:47 AM, Philipp Stephani wrote: > If they fail, shouldn't the test runner that runs these tests time out > after some time and mark them as failures? Not if the test runner is written in elisp. The loops are deep in the C code and are immune to elisp timeouts. (I don't know how the test runner works.) From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 07 16:48:02 2017 Received: (at 25606) by debbugs.gnu.org; 7 Feb 2017 21:48:02 +0000 Received: from localhost ([127.0.0.1]:59347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbDcI-00047w-LN for submit@debbugs.gnu.org; Tue, 07 Feb 2017 16:48:02 -0500 Received: from mail-ot0-f174.google.com ([74.125.82.174]:34905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbDcG-00047M-Gn; Tue, 07 Feb 2017 16:48:01 -0500 Received: by mail-ot0-f174.google.com with SMTP id 65so97033067otq.2; Tue, 07 Feb 2017 13:48:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2YMAFsOvZo+3kEn4+akPUpninEGp7PVBl4Q2EoKM2w8=; b=IbordQDdOwGtpznsySCnJcImSBNqQxs0XODuDYcB4Lbj5fNq9Yzz1l63MY5t8qE4+a uZceG9EgfTjXHwsI0EqiWgXVAqycPjzyFi4wsAKh9Xb0KxeEGQxdko3x/3b+5E32KMyl NLzwxuGMqCsOFNl4DjCltKvrO55ZuidAd3MPZvcMsDrCBQr+2afaRhICOkwDjYYCU5rp dmUVE8a/lQtvNCLaH82Tn8Q6j0t06pq4t8Bw4ZEIL9bl7XnAEUQ9x5d5/4D4dVFZ0zio iGlTVvHpXNT23EfJ4ghgFrcAlWOOMW1PV5OyVjjqkiXS2Y8JCk2FQPjITMnL3+9Mfrlo 450g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2YMAFsOvZo+3kEn4+akPUpninEGp7PVBl4Q2EoKM2w8=; b=Y2qnBCjFTHxBSSZb6inSj9LSqOm2bfTPtyZsf4tu1eWVKG5UE2y9IyTnYBs6CxgGgu skgdCNmWFREYN84t4F+O/9BAy5GvQsEJJ78SMjfX6QCGA0DyCCwGRfz8rolG7k6ybyIB g8secjiRk9Z0U3s/nguMF5F0pglj20xe/rdwVZdYMo2q6h0+CjMXltsI5BqPgFdMU6+i w09gx6p1oou8wKdc90qufNANurGc4bfSBzLi6Zp07LOxGEWD7MdCHwaySb9Zs9LSJGuq 8MlLvI/39zz4GC+iuyZHmDVKnTXUK+CAlFTFTibPArvycO/VABSqab2M1GfvFdibv0bY oqyA== X-Gm-Message-State: AIkVDXL/BCYj9R+MEnrFuxhqs3G2oPBzNPBlFbJkKHbusHvKImt3iCLdnaA93h2tWUsuyiZBGtHO4GbvK6+1Dg== X-Received: by 10.157.16.27 with SMTP id h27mr8902639ote.120.1486504074820; Tue, 07 Feb 2017 13:47:54 -0800 (PST) MIME-Version: 1.0 References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> <42bf63df-416e-7623-8f59-862fbd55f2f3@cs.ucla.edu> In-Reply-To: <42bf63df-416e-7623-8f59-862fbd55f2f3@cs.ucla.edu> From: Philipp Stephani Date: Tue, 07 Feb 2017 21:47:42 +0000 Message-ID: Subject: Re: bug#25606: patches installed for 25605, 25606 To: Paul Eggert , Eli Zaretskii Content-Type: multipart/alternative; boundary=001a113dffc05642d80547f7b3f6 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 25606 Cc: 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --001a113dffc05642d80547f7b3f6 Content-Type: text/plain; charset=UTF-8 Paul Eggert schrieb am Di., 7. Feb. 2017 um 17:32 Uhr: > On 02/07/2017 04:47 AM, Philipp Stephani wrote: > > If they fail, shouldn't the test runner that runs these tests time out > > after some time and mark them as failures? > > Not if the test runner is written in elisp. The loops are deep in the C > code and are immune to elisp timeouts. (I don't know how the test runner > works.) > > How about running the Emacs binary wrapped in /usr/bin/timeout? --001a113dffc05642d80547f7b3f6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Paul E= ggert <eggert@cs.ucla.edu> = schrieb am Di., 7. Feb. 2017 um 17:32=C2=A0Uhr:
On 02/07/2017 04:47 AM, Philipp Stephani wrote:
> If they fail, shouldn't the test runner that runs these tests time= out
> after some time and mark them as failures?

Not if the test runner is written in elisp. The loops are deep in the C
code and are immune to elisp timeouts. (I don't know how the test runne= r
works.)


How about running = the Emacs binary wrapped in /usr/bin/timeout?=C2=A0
--001a113dffc05642d80547f7b3f6-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 07 17:20:22 2017 Received: (at 25606) by debbugs.gnu.org; 7 Feb 2017 22:20:22 +0000 Received: from localhost ([127.0.0.1]:59360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbE7Z-0004ry-P9 for submit@debbugs.gnu.org; Tue, 07 Feb 2017 17:20:21 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:50116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbE7X-0004rd-8m; Tue, 07 Feb 2017 17:20:19 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6DD601600AF; Tue, 7 Feb 2017 14:20:12 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ZNMEN3l56TuP; Tue, 7 Feb 2017 14:20:11 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id AF34E1600AE; Tue, 7 Feb 2017 14:20:11 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id EHl5LxwuD7D2; Tue, 7 Feb 2017 14:20:11 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9491B160090; Tue, 7 Feb 2017 14:20:11 -0800 (PST) Subject: Re: bug#25606: patches installed for 25605, 25606 To: Philipp Stephani , Eli Zaretskii References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> <42bf63df-416e-7623-8f59-862fbd55f2f3@cs.ucla.edu> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <17280878-f096-fc0b-5fc8-6980aff4624f@cs.ucla.edu> Date: Tue, 7 Feb 2017 14:20:11 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25606 Cc: 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On 02/07/2017 01:47 PM, Philipp Stephani wrote: > How about running the Emacs binary wrapped in /usr/bin/timeout? That should work on GNU platforms. 'timeout' is not a standard program, though, and we can't rely on its presence on non-GNU platforms. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 07 17:55:25 2017 Received: (at 25606) by debbugs.gnu.org; 7 Feb 2017 22:55:25 +0000 Received: from localhost ([127.0.0.1]:59380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbEfV-0005ik-D4 for submit@debbugs.gnu.org; Tue, 07 Feb 2017 17:55:25 -0500 Received: from mail-ot0-f180.google.com ([74.125.82.180]:34592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbEfT-0005iR-V8; Tue, 07 Feb 2017 17:55:24 -0500 Received: by mail-ot0-f180.google.com with SMTP id f9so98209207otd.1; Tue, 07 Feb 2017 14:55:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m3Vf13D6wuS60JZa+D6qNYQxYamKU5BstKezqUqGuHk=; b=BHRj9bqfiLRTC56sZTzLNZTu/ubzpKCY37R1fdfBAJDU2cz4FSd0DV5zFJ4FyWS0it BgkK57h0gD0pUJZNy3HzNFVxcb9rhfpcd17+2v/c7ldaNH5dqadBKGhyozgoU2A4mJPL UTzg/Jk4JWT9ooRDK/bxjWhadf3zTE5PoyfOsjd4BfkyERPrEzxsZ6bsHhb9BrtMMVgp UlInpfuNRCdsWJEF7xIdbHiO10dXWc5Yqe7M3FjkmsKngKOwAVEwPVwDyiPSJzZ2QpKf e5jG7IYNM0I3Q05wzmEXqLnIT9yAKoPKKvZ3XlqtBEKHNDtL6X0L1MpU4IoLMykLxFLQ w/ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m3Vf13D6wuS60JZa+D6qNYQxYamKU5BstKezqUqGuHk=; b=BB/z4r/56N7uNTBbL6BQyGsuFdk3ZSazGbFtrBaUUgKqnbvooa2btCFQ2gsa3DXYgz SBMGNL8jgm2arL/r16iwZzGe5uX3S2+wDHWTgAKwRHfCH+PVCayzosQ/A5WyQfwT0lz0 HTygKahLFlwOXngqybMu4Lv307wpEMTCq1V5fPpj1qW2+37ga6chDtKiKbn8l+8Xkcdd ln8gxI2vOJ72th/2snpuit4PK7rWENZszZmH6NSL/Rydfll4FY/6RNdrpvlb8g7b8+yT u5La28BdXhmPebqOn0au8G4uTuZ9r59QHuMOidM381r0GydVc1Oscl3Y5cQiBbjHnDR2 awHw== X-Gm-Message-State: AIkVDXIrKpcieGbf15EudPG9PhKcdWSbwzYInS2Rl9HDPaAYM0CsfDWqe5uWb9jBC1zzaeZThuuIQVjngWUHvg== X-Received: by 10.157.3.209 with SMTP id f75mr8665401otf.261.1486508118455; Tue, 07 Feb 2017 14:55:18 -0800 (PST) MIME-Version: 1.0 References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> <42bf63df-416e-7623-8f59-862fbd55f2f3@cs.ucla.edu> <17280878-f096-fc0b-5fc8-6980aff4624f@cs.ucla.edu> In-Reply-To: <17280878-f096-fc0b-5fc8-6980aff4624f@cs.ucla.edu> From: Philipp Stephani Date: Tue, 07 Feb 2017 22:55:07 +0000 Message-ID: Subject: Re: bug#25606: patches installed for 25605, 25606 To: Paul Eggert , Eli Zaretskii Content-Type: multipart/alternative; boundary=94eb2c03c8ce5b3d200547f8a422 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 25606 Cc: 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --94eb2c03c8ce5b3d200547f8a422 Content-Type: text/plain; charset=UTF-8 Paul Eggert schrieb am Di., 7. Feb. 2017 um 23:20 Uhr: > On 02/07/2017 01:47 PM, Philipp Stephani wrote: > > How about running the Emacs binary wrapped in /usr/bin/timeout? > > That should work on GNU platforms. 'timeout' is not a standard program, > though, and we can't rely on its presence on non-GNU platforms. > > This is only for running tests; don't we already require autotools for that as well? We could also check for it in configure using AC_CHECK_PROGS. --94eb2c03c8ce5b3d200547f8a422 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Paul E= ggert <eggert@cs.ucla.edu> = schrieb am Di., 7. Feb. 2017 um 23:20=C2=A0Uhr:
On 02/07/2017 01:47 PM, Philipp Stephani wrote:
> How about running the Emacs binary wrapped in /usr/bin/timeout?

That should work on GNU platforms. 'timeout' is not a standard prog= ram,
though, and we can't rely on its presence on non-GNU platforms.


This is only for r= unning tests; don't we already require autotools for that as well? We c= ould also check for it in configure using AC_CHECK_PROGS.=C2=A0
=
--94eb2c03c8ce5b3d200547f8a422-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 10 04:59:32 2017 Received: (at 25606) by debbugs.gnu.org; 10 Feb 2017 09:59:32 +0000 Received: from localhost ([127.0.0.1]:33846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cc7zI-0003T6-9P for submit@debbugs.gnu.org; Fri, 10 Feb 2017 04:59:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cc7zH-0003Su-B2 for 25606@debbugs.gnu.org; Fri, 10 Feb 2017 04:59:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cc7z9-000075-4t for 25606@debbugs.gnu.org; Fri, 10 Feb 2017 04:59:26 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60071) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cc7z0-00005B-07; Fri, 10 Feb 2017 04:59:14 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4606 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cc7yy-0006As-TR; Fri, 10 Feb 2017 04:59:13 -0500 Date: Fri, 10 Feb 2017 11:59:20 +0200 Message-Id: <837f4y4b9j.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> (message from Paul Eggert on Mon, 6 Feb 2017 22:53:35 -0800) Subject: Re: bug#25606: patches installed for 25605, 25606 References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25606 Cc: 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 25606@debbugs.gnu.org, 25605@debbugs.gnu.org > From: Paul Eggert > Date: Mon, 6 Feb 2017 22:53:35 -0800 > > Eli Zaretskii wrote: > > Any reasons why the tests are in manual/cyclic-tests.el, and not in > > src/fns-tests.el? > > No particular reason, no. I don't know my way around the test directories well; > please feel free to move them. Done. I took the liberty to do the commit in your name, to keep the attribution of the code to the original author. Btw, 3 of the new tests fail for me: Test test-cycle-lax-plist-get backtrace: (setq value-1366 (apply fn-1364 args-1365)) (unwind-protect (setq value-1366 (apply fn-1364 args-1365)) (setq fo (not (unwind-protect (setq value-1366 (apply fn-1364 args-1365)) (se (if (not (unwind-protect (setq value-1366 (apply fn-1364 args-1365)) (let (form-description-1368) (if (not (unwind-protect (setq value-13 (let ((value-1366 (quote ert-form-evaluation-aborted-1367))) (let (f (let ((fn-1364 (function lax-plist-get)) (args-1365 (list d1 2))) (l (let ((c1 (cyc1 1)) (c2 (cyc2 1 2)) (d1 (dot1 1)) (d2 (dot2 1 2))) ( (lambda nil (let ((c1 (cyc1 1)) (c2 (cyc2 1 2)) (d1 (dot1 1)) (d2 (d ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc ert-run-test([cl-struct-ert-test test-cycle-lax-plist-get nil (lambd ert-run-or-rerun-test([cl-struct-ert--stats t [[cl-struct-ert-test f ert-run-tests(t #[385 "\306☻\307\"\203G \211\211G\310U\203¶ \211@\20 ert-run-tests-batch(nil) ert-run-tests-batch-and-exit(nil) eval((ert-run-tests-batch-and-exit nil)) command-line-1(("-L" ";." "-l" "ert" "-l" "src/fns-tests.el" "--eval command-line() normal-top-level() Test test-cycle-lax-plist-get condition: (wrong-type-argument listp (1 1 1 1 1 1 1 1 1 1 . tail)) FAILED 18/31 test-cycle-lax-plist-get Test test-cycle-lax-plist-put backtrace: (setq value-1570 (apply fn-1568 args-1569)) (unwind-protect (setq value-1570 (apply fn-1568 args-1569)) (setq fo (if (unwind-protect (setq value-1570 (apply fn-1568 args-1569)) (set (let (form-description-1572) (if (unwind-protect (setq value-1570 (a (let ((value-1570 (quote ert-form-evaluation-aborted-1571))) (let (f (let ((fn-1568 (function lax-plist-put)) (args-1569 (list d1 2 2))) (let ((c1 (cyc1 1)) (c2 (cyc2 1 2)) (d1 (dot1 1)) (d2 (dot2 1 2))) ( (lambda nil (let ((c1 (cyc1 1)) (c2 (cyc2 1 2)) (d1 (dot1 1)) (d2 (d ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc ert-run-test([cl-struct-ert-test test-cycle-lax-plist-put nil (lambd ert-run-or-rerun-test([cl-struct-ert--stats t [[cl-struct-ert-test f ert-run-tests(t #[385 "\306☻\307\"\203G \211\211G\310U\203¶ \211@\20 ert-run-tests-batch(nil) ert-run-tests-batch-and-exit(nil) eval((ert-run-tests-batch-and-exit nil)) command-line-1(("-L" ";." "-l" "ert" "-l" "src/fns-tests.el" "--eval command-line() normal-top-level() Test test-cycle-lax-plist-put condition: (wrong-type-argument listp (1 1 1 1 1 1 1 1 1 1 . tail)) FAILED 19/31 test-cycle-lax-plist-put passed 20/31 test-cycle-length passed 21/31 test-cycle-member passed 22/31 test-cycle-memq passed 23/31 test-cycle-memql passed 24/31 test-cycle-nconc passed 25/31 test-cycle-plist-get passed 26/31 test-cycle-plist-member Test test-cycle-plist-put backtrace: (setq value-1504 (apply fn-1502 args-1503)) (unwind-protect (setq value-1504 (apply fn-1502 args-1503)) (setq fo (if (unwind-protect (setq value-1504 (apply fn-1502 args-1503)) (set (let (form-description-1506) (if (unwind-protect (setq value-1504 (a (let ((value-1504 (quote ert-form-evaluation-aborted-1505))) (let (f (let ((fn-1502 (function plist-put)) (args-1503 (list d1 2 2))) (let (let ((c1 (cyc1 1)) (c2 (cyc2 1 2)) (d1 (dot1 1)) (d2 (dot2 1 2))) ( (lambda nil (let ((c1 (cyc1 1)) (c2 (cyc2 1 2)) (d1 (dot1 1)) (d2 (d ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc ert-run-test([cl-struct-ert-test test-cycle-plist-put nil (lambda ni ert-run-or-rerun-test([cl-struct-ert--stats t [[cl-struct-ert-test f ert-run-tests(t #[385 "\306☻\307\"\203G \211\211G\310U\203¶ \211@\20 ert-run-tests-batch(nil) ert-run-tests-batch-and-exit(nil) eval((ert-run-tests-batch-and-exit nil)) command-line-1(("-L" ";." "-l" "ert" "-l" "src/fns-tests.el" "--eval command-line() normal-top-level() Test test-cycle-plist-put condition: (wrong-type-argument listp (1 1 1 1 1 1 1 1 1 1 . tail)) FAILED 27/31 test-cycle-plist-put passed 28/31 test-cycle-rassoc passed 29/31 test-cycle-rassq passed 30/31 test-cycle-reverse passed 31/31 test-cycle-safe-length Ran 31 tests, 28 results as expected, 3 unexpected (2017-02-10 11:49:19+0200) From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 03:31:10 2017 Received: (at 25606) by debbugs.gnu.org; 12 Feb 2017 08:31:11 +0000 Received: from localhost ([127.0.0.1]:36155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccpYs-0006Ok-On for submit@debbugs.gnu.org; Sun, 12 Feb 2017 03:31:10 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:54884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccpYr-0006OO-5E; Sun, 12 Feb 2017 03:31:09 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8D28F160052; Sun, 12 Feb 2017 00:31:03 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id X5eJeFlzQiEi; Sun, 12 Feb 2017 00:31:02 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D0A4C160054; Sun, 12 Feb 2017 00:31:02 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 6y0bhWrfrfhG; Sun, 12 Feb 2017 00:31:02 -0800 (PST) Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id A9939160052; Sun, 12 Feb 2017 00:31:02 -0800 (PST) Subject: Re: bug#25606: patches installed for 25605, 25606 To: Eli Zaretskii References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> <837f4y4b9j.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <355cf7f1-5fc0-cbb4-f806-3f335c14016a@cs.ucla.edu> Date: Sun, 12 Feb 2017 00:31:02 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <837f4y4b9j.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25606 Cc: 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii wrote: > I took the liberty to do the commit in your name, to keep the > attribution of the code to the original author. > > Btw, 3 of the new tests fail for me: Although the new tests fail for me too, they succeed if I revert commit 65298ff4d5861cbc8d88162d58c18fa972b81acf, i.e., the commit that you installed in my name. So there must be something wrong with that commit. It would be easy to revert the commit but I assume that it was done for a reason so I'll wait for you to look into the problem. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 11:13:09 2017 Received: (at 25606) by debbugs.gnu.org; 12 Feb 2017 16:13:09 +0000 Received: from localhost ([127.0.0.1]:37200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccwlx-0000LM-Fd for submit@debbugs.gnu.org; Sun, 12 Feb 2017 11:13:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccwlu-0000Kr-Jo for 25606@debbugs.gnu.org; Sun, 12 Feb 2017 11:13:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ccwlm-0001A9-Db for 25606@debbugs.gnu.org; Sun, 12 Feb 2017 11:13:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ccwld-00017V-Lb; Sun, 12 Feb 2017 11:12:49 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3778 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ccwlc-0008IK-Mo; Sun, 12 Feb 2017 11:12:49 -0500 Date: Sun, 12 Feb 2017 18:13:03 +0200 Message-Id: <83efz32xrk.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <355cf7f1-5fc0-cbb4-f806-3f335c14016a@cs.ucla.edu> (message from Paul Eggert on Sun, 12 Feb 2017 00:31:02 -0800) Subject: Re: bug#25606: patches installed for 25605, 25606 References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> <837f4y4b9j.fsf@gnu.org> <355cf7f1-5fc0-cbb4-f806-3f335c14016a@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25606 Cc: 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 25606@debbugs.gnu.org, 25605@debbugs.gnu.org > From: Paul Eggert > Date: Sun, 12 Feb 2017 00:31:02 -0800 > > Eli Zaretskii wrote: > > I took the liberty to do the commit in your name, to keep the > > attribution of the code to the original author. > > > > Btw, 3 of the new tests fail for me: > > Although the new tests fail for me too, they succeed if I revert commit > 65298ff4d5861cbc8d88162d58c18fa972b81acf, i.e., the commit that you installed in > my name. So there must be something wrong with that commit. That's strange. Before pushing, I verified that I get the same failures with your original test file. But maybe I didn't invoke the test as you intended it to be run. Here's how I invoke it: $ cd test && ../src/emacs -batch -l ert -l manual/cycle-tests.el --eval "(ert-run-tests-batch-and-exit nil)" If that's wrong, what is the right way of running those tests? From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 13:55:18 2017 Received: (at 25606) by debbugs.gnu.org; 12 Feb 2017 18:55:18 +0000 Received: from localhost ([127.0.0.1]:37317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cczIs-0007Y4-BO for submit@debbugs.gnu.org; Sun, 12 Feb 2017 13:55:18 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:34408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cczIq-0007Xk-BN; Sun, 12 Feb 2017 13:55:16 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 70320160083; Sun, 12 Feb 2017 10:55:08 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id rvtCvHNFm1Sq; Sun, 12 Feb 2017 10:55:07 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BE20A160084; Sun, 12 Feb 2017 10:55:07 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 9epmDn-0GLwy; Sun, 12 Feb 2017 10:55:07 -0800 (PST) Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9E3FA160083; Sun, 12 Feb 2017 10:55:07 -0800 (PST) Subject: Re: bug#25606: patches installed for 25605, 25606 To: Eli Zaretskii References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> <837f4y4b9j.fsf@gnu.org> <355cf7f1-5fc0-cbb4-f806-3f335c14016a@cs.ucla.edu> <83efz32xrk.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: Date: Sun, 12 Feb 2017 10:55:00 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <83efz32xrk.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25606 Cc: 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii wrote: > what is the right way of running those tests? "make check". That's what's documented, right? From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 14:34:01 2017 Received: (at 25606) by debbugs.gnu.org; 12 Feb 2017 19:34:01 +0000 Received: from localhost ([127.0.0.1]:37340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cczuK-0008RP-So for submit@debbugs.gnu.org; Sun, 12 Feb 2017 14:34:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cczuJ-0008RC-9A for 25606@debbugs.gnu.org; Sun, 12 Feb 2017 14:33:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cczuB-0007KQ-56 for 25606@debbugs.gnu.org; Sun, 12 Feb 2017 14:33:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cczu2-0007JY-5g; Sun, 12 Feb 2017 14:33:42 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3965 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ccztz-00067t-Kt; Sun, 12 Feb 2017 14:33:41 -0500 Date: Sun, 12 Feb 2017 21:33:48 +0200 Message-Id: <831sv32ogz.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: (message from Paul Eggert on Sun, 12 Feb 2017 10:55:00 -0800) Subject: Re: bug#25606: patches installed for 25605, 25606 References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> <837f4y4b9j.fsf@gnu.org> <355cf7f1-5fc0-cbb4-f806-3f335c14016a@cs.ucla.edu> <83efz32xrk.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25606 Cc: 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 25606@debbugs.gnu.org, 25605@debbugs.gnu.org > From: Paul Eggert > Date: Sun, 12 Feb 2017 10:55:00 -0800 > > Eli Zaretskii wrote: > > what is the right way of running those tests? > > "make check". That's what's documented, right? This runs everything, which is too much. How do I run this single test? (AFAIU, it runs each test exactly as I did.) From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 14:41:24 2017 Received: (at 25606) by debbugs.gnu.org; 12 Feb 2017 19:41:25 +0000 Received: from localhost ([127.0.0.1]:37359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cd01U-0000Ax-L1 for submit@debbugs.gnu.org; Sun, 12 Feb 2017 14:41:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cd01T-0000Ai-9w for 25606@debbugs.gnu.org; Sun, 12 Feb 2017 14:41:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cd01L-0000NW-5M for 25606@debbugs.gnu.org; Sun, 12 Feb 2017 14:41:18 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cd01C-0000Mr-Dp; Sun, 12 Feb 2017 14:41:06 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3972 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cd01B-0002iT-CY; Sun, 12 Feb 2017 14:41:06 -0500 Date: Sun, 12 Feb 2017 21:41:18 +0200 Message-Id: <83zihr19k1.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: (message from Paul Eggert on Sun, 12 Feb 2017 10:55:00 -0800) Subject: Re: bug#25606: patches installed for 25605, 25606 References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> <837f4y4b9j.fsf@gnu.org> <355cf7f1-5fc0-cbb4-f806-3f335c14016a@cs.ucla.edu> <83efz32xrk.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25606 Cc: 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 25606@debbugs.gnu.org, 25605@debbugs.gnu.org > From: Paul Eggert > Date: Sun, 12 Feb 2017 10:55:00 -0800 > > Eli Zaretskii wrote: > > what is the right way of running those tests? > > "make check". That's what's documented, right? Actually, AFAIU "make check" doesn't run the tests in manual/ at all, so I'm not sure how you succeeded to run them. Or maybe I'm missing something obvious. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 14:41:28 2017 Received: (at 25606) by debbugs.gnu.org; 12 Feb 2017 19:41:28 +0000 Received: from localhost ([127.0.0.1]:37362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cd01X-0000BG-UA for submit@debbugs.gnu.org; Sun, 12 Feb 2017 14:41:28 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:45764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cd01U-0000Ao-I6; Sun, 12 Feb 2017 14:41:26 -0500 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1cd01M-000398-SO; Sun, 12 Feb 2017 20:41:21 +0100 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#25606: patches installed for 25605, 25606 References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> <837f4y4b9j.fsf@gnu.org> <355cf7f1-5fc0-cbb4-f806-3f335c14016a@cs.ucla.edu> <83efz32xrk.fsf@gnu.org> <831sv32ogz.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEX69N1bW1b9+uf+/Ovr 5NCwrKAaHBoc0EJTAAACTElEQVQ4jW1Uu44jIRBEHJcf0kKMwM4t2M1ZqckPCZwTmP//hKtuvN4N rsfSzHRNv4pqK/XDiKrc5Ppp9bwaAZXSKioVdQgHNUQkgI46qhhjyQF3FYzhEPzgiyGWWEoqeBxE Y4YDZFzlVmARaajN+YxI+BpAzqXAX6UGgKABJPmeAVNpjNNZOu5jeMxnFhXTtw9RqdyCenWFigM1 2bq13WkO0tfZu/Ubtqy3dva9pYS+8FfW7n0wfjoRl0Gcgl0O99HsEm70rYLW6bed8I82qO/I9XWu UV39Yz+oI8Ry/V8BRXQqIcy59v7TurOO2t3H0y66N84vv0Bf35PuXgUe8KLzNG5tu/8q05cDeIBQ smmY47HfFMrwICpyKrBzvS+/vXeG64/7AdJNB4Nm97ajfto12jMi8SFgXL8X0X2jBiI0A9nUMfoG d+iNcQaIgWBqm371YYRK77cOEnEhsNX72/jNTFoAwlW8Ef2m5mjSp2c/skUBoBWCygzVJ/WgnUlM 7+C2sjbaOa21nzXeoSTRE3rdG9SjhkTcWgfV3XVpaTVQIkrUV+88J+EhvH8ww0clV/aefh797sa0 T+BDam67Vnef/q0162WOdACckx1owLGWJEJ/fHV/OrI4kgNc+vYvUQHwLB8pPq3rbn4pdOKVAa1z 4kV7WcZwmqX4w5lfmObd/AZiTklgVqKO6bU3TBtvM4lEz+JIFhwmW1RZAEZ4b8+eAcV6y6plLCHW 8yRkPMSoqqxaiiG9VjEXhMhKyd+J5vYiT8TGA1b1PzP0D7mfxpHr8Gi+AAAAAElFTkSuQmCC Date: Sun, 12 Feb 2017 20:41:16 +0100 In-Reply-To: <831sv32ogz.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 Feb 2017 21:33:48 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25606 Cc: Paul Eggert , 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: >> "make check". That's what's documented, right? > > This runs everything, which is too much. How do I run this single > test? (AFAIU, it runs each test exactly as I did.) I don't know how to do a single test, but I always run tests from a single file like so: larsi@mouse:~/src/emacs/trunk/test$ make src/fns-tests (which hangs for me at present). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 14:43:33 2017 Received: (at 25606) by debbugs.gnu.org; 12 Feb 2017 19:43:33 +0000 Received: from localhost ([127.0.0.1]:37373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cd03Y-0000Ej-R3 for submit@debbugs.gnu.org; Sun, 12 Feb 2017 14:43:32 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:38184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cd03X-0000EP-Ep; Sun, 12 Feb 2017 14:43:31 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E824C160083; Sun, 12 Feb 2017 11:43:25 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id X0u8dQD1pr-f; Sun, 12 Feb 2017 11:43:25 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 415AE160084; Sun, 12 Feb 2017 11:43:25 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id UHwOpNAfwPLQ; Sun, 12 Feb 2017 11:43:25 -0800 (PST) Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 224F0160083; Sun, 12 Feb 2017 11:43:25 -0800 (PST) Subject: Re: bug#25606: patches installed for 25605, 25606 To: Eli Zaretskii References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> <837f4y4b9j.fsf@gnu.org> <355cf7f1-5fc0-cbb4-f806-3f335c14016a@cs.ucla.edu> <83efz32xrk.fsf@gnu.org> <831sv32ogz.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <4ee40574-c0fa-6de5-65f4-254ba2ad4fc9@cs.ucla.edu> Date: Sun, 12 Feb 2017 11:43:24 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <831sv32ogz.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25606 Cc: 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii wrote: > This runs everything, which is too much. How do I run this single > test? Sorry, I don't know. I didn't have to know, as "make check" sufficed for = me. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 14:49:15 2017 Received: (at 25606) by debbugs.gnu.org; 12 Feb 2017 19:49:15 +0000 Received: from localhost ([127.0.0.1]:37381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cd091-0000NE-Lv for submit@debbugs.gnu.org; Sun, 12 Feb 2017 14:49:15 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:45822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cd08w-0000Mz-VA; Sun, 12 Feb 2017 14:49:10 -0500 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1cd08s-0006sX-6u; Sun, 12 Feb 2017 20:49:06 +0100 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#25605: bug#25606: patches installed for 25605, 25606 References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> <837f4y4b9j.fsf@gnu.org> <355cf7f1-5fc0-cbb4-f806-3f335c14016a@cs.ucla.edu> <83efz32xrk.fsf@gnu.org> <831sv32ogz.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEX69N1bW1b9+uf+/Ovr 5NCwrKAaHBoc0EJTAAACTElEQVQ4jW1Uu44jIRBEHJcf0kKMwM4t2M1ZqckPCZwTmP//hKtuvN4N rsfSzHRNv4pqK/XDiKrc5Ppp9bwaAZXSKioVdQgHNUQkgI46qhhjyQF3FYzhEPzgiyGWWEoqeBxE Y4YDZFzlVmARaajN+YxI+BpAzqXAX6UGgKABJPmeAVNpjNNZOu5jeMxnFhXTtw9RqdyCenWFigM1 2bq13WkO0tfZu/Ubtqy3dva9pYS+8FfW7n0wfjoRl0Gcgl0O99HsEm70rYLW6bed8I82qO/I9XWu UV39Yz+oI8Ry/V8BRXQqIcy59v7TurOO2t3H0y66N84vv0Bf35PuXgUe8KLzNG5tu/8q05cDeIBQ smmY47HfFMrwICpyKrBzvS+/vXeG64/7AdJNB4Nm97ajfto12jMi8SFgXL8X0X2jBiI0A9nUMfoG d+iNcQaIgWBqm371YYRK77cOEnEhsNX72/jNTFoAwlW8Ef2m5mjSp2c/skUBoBWCygzVJ/WgnUlM 7+C2sjbaOa21nzXeoSTRE3rdG9SjhkTcWgfV3XVpaTVQIkrUV+88J+EhvH8ww0clV/aefh797sa0 T+BDam67Vnef/q0162WOdACckx1owLGWJEJ/fHV/OrI4kgNc+vYvUQHwLB8pPq3rbn4pdOKVAa1z 4kV7WcZwmqX4w5lfmObd/AZiTklgVqKO6bU3TBtvM4lEz+JIFhwmW1RZAEZ4b8+eAcV6y6plLCHW 8yRkPMSoqqxaiiG9VjEXhMhKyd+J5vYiT8TGA1b1PzP0D7mfxpHr8Gi+AAAAAElFTkSuQmCC Date: Sun, 12 Feb 2017 20:49:01 +0100 In-Reply-To: (Lars Ingebrigtsen's message of "Sun, 12 Feb 2017 20:41:16 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25606 Cc: Paul Eggert , 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Lars Ingebrigtsen writes: > larsi@mouse:~/src/emacs/trunk/test$ make src/fns-tests > > (which hangs for me at present). (Hm, doesn't hang after rebuilding Emacs. But some of the tests fail.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 15:22:19 2017 Received: (at 25606) by debbugs.gnu.org; 12 Feb 2017 20:22:19 +0000 Received: from localhost ([127.0.0.1]:37409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cd0f5-0002sK-8l for submit@debbugs.gnu.org; Sun, 12 Feb 2017 15:22:19 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cd0f1-0002s3-Bh for 25606@debbugs.gnu.org; Sun, 12 Feb 2017 15:22:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cd0er-0008Ul-6k for 25606@debbugs.gnu.org; Sun, 12 Feb 2017 15:22:10 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cd0er-0008Ug-2x; Sun, 12 Feb 2017 15:22:05 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4042 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cd0eo-0002SW-RU; Sun, 12 Feb 2017 15:22:04 -0500 Date: Sun, 12 Feb 2017 22:22:08 +0200 Message-Id: <83wpcv17nz.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: (message from Lars Ingebrigtsen on Sun, 12 Feb 2017 20:41:16 +0100) Subject: Re: bug#25606: patches installed for 25605, 25606 References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> <837f4y4b9j.fsf@gnu.org> <355cf7f1-5fc0-cbb4-f806-3f335c14016a@cs.ucla.edu> <83efz32xrk.fsf@gnu.org> <831sv32ogz.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25606 Cc: eggert@cs.ucla.edu, 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Lars Ingebrigtsen > Cc: Paul Eggert , 25605@debbugs.gnu.org, 25606@debbugs.gnu.org > Date: Sun, 12 Feb 2017 20:41:16 +0100 > > Eli Zaretskii writes: > > >> "make check". That's what's documented, right? > > > > This runs everything, which is too much. How do I run this single > > test? (AFAIU, it runs each test exactly as I did.) > > I don't know how to do a single test, but I always run tests from a > single file like so: > > larsi@mouse:~/src/emacs/trunk/test$ make src/fns-tests That's what I do. But this doesn't work for files in manual/. > (which hangs for me at present). (It doesn't hang for me; it fails because 3 tests fail.) From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 15:57:23 2017 Received: (at 25606) by debbugs.gnu.org; 12 Feb 2017 20:57:23 +0000 Received: from localhost ([127.0.0.1]:37441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cd1D1-0003iE-Lp for submit@debbugs.gnu.org; Sun, 12 Feb 2017 15:57:23 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:43838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cd1Cz-0003hu-3I; Sun, 12 Feb 2017 15:57:21 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2AE7A160084; Sun, 12 Feb 2017 12:57:14 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id C3_vSGBIEtk2; Sun, 12 Feb 2017 12:57:13 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7E94D160087; Sun, 12 Feb 2017 12:57:13 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id sF74zAR-jAkC; Sun, 12 Feb 2017 12:57:13 -0800 (PST) Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 60162160084; Sun, 12 Feb 2017 12:57:13 -0800 (PST) Subject: Re: bug#25606: patches installed for 25605, 25606 To: Eli Zaretskii References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> <837f4y4b9j.fsf@gnu.org> <355cf7f1-5fc0-cbb4-f806-3f335c14016a@cs.ucla.edu> <83efz32xrk.fsf@gnu.org> <83zihr19k1.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <1cd050a3-9fa5-3391-6e7a-0f3a8e8e92ec@cs.ucla.edu> Date: Sun, 12 Feb 2017 12:57:13 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <83zihr19k1.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25606 Cc: 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii wrote: > Actually, AFAIU "make check" doesn't run the tests in manual/ at all, > so I'm not sure how you succeeded to run them. Well, now that I think back on it, I'm not sure either. I did run them, using some complicated set of arguments to 'make', but I don't remember what the arguments were. Anyway, I debugged the tests under the new regime and installed a fix. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 00:37:30 2017 Received: (at 25606) by debbugs.gnu.org; 13 Feb 2017 05:37:30 +0000 Received: from localhost ([127.0.0.1]:37692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cd9KM-0003wD-Di for submit@debbugs.gnu.org; Mon, 13 Feb 2017 00:37:30 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cd9KL-0003w0-Bu for 25606@debbugs.gnu.org; Mon, 13 Feb 2017 00:37:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cd9KD-0004BA-7o for 25606@debbugs.gnu.org; Mon, 13 Feb 2017 00:37:24 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cd9K4-0004Ac-EH; Mon, 13 Feb 2017 00:37:12 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4891 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cd9K3-00011p-Ih; Mon, 13 Feb 2017 00:37:12 -0500 Date: Mon, 13 Feb 2017 07:37:27 +0200 Message-Id: <83r3321wiw.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <1cd050a3-9fa5-3391-6e7a-0f3a8e8e92ec@cs.ucla.edu> (message from Paul Eggert on Sun, 12 Feb 2017 12:57:13 -0800) Subject: Re: bug#25606: patches installed for 25605, 25606 References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> <837f4y4b9j.fsf@gnu.org> <355cf7f1-5fc0-cbb4-f806-3f335c14016a@cs.ucla.edu> <83efz32xrk.fsf@gnu.org> <83zihr19k1.fsf@gnu.org> <1cd050a3-9fa5-3391-6e7a-0f3a8e8e92ec@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25606 Cc: 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 25606@debbugs.gnu.org, 25605@debbugs.gnu.org > From: Paul Eggert > Date: Sun, 12 Feb 2017 12:57:13 -0800 > > Anyway, I debugged the tests under the new regime and installed a fix. Thanks, they all pass for me now. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 04:11:44 2017 Received: (at 25606) by debbugs.gnu.org; 13 Feb 2017 09:11:44 +0000 Received: from localhost ([127.0.0.1]:37816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdCfg-0000bu-Hi for submit@debbugs.gnu.org; Mon, 13 Feb 2017 04:11:44 -0500 Received: from mout.gmx.net ([212.227.17.20]:55666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdCfe-0000bS-7G; Mon, 13 Feb 2017 04:11:42 -0500 Received: from detlef.gmx.de ([93.197.210.184]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MYtId-1cqYoA1wR9-00Vez0; Mon, 13 Feb 2017 10:11:25 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#25606: patches installed for 25605, 25606 References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> <837f4y4b9j.fsf@gnu.org> <355cf7f1-5fc0-cbb4-f806-3f335c14016a@cs.ucla.edu> <83efz32xrk.fsf@gnu.org> <831sv32ogz.fsf@gnu.org> Date: Mon, 13 Feb 2017 10:11:21 +0100 In-Reply-To: <831sv32ogz.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 Feb 2017 21:33:48 +0200") Message-ID: <878tpazc92.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:6lxZJzSbVCKydMXJhAQqjR7n2pGaHrKn0S9KL0pFhXerlcGO4iG BWauho+CBILUpGKyZCnK6dNpad2BMPIg+g7EmqwrzRuaaf0m/3s6ccQttt/UjjF0+Aq/iej z1VmYfcPrQtgyHB21bQrsD7jyBwqBgiw44+W7fh7RN1iJQs9Ik/nwdfzheYX5uO5cov/4Ql SAucBiKS7+zUt6BVFQf+g== X-UI-Out-Filterresults: notjunk:1;V01:K0:gTPUfY1rdk4=:cjSAbKfEfSgf4yJCeQE5V0 ws/PYumudlar65KN0o3gopWtIsA1QZRo5eePV4/+6nkpJw/19aVd2mjz9z6Kh5nlX/0rfvYNI OzcOKbEF6WjbpBl6FAnSLhfIhCGe1tp6qDRTenRbNG3Yh/rNZnN3oUNiELjIyrb/FsWY3VkkF Uc6bFWTluZTLCjzRhcT2IrPXSAEz+Y/uREktSQxUJ72XdRjuzd87fJGCr/cMb8qwRnIHCpnJ4 m005NDnwAMgRUNFtSoa+5qsXddfDR0x9W8I6okOt4RQZxoJFz3YsX/2S0/OujNa6CiHhaiFSH NfUETSJ2T7Ho8PlFECI3UUQvBw8oAuIPPx9jw2otD6pD6VhFGuGzk1KHe1UQT2RSX6WEQHkDJ aLHbM/VkaVamtH65n96+e0C5M23U5Oe1/PRMkB3t6XOZXexDLXKgy2g/Z/fdsrvb8yVu8vAb8 rchmll/yAPsUBOZd315P+c0Tsph0BuYDgu0fEkbP9WN6qxp0jHLaG1nuKRbUjNl0aZETOEH2f 7LuN5E3tME+Bt7g00XzhxczepkgF3VTfq/RODJViqOe58/58RpzVOmbY7sgKtYnQW8sCSZfxF dWyePRHnDiYNMu4GJrTHrAPy2x4//xqrEjsdD5hCxS3oZ/K6EFboEI0zG2yP15c1r9Ys4TdUQ NgivUSLiAlWUGNXSGasbrgszkmEjSsxNFVLY5cF7eT8Ta1f3r4UMMNCKZxdS7kTDoE27S5jBz U0PjR3YHTrkKXYYtUh+Rp04KzSlhbsGT9KRKx/hMS07mwtued3prsYQCFont/4ZvuZyepqKaV jDszP/W X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 25606 Cc: Paul Eggert , 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Eli Zaretskii writes: >> > what is the right way of running those tests? >> >> "make check". That's what's documented, right? > > This runs everything, which is too much. How do I run this single > test? (AFAIU, it runs each test exactly as I did.) # make -C test fns-tests SELECTOR=\'test-cycle-lax-plist-get See also test/README Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 09:37:14 2017 Received: (at 25606) by debbugs.gnu.org; 13 Feb 2017 14:37:14 +0000 Received: from localhost ([127.0.0.1]:37980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdHkg-0001Sg-6P for submit@debbugs.gnu.org; Mon, 13 Feb 2017 09:37:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdHkc-0001SR-Rt for 25606@debbugs.gnu.org; Mon, 13 Feb 2017 09:37:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cdHkV-0007jA-1d for 25606@debbugs.gnu.org; Mon, 13 Feb 2017 09:37:05 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59688) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdHkU-0007j6-Uc; Mon, 13 Feb 2017 09:37:02 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1528 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cdHkT-0004tU-Ta; Mon, 13 Feb 2017 09:37:02 -0500 Date: Mon, 13 Feb 2017 16:37:18 +0200 Message-Id: <83h93y17j5.fsf@gnu.org> From: Eli Zaretskii To: Michael Albinus In-reply-to: <878tpazc92.fsf@gmx.de> (message from Michael Albinus on Mon, 13 Feb 2017 10:11:21 +0100) Subject: Re: bug#25606: patches installed for 25605, 25606 References: <20170201235622.30836-2-eggert@cs.ucla.edu> <5c200659-f482-b2a5-738f-e7710454c376@cs.ucla.edu> <83bmuf71c1.fsf@gnu.org> <99857212-cb7b-7e57-dab1-ba4412815932@cs.ucla.edu> <837f4y4b9j.fsf@gnu.org> <355cf7f1-5fc0-cbb4-f806-3f335c14016a@cs.ucla.edu> <83efz32xrk.fsf@gnu.org> <831sv32ogz.fsf@gnu.org> <878tpazc92.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25606 Cc: eggert@cs.ucla.edu, 25605@debbugs.gnu.org, 25606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Michael Albinus > Cc: Paul Eggert , 25605@debbugs.gnu.org, 25606@debbugs.gnu.org > Date: Mon, 13 Feb 2017 10:11:21 +0100 > > >> "make check". That's what's documented, right? > > > > This runs everything, which is too much. How do I run this single > > test? (AFAIU, it runs each test exactly as I did.) > > # make -C test fns-tests SELECTOR=\'test-cycle-lax-plist-get Yes, I know. But that doesn't work for tests under manual/, which is what I was asking about. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 18 14:54:51 2017 Received: (at control) by debbugs.gnu.org; 18 Feb 2017 19:54:51 +0000 Received: from localhost ([127.0.0.1]:45390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfB5n-00029P-4v for submit@debbugs.gnu.org; Sat, 18 Feb 2017 14:54:51 -0500 Received: from mail-it0-f54.google.com ([209.85.214.54]:35965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfB5k-00029B-VR for control@debbugs.gnu.org; Sat, 18 Feb 2017 14:54:49 -0500 Received: by mail-it0-f54.google.com with SMTP id h10so45590621ith.1 for ; Sat, 18 Feb 2017 11:54:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=QjQJ02qOuP+0MshcxlYqazvk1CLEqoWTAiVMRKQ7Dno=; b=TQCNICjG83gMOdP2m4mjyAYC6njxiTOSzMSVi35u2q7j7BPR44BicNNI5aJi9MQdZ1 ZyOZtpsytH1wHtyUUDUYMgkPHW68RA9ocYcBMVxZ8lpkccMdmwWm0tPNyDRLgbWJ4ZKw pRF+d9moHiSNoQNE0TRQyqnajGsHy+TqMkZUOGRIpr1FsN4Sjl4UDd5OnLKHLUTfxf2u H6xZtI1qziHoUbKEnirfan0ubO+e5b3xE0i0Ra0HWZ0nCyy6QzUCamxZqdkLP7hFwoWv sPMqVclxoETCZBhXVR52xGldnou+ok0llevgcovRgatIIk7JJWyipusiYrLE6/X5Buep Cf4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=QjQJ02qOuP+0MshcxlYqazvk1CLEqoWTAiVMRKQ7Dno=; b=ByNk5kHz4OeCkkAgoxfvSOWnCHfmEUzil+q7gWNBr8UMLVh5mGRvTItZKVwgpcZC0G XwHHT9sdADJ0HXxpHF7dyLcGxg4TmUwhjjejiB7rH5J405pDmJo42bo40Pk9zQPPV1/f SlpkCkN8gz/bRKw+rtifAodqYhSlbUpCFmwErNQnBMz751SSnEV566Ip6oXAMtir41ye F7msiq2gW8KP+QMTc32dy3he5Y2e3QprYeBmM8rjCUPZZJ+d1aBtobBrBDhA4C6vVutu xRsMASgCdtnfAFWy2e3Lq25DOBaF/GEZ6DlcSWFvRXK7IMILqF2F7CSmeIJjHbMkLSvx X8WA== X-Gm-Message-State: AMke39lGK33925VcSf5noc15ofR1uqClK8xOPt6JHZX64NJZYIKtYoXgcQBd02J7oOOUmw== X-Received: by 10.36.31.205 with SMTP id d196mr11933124itd.112.1487447683508; Sat, 18 Feb 2017 11:54:43 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 82sm6653243ioj.23.2017.02.18.11.54.42 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 18 Feb 2017 11:54:43 -0800 (PST) From: npostavs@users.sourceforge.net To: control@debbugs.gnu.org Subject: control message for bug #25605 Date: Sat, 18 Feb 2017 14:55:54 -0500 Message-ID: <87efyvjmt1.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) close 25605 close 25606 quit From unknown Fri Jun 20 18:25:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 19 Mar 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator