Subject: Re: [PATCH] More reproducibility fixes for R.

From: [email-masked] (Ludovic Courtès)
Date: Fri, 10 Feb 2017 13:38:07 +0100

Hi!

Ricardo Wurmus <[email-masked]> skribis:

> attached are more reproducibility fixes for R.  Unfortunately, it seems
> that files of type “rdb”, “rdx”, and “rds” are still not reproducible.
> This leaves us with the following files in R that are currently not
> reproducible:

Could it be that --built-timestamp is not honored for R modules within R?
Do the Debian patches mentioned in #25598 help?

> From e8cd2114b824ab6fed671c2214956ee22deeaedf Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <[email-masked]>
> Date: Thu, 9 Feb 2017 14:34:57 +0100
> Subject: [PATCH 1/2] gnu: r: Fix syntax for INSTALL_OPTS.
>
> This is a follow-up to commit 4621acfd8272fa93d0530faa5f015b26a194b587.
>
> * gnu/packages/statistics.scm (r)[arguments]: Ensure that
> "--built-timestamp" appears on the same line as the other INSTALL_OPTS.

So the previous attempt had no effect, right?

LGTM.

> From 95b939f662a29b3cc6973a2fba286f32faf010c1 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <[email-masked]>
> Date: Thu, 9 Feb 2017 15:40:02 +0100
> Subject: [PATCH 2/2] gnu: r: Fix more reproducibility problems.
>
> * gnu/packages/statistics.scm (r)[arguments]: Patch locations in the
> build system that need special treatment for reproducibility.

LGTM, thanks!

Ludo’.