From unknown Wed Jun 18 00:19:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25573: Adding btrfs support may break reconfigured system Resent-From: Alex Kost Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 29 Jan 2017 18:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25573 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 25573@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.148571305513535 (code B ref -1); Sun, 29 Jan 2017 18:05:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 Jan 2017 18:04:15 +0000 Received: from localhost ([127.0.0.1]:50414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXtpm-0003WF-OM for submit@debbugs.gnu.org; Sun, 29 Jan 2017 13:04:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXtpm-0003W4-06 for submit@debbugs.gnu.org; Sun, 29 Jan 2017 13:04:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXtpf-0004Dm-RA for submit@debbugs.gnu.org; Sun, 29 Jan 2017 13:04:08 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48295) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cXtpf-0004Dg-O6 for submit@debbugs.gnu.org; Sun, 29 Jan 2017 13:04:07 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXtpe-0002Gl-C0 for bug-guix@gnu.org; Sun, 29 Jan 2017 13:04:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXtpb-0004CK-6B for bug-guix@gnu.org; Sun, 29 Jan 2017 13:04:06 -0500 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:34774) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXtpa-0004Br-Ug for bug-guix@gnu.org; Sun, 29 Jan 2017 13:04:03 -0500 Received: by mail-lf0-x242.google.com with SMTP id q89so29737225lfi.1 for ; Sun, 29 Jan 2017 10:04:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=gJ9ugdJY1i4hI1iU1dToSv6eN197LklBRG6dPMY/Jbg=; b=akW/LE5rHhxsppwkdRkTTmOIEYt1nqbRsvgXm9cGqLhM5pqMQpdPd1uqrSRYM5ao/V 0Ref9czx7WN372+0aXJEkdo4buxOcgmMG3s57Krs5QGl4tLq8YfkPKhc8HF9El8AKrAQ Y8H6WwcPHB8+8BOXWRbVkvWO9rYxboMsMgWKDdFPsMp0DD+sY0S6feoFfGnqNVUc0t92 MihMUEqapTCgQgs72y6ONXGy9VqT/5gQNS9sc22Zhl6zS+n4OWZLSpGIAgqCy9j3HJGK tzIyrwOXx3pAjz5LQ0zGQhq/tIt7YopwiW2xdeDwDc25Os4ke09nBmhZkYNn+yKphxT3 +vDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=gJ9ugdJY1i4hI1iU1dToSv6eN197LklBRG6dPMY/Jbg=; b=TqHFsiciHYt1/NGIW5HbowxbTiM7DyW0CBfUWlBAmtu1EzLKSs1ZvKSdi8ZVQ8STcE LeQQCaqszJUWWwWj0a2JsIQz8Nrr1PppP+iS/UmZkFT/zB8g99vmkBOB/zFOI4uOqIj+ MpWvGL+ca50HvO3LCo3hYensi+cuK38scOBsXslNrpQzgiNOfEX8P1xN5+JEjI9rGqWf COM9ZmJYB1H11hJVk36WX0P9Eme+6/ASLM8QYDhfa6e4i0PT3oV3Jy1mZcMRseqp0GNg ZugWXw55dkHSx3li69k6euUtCojtf6d/YqcU62HOGZxPMlUK/3A/0AYBzQiF56hkFhrf 4ZjA== X-Gm-Message-State: AIkVDXIkoN2KsLeGSO4PBq91Zs76IQpD1L4yhSfKcj/sOfeCqou9ddpkAeNWRpSEuYm2VQ== X-Received: by 10.25.206.146 with SMTP id e140mr6013243lfg.94.1485713039872; Sun, 29 Jan 2017 10:03:59 -0800 (PST) Received: from leviafan ([217.107.194.128]) by smtp.gmail.com with ESMTPSA id s63sm3061971lja.49.2017.01.29.10.03.58 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 29 Jan 2017 10:03:59 -0800 (PST) From: Alex Kost Date: Sun, 29 Jan 2017 21:03:56 +0300 Message-ID: <87wpddzqsz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, recently I found that "guix system" makes a "broken" system for me. When I boot a freshly created system, I get something like this: In procedure <...> at ./gnu/build/file-systems.scm:282:4 (device) In procedure fport_seek: Invalid argument and I'm thrown at the Guile promt. The same problem (well, I think it's the same) was also reported by roptat on #guix: https://gnunet.org/bot/log/guix/2017-01-28#T1277485 After bisecting the guix git checkout, I found that commit b1a505baf6=C2=B9 was the first one where my system starts to fail. And indeed when I reverted this commit on the latest master, guix built a working system. Moreover, the following simple diff (it's a partial revert of that commit) "fixes" guix for me: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=fix-btrfs.diff diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm index 6e5c6aa..f05e035 100644 --- a/gnu/build/file-systems.scm +++ b/gnu/build/file-systems.scm @@ -294,15 +294,11 @@ partition field reader that returned a value." (define %partition-label-readers (list (partition-field-reader read-ext2-superblock - ext2-superblock-volume-name) - (partition-field-reader read-btrfs-superblock - btrfs-superblock-volume-name))) + ext2-superblock-volume-name))) (define %partition-uuid-readers (list (partition-field-reader read-ext2-superblock - ext2-superblock-uuid) - (partition-field-reader read-btrfs-superblock - btrfs-superblock-uuid))) + ext2-superblock-uuid))) (define read-partition-label (cut read-partition-field <> %partition-label-readers)) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I don't have btrfs anywhere (only ext4). During bisecting experiments I used the attached system config (but the config shouldn't matter I think as I tried various variants, and all gave me the same result). Any idea how to dig further? Perhaps there is something I can do in the Guile prompt. =C2=B9 http://git.savannah.gnu.org/cgit/guix.git/commit/?id=3Db1a505baf61cc= 771197eb44af9173f31d2bace46 --=-=-= Content-Type: text/x-scheme Content-Disposition: attachment; filename=bare-bones.scm (use-modules (gnu)) (operating-system (host-name "leviafan") (timezone "Europe/Moscow") (locale "en_US.utf8") (bootloader (grub-configuration (device "/dev/sda"))) (initrd (lambda (fs . args) (apply base-initrd fs #:extra-modules '("sata_nv") ; for my HDD args))) (file-systems (cons (file-system (device "guix") (title 'label) (mount-point "/") (type "ext4")) %base-file-systems)) (users (cons (user-account (name "al") (group "users") (supplementary-groups '("wheel" "audio" "video")) (home-directory "/home/al")) %base-user-accounts)) (packages %base-packages) (services (cons* (console-keymap-service "dvorak") %base-services))) --=-=-=-- From unknown Wed Jun 18 00:19:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25573: Adding btrfs support may break reconfigured system Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 30 Jan 2017 09:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25573 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Alex Kost Cc: 25573@debbugs.gnu.org Received: via spool by 25573-submit@debbugs.gnu.org id=B25573.148576932331418 (code B ref 25573); Mon, 30 Jan 2017 09:43:02 +0000 Received: (at 25573) by debbugs.gnu.org; 30 Jan 2017 09:42:03 +0000 Received: from localhost ([127.0.0.1]:50729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cY8TL-0008Ag-1Y for submit@debbugs.gnu.org; Mon, 30 Jan 2017 04:42:03 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cY8TJ-0008AC-Gr for 25573@debbugs.gnu.org; Mon, 30 Jan 2017 04:42:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cY8TA-0000Er-Vx for 25573@debbugs.gnu.org; Mon, 30 Jan 2017 04:41:56 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56246) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cY8TA-0000EX-RE; Mon, 30 Jan 2017 04:41:52 -0500 Received: from [193.50.110.143] (port=40320 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cY8TA-0000kk-7N; Mon, 30 Jan 2017 04:41:52 -0500 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87wpddzqsz.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 11 =?UTF-8?Q?Pluvi=C3=B4se?= an 225 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Mon, 30 Jan 2017 10:41:49 +0100 In-Reply-To: <87wpddzqsz.fsf@gmail.com> (Alex Kost's message of "Sun, 29 Jan 2017 21:03:56 +0300") Message-ID: <87sho0evfm.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.2 (--------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.2 (--------) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Alex Kost skribis: > Hello, recently I found that "guix system" makes a "broken" system for > me. When I boot a freshly created system, I get something like this: > > In procedure <...> at ./gnu/build/file-systems.scm:282:4 (device) > In procedure fport_seek: Invalid argument > > and I'm thrown at the Guile promt. I think this is due to =E2=80=98read-superblock=E2=80=99 trying to seek bey= ond the end of one of the devices that=E2=80=99s on your machine. Could you try the attached patch and see if it solves the problem? Thanks for reporting it! Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm index 6e5c6aaf1..f8ab95370 100644 --- a/gnu/build/file-systems.scm +++ b/gnu/build/file-systems.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright =C2=A9 2014, 2015, 2016 Ludovic Court=C3=A8s +;;; Copyright =C2=A9 2014, 2015, 2016, 2017 Ludovic Court=C3=A8s ;;; Copyright =C2=A9 2016, 2017 David Craven ;;; ;;; This file is part of GNU Guix. @@ -72,14 +72,25 @@ "Bind-mount SOURCE at TARGET." (mount source target "" MS_BIND)) =20 +(define (seek* fd/port offset whence) + "Like 'seek' but return -1 instead of throwing to 'system-error' upon +EINVAL. This makes it easier to catch cases like OFFSET being too large f= or +FD/PORT." + (catch 'system-error + (lambda () + (seek fd/port offset whence)) + (lambda args + (if (=3D EINVAL (system-error-errno args)) + -1 + (apply throw args))))) + (define (read-superblock device offset size magic?) "Read a superblock of SIZE from OFFSET and DEVICE. Return the raw superblock on success, and #f if no valid superblock was found. MAGIC? takes a bytevector and returns #t when it's a valid superblock." (call-with-input-file device (lambda (port) - (seek port offset SEEK_SET) - + (and (=3D offset (seek* port offset SEEK_SET)) (let ((block (make-bytevector size))) (match (get-bytevector-n! port block 0 (bytevector-length blo= ck)) ((? eof-object?) @@ -87,7 +98,7 @@ takes a bytevector and returns #t when it's a valid super= block." ((? number? len) (and (=3D len (bytevector-length block)) (and (magic? block) - block)))))))) + block))))))))) =20 (define (sub-bytevector bv start size) "Return a copy of the SIZE bytes of BV starting from offset START." --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 17:26:49 2017 Received: (at control) by debbugs.gnu.org; 30 Jan 2017 22:26:49 +0000 Received: from localhost ([127.0.0.1]:51430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYKPR-0003Cx-KW for submit@debbugs.gnu.org; Mon, 30 Jan 2017 17:26:49 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYKPP-0003CS-Ci for control@debbugs.gnu.org; Mon, 30 Jan 2017 17:26:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cYKPH-0001p9-4J for control@debbugs.gnu.org; Mon, 30 Jan 2017 17:26:42 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37071) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cYKPH-0001p5-1T for control@debbugs.gnu.org; Mon, 30 Jan 2017 17:26:39 -0500 Received: from reverse-83.fdn.fr ([80.67.176.83]:49464 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cYKPF-0000lg-He for control@debbugs.gnu.org; Mon, 30 Jan 2017 17:26:38 -0500 Date: Mon, 30 Jan 2017 23:26:35 +0100 Message-Id: <87bmuokwv8.fsf@gnu.org> To: control@debbugs.gnu.org From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: control message for bug #25573 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.2 (--------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.2 (--------) severity 25573 important From unknown Wed Jun 18 00:19:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25573: Adding btrfs support may break reconfigured system Resent-From: Alex Kost Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 31 Jan 2017 17:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25573 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: 25573@debbugs.gnu.org Received: via spool by 25573-submit@debbugs.gnu.org id=B25573.148588379115075 (code B ref 25573); Tue, 31 Jan 2017 17:30:02 +0000 Received: (at 25573) by debbugs.gnu.org; 31 Jan 2017 17:29:51 +0000 Received: from localhost ([127.0.0.1]:52504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYcFb-0003v5-KV for submit@debbugs.gnu.org; Tue, 31 Jan 2017 12:29:51 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:34605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYcFa-0003us-0C for 25573@debbugs.gnu.org; Tue, 31 Jan 2017 12:29:50 -0500 Received: by mail-lf0-f66.google.com with SMTP id q89so34497729lfi.1 for <25573@debbugs.gnu.org>; Tue, 31 Jan 2017 09:29:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=0Gsg0XyK+qeCrx3uLJRALUFPWf4VIcXV31f63TC41bU=; b=VELThlRZ3YWrFrM4fq+jiBekfIIPABQLg4ObdTptia4Kg7/EuLEPafwlKX5KqRg22t 1pHmAT/o68dvuDxfq5YoD01lto43Ei7rdH42Q1VrVh177TLQIrqLE2jEeVNSldhvSeqA 1VKvPKpm22hfwcmGz3vTLShyGegzJcfcWUF5Fowz7k2lQfi0VBKbiKEx18Tl98UI4plV rfMWlZ729C5vCQcHUGv34xUFHcnoRFSJ+/DzF8s03ZotbsSRwsefkNiCPCpcynmvsbHs i/eQcMtbIViLb/7Upu4Z0rqpBBtLHNSt9PNyBriMzKrpGPFHG1eYqC6q0asmx6vgUL2y ZsNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=0Gsg0XyK+qeCrx3uLJRALUFPWf4VIcXV31f63TC41bU=; b=sA2AfkA6qKpZV/zvbacLCH4+9FJf1h5KdZo8OnmJllFdzzW16Gq8WDqWqod0oCKdqX qZsrl5utRHNA5/p9XUeu7TTnzeGiRSL8YDznx5tovggk1jWB5BKey0qtLnfAOWNo1rkk DYJpa8y7GR7xK2FlKGc0sxc0j5fpw/3GnDUYYkk8XxpX2aurhbxVyJx7yWTE/GRG9esS k3kBgbhxxrs9Z7XvgN+pFl/iW6NzVmzoxjsJn7ckKfLopKJs4xp+7tPh8Tjpqhbyy6zd 5OYjlczZVgiBCLdlhI/yX1B+mzt1Ca5xPWGvUDTUtaVDxMoSFXYhiqZ4yZdJhj7WcUJf VRng== X-Gm-Message-State: AIkVDXK5GkAJ5sY+UNxphwNq3XdKt2zwMk4YNCxglXS5Pwvi2UmXDrkx8MvLY1iISc2GEA== X-Received: by 10.25.79.71 with SMTP id a7mr10442770lfk.67.1485883783946; Tue, 31 Jan 2017 09:29:43 -0800 (PST) Received: from leviafan ([217.107.194.132]) by smtp.gmail.com with ESMTPSA id r9sm1853433ljd.14.2017.01.31.09.29.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 31 Jan 2017 09:29:43 -0800 (PST) From: Alex Kost References: <87wpddzqsz.fsf@gmail.com> <87sho0evfm.fsf@gnu.org> Date: Tue, 31 Jan 2017 20:29:45 +0300 In-Reply-To: <87sho0evfm.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 30 Jan 2017 10:41:49 +0100") Message-ID: <87bmuni1di.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Ludovic Court=C3=A8s (2017-01-30 10:41 +0100) wrote: > Hi, > > Alex Kost skribis: > >> Hello, recently I found that "guix system" makes a "broken" system for >> me. When I boot a freshly created system, I get something like this: >> >> In procedure <...> at ./gnu/build/file-systems.scm:282:4 (device) >> In procedure fport_seek: Invalid argument >> >> and I'm thrown at the Guile promt. > > I think this is due to =E2=80=98read-superblock=E2=80=99 trying to seek b= eyond the end > of one of the devices that=E2=80=99s on your machine. > > Could you try the attached patch and see if it solves the problem? Yes, guix makes a bootable system with this modification, thank you! > Thanks for reporting it! Thanks for fixing it! :-) --=20 Alex From unknown Wed Jun 18 00:19:32 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Alex Kost Subject: bug#25573: closed (Re: bug#25573: Adding btrfs support may break reconfigured system) Message-ID: References: <87h94eeuno.fsf@gnu.org> <87wpddzqsz.fsf@gmail.com> X-Gnu-PR-Message: they-closed 25573 X-Gnu-PR-Package: guix Reply-To: 25573@debbugs.gnu.org Date: Tue, 31 Jan 2017 22:24:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1485901442-28694-1" This is a multi-part message in MIME format... ------------=_1485901442-28694-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #25573: Adding btrfs support may break reconfigured system which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 25573@debbugs.gnu.org. --=20 25573: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25573 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1485901442-28694-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 25573-done) by debbugs.gnu.org; 31 Jan 2017 22:23:20 +0000 Received: from localhost ([127.0.0.1]:52628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYgpc-0007RO-Ad for submit@debbugs.gnu.org; Tue, 31 Jan 2017 17:23:20 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59457) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYgpa-0007R0-M8 for 25573-done@debbugs.gnu.org; Tue, 31 Jan 2017 17:23:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cYgpS-0002nW-CD for 25573-done@debbugs.gnu.org; Tue, 31 Jan 2017 17:23:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54207) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cYgpS-0002nO-9L; Tue, 31 Jan 2017 17:23:10 -0500 Received: from reverse-83.fdn.fr ([80.67.176.83]:48404 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cYgpR-0004nb-G9; Tue, 31 Jan 2017 17:23:09 -0500 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Alex Kost Subject: Re: bug#25573: Adding btrfs support may break reconfigured system References: <87wpddzqsz.fsf@gmail.com> <87sho0evfm.fsf@gnu.org> <87bmuni1di.fsf@gmail.com> Date: Tue, 31 Jan 2017 23:23:07 +0100 In-Reply-To: <87bmuni1di.fsf@gmail.com> (Alex Kost's message of "Tue, 31 Jan 2017 20:29:45 +0300") Message-ID: <87h94eeuno.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25573-done Cc: 25573-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Alex Kost skribis: > Ludovic Court=C3=A8s (2017-01-30 10:41 +0100) wrote: > >> Hi, >> >> Alex Kost skribis: >> >>> Hello, recently I found that "guix system" makes a "broken" system for >>> me. When I boot a freshly created system, I get something like this: >>> >>> In procedure <...> at ./gnu/build/file-systems.scm:282:4 (device) >>> In procedure fport_seek: Invalid argument >>> >>> and I'm thrown at the Guile promt. >> >> I think this is due to =E2=80=98read-superblock=E2=80=99 trying to seek = beyond the end >> of one of the devices that=E2=80=99s on your machine. >> >> Could you try the attached patch and see if it solves the problem? > > Yes, guix makes a bootable system with this modification, thank you! Fixed in 2fe4ceee18f8687de8520d28dbfefc7bc3a7e084, thanks for testing! Ludo=E2=80=99. ------------=_1485901442-28694-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 Jan 2017 18:04:15 +0000 Received: from localhost ([127.0.0.1]:50414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXtpm-0003WF-OM for submit@debbugs.gnu.org; Sun, 29 Jan 2017 13:04:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXtpm-0003W4-06 for submit@debbugs.gnu.org; Sun, 29 Jan 2017 13:04:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXtpf-0004Dm-RA for submit@debbugs.gnu.org; Sun, 29 Jan 2017 13:04:08 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48295) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cXtpf-0004Dg-O6 for submit@debbugs.gnu.org; Sun, 29 Jan 2017 13:04:07 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXtpe-0002Gl-C0 for bug-guix@gnu.org; Sun, 29 Jan 2017 13:04:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXtpb-0004CK-6B for bug-guix@gnu.org; Sun, 29 Jan 2017 13:04:06 -0500 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:34774) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXtpa-0004Br-Ug for bug-guix@gnu.org; Sun, 29 Jan 2017 13:04:03 -0500 Received: by mail-lf0-x242.google.com with SMTP id q89so29737225lfi.1 for ; Sun, 29 Jan 2017 10:04:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:user-agent:mime-version; bh=gJ9ugdJY1i4hI1iU1dToSv6eN197LklBRG6dPMY/Jbg=; b=akW/LE5rHhxsppwkdRkTTmOIEYt1nqbRsvgXm9cGqLhM5pqMQpdPd1uqrSRYM5ao/V 0Ref9czx7WN372+0aXJEkdo4buxOcgmMG3s57Krs5QGl4tLq8YfkPKhc8HF9El8AKrAQ Y8H6WwcPHB8+8BOXWRbVkvWO9rYxboMsMgWKDdFPsMp0DD+sY0S6feoFfGnqNVUc0t92 MihMUEqapTCgQgs72y6ONXGy9VqT/5gQNS9sc22Zhl6zS+n4OWZLSpGIAgqCy9j3HJGK tzIyrwOXx3pAjz5LQ0zGQhq/tIt7YopwiW2xdeDwDc25Os4ke09nBmhZkYNn+yKphxT3 +vDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=gJ9ugdJY1i4hI1iU1dToSv6eN197LklBRG6dPMY/Jbg=; b=TqHFsiciHYt1/NGIW5HbowxbTiM7DyW0CBfUWlBAmtu1EzLKSs1ZvKSdi8ZVQ8STcE LeQQCaqszJUWWwWj0a2JsIQz8Nrr1PppP+iS/UmZkFT/zB8g99vmkBOB/zFOI4uOqIj+ MpWvGL+ca50HvO3LCo3hYensi+cuK38scOBsXslNrpQzgiNOfEX8P1xN5+JEjI9rGqWf COM9ZmJYB1H11hJVk36WX0P9Eme+6/ASLM8QYDhfa6e4i0PT3oV3Jy1mZcMRseqp0GNg ZugWXw55dkHSx3li69k6euUtCojtf6d/YqcU62HOGZxPMlUK/3A/0AYBzQiF56hkFhrf 4ZjA== X-Gm-Message-State: AIkVDXIkoN2KsLeGSO4PBq91Zs76IQpD1L4yhSfKcj/sOfeCqou9ddpkAeNWRpSEuYm2VQ== X-Received: by 10.25.206.146 with SMTP id e140mr6013243lfg.94.1485713039872; Sun, 29 Jan 2017 10:03:59 -0800 (PST) Received: from leviafan ([217.107.194.128]) by smtp.gmail.com with ESMTPSA id s63sm3061971lja.49.2017.01.29.10.03.58 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 29 Jan 2017 10:03:59 -0800 (PST) From: Alex Kost To: bug-guix@gnu.org Subject: Adding btrfs support may break reconfigured system Date: Sun, 29 Jan 2017 21:03:56 +0300 Message-ID: <87wpddzqsz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, recently I found that "guix system" makes a "broken" system for me. When I boot a freshly created system, I get something like this: In procedure <...> at ./gnu/build/file-systems.scm:282:4 (device) In procedure fport_seek: Invalid argument and I'm thrown at the Guile promt. The same problem (well, I think it's the same) was also reported by roptat on #guix: https://gnunet.org/bot/log/guix/2017-01-28#T1277485 After bisecting the guix git checkout, I found that commit b1a505baf6=C2=B9 was the first one where my system starts to fail. And indeed when I reverted this commit on the latest master, guix built a working system. Moreover, the following simple diff (it's a partial revert of that commit) "fixes" guix for me: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=fix-btrfs.diff diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm index 6e5c6aa..f05e035 100644 --- a/gnu/build/file-systems.scm +++ b/gnu/build/file-systems.scm @@ -294,15 +294,11 @@ partition field reader that returned a value." (define %partition-label-readers (list (partition-field-reader read-ext2-superblock - ext2-superblock-volume-name) - (partition-field-reader read-btrfs-superblock - btrfs-superblock-volume-name))) + ext2-superblock-volume-name))) (define %partition-uuid-readers (list (partition-field-reader read-ext2-superblock - ext2-superblock-uuid) - (partition-field-reader read-btrfs-superblock - btrfs-superblock-uuid))) + ext2-superblock-uuid))) (define read-partition-label (cut read-partition-field <> %partition-label-readers)) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I don't have btrfs anywhere (only ext4). During bisecting experiments I used the attached system config (but the config shouldn't matter I think as I tried various variants, and all gave me the same result). Any idea how to dig further? Perhaps there is something I can do in the Guile prompt. =C2=B9 http://git.savannah.gnu.org/cgit/guix.git/commit/?id=3Db1a505baf61cc= 771197eb44af9173f31d2bace46 --=-=-= Content-Type: text/x-scheme Content-Disposition: attachment; filename=bare-bones.scm (use-modules (gnu)) (operating-system (host-name "leviafan") (timezone "Europe/Moscow") (locale "en_US.utf8") (bootloader (grub-configuration (device "/dev/sda"))) (initrd (lambda (fs . args) (apply base-initrd fs #:extra-modules '("sata_nv") ; for my HDD args))) (file-systems (cons (file-system (device "guix") (title 'label) (mount-point "/") (type "ext4")) %base-file-systems)) (users (cons (user-account (name "al") (group "users") (supplementary-groups '("wheel" "audio" "video")) (home-directory "/home/al")) %base-user-accounts)) (packages %base-packages) (services (cons* (console-keymap-service "dvorak") %base-services))) --=-=-=-- ------------=_1485901442-28694-1--