GNU bug report logs - #25565
mark-whole-buffer and unnecessary (point) call

Previous Next

Full log

Message #20 received at 25565 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: dptd dptd <dptdescribe <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 25565 <at> debbugs.gnu.org
Subject: Re: bug#25565: mark-whole-buffer and unnecessary (point) call
Date: Sun, 29 Jan 2017 11:41:52 +0100

On Sun, 29 Jan 2017 09:23:40 +0200 dptd dptd <dptdescribe <at> gmail.com> wrote:

>> On 29 Jan 2017, at 05:40, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> 
>>> From: dptd dptd <dptdescribe <at> gmail.com>
>>> Date: Sat, 28 Jan 2017 23:24:02 +0200
>>> Cc: 25565 <at> debbugs.gnu.org
>>> 
>>> It looks really strange to copy-and-paste the same
>>> explanation for each file / function.
>> 
>> You shouldn't.  The format is this:
>> 
>>  * file (func1, func2, func3): Change description.
>
> So this is how it should looks like? For example:
> --------
> * lisp/textmodes/bib-mode.el (mark-bib): Remove unnecessary call to the
> (point) function from (push-mark).
>
> * lisp/simple.el (mark-whole-buffer, yank): Remove unnecessary call to the
> (point) function from (push-mark).
> --------
> etc.?

The convention used here is to leave all entries that share a common
ChangeLog description blank, except for the last one; see the example in
the "** Commit messages" entry of the CONTRIBUTE file.  So instead of the
above, like this (with a slightly reworded description):

* lisp/textmodes/bib-mode.el (mark-bib):
* lisp/simple.el (mark-whole-buffer, yank): Remove unnecessary argument
`(point)' from calls to `push-mark'.

>> 
>> If you type "C-x 4 a" inside every function, Emacs will format the
>> list for you, even if it's longer than a single line.  Then write the
>> description at the end.
>> 
>
> I didn’t knew about this command! It’s awesome - thank you. However it isn’t
> breaking my lines when
> longer than 78 characters. :( I have tried from both - calling directly from
> the function source code
> and from the magit’s staged changes.

Do you have `fill-column' set somewhere?

Steve Berman

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.