From unknown Tue Jun 17 20:15:56 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#25565 <25565@debbugs.gnu.org> To: bug#25565 <25565@debbugs.gnu.org> Subject: Status: mark-whole-buffer and unnecessary (point) call Reply-To: bug#25565 <25565@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:15:56 +0000 retitle 25565 mark-whole-buffer and unnecessary (point) call reassign 25565 emacs submitter 25565 dptd dptd severity 25565 wishlist tag 25565 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 13:37:13 2017 Received: (at submit) by debbugs.gnu.org; 28 Jan 2017 18:37:13 +0000 Received: from localhost ([127.0.0.1]:49351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXXs8-0006P5-AD for submit@debbugs.gnu.org; Sat, 28 Jan 2017 13:37:12 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXV08-0002Db-7m for submit@debbugs.gnu.org; Sat, 28 Jan 2017 10:33:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXV01-0003Xx-8w for submit@debbugs.gnu.org; Sat, 28 Jan 2017 10:33:10 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43628) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cXV01-0003Xr-5Q for submit@debbugs.gnu.org; Sat, 28 Jan 2017 10:33:09 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXUzz-0006oJ-5G for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 10:33:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXUzv-0003XC-WB for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 10:33:07 -0500 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:36715) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXUzv-0003Wx-MR for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 10:33:03 -0500 Received: by mail-wm0-x243.google.com with SMTP id r126so65479189wmr.3 for ; Sat, 28 Jan 2017 07:33:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=Zy7p+ZnqrJu/dIRr8pwOMTTH2Lp3I2ZQ4psf5Kp4COI=; b=DJHgIghwBd2z6Z82CfPPhjsVjdTSoUBd1JL4t+iuvNWzvRbqLFg2sYUoZMevR+PumH 6POGThIofBDm7fCwfI/KJ+JVj1rGW/nJrChRKw9rUyM9j8vwZNT6YHe7/V0lCfHK31Qd uQd9DDEHxXA1FhtlHoOwPvqbNWdFOiVWpC+yGqTFgQ25xCn187z0nPToW3TVqRny1Hw8 poEGozG26Bx1lBA6yRkpOJKkoMQduzRacSxWNScPpbomc+upxaNTTeqXAOMt5HlNqhgR J11tZGzrzz6ObgDZ34OG68guvSOLhcwnUGJ1hWkow2OmZ0BtRafYcu7IlU0MBAeMHowI bMYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=Zy7p+ZnqrJu/dIRr8pwOMTTH2Lp3I2ZQ4psf5Kp4COI=; b=N9lhEwNOM37HPSNWPj91BUyzel/YSbB14H54EGfpjXUQoCAY9rQJIyFAJuOOZ/bwhV kIybNgukMXv2VGD0S3Hea/ZOwQ7XKhEbju86oVRsE4Plzw+lkp7ZGo3rzu5OomBgv5dz u+Y9LSlZ4+CnB6JsWhdsYlDenAZFOQdUcTzNiDRchFVw8+9+T+Mr5lm47mlXScARsdiu j4OSb5kS2O/y+3F6lEEpvgWABmbgpE0k7DJYhf8Q0uSBGFx/XlkWwWzCJ9K+k7CvaBrE W4cB5y/plzLJ6L/5Zb7q/wYH8KW1h0XxwFcKlsT9RuCqqpMScPh7vlZnThBKfvQh5cO9 0PSQ== X-Gm-Message-State: AIkVDXLzsckHVz4aTfl/n7fDXMfFZWhcpGHkTDNrSHB1uu2ER2owlaNqgf2vJiCjd+deJA== X-Received: by 10.223.151.99 with SMTP id r90mr11364378wrb.183.1485617582277; Sat, 28 Jan 2017 07:33:02 -0800 (PST) Received: from [192.168.60.140] ([212.50.23.124]) by smtp.gmail.com with ESMTPSA id d14sm9337205wmd.19.2017.01.28.07.33.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Jan 2017 07:33:01 -0800 (PST) From: dptd dptd Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: mark-whole-buffer and unnecessary (point) call Message-Id: <50AC4AE1-C37B-4BD7-BBB1-8680E60DCB1F@gmail.com> Date: Sat, 28 Jan 2017 17:33:00 +0200 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3259) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 28 Jan 2017 13:37:10 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hello everyone, This is my first patch so please let me know if I am doing something = wrong in the process. I do not know if I should sent just the plain diff file without any = =E2=80=98introduction=E2=80=99 but let me just say that today I have created thread (same name) on emacs-devel mailing = list about this change and I am not pasting it here because I do not (yet!) know if I = should. Thanks! Bartosz Duszel (dptd) =46rom 8434ca3015fb8b0fb34aa8f1e979e005bd7275eb Mon Sep 17 00:00:00 2001 From: Bartosz Duszel Date: Sat, 28 Jan 2017 13:00:12 +0200 Subject: [PATCH] Removed explicit call to (point) function in = (push-mark) calls Arguments for (push-mark) are optional. When there are no arguments passed to the function then by default current point location is used. --- lisp/allout.el | 2 +- lisp/cedet/semantic/senator.el | 2 +- lisp/emulation/viper-cmd.el | 4 ++-- lisp/hexl.el | 4 ++-- lisp/mail/sendmail.el | 2 +- lisp/menu-bar.el | 2 +- lisp/mouse.el | 2 +- lisp/obsolete/vi.el | 2 +- lisp/obsolete/vip.el | 2 +- lisp/progmodes/cc-cmds.el | 2 +- lisp/progmodes/icon.el | 4 ++-- lisp/progmodes/meta-mode.el | 2 +- lisp/progmodes/pascal.el | 4 ++-- lisp/progmodes/perl-mode.el | 4 ++-- lisp/progmodes/verilog-mode.el | 4 ++-- lisp/progmodes/xscheme.el | 2 +- lisp/ses.el | 6 +++--- lisp/simple.el | 4 ++-- lisp/textmodes/bib-mode.el | 2 +- 19 files changed, 28 insertions(+), 28 deletions(-) diff --git a/lisp/allout.el b/lisp/allout.el index 4a0aeeedf6..c6368cd54d 100644 --- a/lisp/allout.el +++ b/lisp/allout.el @@ -6504,7 +6504,7 @@ allout-mark-topic (let ((inhibit-field-text-motion t)) (beginning-of-line)) (allout-goto-prefix-doublechecked) - (push-mark (point)) + (push-mark) (allout-end-of-current-subtree) (exchange-point-and-mark)) ;;;_ : UI: diff --git a/lisp/cedet/semantic/senator.el = b/lisp/cedet/semantic/senator.el index 407bb05add..f1918c4091 100644 --- a/lisp/cedet/semantic/senator.el +++ b/lisp/cedet/semantic/senator.el @@ -659,7 +659,7 @@ senator-mark-defun (end (progn (senator-end-of-defun) (point))) (start (progn (senator-beginning-of-defun) (point)))) (goto-char origin) - (push-mark (point)) + (push-mark) (goto-char end) ;; end-of-defun (push-mark (point) nil t) (goto-char start) ;; beginning-of-defun diff --git a/lisp/emulation/viper-cmd.el b/lisp/emulation/viper-cmd.el index 86364282dc..e71bf0e37a 100644 --- a/lisp/emulation/viper-cmd.el +++ b/lisp/emulation/viper-cmd.el @@ -4346,7 +4346,7 @@ viper-query-replace (defun viper-mark-beginning-of-buffer () "Mark beginning of buffer." (interactive) - (push-mark (point)) + (push-mark) (goto-char (point-min)) (exchange-point-and-mark) (message "Mark set at the beginning of buffer")) @@ -4354,7 +4354,7 @@ viper-mark-beginning-of-buffer (defun viper-mark-end-of-buffer () "Mark end of buffer." (interactive) - (push-mark (point)) + (push-mark) (goto-char (point-max)) (exchange-point-and-mark) (message "Mark set at the end of buffer")) diff --git a/lisp/hexl.el b/lisp/hexl.el index b5e9c1ff33..0a598b22f6 100644 --- a/lisp/hexl.el +++ b/lisp/hexl.el @@ -730,13 +730,13 @@ hexl-beginning-of-buffer Leaves `hexl-mark' at previous position. With prefix arg N, puts point N bytes of the way from the true = beginning." (interactive "p") - (push-mark (point)) + (push-mark) (hexl-goto-address (+ 0 (1- arg)))) =20 (defun hexl-end-of-buffer (arg) "Go to `hexl-max-address' minus ARG." (interactive "p") - (push-mark (point)) + (push-mark) (hexl-goto-address (- hexl-max-address (1- arg)))) =20 (defun hexl-beginning-of-line () diff --git a/lisp/mail/sendmail.el b/lisp/mail/sendmail.el index 70c8ea1f93..4121cd773b 100644 --- a/lisp/mail/sendmail.el +++ b/lisp/mail/sendmail.el @@ -1676,7 +1676,7 @@ mail-yank-original ;; Call yank function, and set the mark if it doesn't. (apply (car original) (cdr original)) (if (eq omark (mark t)) - (push-mark (point)))) + (push-mark))) ;; If the original message is in another window in the same ;; frame, delete that window to save space. (delete-windows-on original t) diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index 28464f13df..c2733a5892 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -1971,7 +1971,7 @@ menu-bar-select-yank "Insert the stretch of previously-killed text selected from menu. The menu shows all the killed text sequences stored in `kill-ring'." (interactive "*") - (push-mark (point)) + (push-mark) (insert last-command-event)) =20 =0C diff --git a/lisp/mouse.el b/lisp/mouse.el index 0f1d446040..0520fd1ab9 100644 --- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -1135,7 +1135,7 @@ mouse-yank-primary (deactivate-mark))) (or mouse-yank-at-point (mouse-set-point click)) (let ((primary (gui-get-primary-selection))) - (push-mark (point)) + (push-mark) (insert-for-yank primary))) =20 (defun mouse-kill-ring-save (click) diff --git a/lisp/obsolete/vi.el b/lisp/obsolete/vi.el index 081b229ebc..5b611aa2d0 100644 --- a/lisp/obsolete/vi.el +++ b/lisp/obsolete/vi.el @@ -1128,7 +1128,7 @@ vi-put-before (progn (forward-line 1) (beginning-of-line)) (beginning-of-line)) (if after-p (forward-char 1))) - (push-mark (point)) + (push-mark) (insert put-text) (exchange-point-and-mark) ;; (back-to-indentation) ; this is not allowed if we allow = yank-pop diff --git a/lisp/obsolete/vip.el b/lisp/obsolete/vip.el index ca0bfe712c..4d70d6a5df 100644 --- a/lisp/obsolete/vip.el +++ b/lisp/obsolete/vip.el @@ -2596,7 +2596,7 @@ ex-goto "ex goto command" (if (null ex-addresses) (setq ex-addresses (cons (point) nil))) - (push-mark (point)) + (push-mark) (goto-char (car ex-addresses)) (beginning-of-line)) =20 diff --git a/lisp/progmodes/cc-cmds.el b/lisp/progmodes/cc-cmds.el index 561e6767e1..a5ddcb4b92 100644 --- a/lisp/progmodes/cc-cmds.el +++ b/lisp/progmodes/cc-cmds.el @@ -2041,7 +2041,7 @@ c-mark-function (push-mark-p (and (eq this-command 'c-mark-function) (not extend-region-p) (not (c-region-is-active-p))))) - (if push-mark-p (push-mark (point))) + (if push-mark-p (push-mark)) (if extend-region-p (progn (exchange-point-and-mark) diff --git a/lisp/progmodes/icon.el b/lisp/progmodes/icon.el index 0c699a00e8..92a89fef70 100644 --- a/lisp/progmodes/icon.el +++ b/lisp/progmodes/icon.el @@ -459,9 +459,9 @@ icon-backward-to-start-of-if (defun mark-icon-function () "Put mark at end of Icon function, point at beginning." (interactive) - (push-mark (point)) + (push-mark) (end-of-icon-defun) - (push-mark (point)) + (push-mark) (beginning-of-line 0) (beginning-of-icon-defun)) =20 diff --git a/lisp/progmodes/meta-mode.el b/lisp/progmodes/meta-mode.el index 3db3b8ad73..3377226388 100644 --- a/lisp/progmodes/meta-mode.el +++ b/lisp/progmodes/meta-mode.el @@ -780,7 +780,7 @@ meta-mark-defun "Put mark at end of the environment, point at the beginning. The environment marked is the one that contains point or follows = point." (interactive) - (push-mark (point)) + (push-mark) (meta-end-of-defun) (push-mark (point) nil t) (meta-beginning-of-defun)) diff --git a/lisp/progmodes/pascal.el b/lisp/progmodes/pascal.el index bf49ba4a36..a7d0624a74 100644 --- a/lisp/progmodes/pascal.el +++ b/lisp/progmodes/pascal.el @@ -507,9 +507,9 @@ pascal-mark-defun "Mark the current Pascal function (or procedure). This puts the mark at the end, and point at the beginning." (interactive) - (push-mark (point)) + (push-mark) (pascal-end-of-defun) - (push-mark (point)) + (push-mark) (pascal-beg-of-defun) (when (featurep 'xemacs) (zmacs-activate-region))) diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el index a516f07e72..1880bdd040 100644 --- a/lisp/progmodes/perl-mode.el +++ b/lisp/progmodes/perl-mode.el @@ -1102,9 +1102,9 @@ 'mark-perl-function (defun perl-mark-function () "Put mark at end of Perl function, point at beginning." (interactive) - (push-mark (point)) + (push-mark) (perl-end-of-function) - (push-mark (point)) + (push-mark) (perl-beginning-of-function) (backward-paragraph)) =20 diff --git a/lisp/progmodes/verilog-mode.el = b/lisp/progmodes/verilog-mode.el index 48ee55500f..9f3bad1c1a 100644 --- a/lisp/progmodes/verilog-mode.el +++ b/lisp/progmodes/verilog-mode.el @@ -4212,9 +4212,9 @@ verilog-mark-defun (interactive) (if (featurep 'xemacs) (progn - (push-mark (point)) + (push-mark) (verilog-end-of-defun) - (push-mark (point)) + (push-mark) (verilog-beg-of-defun) (if (fboundp 'zmacs-activate-region) (zmacs-activate-region))) diff --git a/lisp/progmodes/xscheme.el b/lisp/progmodes/xscheme.el index 4502c6d33f..bdfe30af50 100644 --- a/lisp/progmodes/xscheme.el +++ b/lisp/progmodes/xscheme.el @@ -580,7 +580,7 @@ xscheme-yank (xscheme-rotate-yank-pointer (if (listp arg) 0 (if (eq arg '-) -1 (1- arg)))) - (push-mark (point)) + (push-mark) (insert (car xscheme-expressions-ring-yank-pointer)) (if (consp arg) (exchange-point-and-mark))) diff --git a/lisp/ses.el b/lisp/ses.el index 76d4ca577d..f8fd17d0de 100644 --- a/lisp/ses.el +++ b/lisp/ses.el @@ -3023,7 +3023,7 @@ ses--advice-yank (eq (get-text-property (point) 'keymap) = 'ses-mode-print-map))) (apply yank-fun arg args) ; Normal non-SES yank. (ses-check-curcell 'end) - (push-mark (point)) + (push-mark) (let ((text (current-kill (cond ((listp arg) 0) ((eq arg '-) -1) @@ -3290,7 +3290,7 @@ ses-mark-row (interactive) (ses-check-curcell 'range) (let ((row (car (ses-sym-rowcol (or (car-safe ses--curcell) = ses--curcell))))) - (push-mark (point)) + (push-mark) (ses-goto-print (1+ row) 0) (push-mark (point) nil t) (ses-goto-print row 0))) @@ -3301,7 +3301,7 @@ ses-mark-column (ses-check-curcell 'range) (let ((col (cdr (ses-sym-rowcol (or (car-safe ses--curcell) = ses--curcell)))) (row 0)) - (push-mark (point)) + (push-mark) (ses-goto-print (1- ses--numrows) col) (forward-char 1) (push-mark (point) nil t) diff --git a/lisp/simple.el b/lisp/simple.el index bdc6abde1f..281d9766aa 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -1105,7 +1105,7 @@ mark-whole-buffer that uses or sets the mark." (declare (interactive-only t)) (interactive) - (push-mark (point)) + (push-mark) (push-mark (point-max) nil t) ;; This is really `point-min' in most cases, but if we're in the ;; minibuffer, this is at the end of the prompt. @@ -4858,7 +4858,7 @@ yank ;; If we don't get all the way thru, make last-command indicate that ;; for the following command. (setq this-command t) - (push-mark (point)) + (push-mark) (insert-for-yank (current-kill (cond ((listp arg) 0) ((eq arg '-) -2) diff --git a/lisp/textmodes/bib-mode.el b/lisp/textmodes/bib-mode.el index 74d214496e..2f3c17b3b2 100644 --- a/lisp/textmodes/bib-mode.el +++ b/lisp/textmodes/bib-mode.el @@ -181,7 +181,7 @@ mark-bib (re-search-backward "^ *$" nil 2) (re-search-forward "^%") (beginning-of-line nil) - (push-mark (point)) + (push-mark) (re-search-forward "^ *$" nil 2) (forward-line 1) (beginning-of-line nil)) --=20 2.11.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 14:09:10 2017 Received: (at 25565) by debbugs.gnu.org; 28 Jan 2017 19:09:10 +0000 Received: from localhost ([127.0.0.1]:49370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXYN3-00077t-QJ for submit@debbugs.gnu.org; Sat, 28 Jan 2017 14:09:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXYN2-00077e-9M for 25565@debbugs.gnu.org; Sat, 28 Jan 2017 14:09:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXYMs-00089D-AW for 25565@debbugs.gnu.org; Sat, 28 Jan 2017 14:09:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXYMs-000899-7N; Sat, 28 Jan 2017 14:08:58 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2423 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cXYMr-0004fh-1N; Sat, 28 Jan 2017 14:08:58 -0500 Date: Sat, 28 Jan 2017 21:08:38 +0200 Message-Id: <83vaszxart.fsf@gnu.org> From: Eli Zaretskii To: dptd dptd In-reply-to: <50AC4AE1-C37B-4BD7-BBB1-8680E60DCB1F@gmail.com> (message from dptd dptd on Sat, 28 Jan 2017 17:33:00 +0200) Subject: Re: bug#25565: mark-whole-buffer and unnecessary (point) call References: <50AC4AE1-C37B-4BD7-BBB1-8680E60DCB1F@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.2 (--------) X-Debbugs-Envelope-To: 25565 Cc: 25565@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.2 (--------) > From: dptd dptd > Date: Sat, 28 Jan 2017 17:33:00 +0200 > > This is my first patch so please let me know if I am doing something wrong in the process. > I do not know if I should sent just the plain diff file without any ‘introduction’ but let me just > say that today I have created thread (same name) on emacs-devel mailing list about this > change and I am not pasting it here because I do not (yet!) know if I should. Thanks. This lacks a ChangeLog-style commit log message, naming every function where you made a change. See CONTRIBUTE for the details. Other than that, we will wait until your legal paperwork is done. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 16:24:13 2017 Received: (at 25565) by debbugs.gnu.org; 28 Jan 2017 21:24:13 +0000 Received: from localhost ([127.0.0.1]:49477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXaTk-0003Tz-IN for submit@debbugs.gnu.org; Sat, 28 Jan 2017 16:24:13 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXaTi-0003Tl-LT for 25565@debbugs.gnu.org; Sat, 28 Jan 2017 16:24:11 -0500 Received: by mail-wm0-f67.google.com with SMTP id c85so67120152wmi.1 for <25565@debbugs.gnu.org>; Sat, 28 Jan 2017 13:24:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=szXNOpMr+G8hd13LTQ2fNGqO+XH0gXnga4cF+m3Dciw=; b=NPry84IDWm1T1pj0pEa6gebGn+AVvHzx6Iw7fK+rwQFIt+UjIa3sDEoSO0Uhr+2522 6ImdgB44E4aYAcalcgrjaYrVye6FPR2xVn0+hAN2piHba1dqJfFxWqQ4jsZs1/RdCgsq 51ESh7h+maWdB0WBQvzRj41kOGzmbCpWqTUMhawUHXhX5Ef21NudB5OumrM5YeRbkdIe PE1SXbR2Yqpor0K8No4z1rItXguSMhHKcBfNVx/bq+o8lbIBxoGCwxBJxwDZ0S6ici/m wTQMsnPbSAZOe2aYM6bokoZRKaeuk06PkV6pTFCwpQeAP2BFRXl3fHyinTDs1RBzJE9D Miwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=szXNOpMr+G8hd13LTQ2fNGqO+XH0gXnga4cF+m3Dciw=; b=bukwIEnVteXQ8Z2SJz8xAAoZY0Y0S2xNmK8Vk5hiRERDubV5H2vQ3UULgJ63U89jb8 +BFcKAYat57B7yekUq7IgD07AD2ieTVtG12uagS8mOG2zGC9OxV5b5xPLZQE6taxEmPD 6rfKuhpfv1GA7vowt0YW2dsMXM2rhr7qxiw/3AxcD34pPHNHk7qgqTSRUNS0AODZa+yn kSv9qL7VrvVvjzorzUqVhMMtogF6n3sEx4qrdF7E7IKNCatyw+VHBh0uVXybW235emzr d0F495+L8hKeYhLrqbeLLAY6oIqlWxe4bWKugmnoC8cti0QWvyYEyxFqwwL4Es5EZjFi BtwQ== X-Gm-Message-State: AIkVDXK0Wx6ElSa24QjaO4Q6Nv1q/6mecVHpqhhSOJD3B45Ac7yc5uxlLEEiPOExB0c8Iw== X-Received: by 10.223.131.193 with SMTP id 59mr12569291wre.186.1485638644422; Sat, 28 Jan 2017 13:24:04 -0800 (PST) Received: from [192.168.60.140] ([212.50.23.124]) by smtp.gmail.com with ESMTPSA id l37sm14632443wrc.41.2017.01.28.13.24.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Jan 2017 13:24:03 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: bug#25565: mark-whole-buffer and unnecessary (point) call From: dptd dptd In-Reply-To: <83vaszxart.fsf@gnu.org> Date: Sat, 28 Jan 2017 23:24:02 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <63A9E421-58EB-4E02-9F71-B250ADFB0BCD@gmail.com> References: <50AC4AE1-C37B-4BD7-BBB1-8680E60DCB1F@gmail.com> <83vaszxart.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3259) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25565 Cc: 25565@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) > On 28 Jan 2017, at 21:08, Eli Zaretskii wrote: >=20 >> From: dptd dptd >> Date: Sat, 28 Jan 2017 17:33:00 +0200 >>=20 >> This is my first patch so please let me know if I am doing something = wrong in the process. >> I do not know if I should sent just the plain diff file without any = =E2=80=98introduction=E2=80=99 but let me just >> say that today I have created thread (same name) on emacs-devel = mailing list about this >> change and I am not pasting it here because I do not (yet!) know if I = should. >=20 > Thanks. This lacks a ChangeLog-style commit log message, naming every > function where you made a change. See CONTRIBUTE for the details. >=20 > Other than that, we will wait until your legal paperwork is done. Perfect. I wasn=E2=80=99t able to find similar case to mine in the = current git log where someone has changed the same function in plenty of files. It looks really strange to = copy-and-paste the same explanation for each file / function. Hope it is better now. Btw. why in = my patch next to the ID is so strange date? Mon Sep 17 00:00:00 2001? =46rom 0398ad77868139db089a61dc2700230c98964f3a Mon Sep 17 00:00:00 2001 From: Bartosz Duszel Date: Sat, 28 Jan 2017 13:00:12 +0200 Subject: [PATCH] Removed explicit call to (point) function in = (push-mark) calls * lisp/allout.el (allout-mark-topic): When there are no arguments passed = to the (push-mark) function then current point position is being used by default. * lisp/cedet/semantic/senator.el (senator-mark-defun): When there are no arguments passed to the (push-mark) function then current point position is being used by default. * lisp/emulation/viper-cmd.el (viper-mark-beginning-of-buffer): When there are no arguments passed to the (push-mark) function then current point position is being used by default. * lisp/emulation/viper-cmd.el (viper-mark-end-of-buffer): When there are no arguments passed to the (push-mark) function then current point position is being used by default. * lisp/hexl.el (hexl-beginning-of-buffer): When there are no arguments passed to the (push-mark) function then current point position is being used by default. * lisp/hexl.el (hexl-end-of-buffer): When there are no arguments passed = to the (push-mark) function then current point position is being used by default. * lisp/mail/sendmail.el (mail-yank-original): When there are no arguments passed to the (push-mark) function then current point position is being used by default. * lisp/menu-bar.el (menu-bar-select-yank): When there are no arguments passed to the (push-mark) function then current point position is = being used by default. * lisp/mouse.el (mouse-yank-primary): When there are no arguments passed = to the (push-mark) function then current point position is being used by default. * lisp/obsolete/vi.el (vi-put-before): When there are no arguments = passed to the (push-mark) function then current point position is being used by default. * lisp/obsolete/vip.el (ex-goto): When there are no arguments passed to the (push-mark) function then current point position is being used by default. * lisp/progmodes/cc-cmds.el (c-mark-function): When there are no arguments passed to the (push-mark) function then current point position is being used by default. * lisp/progmodes/icon.el (mark-icon-function): When there are no arguments passed to the (push-mark) function then current point position is being used by default. * lisp/progmodes/meta-mode.el (meta-mark-defun): When there are no arguments passed to the (push-mark) function then current point position is being used by default. * lisp/progmodes/pascal.el (pascal-mark-defun): When there are no arguments passed to the (push-mark) function then current point position is being used by default. * lisp/progmodes/perl-mode.el (perl-mark-function): When there are no arguments passed to the (push-mark) function then current point position is being used by default. * lisp/progmodes/verilog-mode.el (verilog-mark-defun): When there are no arguments passed to the (push-mark) function then current point position is being used by default. * lisp/progmodes/xscheme.el (xscheme-yank): When there are no arguments passed to the (push-mark) function then current point position is being used by default. * lisp/ses.el (ses--advice-yank): When there are no arguments passed to the (push-mark) function then current point position is being used by default. * lisp/ses.el (ses-mark-row): When there are no arguments passed to the (push-mark) function then current point position is being used by default. * lisp/ses.el (ses-mark-column): When there are no arguments passed to the (push-mark) function then current point position is being used by default. * lisp/simple.el (mark-whole-buffer): When there are no arguments passed = to the (push-mark) function then current point position is being used by default. * lisp/simple.el (yank): When there are no arguments passed to the (push-mark) function then current point position is being used by default. * lisp/textmodes/bib-mode.el (mark-bib): When there are no arguments = passed to the (push-mark) function then current point position is being used by default. --- lisp/allout.el | 2 +- lisp/cedet/semantic/senator.el | 2 +- lisp/emulation/viper-cmd.el | 4 ++-- lisp/hexl.el | 4 ++-- lisp/mail/sendmail.el | 2 +- lisp/menu-bar.el | 2 +- lisp/mouse.el | 2 +- lisp/obsolete/vi.el | 2 +- lisp/obsolete/vip.el | 2 +- lisp/progmodes/cc-cmds.el | 2 +- lisp/progmodes/icon.el | 4 ++-- lisp/progmodes/meta-mode.el | 2 +- lisp/progmodes/pascal.el | 4 ++-- lisp/progmodes/perl-mode.el | 4 ++-- lisp/progmodes/verilog-mode.el | 4 ++-- lisp/progmodes/xscheme.el | 2 +- lisp/ses.el | 6 +++--- lisp/simple.el | 4 ++-- lisp/textmodes/bib-mode.el | 2 +- 19 files changed, 28 insertions(+), 28 deletions(-) diff --git a/lisp/allout.el b/lisp/allout.el index 4a0aeeedf6..c6368cd54d 100644 --- a/lisp/allout.el +++ b/lisp/allout.el @@ -6504,7 +6504,7 @@ allout-mark-topic (let ((inhibit-field-text-motion t)) (beginning-of-line)) (allout-goto-prefix-doublechecked) - (push-mark (point)) + (push-mark) (allout-end-of-current-subtree) (exchange-point-and-mark)) ;;;_ : UI: diff --git a/lisp/cedet/semantic/senator.el = b/lisp/cedet/semantic/senator.el index 407bb05add..f1918c4091 100644 --- a/lisp/cedet/semantic/senator.el +++ b/lisp/cedet/semantic/senator.el @@ -659,7 +659,7 @@ senator-mark-defun (end (progn (senator-end-of-defun) (point))) (start (progn (senator-beginning-of-defun) (point)))) (goto-char origin) - (push-mark (point)) + (push-mark) (goto-char end) ;; end-of-defun (push-mark (point) nil t) (goto-char start) ;; beginning-of-defun diff --git a/lisp/emulation/viper-cmd.el b/lisp/emulation/viper-cmd.el index 86364282dc..e71bf0e37a 100644 --- a/lisp/emulation/viper-cmd.el +++ b/lisp/emulation/viper-cmd.el @@ -4346,7 +4346,7 @@ viper-query-replace (defun viper-mark-beginning-of-buffer () "Mark beginning of buffer." (interactive) - (push-mark (point)) + (push-mark) (goto-char (point-min)) (exchange-point-and-mark) (message "Mark set at the beginning of buffer")) @@ -4354,7 +4354,7 @@ viper-mark-beginning-of-buffer (defun viper-mark-end-of-buffer () "Mark end of buffer." (interactive) - (push-mark (point)) + (push-mark) (goto-char (point-max)) (exchange-point-and-mark) (message "Mark set at the end of buffer")) diff --git a/lisp/hexl.el b/lisp/hexl.el index b5e9c1ff33..0a598b22f6 100644 --- a/lisp/hexl.el +++ b/lisp/hexl.el @@ -730,13 +730,13 @@ hexl-beginning-of-buffer Leaves `hexl-mark' at previous position. With prefix arg N, puts point N bytes of the way from the true = beginning." (interactive "p") - (push-mark (point)) + (push-mark) (hexl-goto-address (+ 0 (1- arg)))) =20 (defun hexl-end-of-buffer (arg) "Go to `hexl-max-address' minus ARG." (interactive "p") - (push-mark (point)) + (push-mark) (hexl-goto-address (- hexl-max-address (1- arg)))) =20 (defun hexl-beginning-of-line () diff --git a/lisp/mail/sendmail.el b/lisp/mail/sendmail.el index 70c8ea1f93..4121cd773b 100644 --- a/lisp/mail/sendmail.el +++ b/lisp/mail/sendmail.el @@ -1676,7 +1676,7 @@ mail-yank-original ;; Call yank function, and set the mark if it doesn't. (apply (car original) (cdr original)) (if (eq omark (mark t)) - (push-mark (point)))) + (push-mark))) ;; If the original message is in another window in the same ;; frame, delete that window to save space. (delete-windows-on original t) diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index 28464f13df..c2733a5892 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -1971,7 +1971,7 @@ menu-bar-select-yank "Insert the stretch of previously-killed text selected from menu. The menu shows all the killed text sequences stored in `kill-ring'." (interactive "*") - (push-mark (point)) + (push-mark) (insert last-command-event)) =20 =0C diff --git a/lisp/mouse.el b/lisp/mouse.el index 0f1d446040..0520fd1ab9 100644 --- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -1135,7 +1135,7 @@ mouse-yank-primary (deactivate-mark))) (or mouse-yank-at-point (mouse-set-point click)) (let ((primary (gui-get-primary-selection))) - (push-mark (point)) + (push-mark) (insert-for-yank primary))) =20 (defun mouse-kill-ring-save (click) diff --git a/lisp/obsolete/vi.el b/lisp/obsolete/vi.el index 081b229ebc..5b611aa2d0 100644 --- a/lisp/obsolete/vi.el +++ b/lisp/obsolete/vi.el @@ -1128,7 +1128,7 @@ vi-put-before (progn (forward-line 1) (beginning-of-line)) (beginning-of-line)) (if after-p (forward-char 1))) - (push-mark (point)) + (push-mark) (insert put-text) (exchange-point-and-mark) ;; (back-to-indentation) ; this is not allowed if we allow = yank-pop diff --git a/lisp/obsolete/vip.el b/lisp/obsolete/vip.el index ca0bfe712c..4d70d6a5df 100644 --- a/lisp/obsolete/vip.el +++ b/lisp/obsolete/vip.el @@ -2596,7 +2596,7 @@ ex-goto "ex goto command" (if (null ex-addresses) (setq ex-addresses (cons (point) nil))) - (push-mark (point)) + (push-mark) (goto-char (car ex-addresses)) (beginning-of-line)) =20 diff --git a/lisp/progmodes/cc-cmds.el b/lisp/progmodes/cc-cmds.el index 561e6767e1..a5ddcb4b92 100644 --- a/lisp/progmodes/cc-cmds.el +++ b/lisp/progmodes/cc-cmds.el @@ -2041,7 +2041,7 @@ c-mark-function (push-mark-p (and (eq this-command 'c-mark-function) (not extend-region-p) (not (c-region-is-active-p))))) - (if push-mark-p (push-mark (point))) + (if push-mark-p (push-mark)) (if extend-region-p (progn (exchange-point-and-mark) diff --git a/lisp/progmodes/icon.el b/lisp/progmodes/icon.el index 0c699a00e8..92a89fef70 100644 --- a/lisp/progmodes/icon.el +++ b/lisp/progmodes/icon.el @@ -459,9 +459,9 @@ icon-backward-to-start-of-if (defun mark-icon-function () "Put mark at end of Icon function, point at beginning." (interactive) - (push-mark (point)) + (push-mark) (end-of-icon-defun) - (push-mark (point)) + (push-mark) (beginning-of-line 0) (beginning-of-icon-defun)) =20 diff --git a/lisp/progmodes/meta-mode.el b/lisp/progmodes/meta-mode.el index 3db3b8ad73..3377226388 100644 --- a/lisp/progmodes/meta-mode.el +++ b/lisp/progmodes/meta-mode.el @@ -780,7 +780,7 @@ meta-mark-defun "Put mark at end of the environment, point at the beginning. The environment marked is the one that contains point or follows = point." (interactive) - (push-mark (point)) + (push-mark) (meta-end-of-defun) (push-mark (point) nil t) (meta-beginning-of-defun)) diff --git a/lisp/progmodes/pascal.el b/lisp/progmodes/pascal.el index bf49ba4a36..a7d0624a74 100644 --- a/lisp/progmodes/pascal.el +++ b/lisp/progmodes/pascal.el @@ -507,9 +507,9 @@ pascal-mark-defun "Mark the current Pascal function (or procedure). This puts the mark at the end, and point at the beginning." (interactive) - (push-mark (point)) + (push-mark) (pascal-end-of-defun) - (push-mark (point)) + (push-mark) (pascal-beg-of-defun) (when (featurep 'xemacs) (zmacs-activate-region))) diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el index a516f07e72..1880bdd040 100644 --- a/lisp/progmodes/perl-mode.el +++ b/lisp/progmodes/perl-mode.el @@ -1102,9 +1102,9 @@ 'mark-perl-function (defun perl-mark-function () "Put mark at end of Perl function, point at beginning." (interactive) - (push-mark (point)) + (push-mark) (perl-end-of-function) - (push-mark (point)) + (push-mark) (perl-beginning-of-function) (backward-paragraph)) =20 diff --git a/lisp/progmodes/verilog-mode.el = b/lisp/progmodes/verilog-mode.el index 48ee55500f..9f3bad1c1a 100644 --- a/lisp/progmodes/verilog-mode.el +++ b/lisp/progmodes/verilog-mode.el @@ -4212,9 +4212,9 @@ verilog-mark-defun (interactive) (if (featurep 'xemacs) (progn - (push-mark (point)) + (push-mark) (verilog-end-of-defun) - (push-mark (point)) + (push-mark) (verilog-beg-of-defun) (if (fboundp 'zmacs-activate-region) (zmacs-activate-region))) diff --git a/lisp/progmodes/xscheme.el b/lisp/progmodes/xscheme.el index 4502c6d33f..bdfe30af50 100644 --- a/lisp/progmodes/xscheme.el +++ b/lisp/progmodes/xscheme.el @@ -580,7 +580,7 @@ xscheme-yank (xscheme-rotate-yank-pointer (if (listp arg) 0 (if (eq arg '-) -1 (1- arg)))) - (push-mark (point)) + (push-mark) (insert (car xscheme-expressions-ring-yank-pointer)) (if (consp arg) (exchange-point-and-mark))) diff --git a/lisp/ses.el b/lisp/ses.el index 76d4ca577d..f8fd17d0de 100644 --- a/lisp/ses.el +++ b/lisp/ses.el @@ -3023,7 +3023,7 @@ ses--advice-yank (eq (get-text-property (point) 'keymap) = 'ses-mode-print-map))) (apply yank-fun arg args) ; Normal non-SES yank. (ses-check-curcell 'end) - (push-mark (point)) + (push-mark) (let ((text (current-kill (cond ((listp arg) 0) ((eq arg '-) -1) @@ -3290,7 +3290,7 @@ ses-mark-row (interactive) (ses-check-curcell 'range) (let ((row (car (ses-sym-rowcol (or (car-safe ses--curcell) = ses--curcell))))) - (push-mark (point)) + (push-mark) (ses-goto-print (1+ row) 0) (push-mark (point) nil t) (ses-goto-print row 0))) @@ -3301,7 +3301,7 @@ ses-mark-column (ses-check-curcell 'range) (let ((col (cdr (ses-sym-rowcol (or (car-safe ses--curcell) = ses--curcell)))) (row 0)) - (push-mark (point)) + (push-mark) (ses-goto-print (1- ses--numrows) col) (forward-char 1) (push-mark (point) nil t) diff --git a/lisp/simple.el b/lisp/simple.el index bdc6abde1f..281d9766aa 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -1105,7 +1105,7 @@ mark-whole-buffer that uses or sets the mark." (declare (interactive-only t)) (interactive) - (push-mark (point)) + (push-mark) (push-mark (point-max) nil t) ;; This is really `point-min' in most cases, but if we're in the ;; minibuffer, this is at the end of the prompt. @@ -4858,7 +4858,7 @@ yank ;; If we don't get all the way thru, make last-command indicate that ;; for the following command. (setq this-command t) - (push-mark (point)) + (push-mark) (insert-for-yank (current-kill (cond ((listp arg) 0) ((eq arg '-) -2) diff --git a/lisp/textmodes/bib-mode.el b/lisp/textmodes/bib-mode.el index 74d214496e..2f3c17b3b2 100644 --- a/lisp/textmodes/bib-mode.el +++ b/lisp/textmodes/bib-mode.el @@ -181,7 +181,7 @@ mark-bib (re-search-backward "^ *$" nil 2) (re-search-forward "^%") (beginning-of-line nil) - (push-mark (point)) + (push-mark) (re-search-forward "^ *$" nil 2) (forward-line 1) (beginning-of-line nil)) --=20 2.11.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 22:41:17 2017 Received: (at 25565) by debbugs.gnu.org; 29 Jan 2017 03:41:17 +0000 Received: from localhost ([127.0.0.1]:49605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXgMf-0001w5-CV for submit@debbugs.gnu.org; Sat, 28 Jan 2017 22:41:17 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37155) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXgMd-0001vs-M8 for 25565@debbugs.gnu.org; Sat, 28 Jan 2017 22:41:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXgMU-0005Jv-9x for 25565@debbugs.gnu.org; Sat, 28 Jan 2017 22:41:10 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXgMU-0005Jb-6k; Sat, 28 Jan 2017 22:41:06 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2808 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cXgMT-00052K-F7; Sat, 28 Jan 2017 22:41:05 -0500 Date: Sun, 29 Jan 2017 05:40:59 +0200 Message-Id: <83mveay1mc.fsf@gnu.org> From: Eli Zaretskii To: dptd dptd In-reply-to: <63A9E421-58EB-4E02-9F71-B250ADFB0BCD@gmail.com> (message from dptd dptd on Sat, 28 Jan 2017 23:24:02 +0200) Subject: Re: bug#25565: mark-whole-buffer and unnecessary (point) call References: <50AC4AE1-C37B-4BD7-BBB1-8680E60DCB1F@gmail.com> <83vaszxart.fsf@gnu.org> <63A9E421-58EB-4E02-9F71-B250ADFB0BCD@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.2 (--------) X-Debbugs-Envelope-To: 25565 Cc: 25565@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.2 (--------) > From: dptd dptd > Date: Sat, 28 Jan 2017 23:24:02 +0200 > Cc: 25565@debbugs.gnu.org > > It looks really strange to copy-and-paste the same > explanation for each file / function. You shouldn't. The format is this: * file (func1, func2, func3): Change description. If you type "C-x 4 a" inside every function, Emacs will format the list for you, even if it's longer than a single line. Then write the description at the end. > Btw. why in my patch next to the ID is so strange date? Mon Sep 17 > 00:00:00 2001? I don't know. What did you do to produce the patch? From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 29 02:23:50 2017 Received: (at 25565) by debbugs.gnu.org; 29 Jan 2017 07:23:50 +0000 Received: from localhost ([127.0.0.1]:49630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXjq2-0007GY-3z for submit@debbugs.gnu.org; Sun, 29 Jan 2017 02:23:50 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXjq0-0007GL-Ps for 25565@debbugs.gnu.org; Sun, 29 Jan 2017 02:23:49 -0500 Received: by mail-wm0-f68.google.com with SMTP id c85so69072428wmi.1 for <25565@debbugs.gnu.org>; Sat, 28 Jan 2017 23:23:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=SqDGI3BaEkz7sprZ8a/UNAFcOx54lH7xI5GEiBEBhwc=; b=uesOlxxJwOje41Gffd4BnfjsKgCTQF3y4nZCFAVXo2prGYMRUk4SMWsDD0aVONOK8K +NUX0nqJaYOrjNIF+4KRuQmrNiTSoMBxcpKbN7uZbuKLlWYQVbH5nDJsweiyUmhDYWdk Ib1p+N+JcmbNo5e50U2btGOohL+I3FsE2dJ15j4pCuSOzlkUSkisK12DVuiPtv2arosx gSjeZH8mSVZZtOX3n+kGCF+q3PFLctkAQZ8jWOJ0x4Y7rzvwxK9HSB6mf7cmj/hEzIqx Oo45FFHAS8lQ+h18mbO2iNtfv9RIGgobBc0baaiVkHKOos7DzG6TaGNRswHQrsAh2Cud cNLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=SqDGI3BaEkz7sprZ8a/UNAFcOx54lH7xI5GEiBEBhwc=; b=CaddeCXO4Qp2izFoEpTIs5CzAMvd6h2Ai4qZnhUciHcwIJq/XLFAQj/DpYyzmoqLJl cgwHKMZW531Zk0WIgn4ZPyuei/3Uex9HhTiudHhFKiXG+ljjcX/ocFOAJjkzSE/o7isH mGt3UbzJNO6A+8ms8uWgY/w0QRqp1cfsFZgvQhs8ghjLu/tIw72/rQwdc/4BX8Lh331O yHsvt7WSDvpmyAB7KKyQU426/SoFVu75pDwThCLxjlNZwGO5VVkh7QmDkcwQtYXvdkmv ZpneHg4eeNyOkdegyq6ddsDfvsZ8j+gNbL1j6PRCqOV4c3JYNPZiVRv1s1YZFo4xTJgo tlRA== X-Gm-Message-State: AIkVDXJwGOjVilmqHPFJROreXgxZV0j+BAkoqLeo3LvdHGhrZQ7jm5qY4xhqx65d6wxdeA== X-Received: by 10.28.184.198 with SMTP id i189mr8660910wmf.26.1485674622985; Sat, 28 Jan 2017 23:23:42 -0800 (PST) Received: from [192.168.60.140] ([212.50.23.124]) by smtp.gmail.com with ESMTPSA id d29sm12401911wmi.19.2017.01.28.23.23.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Jan 2017 23:23:42 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: bug#25565: mark-whole-buffer and unnecessary (point) call From: dptd dptd In-Reply-To: <83mveay1mc.fsf@gnu.org> Date: Sun, 29 Jan 2017 09:23:40 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <5A090873-7DCF-4C1A-885D-1D86EC3E6ED4@gmail.com> References: <50AC4AE1-C37B-4BD7-BBB1-8680E60DCB1F@gmail.com> <83vaszxart.fsf@gnu.org> <63A9E421-58EB-4E02-9F71-B250ADFB0BCD@gmail.com> <83mveay1mc.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3259) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25565 Cc: 25565@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) > On 29 Jan 2017, at 05:40, Eli Zaretskii wrote: >=20 >> From: dptd dptd >> Date: Sat, 28 Jan 2017 23:24:02 +0200 >> Cc: 25565@debbugs.gnu.org >>=20 >> It looks really strange to copy-and-paste the same >> explanation for each file / function. >=20 > You shouldn't. The format is this: >=20 > * file (func1, func2, func3): Change description. So this is how it should looks like? For example: -------- * lisp/textmodes/bib-mode.el (mark-bib): Remove unnecessary call to the = (point) function from (push-mark). * lisp/simple.el (mark-whole-buffer, yank): Remove unnecessary call to = the (point) function from (push-mark). -------- etc.? >=20 > If you type "C-x 4 a" inside every function, Emacs will format the > list for you, even if it's longer than a single line. Then write the > description at the end. >=20 I didn=E2=80=99t knew about this command! It=E2=80=99s awesome - thank = you. However it isn=E2=80=99t breaking my lines when longer than 78 characters. :( I have tried from both - calling directly = from the function source code and from the magit=E2=80=99s staged changes. I have read on orgmode's page a bit more about working with ChangeLog = but couldn=E2=80=99t find the answer >> Btw. why in my patch next to the ID is so strange date? Mon Sep 17 >> 00:00:00 2001? >=20 > I don't know. What did you do to produce the patch? When on my feature branch: git format-patch master (same story for git = format-patch -1)= From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 29 05:42:08 2017 Received: (at 25565) by debbugs.gnu.org; 29 Jan 2017 10:42:08 +0000 Received: from localhost ([127.0.0.1]:49720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXmvv-0003Fv-SS for submit@debbugs.gnu.org; Sun, 29 Jan 2017 05:42:08 -0500 Received: from mout.gmx.net ([212.227.17.22]:60238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXmvt-0003FR-LA for 25565@debbugs.gnu.org; Sun, 29 Jan 2017 05:42:06 -0500 Received: from rosalinde ([62.214.238.165]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0M1SLt-1cDW7m17e5-00tVE8; Sun, 29 Jan 2017 11:41:55 +0100 From: Stephen Berman To: dptd dptd Subject: Re: bug#25565: mark-whole-buffer and unnecessary (point) call References: <50AC4AE1-C37B-4BD7-BBB1-8680E60DCB1F@gmail.com> <83vaszxart.fsf@gnu.org> <63A9E421-58EB-4E02-9F71-B250ADFB0BCD@gmail.com> <83mveay1mc.fsf@gnu.org> <5A090873-7DCF-4C1A-885D-1D86EC3E6ED4@gmail.com> Date: Sun, 29 Jan 2017 11:41:52 +0100 In-Reply-To: <5A090873-7DCF-4C1A-885D-1D86EC3E6ED4@gmail.com> (dptd dptd's message of "Sun, 29 Jan 2017 09:23:40 +0200") Message-ID: <87fuk26tcf.fsf@rosalinde> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:Y6xu0+BegYUJc+LRWl3F0B4nUyAWcHeEnT0WyImuI4Tdgy6mX0g WMVb96Cb2HJaP3UtH8LIZvoYkxmBCozATMe+LgszzVRC5qEhaJ4oyuINGRP4Y56eAhwtaX4 xG7Zn0xvwkCm78cmpY7xiL+yLfqDY/GNx4lRh2VgGdgnVzsFf1CwXw2ZdbgXhUwYZshMyBe vi7mM8CWlWZjtYuxFLJZg== X-UI-Out-Filterresults: notjunk:1;V01:K0:bWd5G5ZjdQc=:mJe+ZUEXSjbop8UrZmENjg gLrq+qfrgjikVbIhmPu2NuhbNp/PuZQ+wq4Bm6ivRX6HPgxD8KWd3Hd5Yn6vCPi5VJWJCPqsz u7RNYh6vqDIdehSusQZRdp9kbxLs7MUXg15KP7DsHoLc3iv+LFnG8S19wR+jjbQKURoFOlZPq 272/DQDTpSAn+Yeold427NCKTqA6mVoQOlLyZubQwQ1trHJElbAU/wcyNQ/z6bJUqzY6hzRp9 236lYTu29S6AfgX7fAY3jH393x8tEm9yYOfa46mAHaVMw1XwNaczREV8hcuHKIeToE8CVsJg2 cxrxWfZXT5guStwPBL2Ssp9KZlOZzWwOwHAW+VVdOO6Gwpqk0ZcuscTFpXrz+iSY1abPRc8dC rou5Xck4K9InpatT7IDjeB2HONMc5Xd3ymZmZoymJ9LBjzPZ1n0IUzcgkdUkfrI3IcJu3ujpZ 2gsIkIIwQU/AAcdW3/ojkGWJtMofQ98D4ij5t3DF9dCS8g06UOdOS+8hIMm7rsD5wUtF4h+ZC rzFSwgDt7lqZaf5r9nPFiMjMB+9nnVWFk4Y6mQV5aUzpFEVfRGKHl/XX/TqcqxJjz6+mu9Y60 CU0+z0tEzUmMtlvliYoHTHHo0IlhbJJhhoxTW8dEciCIS9s43KR9tbCG74xkzjzVA6MSVHTkc UJRXwDuLIi3qHd3pQfx6nZYtx88p67WI6ToXef91t5WK6jo4s+J/sBOAHM+mz0XC6TW0kV1zg x53oK+G05fl6fvUi2k+OjmEI+wUl5q1GuCo3bspCHl07feeMbV6fi86w9FPBZKWCvJe3hFIOW a6YC/ROEKQP6qfFJC04JlwihzWGoHbHo3jD9tFSReCEqMIqp8l6wyAIUOayaisPB+6Mgch+cN JKkd77WS7JSk3bj6KTTeNlaTc3XwMVl7Gi3fF20Ikhoz9luLhogPIc6D9RTvWBxumzHuPFKTj +NXthA0sUjk6BUGB+OJ6Th/Msdp3X/otU0e+oGU/7j6CnBt6NdsLnQtnCPxs8bfNp8CO+jOad lzOOkJbLFsvskmhZ8YEH6cvEFpucg/zS4iKG8U/M2ImOChHW8DLrwyEi75Z8nVzphg== X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: 25565 Cc: Eli Zaretskii , 25565@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) On Sun, 29 Jan 2017 09:23:40 +0200 dptd dptd wrote: >> On 29 Jan 2017, at 05:40, Eli Zaretskii wrote: >>=20 >>> From: dptd dptd >>> Date: Sat, 28 Jan 2017 23:24:02 +0200 >>> Cc: 25565@debbugs.gnu.org >>>=20 >>> It looks really strange to copy-and-paste the same >>> explanation for each file / function. >>=20 >> You shouldn't. The format is this: >>=20 >> * file (func1, func2, func3): Change description. > > So this is how it should looks like? For example: > -------- > * lisp/textmodes/bib-mode.el (mark-bib): Remove unnecessary call to the > (point) function from (push-mark). > > * lisp/simple.el (mark-whole-buffer, yank): Remove unnecessary call to the > (point) function from (push-mark). > -------- > etc.? The convention used here is to leave all entries that share a common ChangeLog description blank, except for the last one; see the example in the "** Commit messages" entry of the CONTRIBUTE file. So instead of the above, like this (with a slightly reworded description): * lisp/textmodes/bib-mode.el (mark-bib): * lisp/simple.el (mark-whole-buffer, yank): Remove unnecessary argument `(point)' from calls to `push-mark'. >>=20 >> If you type "C-x 4 a" inside every function, Emacs will format the >> list for you, even if it's longer than a single line. Then write the >> description at the end. >>=20 > > I didn=E2=80=99t knew about this command! It=E2=80=99s awesome - thank yo= u. However it isn=E2=80=99t > breaking my lines when > longer than 78 characters. :( I have tried from both - calling directly f= rom > the function source code > and from the magit=E2=80=99s staged changes. Do you have `fill-column' set somewhere? Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 29 08:27:32 2017 Received: (at 25565) by debbugs.gnu.org; 29 Jan 2017 13:27:32 +0000 Received: from localhost ([127.0.0.1]:49775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXpVz-0000SY-GI for submit@debbugs.gnu.org; Sun, 29 Jan 2017 08:27:32 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:37509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXpVy-0000SI-1R for 25565@debbugs.gnu.org; Sun, 29 Jan 2017 08:27:30 -0500 Received: by mail-wm0-f50.google.com with SMTP id v77so10965864wmv.0 for <25565@debbugs.gnu.org>; Sun, 29 Jan 2017 05:27:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=NLd5ODXV1DqQ0p8pZx3+mkOhEnLGhsF0VX0xK6bkTQw=; b=BKaJMWVPiswwRyu17pd4EP+0VAklxGKzFHedYHhRowSG4JGJ93T6HTmTkci1m54Xm6 aB4g/7RMOliVh1ZPFPhSQAZP96Kcf1TJI76m8rIFVctO/CmZau+e9Pu4Xud4+wcTaxn6 Iy5lIyj6uj7YmZIfGVnhkRRIID95336WgCxwqiVzveXzGrmxn1stPZppQK+LfmJAr5Ic a2982VRQPo7T+y+t7CSrwq9zGh2a4UB5HLPFJvmPw3aOxn1xckO119kJCXNO12bCJOEW h/eRnhywz6vM/gbruF8BdfGHDE5De8U2y3BR67lMen+dsX+Xqq4C+hpMX2MB4nPNd2/J Wm2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=NLd5ODXV1DqQ0p8pZx3+mkOhEnLGhsF0VX0xK6bkTQw=; b=LbNUjRr6WmjvZLsuKArjmR4J4c7ztd7QNmxX1SlEbuv+EKwhHGI0rfaUWdm9eHtJRU OZVrtGnDavtPqqxkcINWIR58s7HMl/59D0t53XReS1mZa6qEkQzaBrdh/YfvzpzEjNo5 9sgjIv1Gg2heFZSA9eyf6xc0T719ryRn2jegUw1Rp5h4Pnv5kVtb0w7KJNZkJdejvW+Y PIi0sx0DzWmgKXbJv7bT8CqWjCkRQc9V2Ff9rlDBbuEHjiSlgxhvHnR08ITW7U5ir0AM WrdUx44Ex38K5fo2Up7Y8JjqjhRiCg2WFT5GeSccntHbyBzI288Ac5HZslWL92tlKDZe 3TBQ== X-Gm-Message-State: AIkVDXLk3NkRvYidfKgSOSriUXfDwci04hOEyneqKjLJUrCdGl378loGWbZ0ML1lP9WCHg== X-Received: by 10.28.5.70 with SMTP id 67mr10024227wmf.32.1485696444156; Sun, 29 Jan 2017 05:27:24 -0800 (PST) Received: from [192.168.60.140] ([212.50.23.124]) by smtp.gmail.com with ESMTPSA id 17sm17739268wru.16.2017.01.29.05.27.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 29 Jan 2017 05:27:23 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: bug#25565: mark-whole-buffer and unnecessary (point) call From: dptd dptd In-Reply-To: <87fuk26tcf.fsf@rosalinde> Date: Sun, 29 Jan 2017 15:27:22 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <7AA23B8E-95A3-4BF4-AF53-AE1FD826D668@gmail.com> References: <50AC4AE1-C37B-4BD7-BBB1-8680E60DCB1F@gmail.com> <83vaszxart.fsf@gnu.org> <63A9E421-58EB-4E02-9F71-B250ADFB0BCD@gmail.com> <83mveay1mc.fsf@gnu.org> <5A090873-7DCF-4C1A-885D-1D86EC3E6ED4@gmail.com> <87fuk26tcf.fsf@rosalinde> To: Stephen Berman X-Mailer: Apple Mail (2.3259) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25565 Cc: Eli Zaretskii , 25565@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) > On 29 Jan 2017, at 12:41, Stephen Berman = wrote: >=20 > On Sun, 29 Jan 2017 09:23:40 +0200 dptd dptd = wrote: >=20 >>> On 29 Jan 2017, at 05:40, Eli Zaretskii wrote: >>>=20 >>>> From: dptd dptd >>>> Date: Sat, 28 Jan 2017 23:24:02 +0200 >>>> Cc: 25565@debbugs.gnu.org >>>>=20 >>>> It looks really strange to copy-and-paste the same >>>> explanation for each file / function. >>>=20 >>> You shouldn't. The format is this: >>>=20 >>> * file (func1, func2, func3): Change description. >>=20 >> So this is how it should looks like? For example: >> -------- >> * lisp/textmodes/bib-mode.el (mark-bib): Remove unnecessary call to = the >> (point) function from (push-mark). >>=20 >> * lisp/simple.el (mark-whole-buffer, yank): Remove unnecessary call = to the >> (point) function from (push-mark). >> -------- >> etc.? >=20 > The convention used here is to leave all entries that share a common > ChangeLog description blank, except for the last one; see the example = in > the "** Commit messages" entry of the CONTRIBUTE file. So instead of = the > above, like this (with a slightly reworded description): >=20 > * lisp/textmodes/bib-mode.el (mark-bib): > * lisp/simple.el (mark-whole-buffer, yank): Remove unnecessary = argument > `(point)' from calls to `push-mark'. Thank you Steve! :) >=20 >>>=20 >>> If you type "C-x 4 a" inside every function, Emacs will format the >>> list for you, even if it's longer than a single line. Then write = the >>> description at the end. >>>=20 >>=20 >> I didn=E2=80=99t knew about this command! It=E2=80=99s awesome - = thank you. However it isn=E2=80=99t >> breaking my lines when >> longer than 78 characters. :( I have tried from both - calling = directly from >> the function source code >> and from the magit=E2=80=99s staged changes. >=20 > Do you have `fill-column' set somewhere? >=20 > Steve Berman Actually yes, I do. C-v fill-column -------- fill-column is a variable defined in =E2=80=98C source code=E2=80=99. Its value is 70 Local in buffer ChangeLog; global value is the same. -------- Here is the newest patch. -------- =46rom c869759f7d7fddb8f8b9fbd9fa7360b1d17edf57 Mon Sep 17 00:00:00 2001 From: Bartosz Duszel Date: Sun, 29 Jan 2017 14:47:23 +0200 Subject: [PATCH] Remove unnecessary argument `(point)' from calls to `push-mark'. * lisp/textmodes/bib-mode.el (mark-bib): * lisp/simple.el (mark-whole-buffer, yank): * lisp/ses.el (ses--advice-yank, ses-mark-row, ses-mark-column): * lisp/progmodes/xscheme.el (xscheme-yank): * lisp/progmodes/verilog-mode.el (verilog-mark-defun): * lisp/progmodes/perl-mode.el (perl-mark-function): * lisp/progmodes/pascal.el (pascal-mark-defun): * lisp/progmodes/meta-mode.el (meta-mark-defun): * lisp/progmodes/icon.el (mark-icon-function): * lisp/progmodes/cc-cmds.el (c-mark-function): * lisp/obsolete/vip.el (ex-goto): * lisp/obsolete/vi.el (vi-put-before): * lisp/mouse.el (mouse-yank-primary): * lisp/menu-bar.el (menu-bar-select-yank): * lisp/mail/sendmail.el (mail-yank-original): * lisp/hexl.el (hexl-beginning-of-buffer, hexl-end-of-buffer): * lisp/emulation/viper-cmd.el (viper-mark-beginning-of-buffer): (viper-mark-end-of-buffer): * lisp/cedet/semantic/senator.el (senator-mark-defun): * lisp/allout.el (allout-mark-topic): Remove unnecessary argument `(point)' from calls to `push-mark'. --- lisp/allout.el | 2 +- lisp/cedet/semantic/senator.el | 2 +- lisp/emulation/viper-cmd.el | 4 ++-- lisp/hexl.el | 4 ++-- lisp/mail/sendmail.el | 2 +- lisp/menu-bar.el | 2 +- lisp/mouse.el | 2 +- lisp/obsolete/vi.el | 2 +- lisp/obsolete/vip.el | 2 +- lisp/progmodes/cc-cmds.el | 2 +- lisp/progmodes/icon.el | 4 ++-- lisp/progmodes/meta-mode.el | 2 +- lisp/progmodes/pascal.el | 4 ++-- lisp/progmodes/perl-mode.el | 4 ++-- lisp/progmodes/verilog-mode.el | 4 ++-- lisp/progmodes/xscheme.el | 2 +- lisp/ses.el | 6 +++--- lisp/simple.el | 4 ++-- lisp/textmodes/bib-mode.el | 2 +- 19 files changed, 28 insertions(+), 28 deletions(-) diff --git a/lisp/allout.el b/lisp/allout.el index 4a0aeeedf6..c6368cd54d 100644 --- a/lisp/allout.el +++ b/lisp/allout.el @@ -6504,7 +6504,7 @@ allout-mark-topic (let ((inhibit-field-text-motion t)) (beginning-of-line)) (allout-goto-prefix-doublechecked) - (push-mark (point)) + (push-mark) (allout-end-of-current-subtree) (exchange-point-and-mark)) ;;;_ : UI: diff --git a/lisp/cedet/semantic/senator.el = b/lisp/cedet/semantic/senator.el index 407bb05add..f1918c4091 100644 --- a/lisp/cedet/semantic/senator.el +++ b/lisp/cedet/semantic/senator.el @@ -659,7 +659,7 @@ senator-mark-defun (end (progn (senator-end-of-defun) (point))) (start (progn (senator-beginning-of-defun) (point)))) (goto-char origin) - (push-mark (point)) + (push-mark) (goto-char end) ;; end-of-defun (push-mark (point) nil t) (goto-char start) ;; beginning-of-defun diff --git a/lisp/emulation/viper-cmd.el b/lisp/emulation/viper-cmd.el index 86364282dc..e71bf0e37a 100644 --- a/lisp/emulation/viper-cmd.el +++ b/lisp/emulation/viper-cmd.el @@ -4346,7 +4346,7 @@ viper-query-replace (defun viper-mark-beginning-of-buffer () "Mark beginning of buffer." (interactive) - (push-mark (point)) + (push-mark) (goto-char (point-min)) (exchange-point-and-mark) (message "Mark set at the beginning of buffer")) @@ -4354,7 +4354,7 @@ viper-mark-beginning-of-buffer (defun viper-mark-end-of-buffer () "Mark end of buffer." (interactive) - (push-mark (point)) + (push-mark) (goto-char (point-max)) (exchange-point-and-mark) (message "Mark set at the end of buffer")) diff --git a/lisp/hexl.el b/lisp/hexl.el index b5e9c1ff33..0a598b22f6 100644 --- a/lisp/hexl.el +++ b/lisp/hexl.el @@ -730,13 +730,13 @@ hexl-beginning-of-buffer Leaves `hexl-mark' at previous position. With prefix arg N, puts point N bytes of the way from the true = beginning." (interactive "p") - (push-mark (point)) + (push-mark) (hexl-goto-address (+ 0 (1- arg)))) =20 (defun hexl-end-of-buffer (arg) "Go to `hexl-max-address' minus ARG." (interactive "p") - (push-mark (point)) + (push-mark) (hexl-goto-address (- hexl-max-address (1- arg)))) =20 (defun hexl-beginning-of-line () diff --git a/lisp/mail/sendmail.el b/lisp/mail/sendmail.el index 70c8ea1f93..4121cd773b 100644 --- a/lisp/mail/sendmail.el +++ b/lisp/mail/sendmail.el @@ -1676,7 +1676,7 @@ mail-yank-original ;; Call yank function, and set the mark if it doesn't. (apply (car original) (cdr original)) (if (eq omark (mark t)) - (push-mark (point)))) + (push-mark))) ;; If the original message is in another window in the same ;; frame, delete that window to save space. (delete-windows-on original t) diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index 28464f13df..c2733a5892 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -1971,7 +1971,7 @@ menu-bar-select-yank "Insert the stretch of previously-killed text selected from menu. The menu shows all the killed text sequences stored in `kill-ring'." (interactive "*") - (push-mark (point)) + (push-mark) (insert last-command-event)) =20 =0C diff --git a/lisp/mouse.el b/lisp/mouse.el index 0f1d446040..0520fd1ab9 100644 --- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -1135,7 +1135,7 @@ mouse-yank-primary (deactivate-mark))) (or mouse-yank-at-point (mouse-set-point click)) (let ((primary (gui-get-primary-selection))) - (push-mark (point)) + (push-mark) (insert-for-yank primary))) =20 (defun mouse-kill-ring-save (click) diff --git a/lisp/obsolete/vi.el b/lisp/obsolete/vi.el index 081b229ebc..5b611aa2d0 100644 --- a/lisp/obsolete/vi.el +++ b/lisp/obsolete/vi.el @@ -1128,7 +1128,7 @@ vi-put-before (progn (forward-line 1) (beginning-of-line)) (beginning-of-line)) (if after-p (forward-char 1))) - (push-mark (point)) + (push-mark) (insert put-text) (exchange-point-and-mark) ;; (back-to-indentation) ; this is not allowed if we allow = yank-pop diff --git a/lisp/obsolete/vip.el b/lisp/obsolete/vip.el index ca0bfe712c..4d70d6a5df 100644 --- a/lisp/obsolete/vip.el +++ b/lisp/obsolete/vip.el @@ -2596,7 +2596,7 @@ ex-goto "ex goto command" (if (null ex-addresses) (setq ex-addresses (cons (point) nil))) - (push-mark (point)) + (push-mark) (goto-char (car ex-addresses)) (beginning-of-line)) =20 diff --git a/lisp/progmodes/cc-cmds.el b/lisp/progmodes/cc-cmds.el index 561e6767e1..a5ddcb4b92 100644 --- a/lisp/progmodes/cc-cmds.el +++ b/lisp/progmodes/cc-cmds.el @@ -2041,7 +2041,7 @@ c-mark-function (push-mark-p (and (eq this-command 'c-mark-function) (not extend-region-p) (not (c-region-is-active-p))))) - (if push-mark-p (push-mark (point))) + (if push-mark-p (push-mark)) (if extend-region-p (progn (exchange-point-and-mark) diff --git a/lisp/progmodes/icon.el b/lisp/progmodes/icon.el index 0c699a00e8..92a89fef70 100644 --- a/lisp/progmodes/icon.el +++ b/lisp/progmodes/icon.el @@ -459,9 +459,9 @@ icon-backward-to-start-of-if (defun mark-icon-function () "Put mark at end of Icon function, point at beginning." (interactive) - (push-mark (point)) + (push-mark) (end-of-icon-defun) - (push-mark (point)) + (push-mark) (beginning-of-line 0) (beginning-of-icon-defun)) =20 diff --git a/lisp/progmodes/meta-mode.el b/lisp/progmodes/meta-mode.el index 3db3b8ad73..3377226388 100644 --- a/lisp/progmodes/meta-mode.el +++ b/lisp/progmodes/meta-mode.el @@ -780,7 +780,7 @@ meta-mark-defun "Put mark at end of the environment, point at the beginning. The environment marked is the one that contains point or follows = point." (interactive) - (push-mark (point)) + (push-mark) (meta-end-of-defun) (push-mark (point) nil t) (meta-beginning-of-defun)) diff --git a/lisp/progmodes/pascal.el b/lisp/progmodes/pascal.el index bf49ba4a36..a7d0624a74 100644 --- a/lisp/progmodes/pascal.el +++ b/lisp/progmodes/pascal.el @@ -507,9 +507,9 @@ pascal-mark-defun "Mark the current Pascal function (or procedure). This puts the mark at the end, and point at the beginning." (interactive) - (push-mark (point)) + (push-mark) (pascal-end-of-defun) - (push-mark (point)) + (push-mark) (pascal-beg-of-defun) (when (featurep 'xemacs) (zmacs-activate-region))) diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el index a516f07e72..1880bdd040 100644 --- a/lisp/progmodes/perl-mode.el +++ b/lisp/progmodes/perl-mode.el @@ -1102,9 +1102,9 @@ 'mark-perl-function (defun perl-mark-function () "Put mark at end of Perl function, point at beginning." (interactive) - (push-mark (point)) + (push-mark) (perl-end-of-function) - (push-mark (point)) + (push-mark) (perl-beginning-of-function) (backward-paragraph)) =20 diff --git a/lisp/progmodes/verilog-mode.el = b/lisp/progmodes/verilog-mode.el index 48ee55500f..9f3bad1c1a 100644 --- a/lisp/progmodes/verilog-mode.el +++ b/lisp/progmodes/verilog-mode.el @@ -4212,9 +4212,9 @@ verilog-mark-defun (interactive) (if (featurep 'xemacs) (progn - (push-mark (point)) + (push-mark) (verilog-end-of-defun) - (push-mark (point)) + (push-mark) (verilog-beg-of-defun) (if (fboundp 'zmacs-activate-region) (zmacs-activate-region))) diff --git a/lisp/progmodes/xscheme.el b/lisp/progmodes/xscheme.el index 4502c6d33f..bdfe30af50 100644 --- a/lisp/progmodes/xscheme.el +++ b/lisp/progmodes/xscheme.el @@ -580,7 +580,7 @@ xscheme-yank (xscheme-rotate-yank-pointer (if (listp arg) 0 (if (eq arg '-) -1 (1- arg)))) - (push-mark (point)) + (push-mark) (insert (car xscheme-expressions-ring-yank-pointer)) (if (consp arg) (exchange-point-and-mark))) diff --git a/lisp/ses.el b/lisp/ses.el index 76d4ca577d..f8fd17d0de 100644 --- a/lisp/ses.el +++ b/lisp/ses.el @@ -3023,7 +3023,7 @@ ses--advice-yank (eq (get-text-property (point) 'keymap) = 'ses-mode-print-map))) (apply yank-fun arg args) ; Normal non-SES yank. (ses-check-curcell 'end) - (push-mark (point)) + (push-mark) (let ((text (current-kill (cond ((listp arg) 0) ((eq arg '-) -1) @@ -3290,7 +3290,7 @@ ses-mark-row (interactive) (ses-check-curcell 'range) (let ((row (car (ses-sym-rowcol (or (car-safe ses--curcell) = ses--curcell))))) - (push-mark (point)) + (push-mark) (ses-goto-print (1+ row) 0) (push-mark (point) nil t) (ses-goto-print row 0))) @@ -3301,7 +3301,7 @@ ses-mark-column (ses-check-curcell 'range) (let ((col (cdr (ses-sym-rowcol (or (car-safe ses--curcell) = ses--curcell)))) (row 0)) - (push-mark (point)) + (push-mark) (ses-goto-print (1- ses--numrows) col) (forward-char 1) (push-mark (point) nil t) diff --git a/lisp/simple.el b/lisp/simple.el index bdc6abde1f..281d9766aa 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -1105,7 +1105,7 @@ mark-whole-buffer that uses or sets the mark." (declare (interactive-only t)) (interactive) - (push-mark (point)) + (push-mark) (push-mark (point-max) nil t) ;; This is really `point-min' in most cases, but if we're in the ;; minibuffer, this is at the end of the prompt. @@ -4858,7 +4858,7 @@ yank ;; If we don't get all the way thru, make last-command indicate that ;; for the following command. (setq this-command t) - (push-mark (point)) + (push-mark) (insert-for-yank (current-kill (cond ((listp arg) 0) ((eq arg '-) -2) diff --git a/lisp/textmodes/bib-mode.el b/lisp/textmodes/bib-mode.el index 74d214496e..2f3c17b3b2 100644 --- a/lisp/textmodes/bib-mode.el +++ b/lisp/textmodes/bib-mode.el @@ -181,7 +181,7 @@ mark-bib (re-search-backward "^ *$" nil 2) (re-search-forward "^%") (beginning-of-line nil) - (push-mark (point)) + (push-mark) (re-search-forward "^ *$" nil 2) (forward-line 1) (beginning-of-line nil)) --=20 2.11.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 29 10:26:06 2017 Received: (at 25565) by debbugs.gnu.org; 29 Jan 2017 15:26:06 +0000 Received: from localhost ([127.0.0.1]:50324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXrMk-0003EQ-70 for submit@debbugs.gnu.org; Sun, 29 Jan 2017 10:26:06 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXrMi-0003Dx-JM for 25565@debbugs.gnu.org; Sun, 29 Jan 2017 10:26:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXrMZ-0000jI-B6 for 25565@debbugs.gnu.org; Sun, 29 Jan 2017 10:25:59 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXrMZ-0000jE-7X; Sun, 29 Jan 2017 10:25:55 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3035 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cXrMY-0004pm-I8; Sun, 29 Jan 2017 10:25:55 -0500 Date: Sun, 29 Jan 2017 17:25:48 +0200 Message-Id: <83k29dyjk3.fsf@gnu.org> From: Eli Zaretskii To: dptd dptd In-reply-to: <5A090873-7DCF-4C1A-885D-1D86EC3E6ED4@gmail.com> (message from dptd dptd on Sun, 29 Jan 2017 09:23:40 +0200) Subject: Re: bug#25565: mark-whole-buffer and unnecessary (point) call References: <50AC4AE1-C37B-4BD7-BBB1-8680E60DCB1F@gmail.com> <83vaszxart.fsf@gnu.org> <63A9E421-58EB-4E02-9F71-B250ADFB0BCD@gmail.com> <83mveay1mc.fsf@gnu.org> <5A090873-7DCF-4C1A-885D-1D86EC3E6ED4@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.2 (--------) X-Debbugs-Envelope-To: 25565 Cc: 25565@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.2 (--------) > From: dptd dptd > Date: Sun, 29 Jan 2017 09:23:40 +0200 > Cc: 25565@debbugs.gnu.org > > >> Btw. why in my patch next to the ID is so strange date? Mon Sep 17 > >> 00:00:00 2001? > > > > I don't know. What did you do to produce the patch? > > When on my feature branch: git format-patch master (same story for git format-patch -1) It's the standard "magic from" string, see the man page of git format-patch. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 29 14:49:04 2017 Received: (at 25565) by debbugs.gnu.org; 29 Jan 2017 19:49:04 +0000 Received: from localhost ([127.0.0.1]:50429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXvTE-0005u3-7G for submit@debbugs.gnu.org; Sun, 29 Jan 2017 14:49:04 -0500 Received: from mout.gmx.net ([212.227.15.19]:59456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXvTC-0005tY-7F for 25565@debbugs.gnu.org; Sun, 29 Jan 2017 14:49:02 -0500 Received: from rosalinde ([62.214.238.165]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Mfn40-1cslk21mZY-00NCgo; Sun, 29 Jan 2017 20:48:54 +0100 From: Stephen Berman To: dptd dptd Subject: Re: bug#25565: mark-whole-buffer and unnecessary (point) call References: <50AC4AE1-C37B-4BD7-BBB1-8680E60DCB1F@gmail.com> <83vaszxart.fsf@gnu.org> <63A9E421-58EB-4E02-9F71-B250ADFB0BCD@gmail.com> <83mveay1mc.fsf@gnu.org> <5A090873-7DCF-4C1A-885D-1D86EC3E6ED4@gmail.com> <87fuk26tcf.fsf@rosalinde> <7AA23B8E-95A3-4BF4-AF53-AE1FD826D668@gmail.com> Date: Sun, 29 Jan 2017 20:48:52 +0100 In-Reply-To: <7AA23B8E-95A3-4BF4-AF53-AE1FD826D668@gmail.com> (dptd dptd's message of "Sun, 29 Jan 2017 15:27:22 +0200") Message-ID: <8760kx4pgb.fsf@rosalinde> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:0ExW4sOuh3XbC4kPj8TdoDJRMCxrgDUee7sE37EhiazWDyex8k1 SA+NLEpwOiLTG4StkdsUj9wnLfuIGf8uxme51MXbaQQ4ePmTNzNN83G2BOrEpFlGtTKMNVF yU8lTsoppR8UXJ4OZ9c7AmRKHk7JKGAyM1aSAMvkqSBSPiPrvWkg/4ZA33Pmf8HtAURfZsv 22cGpE1/BhXPbCZ4f+Dxg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Sa6SCqAjts0=:GR5HlHeKjWnYVgg0NM4Wz9 d9/4JMv+SzMCoD5H/wyMI3hLDK5oqsW51MChXKC0G3MS+UdJtZQZxmiiyqEwhKr/NT+6ZXsun /TiDQT3xRFCSwPSE+cfvBq6J4pcgjHIblmdksWz+U2NC8PxdFiQQOKbF9ygt66c8UsftwO2To dMc72I/Mdoa0tmxfp8XGpB8FtUB/pk1sT5MGvqPS00poQjfLe9Ua1GuSp0wxWFgrPh+B8w67J E0IG5wJb8CasdPa+bMFSbOgNT0voQ4dr75vR4LfedTpDBo3uFsZcLprtcaRY6CIdCoY57Nq1l VwzB/3qQ15ptPxQ5tbgrASHp4okcmTkjNKeUKz1sqxwCzEN8Zo6lSO+90oWaimlD94dGef5Ex uopNAtNbZ4H4Kn74LTifFpC7yAbZVMnUk+Tr+yrPHs464nUBD2WRo5iytH29UiuoX5WBfxgqU qiAePre4VBW28eNmOEGVcQDfOKPMQeJKtOyb4Ar5UDpfD3i9OfiNaEQxMjeMIHNjdHvEI+Jk6 IwFw0U5Qqghr/5D09lqC5B5fwAI9ZbrPDvUgjTUvA/HTGNcQHrVgOnZXb712KCFy9BvhhzcAY +lV5jiyOlsYIWWAOI4PpxCWyI6H1E8sYmaRq/n9xqA7yHi9fXdzRnXQPt4lGsixJMYOqGDnxV GDC0f1U/Nvmb26kNenmnpHyhX/XxI9lk/5h+B8Fq4Ttu542PRiuZP+b5OEggzUfR2kZoX19p5 C0gtPk5m8RCvP0bjyLIvdqknOaNQHdExwd4fnOBC9udp9zmIGQmN6a3LC1zlqQ1O2msGyxL6e AXMsEd3 X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: 25565 Cc: Eli Zaretskii , 25565@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) On Sun, 29 Jan 2017 15:27:22 +0200 dptd dptd wrote: >> On 29 Jan 2017, at 12:41, Stephen Berman wrote: >>=20 >> On Sun, 29 Jan 2017 09:23:40 +0200 dptd dptd wro= te: >>=20 >>>> On 29 Jan 2017, at 05:40, Eli Zaretskii wrote: [...] >>>> If you type "C-x 4 a" inside every function, Emacs will format the >>>> list for you, even if it's longer than a single line. Then write the >>>> description at the end. >>>>=20 >>>=20 >>> I didn=E2=80=99t knew about this command! It=E2=80=99s awesome - thank = you. However it isn=E2=80=99t >>> breaking my lines when >>> longer than 78 characters. :( I have tried from both - calling directly= from >>> the function source code >>> and from the magit=E2=80=99s staged changes. >>=20 >> Do you have `fill-column' set somewhere? >>=20 >> Steve Berman > > Actually yes, I do. > > C-v fill-column > -------- > fill-column is a variable defined in =E2=80=98C source code=E2=80=99. > Its value is 70 > Local in buffer ChangeLog; global value is the same. > -------- This is is the standard value in ChangeLog mode, so I don't know why you aren't getting line-breaking. You could check what happens when you start Emacs with -Q, and if it works there, that means something in your initializations, or a library you've loaded, is causing the problem. In that case, you can bisect your init file to find the culpable bit (i.e., comment out half of it, restart Emacs with the result, if the problem still occurs, comment out half of the uncommented part and repeat, otherwise reverse the commenting out and do the same). > Here is the newest patch. > -------- > From c869759f7d7fddb8f8b9fbd9fa7360b1d17edf57 Mon Sep 17 00:00:00 2001 > From: Bartosz Duszel > Date: Sun, 29 Jan 2017 14:47:23 +0200 > Subject: [PATCH] Remove unnecessary argument `(point)' from calls to > `push-mark'. > > * lisp/textmodes/bib-mode.el (mark-bib): > * lisp/simple.el (mark-whole-buffer, yank): > * lisp/ses.el (ses--advice-yank, ses-mark-row, ses-mark-column): > * lisp/progmodes/xscheme.el (xscheme-yank): > * lisp/progmodes/verilog-mode.el (verilog-mark-defun): > * lisp/progmodes/perl-mode.el (perl-mark-function): > * lisp/progmodes/pascal.el (pascal-mark-defun): > * lisp/progmodes/meta-mode.el (meta-mark-defun): > * lisp/progmodes/icon.el (mark-icon-function): > * lisp/progmodes/cc-cmds.el (c-mark-function): > * lisp/obsolete/vip.el (ex-goto): > * lisp/obsolete/vi.el (vi-put-before): > * lisp/mouse.el (mouse-yank-primary): > * lisp/menu-bar.el (menu-bar-select-yank): > * lisp/mail/sendmail.el (mail-yank-original): > * lisp/hexl.el (hexl-beginning-of-buffer, hexl-end-of-buffer): > * lisp/emulation/viper-cmd.el (viper-mark-beginning-of-buffer): > (viper-mark-end-of-buffer): There should be no colon `:' after `(viper-mark-beginning-of-buffer)', since `(viper-mark-end-of-buffer)' in the next line is in the same file. > * lisp/cedet/semantic/senator.el (senator-mark-defun): > * lisp/allout.el (allout-mark-topic): Remove unnecessary argument > `(point)' from calls to `push-mark'. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 29 15:46:12 2017 Received: (at 25565) by debbugs.gnu.org; 29 Jan 2017 20:46:12 +0000 Received: from localhost ([127.0.0.1]:50450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXwMW-0007C0-5c for submit@debbugs.gnu.org; Sun, 29 Jan 2017 15:46:12 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:37821) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXwMU-0007Bk-97 for 25565@debbugs.gnu.org; Sun, 29 Jan 2017 15:46:11 -0500 Received: by mail-wm0-f54.google.com with SMTP id v77so20975887wmv.0 for <25565@debbugs.gnu.org>; Sun, 29 Jan 2017 12:46:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=F5W+Qe0eOpC1F4NqElLBWGnDG7WGOmgv/W64JkutSBE=; b=BiLRX0J3g9nj4Gt89hk3WFrKrRyN9wcs/XT9nnwons3JdIIeXmQ2UZNVGaqOo9jigN 4/RHE9byznT3/ob3doLpBFrsmIVZXKmFlfslVZzRvplnMxE1tex9GIjUxV/UGwS0Nzq3 iV53MtwdGNCp151DUf1DiJOOuJgA61U3dOi1Uy+qOygrLdp1Z1SNxeg7uK0zmZLPijrv VyINID6M7bE3bGbL1bT2T7wGqk156hqSABRN1yIGmsiMrZsXOWCjwvIvm62coefgsKvB Sb94IIK9TJcbeMWomhZ+1gmWHsVy2sPrX968FooqmQIdp9/T7Y5fDmlHYuAk+fXPjZp8 +3hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=F5W+Qe0eOpC1F4NqElLBWGnDG7WGOmgv/W64JkutSBE=; b=oKlmLKctXrzaCk4FcMwHGtMm6rtbQsPNbWMwUBLC83BUjKr1V77Y9PRiNBTPowpZ9F NJxMC+GAVvBkKKnhgZcBzCJYsTiBxig7EeA/wQXf4tZXZI7DfQy0BJ9+4kE9Jot0hriN p1mF19Eq+JlPMx1vAdrqqKz7svZn5v8LL2uwZPRjgZowbMy+7ZxARsmTSElmhVMQm+BW KX8kbPKBWje7j8Xx8FfIvuyFzHCAvOsVB9CdHJzZYJPZrna8zKkmvuvN7068LfQAhe+U otK7uVxoDoex0W6dtyH9hSQMqXcRUaPPoNmjVadpEHEoTRB9HP/nel4WCo84Cqdfk2DX DHYQ== X-Gm-Message-State: AIkVDXKpEVSXWWcNS98aTlIwI10MEvuXj6gAESpjEn5z+gaBDY0KW3pM8Bkxf4kvKu/eAQ== X-Received: by 10.223.179.26 with SMTP id j26mr15475512wrd.126.1485722764344; Sun, 29 Jan 2017 12:46:04 -0800 (PST) Received: from [192.168.60.140] ([212.50.23.124]) by smtp.gmail.com with ESMTPSA id y97sm15372591wmh.24.2017.01.29.12.46.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 29 Jan 2017 12:46:03 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: bug#25565: mark-whole-buffer and unnecessary (point) call From: dptd dptd In-Reply-To: <8760kx4pgb.fsf@rosalinde> Date: Sun, 29 Jan 2017 22:46:02 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <447D8DEA-7B02-44F7-A693-597CE74B6FE4@gmail.com> References: <50AC4AE1-C37B-4BD7-BBB1-8680E60DCB1F@gmail.com> <83vaszxart.fsf@gnu.org> <63A9E421-58EB-4E02-9F71-B250ADFB0BCD@gmail.com> <83mveay1mc.fsf@gnu.org> <5A090873-7DCF-4C1A-885D-1D86EC3E6ED4@gmail.com> <87fuk26tcf.fsf@rosalinde> <7AA23B8E-95A3-4BF4-AF53-AE1FD826D668@gmail.com> <8760kx4pgb.fsf@rosalinde> To: Stephen Berman X-Mailer: Apple Mail (2.3259) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25565 Cc: Eli Zaretskii , 25565@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) > On 29 Jan 2017, at 21:48, Stephen Berman = wrote: >=20 > On Sun, 29 Jan 2017 15:27:22 +0200 dptd dptd = wrote: >=20 >>> On 29 Jan 2017, at 12:41, Stephen Berman = wrote: >>>=20 >>> On Sun, 29 Jan 2017 09:23:40 +0200 dptd dptd = wrote: >>>=20 >>>>> On 29 Jan 2017, at 05:40, Eli Zaretskii wrote: > [...] >>>>> If you type "C-x 4 a" inside every function, Emacs will format the >>>>> list for you, even if it's longer than a single line. Then write = the >>>>> description at the end. >>>>>=20 >>>>=20 >>>> I didn=E2=80=99t knew about this command! It=E2=80=99s awesome - = thank you. However it isn=E2=80=99t >>>> breaking my lines when >>>> longer than 78 characters. :( I have tried from both - calling = directly from >>>> the function source code >>>> and from the magit=E2=80=99s staged changes. >>>=20 >>> Do you have `fill-column' set somewhere? >>>=20 >>> Steve Berman >>=20 >> Actually yes, I do. >>=20 >> C-v fill-column >> -------- >> fill-column is a variable defined in =E2=80=98C source code=E2=80=99. >> Its value is 70 >> Local in buffer ChangeLog; global value is the same. >> -------- >=20 > This is is the standard value in ChangeLog mode, so I don't know why = you > aren't getting line-breaking. You could check what happens when you > start Emacs with -Q, and if it works there, that means something in = your > initializations, or a library you've loaded, is causing the problem. = In > that case, you can bisect your init file to find the culpable bit = (i.e., > comment out half of it, restart Emacs with the result, if the problem > still occurs, comment out half of the uncommented part and repeat, > otherwise reverse the commenting out and do the same). >=20 So basically do a binary-search on my init file. :D Will do, thanks. >> Here is the newest patch. >> -------- >> =46rom c869759f7d7fddb8f8b9fbd9fa7360b1d17edf57 Mon Sep 17 00:00:00 = 2001 >> From: Bartosz Duszel >> Date: Sun, 29 Jan 2017 14:47:23 +0200 >> Subject: [PATCH] Remove unnecessary argument `(point)' from calls to >> `push-mark'. >>=20 >> * lisp/textmodes/bib-mode.el (mark-bib): >> * lisp/simple.el (mark-whole-buffer, yank): >> * lisp/ses.el (ses--advice-yank, ses-mark-row, ses-mark-column): >> * lisp/progmodes/xscheme.el (xscheme-yank): >> * lisp/progmodes/verilog-mode.el (verilog-mark-defun): >> * lisp/progmodes/perl-mode.el (perl-mark-function): >> * lisp/progmodes/pascal.el (pascal-mark-defun): >> * lisp/progmodes/meta-mode.el (meta-mark-defun): >> * lisp/progmodes/icon.el (mark-icon-function): >> * lisp/progmodes/cc-cmds.el (c-mark-function): >> * lisp/obsolete/vip.el (ex-goto): >> * lisp/obsolete/vi.el (vi-put-before): >> * lisp/mouse.el (mouse-yank-primary): >> * lisp/menu-bar.el (menu-bar-select-yank): >> * lisp/mail/sendmail.el (mail-yank-original): >> * lisp/hexl.el (hexl-beginning-of-buffer, hexl-end-of-buffer): >> * lisp/emulation/viper-cmd.el (viper-mark-beginning-of-buffer): >> (viper-mark-end-of-buffer): >=20 > There should be no colon `:' after `(viper-mark-beginning-of-buffer)', > since `(viper-mark-end-of-buffer)' in the next line is in the same = file. >=20 >> * lisp/cedet/semantic/senator.el (senator-mark-defun): >> * lisp/allout.el (allout-mark-topic): Remove unnecessary argument >> `(point)' from calls to `push-mark'. >=20 > Steve Berman I want to contribute to the project but I cannot even prepare the patch = file correctly... dammit! -------- =46rom 5f044df2093844b24a692d3aceb846ced7b1b442 Mon Sep 17 00:00:00 2001 From: Bartosz Duszel Date: Sun, 29 Jan 2017 14:47:23 +0200 Subject: [PATCH] Remove unnecessary argument `(point)' from calls to `push-mark'. * lisp/textmodes/bib-mode.el (mark-bib): * lisp/simple.el (mark-whole-buffer, yank): * lisp/ses.el (ses--advice-yank, ses-mark-row, ses-mark-column): * lisp/progmodes/xscheme.el (xscheme-yank): * lisp/progmodes/verilog-mode.el (verilog-mark-defun): * lisp/progmodes/perl-mode.el (perl-mark-function): * lisp/progmodes/pascal.el (pascal-mark-defun): * lisp/progmodes/meta-mode.el (meta-mark-defun): * lisp/progmodes/icon.el (mark-icon-function): * lisp/progmodes/cc-cmds.el (c-mark-function): * lisp/obsolete/vip.el (ex-goto): * lisp/obsolete/vi.el (vi-put-before): * lisp/mouse.el (mouse-yank-primary): * lisp/menu-bar.el (menu-bar-select-yank): * lisp/mail/sendmail.el (mail-yank-original): * lisp/hexl.el (hexl-beginning-of-buffer, hexl-end-of-buffer): * lisp/emulation/viper-cmd.el (viper-mark-beginning-of-buffer) (viper-mark-end-of-buffer): * lisp/cedet/semantic/senator.el (senator-mark-defun): * lisp/allout.el (allout-mark-topic): Remove unnecessary argument `(point)' from calls to `push-mark'. --- lisp/allout.el | 2 +- lisp/cedet/semantic/senator.el | 2 +- lisp/emulation/viper-cmd.el | 4 ++-- lisp/hexl.el | 4 ++-- lisp/mail/sendmail.el | 2 +- lisp/menu-bar.el | 2 +- lisp/mouse.el | 2 +- lisp/obsolete/vi.el | 2 +- lisp/obsolete/vip.el | 2 +- lisp/progmodes/cc-cmds.el | 2 +- lisp/progmodes/icon.el | 4 ++-- lisp/progmodes/meta-mode.el | 2 +- lisp/progmodes/pascal.el | 4 ++-- lisp/progmodes/perl-mode.el | 4 ++-- lisp/progmodes/verilog-mode.el | 4 ++-- lisp/progmodes/xscheme.el | 2 +- lisp/ses.el | 6 +++--- lisp/simple.el | 4 ++-- lisp/textmodes/bib-mode.el | 2 +- 19 files changed, 28 insertions(+), 28 deletions(-) diff --git a/lisp/allout.el b/lisp/allout.el index 4a0aeeedf6..c6368cd54d 100644 --- a/lisp/allout.el +++ b/lisp/allout.el @@ -6504,7 +6504,7 @@ allout-mark-topic (let ((inhibit-field-text-motion t)) (beginning-of-line)) (allout-goto-prefix-doublechecked) - (push-mark (point)) + (push-mark) (allout-end-of-current-subtree) (exchange-point-and-mark)) ;;;_ : UI: diff --git a/lisp/cedet/semantic/senator.el = b/lisp/cedet/semantic/senator.el index 407bb05add..f1918c4091 100644 --- a/lisp/cedet/semantic/senator.el +++ b/lisp/cedet/semantic/senator.el @@ -659,7 +659,7 @@ senator-mark-defun (end (progn (senator-end-of-defun) (point))) (start (progn (senator-beginning-of-defun) (point)))) (goto-char origin) - (push-mark (point)) + (push-mark) (goto-char end) ;; end-of-defun (push-mark (point) nil t) (goto-char start) ;; beginning-of-defun diff --git a/lisp/emulation/viper-cmd.el b/lisp/emulation/viper-cmd.el index 86364282dc..e71bf0e37a 100644 --- a/lisp/emulation/viper-cmd.el +++ b/lisp/emulation/viper-cmd.el @@ -4346,7 +4346,7 @@ viper-query-replace (defun viper-mark-beginning-of-buffer () "Mark beginning of buffer." (interactive) - (push-mark (point)) + (push-mark) (goto-char (point-min)) (exchange-point-and-mark) (message "Mark set at the beginning of buffer")) @@ -4354,7 +4354,7 @@ viper-mark-beginning-of-buffer (defun viper-mark-end-of-buffer () "Mark end of buffer." (interactive) - (push-mark (point)) + (push-mark) (goto-char (point-max)) (exchange-point-and-mark) (message "Mark set at the end of buffer")) diff --git a/lisp/hexl.el b/lisp/hexl.el index b5e9c1ff33..0a598b22f6 100644 --- a/lisp/hexl.el +++ b/lisp/hexl.el @@ -730,13 +730,13 @@ hexl-beginning-of-buffer Leaves `hexl-mark' at previous position. With prefix arg N, puts point N bytes of the way from the true = beginning." (interactive "p") - (push-mark (point)) + (push-mark) (hexl-goto-address (+ 0 (1- arg)))) =20 (defun hexl-end-of-buffer (arg) "Go to `hexl-max-address' minus ARG." (interactive "p") - (push-mark (point)) + (push-mark) (hexl-goto-address (- hexl-max-address (1- arg)))) =20 (defun hexl-beginning-of-line () diff --git a/lisp/mail/sendmail.el b/lisp/mail/sendmail.el index 70c8ea1f93..4121cd773b 100644 --- a/lisp/mail/sendmail.el +++ b/lisp/mail/sendmail.el @@ -1676,7 +1676,7 @@ mail-yank-original ;; Call yank function, and set the mark if it doesn't. (apply (car original) (cdr original)) (if (eq omark (mark t)) - (push-mark (point)))) + (push-mark))) ;; If the original message is in another window in the same ;; frame, delete that window to save space. (delete-windows-on original t) diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index 28464f13df..c2733a5892 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -1971,7 +1971,7 @@ menu-bar-select-yank "Insert the stretch of previously-killed text selected from menu. The menu shows all the killed text sequences stored in `kill-ring'." (interactive "*") - (push-mark (point)) + (push-mark) (insert last-command-event)) =20 =0C diff --git a/lisp/mouse.el b/lisp/mouse.el index 0f1d446040..0520fd1ab9 100644 --- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -1135,7 +1135,7 @@ mouse-yank-primary (deactivate-mark))) (or mouse-yank-at-point (mouse-set-point click)) (let ((primary (gui-get-primary-selection))) - (push-mark (point)) + (push-mark) (insert-for-yank primary))) =20 (defun mouse-kill-ring-save (click) diff --git a/lisp/obsolete/vi.el b/lisp/obsolete/vi.el index 081b229ebc..5b611aa2d0 100644 --- a/lisp/obsolete/vi.el +++ b/lisp/obsolete/vi.el @@ -1128,7 +1128,7 @@ vi-put-before (progn (forward-line 1) (beginning-of-line)) (beginning-of-line)) (if after-p (forward-char 1))) - (push-mark (point)) + (push-mark) (insert put-text) (exchange-point-and-mark) ;; (back-to-indentation) ; this is not allowed if we allow = yank-pop diff --git a/lisp/obsolete/vip.el b/lisp/obsolete/vip.el index ca0bfe712c..4d70d6a5df 100644 --- a/lisp/obsolete/vip.el +++ b/lisp/obsolete/vip.el @@ -2596,7 +2596,7 @@ ex-goto "ex goto command" (if (null ex-addresses) (setq ex-addresses (cons (point) nil))) - (push-mark (point)) + (push-mark) (goto-char (car ex-addresses)) (beginning-of-line)) =20 diff --git a/lisp/progmodes/cc-cmds.el b/lisp/progmodes/cc-cmds.el index 561e6767e1..a5ddcb4b92 100644 --- a/lisp/progmodes/cc-cmds.el +++ b/lisp/progmodes/cc-cmds.el @@ -2041,7 +2041,7 @@ c-mark-function (push-mark-p (and (eq this-command 'c-mark-function) (not extend-region-p) (not (c-region-is-active-p))))) - (if push-mark-p (push-mark (point))) + (if push-mark-p (push-mark)) (if extend-region-p (progn (exchange-point-and-mark) diff --git a/lisp/progmodes/icon.el b/lisp/progmodes/icon.el index 0c699a00e8..92a89fef70 100644 --- a/lisp/progmodes/icon.el +++ b/lisp/progmodes/icon.el @@ -459,9 +459,9 @@ icon-backward-to-start-of-if (defun mark-icon-function () "Put mark at end of Icon function, point at beginning." (interactive) - (push-mark (point)) + (push-mark) (end-of-icon-defun) - (push-mark (point)) + (push-mark) (beginning-of-line 0) (beginning-of-icon-defun)) =20 diff --git a/lisp/progmodes/meta-mode.el b/lisp/progmodes/meta-mode.el index 3db3b8ad73..3377226388 100644 --- a/lisp/progmodes/meta-mode.el +++ b/lisp/progmodes/meta-mode.el @@ -780,7 +780,7 @@ meta-mark-defun "Put mark at end of the environment, point at the beginning. The environment marked is the one that contains point or follows = point." (interactive) - (push-mark (point)) + (push-mark) (meta-end-of-defun) (push-mark (point) nil t) (meta-beginning-of-defun)) diff --git a/lisp/progmodes/pascal.el b/lisp/progmodes/pascal.el index bf49ba4a36..a7d0624a74 100644 --- a/lisp/progmodes/pascal.el +++ b/lisp/progmodes/pascal.el @@ -507,9 +507,9 @@ pascal-mark-defun "Mark the current Pascal function (or procedure). This puts the mark at the end, and point at the beginning." (interactive) - (push-mark (point)) + (push-mark) (pascal-end-of-defun) - (push-mark (point)) + (push-mark) (pascal-beg-of-defun) (when (featurep 'xemacs) (zmacs-activate-region))) diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el index a516f07e72..1880bdd040 100644 --- a/lisp/progmodes/perl-mode.el +++ b/lisp/progmodes/perl-mode.el @@ -1102,9 +1102,9 @@ 'mark-perl-function (defun perl-mark-function () "Put mark at end of Perl function, point at beginning." (interactive) - (push-mark (point)) + (push-mark) (perl-end-of-function) - (push-mark (point)) + (push-mark) (perl-beginning-of-function) (backward-paragraph)) =20 diff --git a/lisp/progmodes/verilog-mode.el = b/lisp/progmodes/verilog-mode.el index 48ee55500f..9f3bad1c1a 100644 --- a/lisp/progmodes/verilog-mode.el +++ b/lisp/progmodes/verilog-mode.el @@ -4212,9 +4212,9 @@ verilog-mark-defun (interactive) (if (featurep 'xemacs) (progn - (push-mark (point)) + (push-mark) (verilog-end-of-defun) - (push-mark (point)) + (push-mark) (verilog-beg-of-defun) (if (fboundp 'zmacs-activate-region) (zmacs-activate-region))) diff --git a/lisp/progmodes/xscheme.el b/lisp/progmodes/xscheme.el index 4502c6d33f..bdfe30af50 100644 --- a/lisp/progmodes/xscheme.el +++ b/lisp/progmodes/xscheme.el @@ -580,7 +580,7 @@ xscheme-yank (xscheme-rotate-yank-pointer (if (listp arg) 0 (if (eq arg '-) -1 (1- arg)))) - (push-mark (point)) + (push-mark) (insert (car xscheme-expressions-ring-yank-pointer)) (if (consp arg) (exchange-point-and-mark))) diff --git a/lisp/ses.el b/lisp/ses.el index 76d4ca577d..f8fd17d0de 100644 --- a/lisp/ses.el +++ b/lisp/ses.el @@ -3023,7 +3023,7 @@ ses--advice-yank (eq (get-text-property (point) 'keymap) = 'ses-mode-print-map))) (apply yank-fun arg args) ; Normal non-SES yank. (ses-check-curcell 'end) - (push-mark (point)) + (push-mark) (let ((text (current-kill (cond ((listp arg) 0) ((eq arg '-) -1) @@ -3290,7 +3290,7 @@ ses-mark-row (interactive) (ses-check-curcell 'range) (let ((row (car (ses-sym-rowcol (or (car-safe ses--curcell) = ses--curcell))))) - (push-mark (point)) + (push-mark) (ses-goto-print (1+ row) 0) (push-mark (point) nil t) (ses-goto-print row 0))) @@ -3301,7 +3301,7 @@ ses-mark-column (ses-check-curcell 'range) (let ((col (cdr (ses-sym-rowcol (or (car-safe ses--curcell) = ses--curcell)))) (row 0)) - (push-mark (point)) + (push-mark) (ses-goto-print (1- ses--numrows) col) (forward-char 1) (push-mark (point) nil t) diff --git a/lisp/simple.el b/lisp/simple.el index bdc6abde1f..281d9766aa 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -1105,7 +1105,7 @@ mark-whole-buffer that uses or sets the mark." (declare (interactive-only t)) (interactive) - (push-mark (point)) + (push-mark) (push-mark (point-max) nil t) ;; This is really `point-min' in most cases, but if we're in the ;; minibuffer, this is at the end of the prompt. @@ -4858,7 +4858,7 @@ yank ;; If we don't get all the way thru, make last-command indicate that ;; for the following command. (setq this-command t) - (push-mark (point)) + (push-mark) (insert-for-yank (current-kill (cond ((listp arg) 0) ((eq arg '-) -2) diff --git a/lisp/textmodes/bib-mode.el b/lisp/textmodes/bib-mode.el index 74d214496e..2f3c17b3b2 100644 --- a/lisp/textmodes/bib-mode.el +++ b/lisp/textmodes/bib-mode.el @@ -181,7 +181,7 @@ mark-bib (re-search-backward "^ *$" nil 2) (re-search-forward "^%") (beginning-of-line nil) - (push-mark (point)) + (push-mark) (re-search-forward "^ *$" nil 2) (forward-line 1) (beginning-of-line nil)) --=20 2.11.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 29 16:29:33 2017 Received: (at 25565) by debbugs.gnu.org; 29 Jan 2017 21:29:33 +0000 Received: from localhost ([127.0.0.1]:50470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXx2S-00089O-Rp for submit@debbugs.gnu.org; Sun, 29 Jan 2017 16:29:33 -0500 Received: from mout.gmx.net ([212.227.15.18]:59257) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXx2N-000890-1H for 25565@debbugs.gnu.org; Sun, 29 Jan 2017 16:29:31 -0500 Received: from rosalinde ([62.214.238.165]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MIe0O-1cVk6t3LBY-002J9n; Sun, 29 Jan 2017 22:29:07 +0100 From: Stephen Berman To: dptd dptd Subject: Re: bug#25565: mark-whole-buffer and unnecessary (point) call References: <50AC4AE1-C37B-4BD7-BBB1-8680E60DCB1F@gmail.com> <83vaszxart.fsf@gnu.org> <63A9E421-58EB-4E02-9F71-B250ADFB0BCD@gmail.com> <83mveay1mc.fsf@gnu.org> <5A090873-7DCF-4C1A-885D-1D86EC3E6ED4@gmail.com> <87fuk26tcf.fsf@rosalinde> <7AA23B8E-95A3-4BF4-AF53-AE1FD826D668@gmail.com> <8760kx4pgb.fsf@rosalinde> <447D8DEA-7B02-44F7-A693-597CE74B6FE4@gmail.com> Date: Sun, 29 Jan 2017 22:29:06 +0100 In-Reply-To: <447D8DEA-7B02-44F7-A693-597CE74B6FE4@gmail.com> (dptd dptd's message of "Sun, 29 Jan 2017 22:46:02 +0200") Message-ID: <871svl4kt9.fsf@rosalinde> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:mK7He0UxC6KIBD7YJ+Bs7BLvQsmeLO//r3sbSHgR0QFXzY/zITX QwTUSnItlYdv1TSxWsnSJmSk5TOa8B3VQ2UQyJbtlFCH3RQ0B/q/uDW2ODdHSOHw4178rwD E0vFNfQzeuhoN2YnXu5IpcoD6LnNErjsZDft/9T7UGDzPylFaKWpaAdZe9JqgiT1cKlbQfA 35XIVGFcBOEEdZxqeqy5w== X-UI-Out-Filterresults: notjunk:1;V01:K0:GCGMe5neOLA=:XIsh5NYwMPrBVkjV070Mao BhaXWdNsSX/+L9QDfA8uOPcfp8z4cyAsqwqS3j+bY4Dc96oOInwmtCThpo/OMjTG2ABZWQB9l cI5xvCEyLQrxRvqtMTWVSrIttrpwn/YubvUrO2mC5qXmpU+t094bxigSeRsRooaFH5nZMMBgj 5cfEpuKMrZ4IrMy6QX6yNaOwL3uJS8OP7AA16CNTOH3RrStPh4Lr4Wqf91nRtS27OjR1inKKJ ihcGjGtiBJGkAYiZNveDeMz14l4xkQI/crzoWDUekwGsQ6JOVQWl34XQu5bnVgDttJJ9dNxY3 PL5xVI/oY1GmLhyFIsGwr9lkfsOUNXZ5gKwwME4mEdEi/tmn46LaOjl68XLaww1Gea9fffEOO hGkTP0O0ZM8Sf/w0SHe5Q3DC+4Bw0BjWTwfxGpG9BFCS5bFCNwAXPzzJa9oRsaCF6JdilZoyW jJrtdIFPnbslB6M5Ifby3WEk6UYVrxsOcjEEmEQCNMVykva0niCLY6MPkIhvq5DSg2wwVReZe u8ZTeGNnAu9dyi1z5q4XVQB7uTXrLSIRYJDPXJLqDisxcim0Ru6VgW5JA1P7Sq71PNUZVEVwY 9bhJS+4ozb9hfnmIA5aH2XppPFrW3Nm8IWVo6CwIJhiGe+OcRHGG/BLfpvE0qIxpsEwKr91BK 6IPPm5m4QWkHrW9PpSPb2FmUFWH6PElT7kEM5B0/0gGg2bHjsdJd6Xxb19FkOMCJgA8GhulJi ghQc6uCiS6ULbM1r0BY+c1GLoOfor9A3fbz2gpPCB2sJvAXp3BBAYbADuwj9DSsMLbd86vMb0 MZjhdaZ X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: 25565 Cc: Eli Zaretskii , 25565@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) On Sun, 29 Jan 2017 22:46:02 +0200 dptd dptd wrote: >>> Here is the newest patch. [...] >>> * lisp/emulation/viper-cmd.el (viper-mark-beginning-of-buffer): >>> (viper-mark-end-of-buffer): >> >> There should be no colon `:' after `(viper-mark-beginning-of-buffer)', >> since `(viper-mark-end-of-buffer)' in the next line is in the same file. >> >>> * lisp/cedet/semantic/senator.el (senator-mark-defun): >>> * lisp/allout.el (allout-mark-topic): Remove unnecessary argument >>> `(point)' from calls to `push-mark'. >> >> Steve Berman > > I want to contribute to the project but I cannot even prepare the > patch file correctly... dammit! If that's the worst problem you have as a contributor, Emacs will be very lucky indeed! ;-) Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 18 13:10:46 2017 Received: (at control) by debbugs.gnu.org; 18 Feb 2017 18:10:46 +0000 Received: from localhost ([127.0.0.1]:45357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf9T4-0004hm-8R for submit@debbugs.gnu.org; Sat, 18 Feb 2017 13:10:46 -0500 Received: from mail-io0-f176.google.com ([209.85.223.176]:34345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf9T2-0004ha-TN for control@debbugs.gnu.org; Sat, 18 Feb 2017 13:10:45 -0500 Received: by mail-io0-f176.google.com with SMTP id l66so9780733ioi.1 for ; Sat, 18 Feb 2017 10:10:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=2tQKMnPPbTbk3zR0sS026GvFDs8nF7RFBfzfNNIYVWc=; b=UJkLTHCDHi982+mBnRcRg7SQxM6lEuSZNN74ndV8Kahf+GmGfxJq7ZCBsO9kzdr1/0 H1E+AtNQbvd+bekGFEqFzXN3tDTqx74Nj3GopPmKsyruYVUB+Iw31qDhagw9zQKh5sgV WHdeJPUBrPQbhmR5kVsroTksedY8nKwcpPvpdDoqMqSNyM5e1Xo44iOV1fR13UV5ys61 HlHITBg7VluinYTKwCjVbvaf6hVhLagsgsbljElnLu15Xplf7DajDbz56c7rxpANJdXB 8CEMGhUReSvrZIPA24XYoKGsq1F35J/E4qjm5/nn3SKZLUlVFFbTiJ9B62Bo3GiBzkte r0Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=2tQKMnPPbTbk3zR0sS026GvFDs8nF7RFBfzfNNIYVWc=; b=hKnHpoD3BOEqEgyWfpGH/Ruid2YVRo6udNdWkwgGjeKO0P4QV2BrX3fcqKrux2CIVx 1fvf/FSp5XOAUbz2jpB0aniHHr1JctiSUtthgMoPxfkw2UZmeS2GAhFeR7iEylwpUF88 7BSl9skUo5X/eE7DtXGASV1S0kzQ4FcRu6sbZ/fS/lqYbtT4qlzeg6XAaq95LpYxPKkW 8syzGqg5s+AjaPpqkAa+uMhBGRK9wa92CafdaUdfN0UUBnN6cjK9Vv5L+cwNuwPjJkxF g05i1qWUJGzKyh8DESFdAoCN19PRcKCRke+D2Wt6/pmJLy66nmLQpZ+cLhYX3V5euqN9 SmPw== X-Gm-Message-State: AMke39k8K6duqLvtF9ZQZS9IAQNe5sXDUdNSL/7cupSnWY7zJvZSbfPf9al0MeU8Ws9aaw== X-Received: by 10.107.160.83 with SMTP id j80mr12487522ioe.58.1487441439332; Sat, 18 Feb 2017 10:10:39 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id k6sm6748068ioe.1.2017.02.18.10.10.38 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 18 Feb 2017 10:10:38 -0800 (PST) From: npostavs@users.sourceforge.net To: control@debbugs.gnu.org Subject: control message for bug #25565 Date: Sat, 18 Feb 2017 13:11:50 -0500 Message-ID: <87k28njrmh.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) # pending copyright assignment tags 25565 pending quit From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 24 02:23:26 2017 Received: (at 25565) by debbugs.gnu.org; 24 Mar 2017 06:23:26 +0000 Received: from localhost ([127.0.0.1]:41664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crIdC-00076h-9C for submit@debbugs.gnu.org; Fri, 24 Mar 2017 02:23:26 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:33825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crIdA-00076T-6i for 25565@debbugs.gnu.org; Fri, 24 Mar 2017 02:23:24 -0400 Received: by mail-lf0-f67.google.com with SMTP id y193so460393lfd.1 for <25565@debbugs.gnu.org>; Thu, 23 Mar 2017 23:23:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=bDtjUsnnLLLzyQQKjVzE3XJ02/cm90Y9cCHNhuyMpW4=; b=sP+SzR5RKbRHK3L9RzjkH5j/7Pl6AepjWFxm2Sij+4CX1xV5eK6+sWwPNSlORQSChg 6MaHbOHsgjLuddOLK+M7UFf0a2XboTLcUBNgqqJH2ssG44U9SCkM4yU88NL7VIxOVR0O gssAExF/pENi8krJ54CqkWAeNBu6QFiaGkbHS+ZrASisTIt69I+1i2WPxzIUbNYtZFpP wvWHWxtKN/Cc697iXSpn3FUYG1hJTpOMeODJQkHaMfQD9l9KuHxf8UdCmDZ0DLm4I6kl ilkABr/CCcdhRHWhPDKmrw2st1bVuunZvrGBkivbdzYBrENJby8OYCqvXeCZC/JNA3Uc 2ZLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=bDtjUsnnLLLzyQQKjVzE3XJ02/cm90Y9cCHNhuyMpW4=; b=lUWmMSunjEotJKdiyrAxoY7xWiz9GHBTvp99ryq5oZgRHSss+hGtHYYUkSklVBCQSC H7s6eH6xYRoG+4wyWvswKLJ49bMZEgR5XdxfyetZkUV0nn8hpun1Oc61K1kePqQX9DhD D99XMJR39yXS8RaLQrRt3W09FKkybzN7Iqs1bLiOk9NdbEEbO6dthksoUOZX0npbz2AO zh2EDQFlUuypxBjDEu5KUVelVhtUg3q4Zb+9cI9gIl3FjNfuJPriOuxJxIFkkBoSjLOo kb/RZZEua75+UWjpFA70rftSntox1SFSQ+ZOq1z5A/0MBxh0tLa2/ouoKyeyVygwPNuv r4wg== X-Gm-Message-State: AFeK/H33Zy7cI/vTA6wrWVYJLbAQxdFEj5NLIHuj52iB/K3BLreo8/jriCWmOUiwsaXfSA== X-Received: by 10.25.145.78 with SMTP id y14mr3056082lfj.18.1490336598292; Thu, 23 Mar 2017 23:23:18 -0700 (PDT) Received: from [192.168.0.8] (031011130184.dynamic-zab-05.vectranet.pl. [31.11.130.184]) by smtp.gmail.com with ESMTPSA id e91sm206677lji.40.2017.03.23.23.23.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Mar 2017 23:23:17 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: bug#25565: mark-whole-buffer and unnecessary (point) call From: dptd dptd In-Reply-To: <871svl4kt9.fsf@rosalinde> Date: Fri, 24 Mar 2017 07:23:19 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <50AC4AE1-C37B-4BD7-BBB1-8680E60DCB1F@gmail.com> <83vaszxart.fsf@gnu.org> <63A9E421-58EB-4E02-9F71-B250ADFB0BCD@gmail.com> <83mveay1mc.fsf@gnu.org> <5A090873-7DCF-4C1A-885D-1D86EC3E6ED4@gmail.com> <87fuk26tcf.fsf@rosalinde> <7AA23B8E-95A3-4BF4-AF53-AE1FD826D668@gmail.com> <8760kx4pgb.fsf@rosalinde> <447D8DEA-7B02-44F7-A693-597CE74B6FE4@gmail.com> <871svl4kt9.fsf@rosalinde> To: Stephen Berman X-Mailer: Apple Mail (2.3259) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25565 Cc: Eli Zaretskii , 25565@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) > On 29 Jan 2017, at 22:29, Stephen Berman = wrote: >=20 > On Sun, 29 Jan 2017 22:46:02 +0200 dptd dptd = wrote: >=20 >>>> Here is the newest patch. > [...] >>>> * lisp/emulation/viper-cmd.el (viper-mark-beginning-of-buffer): >>>> (viper-mark-end-of-buffer): >>>=20 >>> There should be no colon `:' after = `(viper-mark-beginning-of-buffer)', >>> since `(viper-mark-end-of-buffer)' in the next line is in the same = file. >>>=20 >>>> * lisp/cedet/semantic/senator.el (senator-mark-defun): >>>> * lisp/allout.el (allout-mark-topic): Remove unnecessary argument >>>> `(point)' from calls to `push-mark'. >>>=20 >>> Steve Berman >>=20 >> I want to contribute to the project but I cannot even prepare the >> patch file correctly... dammit! >=20 > If that's the worst problem you have as a contributor, Emacs will be > very lucky indeed! ;-) >=20 > Steve Berman Hello again, I think my paperwork with FSF is done now. What should I do not to make = sure that patch from the previous messages will be applied by someone? Best regards, B.D.= From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 24 03:24:03 2017 Received: (at 25565) by debbugs.gnu.org; 24 Mar 2017 07:24:03 +0000 Received: from localhost ([127.0.0.1]:41684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crJZr-00009F-0W for submit@debbugs.gnu.org; Fri, 24 Mar 2017 03:24:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crJZp-00008g-23 for 25565@debbugs.gnu.org; Fri, 24 Mar 2017 03:24:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1crJZf-0004hX-1f for 25565@debbugs.gnu.org; Fri, 24 Mar 2017 03:23:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48676) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crJZe-0004hQ-UV; Fri, 24 Mar 2017 03:23:50 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2986 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1crJZd-0000qR-7W; Fri, 24 Mar 2017 03:23:50 -0400 Date: Fri, 24 Mar 2017 09:23:41 +0200 Message-Id: <83d1d75e9u.fsf@gnu.org> From: Eli Zaretskii To: dptd dptd In-reply-to: (message from dptd dptd on Fri, 24 Mar 2017 07:23:19 +0100) Subject: Re: bug#25565: mark-whole-buffer and unnecessary (point) call References: <50AC4AE1-C37B-4BD7-BBB1-8680E60DCB1F@gmail.com> <83vaszxart.fsf@gnu.org> <63A9E421-58EB-4E02-9F71-B250ADFB0BCD@gmail.com> <83mveay1mc.fsf@gnu.org> <5A090873-7DCF-4C1A-885D-1D86EC3E6ED4@gmail.com> <87fuk26tcf.fsf@rosalinde> <7AA23B8E-95A3-4BF4-AF53-AE1FD826D668@gmail.com> <8760kx4pgb.fsf@rosalinde> <447D8DEA-7B02-44F7-A693-597CE74B6FE4@gmail.com> <871svl4kt9.fsf@rosalinde> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25565 Cc: stephen.berman@gmx.net, 25565@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: dptd dptd > Date: Fri, 24 Mar 2017 07:23:19 +0100 > Cc: Eli Zaretskii , > 25565@debbugs.gnu.org > > I think my paperwork with FSF is done now. What should I do not to make sure that patch from the previous messages will be applied by someone? Nothing, just wait for a week, and if it isn't applied yet, ping here. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 24 03:29:51 2017 Received: (at 25565) by debbugs.gnu.org; 24 Mar 2017 07:29:51 +0000 Received: from localhost ([127.0.0.1]:41692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crJfS-0000Is-Ut for submit@debbugs.gnu.org; Fri, 24 Mar 2017 03:29:51 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:35605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crJfR-0000Id-Bj for 25565@debbugs.gnu.org; Fri, 24 Mar 2017 03:29:49 -0400 Received: by mail-lf0-f66.google.com with SMTP id v2so589031lfi.2 for <25565@debbugs.gnu.org>; Fri, 24 Mar 2017 00:29:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=vybGGV67LeFWc77zjsWg8bsdxZQY8HUnlKzKRowqoXw=; b=mKTHuh2djuQvJEB87acP0DSP9C2wwjOVpetMvNx/W68rxAW1BfeivFmnYX34gDoKex xvD2icqNwPkyniCK7WVY8dVcxw9mbBfm+d6SLv96+c/5KxqTrDB9zDpMZjGE3ZHbdKmN KhcDSr5D4b5I3HHQ7JDIuoLYR+m58vZJN3fVigLq3KKNn9QWDTo4lEVBpm1UPfmgNj59 c7hOxhb74nTpqBw3qZkWeZPuh06f2s5plGbLVFbS0uSHMucgqKhZLdnIGkW4riu/Z70I BAxVuDkpxBC63P/QX0HymC5KY7jhhr+LusvDXTvvh6NvqWj4Z9W6U4kDPxN7bHzTNSiG 6UBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=vybGGV67LeFWc77zjsWg8bsdxZQY8HUnlKzKRowqoXw=; b=IhQuhhuQy2JPAJZWAdJewsV8/OXBVImjwjCT60nEgsRSjp1wlhazJtlaurWgZP8PSi TMjgWhyzra6sGpUFC3nl/J3aAHosz4L0o3CQ+IQyb7HN0C+ZJpcC07+rBxbUzuYB7cff 1BpvVfajzsBDBNeegB1Rj+Nl8FmyYdLu9vKmJeoiDG2Eey33QV4wLHJc8lI+uI9aYTEr sIogYKytqsuGO25eSBA0PsTyPiD1htpoMZWqvt388YdgCZBGhouziKLwk+GF2wCqE8xN 4YL8+zbSmdKeh7VH/ht9zftOpG2tTBk4FbtIB509nOh0GOWI/iGbvJCldCCaW264gpr6 O4Bw== X-Gm-Message-State: AFeK/H2V777ommK9sTqZ7VZ1Lg8Av8168pxDaTkirDDRV9k7Atzydo64e/7wgqG4u0yZIA== X-Received: by 10.25.18.95 with SMTP id h92mr3126801lfi.63.1490340583452; Fri, 24 Mar 2017 00:29:43 -0700 (PDT) Received: from [192.168.0.8] (031011130184.dynamic-zab-05.vectranet.pl. [31.11.130.184]) by smtp.gmail.com with ESMTPSA id w68sm213201lff.15.2017.03.24.00.29.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Mar 2017 00:29:42 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: bug#25565: mark-whole-buffer and unnecessary (point) call From: dptd dptd In-Reply-To: <83d1d75e9u.fsf@gnu.org> Date: Fri, 24 Mar 2017 08:29:44 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <714400D8-F342-42E9-BDD6-C3FB3696F57D@gmail.com> References: <50AC4AE1-C37B-4BD7-BBB1-8680E60DCB1F@gmail.com> <83vaszxart.fsf@gnu.org> <63A9E421-58EB-4E02-9F71-B250ADFB0BCD@gmail.com> <83mveay1mc.fsf@gnu.org> <5A090873-7DCF-4C1A-885D-1D86EC3E6ED4@gmail.com> <87fuk26tcf.fsf@rosalinde> <7AA23B8E-95A3-4BF4-AF53-AE1FD826D668@gmail.com> <8760kx4pgb.fsf@rosalinde> <447D8DEA-7B02-44F7-A693-597CE74B6FE4@gmail.com> <871svl4kt9.fsf@rosalinde> <83d1d75e9u.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3259) X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 25565 Cc: stephen.berman@gmx.net, 25565@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > On 24 Mar 2017, at 08:23, Eli Zaretskii wrote: >=20 >> From: dptd dptd >> Date: Fri, 24 Mar 2017 07:23:19 +0100 >> Cc: Eli Zaretskii , >> 25565@debbugs.gnu.org >>=20 >> I think my paperwork with FSF is done now. What should I do not to = make sure that patch from the previous messages will be applied by = someone? >=20 > Nothing, just wait for a week, and if it isn't applied yet, ping here. >=20 > Thanks. Okay, great. I will bump this thread if needed after a week. Thanks!= From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 28 04:28:56 2017 Received: (at 25565-done) by debbugs.gnu.org; 28 Apr 2017 08:28:56 +0000 Received: from localhost ([127.0.0.1]:43562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d41Gq-0004eA-9I for submit@debbugs.gnu.org; Fri, 28 Apr 2017 04:28:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d41Gp-0004du-7V for 25565-done@debbugs.gnu.org; Fri, 28 Apr 2017 04:28:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d41Gg-00023c-Ga for 25565-done@debbugs.gnu.org; Fri, 28 Apr 2017 04:28:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d41Gg-00023W-Cm; Fri, 28 Apr 2017 04:28:46 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2662 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d41Gf-0004Un-HJ; Fri, 28 Apr 2017 04:28:46 -0400 Date: Fri, 28 Apr 2017 11:28:10 +0300 Message-Id: <83shktlyw5.fsf@gnu.org> From: Eli Zaretskii To: dptd dptd In-reply-to: <447D8DEA-7B02-44F7-A693-597CE74B6FE4@gmail.com> (message from dptd dptd on Sun, 29 Jan 2017 22:46:02 +0200) Subject: Re: bug#25565: mark-whole-buffer and unnecessary (point) call References: <50AC4AE1-C37B-4BD7-BBB1-8680E60DCB1F@gmail.com> <83vaszxart.fsf@gnu.org> <63A9E421-58EB-4E02-9F71-B250ADFB0BCD@gmail.com> <83mveay1mc.fsf@gnu.org> <5A090873-7DCF-4C1A-885D-1D86EC3E6ED4@gmail.com> <87fuk26tcf.fsf@rosalinde> <7AA23B8E-95A3-4BF4-AF53-AE1FD826D668@gmail.com> <8760kx4pgb.fsf@rosalinde> <447D8DEA-7B02-44F7-A693-597CE74B6FE4@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25565-done Cc: stephen.berman@gmx.net, 25565-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: dptd dptd > Date: Sun, 29 Jan 2017 22:46:02 +0200 > Cc: Eli Zaretskii , 25565@debbugs.gnu.org > > > There should be no colon `:' after `(viper-mark-beginning-of-buffer)', > > since `(viper-mark-end-of-buffer)' in the next line is in the same file. > > > >> * lisp/cedet/semantic/senator.el (senator-mark-defun): > >> * lisp/allout.el (allout-mark-topic): Remove unnecessary argument > >> `(point)' from calls to `push-mark'. > > > > Steve Berman > > I want to contribute to the project but I cannot even prepare the patch file correctly... dammit! > -------- > From 5f044df2093844b24a692d3aceb846ced7b1b442 Mon Sep 17 00:00:00 2001 > From: Bartosz Duszel > Date: Sun, 29 Jan 2017 14:47:23 +0200 > Subject: [PATCH] Remove unnecessary argument `(point)' from calls to > `push-mark'. > > * lisp/textmodes/bib-mode.el (mark-bib): > * lisp/simple.el (mark-whole-buffer, yank): > * lisp/ses.el (ses--advice-yank, ses-mark-row, ses-mark-column): > * lisp/progmodes/xscheme.el (xscheme-yank): > * lisp/progmodes/verilog-mode.el (verilog-mark-defun): > * lisp/progmodes/perl-mode.el (perl-mark-function): > * lisp/progmodes/pascal.el (pascal-mark-defun): > * lisp/progmodes/meta-mode.el (meta-mark-defun): > * lisp/progmodes/icon.el (mark-icon-function): > * lisp/progmodes/cc-cmds.el (c-mark-function): > * lisp/obsolete/vip.el (ex-goto): > * lisp/obsolete/vi.el (vi-put-before): > * lisp/mouse.el (mouse-yank-primary): > * lisp/menu-bar.el (menu-bar-select-yank): > * lisp/mail/sendmail.el (mail-yank-original): > * lisp/hexl.el (hexl-beginning-of-buffer, hexl-end-of-buffer): > * lisp/emulation/viper-cmd.el (viper-mark-beginning-of-buffer) > (viper-mark-end-of-buffer): > * lisp/cedet/semantic/senator.el (senator-mark-defun): > * lisp/allout.el (allout-mark-topic): Remove unnecessary argument > `(point)' from calls to `push-mark'. I've now pushed this in your name to the master branc h, and I'm marking this bug done. Thanks for working on this and for persevering. From unknown Tue Jun 17 20:15:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 26 May 2017 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator