GNU bug report logs - #25563
11.90; Many predicates in TeX-view-predicate-list-builtin don't work.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25563 in the body.
You can then email your comments to 25563 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ikumi Keita <ikumi <at> ikumi.que.jp>
To: bug-auctex <at> gnu.org
Subject: 11.90; Many predicates in TeX-view-predicate-list-builtin don't work.
Date: Sun, 29 Jan 2017 00:57:14 +0900

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.

Be sure to consult the FAQ section in the manual before submitting
a bug report.  In addition check if the bug is reproducable with an
up-to-date version of AUCTeX.  So please upgrade to the version
available from http://www.gnu.org/software/auctex/ if your
installation is older than the one available from the web site.

If the bug is triggered by a specific (La)TeX file, you should try
to produce a minimal sample file showing the problem and include it
in your report.

Your report will be posted for the auctex package at the GNU bug
tracker.  Visit http://debbugs.gnu.org/cgi/pkgreport.cgi?pkg=auctex
to browse existing AUCTeX bugs.
------------------------------------------------------------------------

Most paper size related predicates in TeX-view-predicate-list-builtin
like paper-a5 are ineffective now.

How to confirm:
0. Start an emacs sesseion on X window.  Make sure that xdvi is
   available on your system.
1. Open the following file with AUCTeX.
----------------------------------------------------------------------
\documentclass[a5paper]{article}

\begin{document}
dummy text
\end{document}

%%% Local Variables:
%%% mode: latex
%%% TeX-master: t
%%% TeX-PDF-mode: nil
%%% End:
----------------------------------------------------------------------
2. Type C-c C-c RET.  The document is typeset and dvi file is produced.
3. Type C-c C-c RET.  AUCTeX suggests "xdvi FILENAME.dvi" for the
   default View command.  I expect that the option " -paper a5" is
   present in the suggested command according to the entry
      ("xdvi" ("%(o?)xdvi"
	       (mode-io-correlate " -sourceposition \"%n %b\" -editor \"%cS\"")
	       ((paper-a4 paper-portrait) " -paper a4")
	       ((paper-a4 paper-landscape) " -paper a4r")
	       ((paper-a5 paper-portrait) " -paper a5")
	       ((paper-a5 paper-landscape) " -paper a5r")
	       (paper-b5 " -paper b5")
	       (paper-letter " -paper us")
	       (paper-legal " -paper legal")
	       (paper-executive " -paper 7.25x10.5in")
	       " %d") "%(o?)xdvi")
   in TeX-view-program-list-builtin.  However that is missing.

The reason for this is that the current AUCTeX does not append the
documentclass options to the active styles of the document.  In the days
that the predicates did function, the options were present in the output
of `(TeX-style-list)'.  However, evaluating `(TeX-style-list)' in the
buffer of the example above yields just
("art10" "article" "latex2e" "FILENAME" "LATEX")
, which lacks "a5paper".  Thus the predicate
----------------------------------------------------------------------
    (paper-a5
     (TeX-match-style "\\`a5paper\\|a5comb\\'"))
----------------------------------------------------------------------
in TeX-view-predicate-list-builtin returns negative result.  I suppose
that the other predicates related to paper size in
TeX-view-predicate-list-builtin do not function anymore, too.

Skimming briefly over the commit log, this discrepancy seems to be
introduced by the following commit (sorry for the mercurial log format):
changeset:   6026:170a0f97c120
user:        Mosè Giordano <giordano.mose <at> libero.it>
date:        Thu Apr 04 15:17:23 2013 +0200
summary:     Better management of package options.
Before this commit, the function LaTeX-auto-cleanup has the following
lines:
----------------------------------------------------------------------
        ;; Append them to the style list.
        (dolist (elt options)
          (add-to-list 'TeX-auto-file elt t))
----------------------------------------------------------------------
I suppose these lines appended all the options of documentclass to the
active style list, but they were lost in the current LaTeX-auto-cleanup.

Emacs  : GNU Emacs 25.1.1 (x86_64-unknown-freebsd11.0, GTK+ Version 3.18.8)
 of 2016-10-14
Package: 11.90

current state:
==============
(setq
 AUCTeX-date "2017-01-10"
 window-system 'x
 LaTeX-version "2e"
 TeX-style-path '("/usr/local/var/auctex"
		  "/usr/local/share/emacs/site-lisp/auctex/style"
		  "/home/keita/.emacs.d/auctex/auto"
		  "/home/keita/.emacs.d/auctex/style" "auto" "style")
 TeX-auto-save nil
 TeX-parse-self t
 TeX-master t
 TeX-command-list '(("TeX"
		     "%(PDF)%(tex) %(file-line-error) %(extraopts) %`%S%(PDFout)%(mode)%' %t"
		     TeX-run-TeX nil
		     (plain-tex-mode ams-tex-mode texinfo-mode) :help
		     "Run plain TeX")
		    ("LaTeX" "%`%l%(mode)%' %t" TeX-run-TeX nil
		     (latex-mode doctex-mode) :help "Run LaTeX")
		    ("Makeinfo" "makeinfo %(extraopts) %t" TeX-run-compile nil
		     (texinfo-mode) :help "Run Makeinfo with Info output")
		    ("Makeinfo HTML" "makeinfo %(extraopts) --html %t"
		     TeX-run-compile nil (texinfo-mode) :help
		     "Run Makeinfo with HTML output")
		    ("AmSTeX" "amstex %(PDFout) %(extraopts) %`%S%(mode)%' %t"
		     TeX-run-TeX nil (ams-tex-mode) :help "Run AMSTeX")
		    ("ConTeXt"
		     "%(cntxcom) --once --texutil %(extraopts) %(execopts)%t"
		     TeX-run-TeX nil (context-mode) :help "Run ConTeXt once")
		    ("ConTeXt Full" "%(cntxcom) %(extraopts) %(execopts)%t"
		     TeX-run-TeX nil (context-mode) :help
		     "Run ConTeXt until completion")
		    ("BibTeX" "bibtex %s" TeX-run-BibTeX nil t :help
		     "Run BibTeX")
		    ("Biber" "biber %s" TeX-run-Biber nil t :help "Run Biber")
		    ("View" "%V" TeX-run-discard-or-function t t :help
		     "Run Viewer")
		    ("Print" "%p" TeX-run-command t t :help "Print the file")
		    ("Queue" "%q" TeX-run-background nil t :help
		     "View the printer queue" :visible TeX-queue-command)
		    ("File" "%(o?)dvips %d -o %f " TeX-run-dvips t t :help
		     "Generate PostScript file")
		    ("Dvips" "%(o?)dvips %d -o %f " TeX-run-dvips nil t :help
		     "Convert DVI file to PostScript")
		    ("Dvipdfmx" "dvipdfmx %d" TeX-run-dvipdfmx nil t :help
		     "Convert DVI file to PDF with dvipdfmx")
		    ("Ps2pdf" "ps2pdf %f" TeX-run-ps2pdf nil t :help
		     "Convert PostScript file to PDF")
		    ("Index" "makeindex %s" TeX-run-index nil t :help
		     "Run makeindex to create index file")
		    ("Xindy" "texindy %s" TeX-run-command nil t :help
		     "Run xindy to create index file")
		    ("Check" "lacheck %s" TeX-run-compile nil (latex-mode)
		     :help "Check LaTeX file for correctness")
		    ("ChkTeX" "chktex -v6 %s" TeX-run-compile nil (latex-mode)
		     :help "Check LaTeX file for common mistakes")
		    ("Spell" "(TeX-ispell-document \"\")" TeX-run-function nil
		     t :help "Spell-check the document")
		    ("Clean" "TeX-clean" TeX-run-function nil t :help
		     "Delete generated intermediate files")
		    ("Clean All" "(TeX-clean t)" TeX-run-function nil t :help
		     "Delete generated intermediate and output files")
		    ("Other" "" TeX-run-command t t :help
		     "Run an arbitrary command")
		    )
 )

Message #8 received at 25563 <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Ikumi Keita <ikumi <at> ikumi.que.jp>
Cc: 25563 <at> debbugs.gnu.org
Subject: Re: bug#25563: 11.90;
 Many predicates in TeX-view-predicate-list-builtin don't work.
Date: Thu, 02 Feb 2017 06:52:47 +0100

Ikumi Keita <ikumi <at> ikumi.que.jp> writes:

Hi Ikumi,

> The reason for this is that the current AUCTeX does not append the
> documentclass options to the active styles of the document.  In the days
> that the predicates did function, the options were present in the output
> of `(TeX-style-list)'.  However, evaluating `(TeX-style-list)' in the
> buffer of the example above yields just
> ("art10" "article" "latex2e" "FILENAME" "LATEX")
> , which lacks "a5paper".  Thus the predicate
> ----------------------------------------------------------------------
>     (paper-a5
>      (TeX-match-style "\\`a5paper\\|a5comb\\'"))
> ----------------------------------------------------------------------
> in TeX-view-predicate-list-builtin returns negative result.  I suppose
> that the other predicates related to paper size in
> TeX-view-predicate-list-builtin do not function anymore, too.

Oh, good catch.  We've rewritten that a bit so that `TeX-style-list' is
just that, the list of styles.  In addition to that, there are now

,----[ C-h v LaTeX-provided-class-options RET ]
| LaTeX-provided-class-options is a variable defined in ‘latex.el’.
| Its value is nil
| 
|   Automatically becomes buffer-local when set.
| 
| Documentation:
| Alist of options provided to LaTeX classes.
| For each element, the CAR is the name of the class, the CDR is
| the list of options provided to it.
| 
| E.g., its value will be
|   (("book" "a4paper" "11pt" "openany" "fleqn")
|    ...)
| See also ‘LaTeX-provided-package-options’.
`----

(and that one needs to be checked now) and

,----[ C-h v LaTeX-provided-package-options RET ]
| LaTeX-provided-package-options is a variable defined in ‘latex.el’.
| Its value is nil
| 
|   Automatically becomes buffer-local when set.
| 
| Documentation:
| Alist of options provided to LaTeX packages.
| For each element, the CAR is the name of the package, the CDR is
| the list of options provided to it.
| 
| E.g., its value will be
|   (("babel" "german")
|    ("geometry" "a4paper" "top=2cm" "bottom=2cm" "left=2.5cm" "right=2.5cm")
|    ...)
| See also ‘LaTeX-provided-class-options’.
`----

I'll see if I can fix it.  And "landscape" is another document class
option which is broken right now.

Thanks for the report!

Bye,
Tassilo

Message #11 received at 25563 <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Ikumi Keita <ikumi <at> ikumi.que.jp>
Cc: 25563 <at> debbugs.gnu.org
Subject: Re: bug#25563: 11.90;
 Many predicates in TeX-view-predicate-list-builtin don't work.
Date: Thu, 02 Feb 2017 07:38:47 +0100

Tassilo Horn <tsdh <at> gnu.org> writes:

Hi Ikumi,

> I'll see if I can fix it.  And "landscape" is another document class
> option which is broken right now.

I think I've fixed this in commit
c0f3659059a138aaf5fa610f2913035d63225bfb.  For paper-a4 and paper-a5 I
wasn't quite sure if at least some of the regexes there could also be
styles/packages so there I check both styles and documentclass options.
If you know better than me, feel free to make that more specific.

Please report back if it works again.

Bye,
Tassilo

Message #14 received at 25563 <at> debbugs.gnu.org (full text, mbox):

From: Ikumi Keita <ikumi <at> ikumi.que.jp>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: 25563 <at> debbugs.gnu.org
Subject: Re: bug#25563: 11.90;
 Many predicates in TeX-view-predicate-list-builtin don't work.
Date: Thu, 02 Feb 2017 22:58:23 +0900

Hi Tassilo,

> I think I've fixed this in commit
> c0f3659059a138aaf5fa610f2913035d63225bfb.

Thanks, the problem is fixed now.

> For paper-a4 and paper-a5 I wasn't quite sure if at least some of the
> regexes there could also be styles/packages so there I check both
> styles and documentclass options.  If you know better than me, feel
> free to make that more specific.

Sorry, I am not familiar about that issue either.

And just some minor comments about the code related to the problem.

1. Isn't the the regexp \`a5paper\|a5comb\' for paper-a5 really intended
   as \`\(?:a5paper\|a5comb\)\' ?  Similar question goes to the regexp
   for paper-a4, too.
2. `LaTeX-auto-cleanup' treats "package" and "Package" equally at the
   part
        (if (or (string-equal "package" class)
                (string-equal "Package" class))
   .  Thus the later part
	(cond (equal class "class")
	      (add-to-list 'TeX-auto-file "latex2e"))
   shuold also treat "class" and "Class" equally, shouldn't it?  The
   variable `LaTeX-auto-class-regexp-list' contains lines
    ;; \LoadClass[<options>]{<package>}[<date>]
    ("\\\\Load\\(Class\\)\\(\\[\\([^#\\.%]*?\\)\\]\\)?{\\([^#\\.\n\r]+?\\)}"
     (3 4 1) LaTeX-auto-style)
    ;; \LoadClassWithOptions{<package>}[<date>]
    ("\\\\Load\\(Class\\)WithOptions\\(\\){\\([^#\\.\n\r]+?\\)}"
     (2 3 1) LaTeX-auto-style)
  , with capitalized word "Class".

I attach a patch based on the above idea.

Bye,
Ikumi Keita

diff -r c52403a42881 latex.el
--- a/latex.el	Wed Dec 21 22:58:09 2016 +0900
+++ b/latex.el	Thu Feb 02 22:50:17 2017 +0900
@@ -1799,9 +1799,10 @@
 			      (list (cons style options)))))
 
 	;; The third argument if "class" indicates LaTeX2e features.
-	(cond ((equal class "class")
+	(cond ((or (string-equal class "class")
+		   (string-equal class "Class"))
 	       (add-to-list 'TeX-auto-file "latex2e"))
-	      ((equal class "style")
+	      ((string-equal class "style")
 	       (add-to-list 'TeX-auto-file "latex2"))))))
 
   ;; Cleanup optional arguments
diff -r c52403a42881 tex.el
--- a/tex.el	Wed Dec 21 22:58:09 2016 +0900
+++ b/tex.el	Thu Feb 02 22:50:17 2017 +0900
@@ -1173,12 +1173,12 @@
      (not (and (fboundp 'LaTeX-provided-class-options)
 	       (LaTeX-match-class-option "\\`landscape\\'"))))
     (paper-a4
-     (let ((regex "\\`a4paper\\|a4dutch\\|a4wide\\|sem-a4\\'"))
+     (let ((regex "\\`\\(?:a4paper\\|a4dutch\\|a4wide\\|sem-a4\\)\\'"))
        (or (TeX-match-style regex)
 	   (and (fboundp 'LaTeX-match-class-option)
 		(LaTeX-match-class-option regex)))))
     (paper-a5
-     (let ((regex "\\`a5paper\\|a5comb\\'"))
+     (let ((regex "\\`\\(?:a5paper\\|a5comb\\)\\'"))
        (or (TeX-match-style regex)
 	   (and (fboundp 'LaTeX-match-class-option)
 		(LaTeX-match-class-option regex)))))

Message #17 received at 25563 <at> debbugs.gnu.org (full text, mbox):

From: Ikumi Keita <ikumi <at> ikumi.que.jp>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: 25563 <at> debbugs.gnu.org
Subject: Re: bug#25563: 11.90;
 Many predicates in TeX-view-predicate-list-builtin don't work.
Date: Thu, 02 Feb 2017 23:42:11 +0900

> I attach a patch based on the above idea.

Added trivial fix for coherency (provided -> match).

Bye,
Ikumi Keita

diff -r c52403a42881 latex.el
--- a/latex.el	Wed Dec 21 22:58:09 2016 +0900
+++ b/latex.el	Thu Feb 02 23:40:09 2017 +0900
@@ -1799,9 +1799,10 @@
 			      (list (cons style options)))))
 
 	;; The third argument if "class" indicates LaTeX2e features.
-	(cond ((equal class "class")
+	(cond ((or (string-equal class "class")
+		   (string-equal class "Class"))
 	       (add-to-list 'TeX-auto-file "latex2e"))
-	      ((equal class "style")
+	      ((string-equal class "style")
 	       (add-to-list 'TeX-auto-file "latex2"))))))
 
   ;; Cleanup optional arguments
diff -r c52403a42881 tex.el
--- a/tex.el	Wed Dec 21 22:58:09 2016 +0900
+++ b/tex.el	Thu Feb 02 23:40:09 2017 +0900
@@ -1167,18 +1167,18 @@
     (mode-io-correlate
      TeX-source-correlate-mode)
     (paper-landscape
-     (and (fboundp 'LaTeX-provided-class-options)
+     (and (fboundp 'LaTeX-match-class-options)
 	  (LaTeX-match-class-option "\\`landscape\\'")))
     (paper-portrait
-     (not (and (fboundp 'LaTeX-provided-class-options)
+     (not (and (fboundp 'LaTeX-match-class-options)
 	       (LaTeX-match-class-option "\\`landscape\\'"))))
     (paper-a4
-     (let ((regex "\\`a4paper\\|a4dutch\\|a4wide\\|sem-a4\\'"))
+     (let ((regex "\\`\\(?:a4paper\\|a4dutch\\|a4wide\\|sem-a4\\)\\'"))
        (or (TeX-match-style regex)
 	   (and (fboundp 'LaTeX-match-class-option)
 		(LaTeX-match-class-option regex)))))
     (paper-a5
-     (let ((regex "\\`a5paper\\|a5comb\\'"))
+     (let ((regex "\\`\\(?:a5paper\\|a5comb\\)\\'"))
        (or (TeX-match-style regex)
 	   (and (fboundp 'LaTeX-match-class-option)
 		(LaTeX-match-class-option regex)))))

Message #20 received at 25563 <at> debbugs.gnu.org (full text, mbox):

From: Ikumi Keita <ikumi <at> ikumi.que.jp>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: 25563 <at> debbugs.gnu.org
Subject: Re: bug#25563: 11.90;
 Many predicates in TeX-view-predicate-list-builtin don't work.
Date: Fri, 03 Feb 2017 00:24:18 +0900

>> I attach a patch based on the above idea.

> Added trivial fix for coherency (provided -> match).

Sorry for noise, I had to change "options" to "option", too.

Bye,
Ikumi Keita

diff -r c52403a42881 latex.el
--- a/latex.el	Wed Dec 21 22:58:09 2016 +0900
+++ b/latex.el	Fri Feb 03 00:21:58 2017 +0900
@@ -1799,9 +1799,10 @@
 			      (list (cons style options)))))
 
 	;; The third argument if "class" indicates LaTeX2e features.
-	(cond ((equal class "class")
+	(cond ((or (string-equal class "class")
+		   (string-equal class "Class"))
 	       (add-to-list 'TeX-auto-file "latex2e"))
-	      ((equal class "style")
+	      ((string-equal class "style")
 	       (add-to-list 'TeX-auto-file "latex2"))))))
 
   ;; Cleanup optional arguments
diff -r c52403a42881 tex.el
--- a/tex.el	Wed Dec 21 22:58:09 2016 +0900
+++ b/tex.el	Fri Feb 03 00:21:58 2017 +0900
@@ -1167,18 +1167,18 @@
     (mode-io-correlate
      TeX-source-correlate-mode)
     (paper-landscape
-     (and (fboundp 'LaTeX-provided-class-options)
+     (and (fboundp 'LaTeX-match-class-option)
 	  (LaTeX-match-class-option "\\`landscape\\'")))
     (paper-portrait
-     (not (and (fboundp 'LaTeX-provided-class-options)
+     (not (and (fboundp 'LaTeX-match-class-option)
 	       (LaTeX-match-class-option "\\`landscape\\'"))))
     (paper-a4
-     (let ((regex "\\`a4paper\\|a4dutch\\|a4wide\\|sem-a4\\'"))
+     (let ((regex "\\`\\(?:a4paper\\|a4dutch\\|a4wide\\|sem-a4\\)\\'"))
        (or (TeX-match-style regex)
 	   (and (fboundp 'LaTeX-match-class-option)
 		(LaTeX-match-class-option regex)))))
     (paper-a5
-     (let ((regex "\\`a5paper\\|a5comb\\'"))
+     (let ((regex "\\`\\(?:a5paper\\|a5comb\\)\\'"))
        (or (TeX-match-style regex)
 	   (and (fboundp 'LaTeX-match-class-option)
 		(LaTeX-match-class-option regex)))))

Message #23 received at 25563 <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Ikumi Keita <ikumi <at> ikumi.que.jp>
Cc: 25563 <at> debbugs.gnu.org
Subject: Re: bug#25563: 11.90;
 Many predicates in TeX-view-predicate-list-builtin don't work.
Date: Thu, 02 Feb 2017 17:27:02 +0100

Ikumi Keita <ikumi <at> ikumi.que.jp> writes:

Hi Ikumi,

>> For paper-a4 and paper-a5 I wasn't quite sure if at least some of the
>> regexes there could also be styles/packages so there I check both
>> styles and documentclass options.  If you know better than me, feel
>> free to make that more specific.
>
> Sorry, I am not familiar about that issue either.

Ok, no problem to keep checking for both.

> And just some minor comments about the code related to the problem.
>
> 1. Isn't the the regexp \`a5paper\|a5comb\' for paper-a5 really intended
>    as \`\(?:a5paper\|a5comb\)\' ?  Similar question goes to the regexp
>    for paper-a4, too.

Oh, I didn't think about it.  But after a short test it seems that
foo\|bar is equivalent to \(foo\|bar\) and not to fo\(o\|b\)ar which you
seem to expect (and which sounded more plausible to me, too).

Anyway, IMO the shy group with its parens makes it more understandable
to me, so please go ahead.

> 2. `LaTeX-auto-cleanup' treats "package" and "Package" equally at the
>    part
>         (if (or (string-equal "package" class)
>                 (string-equal "Package" class))
>    .  Thus the later part
> 	(cond (equal class "class")
> 	      (add-to-list 'TeX-auto-file "latex2e"))
>    shuold also treat "class" and "Class" equally, shouldn't it?

Yes, makes sense.

Could you do me a favor and submit a one-in-all patch which also
contains your changes from your later 2 changes with a ChangeLog-like
commit message?

Bye,
Tassilo

BTW: You are a contributor since a very long time (12 years!) and I
completely trust your ability to not mess up things beyond repair.  So
I'd happily give you push access to our repository if you want to.
Interested?

Message #26 received at 25563 <at> debbugs.gnu.org (full text, mbox):

From: Ikumi Keita <ikumi <at> ikumi.que.jp>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: 25563 <at> debbugs.gnu.org
Subject: Re: bug#25563: 11.90;
 Many predicates in TeX-view-predicate-list-builtin don't work.
Date: Fri, 03 Feb 2017 19:20:34 +0900

[Message part 1 (text/plain, inline)]

Hi Tassilo,

>> 1. Isn't the the regexp \`a5paper\|a5comb\' for paper-a5 really intended
>> as \`\(?:a5paper\|a5comb\)\' ?  Similar question goes to the regexp
>> for paper-a4, too.

> Oh, I didn't think about it.  But after a short test it seems that
> foo\|bar is equivalent to \(foo\|bar\) and not to fo\(o\|b\)ar which you
> seem to expect (and which sounded more plausible to me, too).

Ah, no, my concern is in the way how "\`" and "\'" are interpreted.  The
original regexp \`a5paper\|a5comb\' means
"\`a5paper" or "a5comb\'",
not
"\`a5paper\'" or "\`a5comb\'".
That is, \`a5paper\|a5comb\' matches with "a5paperXYZ" and "XYZa5comb"
while \`\(?:a5paper\|a5comb\)\' does not.

>> 2. `LaTeX-auto-cleanup' treats "package" and "Package" equally at the
>> part
>> (if (or (string-equal "package" class)
>> (string-equal "Package" class))
>> .  Thus the later part
>> (cond (equal class "class")
>> (add-to-list 'TeX-auto-file "latex2e"))
>> shuold also treat "class" and "Class" equally, shouldn't it?

> Yes, makes sense.

> Could you do me a favor and submit a one-in-all patch which also
> contains your changes from your later 2 changes with a ChangeLog-like
> commit message?

OK, the patch is attached at the last of this mail.

> Bye,
> Tassilo

> BTW: You are a contributor since a very long time (12 years!) and I
> completely trust your ability to not mess up things beyond repair.  So
> I'd happily give you push access to our repository if you want to.
> Interested?

Thank you very much.  I would like to recieve that honor.  Please tell
me what I should do next.

Regards,
Ikumi Keita

[diff (text/x-diff, attachment)]

Message #29 received at 25563 <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Ikumi Keita <ikumi <at> ikumi.que.jp>
Cc: 25563 <at> debbugs.gnu.org
Subject: Re: bug#25563: 11.90;
 Many predicates in TeX-view-predicate-list-builtin don't work.
Date: Fri, 03 Feb 2017 12:17:47 +0100

Ikumi Keita <ikumi <at> ikumi.que.jp> writes:

Hi Ikumi,

>> Oh, I didn't think about it.  But after a short test it seems that
>> foo\|bar is equivalent to \(foo\|bar\) and not to fo\(o\|b\)ar which you
>> seem to expect (and which sounded more plausible to me, too).
>
> Ah, no, my concern is in the way how "\`" and "\'" are interpreted.  The
> original regexp \`a5paper\|a5comb\' means
> "\`a5paper" or "a5comb\'",
> not
> "\`a5paper\'" or "\`a5comb\'".
> That is, \`a5paper\|a5comb\' matches with "a5paperXYZ" and "XYZa5comb"
> while \`\(?:a5paper\|a5comb\)\' does not.

Oh, of course you are right!

>> BTW: You are a contributor since a very long time (12 years!) and I
>> completely trust your ability to not mess up things beyond repair.  So
>> I'd happily give you push access to our repository if you want to.
>> Interested?
>
> Thank you very much.  I would like to recieve that honor.  Please tell
> me what I should do next.

Great, welcome on board!

First, you need a savannah account (https://savannah.gnu.org) if you
don't have one already.  In your account settings, you have to register
your public SSH key which will be used for authentication by git.  Go to
the AUCTeX page (https://savannah.gnu.org/projects/auctex/) and apply
for membership.  I'll then accept and you are ready to push.  Let's use
this patch as test if your setup works, i.e., I won't commit and push it
right now but you do it yourself after we've set everything up.

The right git url to use with your savannah user name and SSH key is
shown on https://savannah.gnu.org/git/?group=auctex when you are logged
in.

Bye,
Tassilo

Message #32 received at 25563 <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Ikumi Keita <ikumi <at> ikumi.que.jp>
Cc: 25563 <at> debbugs.gnu.org
Subject: Re: bug#25563: 11.90;
 Many predicates in TeX-view-predicate-list-builtin don't work.
Date: Fri, 03 Feb 2017 20:07:23 +0100

Tassilo Horn <tsdh <at> gnu.org> writes:

> First, you need a savannah account (https://savannah.gnu.org) if you
> don't have one already.  In your account settings, you have to register
> your public SSH key which will be used for authentication by git.  Go to
> the AUCTeX page (https://savannah.gnu.org/projects/auctex/) and apply
> for membership.  I'll then accept and you are ready to push.

Accepted, you should be able to push your change.

Viele Grüße,
Tassilo

Message #37 received at 25563-done <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: 25563-done <at> debbugs.gnu.org
Subject: Re: bug#25563: 11.90;
 Many predicates in TeX-view-predicate-list-builtin don't work.
Date: Mon, 06 Feb 2017 09:23:00 +0100

Closing this bug as Ikumi has pushed his fix.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.