GNU bug report logs - #25561
25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil

Previous Next

Package: emacs;

Reported by: Vasilij Schneidermann <v.schneidermann <at> gmail.com>

Date: Sat, 28 Jan 2017 11:04:01 UTC

Severity: minor

Merged with 25986

Found in versions 25.1, 25.2

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#25561: closed (25.1; "Making isearch-search-fun-function
 local to *Minibuf-1* while let-bound!" warning with Evil)
Date: Sat, 18 Feb 2017 09:30:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 18 Feb 2017 11:29:47 +0200
with message-id <83ino7rgms.fsf <at> gnu.org>
and subject line Re: bug#25561: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil
has caused the debbugs.gnu.org bug report #25561,
regarding 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
25561: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25561
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Vasilij Schneidermann <v.schneidermann <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while
 let-bound!" warning with Evil
Date: Sat, 28 Jan 2017 12:03:31 +0100
Hello,

a user of the Evil package reported [1] that using a search command
results in a "Making isearch-search-fun-function local to *Minibuf-1*
while let-bound!" warning.  This appears to be an interaction between
isearch and Evil, more specifically, Evil let-binds
`isearch-search-fun-function' to something of its own, invokes isearch
and something in isearch ends up running
`minibuffer-history-isearch-setup' which `make-local-variable' to have
`isearch-search-fun-function' have a separate value, resulting in the
aforementioned warning.

What's the recommended way to avoid or silence it?  Stefan suggested
elsewhere [2] that this might indicate a bug, hence why I'm bringing
this up here.

[1]: https://github.com/emacs-evil/evil/issues/748
[2]: https://lists.gnu.org/archive/html/emacs-devel/2010-06/msg00903.html


[Message part 3 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 25561-done <at> debbugs.gnu.org, v.schneidermann <at> gmail.com, juri <at> linkov.net
Subject: Re: bug#25561: 25.1;
 "Making isearch-search-fun-function local to *Minibuf-1* while
 let-bound!" warning with Evil
Date: Sat, 18 Feb 2017 11:29:47 +0200
> From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
> Cc: v.schneidermann <at> gmail.com, 25561 <at> debbugs.gnu.org, juri <at> linkov.net
> Date: Fri, 10 Feb 2017 07:45:53 -0500
> 
> > So you are saying we should remove that warning entirely?
> 
> Yes.
> 
> > What about the other warning, "Making FOO buffer-local while let-bound!"?
> 
> IIRC this one is less annoying, but it didn't prove useful either, so
> I thing we should remove it as well.

Done.


This bug report was last modified 8 years and 79 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.