Subject: bug#25561: closed (Re: bug#25561: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 18 Feb 2017 09:30:03 +0000

Your bug report

#25561: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
25561: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25561
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#25561: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil
From: Eli Zaretskii <[email-masked]>
To: Stefan Monnier <[email-masked]>
Cc: [email-masked], [email-masked], [email-masked]
Date: Sat, 18 Feb 2017 11:29:47 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

> From: Stefan Monnier <[email-masked]>
> Cc: [email-masked], [email-masked], [email-masked]
> Date: Fri, 10 Feb 2017 07:45:53 -0500
> 
> > So you are saying we should remove that warning entirely?
> 
> Yes.
> 
> > What about the other warning, "Making FOO buffer-local while let-bound!"?
> 
> IIRC this one is less annoying, but it didn't prove useful either, so
> I thing we should remove it as well.

Done.

Subject: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil
From: Vasilij Schneidermann <[email-masked]>
To: [email-masked]
Date: Sat, 28 Jan 2017 12:03:31 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

a user of the Evil package reported [1] that using a search command
results in a "Making isearch-search-fun-function local to *Minibuf-1*
while let-bound!" warning.  This appears to be an interaction between
isearch and Evil, more specifically, Evil let-binds
`isearch-search-fun-function' to something of its own, invokes isearch
and something in isearch ends up running
`minibuffer-history-isearch-setup' which `make-local-variable' to have
`isearch-search-fun-function' have a separate value, resulting in the
aforementioned warning.

What's the recommended way to avoid or silence it?  Stefan suggested
elsewhere [2] that this might indicate a bug, hence why I'm bringing
this up here.

[1]: https://github.com/emacs-evil/evil/issues/748
[2]: https://lists.gnu.org/archive/html/emacs-devel/2010-06/msg00903.html