From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 06:03:45 2017 Received: (at submit) by debbugs.gnu.org; 28 Jan 2017 11:03:45 +0000 Received: from localhost ([127.0.0.1]:48815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXQnJ-0007hW-0b for submit@debbugs.gnu.org; Sat, 28 Jan 2017 06:03:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38125) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXQnG-0007hJ-B7 for submit@debbugs.gnu.org; Sat, 28 Jan 2017 06:03:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXQnA-0002yM-FX for submit@debbugs.gnu.org; Sat, 28 Jan 2017 06:03:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42801) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cXQnA-0002yD-Ca for submit@debbugs.gnu.org; Sat, 28 Jan 2017 06:03:36 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXQn9-0006E0-8y for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 06:03:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXQn8-0002xr-Dg for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 06:03:35 -0500 Received: from mail-ot0-x233.google.com ([2607:f8b0:4003:c0f::233]:34595) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXQn8-0002xf-8w for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2017 06:03:34 -0500 Received: by mail-ot0-x233.google.com with SMTP id f9so214550277otd.1 for ; Sat, 28 Jan 2017 03:03:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=3T1YJ6kGE/fyNd7YbJ6DlNFX4LGv3HlXnLdgYe8xY8c=; b=IqLVxdcXnsSXEtfAYsdRACYfI4Zof9v8cKzn/BwljB1DA1jDKMzLWQaiopJBaSKSjQ QQOxV2UsMIIigYh/Ff1mhHvAn/HBXd67N+lcvV2A5X+u1g6QkRF3jaxUqlZqbYA1ky4W JtpRZz4SpirDvLSmyHXqQKSFwAGpGnpKJoLmU/BO8lKM4kOHDNk/AXQVIL6qaEkjughQ 5tTSgEdoBgXJ50cBJ7cmqauefFGiTZ5NpY+QsvpqPRAtSOJlWftMP89HdcczNX+fd7L4 kDn77qnfYQfipId4mtXsH/gTtOo929IiuDhAm6KDOzjPVKGsnA3QJAxS/x3gbVfVrUBc defw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=3T1YJ6kGE/fyNd7YbJ6DlNFX4LGv3HlXnLdgYe8xY8c=; b=p8KuoluyvNpSh7+dCZN5WfBfqpaXrdG7YXafJePehcF0Khj8zzsHTrMMBHiSjBpdMT u/Uoqj+7x4zWSzYvBBgZqqFPHkLTxOFgLZ8lcjrv87iDYzaxD9iuo1o8gy2wlEPiVt76 GaiEc8+PrAhq9G219w6TyYkBkTwSWerthtidsDohvpeLSo3n5KWbc1Sr18ceILhC7OZR pJmexccX6SMyJk/IE4rnim1FCo0BmaZIRWMcUfg8CVOAXEFZ0s329+yLrrI1TODocfEf 9I0K/PzotYvq6G6EgdtSpo2+UhtwYBwUBuSxsrpeyLAqXq35Hc7qanaSy05PIuCT3vhK MOIg== X-Gm-Message-State: AIkVDXKPGXzAzzFj0mwFVtrFgDOQ3RywAMpmUhkTn5MqPOcjq/dwgmeYD60rZzenaOjHV4L2repkfwYnPLMeAQ== X-Received: by 10.157.46.114 with SMTP id c47mr5854208otd.176.1485601411745; Sat, 28 Jan 2017 03:03:31 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.0.34 with HTTP; Sat, 28 Jan 2017 03:03:31 -0800 (PST) From: Vasilij Schneidermann Date: Sat, 28 Jan 2017 12:03:31 +0100 Message-ID: Subject: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hello, a user of the Evil package reported [1] that using a search command results in a "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning. This appears to be an interaction between isearch and Evil, more specifically, Evil let-binds `isearch-search-fun-function' to something of its own, invokes isearch and something in isearch ends up running `minibuffer-history-isearch-setup' which `make-local-variable' to have `isearch-search-fun-function' have a separate value, resulting in the aforementioned warning. What's the recommended way to avoid or silence it? Stefan suggested elsewhere [2] that this might indicate a bug, hence why I'm bringing this up here. [1]: https://github.com/emacs-evil/evil/issues/748 [2]: https://lists.gnu.org/archive/html/emacs-devel/2010-06/msg00903.html From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 19:51:05 2017 Received: (at 25561) by debbugs.gnu.org; 29 Jan 2017 00:51:05 +0000 Received: from localhost ([127.0.0.1]:49570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXdhx-0004wI-Gr for submit@debbugs.gnu.org; Sat, 28 Jan 2017 19:51:05 -0500 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:45207 helo=homiemail-a23.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXdhs-0004vV-Ni for 25561@debbugs.gnu.org; Sat, 28 Jan 2017 19:51:01 -0500 Received: from homiemail-a23.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a23.g.dreamhost.com (Postfix) with ESMTP id 258D84B006D; Sat, 28 Jan 2017 16:51:00 -0800 (PST) Received: from localhost.linkov.net (m213-100-238-78.cust.tele2.ee [213.100.238.78]) (Authenticated sender: jurta@jurta.org) by homiemail-a23.g.dreamhost.com (Postfix) with ESMTPA id 542704B0063; Sat, 28 Jan 2017 16:50:59 -0800 (PST) From: Juri Linkov To: Vasilij Schneidermann Subject: Re: bug#25561: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil Organization: LINKOV.NET References: Date: Sun, 29 Jan 2017 02:39:53 +0200 In-Reply-To: (Vasilij Schneidermann's message of "Sat, 28 Jan 2017 12:03:31 +0100") Message-ID: <8760kyzoma.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 3.2 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Hello, > > a user of the Evil package reported [1] that using a search command > results in a "Making isearch-search-fun-function local to *Minibuf-1* > while let-bound!" warning. This appears to be an interaction between > isearch and Evil, more specifically, Evil let-binds > `isearch-search-fun-function' to something of its own, invokes isearch > and something in isearch ends up running > `minibuffer-history-isearch-setup' which `make-local-variable' to have > `isearch-search-fun-function' have a separate value, resulting in the > aforementioned warning. > > What's the recommended way to avoid or silence it? Stefan suggested > elsewhere [2] that this might indicate a bug, hence why I'm bringing > this up here. > > [1]: https://github.com/emacs-evil/evil/issues/748 > [2]: https://lists.gnu.org/archive/html/emacs-devel/2010-06/msg00903.html [...] Content analysis details: (3.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [69.163.253.7 listed in dnsbl.sorbs.net] 0.0 RCVD_IN_MSPIKE_L5 RBL: Very bad reputation (-5) [69.163.253.7 listed in bl.mailspike.net] 2.7 RCVD_IN_PSBL RBL: Received via a relay in PSBL [69.163.253.7 listed in psbl.surriel.com] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [69.163.253.7 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_BL Mailspike blacklisted X-Debbugs-Envelope-To: 25561 Cc: 25561@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 3.2 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > Hello, > > a user of the Evil package reported [1] that using a search command > results in a "Making isearch-search-fun-function local to *Minibuf-1* > while let-bound!" warning. This appears to be an interaction between > isearch and Evil, more specifically, Evil let-binds > `isearch-search-fun-function' to something of its own, invokes isearch > and something in isearch ends up running > `minibuffer-history-isearch-setup' which `make-local-variable' to have > `isearch-search-fun-function' have a separate value, resulting in the > aforementioned warning. > > What's the recommended way to avoid or silence it? Stefan suggested > elsewhere [2] that this might indicate a bug, hence why I'm bringing > this up here. > > [1]: https://github.com/emacs-evil/evil/issues/748 > [2]: https://lists.gnu.org/archive/html/emacs-devel/2010-06/msg00903.html [...] Content analysis details: (3.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [69.163.253.7 listed in dnsbl.sorbs.net] 0.0 RCVD_IN_MSPIKE_L5 RBL: Very bad reputation (-5) [69.163.253.7 listed in bl.mailspike.net] 2.7 RCVD_IN_PSBL RBL: Received via a relay in PSBL [69.163.253.7 listed in psbl.surriel.com] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [69.163.253.7 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_BL Mailspike blacklisted > Hello, > > a user of the Evil package reported [1] that using a search command > results in a "Making isearch-search-fun-function local to *Minibuf-1* > while let-bound!" warning. This appears to be an interaction between > isearch and Evil, more specifically, Evil let-binds > `isearch-search-fun-function' to something of its own, invokes isearch > and something in isearch ends up running > `minibuffer-history-isearch-setup' which `make-local-variable' to have > `isearch-search-fun-function' have a separate value, resulting in the > aforementioned warning. > > What's the recommended way to avoid or silence it? Stefan suggested > elsewhere [2] that this might indicate a bug, hence why I'm bringing > this up here. > > [1]: https://github.com/emacs-evil/evil/issues/748 > [2]: https://lists.gnu.org/archive/html/emacs-devel/2010-06/msg00903.html Thanks for the report. I'm not familiar with the Evil package, so please correct me if I make wrong guesses about it. I suppose that the basic mode of operation of the Evil package is not buffer-local. In this case I believe (make-local-variable 'isearch-search-fun-function) is the wrong fix because it will make this variable have this value in every random buffer where the user happens to invoke the search command. OTOH, if evil-mode is the global mode then it makes sense to change the global value of isearch-search-fun-function (and perhaps keeping its old value). If you need to keep standard search commands working, then you could create a new internal defvar e.g. evil-search-is-active, set it temporarily in evil-search commands, and check it in your new implementation of the search function in isearch-search-fun-function. If evil-search-is-active is nil, then call the old default value isearch-search-fun-default. I can't guarantee this solution to work, it's just an idea for you to consider. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 29 07:25:33 2017 Received: (at 25561) by debbugs.gnu.org; 29 Jan 2017 12:25:33 +0000 Received: from localhost ([127.0.0.1]:49759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXoY1-0005ob-5c for submit@debbugs.gnu.org; Sun, 29 Jan 2017 07:25:33 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXoXz-0005oN-8w for 25561@debbugs.gnu.org; Sun, 29 Jan 2017 07:25:31 -0500 Received: by mail-wm0-f67.google.com with SMTP id c85so70346082wmi.1 for <25561@debbugs.gnu.org>; Sun, 29 Jan 2017 04:25:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VEIhqdHgqKnf+omRZwku7uJFU4+qXT2A6gboPv57Wew=; b=lxz7lQRrKIUIWoRjrZWCZC7zPe09KERV9nclAUGT2otbWJgUW+LXaGAZaE0OVfU3K2 IQwujwSB24DuDdjou8aTlaeKo9QoG78jiJy2G6U7OPO8Ato0lbAXlp8qL2OEFJypjW8q sNvIJRTq4SDbmaURvzXTGaoKuI03DpOiGL1UoLReGbao0E9ZAiKbvys2/7xcO9cnpOSS rDo2eXjhqUiAXKR8x+whHT//53pdt6wWoz2OcoO4dov2lWxMCLvyyWNNywA/DGxE4WJj MPB2KbmY0Hg9xHA7xjEY59H81ZUMrqf8COEF9Y+vmM30pTJezd//JcctSvUZYgflQcJ7 iEHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VEIhqdHgqKnf+omRZwku7uJFU4+qXT2A6gboPv57Wew=; b=mNHseq0q4QZu81daYzy9WAaaScH/BgbhPNB0jvSpEOAO6q8CnJaqwiZe/GjoMhIJpe /sIf1H6XBr2zhnAkfby+GmryhGQaAZsZqBgy3MGTR5F75tYPVNJyYxVXuVfCt8rV+N3u ttVqvcNsEn6tU3MJMYuYR1eJFoSGDp2o7gJPcxw4GFK1/AOhIPXm+HTqBgii/c3IakKy WAYev7ism0dfz0jCzKghFBuPFpUnQTu9sY27Xn5UWdnczOyfSyIGFpiYjejA7MdZQENJ qS5ybgb6/Nw2TLFSaGAey4jiaYTJlXs3FeUS9uD+Jazmo3yncBfdAbfEI4jquUH5q/Gi w9vw== X-Gm-Message-State: AIkVDXLG6H6xRBgeQfVBi62Oi8fs8SPujbCD+eZkiNJP4MVP36F+ASMcZ+MlaLynMyeJHA== X-Received: by 10.223.160.206 with SMTP id n14mr14597279wrn.31.1485692725476; Sun, 29 Jan 2017 04:25:25 -0800 (PST) Received: from localhost (dslb-092-073-085-113.092.073.pools.vodafone-ip.de. [92.73.85.113]) by smtp.gmail.com with ESMTPSA id s17sm17515433wrc.6.2017.01.29.04.25.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 29 Jan 2017 04:25:24 -0800 (PST) Date: Sun, 29 Jan 2017 13:25:24 +0100 From: Vasilij Schneidermann To: Juri Linkov Subject: Re: bug#25561: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil Message-ID: <20170129122524.GA602@odonien.localdomain> References: <8760kyzoma.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8760kyzoma.fsf@mail.linkov.net> User-Agent: Mutt/1.7.2 (2016-11-26) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25561 Cc: 25561@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) > Thanks for the report. I'm not familiar with the Evil package, so > please correct me if I make wrong guesses about it. I suppose that > the basic mode of operation of the Evil package is not buffer-local. It's a bit trickier than that. Evil defines a minor mode (evil-local-mode), then a global minor mode (evil-mode) using it and a few more variables for state tracking. The supported mode of operation is therefore global, while still allowing to deactivate it on a per-buffer or even per-command basis (there's a command to deactivate Evil's keymaps for the duration of the next command). > OTOH, if evil-mode is the global mode then it makes sense to change > the global value of isearch-search-fun-function (and perhaps keeping > its old value). If you need to keep standard search commands working, > then you could create a new internal defvar e.g. > evil-search-is-active, set it temporarily in evil-search commands, and > check it in your new implementation of the search function in > isearch-search-fun-function. If evil-search-is-active is nil, then > call the old default value isearch-search-fun-default. Hm, this sounds hackier than the current approach, also, what if another package let-binds this variable for custom search functionality? The reason I reported this warning is because I suspect something about isearch and the minibuffer setup hook isn't done correctly, in hope of getting rid of the warning for every user of that variable. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 08 07:55:33 2017 Received: (at 25561) by debbugs.gnu.org; 8 Feb 2017 12:55:33 +0000 Received: from localhost ([127.0.0.1]:59664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbRmX-0000JO-Fx for submit@debbugs.gnu.org; Wed, 08 Feb 2017 07:55:33 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbRmU-0000J5-Ot for 25561@debbugs.gnu.org; Wed, 08 Feb 2017 07:55:31 -0500 Received: by mail-wm0-f66.google.com with SMTP id c85so33092850wmi.1 for <25561@debbugs.gnu.org>; Wed, 08 Feb 2017 04:55:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1q84zkwRZJAWkSfpOda1l3tT4yu4j67mH/ycVXNn6FA=; b=MihseFwAkr3F36NDeW1dOfVdZIjbSIBYTHeQazxwSGqqMmOwjLb/241ssfS+RPmK+5 1oTOWkUOYjhQ1vTROktFmluQbDRF6nJ8X3/rZn6cRPAxblNY71BmWUlQfouJt0eouq9B bF/kApipQ25Gzqk67mAZ/WMqHG8JfmmyLcqK5uY1PdsnX7gvxSWIBychjf9pqCg9gd+m o0rv83wNS26xYCTuXzYqYGZtCvcU/5PkvnLAG1uFaT4XzI/kPN+SGnUcUwFwDQPV7lU8 xHuwtDbCFANZyWou48oAoec82fc3mUN3tUdROdvsCeN1ASSKvSEDmYu8SJI5HNnfiwdS aVug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1q84zkwRZJAWkSfpOda1l3tT4yu4j67mH/ycVXNn6FA=; b=PkB/PENIeOlbAi0juGTeVoyyiuUFt4Dmb66VV/JtzjkXq5aUb2Waoi4RWDQqylPL++ ZvIumzl62GVu29EP8Li5y/rd6jF31o7hyDnGSWCHWMNvHXhljcuwM/RPqeM5w18azRDq hnjModksiNPIKMjzj4wsKDgSiAmPUdlp03wfIvj0Rl9uXD+Hw5k8BTxFrAeH0nW03YnN 88zWZjCNQcbxrLTzc1EXzN41aVFN7wPMFQTuIGZg1GRnmb/jV1d8tT2OWBwY2YbwL3lP GZh2tXJnQX1Nwuk2SDvSjcwFD9bA+ryo+ruXgfhIg/hl7O1qXTpfNlSw2mDZhteHrHxP v4Pg== X-Gm-Message-State: AMke39nLo6R4UWcy1O7Vl0PBZljQ/X7V4oncsCXvnCUUyUHXVhnjzjuOKDg/r7kmaOua9w== X-Received: by 10.28.189.195 with SMTP id n186mr16594229wmf.77.1486558524790; Wed, 08 Feb 2017 04:55:24 -0800 (PST) Received: from localhost (dslb-088-078-199-035.088.078.pools.vodafone-ip.de. [88.78.199.35]) by smtp.gmail.com with ESMTPSA id i15sm3198173wmf.21.2017.02.08.04.55.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 Feb 2017 04:55:24 -0800 (PST) Date: Wed, 8 Feb 2017 13:55:23 +0100 From: Vasilij Schneidermann To: Juri Linkov Subject: Re: bug#25561: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil Message-ID: <20170208125523.GA703@odonien.localdomain> References: <8760kyzoma.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8760kyzoma.fsf@mail.linkov.net> User-Agent: Mutt/1.7.2 (2016-11-26) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25561 Cc: 25561@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Bumping this thread to CC Stefan Monnier as well. On 01/29/17 at 02:39am, Juri Linkov wrote: > > Hello, > > > > a user of the Evil package reported [1] that using a search command > > results in a "Making isearch-search-fun-function local to *Minibuf-1* > > while let-bound!" warning. This appears to be an interaction between > > isearch and Evil, more specifically, Evil let-binds > > `isearch-search-fun-function' to something of its own, invokes isearch > > and something in isearch ends up running > > `minibuffer-history-isearch-setup' which `make-local-variable' to have > > `isearch-search-fun-function' have a separate value, resulting in the > > aforementioned warning. > > > > What's the recommended way to avoid or silence it? Stefan suggested > > elsewhere [2] that this might indicate a bug, hence why I'm bringing > > this up here. > > > > [1]: https://github.com/emacs-evil/evil/issues/748 > > [2]: https://lists.gnu.org/archive/html/emacs-devel/2010-06/msg00903.html > > Thanks for the report. I'm not familiar with the Evil package, > so please correct me if I make wrong guesses about it. I suppose > that the basic mode of operation of the Evil package is not buffer-local. > In this case I believe (make-local-variable 'isearch-search-fun-function) > is the wrong fix because it will make this variable have this value > in every random buffer where the user happens to invoke the search command. > > OTOH, if evil-mode is the global mode then it makes sense to change the > global value of isearch-search-fun-function (and perhaps keeping its > old value). If you need to keep standard search commands working, > then you could create a new internal defvar e.g. evil-search-is-active, > set it temporarily in evil-search commands, and check it in your new > implementation of the search function in isearch-search-fun-function. > If evil-search-is-active is nil, then call the old default value > isearch-search-fun-default. > > I can't guarantee this solution to work, it's just an idea for you > to consider. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 08 17:21:16 2017 Received: (at 25561) by debbugs.gnu.org; 8 Feb 2017 22:21:16 +0000 Received: from localhost ([127.0.0.1]:60604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbac0-0001s2-1r for submit@debbugs.gnu.org; Wed, 08 Feb 2017 17:21:16 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:55532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbabw-0001rt-VM for 25561@debbugs.gnu.org; Wed, 08 Feb 2017 17:21:14 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v18MLBAE002893; Wed, 8 Feb 2017 17:21:11 -0500 Received: by pastel.home (Postfix, from userid 20848) id 17EE2600C1; Wed, 8 Feb 2017 17:21:11 -0500 (EST) From: Stefan Monnier To: Vasilij Schneidermann Subject: Re: bug#25561: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil Message-ID: References: <8760kyzoma.fsf@mail.linkov.net> <20170208125523.GA703@odonien.localdomain> Date: Wed, 08 Feb 2017 17:21:11 -0500 In-Reply-To: <20170208125523.GA703@odonien.localdomain> (Vasilij Schneidermann's message of "Wed, 8 Feb 2017 13:55:23 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV5943=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5943> : inlines <5682> : streams <1732088> : uri <2373886> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 25561 Cc: 25561@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) >> > a user of the Evil package reported [1] that using a search command >> > results in a "Making isearch-search-fun-function local to *Minibuf-1* >> > while let-bound!" warning. This appears to be an interaction between >> > isearch and Evil, more specifically, Evil let-binds >> > `isearch-search-fun-function' to something of its own, invokes isearch >> > and something in isearch ends up running >> > `minibuffer-history-isearch-setup' which `make-local-variable' to have >> > `isearch-search-fun-function' have a separate value, resulting in the >> > aforementioned warning. >> > >> > What's the recommended way to avoid or silence it? Stefan suggested >> > elsewhere [2] that this might indicate a bug, hence why I'm bringing >> > this up here. I plead guilty of adding this warning. But FWIW, I think it was misguided: the interaction between make-local-variable and let-binding can be pretty tricky, which is why I added the warning (thinking that such things should better be avoided), but in my subsequent experience, I haven't found a single case where the problem is real. Worse: it's often difficult/ugly to change the code to avoid the "tricky" interaction, because the code that does the let-binding doesn't know about the other and vice-versa. So, while the trickiness rmains, I think it's best to just hope for the best, silently, rather than signal a warning that nobody (not even me) knows how to address satisfactorily. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 10 05:16:44 2017 Received: (at 25561) by debbugs.gnu.org; 10 Feb 2017 10:16:44 +0000 Received: from localhost ([127.0.0.1]:33853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cc8Fv-0003s4-Tb for submit@debbugs.gnu.org; Fri, 10 Feb 2017 05:16:44 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cc8Ft-0003rr-V0 for 25561@debbugs.gnu.org; Fri, 10 Feb 2017 05:16:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cc8Fn-0004ST-ST for 25561@debbugs.gnu.org; Fri, 10 Feb 2017 05:16:36 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:32868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cc8Fe-0004Rg-0S; Fri, 10 Feb 2017 05:16:26 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4638 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cc8Fd-0002Y9-5v; Fri, 10 Feb 2017 05:16:25 -0500 Date: Fri, 10 Feb 2017 12:16:32 +0200 Message-Id: <8360ki4agv.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Wed, 08 Feb 2017 17:21:11 -0500) Subject: Re: bug#25561: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil References: <8760kyzoma.fsf@mail.linkov.net> <20170208125523.GA703@odonien.localdomain> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25561 Cc: 25561@debbugs.gnu.org, v.schneidermann@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Stefan Monnier > Date: Wed, 08 Feb 2017 17:21:11 -0500 > Cc: 25561@debbugs.gnu.org, Juri Linkov > > >> > a user of the Evil package reported [1] that using a search command > >> > results in a "Making isearch-search-fun-function local to *Minibuf-1* > >> > while let-bound!" warning. This appears to be an interaction between > >> > isearch and Evil, more specifically, Evil let-binds > >> > `isearch-search-fun-function' to something of its own, invokes isearch > >> > and something in isearch ends up running > >> > `minibuffer-history-isearch-setup' which `make-local-variable' to have > >> > `isearch-search-fun-function' have a separate value, resulting in the > >> > aforementioned warning. > >> > > >> > What's the recommended way to avoid or silence it? Stefan suggested > >> > elsewhere [2] that this might indicate a bug, hence why I'm bringing > >> > this up here. > > I plead guilty of adding this warning. But FWIW, I think it was > misguided: the interaction between make-local-variable and let-binding > can be pretty tricky, which is why I added the warning (thinking that > such things should better be avoided), but in my subsequent experience, > I haven't found a single case where the problem is real. Worse: it's > often difficult/ugly to change the code to avoid the "tricky" > interaction, because the code that does the let-binding doesn't know > about the other and vice-versa. > > So, while the trickiness rmains, I think it's best to just hope for the > best, silently, rather than signal a warning that nobody (not even me) > knows how to address satisfactorily. So you are saying we should remove that warning entirely? What about the other warning, "Making FOO buffer-local while let-bound!"? From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 10 07:45:58 2017 Received: (at 25561) by debbugs.gnu.org; 10 Feb 2017 12:45:58 +0000 Received: from localhost ([127.0.0.1]:33885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccAaM-0000cT-0A for submit@debbugs.gnu.org; Fri, 10 Feb 2017 07:45:58 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:55640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ccAaK-0000cN-EC for 25561@debbugs.gnu.org; Fri, 10 Feb 2017 07:45:57 -0500 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v1ACjr4a020983; Fri, 10 Feb 2017 07:45:55 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 5D12E662A1; Fri, 10 Feb 2017 07:45:53 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#25561: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil Message-ID: References: <8760kyzoma.fsf@mail.linkov.net> <20170208125523.GA703@odonien.localdomain> <8360ki4agv.fsf@gnu.org> Date: Fri, 10 Feb 2017 07:45:53 -0500 In-Reply-To: <8360ki4agv.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 Feb 2017 12:16:32 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV5945=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5945> : inlines <5686> : streams <1732317> : uri <2374809> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 25561 Cc: 25561@debbugs.gnu.org, v.schneidermann@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > So you are saying we should remove that warning entirely? Yes. > What about the other warning, "Making FOO buffer-local while let-bound!"? IIRC this one is less annoying, but it didn't prove useful either, so I thing we should remove it as well. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 18 04:29:32 2017 Received: (at 25561-done) by debbugs.gnu.org; 18 Feb 2017 09:29:32 +0000 Received: from localhost ([127.0.0.1]:44144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf1Kd-0003l9-V9 for submit@debbugs.gnu.org; Sat, 18 Feb 2017 04:29:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf1Kc-0003ku-4J for 25561-done@debbugs.gnu.org; Sat, 18 Feb 2017 04:29:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cf1KW-0003XR-23 for 25561-done@debbugs.gnu.org; Sat, 18 Feb 2017 04:29:24 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cf1KQ-0003VZ-Uk; Sat, 18 Feb 2017 04:29:18 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4841 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cf1KP-0005ki-Vo; Sat, 18 Feb 2017 04:29:18 -0500 Date: Sat, 18 Feb 2017 11:29:47 +0200 Message-Id: <83ino7rgms.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Fri, 10 Feb 2017 07:45:53 -0500) Subject: Re: bug#25561: 25.1; "Making isearch-search-fun-function local to *Minibuf-1* while let-bound!" warning with Evil References: <8760kyzoma.fsf@mail.linkov.net> <20170208125523.GA703@odonien.localdomain> <8360ki4agv.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25561-done Cc: 25561-done@debbugs.gnu.org, v.schneidermann@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Stefan Monnier > Cc: v.schneidermann@gmail.com, 25561@debbugs.gnu.org, juri@linkov.net > Date: Fri, 10 Feb 2017 07:45:53 -0500 > > > So you are saying we should remove that warning entirely? > > Yes. > > > What about the other warning, "Making FOO buffer-local while let-bound!"? > > IIRC this one is less annoying, but it didn't prove useful either, so > I thing we should remove it as well. Done. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 05 17:30:08 2017 Received: (at control) by debbugs.gnu.org; 5 Mar 2017 22:30:08 +0000 Received: from localhost ([127.0.0.1]:41477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckefI-0001P5-Kw for submit@debbugs.gnu.org; Sun, 05 Mar 2017 17:30:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckefG-0001NE-L6 for control@debbugs.gnu.org; Sun, 05 Mar 2017 17:30:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckefA-00031U-Se for control@debbugs.gnu.org; Sun, 05 Mar 2017 17:30:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36599) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckefA-00031P-Pk for control@debbugs.gnu.org; Sun, 05 Mar 2017 17:30:00 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ckefA-0003UY-Fa for control@debbugs.gnu.org; Sun, 05 Mar 2017 17:30:00 -0500 Subject: control message for bug 25986 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Sun, 05 Mar 2017 17:30:00 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) forcemerge 25561 25986 From unknown Mon Aug 11 18:15:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 04 Apr 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator