Subject: bug#25547: 25.1.91; emacsclient -c creates frames on the wrong display

From: Eli Zaretskii <[email-masked]>
Date: Fri, 06 Nov 2020 07:39:34 +0200

> Cc: [email-masked], Alex Hutcheson <[email-masked]>
> Date: Thu, 5 Nov 2020 15:41:08 -0800
> From: Eliza Velasquez via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <[email-masked]>
> 
> +(defun server-create-frame (nowait proc &optional parameters)

This function's name is too general, and therefore will confuse
someone who tries to learn how server.el works.  Please name it
according to the convention used by 2 other functions in server.el
that create GUI and TTY frames.

Btw, why can't you use server-create-tty-frame here?  IOW, I don't
think I understand this comment:

> +                   ((equal tty-type "dumb")
> +                    ;; Dumb terminals should create frames without
> +                    ;; preference for tty or window system (bug#25547)
> +                    (server-create-frame nowait proc frame-parameters))

Thanks.