GNU bug report logs - #25542
25.1; Restoring the frame from fullscreen to maximized

Previous Next

Full log

View this message in rfc822 format

From: martin rudalics <rudalics <at> gmx.at>
To: Ken Brown <kbrown <at> cornell.edu>, Dani Moncayo <dmoncayo <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>, 25542 <at> debbugs.gnu.org, Noam Postavsky <npostavs <at> users.sourceforge.net>
Subject: bug#25542: 25.1; Restoring the frame from fullscreen to maximized
Date: Thu, 10 Sep 2020 20:16:04 +0200

>> (2) Does 'toggle-frame-fullscreen' the second time when you type F11
>>      correctly call
>>
>>     (set-frame-parameter frame 'fullscreen fullscreen-restore)
>>
>>     with 'fullscreen-restore' equal to 'maximized' at all?
>
> No.  The value of 'fullscreen-restore' is nil.  But if I repeat the experiment with the taskbar on the bottom, the value of fullscreen-restore is 'maximized'.

Thanks for telling me what I forgot to ask.  IIUC this means that after
maximizing the frame with the mouse, the value of

(frame-parameter nil 'fullscreen)

is nil.  Correct?  And what is its value if, instead, you maximize the
frame via 'toggle-frame-maximized'?

In either case the bug should be a consequence of the earlier mentioned

			if (x < 0 && y < 0)
			  store_frame_param (f, Qfullscreen, Qmaximized);

so we do not remember in the fullscreen parameter that the frame has
been maximized.  Apparently some check _is_ needed (why?) so probably
using

			if (x < 0 || y < 0)
			  store_frame_param (f, Qfullscreen, Qmaximized);

instead will fix it.  Can you try that (as I said elsewhere it will then
fail for borderless, maximized frames)?

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.