GNU bug report logs - #25542
25.1; Restoring the frame from fullscreen to maximized

Previous Next

Full log

Message #119 received at 25542 <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: rudalics <at> gmx.at, larsi <at> gnus.org, npostavs <at> users.sourceforge.net,
 25542 <at> debbugs.gnu.org, dmoncayo <at> gmail.com
Subject: Re: bug#25542: 25.1; Restoring the frame from fullscreen to maximized
Date: Sat, 5 Sep 2020 12:10:59 -0400

On 9/5/2020 12:07 PM, Eli Zaretskii wrote:
>> Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>, 25542 <at> debbugs.gnu.org,
>>   Noam Postavsky <npostavs <at> users.sourceforge.net>,
>>   martin rudalics <rudalics <at> gmx.at>
>> From: Ken Brown <kbrown <at> cornell.edu>
>> Date: Sat, 5 Sep 2020 11:10:31 -0400
>>
>> diff --git a/src/w32term.c b/src/w32term.c
>> index 76cf6bd696..c7da95528b 100644
>> --- a/src/w32term.c
>> +++ b/src/w32term.c
>> @@ -5454,15 +5454,7 @@ w32_read_socket (struct terminal *terminal,
>>                        simple hack to check that based on the fact that
>>                        only a maximized fullscreen frame should have both
>>                        top/left outside the screen.  */
>> -                 if (EQ (fullscreen, Qfullwidth) || EQ (fullscreen, Qfullheight)
>> -                     || NILP (fullscreen))
>> -                     {
>> -                       int x, y;
>> -
>> -                       w32_real_positions (f, &x, &y);
>> -                       if (x < 0 && y < 0)
>> -                         store_frame_param (f, Qfullscreen, Qmaximized);
>> -                     }
>> +                   store_frame_param (f, Qfullscreen, Qmaximized);
>>                     }
>>
>>                     break;
>>
>> If I make this change and follow Dani's recipe from the original bug report, the
>> second F11 press doesn't restore the previous state.  Instead, the frame appears
>> to get slightly smaller for an instant and then immediately reverts to
>> fullscreen mode.
> 
> Thanks for testing.  It sounds like the proposed change leaves the
> original incorrect behavior unchanged, so we need to look for some
> different way of fixing this.

It's not unchanged, it's just wrong in a different way.  Previously the second 
F11 resulted in an unmaximized frame.

Ken

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.