GNU bug report logs - #25542
25.1; Restoring the frame from fullscreen to maximized

Previous Next

Package: emacs;

Reported by: Dani Moncayo <dmoncayo <at> gmail.com>

Date: Thu, 26 Jan 2017 08:16:02 UTC

Severity: normal

Found in version 25.1

Done: Ken Brown <kbrown <at> cornell.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: rudalics <at> gmx.at, larsi <at> gnus.org, npostavs <at> users.sourceforge.net, 25542 <at> debbugs.gnu.org, dmoncayo <at> gmail.com
Subject: bug#25542: 25.1; Restoring the frame from fullscreen to maximized
Date: Sat, 05 Sep 2020 19:07:53 +0300
> Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>, 25542 <at> debbugs.gnu.org,
>  Noam Postavsky <npostavs <at> users.sourceforge.net>,
>  martin rudalics <rudalics <at> gmx.at>
> From: Ken Brown <kbrown <at> cornell.edu>
> Date: Sat, 5 Sep 2020 11:10:31 -0400
> 
> diff --git a/src/w32term.c b/src/w32term.c
> index 76cf6bd696..c7da95528b 100644
> --- a/src/w32term.c
> +++ b/src/w32term.c
> @@ -5454,15 +5454,7 @@ w32_read_socket (struct terminal *terminal,
>                       simple hack to check that based on the fact that
>                       only a maximized fullscreen frame should have both
>                       top/left outside the screen.  */
> -                 if (EQ (fullscreen, Qfullwidth) || EQ (fullscreen, Qfullheight)
> -                     || NILP (fullscreen))
> -                     {
> -                       int x, y;
> -
> -                       w32_real_positions (f, &x, &y);
> -                       if (x < 0 && y < 0)
> -                         store_frame_param (f, Qfullscreen, Qmaximized);
> -                     }
> +                   store_frame_param (f, Qfullscreen, Qmaximized);
>                    }
> 
>                    break;
> 
> If I make this change and follow Dani's recipe from the original bug report, the 
> second F11 press doesn't restore the previous state.  Instead, the frame appears 
> to get slightly smaller for an instant and then immediately reverts to 
> fullscreen mode.

Thanks for testing.  It sounds like the proposed change leaves the
original incorrect behavior unchanged, so we need to look for some
different way of fixing this.




This bug report was last modified 4 years and 258 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.