From unknown Wed Jun 25 02:05:59 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#25541 <25541@debbugs.gnu.org> To: bug#25541 <25541@debbugs.gnu.org> Subject: Status: [PATCH] Some small bat-mode fixes Reply-To: bug#25541 <25541@debbugs.gnu.org> Date: Wed, 25 Jun 2025 09:05:59 +0000 retitle 25541 [PATCH] Some small bat-mode fixes reassign 25541 emacs submitter 25541 Vladimir Panteleev severity 25541 minor tag 25541 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 25 23:59:25 2017 Received: (at submit) by debbugs.gnu.org; 26 Jan 2017 04:59:25 +0000 Received: from localhost ([127.0.0.1]:44059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWc9d-0008UY-7Q for submit@debbugs.gnu.org; Wed, 25 Jan 2017 23:59:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWbnh-0007xx-Qe for submit@debbugs.gnu.org; Wed, 25 Jan 2017 23:36:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWbnb-0007n0-Qw for submit@debbugs.gnu.org; Wed, 25 Jan 2017 23:36:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34567) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cWbnb-0007mm-OU for submit@debbugs.gnu.org; Wed, 25 Jan 2017 23:36:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWbna-0005ld-Cd for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 23:36:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWbnX-0007li-8u for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 23:36:38 -0500 Received: from [89.28.117.31] (port=38708 helo=home.thecybershadow.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWbnX-0007l9-1Q for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 23:36:35 -0500 Received: by home.thecybershadow.net (Postfix, from userid 1000) id 631A5562F7B; Thu, 26 Jan 2017 04:36:29 +0000 (UTC) From: Vladimir Panteleev To: bug-gnu-emacs@gnu.org Subject: [PATCH] Some small bat-mode fixes Date: Thu, 26 Jan 2017 04:36:21 +0000 Message-Id: <20170126043624.14326-1-git@thecybershadow.net> X-Mailer: git-send-email 2.11.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 25 Jan 2017 23:59:23 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) These fix a few issues with fontification and fill-paragraph in bat-mode (used for Windows .bat and .cmd files). Tests included. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 26 00:11:14 2017 Received: (at submit) by debbugs.gnu.org; 26 Jan 2017 05:11:14 +0000 Received: from localhost ([127.0.0.1]:44068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWcL4-0000Lc-0Q for submit@debbugs.gnu.org; Thu, 26 Jan 2017 00:11:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWbnh-0007xv-Qe for submit@debbugs.gnu.org; Wed, 25 Jan 2017 23:36:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWbnb-0007mp-O5 for submit@debbugs.gnu.org; Wed, 25 Jan 2017 23:36:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45427) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cWbnb-0007mg-LK for submit@debbugs.gnu.org; Wed, 25 Jan 2017 23:36:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWbna-0005lb-Bj for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 23:36:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWbnX-0007lg-8a for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 23:36:38 -0500 Received: from [89.28.117.31] (port=38712 helo=home.thecybershadow.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWbnX-0007l8-0y for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 23:36:35 -0500 Received: by home.thecybershadow.net (Postfix, from userid 1000) id 6E801562F7F; Thu, 26 Jan 2017 04:36:29 +0000 (UTC) From: Vladimir Panteleev To: bug-gnu-emacs@gnu.org Subject: [PATCH 2/3] Fix fill-paragraph for comments in bat-mode Date: Thu, 26 Jan 2017 04:36:23 +0000 Message-Id: <20170126043624.14326-3-git@thecybershadow.net> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170126043624.14326-1-git@thecybershadow.net> References: <20170126043624.14326-1-git@thecybershadow.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 26 Jan 2017 00:11:12 -0500 Cc: Vladimir Panteleev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * lisp/progmodes/bat-mode.el: Set comment-start-skip. * test/lisp/progmodes/bat-mode-tests.el: Add test. --- lisp/progmodes/bat-mode.el | 1 + test/lisp/progmodes/bat-mode-tests.el | 14 ++++++++++++++ 2 files changed, 15 insertions(+) diff --git a/lisp/progmodes/bat-mode.el b/lisp/progmodes/bat-mode.el index 77b97ac6ff..a945d37f1d 100644 --- a/lisp/progmodes/bat-mode.el +++ b/lisp/progmodes/bat-mode.el @@ -176,6 +176,7 @@ bat-mode Run script using `bat-run' and `bat-run-args'.\n \\{bat-mode-map}" (setq-local comment-start "rem ") + (setq-local comment-start-skip "rem[ \t]+") (setq-local syntax-propertize-function bat--syntax-propertize) (setq-local font-lock-defaults '(bat-font-lock-keywords nil t)) ; case-insensitive keywords diff --git a/test/lisp/progmodes/bat-mode-tests.el b/test/lisp/progmodes/bat-mode-tests.el index c78827db80..335fc16ffb 100644 --- a/test/lisp/progmodes/bat-mode-tests.el +++ b/test/lisp/progmodes/bat-mode-tests.el @@ -59,5 +59,19 @@ bat-test-fontify (bat-test-fontify "echo !a_b-c{d}e!") "echo !a_b-c{d}e!"))) +(defun bat-test-fill-paragraph (str) + "Return the result of invoking `fill-paragraph' on STR in a `bat-mode' buffer." + (with-temp-buffer + (bat-mode) + (insert str) + (goto-char 1) + (font-lock-ensure) + (fill-paragraph) + (buffer-string))) + +(ert-deftest bat-test-fill-paragraph-comment () + "Test `fill-paragraph' in a comment block." + (should (equal (bat-test-fill-paragraph "rem foo\nrem bar\n") "rem foo bar\n"))) + (provide 'bat-tests) ;;; bat-mode-tests.el ends here -- 2.11.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 26 00:11:14 2017 Received: (at submit) by debbugs.gnu.org; 26 Jan 2017 05:11:14 +0000 Received: from localhost ([127.0.0.1]:44070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWcL4-0000Le-AS for submit@debbugs.gnu.org; Thu, 26 Jan 2017 00:11:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWbnh-0007xw-Qf for submit@debbugs.gnu.org; Wed, 25 Jan 2017 23:36:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWbnb-0007mu-Ol for submit@debbugs.gnu.org; Wed, 25 Jan 2017 23:36:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55497) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cWbnb-0007mh-Lk for submit@debbugs.gnu.org; Wed, 25 Jan 2017 23:36:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45594) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWbna-0005lc-C4 for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 23:36:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWbnX-0007lh-9C for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 23:36:38 -0500 Received: from [89.28.117.31] (port=38710 helo=home.thecybershadow.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWbnX-0007lA-1B for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 23:36:35 -0500 Received: by home.thecybershadow.net (Postfix, from userid 1000) id 7447C562F81; Thu, 26 Jan 2017 04:36:29 +0000 (UTC) From: Vladimir Panteleev To: bug-gnu-emacs@gnu.org Subject: [PATCH 3/3] Improve iteration variable fontification in bat-mode Date: Thu, 26 Jan 2017 04:36:24 +0000 Message-Id: <20170126043624.14326-4-git@thecybershadow.net> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170126043624.14326-1-git@thecybershadow.net> References: <20170126043624.14326-1-git@thecybershadow.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 26 Jan 2017 00:11:12 -0500 Cc: Vladimir Panteleev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * lisp/progmodes/bat-mode.el: Improve fontification accuracy of iteration/positional variables. * test/lisp/progmodes/bat-mode-tests.el: Add tests. --- lisp/progmodes/bat-mode.el | 7 +++++-- test/lisp/progmodes/bat-mode-tests.el | 9 +++++++++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/lisp/progmodes/bat-mode.el b/lisp/progmodes/bat-mode.el index a945d37f1d..1dd2e3757e 100644 --- a/lisp/progmodes/bat-mode.el +++ b/lisp/progmodes/bat-mode.el @@ -84,10 +84,13 @@ bat-font-lock-keywords . 'bat-label-face) ("\\_<\\(defined\\|set\\)\\_>[ \t]*\\(\\(\\sw\\|\\s_\\)+\\)" (2 font-lock-variable-name-face)) - ("%\\(\\(\\sw\\|\\s_\\)+\\)%?" + ("%\\(\\(\\sw\\|\\s_\\)+\\)%" (1 font-lock-variable-name-face)) - ("!\\(\\(\\sw\\|\\s_\\)+\\)!?" ; delayed-expansion !variable! + ("!\\(\\(\\sw\\|\\s_\\)+\\)!" ; delayed-expansion !variable! (1 font-lock-variable-name-face)) + ("%%\\(?:~[adfnpstxz]*\\(?:\\$\\(\\(?:\\sw\\|\\s_\\)+\\):\\)?\\)?\\([]!#$&-:?-[_-{}~]\\)" + (1 font-lock-variable-name-face nil t) ; PATH expansion + (2 font-lock-variable-name-face)) ; iteration variable or positional parameter ("[ =][-/]+\\(\\w+\\)" (1 font-lock-type-face append)) (,(concat "\\_<" (regexp-opt COMMANDS) "\\_>") . font-lock-builtin-face) diff --git a/test/lisp/progmodes/bat-mode-tests.el b/test/lisp/progmodes/bat-mode-tests.el index 335fc16ffb..565718eea4 100644 --- a/test/lisp/progmodes/bat-mode-tests.el +++ b/test/lisp/progmodes/bat-mode-tests.el @@ -59,6 +59,15 @@ bat-test-fontify (bat-test-fontify "echo !a_b-c{d}e!") "echo !a_b-c{d}e!"))) +(ert-deftest bat-test-fontification-iter-var-1 () + "Test fontification of iteration variables." + (should + (equal + (bat-test-fontify "echo %%a\necho %%~dp1\necho %%~$PATH:I") + "echo %%a +echo %%~dp1 +echo %%~$PATH:I"))) + (defun bat-test-fill-paragraph (str) "Return the result of invoking `fill-paragraph' on STR in a `bat-mode' buffer." (with-temp-buffer -- 2.11.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 26 00:11:15 2017 Received: (at submit) by debbugs.gnu.org; 26 Jan 2017 05:11:15 +0000 Received: from localhost ([127.0.0.1]:44072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWcL4-0000Ll-Jl for submit@debbugs.gnu.org; Thu, 26 Jan 2017 00:11:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54657) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWbni-0007xy-36 for submit@debbugs.gnu.org; Wed, 25 Jan 2017 23:36:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWbnb-0007nA-Ue for submit@debbugs.gnu.org; Wed, 25 Jan 2017 23:36:41 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42395) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cWbnb-0007n4-S1 for submit@debbugs.gnu.org; Wed, 25 Jan 2017 23:36:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWbna-0005la-Bi for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 23:36:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWbnX-0007lu-9Y for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 23:36:38 -0500 Received: from [89.28.117.31] (port=38720 helo=home.thecybershadow.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWbnX-0007lB-1X for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 23:36:35 -0500 Received: by home.thecybershadow.net (Postfix, from userid 1000) id 673FD562F7D; Thu, 26 Jan 2017 04:36:29 +0000 (UTC) From: Vladimir Panteleev To: bug-gnu-emacs@gnu.org Subject: [PATCH 1/3] Improve fontification of variables in bat-mode Date: Thu, 26 Jan 2017 04:36:22 +0000 Message-Id: <20170126043624.14326-2-git@thecybershadow.net> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170126043624.14326-1-git@thecybershadow.net> References: <20170126043624.14326-1-git@thecybershadow.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 26 Jan 2017 00:11:12 -0500 Cc: Vladimir Panteleev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * lisp/progmodes/bat-mode.el: Match word and symbol constituents when looking for variable names to fontify; also, correct the syntax table and mark the equal sign (=) character as punctuation. * test/lisp/progmodes/bat-mode-tests.el: Add test script for bat-mode. --- lisp/progmodes/bat-mode.el | 7 ++-- test/lisp/progmodes/bat-mode-tests.el | 63 +++++++++++++++++++++++++++++++++++ 2 files changed, 67 insertions(+), 3 deletions(-) create mode 100644 test/lisp/progmodes/bat-mode-tests.el diff --git a/lisp/progmodes/bat-mode.el b/lisp/progmodes/bat-mode.el index 156331cf86..77b97ac6ff 100644 --- a/lisp/progmodes/bat-mode.el +++ b/lisp/progmodes/bat-mode.el @@ -82,11 +82,11 @@ bat-font-lock-keywords (2 font-lock-constant-face t)) ("^:[^:].*" . 'bat-label-face) - ("\\_<\\(defined\\|set\\)\\_>[ \t]*\\(\\w+\\)" + ("\\_<\\(defined\\|set\\)\\_>[ \t]*\\(\\(\\sw\\|\\s_\\)+\\)" (2 font-lock-variable-name-face)) - ("%\\(\\w+\\)%?" + ("%\\(\\(\\sw\\|\\s_\\)+\\)%?" (1 font-lock-variable-name-face)) - ("!\\(\\w+\\)!?" ; delayed-expansion !variable! + ("!\\(\\(\\sw\\|\\s_\\)+\\)!?" ; delayed-expansion !variable! (1 font-lock-variable-name-face)) ("[ =][-/]+\\(\\w+\\)" (1 font-lock-type-face append)) @@ -130,6 +130,7 @@ bat-mode-syntax-table (modify-syntax-entry ?{ "_" table) (modify-syntax-entry ?} "_" table) (modify-syntax-entry ?\\ "." table) + (modify-syntax-entry ?= "." table) table)) (defconst bat--syntax-propertize diff --git a/test/lisp/progmodes/bat-mode-tests.el b/test/lisp/progmodes/bat-mode-tests.el new file mode 100644 index 0000000000..c78827db80 --- /dev/null +++ b/test/lisp/progmodes/bat-mode-tests.el @@ -0,0 +1,63 @@ +;;; bat-mode-tests.el --- Tests for bat-mode.el -*- lexical-binding: t; -*- + +;; Copyright (C) 2017 Free Software Foundation, Inc. + +;; Author: Vladimir Panteleev +;; Keywords: + +;; This file is part of GNU Emacs. + +;; GNU Emacs is free software: you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; GNU Emacs is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with GNU Emacs. If not, see . + +;;; Commentary: + +;; + +;;; Code: + +(require 'ert) +(require 'bat-mode) +(require 'htmlfontify) + +(defun bat-test-fontify (str) + "Fontify STR in `bat-mode' to a HTML string using `htmlfontify' and return it." + (with-temp-buffer + (insert str) + (bat-mode) + (let ((hfy-optimizations '(body-text-only merge-adjacent-tags))) + (with-current-buffer (htmlfontify-buffer) (buffer-string))))) + +(ert-deftest bat-test-fontification-var-decl () + "Test fontification of variable declarations." + (should + (equal + (bat-test-fontify "set a_b-c{d}e=f") + "set a_b-c{d}e=f"))) + +(ert-deftest bat-test-fontification-var-exp () + "Test fontification of variable expansions." + (should + (equal + (bat-test-fontify "echo %a_b-c{d}e%") + "echo %a_b-c{d}e%"))) + +(ert-deftest bat-test-fontification-var-delayed-exp () + "Test fontification of delayed variable expansions." + (should + (equal + (bat-test-fontify "echo !a_b-c{d}e!") + "echo !a_b-c{d}e!"))) + +(provide 'bat-tests) +;;; bat-mode-tests.el ends here -- 2.11.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 27 04:57:42 2017 Received: (at 25541) by debbugs.gnu.org; 27 Jan 2017 09:57:42 +0000 Received: from localhost ([127.0.0.1]:47019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cX3Hq-0006hr-Dn for submit@debbugs.gnu.org; Fri, 27 Jan 2017 04:57:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cX3Hp-0006hg-AW for 25541@debbugs.gnu.org; Fri, 27 Jan 2017 04:57:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cX3Hf-0005Rn-5q for 25541@debbugs.gnu.org; Fri, 27 Jan 2017 04:57:36 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60878) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cX3Hf-0005Rh-2u; Fri, 27 Jan 2017 04:57:31 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4091 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cX3He-0002RU-6h; Fri, 27 Jan 2017 04:57:30 -0500 Date: Fri, 27 Jan 2017 11:57:19 +0200 Message-Id: <83fuk425c0.fsf@gnu.org> From: Eli Zaretskii To: Vladimir Panteleev In-reply-to: <20170126043624.14326-1-git@thecybershadow.net> (message from Vladimir Panteleev on Thu, 26 Jan 2017 04:36:21 +0000) Subject: Re: bug#25541: [PATCH] Some small bat-mode fixes References: <20170126043624.14326-1-git@thecybershadow.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.2 (--------) X-Debbugs-Envelope-To: 25541 Cc: 25541@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.2 (--------) > From: Vladimir Panteleev > Date: Thu, 26 Jan 2017 04:36:21 +0000 > > These fix a few issues with fontification and fill-paragraph in > bat-mode (used for Windows .bat and .cmd files). Tests included. Thanks. These look good to me, but the sum total of the code exceeds the amount we can accept without an assignment of copyright to the FSF. Would you be willing to do the legal paperwork needed for that? if you will, I'll send you the form to start that rolling (off-list). From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 27 05:03:07 2017 Received: (at 25541) by debbugs.gnu.org; 27 Jan 2017 10:03:07 +0000 Received: from localhost ([127.0.0.1]:47027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cX3N5-0006r0-8O for submit@debbugs.gnu.org; Fri, 27 Jan 2017 05:03:07 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:37199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cX3N3-0006qU-Hv for 25541@debbugs.gnu.org; Fri, 27 Jan 2017 05:03:05 -0500 Received: by mail-wm0-f54.google.com with SMTP id c206so128599762wme.0 for <25541@debbugs.gnu.org>; Fri, 27 Jan 2017 02:03:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=GZY6GEXYS5/yrYQd9Mlnn5oeuWIo4XFYQQS17EQ7fuE=; b=fHVzeqWv2ANzQpUUXGDIQWEJ7ouc7W6x6ThMxaVgrmVJcYq6/0FCfdE/7L0wz3Dw8g 9e2wbpQo5LoWE5kGEsnC58z8NdfQByBeUTqLhpiN31PoLEzTDcTNgV5vDduL81zkO4g5 Xt0zVJxNE8SbWu1xFbvLBYKbfEW6SWNPvDo3zj+kYZynyEblBVMnLwr/zScOkSFjlpkr THMvagG3Fx3Mkp8tbENXQhek5xTO2WuB+za6aYafVL0ULTa8Evnbt95TZ2RxIpfXMXn6 lA/oYCmIS2FETGyAeJuLG888+hZUj5b+wwW83sKJaECgQeauScRmlCxwMOtGwdo9tUxb Ba9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=GZY6GEXYS5/yrYQd9Mlnn5oeuWIo4XFYQQS17EQ7fuE=; b=UDkodA9qmZtbTHxiyZlh6PoThzA/iADwi24oF3KjryG3IbRffvi3fsOs80s2m+NNb/ BKvGpStWAokax4RZ+LJjG/0FiKzXmF1gJklb28OCS9f6LqeExzTFo+NqnRVMHqVGHU2P ipmAAcl1obsfYIaIszBnRe1p3nizTMsWncymmqZGD4MmfBlPlAMs56+IAW/yRPpCLFbv l8sjuLOFHESGOu1v9y7+iHYIfxohOLxw1UNdvXX9kYNMu+q69xZjF5GooBLhJ11P8J/0 FJxiCTPNsQqhoECKOelSjKz59OOIWhev6uv7J3ESsimqmsGgbO4+Orc0yXKXjOw/nIiZ iaTQ== X-Gm-Message-State: AIkVDXJ/1CXKsk9X9csXBhBhP+e6ZDOI6M1dz4+jM9fO7owAzyCQRiF5DGlJBDcy3NKI9A== X-Received: by 10.223.170.221 with SMTP id i29mr8161078wrc.131.1485511379378; Fri, 27 Jan 2017 02:02:59 -0800 (PST) Received: from home.thecybershadow.net ([89.28.117.31]) by smtp.gmail.com with ESMTPSA id 17sm7023964wru.16.2017.01.27.02.02.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Jan 2017 02:02:58 -0800 (PST) Subject: Re: bug#25541: [PATCH] Some small bat-mode fixes To: Eli Zaretskii , Vladimir Panteleev References: <20170126043624.14326-1-git@thecybershadow.net> <83fuk425c0.fsf@gnu.org> From: Vladimir Panteleev Message-ID: <22d87232-790a-7200-b403-a17679c7a2c4@gmail.com> Date: Fri, 27 Jan 2017 10:02:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <83fuk425c0.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25541 Cc: 25541@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Hi Eli, Yes, I am interested in contributing to Emacs in the future :) Please hook me up. On 2017-01-27 09:57, Eli Zaretskii wrote: >> From: Vladimir Panteleev >> Date: Thu, 26 Jan 2017 04:36:21 +0000 >> >> These fix a few issues with fontification and fill-paragraph in >> bat-mode (used for Windows .bat and .cmd files). Tests included. > > Thanks. These look good to me, but the sum total of the code exceeds > the amount we can accept without an assignment of copyright to the > FSF. Would you be willing to do the legal paperwork needed for that? > if you will, I'll send you the form to start that rolling (off-list). > -- Best regards, Vladimir From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 27 05:34:46 2017 Received: (at 25541) by debbugs.gnu.org; 27 Jan 2017 10:34:46 +0000 Received: from localhost ([127.0.0.1]:47047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cX3rh-0007a1-PR for submit@debbugs.gnu.org; Fri, 27 Jan 2017 05:34:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cX3rg-0007Zp-9z for 25541@debbugs.gnu.org; Fri, 27 Jan 2017 05:34:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cX3rX-0001u8-U3 for 25541@debbugs.gnu.org; Fri, 27 Jan 2017 05:34:39 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34957) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cX3rX-0001tz-Rv; Fri, 27 Jan 2017 05:34:35 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4125 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cX3rX-0004YK-4n; Fri, 27 Jan 2017 05:34:35 -0500 Date: Fri, 27 Jan 2017 12:34:24 +0200 Message-Id: <83bmus23m7.fsf@gnu.org> From: Eli Zaretskii To: Vladimir Panteleev In-reply-to: <22d87232-790a-7200-b403-a17679c7a2c4@gmail.com> (message from Vladimir Panteleev on Fri, 27 Jan 2017 10:02:57 +0000) Subject: Re: bug#25541: [PATCH] Some small bat-mode fixes References: <20170126043624.14326-1-git@thecybershadow.net> <83fuk425c0.fsf@gnu.org> <22d87232-790a-7200-b403-a17679c7a2c4@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.2 (--------) X-Debbugs-Envelope-To: 25541 Cc: git@thecybershadow.net, 25541@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.2 (--------) > Cc: 25541@debbugs.gnu.org > From: Vladimir Panteleev > Date: Fri, 27 Jan 2017 10:02:57 +0000 > > Hi Eli, > > Yes, I am interested in contributing to Emacs in the future :) Please > hook me up. The form was sent off-list. When the paperwork is done, we will install your changes. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 10 04:30:13 2017 Received: (at 25541-done) by debbugs.gnu.org; 10 Feb 2017 09:30:13 +0000 Received: from localhost ([127.0.0.1]:33812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cc7Wv-0002nZ-CI for submit@debbugs.gnu.org; Fri, 10 Feb 2017 04:30:13 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cc7Wt-0002nL-Sw for 25541-done@debbugs.gnu.org; Fri, 10 Feb 2017 04:30:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cc7Wj-0008Rg-S8 for 25541-done@debbugs.gnu.org; Fri, 10 Feb 2017 04:30:06 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cc7Wj-0008Rc-Pf; Fri, 10 Feb 2017 04:30:01 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4562 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cc7Wi-0005OO-V8; Fri, 10 Feb 2017 04:30:01 -0500 Date: Fri, 10 Feb 2017 11:30:08 +0200 Message-Id: <83a89u4cm7.fsf@gnu.org> From: Eli Zaretskii To: Vladimir Panteleev In-reply-to: <20170126043624.14326-1-git@thecybershadow.net> (message from Vladimir Panteleev on Thu, 26 Jan 2017 04:36:21 +0000) Subject: Re: bug#25541: [PATCH] Some small bat-mode fixes References: <20170126043624.14326-1-git@thecybershadow.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25541-done Cc: 25541-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Vladimir Panteleev > Date: Thu, 26 Jan 2017 04:36:21 +0000 > > These fix a few issues with fontification and fill-paragraph in > bat-mode (used for Windows .bat and .cmd files). Tests included. Thanks, pushed to the master branch. In the future, please make sure the commit log entries indicate the function in which each change was made. E.g., here: * lisp/progmodes/bat-mode.el: Set comment-start-skip. the function is bat-mode, so the log entry should have said * lisp/progmodes/bat-mode.el (bat-mode): Set comment-start-skip. You can use "C-x 4 a" to format the commit messages for you. From unknown Wed Jun 25 02:05:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 10 Mar 2017 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator