GNU bug report logs - #25529
25.1.90; js-mode: Regexp literal with unbalanced brackets breaks font-lock

Previous Next

Package: emacs;

Reported by: Mikhail Gusarov <mikhail <at> hola.org>

Date: Wed, 25 Jan 2017 11:15:02 UTC

Severity: minor

Found in version 25.1.90

Done: Tom Tromey <tom <at> tromey.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Tom Tromey <tom <at> tromey.com>
Cc: 25529 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: bug#25529: diagnosis and one approach to a fix
Date: Fri, 10 Feb 2017 22:45:54 -0500

> -(defun js-syntax-propertize-regexp (end)
> +(defun js-syntax-propertize-regexp ()

Removing the `end` argument is fundamentally wrong.  It's OK to play it
fast-and-loose and ignore that argument, but the function *should* keep
the buffer untouched after `end`.

> +        (put-text-property (match-beginning 1) (match-end 1)
                                                  ^^^^^^^^^^^^^
                                              (min end (match-end 1))

should do it.


        Stefan
This bug report was last modified 8 years and 180 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.