GNU bug report logs - #25529
25.1.90; js-mode: Regexp literal with unbalanced brackets breaks font-lock

Previous Next

Full log

View this message in rfc822 format

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Tom Tromey <tom <at> tromey.com>
Cc: 25529 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Subject: bug#25529: diagnosis and one approach to a fix
Date: Tue, 7 Feb 2017 04:20:40 +0200

On 06.02.2017 19:27, Tom Tromey wrote:

> Yep, adding a goto-char at the end of the function fixed this.
> Thanks for pointing that out; I'll add a test case for it.

Thanks.

> I think I understand combining the regexps.  But what does using a simple
> regexp for the closer mean?

Simple handler (not regexp), for the group corresponding to the closer 
(what's called a HIGHLIGHTn in syntax-propertize-rules docstring). The 
string "\"/", probably.

> Also, what is the purpose of the first call to
> js-syntax-propertize-regexp in js-syntax-propertize?

I'm not sure. Normally, that helps deal with multiline literals, but 
regexps in JavaScript are single-line. Maybe Stefan remembers.

Or maybe it was a result of confusion: the code deleted in 6cd18349 
includes this mistaken sentence: "XXX: Javascript can continue a regexp 
literal across lines so long as the newline is escaped with \."

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.