GNU bug report logs - #25529
25.1.90; js-mode: Regexp literal with unbalanced brackets breaks font-lock

Previous Next

Full log

Message #20 received at 25529 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Tom Tromey <tom <at> tromey.com>
Cc: 25529 <at> debbugs.gnu.org
Subject: Re: bug#25529: diagnosis and one approach to a fix
Date: Mon, 6 Feb 2017 03:12:31 +0200

Hey Tom,

On 05.02.2017 20:43, Tom Tromey wrote:
> Tom> Another way is to use a regexp, see appended.
> Tom> I'll try to write a test for this soon.
> 
> Now with a test.

This is very good, thank you. Here's just one example I've come so far 
that works with the old code, but not with yours:

let x = /[/]/;

And that's probably just because the new js-syntax-propertize-regexp 
doesn't move point forward after matching (the current one leaves it 
after the closing slash), because the regexp in js-syntax-propertize is 
too primitive.

We could try to combine the regexps together, though. Then we'd move the 
syntax-ppss status check inside the rule for the opening delimiter, and 
use a simple one for the closer.

> +  "Regular expression matching the body of a JavaScript regexp literal.")

Maybe remove "the body of". The regexp matches the delimiters as well.

Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.