GNU bug report logs - #25525
25.1.90; add color highlighting to css mode

Previous Next

Package: emacs;

Reported by: Tom Tromey <tom <at> tromey.com>

Date: Wed, 25 Jan 2017 08:08:01 UTC

Severity: wishlist

Tags: patch

Found in version 25.1.90

Done: Tom Tromey <tom <at> tromey.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Tom Tromey <tom <at> tromey.com>
To: Simen Heggestøyl <simenheg <at> gmail.com>
Cc: 25525 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, Tom Tromey <tom <at> tromey.com>
Subject: bug#25525: 25.1.90; add color highlighting to css mode
Date: Sat, 04 Mar 2017 19:42:34 -0700

>>>>> "Simen" == Simen Heggestøyl <simenheg <at> gmail.com> writes:

Simen> There is also a test failure when you rebase the patch on the latest
Simen> master due to the changes in 7b00e956b4. It can be fixed by passing 2
Simen> as the last argument to `color-rgb-to-hex' in `css--hsl-color'.

This happens due to the change in 7b00e956b485d8ade03c870cbdd0ae086348737b,
which changed color-name-to-rgb in a backward-incompatible way.
Eli, you made this change -- it seems to me that it would be safer if it
defaulted to 2 digits, which was how it worked previously.  This would
be backward-compatible and allow the new functionality as well.

Tom
This bug report was last modified 8 years and 80 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.