GNU bug report logs - #25524
26.0.50; diff-mode is broken

Previous Next

Full log

Message #16 received at 25524 <at> debbugs.gnu.org (full text, mbox):

From: Dima Kogan <dima <at> secretsauce.net>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: 25524 <at> debbugs.gnu.org, Tino Calancha <tino.calancha <at> gmail.com>
Subject: Re: bug#25524: 26.0.50; diff-mode is broken
Date: Wed, 25 Jan 2017 13:25:04 -0800

Noam Postavsky <npostavs <at> users.sourceforge.net> writes:

> On Wed, Jan 25, 2017 at 11:32 AM, Tino Calancha <tino.calancha <at> gmail.com> wrote:
>>  ;; "index ", "old mode", "new mode", "new file mode" and
>> -;; "deleted file mode" are output by git-diff.
>> +;; "deleted file mode" are output by git-diff; "Index: " and
>> +;; "========..." by SVN.
>>  (defconst diff-file-junk-re
>> -  "diff \\|index \\|\\(?:deleted file\\|new\\(?: file\\)?\\|old\\) mode\\|=== modified file")
>> +  (concat "Index: \\|" (make-string 67 ?=) "\\|"
>> +          "diff \\|index \\|\\(?:deleted file\\|new\\(?: file\\)?\\|old\\) mode\\|=== modified file"))
>
> Is it safe to assume exactly 67 "="? Maybe it would be better to use
> something like "=\\{20,\\}", i.e. a sequence of 20 or more "=".

More broadly, are we sure we need to be touching this? The previous
approach and the one before that worked with the stock regexes.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.