GNU bug report logs - #25524
26.0.50; diff-mode is broken

Previous Next

Package: emacs;

Reported by: Dima Kogan <dima <at> secretsauce.net>

Date: Wed, 25 Jan 2017 06:43:01 UTC

Severity: normal

Found in version 26.0.50

Done: Tino Calancha <tino.calancha <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #13 received at 25524 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Tino Calancha <tino.calancha <at> gmail.com>
Cc: 25524 <at> debbugs.gnu.org, Dima Kogan <dima <at> secretsauce.net>
Subject: Re: bug#25524: 26.0.50; diff-mode is broken
Date: Wed, 25 Jan 2017 15:47:53 -0500
On Wed, Jan 25, 2017 at 11:32 AM, Tino Calancha <tino.calancha <at> gmail.com> wrote:
>  ;; "index ", "old mode", "new mode", "new file mode" and
> -;; "deleted file mode" are output by git-diff.
> +;; "deleted file mode" are output by git-diff; "Index: " and
> +;; "========..." by SVN.
>  (defconst diff-file-junk-re
> -  "diff \\|index \\|\\(?:deleted file\\|new\\(?: file\\)?\\|old\\) mode\\|=== modified file")
> +  (concat "Index: \\|" (make-string 67 ?=) "\\|"
> +          "diff \\|index \\|\\(?:deleted file\\|new\\(?: file\\)?\\|old\\) mode\\|=== modified file"))

Is it safe to assume exactly 67 "="? Maybe it would be better to use
something like "=\\{20,\\}", i.e. a sequence of 20 or more "=".




This bug report was last modified 8 years and 175 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.