GNU bug report logs - #25508
Git hook shebangs should not be rewritten

Previous Next

Full log

Message #12 received at 25508 <at> debbugs.gnu.org (full text, mbox):

From: Miguel Ángel Arruga Vivas <rosen644835 <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 25304 <at> debbugs.gnu.org, 25508 <at> debbugs.gnu.org, John Darrington <jmd <at> gnu.org>
Subject: Re: bug#25508: Git hook shebangs should not be rewritten
Date: Mon, 16 Nov 2020 19:10:59 +0100

[Message part 1 (text/plain, inline)]

Sorry, I've closed this with the libtool one.

The attached patch fixes this one too, should I push it to master (as
the last change for git) or to core-updates or staging (as it might seem
looking at the dependencies)?

Happy hacking!
Miguel

[0001-gnu-git-Add-phase-to-restore-hooks-shebang.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> From: John Darrington <john <at> darrington.wattle.id.au>
> Subject: Not patching shebang in git hook samples ?
> To: guix-devel <at> gnu.org
> Date: Sun, 22 Jan 2017 14:01:24 +0100 (3 years, 42 weeks, 4 days ago)
>
> The git package ships with a number of sample hook files.  These are shell scripts and
> therefore the #!/bin/sh line gets substituted at  build time.
>
> However these files get installed into every git repostory that is created, and users
> are invited to use them as templates for their own hooks.
>
> This will be fine until both git and bash are updated.  Now the original bash is free
> to be garbage collected.  If that happens, the path: 
> #!/gnu/store/qkw4zrwfybxww8f56nkb6hggxambk89b-bash-4.4.0/bin/sh
> will no longer exist.
>
> I suggest what we turn off the shebang patching for the files in share/templates for git.
>
> J'

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.