From unknown Wed Jun 18 23:01:02 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#25508 <25508@debbugs.gnu.org> To: bug#25508 <25508@debbugs.gnu.org> Subject: Status: Git hook shebangs should not be rewritten Reply-To: bug#25508 <25508@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:01:02 +0000 retitle 25508 Git hook shebangs should not be rewritten reassign 25508 guix submitter 25508 Leo Famulari severity 25508 important thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 22 18:26:04 2017 Received: (at submit) by debbugs.gnu.org; 22 Jan 2017 23:26:04 +0000 Received: from localhost ([127.0.0.1]:38568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cVRWO-0001VM-Fq for submit@debbugs.gnu.org; Sun, 22 Jan 2017 18:26:04 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cVRWN-0001Us-7o for submit@debbugs.gnu.org; Sun, 22 Jan 2017 18:26:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVRWH-0008E4-3M for submit@debbugs.gnu.org; Sun, 22 Jan 2017 18:25:58 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55220) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cVRWH-0008Dv-0O for submit@debbugs.gnu.org; Sun, 22 Jan 2017 18:25:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVRWF-00010U-SQ for bug-guix@gnu.org; Sun, 22 Jan 2017 18:25:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVRWB-0008D2-SX for bug-guix@gnu.org; Sun, 22 Jan 2017 18:25:55 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:42114) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cVRWB-0008Cw-NS; Sun, 22 Jan 2017 18:25:51 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 144312074A; Sun, 22 Jan 2017 18:25:51 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Sun, 22 Jan 2017 18:25:51 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=famulari.name; h= cc:content-type:date:from:message-id:mime-version:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=5RU hTP1uE/5KIFRw7ZazniPQYno=; b=z18fz0iyKU8DZL9xQ+sQxCgbGoU7PFCBOvC 64WxbEvMsCCVpPqVYKesFztDFyxMT4EMnpN9cy1woejol8CmGPHqEiPbioEWNYTr ILapsHIkBt+y3xR2M5OthAwPDFXVbt84WwIG98pjZIxb70SFfaQ5Is5ui2gwSO2y cfU4YsKc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=smtpout; bh=5RUhTP1uE/5KIFRw7ZazniPQYno=; b=ZPHFC THQzjZ/PApyJTlIiEtvnPiT2pzxnmyzfBf/e73OjrLFIKSyZECMSoonqyDDJRA/O MrYn3hYSLU27G2OVPKecbSGQYs7Nxr95Sq0aAALikThifH1S4Ff8NOBwLh+Oa4iN dDDczhRG/fdmIHsWdfflLSgo6iTEn/sVZoaxv0= X-ME-Sender: X-Sasl-enc: FeVbWWmvuGtJkKI1zfpxrG99DcgiaOAdKY3iYl3Jr4ex 1485127550 Received: from localhost (c-73-188-17-148.hsd1.pa.comcast.net [73.188.17.148]) by mail.messagingengine.com (Postfix) with ESMTPA id BF99A24077; Sun, 22 Jan 2017 18:25:50 -0500 (EST) Date: Sun, 22 Jan 2017 18:25:50 -0500 From: Leo Famulari To: bug-guix@gnu.org Subject: Git hook shebangs should not be rewritten Message-ID: <20170122232550.GB27876@jasmine> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="liOOAslEiF7prFVr" Content-Disposition: inline User-Agent: Mutt/1.7.2 (2016-11-26) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit Cc: John Darrington X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) --liOOAslEiF7prFVr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable ----- Forwarded message from John Darrington = ----- Date: Sun, 22 Jan 2017 14:01:24 +0100 =46rom: John Darrington To: guix-devel@gnu.org Subject: Not patching shebang in git hook samples ? User-Agent: Mutt/1.5.23 (2014-03-12) The git package ships with a number of sample hook files. These are shell = scripts and therefore the #!/bin/sh line gets substituted at build time. However these files get installed into every git repostory that is created,= and users are invited to use them as templates for their own hooks. This will be fine until both git and bash are updated. Now the original ba= sh is free to be garbage collected. If that happens, the path:=20 #!/gnu/store/qkw4zrwfybxww8f56nkb6hggxambk89b-bash-4.4.0/bin/sh will no longer exist. I suggest what we turn off the shebang patching for the files in share/temp= lates for git. J' --=20 Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. ----- End forwarded message ----- --liOOAslEiF7prFVr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAliFP3kACgkQJkb6MLrK fwg9Jg/9HE3EmpVTW6Uq5oYTegpmoq1VkXZ6OBFGkeBx4Xjv6bJwwpxWwKxcuxTY jmw/JuvjHCW2TCcLEUNHv5a1xMRZ69dUWzppB9JNWO63h+Qku6rA97CH21fyPpNh j5gGkV9WQnDi1BXOOggXQ0wYbkOTfa0WzCabdxcvf0CeoZRSYflq6kLothZ4pUF9 XED6xCnNxYjPYGlzjdc9LXYpFuqOOLJrX60xL5I0cibfjbpcK41/pk55YKI0LESp xNzqKmrS4x2xSJFeQHAsnrLsgModpZPP0+6nMI0NhePs+3d5T3Jaa9imfmNDwy4M DC6gRy8X9kVg4YU/ljklA5kKDMp/bGP2DHc3KsvgzEu9RjxgeGMRImZnFBqbWFAJ k3FuOm8VymlkKsOP793ah4QDi4GL4JFrIzxwBF9OY8/yNkiqQHk0R+OCK4xjScBU WOBCdOLsdkAUgAhQbX/yL4Cklc2YU6+6qY0WwFke/eJP2vn1lOtABQoxxnZzOOhw hgPMMY4LIldu9xpNyu4zQ6F8s/rmi+n1Vtxr2q+ZKf4rKD6V/z1+Qp+HlDQ7YGXl /01PwkXKNqKeyz6VogLXwfLJkGbPjhQvnI/9aQA0I3uVMyz5elvYT+qXt09+aZJn x5JQ2NLMCki4zOYf0dkeDbfAr5lfBlUowEt5tjfgUkmvmwXNBmA= =/fnN -----END PGP SIGNATURE----- --liOOAslEiF7prFVr-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 18 16:31:32 2020 Received: (at control) by debbugs.gnu.org; 18 Mar 2020 20:31:32 +0000 Received: from localhost ([127.0.0.1]:41471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEfLf-0006Jh-Su for submit@debbugs.gnu.org; Wed, 18 Mar 2020 16:31:32 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:57806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEfLe-0006JQ-4P for control@debbugs.gnu.org; Wed, 18 Mar 2020 16:31:30 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jEfLU-0002EE-3x for control@debbugs.gnu.org; Wed, 18 Mar 2020 16:31:20 -0400 Date: Wed, 18 Mar 2020 16:31:19 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net To: control@debbugs.gnu.org Subject: Merging issues for not patching some shebang in examples Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) reopen 25304 severity 25304 important severity 25508 important merge 25508 25304 26749 retitle 26749 mask files from shebang patcher (git, libtool and stagit) From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 18 16:38:00 2020 Received: (at control) by debbugs.gnu.org; 18 Mar 2020 20:38:00 +0000 Received: from localhost ([127.0.0.1]:41477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEfRw-0006U8-LK for submit@debbugs.gnu.org; Wed, 18 Mar 2020 16:38:00 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:57850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEfRv-0006Tp-6E for control@debbugs.gnu.org; Wed, 18 Mar 2020 16:37:59 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jEfRp-0002PT-OA for control@debbugs.gnu.org; Wed, 18 Mar 2020 16:37:53 -0400 Date: Wed, 18 Mar 2020 16:37:53 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net To: control@debbugs.gnu.org Subject: Merge bugs related to masking files from shebang patcher Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) unarchive 25304 reopen 25304 severity 25304 important merge 25508 25304 26749 thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 13:11:29 2020 Received: (at 25508) by debbugs.gnu.org; 16 Nov 2020 18:11:29 +0000 Received: from localhost ([127.0.0.1]:57152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keiyP-0007ni-5x for submit@debbugs.gnu.org; Mon, 16 Nov 2020 13:11:29 -0500 Received: from mail-wm1-f52.google.com ([209.85.128.52]:37618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keiyK-0007nI-7d; Mon, 16 Nov 2020 13:11:25 -0500 Received: by mail-wm1-f52.google.com with SMTP id h21so185470wmb.2; Mon, 16 Nov 2020 10:11:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=t6mHTqOpjD0Rw+3MOX/YWm9ZH4LZHHwtmHBIDD7SnBY=; b=hSyVgf7pzqVA6Rzuyd+oyVq1u99q4I5irhp9VhO7hmy1o17sEEx90fEmXtHTtHhdee JGHQUT8i6wYb6Ho2WnNtuCywPDJ5gj1xgJCu2Rw0Qw5Zo+mliT3P1f/1vi5Mt00fJRhT mJDD7fH46idXIB+RWVGZjSDrs2ypnPTNdos8IO73st5VaXhn18UITemBPMgtw5Z8i6jD +yxGW+QE0OkGqgtM1RAl3p8FDE0AfKDph0j34arwP9wWPzuqC7aiYbVc8XbY5TiF/Zcf hNJjPe6kMhM/nckdAJIxnINZjHzERU75zdCEKUjL6WkrgejvFJqx8kGSZ0TgYiSuE8l5 T5lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=t6mHTqOpjD0Rw+3MOX/YWm9ZH4LZHHwtmHBIDD7SnBY=; b=Z07+gh/lQ79kDIXAtlAvbvLO4O6uP/jAJxDotzmy5qUEpTMl17NlOOkzfmoR1sk44J lgnAZpoKr8t0fFgyNtQaX8E/zLq1piKW6Q2SgFrGLwszzDtRoQlfDdkAuxkG9mWTKQSd D6uzzJthXIPBaeISjnA7CI3cYkolIFRAgceO2FxQCIpUzJbtvK5XyD7LBrbCXX4fazor RuqTpwNMntenqIHv1RDBxBRZz57Cpf5mNQdniPyZHBz6wGddvSSi6T2YcQFvsBrwbmva jj8kTUOYHTEn6XrwIUmxdetOFeZ4QaRpN+L5IMymaKwHVbJpRz/orIFLOT9Pa7KQ+bkP fxkw== X-Gm-Message-State: AOAM530oURmHb4shKfbt1KVGMBfsG3kffjwrIyIuFqBx11CxtlPoEWWv 6iM6JoMMG+xXyDldL55OlDQ= X-Google-Smtp-Source: ABdhPJzHlpJ8yFO8TraNqp/sqX9kJAQvjgHKmbH5dxwo7oYbbdtUf3dI92t+/i6GbGl4FeajXwAoiw== X-Received: by 2002:a7b:ce99:: with SMTP id q25mr131738wmj.35.1605550278448; Mon, 16 Nov 2020 10:11:18 -0800 (PST) Received: from unfall (20.134.94.90.dynamic.jazztel.es. [90.94.134.20]) by smtp.gmail.com with ESMTPSA id b8sm25669015wrv.57.2020.11.16.10.11.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 10:11:17 -0800 (PST) From: =?utf-8?Q?Miguel_=C3=81ngel_Arruga_Vivas?= To: Leo Famulari Subject: Re: bug#25508: Git hook shebangs should not be rewritten References: <20170122232550.GB27876@jasmine> Date: Mon, 16 Nov 2020 19:10:59 +0100 In-Reply-To: <20170122232550.GB27876@jasmine> (Leo Famulari's message of "Sun, 22 Jan 2017 18:25:50 -0500") Message-ID: <87r1otw4ss.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 25508 Cc: 25304@debbugs.gnu.org, 25508@debbugs.gnu.org, John Darrington X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Sorry, I've closed this with the libtool one. The attached patch fixes this one too, should I push it to master (as the last change for git) or to core-updates or staging (as it might seem looking at the dependencies)? Happy hacking! Miguel --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-git-Add-phase-to-restore-hooks-shebang.patch Content-Transfer-Encoding: quoted-printable Content-Description: 0001.patch From=209f0e9eea6d7c338fba234c2f8935ba76b1d94b2c Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Miguel=3D20=3DC3=3D81ngel=3D20Arruga=3D20Vivas?=3D Date: Mon, 16 Nov 2020 19:06:40 +0100 Subject: [PATCH] gnu: git: Add phase to restore hooks shebang. Fixes . * gnu/packages/version-control.scm (git)[arguments]: New phase restore-sample-hooks-shebang. =2D-- gnu/packages/version-control.scm | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-contro= l.scm index 3e46a6162b..1842528ff6 100644 =2D-- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -391,6 +391,16 @@ as well as the classic centralized workflow.") (install-file "contrib/subtree/git-subtree.1" (string-append subtree "/share/man/man1")) #t))) + (add-after 'install 'restore-sample-hooks-shebang + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (dir (string-append out "/share/git-core/templates/hoo= ks"))) + (for-each (lambda (file) + (format #t "restoring shebang on `~a'~%" file) + (substitute* file + (("^#!.*/bin/sh") "#!/bin/sh"))) + (find-files dir ".*")) + #t))) (add-after 'install 'split (lambda* (#:key inputs outputs #:allow-other-keys) ;; Split the binaries to the various outputs. =2D-=20 2.29.2 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > From: John Darrington > Subject: Not patching shebang in git hook samples ? > To: guix-devel@gnu.org > Date: Sun, 22 Jan 2017 14:01:24 +0100 (3 years, 42 weeks, 4 days ago) > > The git package ships with a number of sample hook files. These are shel= l scripts and > therefore the #!/bin/sh line gets substituted at build time. > > However these files get installed into every git repostory that is create= d, and users > are invited to use them as templates for their own hooks. > > This will be fine until both git and bash are updated. Now the original = bash is free > to be garbage collected. If that happens, the path:=20 > #!/gnu/store/qkw4zrwfybxww8f56nkb6hggxambk89b-bash-4.4.0/bin/sh > will no longer exist. > > I suggest what we turn off the shebang patching for the files in share/te= mplates for git. > > J' --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEEiIeExBRZrMuD5+hMY0xuiXn6vsIFAl+ywLQACgkQY0xuiXn6 vsI5hQv+IfRGaTZ7A0Ulzdy54BxcVq/asGgJUcAG8HU/cZbxQDSjmbcWXoIomrI8 PyvVVmoFwm6RVFKvCZCFqFVIeKMzPZOjgWLV2gRLwBH1VR+oQG+1LT7WTULL8fGB 6ToYkKWqE3d7sZnE5J+jFjVclCXUVyzySIW0cCBT8jXei9sOTnO8+nby9/aBwMpT +1sMz2qGZ4XR8arXPQnp1duDaBrqq4hPOcsMUH2NL86Widf3EkJ0F+CskU0z/Bi8 jufRuZcy9OfQXUHqoVOEvS9catdq9IAR4rGaYhRMHUiq796Bka232kATYkpTmjZz pMFxyQNUkDQtRCVt8devE54Xliy6OTPD3w0RRn/3s78XKyCVCim2JQK0+40cDDHh dnrUN1tkZ87ggHw1xth2NVdi4eKlKIqB4mAClH9QRyF2yW0EzGmjE27Lxbb3e9aM +nSZHYo52VbKbUVGVkgmBwT9el9zGG/YcIbfO3oM71Pe18Xmmf7KropfvKgVhqaz AAPVvykG =3IH3 -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 13:42:40 2020 Received: (at 25508) by debbugs.gnu.org; 16 Nov 2020 18:42:41 +0000 Received: from localhost ([127.0.0.1]:57209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kejSa-00008Z-Iq for submit@debbugs.gnu.org; Mon, 16 Nov 2020 13:42:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kejSW-00008E-2i; Mon, 16 Nov 2020 13:42:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38602) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kejSQ-0001LB-34; Mon, 16 Nov 2020 13:42:30 -0500 Received: from host-37-191-236-253.lynet.no ([37.191.236.253]:34310 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kejSO-0004Ks-Gt; Mon, 16 Nov 2020 13:42:29 -0500 From: Marius Bakke To: Miguel =?utf-8?Q?=C3=81ngel?= Arruga Vivas , Leo Famulari Subject: Re: bug#25304: bug#25508: Git hook shebangs should not be rewritten In-Reply-To: <87r1otw4ss.fsf@gmail.com> References: <20170122232550.GB27876@jasmine> <87r1otw4ss.fsf@gmail.com> Date: Mon, 16 Nov 2020 19:42:26 +0100 Message-ID: <87h7pp9m99.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 25508 Cc: 25304@debbugs.gnu.org, 25508@debbugs.gnu.org, John Darrington X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Miguel =C3=81ngel Arruga Vivas writes: > The attached patch fixes this one too, should I push it to master (as > the last change for git) or to core-updates or staging (as it might seem > looking at the dependencies)? LGTM. Git (+ git-minimal) is below the 300 rebuild limit for 'master' (and I try to keep it that way!). --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCgAtFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl+yyBIPHG1hcml1c0Bn bnUub3JnAAoJEKKgbfKjOlT63K4H/2TqeZuQEnTyDjzDyMHOTuuqaw1Ckbxep04O 9Bp9Dz00OX2qOrJLuviiSbN656G+gtA9phopvZiQhRQrkNt91S202zWQy96tPAHy ikTNlONVqH1d8penErNSW7Ddzmi+IO16MxIvHSyme+wNo+zy3uirdO9LNEcSBr72 TI+YzkuKh3qFUbW7DMFKIKCdeRL4lwBE5pxdhXhsFLn/ecr9iFmHY9ZqI/C6OYIK 7Xi2sFt5vQu/MmP99N/mhqtURYz6AeRt6xQfMBj9HzXoTbYtoDgseVmfAvZfiQiq 7Q7NJnzBAjOGzmhlRcV8+Q0PrshOkfqzBZ4XSAgzQrZhQDYvOqk= =1bUC -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 15:51:54 2020 Received: (at 25508) by debbugs.gnu.org; 16 Nov 2020 20:51:54 +0000 Received: from localhost ([127.0.0.1]:57494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kelTe-0001LK-1l for submit@debbugs.gnu.org; Mon, 16 Nov 2020 15:51:54 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:37749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kelTb-0001L4-R6; Mon, 16 Nov 2020 15:51:52 -0500 Received: by mail-wr1-f51.google.com with SMTP id b6so20311958wrt.4; Mon, 16 Nov 2020 12:51:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=2OkBs4y3WiWUrFLF89+nCfdoMdB013SJPkZ4oqGXHqk=; b=o/XZ+y1mhK+irGcD6XWyNOYhVVi0CqQ/rWABFpmYXL+TG6lNZT+DPxvM8qakRl9IOu HIIluy+2Zli22/Lhc2eiHygQxIZtD9mWWeR3v80KsaLwFxh5wdyp+6zj8tUZhE979Tmc q9Qx6p3/hthaTga3K7rTIiKlj99cDjVG4tEBY8tAO5UZdMwIIOgMAIQEhUMnVRVZ/1iR HpcpbHu0UFoA3ylkEA4Ta3pN9EUHyDSgbVQhgH1Z3LVhNh3dG8B1C5B932gIiK87DeH5 7ZiVsVW7MY83fTf5cEXZ1/NpWGIryE7RxoEH5GU/Y81mrNqItp3HYlLAwepCwMaKcznk 5ZKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=2OkBs4y3WiWUrFLF89+nCfdoMdB013SJPkZ4oqGXHqk=; b=A04gdgPqDvMPVRNsKa9ThpFqG2dfQ8AE9m3PHJ6wodC5IUMSPI+IVmxdvlJHU1/yCX LWZMZp5lJH0r/qjlFEeZ8nAbKbjVI2bxg+BC1hpMs1An6+7yq4n9sKpelgzOy3B4ghHT KRuUjAH7dReE0Ym4zPD09RmGBKObET6Tk6ZwBPNGYALSydwxi7leCG0z+LrlETSyRXGv Yo4JEnF+QQlylIy4i6AUXv4xLkp3myZE63DWULamU4d/dcMZKC6Yf5vEEeaSfuW5LBoe h++4TX2HZyQP8NM1uhWHLlScNVD+LpLxediPogPQedmw4jxqTrMckh1wjWvO2O2Hq2yE 3LIQ== X-Gm-Message-State: AOAM532ku+mJfb37AjhApfLEz/ZyXat/3+alS+/uJ45vakNmXfSX/S9h pHXVWzNUu1yywje3j1l14vM= X-Google-Smtp-Source: ABdhPJxNhxzz5PodEydgmRlJaC32ctb7x+MdfJAkeRPVXKxxiJIF9UdjWm00EpCrJ2WLlE3QKyroJw== X-Received: by 2002:adf:b109:: with SMTP id l9mr20724014wra.279.1605559905922; Mon, 16 Nov 2020 12:51:45 -0800 (PST) Received: from unfall (20.134.94.90.dynamic.jazztel.es. [90.94.134.20]) by smtp.gmail.com with ESMTPSA id t74sm602699wmt.8.2020.11.16.12.51.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 12:51:45 -0800 (PST) From: =?utf-8?Q?Miguel_=C3=81ngel_Arruga_Vivas?= To: Marius Bakke Subject: Re: bug#25304: bug#25508: Git hook shebangs should not be rewritten References: <20170122232550.GB27876@jasmine> <87r1otw4ss.fsf@gmail.com> <87h7pp9m99.fsf@gnu.org> Date: Mon, 16 Nov 2020 21:51:43 +0100 In-Reply-To: <87h7pp9m99.fsf@gnu.org> (Marius Bakke's message of "Mon, 16 Nov 2020 19:42:26 +0100") Message-ID: <87ima5vxcw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 25508 Cc: 25304@debbugs.gnu.org, 25508@debbugs.gnu.org, John Darrington , Leo Famulari X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Marius Bakke writes: > Miguel =C3=81ngel Arruga Vivas writes: > >> The attached patch fixes this one too, should I push it to master (as >> the last change for git) or to core-updates or staging (as it might seem >> looking at the dependencies)? > > LGTM. Git (+ git-minimal) is below the 300 rebuild limit for 'master' > (and I try to keep it that way!). Thanks for the info and the fast review, I wasn't sure if it was 109+242 or just 242. I've pushed it to master as 46ce24fb2d8c9f7dce16c4c08919f0fc108dbfae. Happy hacking! Miguel From unknown Wed Jun 18 23:01:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 15 Dec 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator