GNU bug report logs - #25501
sed-4.3: testsuite/runtest does not check for a program extension

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Assaf Gordon <assafgordon <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#25501: closed (sed-4.3: testsuite/runtest does not check for
 a program extension)
Date: Tue, 09 Oct 2018 12:54:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 9 Oct 2018 06:53:05 -0600
with message-id <76f74261-1f09-6c90-67fb-1f3eae37f3e0 <at> gmail.com>
and subject line Re: bug#25501: sed-4.3: testsuite/runtest does not check for a program extension
has caused the debbugs.gnu.org bug report #25501,
regarding sed-4.3: testsuite/runtest does not check for a program extension
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
25501: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25501
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Juan Manuel Guerrero <juan.guerrero <at> gmx.de>
To: bug-sed <at> gnu.org
Subject: sed-4.3: testsuite/runtest does not check for a program extension
Date: Sat, 21 Jan 2017 15:42:39 +0100

OFYI, the testsuite/runtest shell script makes the assumption that programs
like get-mb-cur-max and test-mbrtowc have no extension but this is not true
for non-posix systems like Windows (aka MinGW) or MSDOS (aka DJGPP).  Thus
the check fails when runtest is invoked.  In some way the possibility for
an extension should be provided.  The patch below is not intended as fix,
it shall only demonstrate the issue.  It is clear that this problem cannot
be reproduced on a posix system like linux.
This means that the test fails to find programs if they have an extension
like ".exe" as used to be in DOS/Windows.

Regards,
Juan M. Guerrero



diff -aprNU5 sed-4.3.orig/testsuite/runtest sed-4.3/testsuite/runtest
--- sed-4.3.orig/testsuite/runtest	2016-07-25 03:03:56 +0000
+++ sed-4.3/testsuite/runtest	2017-01-13 17:49:42 +0000
@@ -9,11 +9,11 @@
 : ${SED="./sed/sed"}

 makefile="${abs_top_srcdir}/testsuite/Makefile.tests"

 # Strip the directory './testsuite/' from the test name.
-test=`echo "$@"| sed 's,.*/,,'`
+test=`echo "$@"| sed 's,.*/,,;s,\.exe$,,'`

 # Skip the utility programs, they are not standalone tests
 test "$test" = get-mb-cur-max \
     || test "$test" = test-mbrtowc \
     && exit 77

[Message part 3 (message/rfc822, inline)]

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Juan Manuel Guerrero <juan.guerrero <at> gmx.de>, 25501-done <at> debbugs.gnu.org
Subject: Re: bug#25501: sed-4.3: testsuite/runtest does not check for a
 program extension
Date: Tue, 9 Oct 2018 06:53:05 -0600

tags 25501 fixed
stop

Hello,

On 21/01/17 07:42 AM, Juan Manuel Guerrero wrote:
> OFYI, the testsuite/runtest shell script makes the assumption that programs
> like get-mb-cur-max and test-mbrtowc have no extension but this is not true
> for non-posix systems like Windows (aka MinGW) or MSDOS (aka DJGPP). 

Thank you for the report.

In the time since your bug report, sed's testsuite has
been greatly improved, and the problematic file (runtest)
has been completely removed:
https://git.savannah.gnu.org/cgit/sed.git/commit/?id=7daa26d068e5e84eed1212e203c2ce79c074604c

I've just tested the latest git revision on cygwin
and the auxiliary test files (get-mb-cur-max.exe and test-mbrtowc.exe)
are executed correctly.

As such I'm closing this bug report.

regards,
 - assaf

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.