GNU bug report logs - #25499
[PATCH] grep: fix matching not longest pattern with grep -Fo

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25499 in the body.
You can then email your comments to 25499 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: <bug-grep <at> gnu.org>
Subject: [PATCH] grep: fix matching not longest pattern with grep -Fo
Date: Sat, 21 Jan 2017 18:14:48 +0900

[Message part 1 (text/plain, inline)]

grep -Fo may not match longest pattern in grep 2.26 or later including
current master.

$ printf 'abce\n' > in
$ printf 'abcd\nc\nbce\n' > pat
$ LC_ALL=C src/grep -Fof pat in
c

We expect "bce" in this case.

[0001-grep-fix-matching-not-longest-pattern-with-grep-Fo.patch (text/plain, attachment)]

Message #8 received at 25499 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 25499 <at> debbugs.gnu.org
Subject: Re: bug#25499: [PATCH] grep: fix matching not longest pattern with
 grep -Fo
Date: Sat, 21 Jan 2017 08:09:00 -0800

[Message part 1 (text/plain, inline)]

On Sat, Jan 21, 2017 at 1:14 AM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> grep -Fo may not match longest pattern in grep 2.26 or later including
> current master.
>
> $ printf 'abce\n' > in
> $ printf 'abcd\nc\nbce\n' > pat
> $ LC_ALL=C src/grep -Fof pat in
> c
>
> We expect "bce" in this case.

Nice. I am glad you caught that.
I've adjusted some wording and will push this soon:

[grep-Fo-longest.diff (text/plain, attachment)]

Message #11 received at 25499 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Jim Meyering <jim <at> meyering.net>
Cc: 25499 <at> debbugs.gnu.org
Subject: Re: bug#25499: [PATCH] grep: fix matching not longest pattern with
 grep -Fo
Date: Sun, 22 Jan 2017 10:09:10 +0900

On Sat, 21 Jan 2017 08:09:00 -0800
Jim Meyering <jim <at> meyering.net> wrote:

> Nice. I am glad you caught that.
> I've adjusted some wording and will push this soon:

Thanks for replying and adjusting quickly.  Your adjustment is also very
useful for me to learn English.

Message #16 received at 25499-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 25499-done <at> debbugs.gnu.org
Subject: Re: bug#25499: [PATCH] grep: fix matching not longest pattern with
 grep -Fo
Date: Sat, 21 Jan 2017 17:11:50 -0800

On Sat, Jan 21, 2017 at 5:09 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
>
> On Sat, 21 Jan 2017 08:09:00 -0800
> Jim Meyering <jim <at> meyering.net> wrote:
>
>> Nice. I am glad you caught that.
>> I've adjusted some wording and will push this soon:
>
> Thanks for replying and adjusting quickly.  Your adjustment is also very
> useful for me to learn English.

Pushed.

Message #19 received at 25499-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 25499-done <at> debbugs.gnu.org
Subject: Re: bug#25499: [PATCH] grep: fix matching not longest pattern with
 grep -Fo
Date: Mon, 23 Jan 2017 11:43:55 -0800

On Sat, Jan 21, 2017 at 5:11 PM, Jim Meyering <jim <at> meyering.net> wrote:
> On Sat, Jan 21, 2017 at 5:09 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
>>
>> On Sat, 21 Jan 2017 08:09:00 -0800
>> Jim Meyering <jim <at> meyering.net> wrote:
>>
>>> Nice. I am glad you caught that.
>>> I've adjusted some wording and will push this soon:
>>
>> Thanks for replying and adjusting quickly.  Your adjustment is also very
>> useful for me to learn English.
>
> Pushed.

I've just noticed that fgrep-longest was not listed in Makefile.am's
lists of tests, so have added it with this:

  http://git.savannah.gnu.org/cgit/grep.git/commit/?id=b2e0f3f86c6ff948c9b37668af762ea90f06e401

Message #22 received at 25499-done <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Jim Meyering <jim <at> meyering.net>
Cc: 25499-done <at> debbugs.gnu.org
Subject: Re: bug#25499: [PATCH] grep: fix matching not longest pattern with
 grep -Fo
Date: Wed, 25 Jan 2017 00:00:30 +0900

On Mon, 23 Jan 2017 11:43:55 -0800
Jim Meyering <jim <at> meyering.net> wrote:

> I've just noticed that fgrep-longest was not listed in Makefile.am's
> lists of tests, so have added it with this:
> 
>   http://git.savannah.gnu.org/cgit/grep.git/commit/?id=b2e0f3f86c6ff948c9b37668af762ea90f06e401

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.