GNU bug report logs - #25496
25.1.91; INSIDE_EMACS env variable is not set in eshell

Previous Next

Package: emacs;

Reported by: Alex Hutcheson <alexhutcheson <at> google.com>

Date: Fri, 20 Jan 2017 22:33:02 UTC

Severity: minor

Tags: fixed, patch

Merged with 39596

Found in versions 25.1.91, 26.3

Fixed in version 28.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #44 received at 25496 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 25496 <at> debbugs.gnu.org, federicotedin <at> gmail.com
Subject: Re: bug#25496: 25.1.91; INSIDE_EMACS env variable is not set in eshell
Date: Fri, 03 Apr 2020 15:17:30 +0300
> From: Noam Postavsky <npostavs <at> gmail.com>
> Date: Mon, 30 Mar 2020 19:11:04 -0400
> Cc: 25496 <at> debbugs.gnu.org
> 
> > +If the value is a string, the value for the variable with that name in
> > +the current environment will be returned.  If no variable with that
> > +name exists in the environment, but if a symbol with that same name
> > +exists and has a value bound to it, then that value will be used.  You
> > +can prioritize symbol values over environment values by setting
> > +`eshell-prefer-lisp-variables' to t.
> > +
> > +If the value is a symbol, the value bound to that symbol will be used.
> 
> Much better, thanks.

Would it be possible to reword this so that passive tense is used less
frequently?  E.g., instead of "the variable with that name in the
current environment will be returned", how about "return the variable
with that name in the current environment"?  And similarly with the
rest of the doc string.

Thanks.




This bug report was last modified 5 years and 95 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.