From unknown Fri Sep 05 22:44:35 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#25478 <25478@debbugs.gnu.org> To: bug#25478 <25478@debbugs.gnu.org> Subject: Status: 26.0.50; No hooks are called when auto-saving Reply-To: bug#25478 <25478@debbugs.gnu.org> Date: Sat, 06 Sep 2025 05:44:35 +0000 retitle 25478 26.0.50; No hooks are called when auto-saving reassign 25478 emacs submitter 25478 Philipp Stephani severity 25478 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 18 16:39:28 2017 Received: (at submit) by debbugs.gnu.org; 18 Jan 2017 21:39:28 +0000 Received: from localhost ([127.0.0.1]:35038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cTxx2-0006qM-4Y for submit@debbugs.gnu.org; Wed, 18 Jan 2017 16:39:28 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cTxx0-0006q9-FO for submit@debbugs.gnu.org; Wed, 18 Jan 2017 16:39:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTxwu-00030E-5z for submit@debbugs.gnu.org; Wed, 18 Jan 2017 16:39:21 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40688) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cTxwu-000309-2H for submit@debbugs.gnu.org; Wed, 18 Jan 2017 16:39:20 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTxws-0004xU-MC for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2017 16:39:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTxwr-0002yi-Ji for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2017 16:39:18 -0500 Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]:37251) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cTxwr-0002y6-8c for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2017 16:39:17 -0500 Received: by mail-wm0-x22b.google.com with SMTP id c206so47118740wme.0 for ; Wed, 18 Jan 2017 13:39:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=tmIMpeZAo5jLMgqdLopX1+XO8kiLdThkFdHEWRZ7wk8=; b=ohP6Cw7LcnYB9XDF745NzxNaK3YYSyEPMZoZDnG8Lpt2+Nwc0tJFmg+RWIJIsoSLYd Ls+V5u+gXrEFg+Fh3IQLmJ2zyv6O5YUnX4UWjU59dEB5lJkUm5+F4/UadckV55lwkt5r R0FZAsOcM/jVsn4XD0Hdio2n6NhhkVZL7m0XroQkLBHMmeRtKBzwrplWNeNsx4Ckhkfi L8XKxMTPHweXA1O8jQ7ioo4M55EupGZbYcmYHtAVbdRIy3YeDifJGZxOYd5Ujn2Wy958 7hqt35y6yko3TwHGEMHV/MKZen0BMQ6uDHqNv5SjAqU4n8I9YpOw4P2ovdhGdsKLQiOP trrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=tmIMpeZAo5jLMgqdLopX1+XO8kiLdThkFdHEWRZ7wk8=; b=GRjwPXPN8clW2ithJs/Yypj+o2aemuxmDFDBrce7eOgaKaiXaxTw83yzYkh4RYyohy T11NTDwqf20V6nJX/wKF3pRDmDPRVMKxA1QQiOligJ2V+KxpGiFQtd+a8ie0KxwQBNlq hlFHti64akyDxWS7kDmQPuiWkWdkc3N9byy0wUYINipjdz1Dek/oDLWADky3+Vx/LErB 11//sj5rJQg5mTLyaRtVD1WeJfg0YJvPn/qKyuaEHpp2U9Vz0fq+9cfoXKLNtLhPwzIS lntbnZTi67h3q/D38KbdtbSQyvHQIfi2Vm8WmaJoWmV2dCJp3JivL7XDzVUxDW/eFjxa 9Ixw== X-Gm-Message-State: AIkVDXKUX39jsPDl5RQfvkqpUrHIWeV/s9yVMxcYGfVPHOvntFuVXkwrXmu1hEjI0+iRSQ== X-Received: by 10.223.145.163 with SMTP id 32mr5271266wri.198.1484775555492; Wed, 18 Jan 2017 13:39:15 -0800 (PST) Received: from a.muc.corp.google.com ([2a00:79e0:15:4:84c:d489:bf17:acdd]) by smtp.gmail.com with ESMTPSA id 135sm7619073wmh.14.2017.01.18.13.39.14 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 18 Jan 2017 13:39:14 -0800 (PST) From: Philipp Stephani To: bug-gnu-emacs@gnu.org Subject: 26.0.50; No hooks are called when auto-saving Date: Wed, 18 Jan 2017 22:39:13 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) The Emacs manual states: "If you want auto-saving to be done in the visited file rather than in a separate auto-save file, set the variable =E2=80=98auto-save-visited-file-name=E2=80=99 to a non-=E2=80=98nil=E2=80= =99 value. In this mode, there is no real difference between auto-saving and explicit saving." However, there is a significant difference between auto-saving and explicit saving, even in this mode: auto-saving doesn't run before-save-hook, after-save-hook, write-contents-functions, or write-file-functions. Either some of these hooks should be run during auto-saving if auto-save-visited-file-name is t, or new hooks should be created to run in this case. In GNU Emacs 26.0.50.38 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8) of 2017-01-18 built on localhost Repository revision: 5fefaaa8c0696ba4b7b6e1e89267aa10fff88b31 Windowing system distributor 'The X.Org Foundation', version 11.0.11501000 System Description: Ubuntu 14.04 LTS Recent messages: Sending email=20 Sending email done Sending...done Configured using: 'configure --with-modules --enable-checking --enable-check-lisp-object-type 'CFLAGS=3D-ggdb3 -O0'' Configured features: XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY GNUTLS FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (network-stream nsm starttls tls gnutls mailalias smtpmail auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs qp cus-edit cus-start cus-load wid-edit pp shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv bytecomp byte-compile cl-extra help-mode cconv cl-loaddefs pcase cl-lib dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 125369 10956) (symbols 48 22403 1) (miscs 40 373 277) (strings 32 23633 8700) (string-bytes 1 753869) (vectors 16 22889) (vector-slots 8 1256392 202843) (floats 8 225 207) (intervals 56 502 0) (buffers 976 16) (heap 1024 42683 5682)) --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Matthew Scott Sucherman, Paul Terence Manicle Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und l=C3= =B6schen Sie die E-Mail und alle Anh=C3=A4nge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do = not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 19 15:29:17 2017 Received: (at 25478) by debbugs.gnu.org; 19 Jan 2017 20:29:17 +0000 Received: from localhost ([127.0.0.1]:35788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cUJKe-0007ny-QI for submit@debbugs.gnu.org; Thu, 19 Jan 2017 15:29:16 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cUJKd-0007ne-UJ for 25478@debbugs.gnu.org; Thu, 19 Jan 2017 15:29:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cUJKX-00052b-Mf for 25478@debbugs.gnu.org; Thu, 19 Jan 2017 15:29:10 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cUJKT-00050P-Vz; Thu, 19 Jan 2017 15:29:06 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1cUJKS-00040a-BN; Thu, 19 Jan 2017 15:29:04 -0500 From: Glenn Morris To: Philipp Stephani Subject: Re: bug#25478: 26.0.50; No hooks are called when auto-saving References: X-Spook: [Hello to all my friends and fans in domestic X-Ran: fxPO`HO}OgNcYH}!v/tTH`vv5^26E~r[;sf%~`-M6(ezIa7CBBm*M!.f. (Philipp Stephani's message of "Wed, 18 Jan 2017 22:39:13 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.2 (--------) X-Debbugs-Envelope-To: 25478 Cc: 25478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.2 (--------) Philipp Stephani wrote: > The Emacs manual states: > > "If you want auto-saving to be done in the visited file rather than in > a separate auto-save file, set the variable > 'auto-save-visited-file-name' to a non-'nil' value. In this mode, there > is no real difference between auto-saving and explicit saving." > > However, there is a significant difference between auto-saving and > explicit saving, even in this mode: auto-saving doesn't run > before-save-hook, after-save-hook, write-contents-functions, or > write-file-functions. Either some of these hooks should be run during > auto-saving if auto-save-visited-file-name is t, or new hooks should be > created to run in this case. The phrasing of the manual can easily be changed if it's creating unreasonable expectations. Do you have a use case for autosave running hooks? One could argue that it is a low-level operation that should not be modifiable in this way. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 20 03:45:26 2017 Received: (at 25478) by debbugs.gnu.org; 20 Jan 2017 08:45:26 +0000 Received: from localhost ([127.0.0.1]:36027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cUUp4-0004yu-FR for submit@debbugs.gnu.org; Fri, 20 Jan 2017 03:45:26 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cUUp2-0004yh-U6 for 25478@debbugs.gnu.org; Fri, 20 Jan 2017 03:45:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cUUos-0005Pt-Kr for 25478@debbugs.gnu.org; Fri, 20 Jan 2017 03:45:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54797) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cUUos-0005Pj-Hh; Fri, 20 Jan 2017 03:45:14 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4127 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cUUor-0008On-JL; Fri, 20 Jan 2017 03:45:14 -0500 Date: Fri, 20 Jan 2017 10:45:05 +0200 Message-Id: <837f5q6rxq.fsf@gnu.org> From: Eli Zaretskii To: Glenn Morris In-reply-to: (message from Glenn Morris on Thu, 19 Jan 2017 15:29:04 -0500) Subject: Re: bug#25478: 26.0.50; No hooks are called when auto-saving References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.2 (--------) X-Debbugs-Envelope-To: 25478 Cc: p.stephani2@gmail.com, 25478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.2 (--------) > From: Glenn Morris > Date: Thu, 19 Jan 2017 15:29:04 -0500 > Cc: 25478@debbugs.gnu.org > > Philipp Stephani wrote: > > > The Emacs manual states: > > > > "If you want auto-saving to be done in the visited file rather than in > > a separate auto-save file, set the variable > > 'auto-save-visited-file-name' to a non-'nil' value. In this mode, there > > is no real difference between auto-saving and explicit saving." > > > > However, there is a significant difference between auto-saving and > > explicit saving, even in this mode: auto-saving doesn't run > > before-save-hook, after-save-hook, write-contents-functions, or > > write-file-functions. Either some of these hooks should be run during > > auto-saving if auto-save-visited-file-name is t, or new hooks should be > > created to run in this case. > > The phrasing of the manual can easily be changed if it's creating > unreasonable expectations. I've done that now on the release branch. > Do you have a use case for autosave running hooks? > One could argue that it is a low-level > operation that should not be modifiable in this way. Auto-save has its own hook. But that's just the tip of an iceberg, because nowadays various modes can completely change what happens at save-buffer time by using the hooks mentioned above, and those hooks run only when basic-save-buffer is invoked; they won't be run during auto-saving. And there are other differences, too. E.g., if save-buffer asks the user for a suitable encoding, it will record the value used in buffer-file-coding-system, so that future saves reuse that automatically. Auto-saving doesn't record the value, so if the user doesn't change the buffer's file encoding manually, she will be prompted to provide an encoding on every auto-save. All in all, I think this option is subtly dangerous and should be either deprecated or completely reimplemented to invoke basic-save-buffer instead. I'm quite sure this option made sense in the past, when complications with encoding and save-related hooks didn't exist, but that is no longer the case in Emacs these days. If someone thinks using this option will allow them not to bother with saving their edits, they are in for an unpleasant surprise. (Not sure whether we should close this bug now that the documentation is fixed.) From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 20 12:43:02 2017 Received: (at 25478) by debbugs.gnu.org; 20 Jan 2017 17:43:02 +0000 Received: from localhost ([127.0.0.1]:36599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cUdDJ-0004BH-OB for submit@debbugs.gnu.org; Fri, 20 Jan 2017 12:43:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cUdDI-0004B0-Kf for 25478@debbugs.gnu.org; Fri, 20 Jan 2017 12:43:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cUdDC-0001ki-CX for 25478@debbugs.gnu.org; Fri, 20 Jan 2017 12:42:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cUdD8-0001iL-Q9; Fri, 20 Jan 2017 12:42:50 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1cUdD7-0006z0-00; Fri, 20 Jan 2017 12:42:49 -0500 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#25478: 26.0.50; No hooks are called when auto-saving References: <837f5q6rxq.fsf@gnu.org> X-Spook: Al-Shabaab Leuken-Baden ASDIC Border WHO president Al X-Ran: 8h4>-Dn4h1;k|h`V^7kmOBIXEmAFX$0Z@SL|Ii)vV<823-})02HAoRU:)s0sMtGV`z.&\z X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 20 Jan 2017 12:42:48 -0500 In-Reply-To: <837f5q6rxq.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Jan 2017 10:45:05 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.2 (--------) X-Debbugs-Envelope-To: 25478 Cc: p.stephani2@gmail.com, 25478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.2 (--------) Eli Zaretskii wrote: > All in all, I think this option is subtly dangerous and should be > either deprecated or completely reimplemented to invoke > basic-save-buffer instead. I'm quite sure this option made sense in > the past, when complications with encoding and save-related hooks > didn't exist, but that is no longer the case in Emacs these days. > If someone thinks using this option will allow them not to bother with > saving their edits, they are in for an unpleasant surprise. Deprecation sounds good to me. I believe there's a "real-auto-save" package that does a standard save at intervals. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 26 14:21:21 2017 Received: (at 25478) by debbugs.gnu.org; 26 Mar 2017 18:21:21 +0000 Received: from localhost ([127.0.0.1]:46152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csCn2-0004Sg-IX for submit@debbugs.gnu.org; Sun, 26 Mar 2017 14:21:20 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:33553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csCmz-0004SH-Or for 25478@debbugs.gnu.org; Sun, 26 Mar 2017 14:21:18 -0400 Received: by mail-wr0-f196.google.com with SMTP id 20so6707502wrx.0 for <25478@debbugs.gnu.org>; Sun, 26 Mar 2017 11:21:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H/Ob7BoDUoAtl8CmICAvxx37Nu8nfFp0bitjJa66K8Q=; b=ITnTKwBoPNW+EHyELs7fT4Wc0eROnG0cPHTxdgBbxcF+A2zHyJhKZaCh17DaANhoxG wUJo2TFoOnDeVBgUhV2hyH5YBTwcbndoK8KRn1ukDWxkZyflD/0w6E0NIKl/8gaBXlDF 4S04F5bwjpwry0pmHiwIR3nUvyqyjwWqA5dxhGJugRRmJG4r8NozTOzI6d6M0aC6LsZf MvTMrmFtq9B0xdR2kfHXVKdmr317+flWwToBXyY0I0yoZs/0ubuNJq3QK5YMxZro9v0g fVUodXq39sMpRs9Cwep1a5RyaM40b5qLrqz/gCUK+dByY9dS0GhlGilRHG9K6xat4mpL 5fjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H/Ob7BoDUoAtl8CmICAvxx37Nu8nfFp0bitjJa66K8Q=; b=lP9F/iiHvw3NrKHkVS5vP8oEagjZrtQW4AHz3ncMyTjVo8zYpk6B5/yBozNEjnJB6K KDyW815lClfVXk21PAZd4Mn+/7JcKJ4m7P9pxw1Wj7ouJcOCayUEnde3iL1PQn1yw68q ylsv+S7ETsJkReiwDPpLduwg3p0yLnZcnyq6FmLy2vYbVdhBkuxHGBkNZ3IPxiiv3sCw kLfol8yKFZBElJYSo/wlldF28UfZmqsEMwaapaz1l8BkMB5m/DHMfz6xi6ea8LKlf8Io BC1x9UFRJ3I8Ko2DIjAByHT3WWpwv97xxstTXwxvCvIWQIRjJb5dFrlPiE4ohE9yXZHK E9yA== X-Gm-Message-State: AFeK/H0n96dGFbkNqd0yWPsXdbNXd6GggkG6nwYsi9escc0/VrKPvo1ceyhSkhpkObO0xi8kAOAiy3wbM+XbOQ== X-Received: by 10.223.154.2 with SMTP id z2mr11492709wrb.136.1490552472008; Sun, 26 Mar 2017 11:21:12 -0700 (PDT) MIME-Version: 1.0 References: <837f5q6rxq.fsf@gnu.org> In-Reply-To: <837f5q6rxq.fsf@gnu.org> From: Philipp Stephani Date: Sun, 26 Mar 2017 18:21:01 +0000 Message-ID: Subject: Re: bug#25478: 26.0.50; No hooks are called when auto-saving To: Eli Zaretskii , Glenn Morris Content-Type: multipart/alternative; boundary=f403045f57709cfdc4054ba64aff X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 25478 Cc: 25478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) --f403045f57709cfdc4054ba64aff Content-Type: text/plain; charset=UTF-8 Eli Zaretskii schrieb am Fr., 20. Jan. 2017 um 09:45 Uhr: > > From: Glenn Morris > > Date: Thu, 19 Jan 2017 15:29:04 -0500 > > Cc: 25478@debbugs.gnu.org > > > > Philipp Stephani wrote: > > > > > The Emacs manual states: > > > > > > "If you want auto-saving to be done in the visited file rather than in > > > a separate auto-save file, set the variable > > > 'auto-save-visited-file-name' to a non-'nil' value. In this mode, > there > > > is no real difference between auto-saving and explicit saving." > > > > > > However, there is a significant difference between auto-saving and > > > explicit saving, even in this mode: auto-saving doesn't run > > > before-save-hook, after-save-hook, write-contents-functions, or > > > write-file-functions. Either some of these hooks should be run during > > > auto-saving if auto-save-visited-file-name is t, or new hooks should be > > > created to run in this case. > > > > The phrasing of the manual can easily be changed if it's creating > > unreasonable expectations. > > I've done that now on the release branch. > > > Do you have a use case for autosave running hooks? > > One could argue that it is a low-level > > operation that should not be modifiable in this way. > > Auto-save has its own hook. But that's just the tip of an iceberg, > because nowadays various modes can completely change what happens at > save-buffer time by using the hooks mentioned above, and those hooks > run only when basic-save-buffer is invoked; they won't be run during > auto-saving. > > And there are other differences, too. E.g., if save-buffer asks the > user for a suitable encoding, it will record the value used in > buffer-file-coding-system, so that future saves reuse that > automatically. Auto-saving doesn't record the value, so if the user > doesn't change the buffer's file encoding manually, she will be > prompted to provide an encoding on every auto-save. > > All in all, I think this option is subtly dangerous and should be > either deprecated or completely reimplemented to invoke > basic-save-buffer instead. I'm quite sure this option made sense in > the past, when complications with encoding and save-related hooks > didn't exist, but that is no longer the case in Emacs these days. > If someone thinks using this option will allow them not to bother with > saving their edits, they are in for an unpleasant surprise. > > That's quite unfortunate, as not having to bother with saving edits manually is a very desirable feature that I think Emacs should offer out of the box. If you really want to deprecate auto-save-visited-file-name, how about adding a simple global minor mode that invokes save-some-buffers from an idle timer to files.el? --f403045f57709cfdc4054ba64aff Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Fr., 20. Jan. 2017 um 09:45=C2=A0Uhr:
> From: Glenn Morris <rgm@gnu.org>
> Date: Thu, 19 Jan 2017 15:29:04 -0500
> Cc: 25478@debbugs.gnu.org
>
> Philipp Stephani wrote:
>
> > The Emacs manual states:
> >
> > "If you want auto-saving to be done in the visited file rath= er than in
> > a separate auto-save file, set the variable
> > 'auto-save-visited-file-name' to a non-'nil' valu= e.=C2=A0 In this mode, there
> > is no real difference between auto-saving and explicit saving.&qu= ot;
> >
> > However, there is a significant difference between auto-saving an= d
> > explicit saving, even in this mode: auto-saving doesn't run > > before-save-hook, after-save-hook, write-contents-functions, or > > write-file-functions.=C2=A0 Either some of these hooks should be = run during
> > auto-saving if auto-save-visited-file-name is t, or new hooks sho= uld be
> > created to run in this case.
>
> The phrasing of the manual can easily be changed if it's creating<= br class=3D"gmail_msg"> > unreasonable expectations.

I've done that now on the release branch.

> Do you have a use case for autosave running hooks?
> One could argue that it is a low-level
> operation that should not be modifiable in this way.

Auto-save has its own hook.=C2=A0 But that's just the tip of an iceberg= ,
because nowadays various modes can completely change what happens at
save-buffer time by using the hooks mentioned above, and those hooks
run only when basic-save-buffer is invoked; they won't be run during auto-saving.

And there are other differences, too.=C2=A0 E.g., if save-buffer asks the user for a suitable encoding, it will record the value used in
buffer-file-coding-system, so that future saves reuse that
automatically.=C2=A0 Auto-saving doesn't record the value, so if the us= er
doesn't change the buffer's file encoding manually, she will be
prompted to provide an encoding on every auto-save.

All in all, I think this option is subtly dangerous and should be
either deprecated or completely reimplemented to invoke
basic-save-buffer instead.=C2=A0 I'm quite sure this option made sense = in
the past, when complications with encoding and save-related hooks
didn't exist, but that is no longer the case in Emacs these days.
If someone thinks using this option will allow them not to bother with
saving their edits, they are in for an unpleasant surprise.


That's quite u= nfortunate, as not having to bother with saving edits manually is a very de= sirable feature that I think Emacs should offer out of the box.
<= br>
If you really want to deprecate auto-save-visited-file-name, = how about adding a simple global minor mode that invokes save-some-buffers = from an idle timer to files.el?=C2=A0
--f403045f57709cfdc4054ba64aff-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 26 14:46:11 2017 Received: (at 25478) by debbugs.gnu.org; 26 Mar 2017 18:46:12 +0000 Received: from localhost ([127.0.0.1]:46166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csDB5-00053c-MQ for submit@debbugs.gnu.org; Sun, 26 Mar 2017 14:46:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csDB4-00053O-WB for 25478@debbugs.gnu.org; Sun, 26 Mar 2017 14:46:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csDAv-0001xt-E8 for 25478@debbugs.gnu.org; Sun, 26 Mar 2017 14:46:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csDAv-0001xo-9Z; Sun, 26 Mar 2017 14:46:01 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3020 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1csDAu-0007Rw-B1; Sun, 26 Mar 2017 14:46:00 -0400 Date: Sun, 26 Mar 2017 21:45:59 +0300 Message-Id: <83wpbb98rc.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-reply-to: (message from Philipp Stephani on Sun, 26 Mar 2017 18:21:01 +0000) Subject: Re: bug#25478: 26.0.50; No hooks are called when auto-saving References: <837f5q6rxq.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25478 Cc: rgm@gnu.org, 25478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Philipp Stephani > Date: Sun, 26 Mar 2017 18:21:01 +0000 > Cc: 25478@debbugs.gnu.org > > All in all, I think this option is subtly dangerous and should be > either deprecated or completely reimplemented to invoke > basic-save-buffer instead. I'm quite sure this option made sense in > the past, when complications with encoding and save-related hooks > didn't exist, but that is no longer the case in Emacs these days. > If someone thinks using this option will allow them not to bother with > saving their edits, they are in for an unpleasant surprise. > > That's quite unfortunate, as not having to bother with saving edits manually is a very desirable feature that I > think Emacs should offer out of the box. > > If you really want to deprecate auto-save-visited-file-name, how about adding a simple global minor mode that > invokes save-some-buffers from an idle timer to files.el? As I wrote, I'm also okay with Someone™ volunteering to reimplement this option such that it invokes basic-save-buffer instead. A minor mode that you describe would also be fine, but then it should probably disable auto-saving if auto-save-visited-file-name is set, right? From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 26 15:18:11 2017 Received: (at 25478) by debbugs.gnu.org; 26 Mar 2017 19:18:11 +0000 Received: from localhost ([127.0.0.1]:46195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csDg3-0005re-15 for submit@debbugs.gnu.org; Sun, 26 Mar 2017 15:18:11 -0400 Received: from mail-wr0-f174.google.com ([209.85.128.174]:36767) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csDg1-0005rR-LQ for 25478@debbugs.gnu.org; Sun, 26 Mar 2017 15:18:10 -0400 Received: by mail-wr0-f174.google.com with SMTP id w11so16098420wrc.3 for <25478@debbugs.gnu.org>; Sun, 26 Mar 2017 12:18:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HwQzFWOX7QgMWZqextTHc03rzRsc1PItkbdoNNnzxKM=; b=J61Z17VtLmN7kjAlZTVOTQrX1x+0XmrgSL/IxSvRZ+i1G5iI6ZKEeP1tRqnLzlGY9J kGaBZ3mg4+PjT1lM/eK9Jezg1ReSP20p8vsrJTIxUcf+E2dy9KeLCyNWRvNUb25L4dRg s+2Qi8I7xYuAGVuqD70lQhobANP/auV87ARweSDbcmmkc/5MEbnSt8iA1ccFemH+GnMD 7o/qZGMaNmjRLz1bkAS4zHUyU56+281Ef//EpVKD5njGhM0y1RYTm54hOIovTjus9Om6 R4h/DnSQlW9ZQt2HxLicmX3c8f3RnwagndnyZqFr9bIBXjtViMatQWfWIwMugpBluyZr 36YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HwQzFWOX7QgMWZqextTHc03rzRsc1PItkbdoNNnzxKM=; b=e5PtfC0nOe3cyPcVFmHUEx3UFB1TPmPmEr0wmNNb5aGqa3LgFx+qpXgAmC+phCiEGp Jo+VWt880sZIbocwAjwIxVQzTC6dhOrslo/Txp36uPxFjoNTDbc2cp3iUxpFJuP1z6e5 wPlvh8VEj6SLGVHlTJtBfP/wlzyByIuTqdbXJT5ML3cGpJsuYiLc5CwhPngDHZxPvKSj hYGwFjBfARmM7cSrITFtXhXzZn45Eokg4WLxkRE7WLZDVaidyV7UAwaKS2ZlVS01EvAB rvnnU6T6KMNaa3Q64GyhXauPRe8HM+KmklXs9amOnUvoT1qQO+Ev4X/H/96TEN6hbvBz EYOA== X-Gm-Message-State: AFeK/H2CRbU53y9xwfvzvy5ePQ9edLVQw4lJnOhL+nzgfQ6F6PG+Nmjk9KYKu1Xs40MHl9EapQ2JhcHckBjVAg== X-Received: by 10.223.164.201 with SMTP id h9mr16127302wrb.175.1490555884082; Sun, 26 Mar 2017 12:18:04 -0700 (PDT) MIME-Version: 1.0 References: <837f5q6rxq.fsf@gnu.org> <83wpbb98rc.fsf@gnu.org> In-Reply-To: <83wpbb98rc.fsf@gnu.org> From: Philipp Stephani Date: Sun, 26 Mar 2017 19:17:53 +0000 Message-ID: Subject: Re: bug#25478: 26.0.50; No hooks are called when auto-saving To: Eli Zaretskii Content-Type: multipart/alternative; boundary=f403045f1518fd1cf0054ba71571 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 25478 Cc: rgm@gnu.org, 25478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) --f403045f1518fd1cf0054ba71571 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii schrieb am So., 26. M=C3=A4rz 2017 um 20:46 Uh= r: > > From: Philipp Stephani > > Date: Sun, 26 Mar 2017 18:21:01 +0000 > > Cc: 25478@debbugs.gnu.org > > > > All in all, I think this option is subtly dangerous and should be > > either deprecated or completely reimplemented to invoke > > basic-save-buffer instead. I'm quite sure this option made sense in > > the past, when complications with encoding and save-related hooks > > didn't exist, but that is no longer the case in Emacs these days. > > If someone thinks using this option will allow them not to bother with > > saving their edits, they are in for an unpleasant surprise. > > > > That's quite unfortunate, as not having to bother with saving edits > manually is a very desirable feature that I > > think Emacs should offer out of the box. > > > > If you really want to deprecate auto-save-visited-file-name, how about > adding a simple global minor mode that > > invokes save-some-buffers from an idle timer to files.el? > > As I wrote, I'm also okay with Someone=E2=84=A2 volunteering to reimpleme= nt > this option such that it invokes basic-save-buffer instead. > > A minor mode that you describe would also be fine, but then it should > probably disable auto-saving if auto-save-visited-file-name is set, > right? > Sounds reasonable. I'll try to come up with something by next weekend. Probably it will be just (defvar auto-save--timer nil) (defcustom auto-save-visited-interval 5 "seconds" :group 'files :type 'number :set (lambda (symbol value) (set-default symbol value) (when auto-save--timer (timer-set-idle-time auto-save--timer value :repeat)))) (define-minor-mode auto-save-visited-mode nil :group 'files :global t (when auto-save--timer (kill-timer auto-save--timer)) (setq auto-save--timer (when auto-save-visited-mode (run-with-idle-timer auto-save-visited-interval :repeat #'save-some-buffers :no-prompt (lambda () (not (and buffer-auto-save-file-name auto-save-visited-file-name))))))) but it will also need tests and documentation, which take a bit more time. --f403045f1518fd1cf0054ba71571 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= So., 26. M=C3=A4rz 2017 um 20:46=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com><= br class=3D"gmail_msg"> > Date: Sun, 26 Mar 2017 18:21:01 +0000
> Cc: 25478@debbugs.gnu.org
>
>=C2=A0 All in all, I think this option is subtly dangerous and should b= e
>=C2=A0 either deprecated or completely reimplemented to invoke
>=C2=A0 basic-save-buffer instead. I'm quite sure this option made s= ense in
>=C2=A0 the past, when complications with encoding and save-related hook= s
>=C2=A0 didn't exist, but that is no longer the case in Emacs these = days.
>=C2=A0 If someone thinks using this option will allow them not to bothe= r with
>=C2=A0 saving their edits, they are in for an unpleasant surprise.
>
> That's quite unfortunate, as not having to bother with saving edit= s manually is a very desirable feature that I
> think Emacs should offer out of the box.
>
> If you really want to deprecate auto-save-visited-file-name, how about= adding a simple global minor mode that
> invokes save-some-buffers from an idle timer to files.el?

As I wrote, I'm also okay with Someone=E2=84=A2 volunteering to reimple= ment
this option such that it invokes basic-save-buffer instead.

A minor mode that you describe would also be fine, but then it should
probably disable auto-saving if auto-save-visited-file-name is set,
right?

Sounds reaso= nable. I'll try to come up with something by next weekend. Probably it = will be just=C2=A0

(defvar auto-save--timer nil)
(defcustom auto-save-visited-interval 5
=C2=A0 "= ;seconds"
=C2=A0 :group 'files
=C2=A0 :type &#= 39;number
=C2=A0 :set (lambda (symbol value)
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0(set-default symbol value)
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0(when auto-save--timer
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0(timer-set-idle-time auto-save--timer value :repeat))))=
(define-minor-mode auto-save-visited-mode nil
=C2= =A0 :group 'files
=C2=A0 :global t
=C2=A0 (when aut= o-save--timer (kill-timer auto-save--timer))
=C2=A0 (setq auto-sa= ve--timer
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (when auto-save-visited-mod= e
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (run-with-idle-timer
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0auto-save-visited-interval :rep= eat
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#'save-some-buff= ers :no-prompt
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(lambda (= )
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(not (and buffe= r-auto-save-file-name auto-save-visited-file-name)))))))

but it will also need tests and documentation, which take a bit more= time.
--f403045f1518fd1cf0054ba71571-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 22 15:02:11 2017 Received: (at 25478) by debbugs.gnu.org; 22 Apr 2017 19:02:11 +0000 Received: from localhost ([127.0.0.1]:34698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d20IM-00005A-Ti for submit@debbugs.gnu.org; Sat, 22 Apr 2017 15:02:11 -0400 Received: from mail-wr0-f174.google.com ([209.85.128.174]:33367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d20IK-00004v-Qz for 25478@debbugs.gnu.org; Sat, 22 Apr 2017 15:02:09 -0400 Received: by mail-wr0-f174.google.com with SMTP id w50so47344796wrc.0 for <25478@debbugs.gnu.org>; Sat, 22 Apr 2017 12:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7HIuunF6ew8SwiZaYwoWzA7KeL/+qSj0XFOA1dGIg3M=; b=juJgX1rM+lv68iAY2RY0k2JZS0mmRToWIsMwvClV31kDrP9KO0hFVnaH7qCxT9u1Bn aqGWUZzURrHkj2wBNRkeGRYK5wx+p2vExj3kPt2ZSkp7N2JFl+YDFAHdjJgFz3uiNBcZ h87PgK96Lgb38Z8gpBURZXAVRtnAtl+qhrW2w4uE1oXZdwavFWwG+FrpC6eM4SMl//ES af9gEkp5pxk7sQAodmvym9IRvf334aWCXQkrciUbh1h5NUUW8/Dikuv3z5gDNGfJskoX r2EwPn4K0QKkfLW4XpgHoe5SJR6SWYVVLxeikJLo6jp1P5lj5IXqlTg/tV2gUWLSAJQV 1Vig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7HIuunF6ew8SwiZaYwoWzA7KeL/+qSj0XFOA1dGIg3M=; b=oWQfk34EYLj81AozTaVcljWREINNsurtkdebRGnm8M3gKjxBnFfrDfeuga7NeNuuIn 3HguRFTGdI5IitxPso27Vp1M74XtqfoArr+Pnx9KQIaDomzhbeV2FNrEnhuZG+36xdfp W/B36XCyBT1pcn551vi+hlxB8Pa2xmA+Nw9Ndt6M7xeiZcpgkdDw9I5UBDqiSUnR1RS9 fw3avHV5LcaAd+eBIboZw4JNSDaGtdloEKWnuwxJXoGgnDVB3sKdREKIzqx7EamCiw/V cWuftTuriR7YT9HWgvb04PoPNB+8Al2kI2oL/797u6Q0CgSRtOYCNzt3ZKLmBPGg6rxK 3Bjw== X-Gm-Message-State: AN3rC/6EZvgk+Uqc3w7nEf90bIphGasFtaD5LDFbjv28vdKyZe6U8n/D SY8r/x/UHjxKHmsf4vElvmP9x3jlHw== X-Received: by 10.223.139.146 with SMTP id o18mr2262637wra.175.1492887723108; Sat, 22 Apr 2017 12:02:03 -0700 (PDT) MIME-Version: 1.0 References: <837f5q6rxq.fsf@gnu.org> <83wpbb98rc.fsf@gnu.org> In-Reply-To: From: Philipp Stephani Date: Sat, 22 Apr 2017 19:01:50 +0000 Message-ID: Subject: Re: bug#25478: 26.0.50; No hooks are called when auto-saving To: Eli Zaretskii Content-Type: multipart/mixed; boundary=f403045eade26d17a5054dc60291 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 25478 Cc: rgm@gnu.org, 25478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) --f403045eade26d17a5054dc60291 Content-Type: multipart/alternative; boundary=f403045eade26d179c054dc6028f --f403045eade26d179c054dc6028f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Philipp Stephani schrieb am So., 26. M=C3=A4rz 2017= um 21:17 Uhr: > Eli Zaretskii schrieb am So., 26. M=C3=A4rz 2017 um 20:46 = Uhr: > >> > From: Philipp Stephani >> > Date: Sun, 26 Mar 2017 18:21:01 +0000 >> > Cc: 25478@debbugs.gnu.org >> > >> > All in all, I think this option is subtly dangerous and should be >> > either deprecated or completely reimplemented to invoke >> > basic-save-buffer instead. I'm quite sure this option made sense in >> > the past, when complications with encoding and save-related hooks >> > didn't exist, but that is no longer the case in Emacs these days. >> > If someone thinks using this option will allow them not to bother wit= h >> > saving their edits, they are in for an unpleasant surprise. >> > >> > That's quite unfortunate, as not having to bother with saving edits >> manually is a very desirable feature that I >> > think Emacs should offer out of the box. >> > >> > If you really want to deprecate auto-save-visited-file-name, how about >> adding a simple global minor mode that >> > invokes save-some-buffers from an idle timer to files.el? >> >> As I wrote, I'm also okay with Someone=E2=84=A2 volunteering to reimplem= ent >> this option such that it invokes basic-save-buffer instead. >> >> A minor mode that you describe would also be fine, but then it should >> probably disable auto-saving if auto-save-visited-file-name is set, >> right? >> > > Sounds reasonable. I'll try to come up with something by next weekend. > Probably it will be just > > (defvar auto-save--timer nil) > (defcustom auto-save-visited-interval 5 > "seconds" > :group 'files > :type 'number > :set (lambda (symbol value) > (set-default symbol value) > (when auto-save--timer > (timer-set-idle-time auto-save--timer value :repeat)))) > (define-minor-mode auto-save-visited-mode nil > :group 'files > :global t > (when auto-save--timer (kill-timer auto-save--timer)) > (setq auto-save--timer > (when auto-save-visited-mode > (run-with-idle-timer > auto-save-visited-interval :repeat > #'save-some-buffers :no-prompt > (lambda () > (not (and buffer-auto-save-file-name > auto-save-visited-file-name))))))) > > but it will also need tests and documentation, which take a bit more time= . > Here's a patch. --f403045eade26d179c054dc6028f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Philip= p Stephani <p.stephani2@gmail.c= om> schrieb am So., 26. M=C3=A4rz 2017 um 21:17=C2=A0Uhr:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
<= div dir=3D"ltr">Eli Zaretskii <eliz@gnu.org> schrieb am So., 26. M=C3=A4rz 2017 um 20:46= =C2=A0Uhr:
> From: Philipp Steph= ani <p.stephani2@gmail.com>
> Date: Sun, 26 Mar 2017 18:21:01 +0000
> Cc: 25478@debbugs.gnu.org
>
>=C2=A0 All in all, I think this option is subtly dangerous and should b= e
>=C2=A0 either deprecated or completely reimplemented to invoke
>=C2=A0 basic-save-buffer instead. I'm quite sure this option made s= ense in
>=C2=A0 the past, when complications with encoding and save-related hook= s
>=C2=A0 didn't exist, but that is no longer the case in Emacs these = days.
>=C2=A0 If someone thinks using this option will allow them not to bothe= r with
>=C2=A0 saving their edits, they are in for an unpleasant surprise.
>
> That's quite unfortunate, as not having to bother with saving edit= s manually is a very desirable feature that I
> think Emacs should offer out of the box.
>
> If you really want to deprecate auto-save-visited-file-name, how about= adding a simple global minor mode that
> invokes save-some-buffers from an idle timer to files.el?

As I wrote, I'm also okay with Someone=E2=84=A2 volunteering to reimple= ment
this option such that it invokes basic-save-buffer instead.

A minor mode that you describe would also be fine, but then it should
probably disable auto-saving if auto-save-visited-file-name is set,
right?

<= /div>
Sounds re= asonable. I'll try to come up with something by next weekend. Probably = it will be just=C2=A0

(defvar auto-save--timer nil= )
(defcustom auto-save-visited-interval 5
=C2=A0 &q= uot;seconds"
=C2=A0 :group 'files
=C2=A0 :type= 'number
=C2=A0 :set (lambda (symbol value)
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0(set-default symbol value)
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0(when auto-save--timer
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0(timer-set-idle-time auto-save--timer value :repeat= ))))
(define-minor-mode auto-save-visited-mode nil
= =C2=A0 :group 'files
=C2=A0 :global t
=C2=A0 (when = auto-save--timer (kill-timer auto-save--timer))
=C2=A0 (setq auto= -save--timer
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (when auto-save-visited-= mode
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (run-with-idle-timer
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0auto-save-visited-interval := repeat
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#'save-some-b= uffers :no-prompt
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(lambd= a ()
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(not (and bu= ffer-auto-save-file-name auto-save-visited-file-name)))))))

<= /div>
but it will also need tests and documentation, which take a bit m= ore time.

Here's a pa= tch.=C2=A0
--f403045eade26d179c054dc6028f-- --f403045eade26d17a5054dc60291 Content-Type: text/plain; charset=US-ASCII; name="0001-Reimplement-auto-saving-to-visited-files.txt" Content-Disposition: attachment; filename="0001-Reimplement-auto-saving-to-visited-files.txt" Content-Transfer-Encoding: base64 Content-ID: <15b970a9fd9c5bca6e21> X-Attachment-Id: 15b970a9fd9c5bca6e21 RnJvbSAyYTE0NjM2YTA2MTBkMWJjNmUwMjRhNTZiNzg4YTU3NWMwMzlmNzg0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwIFN0ZXBoYW5pIDxwaHN0QGdvb2dsZS5jb20+CkRh dGU6IFNhdCwgMjIgQXByIDIwMTcgMjA6NTg6MzggKzAyMDAKU3ViamVjdDogW1BBVENIXSBSZWlt cGxlbWVudCBhdXRvLXNhdmluZyB0byB2aXNpdGVkIGZpbGVzCgpUaGlzIHJlYWN0cyB0byBjb25m dXNpbmcgYmVoYXZpb3Igb2YgJ2F1dG8tc2F2ZS12aXNpdGVkLWZpbGUtbmFtZScsCmNmLiBCdWcj MjU0NzguCgoqIGxpc3AvZmlsZXMuZWwgKGF1dG8tc2F2ZS12aXNpdGVkLWludGVydmFsKTogTmV3 IGN1c3RvbWl6YXRpb24gb3B0aW9uLgooYXV0by1zYXZlLXZpc2l0ZWQtbW9kZSk6IE5ldyBnbG9i YWwgbWlub3IgbW9kZS4KKGF1dG8tc2F2ZS12aXNpdGVkLWZpbGUtbmFtZSk6IE1ha2Ugb2Jzb2xl dGUuCihhdXRvLXNhdmUtLXRpbWVyKTogTmV3IGludGVybmFsIGhlbHBlciB2YXJpYWJsZS4KCiog ZG9jL2VtYWNzL2ZpbGVzLnRleGkgKEF1dG8gU2F2ZSBGaWxlcyk6IERvY3VtZW50CidhdXRvLXNh dmUtdmlzaXRlZC1tb2RlJyBpbnN0ZWFkIG9mIG9ic29sZXRlCidhdXRvLXNhdmUtdmlzaXRlZC1m aWxlLW5hbWUnLgooQXV0byBTYXZlIENvbnRyb2wpOiBEb2N1bWVudCBjdXN0b21pemF0aW9uIG9w dGlvbgonYXV0by1zYXZlLXZpc2l0ZWQtaW50ZXJ2YWwnLgotLS0KIGRvYy9lbWFjcy9maWxlcy50 ZXhpIHwgMjAgKysrKysrKysrKysrKy0tLS0tLS0KIGV0Yy9ORVdTICAgICAgICAgICAgIHwgIDYg KysrKysrCiBsaXNwL2ZpbGVzLmVsICAgICAgICB8IDM5ICsrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCA1OCBpbnNlcnRpb25zKCspLCA3IGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9lbWFjcy9maWxlcy50ZXhpIGIvZG9jL2VtYWNz L2ZpbGVzLnRleGkKaW5kZXggZWQxN2Y2NmNhMi4uMDhjOGJlZWQ5NiAxMDA2NDQKLS0tIGEvZG9j L2VtYWNzL2ZpbGVzLnRleGkKKysrIGIvZG9jL2VtYWNzL2ZpbGVzLnRleGkKQEAgLTEwNDAsMTQg KzEwNDAsMTMgQEAgQXV0byBTYXZlIEZpbGVzCiB0aGlzIGhhcHBlbnMsIHNhdmUgdGhlIGJ1ZmZl ciB3aXRoIEBrYmR7Qy14IEMtc30sIG9yIHVzZSBAa2Jke0MtdSAxIE0teAogYXV0by1zYXZlLW1v ZGV9LgogCi1AdmluZGV4IGF1dG8tc2F2ZS12aXNpdGVkLWZpbGUtbmFtZQorQHZpbmRleCBhdXRv LXNhdmUtdmlzaXRlZC1tb2RlCiAgIElmIHlvdSB3YW50IGF1dG8tc2F2aW5nIHRvIGJlIGRvbmUg aW4gdGhlIHZpc2l0ZWQgZmlsZSByYXRoZXIgdGhhbgotaW4gYSBzZXBhcmF0ZSBhdXRvLXNhdmUg ZmlsZSwgc2V0IHRoZSB2YXJpYWJsZQotQGNvZGV7YXV0by1zYXZlLXZpc2l0ZWQtZmlsZS1uYW1l fSB0byBhIG5vbi1AY29kZXtuaWx9IHZhbHVlLiAgSW4gdGhpcwotbW9kZSwgYXV0by1zYXZpbmcg aXMgdmVyeSBzaW1pbGFyIHRvIGV4cGxpY2l0IHNhdmluZy4gIEhvd2V2ZXIsCi1kaWZmZXJlbmNl cyBzdGlsbCBleGlzdCwgaW4gcGFydGljdWxhciBmb3IgbW9kZXMgd2hpY2ggbW9kaWZ5IHRoZQot YnVmZmVyLXNhdmluZyBwcm9jZXNzIGluIG5vbi10cml2aWFsIHdheXMgdmlhIHZhcmlvdXMgaG9v a3MKLShAcHhyZWZ7U2F2aW5nIEJ1ZmZlcnMsLCwgZWxpc3AsIFRoZSBFbWFjcyBMaXNwIFJlZmVy ZW5jZSBNYW51YWx9KS4KK2luIGEgc2VwYXJhdGUgYXV0by1zYXZlIGZpbGUsIGVuYWJsZSB0aGUg Z2xvYmFsIG1pbm9yIG1vZGUKK0Bjb2Rle2F1dG8tc2F2ZS12aXNpdGVkLW1vZGV9LiAgSW4gdGhp cyBtb2RlLCBhdXRvLXNhdmluZyBpcyB2ZXJ5CitzaW1pbGFyIHRvIGV4cGxpY2l0IHNhdmluZy4g IE5vdGUgdGhhdCB0aGlzIG1vZGUgaXMgb3J0aG9nb25hbCB0byB0aGUKK0Bjb2Rle2F1dG8tc2F2 ZX0gbW9kZSBkZXNjcmliZWQgYWJvdmU7IHlvdSBjYW4gZW5hYmxlIGJvdGggYXQgdGhlIHNhbWUK K3RpbWUuCiAKIEB2aW5kZXggZGVsZXRlLWF1dG8tc2F2ZS1maWxlcwogICBBIGJ1ZmZlcidzIGF1 dG8tc2F2ZSBmaWxlIGlzIGRlbGV0ZWQgd2hlbiB5b3Ugc2F2ZSB0aGUgYnVmZmVyIGluIGl0cwpA QCAtMTA5MSw2ICsxMDkwLDEzIEBAIEF1dG8gU2F2ZSBDb250cm9sCiBhIHdoaWxlOyBzZWNvbmQs IGl0IG1heSBhdm9pZCBzb21lIGF1dG8tc2F2aW5nIHdoaWxlIHlvdSBhcmUgYWN0dWFsbHkKIHR5 cGluZy4KIAorQHZpbmRleCBhdXRvLXNhdmUtdmlzaXRlZC1pbnRlcnZhbAorICBXaGVuIEBjb2Rl e2F1dG8tc2F2ZS12aXNpdGVkLW1vZGV9IGlzIGVuYWJsZWQsIEVtYWNzIHdpbGwgYXV0by1zYXZl CitmaWxlLXZpc2l0aW5nIGJ1ZmZlcnMgYWZ0ZXIgZml2ZSBzZWNvbmRzIG9mIGlkbGUgdGltZS4g IFlvdSBjYW4KK2N1c3RvbWl6ZSB0aGUgdmFyaWFibGUgQGNvZGV7YXV0by1zYXZlLXZpc2l0ZWQt aW50ZXJ2YWx9IHRvIGNoYW5nZSB0aGUKK2lkbGUgdGltZSBpbnRlcnZhbC4gIEBjb2Rle2F1dG8t c2F2ZS1pbnRlcnZhbH0gYW5kCitAY29kZXthdXRvLXNhdmUtdGltZW91dH0gaGF2ZSBubyBlZmZl Y3Qgb24gdGhpcyBtb2RlLgorCiAgIEVtYWNzIGFsc28gZG9lcyBhdXRvLXNhdmluZyB3aGVuZXZl ciBpdCBnZXRzIGEgZmF0YWwgZXJyb3IuICBUaGlzCiBpbmNsdWRlcyBraWxsaW5nIHRoZSBFbWFj cyBqb2Igd2l0aCBhIHNoZWxsIGNvbW1hbmQgc3VjaCBhcyBAc2FtcHtraWxsCiAlZW1hY3N9LCBv ciBkaXNjb25uZWN0aW5nIGEgcGhvbmUgbGluZSBvciBuZXR3b3JrIGNvbm5lY3Rpb24uCmRpZmYg LS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IDcyODE4Mjc4NzguLjJmMTAyNzZkMTIg MTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC0zODMsNiArMzgzLDEyIEBA IFN0cmluZ3Mgc3VjaCBhcyDOjM6jzp/OoyBhcmUgbm93IGNvcnJlY3RseSBjb252ZXJ0ZWQgdG8g zozPg86/z4Igd2hlbgogY2FwaXRhbGl6ZWQgaW5zdGVhZCBvZiBpbmNvcnJlY3QgzozPg86/z4Mg KGNvbXBhcmUgbG93ZXJjYXNlIHNpZ21hIGF0IHRoZQogZW5kIG9mIHRoZSB3b3JkKS4KIAorKiog RW1hY3MgY2FuIG5vdyBhdXRvLXNhdmUgYnVmZmVycyB0byB2aXNpdGVkIGZpbGVzIGluIGEgbW9y ZSByb2J1c3QKK21hbm5lciB2aWEgdGhlIG5ldyBtb2RlICdhdXRvLXNhdmUtdmlzaXRlZC1tb2Rl Jy4gIFVubGlrZQorJ2F1dG8tc2F2ZS12aXNpdGVkLWZpbGUtbmFtZScsIHRoaXMgbW9kZSB1c2Vz IHRoZSBub3JtYWwgc2F2aW5nCitwcm9jZWR1cmUgYW5kIHRoZXJlZm9yZSBvYmV5cyBzYXZpbmcg aG9va3MuCisnYXV0by1zYXZlLXZpc2l0ZWQtZmlsZS1uYW1lJyBpcyBub3cgb2Jzb2xldGUuCisK IAwKICogQ2hhbmdlcyBpbiBTcGVjaWFsaXplZCBNb2RlcyBhbmQgUGFja2FnZXMgaW4gRW1hY3Mg MjYuMQogCmRpZmYgLS1naXQgYS9saXNwL2ZpbGVzLmVsIGIvbGlzcC9maWxlcy5lbAppbmRleCA2 ODQ4ODE4Y2FkLi5jZjkwMzdlYzY4IDEwMDY0NAotLS0gYS9saXNwL2ZpbGVzLmVsCisrKyBiL2xp c3AvZmlsZXMuZWwKQEAgLTM5Myw2ICszOTMsNDUgQEAgYXV0by1zYXZlLWZpbGUtbmFtZS10cmFu c2Zvcm1zCiAgIDppbml0aWFsaXplICdjdXN0b20taW5pdGlhbGl6ZS1kZWxheQogICA6dmVyc2lv biAiMjEuMSIpCiAKKyhkZWZ2YXIgYXV0by1zYXZlLS10aW1lciBuaWwgIlRpbWVyIGZvciBgYXV0 by1zYXZlLXZpc2l0ZWQtbW9kZScuIikKKworKGRlZmN1c3RvbSBhdXRvLXNhdmUtdmlzaXRlZC1p bnRlcnZhbCA1CisgICJJbnRlcnZhbCBpbiBzZWNvbmRzIGZvciBgYXV0by1zYXZlLXZpc2l0ZWQt bW9kZScuCitJZiBgYXV0by1zYXZlLXZpc2l0ZWQtbW9kZScgaXMgZW5hYmxlZCwgRW1hY3Mgd2ls bCBzYXZlIGFsbAorYnVmZmVycyB2aXNpdGluZyBhIGZpbGUgdG8gdGhlIHZpc2l0ZWQgZmlsZSBh ZnRlciBpdCBoYXMgYmVlbgoraWRsZSBmb3IgYGF1dG8tc2F2ZS12aXNpdGVkLWludGVydmFsJyBz ZWNvbmRzLiIKKyAgOmdyb3VwICdhdXRvLXNhdmUKKyAgOnR5cGUgJ251bWJlcgorICA6c2V0IChs YW1iZGEgKHN5bWJvbCB2YWx1ZSkKKyAgICAgICAgIChzZXQtZGVmYXVsdCBzeW1ib2wgdmFsdWUp CisgICAgICAgICAod2hlbiBhdXRvLXNhdmUtLXRpbWVyCisgICAgICAgICAgICh0aW1lci1zZXQt aWRsZS10aW1lIGF1dG8tc2F2ZS0tdGltZXIgdmFsdWUgOnJlcGVhdCkpKSkKKworKGRlZmluZS1t aW5vci1tb2RlIGF1dG8tc2F2ZS12aXNpdGVkLW1vZGUKKyAgIlRvZ2dsZSBhdXRvbWF0aWMgc2F2 aW5nIHRvIGZpbGUtdmlzaXRpbmcgYnVmZmVycyBvbiBvciBvZmYuCitXaXRoIGEgcHJlZml4IGFy Z3VtZW50IEFSRywgZW5hYmxlIHJlZ3VsYXIgc2F2aW5nIG9mIGFsbCBidWZmZXJzCit2aXNpbmcg YSBmaWxlIGlmIEFSRyBpcyBwb3NpdGl2ZSwgYW5kIGRpc2FibGUgaXQgb3RoZXJ3aXNlLgorVW5s aWtlIGBhdXRvLXNhdmUtbW9kZScsIHRoaXMgbW9kZSB3aWxsIGF1dG8tc2F2ZSBidWZmZXIgY29u dGVudHMKK3RvIHRoZSB2aXNpdGVkIGZpbGVzIGRpcmVjdGx5IGFuZCB3aWxsIGFsc28gcnVuIGFs bCBzYXZlLXJlbGF0ZWQKK2hvb2tzLiAgU2VlIEluZm8gbm9kZSBgU2F2aW5nJyBmb3IgZGV0YWls cyBvZiB0aGUgc2F2ZSBwcm9jZXNzLgorCitJZiBjYWxsZWQgZnJvbSBMaXNwLCBlbmFibGUgdGhl IG1vZGUgaWYgQVJHIGlzIG9taXR0ZWQgb3IgbmlsLAorYW5kIHRvZ2dsZSBpdCBpZiBBUkcgaXMg YHRvZ2dsZScuIgorICA6Z3JvdXAgJ2F1dG8tc2F2ZQorICA6Z2xvYmFsIHQKKyAgKHdoZW4gYXV0 by1zYXZlLS10aW1lciAoa2lsbC10aW1lciBhdXRvLXNhdmUtLXRpbWVyKSkKKyAgKHNldHEgYXV0 by1zYXZlLS10aW1lcgorICAgICAgICAod2hlbiBhdXRvLXNhdmUtdmlzaXRlZC1tb2RlCisgICAg ICAgICAgKHJ1bi13aXRoLWlkbGUtdGltZXIKKyAgICAgICAgICAgYXV0by1zYXZlLXZpc2l0ZWQt aW50ZXJ2YWwgOnJlcGVhdAorICAgICAgICAgICAjJ3NhdmUtc29tZS1idWZmZXJzIDpuby1wcm9t cHQKKyAgICAgICAgICAgKGxhbWJkYSAoKQorICAgICAgICAgICAgIChub3QgKGFuZCBidWZmZXIt YXV0by1zYXZlLWZpbGUtbmFtZQorICAgICAgICAgICAgICAgICAgICAgICBhdXRvLXNhdmUtdmlz aXRlZC1maWxlLW5hbWUpKSkpKSkpCisKKyhtYWtlLW9ic29sZXRlLXZhcmlhYmxlICdhdXRvLXNh dmUtdmlzaXRlZC1maWxlLW5hbWUgJ2F1dG8tc2F2ZS12aXNpdGVkLW1vZGUKKyAgICAgICAgICAg ICAgICAgICAgICAgICJFbWFjcyAyNi4xIikKKwogKGRlZmN1c3RvbSBzYXZlLWFiYnJldnMgdAog ICAiTm9uLW5pbCBtZWFucyBzYXZlIHdvcmQgYWJicmV2cyB0b28gd2hlbiBmaWxlcyBhcmUgc2F2 ZWQuCiBJZiBgc2lsZW50bHknLCBkb24ndCBhc2sgdGhlIHVzZXIgYmVmb3JlIHNhdmluZy4iCi0t IAoyLjEyLjIKCg== --f403045eade26d17a5054dc60291-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 28 05:28:04 2017 Received: (at 25478) by debbugs.gnu.org; 28 Apr 2017 09:28:04 +0000 Received: from localhost ([127.0.0.1]:43592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d42C4-00064C-9g for submit@debbugs.gnu.org; Fri, 28 Apr 2017 05:28:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35043) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d42C2-00063i-AG for 25478@debbugs.gnu.org; Fri, 28 Apr 2017 05:28:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d42Bt-0001Oj-O1 for 25478@debbugs.gnu.org; Fri, 28 Apr 2017 05:27:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d42Bt-0001Of-Jj; Fri, 28 Apr 2017 05:27:53 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2702 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d42Bs-0002Uu-Oe; Fri, 28 Apr 2017 05:27:53 -0400 Date: Fri, 28 Apr 2017 12:27:19 +0300 Message-Id: <83mvb0naq0.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-reply-to: (message from Philipp Stephani on Sat, 22 Apr 2017 19:01:50 +0000) Subject: Re: bug#25478: 26.0.50; No hooks are called when auto-saving References: <837f5q6rxq.fsf@gnu.org> <83wpbb98rc.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25478 Cc: rgm@gnu.org, 25478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Philipp Stephani > Date: Sat, 22 Apr 2017 19:01:50 +0000 > Cc: rgm@gnu.org, 25478@debbugs.gnu.org > > Here's a patch. Thanks. A few minor comments: > --- a/doc/emacs/files.texi > +++ b/doc/emacs/files.texi > @@ -1040,14 +1040,13 @@ Auto Save Files > this happens, save the buffer with @kbd{C-x C-s}, or use @kbd{C-u 1 M-x > auto-save-mode}. > > -@vindex auto-save-visited-file-name > +@vindex auto-save-visited-mode I wonder whether auto-save-files-mode is a better name, as the "visited" part looks now out of place. (If you do rename it, please also rename the time-interval variable accordingly.) > +in a separate auto-save file, enable the global minor mode > +@code{auto-save-visited-mode}. In this mode, auto-saving is very > +similar to explicit saving. "Very similar" begs the question "what's the difference?" If there are differences, let's describe them; if there aren't, let's say "identical to" or "the same as". > Note that this mode is orthogonal to the > +@code{auto-save} mode described above; you can enable both at the same > +time. But if auto-save mode is enabled and auto-save-visited-file-name is set, then this new mode will not auto-save, right? This should be documented. > @@ -1091,6 +1090,13 @@ Auto Save Control > a while; second, it may avoid some auto-saving while you are actually > typing. > > +@vindex auto-save-visited-interval I suggest to mention this variable where you describe the new mode, since the two descriptions are several tens of lines apart. > + When @code{auto-save-visited-mode} is enabled, Emacs will auto-save > +file-visiting buffers after five seconds of idle time. You can > +customize the variable @code{auto-save-visited-interval} to change the > +idle time interval. @code{auto-save-interval} and > +@code{auto-save-timeout} have no effect on this mode. I think the last sentence should be part of the description of the mode, not of the variable. Doing so will also provide a good opportunity to mention auto-save-visited-interval. > +(defcustom auto-save-visited-interval 5 > + "Interval in seconds for `auto-save-visited-mode'. > +If `auto-save-visited-mode' is enabled, Emacs will save all > +buffers visiting a file to the visited file after it has been > +idle for `auto-save-visited-interval' seconds." > + :group 'auto-save > + :type 'number > + :set (lambda (symbol value) > + (set-default symbol value) > + (when auto-save--timer > + (timer-set-idle-time auto-save--timer value :repeat)))) Please add a :version tag to new defcustoms. > +(define-minor-mode auto-save-visited-mode > + "Toggle automatic saving to file-visiting buffers on or off. > +With a prefix argument ARG, enable regular saving of all buffers > +vising a file if ARG is positive, and disable it otherwise. ^^^^^^ A typo. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 29 14:47:42 2017 Received: (at 25478) by debbugs.gnu.org; 29 Apr 2017 18:47:42 +0000 Received: from localhost ([127.0.0.1]:46612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d4XPC-0001Bg-CA for submit@debbugs.gnu.org; Sat, 29 Apr 2017 14:47:42 -0400 Received: from mail-wr0-f169.google.com ([209.85.128.169]:34734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d4XPA-0001BT-Rr for 25478@debbugs.gnu.org; Sat, 29 Apr 2017 14:47:41 -0400 Received: by mail-wr0-f169.google.com with SMTP id l9so47888359wre.1 for <25478@debbugs.gnu.org>; Sat, 29 Apr 2017 11:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ypUokuhZEY4ji4JPwNBrQ/i/rpqsUARGH1swP5hFyGQ=; b=FG4Q872DEYDrGxCJ50mcJnVqJRY1vWW7lf2vhftANRUOMURKB8ikZ97nhleyT5w55e Ex1behFLJ9vp5MRMPzx6RoQZV2xiwFArggBaaI3gLVeN2QGUgjz0EpmeeIZRVDkLFKqO 0IDtUagzOacWANo9nbwwHlec5pvxXME9bnF+kna62SY6QvQY71Z6t/VVpTME9wg+8PEL TOuKuW0y+MNeqPEG+imqMb7F6jZf+cMl4RxFW7/gwdZzXDz/4mh5PubsGX1lW/c0+vXf d6NXvTEzEcRC44A0j0amrcMyIMNKtDllkw/2j3c4615vbMp+SL6n8gDXPtOLWYIxNSfj kJPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ypUokuhZEY4ji4JPwNBrQ/i/rpqsUARGH1swP5hFyGQ=; b=cEtG/0yZkW+BfTuuk0VsNIVYIpf2tYfe8PgSCovvLcYJ9QFkxbQMToiaDEc6SVrKBi Uk4yR3oJ6J0bQ8M0KEQ4bQ3rpLrrbkOSpTPjvm2BL+wJfcqOq87ndVmE6d7ESoBoWJEM qCYPDP/F5iBL+ZT4npNhYqKmt2tap/C/VjubZetA0mh7qs7DL2UJiYla2hwOhgGZk3nW +6phh3KLqJsvVH64hB+C9DZixH9TfyfyPWAfdKL/0IWJaj3h1PdgRPhvG08SCq9VMmY/ +RFMzVdz/iEaSzo203SEb6OHyfDDO+QWimFjgV0/uURyD/BBZSpid/SqSCijDDlkxu6c oeGQ== X-Gm-Message-State: AN3rC/7aVdILjkunYa4eW0EwsWG2++wSADa0T7lw8AoKnhWVQHT+xk10 TzuqrXeGn45wY2eLb7hYIXS3Um3+rw== X-Received: by 10.223.148.35 with SMTP id 32mr5247268wrq.175.1493491655100; Sat, 29 Apr 2017 11:47:35 -0700 (PDT) MIME-Version: 1.0 References: <837f5q6rxq.fsf@gnu.org> <83wpbb98rc.fsf@gnu.org> <83mvb0naq0.fsf@gnu.org> In-Reply-To: <83mvb0naq0.fsf@gnu.org> From: Philipp Stephani Date: Sat, 29 Apr 2017 18:47:24 +0000 Message-ID: Subject: Re: bug#25478: 26.0.50; No hooks are called when auto-saving To: Eli Zaretskii Content-Type: multipart/alternative; boundary=94eb2c0d21c293cf6f054e529f13 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 25478 Cc: rgm@gnu.org, 25478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) --94eb2c0d21c293cf6f054e529f13 Content-Type: text/plain; charset=UTF-8 Eli Zaretskii schrieb am Fr., 28. Apr. 2017 um 11:28 Uhr: > > From: Philipp Stephani > > Date: Sat, 22 Apr 2017 19:01:50 +0000 > > Cc: rgm@gnu.org, 25478@debbugs.gnu.org > > > > Here's a patch. > > Thanks. A few minor comments: > > > --- a/doc/emacs/files.texi > > +++ b/doc/emacs/files.texi > > @@ -1040,14 +1040,13 @@ Auto Save Files > > this happens, save the buffer with @kbd{C-x C-s}, or use @kbd{C-u 1 M-x > > auto-save-mode}. > > > > -@vindex auto-save-visited-file-name > > +@vindex auto-save-visited-mode > > I wonder whether auto-save-files-mode is a better name, as the > "visited" part looks now out of place. (If you do rename it, please > also rename the time-interval variable accordingly.) > I think the name should be sufficiently different from auto-save-mode so that the modes can't be confused. auto-save-files-mode would be confusing, because auto-save-mode also saves files. I think including the "visited" word is useful here because it's the meaningful distinction between the modes: one uses the visited file name, the other doesn't. > > > +in a separate auto-save file, enable the global minor mode > > +@code{auto-save-visited-mode}. In this mode, auto-saving is very > > +similar to explicit saving. > > "Very similar" begs the question "what's the difference?" If there > are differences, let's describe them; if there aren't, let's say > "identical to" or "the same as". > Done. > > > Note that this mode is orthogonal to the > > +@code{auto-save} mode described above; you can enable both at the same > > +time. > > But if auto-save mode is enabled and auto-save-visited-file-name is > set, then this new mode will not auto-save, right? This should be > documented. > Done. > > > @@ -1091,6 +1090,13 @@ Auto Save Control > > a while; second, it may avoid some auto-saving while you are actually > > typing. > > > > +@vindex auto-save-visited-interval > > I suggest to mention this variable where you describe the new mode, > since the two descriptions are several tens of lines apart. > Done. > > > + When @code{auto-save-visited-mode} is enabled, Emacs will auto-save > > +file-visiting buffers after five seconds of idle time. You can > > +customize the variable @code{auto-save-visited-interval} to change the > > +idle time interval. @code{auto-save-interval} and > > +@code{auto-save-timeout} have no effect on this mode. > > I think the last sentence should be part of the description of the > mode, not of the variable. Doing so will also provide a good > opportunity to mention auto-save-visited-interval. > Done. > > > +(defcustom auto-save-visited-interval 5 > > + "Interval in seconds for `auto-save-visited-mode'. > > +If `auto-save-visited-mode' is enabled, Emacs will save all > > +buffers visiting a file to the visited file after it has been > > +idle for `auto-save-visited-interval' seconds." > > + :group 'auto-save > > + :type 'number > > + :set (lambda (symbol value) > > + (set-default symbol value) > > + (when auto-save--timer > > + (timer-set-idle-time auto-save--timer value :repeat)))) > > Please add a :version tag to new defcustoms. > Done. > > > +(define-minor-mode auto-save-visited-mode > > + "Toggle automatic saving to file-visiting buffers on or off. > > +With a prefix argument ARG, enable regular saving of all buffers > > +vising a file if ARG is positive, and disable it otherwise. > ^^^^^^ > A typo. > Done. --94eb2c0d21c293cf6f054e529f13 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Fr., 28. Apr. 2017 um 11:28=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sat, 22 Apr 2017 19:01:50 +0000
> Cc: rgm@gnu.org, = 25478@debbugs.gn= u.org
>
> Here's a patch.

Thanks.=C2=A0 A few minor comments:

> --- a/doc/emacs/files.texi
> +++ b/doc/emacs/files.texi
> @@ -1040,14 +1040,13 @@ Auto Save Files
>=C2=A0 this happens, save the buffer with @kbd{C-x C-s}, or use @kbd{C-= u 1 M-x
>=C2=A0 auto-save-mode}.
>
> -@vindex auto-save-visited-file-name
> +@vindex auto-save-visited-mode

I wonder whether auto-save-files-mode is a better name, as the
"visited" part looks now out of place.=C2=A0 (If you do rename it= , please
also rename the time-interval variable accordingly.)
<= br>
I think the name should be sufficiently different from auto-s= ave-mode so that the modes can't be confused. auto-save-files-mode woul= d be confusing, because auto-save-mode also saves files. I think including = the "visited" word is useful here because it's the meaningful= distinction between the modes: one uses the visited file name, the other d= oesn't.
=C2=A0

> +in a separate auto-save file, enable the global minor mode
> +@code{auto-save-visited-mode}.=C2=A0 In this mode, auto-saving is ver= y
> +similar to explicit saving.

"Very similar" begs the question "what's the difference?= "=C2=A0 If there
are differences, let's describe them; if there aren't, let's sa= y
"identical to" or "the same as".
<= br>
Done.
=C2=A0

>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Note that this mode is orthogonal= to the
> +@code{auto-save} mode described above; you can enable both at the sam= e
> +time.

But if auto-save mode is enabled and auto-save-visited-file-name is
set, then this new mode will not auto-save, right?=C2=A0 This should be
documented.

Done.
=C2=A0

> @@ -1091,6 +1090,13 @@ Auto Save Control
>=C2=A0 a while; second, it may avoid some auto-saving while you are act= ually
>=C2=A0 typing.
>
> +@vindex auto-save-visited-interval

I suggest to mention this variable where you describe the new mode,
since the two descriptions are several tens of lines apart.

Done.
=C2=A0

> +=C2=A0 When @code{auto-save-visited-mode} is enabled, Emacs will auto= -save
> +file-visiting buffers after five seconds of idle time.=C2=A0 You can<= br> > +customize the variable @code{auto-save-visited-interval} to change th= e
> +idle time interval.=C2=A0 @code{auto-save-interval} and
> +@code{auto-save-timeout} have no effect on this mode.

I think the last sentence should be part of the description of the
mode, not of the variable.=C2=A0 Doing so will also provide a good
opportunity to mention auto-save-visited-interval.
Done.
=C2=A0

> +(defcustom auto-save-visited-interval 5
> +=C2=A0 "Interval in seconds for `auto-save-visited-mode'. > +If `auto-save-visited-mode' is enabled, Emacs will save all
> +buffers visiting a file to the visited file after it has been
> +idle for `auto-save-visited-interval' seconds."
> +=C2=A0 :group 'auto-save
> +=C2=A0 :type 'number
> +=C2=A0 :set (lambda (symbol value)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(set-default symbol value)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(when auto-save--timer
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(timer-set-idle-time auto-sa= ve--timer value :repeat))))

Please add a :version tag to new defcustoms.

Done.
=C2=A0

> +(define-minor-mode auto-save-visited-mode
> +=C2=A0 "Toggle automatic saving to file-visiting buffers on or o= ff.
> +With a prefix argument ARG, enable regular saving of all buffers
> +vising a file if ARG is positive, and disable it otherwise.
=C2=A0 =C2=A0^^^^^^
A typo.

Done.=C2=A0
--94eb2c0d21c293cf6f054e529f13-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 29 14:49:32 2017 Received: (at 25478) by debbugs.gnu.org; 29 Apr 2017 18:49:32 +0000 Received: from localhost ([127.0.0.1]:46616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d4XQx-0001Ek-UX for submit@debbugs.gnu.org; Sat, 29 Apr 2017 14:49:32 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:34931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d4XQv-0001EX-Oo for 25478@debbugs.gnu.org; Sat, 29 Apr 2017 14:49:30 -0400 Received: by mail-wm0-f54.google.com with SMTP id w64so64560775wma.0 for <25478@debbugs.gnu.org>; Sat, 29 Apr 2017 11:49:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BWoHug3OsCXR1dWsh5QjuPhH6/ncB+wxTisWvDMEDHs=; b=DrZ23E/E0IKr4Xfcw9sCxSr7iUT0cHt6YPMKIAee0L+K1jI0gLI6xjyk2gZ3AZHwR+ eGIzfHw+MW9rdGnUEJOLXOkJ0iQ+C578DXMLKAggPwNvBlmiCwV5joypR28Gcb3/XrbW ItymXlQodcfwEf1RTM5vkX1aBMLjN/QYNdl8yEzUT1+UhO08r8VLPnAieDGWGCDU0mWx MUrX3Mx27EUW6WFoN8d4jEDYgQnPZuSS5jp0c4aXkadmXqu6MDFpFYE9l4L2oXV357tk RHq2b8kRmlv66nVc4/RyLnmIjHmVBK6HcRsqx9y42Aeow9q3EW4a/Eb/6Pc4KMyc0lGG ANSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BWoHug3OsCXR1dWsh5QjuPhH6/ncB+wxTisWvDMEDHs=; b=G3DxrB4nnsycbQ6yTPmbgBZ+SNHYpQhAO9kH/Ww1h86Kt2UHN5nwTOtkNq2aXugDqb 4U7Qs+qGREeVkyVnvODk+UqtUV0apBuF82FMWvwgnjMDu7ZxGwWhvIoMwboGc8ghhk+H 6o24v1J2pAzDddbEx2gmsgGMH5Jp5y6ilDi0XL1dMSn0GXr6ddPZ95Pl3XBzpwVgKskA Zdh77TA44PXHkgBIkqXZqvZT4dPtcgB4XbCNKwK5yd274Yx9PaO9a0fxzgX/N60kjsXD XCpmMTK2Q5EhTAGMJDAU3f62DFOjf16gK8PjAvzeLHqy3ghsfJBFYo+wS0Xz6nO/oh+z Au2A== X-Gm-Message-State: AN3rC/5uAiFYy1Gl78c0ZXlf0M2m58QJY/ktBjUHCT1FIJS3NHuiyKiM HOnEpWMhHrMoBA== X-Received: by 10.28.48.11 with SMTP id w11mr2020193wmw.77.1493491763847; Sat, 29 Apr 2017 11:49:23 -0700 (PDT) Received: from p.cm.cablesurf.de (46.128.198.151.dynamic.cablesurf.de. [46.128.198.151]) by smtp.gmail.com with ESMTPSA id j124sm11168428wmg.13.2017.04.29.11.49.22 (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 29 Apr 2017 11:49:23 -0700 (PDT) From: Philipp Stephani X-Google-Original-From: Philipp Stephani To: eliz@gnu.org, emacs-devel@gnu.org, 25478@debbugs.gnu.org, rgm@gnu.org Subject: [PATCH] Reimplement auto-saving to visited files Date: Sat, 29 Apr 2017 20:49:09 +0200 Message-Id: <20170429184909.40204-1-phst@google.com> X-Mailer: git-send-email 2.12.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 25478 Cc: Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) This reacts to confusing behavior of 'auto-save-visited-file-name', cf. Bug#25478. * lisp/files.el (auto-save-visited-interval): New customization option. (auto-save-visited-mode): New global minor mode. (auto-save-visited-file-name): Make obsolete. (auto-save--timer): New internal helper variable. * doc/emacs/files.texi (Auto Save Files): Document 'auto-save-visited-mode' instead of obsolete 'auto-save-visited-file-name'. (Auto Save Control): Document customization option 'auto-save-visited-interval'. --- doc/emacs/files.texi | 29 ++++++++++++++++++++++------- etc/NEWS | 6 ++++++ lisp/files.el | 40 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 68 insertions(+), 7 deletions(-) diff --git a/doc/emacs/files.texi b/doc/emacs/files.texi index ed17f66ca2..55eda00d0c 100644 --- a/doc/emacs/files.texi +++ b/doc/emacs/files.texi @@ -1040,14 +1040,23 @@ Auto Save Files this happens, save the buffer with @kbd{C-x C-s}, or use @kbd{C-u 1 M-x auto-save-mode}. -@vindex auto-save-visited-file-name +@vindex auto-save-visited-mode If you want auto-saving to be done in the visited file rather than -in a separate auto-save file, set the variable -@code{auto-save-visited-file-name} to a non-@code{nil} value. In this -mode, auto-saving is very similar to explicit saving. However, -differences still exist, in particular for modes which modify the -buffer-saving process in non-trivial ways via various hooks -(@pxref{Saving Buffers,,, elisp, The Emacs Lisp Reference Manual}). +in a separate auto-save file, enable the global minor mode +@code{auto-save-visited-mode}. In this mode, auto-saving is identical +to explicit saving. Note that this mode is orthogonal to the +@code{auto-save} mode described above; you can enable both at the same +time. However, if @code{auto-save} mode is active in some buffer and +the obsolete @code{auto-save-visited-file-name} variable is set to a +non-@code{nil} value, that buffer won't be affected by +@code{auto-save-visited-mode}. + + You can use the variable @code{auto-save-visited-interval} to +customize the interval between auto-save operations in +@code{auto-save-visited-mode}; by default it's five seconds. +@code{auto-save-interval} and @code{auto-save-timeout} have no effect +on @code{auto-save-visited-mode}. See @xref{Auto Save Control} for +details on these variables. @vindex delete-auto-save-files A buffer's auto-save file is deleted when you save the buffer in its @@ -1091,6 +1100,12 @@ Auto Save Control a while; second, it may avoid some auto-saving while you are actually typing. +@vindex auto-save-visited-interval + When @code{auto-save-visited-mode} is enabled, Emacs will auto-save +file-visiting buffers after five seconds of idle time. You can +customize the variable @code{auto-save-visited-interval} to change the +idle time interval. + Emacs also does auto-saving whenever it gets a fatal error. This includes killing the Emacs job with a shell command such as @samp{kill %emacs}, or disconnecting a phone line or network connection. diff --git a/etc/NEWS b/etc/NEWS index 9d4c72d6dc..173c4e466b 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -383,6 +383,12 @@ Strings such as ΌΣΟΣ are now correctly converted to Όσος when capitalized instead of incorrect Όσοσ (compare lowercase sigma at the end of the word). +** Emacs can now auto-save buffers to visited files in a more robust +manner via the new mode 'auto-save-visited-mode'. Unlike +'auto-save-visited-file-name', this mode uses the normal saving +procedure and therefore obeys saving hooks. +'auto-save-visited-file-name' is now obsolete. + * Changes in Specialized Modes and Packages in Emacs 26.1 diff --git a/lisp/files.el b/lisp/files.el index 6848818cad..d3958b5643 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -393,6 +393,46 @@ auto-save-file-name-transforms :initialize 'custom-initialize-delay :version "21.1") +(defvar auto-save--timer nil "Timer for `auto-save-visited-mode'.") + +(defcustom auto-save-visited-interval 5 + "Interval in seconds for `auto-save-visited-mode'. +If `auto-save-visited-mode' is enabled, Emacs will save all +buffers visiting a file to the visited file after it has been +idle for `auto-save-visited-interval' seconds." + :group 'auto-save + :type 'number + :version "26.1" + :set (lambda (symbol value) + (set-default symbol value) + (when auto-save--timer + (timer-set-idle-time auto-save--timer value :repeat)))) + +(define-minor-mode auto-save-visited-mode + "Toggle automatic saving to file-visiting buffers on or off. +With a prefix argument ARG, enable regular saving of all buffers +visiting a file if ARG is positive, and disable it otherwise. +Unlike `auto-save-mode', this mode will auto-save buffer contents +to the visited files directly and will also run all save-related +hooks. See Info node `Saving' for details of the save process. + +If called from Lisp, enable the mode if ARG is omitted or nil, +and toggle it if ARG is `toggle'." + :group 'auto-save + :global t + (when auto-save--timer (kill-timer auto-save--timer)) + (setq auto-save--timer + (when auto-save-visited-mode + (run-with-idle-timer + auto-save-visited-interval :repeat + #'save-some-buffers :no-prompt + (lambda () + (not (and buffer-auto-save-file-name + auto-save-visited-file-name))))))) + +(make-obsolete-variable 'auto-save-visited-file-name 'auto-save-visited-mode + "Emacs 26.1") + (defcustom save-abbrevs t "Non-nil means save word abbrevs too when files are saved. If `silently', don't ask the user before saving." -- 2.12.2 From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 29 15:21:24 2017 Received: (at 25478) by debbugs.gnu.org; 29 Apr 2017 19:21:25 +0000 Received: from localhost ([127.0.0.1]:46627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d4Xvo-00022a-NO for submit@debbugs.gnu.org; Sat, 29 Apr 2017 15:21:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d4Xvn-00022N-1s for 25478@debbugs.gnu.org; Sat, 29 Apr 2017 15:21:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d4Xvh-0000Yz-9q for 25478@debbugs.gnu.org; Sat, 29 Apr 2017 15:21:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d4Xvd-0000Yi-2d; Sat, 29 Apr 2017 15:21:13 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1501 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d4XvZ-0002eB-Pz; Sat, 29 Apr 2017 15:21:12 -0400 Date: Sat, 29 Apr 2017 22:20:18 +0300 Message-Id: <83r30bkolp.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-reply-to: <20170429184909.40204-1-phst@google.com> (message from Philipp Stephani on Sat, 29 Apr 2017 20:49:09 +0200) Subject: Re: [PATCH] Reimplement auto-saving to visited files References: <20170429184909.40204-1-phst@google.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25478 Cc: phst@google.com, rgm@gnu.org, 25478@debbugs.gnu.org, emacs-devel@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Philipp Stephani > Cc: Philipp Stephani > Date: Sat, 29 Apr 2017 20:49:09 +0200 > > +on @code{auto-save-visited-mode}. See @xref{Auto Save Control} for @xref itself produces "See", so the "See" before it is unnecessary. Other than that, I think this can go in. Thanks for working on this. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 29 15:31:25 2017 Received: (at 25478) by debbugs.gnu.org; 29 Apr 2017 19:31:25 +0000 Received: from localhost ([127.0.0.1]:46635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d4Y5U-0002I7-Tf for submit@debbugs.gnu.org; Sat, 29 Apr 2017 15:31:25 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:37516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d4Y5S-0002Hq-TU for 25478@debbugs.gnu.org; Sat, 29 Apr 2017 15:31:23 -0400 Received: by mail-wm0-f46.google.com with SMTP id m123so71780156wma.0 for <25478@debbugs.gnu.org>; Sat, 29 Apr 2017 12:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zPrD+ZI3d0AptkvPEFkTXlExzaqI025bRTEXDkdjYwY=; b=f5mQuXoLtVn5+O+WVnnzmM6SQtZCD+oiuPHrmLfQyi1pOnrylvvIRJKXXapvBTTHPq FA+JbI0Mdm8x4w1KlWVJDwx0kpFZpHDEMK3TL+rQ3Kycl6fvaXPWyryRL9Oxd3Biz0O6 y2R3b6N9YcNAHz+vPD7X7fpUfxcb0yHYKUhIuOuEK5K5/lOj51xaJbbo+7uT/6EIm9y3 sEj7ClHRLoq8aehcsUD0jwsfjudI9Q6Fdy19VA6E/kgT8MkPD8HroUkCYNIVn8gYKBvg luLfRkl4btm0gpoAgEWeq8IeTF1sMjq6F0QWgWwugcNpoTe0Niq5k2HW9lfBr6pUnWsj odQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zPrD+ZI3d0AptkvPEFkTXlExzaqI025bRTEXDkdjYwY=; b=hYCFa/elGbDPooLnxe7pJ9Z9eHlb/KVl1JIWLmu4KaamhN96JQaD2U4GtTJM7hzJj8 a1fMBN3Ni0giOG6HJwY16J9AxdWsQZQNOBd8PTW5IdSVxPJ9NzLd4iaGyS61Jlu364kh YCFSDVFNO4vxk8Tbhk1KmMI6Mx1fONX94yD/bw/M5kavM52I9u1jHZjHrhZfBCQOykqK EYIiTOy6N8xme+d03vTd5SFpnaT4ykMILO4cnz1k7Y2SXjZAuHzlgxWGTqI/7cDKVD5u uGhFE5To4NQW3CIH57HuHUrt29pumLSPx/ucZa7gZb3Ig7wSqKJmzYpYJq56AQ6ANjSM Z9Dg== X-Gm-Message-State: AN3rC/5/aGNod+8VtG+4EqV5TjoWadXOSs2KHXvP+Y2ZEAGbVT3PbRTV lgaxxlrLCxWbjpu4bCXfr5icUHRs8A== X-Received: by 10.28.156.13 with SMTP id f13mr2260592wme.44.1493494277202; Sat, 29 Apr 2017 12:31:17 -0700 (PDT) MIME-Version: 1.0 References: <20170429184909.40204-1-phst@google.com> <83r30bkolp.fsf@gnu.org> In-Reply-To: <83r30bkolp.fsf@gnu.org> From: Philipp Stephani Date: Sat, 29 Apr 2017 19:31:06 +0000 Message-ID: Subject: Re: [PATCH] Reimplement auto-saving to visited files To: Eli Zaretskii Content-Type: multipart/alternative; boundary=001a114b391addf123054e533bfc X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 25478 Cc: phst@google.com, rgm@gnu.org, 25478@debbugs.gnu.org, emacs-devel@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --001a114b391addf123054e533bfc Content-Type: text/plain; charset=UTF-8 Eli Zaretskii schrieb am Sa., 29. Apr. 2017 um 21:21 Uhr: > > From: Philipp Stephani > > Cc: Philipp Stephani > > Date: Sat, 29 Apr 2017 20:49:09 +0200 > > > > +on @code{auto-save-visited-mode}. See @xref{Auto Save Control} for > > @xref itself produces "See", so the "See" before it is unnecessary. > > Other than that, I think this can go in. Thanks for working on this. > Thanks, pushed as 4db844a453 and 89159e78bb. --001a114b391addf123054e533bfc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Sa., 29. Apr. 2017 um 21:21=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Cc: Philipp Stephani <phst@google.com>
> Date: Sat, 29 Apr 2017 20:49:09 +0200
>
> +on @code{auto-save-visited-mode}.=C2=A0 See @xref{Auto Save Control} = for

@xref itself produces "See", so the "See" before it is = unnecessary.

Other than that, I think this can go in.=C2=A0 Thanks for working on this.<= br>

Thanks, pushed as 4db844a453 and 89159e= 78bb.=C2=A0
--001a114b391addf123054e533bfc-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 11 04:08:42 2020 Received: (at 25478) by debbugs.gnu.org; 11 Aug 2020 08:08:42 +0000 Received: from localhost ([127.0.0.1]:38500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5PKs-0007Pr-0t for submit@debbugs.gnu.org; Tue, 11 Aug 2020 04:08:42 -0400 Received: from mail-yb1-f196.google.com ([209.85.219.196]:38534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5PKq-0007PQ-PQ for 25478@debbugs.gnu.org; Tue, 11 Aug 2020 04:08:41 -0400 Received: by mail-yb1-f196.google.com with SMTP id e187so6594017ybc.5 for <25478@debbugs.gnu.org>; Tue, 11 Aug 2020 01:08:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=RnzhMHLluZA3zLi4tgNCySXtFKzoswMkALi2e4e/Ynk=; b=qhAxGx/P/QzEK7dk0KMCiWdjZFyARr0cTG8hoAqzkfZJOpM17n47tZkDM78D2ah8AJ qoYl0UoUkzQrZvjEwBWO41gyMpigmAh1T36VDMoWBEQPSG6bbNC39n7fMThakplXV/oO 440bh9kkgOrBMS429JuS58aYDO+V4c0b14ocpHzCUq4vSzWO1j4jcF8wQbYOvp+tb8Bg pYByB0xZsdvG30GHSQxmEoxoYpWzkdmmEo2o0+c1k/siz2sMfWx/XbcODZdYCIZYJ/bm zlcpypKXUoeB41R4tQGg8g9+q5OpcknJK4uVDm1LBCM4EaqmMswSbuhJHbbKwGejiKf0 NPWQ== X-Gm-Message-State: AOAM532IdtlCK8YmWpOT9jV+jb9uxSwmDV3z7SthC2oJAyynfBtYKtZM HVfJFJncbXiIN7EQk8Bt3dEC34uHRw1QNqspZI0= X-Google-Smtp-Source: ABdhPJyy+Zk8BV/VWHV04MgKYSU8DUgsMlgn+VAZBb+tMRDHiVjQheXwK9wEyfmg7mZSv6SgeOOAinO9LttoH3iaRyM= X-Received: by 2002:a25:4609:: with SMTP id t9mr44025656yba.231.1597133315403; Tue, 11 Aug 2020 01:08:35 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 11 Aug 2020 01:08:34 -0700 From: Stefan Kangas In-Reply-To: (Philipp Stephani's message of "Sat, 29 Apr 2017 19:31:06 +0000") References: <20170429184909.40204-1-phst@google.com> <83r30bkolp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Tue, 11 Aug 2020 01:08:34 -0700 Message-ID: Subject: Re: bug#25478: [PATCH] Reimplement auto-saving to visited files To: Philipp Stephani Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25478 Cc: phst@google.com, rgm@gnu.org, Eli Zaretskii , 25478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philipp Stephani writes: > Eli Zaretskii schrieb am Sa., 29. Apr. 2017 um 21:21 Uhr: > > > From: Philipp Stephani > > Cc: Philipp Stephani > > Date: Sat, 29 Apr 2017 20:49:09 +0200 > > > > +on @code{auto-save-visited-mode}. See @xref{Auto Save Control} for > > @xref itself produces "See", so the "See" before it is unnecessary. > > Other than that, I think this can go in. Thanks for working on this. > > Thanks, pushed as 4db844a453 and 89159e78bb. It seems like all the patches here were pushed. Should this therefore also be closed, or is there more to do here? Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 01 08:11:59 2020 Received: (at 25478-done) by debbugs.gnu.org; 1 Oct 2020 12:11:59 +0000 Received: from localhost ([127.0.0.1]:34359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNxRG-0007Ld-Uc for submit@debbugs.gnu.org; Thu, 01 Oct 2020 08:11:59 -0400 Received: from mail-ed1-f44.google.com ([209.85.208.44]:46107) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNxRF-0007LP-1H for 25478-done@debbugs.gnu.org; Thu, 01 Oct 2020 08:11:57 -0400 Received: by mail-ed1-f44.google.com with SMTP id 33so5004391edq.13 for <25478-done@debbugs.gnu.org>; Thu, 01 Oct 2020 05:11:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=wTtbFV/T9CQJZCxooCqz8ck/V5/WnsgwUPvzYP285Vc=; b=tAQAaWfK9LAJAuh5C2VLDNGUoncM29l7j53aJdWoXuVlZuo7SrOn0MctAPyTuqhj2H Gy8z3kAB4LEmX6cxGeyy81cX9JPu1lwNj/kzxfGEsHt6CY+ERT5oFlc8tSmkWQhRtYNr TftNNXAUaC+duFNPRBV/3dhbrCRr2CEn9+oYASn6HyEaVACz7X9mH6Vo5Kkz+toRSbng tXDzSm9IMXXdV0rhxTGwBTOrWnNF0ejjw+laGi121b09z3aJWa3pGbuBROp7GbrVH53g Ozb/xSp9Wsu7n4dnYq/lhzDtMAj7O4aF78Q+fahFCgQKZGoYy1+wjma1kDQu73aDYPPd LmHQ== X-Gm-Message-State: AOAM531GMymKBNALCyy32YHvQ3V+6U3rIJ2Oe6x2EQ1SF5NV6yCc3soi DtKud9bcDcs746A8GcATQfac4vLNd2wN3eg4ab0= X-Google-Smtp-Source: ABdhPJyxdoDVm6KgBrT+w3ZwOLF1xKP+azGmo1j4uWGD/K0OXh+KlHJNY8U9r07/lUk8U38f5HDtLWNwguRE5ku7lDk= X-Received: by 2002:a50:e68a:: with SMTP id z10mr8189121edm.100.1601554311364; Thu, 01 Oct 2020 05:11:51 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 1 Oct 2020 05:11:50 -0700 From: Stefan Kangas In-Reply-To: (Stefan Kangas's message of "Tue, 11 Aug 2020 01:08:34 -0700") References: <20170429184909.40204-1-phst@google.com> <83r30bkolp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Thu, 1 Oct 2020 05:11:50 -0700 Message-ID: Subject: Re: bug#25478: [PATCH] Reimplement auto-saving to visited files To: Philipp Stephani Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 25478-done Cc: phst@google.com, rgm@gnu.org, Eli Zaretskii , 25478-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Stefan Kangas writes: > Philipp Stephani writes: > >> Eli Zaretskii schrieb am Sa., 29. Apr. 2017 um 21:21 Uhr: >> >> > From: Philipp Stephani >> > Cc: Philipp Stephani >> > Date: Sat, 29 Apr 2017 20:49:09 +0200 >> > >> > +on @code{auto-save-visited-mode}. See @xref{Auto Save Control} for >> >> @xref itself produces "See", so the "See" before it is unnecessary. >> >> Other than that, I think this can go in. Thanks for working on this. >> >> Thanks, pushed as 4db844a453 and 89159e78bb. > > It seems like all the patches here were pushed. Should this therefore > also be closed, or is there more to do here? More information was requested, but none was given within 7 weeks, so I'm closing this bug. If this is still an issue, please reply to this email (use "Reply to all" in your email client) and we can reopen the bug report. Best regards, Stefan Kangas From unknown Fri Sep 05 22:44:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 30 Oct 2020 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator