GNU bug report logs - #25468
26.0.50; Can't load htmlfontify if shell binary doesn't exist

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25468 in the body.
You can then email your comments to 25468 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; Can't load htmlfontify if shell binary doesn't exist
Date: Tue, 17 Jan 2017 15:19:59 +0100

$ SHELL=/doesnotexist src/emacs -Q -batch -l htmlfontify ; echo $?
Searching for program: No such file or directory, /doesnotexist
255

This is of course a rather rare edge case, but I think that
unavailability of a shell shouldn't prevent htmlfontify from loading.
The shell is only used to initialize hfy-etags-cmd, this variable could
simply be initialized to nil if no shell is found, similar to when no
etags binary is found.


In GNU Emacs 26.0.50.30 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
 of 2017-01-17 built on localhost
Repository revision: 5362ef79cbb195f9df38f71b4d64e290cd7d9f50
Windowing system distributor 'The X.Org Foundation', version 11.0.11501000
System Description:	Ubuntu 14.04 LTS

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure --with-modules --enable-checking
 --enable-check-lisp-object-type 'CFLAGS=-ggdb3 -O0''

Configured features:
XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY GNUTLS FREETYPE XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 MODULES

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv
bytecomp byte-compile cl-extra help-mode cconv cl-loaddefs pcase cl-lib
dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec
password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr
mail-utils time-date mule-util tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page menu-bar rfn-eshadow isearch timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript case-table epa-hook jka-cmpr-hook help
simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button
faces cus-face macroexp files text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote inotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty
make-network-process emacs)

Memory information:
((conses 16 97831 8478)
 (symbols 48 20220 1)
 (miscs 40 331 131)
 (strings 32 18031 4413)
 (string-bytes 1 592989)
 (vectors 16 14093)
 (vector-slots 8 473001 6992)
 (floats 8 181 10)
 (intervals 56 218 0)
 (buffers 976 12)
 (heap 1024 36888 965))

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle

Diese E-Mail ist vertraulich.  Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen
Sie die E-Mail und alle Anhänge.  Vielen Dank.

This e-mail is confidential.  If you are not the right addressee please do not
forward it, please inform the sender, and please erase this e-mail including
any attachments.  Thanks.

Message #8 received at 25468 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: 25468 <at> debbugs.gnu.org
Subject: Re: bug#25468: 26.0.50; Can't load htmlfontify if shell binary
 doesn't exist
Date: Tue, 17 Jan 2017 17:27:27 +0000

[Message part 1 (text/plain, inline)]

Philipp Stephani <p.stephani2 <at> gmail.com> schrieb am Di., 17. Jan. 2017 um
15:21 Uhr:

>
> $ SHELL=/doesnotexist src/emacs -Q -batch -l htmlfontify ; echo $?
> Searching for program: No such file or directory, /doesnotexist
> 255
>
> This is of course a rather rare edge case, but I think that
> unavailability of a shell shouldn't prevent htmlfontify from loading.
> The shell is only used to initialize hfy-etags-cmd, this variable could
> simply be initialized to nil if no shell is found, similar to when no
> etags binary is found.
>

I've attached a patch.

[Message part 2 (text/html, inline)]

[0001-Don-t-error-when-loading-htmlfontify-without-shell.txt (text/plain, attachment)]

Message #11 received at 25468 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 25468 <at> debbugs.gnu.org
Subject: Re: bug#25468: 26.0.50;
 Can't load htmlfontify if shell binary doesn't exist
Date: Tue, 17 Jan 2017 12:34:25 -0500

I don't see a need for hfy-which-etags to go via the shell at all,
so a better change to me would be to use call-process instead of
shell-command-to-string there. I see there's also hfy-shell-file-name
for some reason.

Message #14 received at 25468 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 25468 <at> debbugs.gnu.org
Subject: Re: bug#25468: 26.0.50; Can't load htmlfontify if shell binary
 doesn't exist
Date: Tue, 17 Jan 2017 18:23:14 +0000

[Message part 1 (text/plain, inline)]

Glenn Morris <rgm <at> gnu.org> schrieb am Di., 17. Jan. 2017 um 18:34 Uhr:

>
> I don't see a need for hfy-which-etags to go via the shell at all,
> so a better change to me would be to use call-process instead of
> shell-command-to-string there. I see there's also hfy-shell-file-name
> for some reason.
>

Good point, here's another patch.

[Message part 2 (text/html, inline)]

[0001-Don-t-require-a-shell-when-loading-htmlfontify.txt (text/plain, attachment)]

Message #17 received at 25468 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 25468 <at> debbugs.gnu.org
Subject: Re: bug#25468: 26.0.50; Can't load htmlfontify if shell binary
 doesn't exist
Date: Tue, 24 Jan 2017 16:43:00 +0000

[Message part 1 (text/plain, inline)]

Philipp Stephani <p.stephani2 <at> gmail.com> schrieb am Di., 17. Jan. 2017 um
19:23 Uhr:

> Glenn Morris <rgm <at> gnu.org> schrieb am Di., 17. Jan. 2017 um 18:34 Uhr:
>
>
> I don't see a need for hfy-which-etags to go via the shell at all,
> so a better change to me would be to use call-process instead of
> shell-command-to-string there. I see there's also hfy-shell-file-name
> for some reason.
>
>
> Good point, here's another patch.
>

Unless there are further comments, I'll push this patch to master in a few
days.

[Message part 2 (text/html, inline)]

Message #22 received at 25468-done <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>, 25468-done <at> debbugs.gnu.org
Subject: Re: bug#25468: 26.0.50; Can't load htmlfontify if shell binary
 doesn't exist
Date: Fri, 27 Jan 2017 17:59:07 +0000

[Message part 1 (text/plain, inline)]

Philipp Stephani <p.stephani2 <at> gmail.com> schrieb am Di., 24. Jan. 2017 um
17:43 Uhr:

> Philipp Stephani <p.stephani2 <at> gmail.com> schrieb am Di., 17. Jan. 2017 um
> 19:23 Uhr:
>
> Glenn Morris <rgm <at> gnu.org> schrieb am Di., 17. Jan. 2017 um 18:34 Uhr:
>
>
> I don't see a need for hfy-which-etags to go via the shell at all,
> so a better change to me would be to use call-process instead of
> shell-command-to-string there. I see there's also hfy-shell-file-name
> for some reason.
>
>
> Good point, here's another patch.
>
>
> Unless there are further comments, I'll push this patch to master in a few
> days.
>

Pushed as 107a0c4caa.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.