GNU bug report logs - #25399
auth-source-user-and-password user argument

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25399 in the body.
You can then email your comments to 25399 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oscar Najera <najera.oscar <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org, Ted Zlatanov <tzz <at> lifelogs.com>
Subject: [PATCH]
Date: Sun, 08 Jan 2017 19:17:43 +0100

Hello,

I tried to use the auth-source-user-and-password function with the user
argument, but it always returns a list of nil. Looking at the code I see
that the argument is not used in the auth-source-search but that a fixed
string "yourusername" is used.

With this patch I obtain the correct behavior.

Thank you for your attention,
Best regards,
Oscar

---
 lisp/auth-source.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/auth-source.el b/lisp/auth-source.el
index c26935fcc9..7402ab21d7 100644
--- a/lisp/auth-source.el
+++ b/lisp/auth-source.el
@@ -2129,7 +2129,7 @@ MODE can be \"login\" or \"password\"."
                      (if user
                          (auth-source-search
                           :host host
-                          :user "yourusername"
+                          :user user
                           :max 1
                           :require '(:user :secret)
                           :create nil)

Message #10 received at 25399 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Oscar Najera <najera.oscar <at> gmail.com>
Cc: tzz <at> lifelogs.com, 25399 <at> debbugs.gnu.org
Subject: Re: bug#25399: [PATCH]
Date: Tue, 31 Jan 2017 20:39:10 -0500

tags 25399 fixed
close 25399 26.1
quit

Oscar Najera <najera.oscar <at> gmail.com> writes:

> I tried to use the auth-source-user-and-password function with the user
> argument, but it always returns a list of nil. Looking at the code I see
> that the argument is not used in the auth-source-search but that a fixed
> string "yourusername" is used.

This was fixed in [1: 52515f1].

1: 2017-01-31 14:13:10 -0500 52515f1133f2b87c573524d83c86b08e70ce1c30
  auth-source-user-and-password: add forgotten user parameter

Message #17 received at 25399-done <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: npostavs <at> users.sourceforge.net
Cc: Oscar Najera <najera.oscar <at> gmail.com>, 25399-done <at> debbugs.gnu.org
Subject: Re: bug#25399: [PATCH]
Date: Wed, 01 Feb 2017 10:27:21 -0500

On Tue, 31 Jan 2017 20:39:10 -0500 npostavs <at> users.sourceforge.net wrote: 

n> tags 25399 fixed
n> close 25399 26.1
n> quit

n> Oscar Najera <najera.oscar <at> gmail.com> writes:

>> I tried to use the auth-source-user-and-password function with the user
>> argument, but it always returns a list of nil. Looking at the code I see
>> that the argument is not used in the auth-source-search but that a fixed
>> string "yourusername" is used.

n> This was fixed in [1: 52515f1].

n> 1: 2017-01-31 14:13:10 -0500 52515f1133f2b87c573524d83c86b08e70ce1c30
n>   auth-source-user-and-password: add forgotten user parameter

Oh, thanks! I had missed this bug report because it had no subject line.

Ted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.