GNU bug report logs - #25391
24.5; ffap-guesser "stack overflow in regexp matcher" error may crash emacs.

Previous Next

Package: emacs;

Reported by: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>

Date: Sun, 8 Jan 2017 07:32:01 UTC

Severity: minor

Tags: fixed, patch

Found in version 24.5

Fixed in version 26.1

Done: Noam Postavsky <npostavs <at> users.sourceforge.net>

Bug is archived. No further changes may be made.

Full log


Message #19 received at 25391 <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: npostavs <at> users.sourceforge.net
Cc: 25391 <at> debbugs.gnu.org
Subject: Re: bug#25391: 24.5;
 ffap-guesser "stack overflow in regexp matcher" error may crash emacs.
Date: Mon, 09 Jan 2017 08:00:35 +0100
npostavs <at> users.sourceforge.net writes:

> tags 25391 patch
> quit
>
> Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:
>>
>> However, this handle the problem with "Stack overflow in regexp matcher"
>> generally, but perhaps regexps such as `ffap-gopher-regexp` could be
>> avoided when possible in emacs source code.
>
> Ah, so by "crash" you meant throw an error.

I had the both, a crash on emacs-26, emacs taking all memory and finally
crashing and on emacs-24.5 "Stack overflow in regexp matcher".


> Right, and ffap-gopher-at-point is also using `set' on local variables,
> icky.  Here's a patch:

I don't know `let-alist`, but looks good, however keeping
`ffap-gopher-regexp` instead of hardcoding it and returning nil when the
regexp is nil would allow users to disable the feature.

Thanks.

-- 
Thierry




This bug report was last modified 8 years and 161 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.