GNU bug report logs - #25391
24.5; ffap-guesser "stack overflow in regexp matcher" error may crash emacs.

Previous Next

Full log

Message #14 received at 25391 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Cc: 25391 <at> debbugs.gnu.org
Subject: Re: bug#25391: 24.5;
 ffap-guesser "stack overflow in regexp matcher" error may crash emacs.
Date: Sun, 08 Jan 2017 18:29:08 -0500

[Message part 1 (text/plain, inline)]

tags 25391 patch
quit

Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:
>
> However, this handle the problem with "Stack overflow in regexp matcher"
> generally, but perhaps regexps such as `ffap-gopher-regexp` could be
> avoided when possible in emacs source code.

Ah, so by "crash" you meant throw an error.

>
> IIUC regexps like "^.*\\(this\\|that etc...\\)" create an incredible
> number of travels between bol and eol (which may sometimes be eob) and
> lead to a stack overflow inevitably on long lines (perhaps not so long
> in this case).

Right, and ffap-gopher-at-point is also using `set' on local variables,
icky.  Here's a patch:

[v1-0001-Improve-ffap-gopher-at-point-handling-of-long-lin.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.