From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 08 02:08:53 2017 Received: (at submit) by debbugs.gnu.org; 8 Jan 2017 07:08:53 +0000 Received: from localhost ([127.0.0.1]:46439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQ7b2-00057Q-Tl for submit@debbugs.gnu.org; Sun, 08 Jan 2017 02:08:53 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQ5ia-0001vG-86 for submit@debbugs.gnu.org; Sun, 08 Jan 2017 00:08:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cQ5iT-0005kE-Nu for submit@debbugs.gnu.org; Sun, 08 Jan 2017 00:08:26 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=BAYES_50,RCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43211) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cQ5iT-0005k9-KR for submit@debbugs.gnu.org; Sun, 08 Jan 2017 00:08:25 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQ5iS-0007sE-F0 for bug-sed@gnu.org; Sun, 08 Jan 2017 00:08:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cQ5iN-0005jE-Ff for bug-sed@gnu.org; Sun, 08 Jan 2017 00:08:24 -0500 Received: from ecemailfilter.ece.umd.edu ([129.2.90.4]:51059 helo=mailfilter.ece.umd.edu) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQ5iN-0005ir-B6 for bug-sed@gnu.org; Sun, 08 Jan 2017 00:08:19 -0500 X-ASG-Debug-ID: 1483852098-04739d10e787bfe0001-EHNGDJ Received: from mail-qk0-f198.google.com (mail-qk0-f198.google.com [209.85.220.198]) by mailfilter.ece.umd.edu with ESMTP id xex99ckxTBSKx7LE for ; Sun, 08 Jan 2017 00:08:18 -0500 (EST) X-Barracuda-Envelope-From: sgilles@math.umd.edu X-Barracuda-Effective-Source-IP: mail-qk0-f198.google.com[209.85.220.198] X-Barracuda-Apparent-Source-IP: 209.85.220.198 Received: by mail-qk0-f198.google.com with SMTP id 11so13799756qkl.4 for ; Sat, 07 Jan 2017 21:08:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=UQXO6EhAl2Fb1RdhAzOUHJfzzEC6NQY4HExLk1vqmrs=; b=J0EG+rFw2ZlwIhiRZz639Ji24qp/ei2cdvmVjt5uhtIEiaHAjqYTdazAzbXs/GNOvd Lb9LrXM/+ilKtwJIFO8plEj0m/XpD+f96JIDLlTByOUHRy1f0DxrvgUdDsx6mm2iiKo8 H/OuJXQSaItfhFnoDDGQIcmF0VbA5MqSehVX6NofwNY94JLwy+b+fU243KBk/Yu893ia V2KmMY1jyIGAvRTBEpK65FuZXudwjkeZwFo5t6kDVelHFZ1eoLN71FccRIlpNrVie109 GmpT77cBnp4riBWRE8BE2w15+R/GdsuKCkHGvr/5+tCshJFlheswTCwcTvNhMi63ZRIB MUBQ== X-Gm-Message-State: AIkVDXJ0Vbou7o+IIM+Sa1fyU3ojIAWF9HTYZK1mcZ9Le/BJod74ZTKt6KlTEyzoYqDUo3h749SmUt7SdB+opeUkjQ6RVWVQuKGJRTB1KrVYpUbuMTWjEgLt6L1zIC8l X-Received: by 10.55.133.199 with SMTP id h190mr91323346qkd.302.1483852098165; Sat, 07 Jan 2017 21:08:18 -0800 (PST) X-Received: by 10.55.133.199 with SMTP id h190mr91323338qkd.302.1483852097988; Sat, 07 Jan 2017 21:08:17 -0800 (PST) Received: from number18.npnth.net (c-50-190-1-87.hsd1.md.comcast.net. [50.190.1.87]) by smtp.gmail.com with ESMTPSA id 5sm54308280qts.47.2017.01.07.21.08.17 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 07 Jan 2017 21:08:17 -0800 (PST) Date: Sun, 8 Jan 2017 00:07:58 -0500 From: "S. Gilles" To: bug-sed@gnu.org Subject: Segfault with sed 4.3 Message-ID: <20170108050745.GA14227@number18.npnth.net> X-ASG-Orig-Subj: Segfault with sed 4.3 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qtZFehHsKgwS5rPz" Content-Disposition: inline User-Agent: Mutt/1.7.2 (2016-11-26) X-Barracuda-Connect: mail-qk0-f198.google.com[209.85.220.198] X-Barracuda-Start-Time: 1483852098 X-Barracuda-URL: https://mailfilter.ece.umd.edu:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 1087 X-Virus-Scanned: by bsmtpd at ece.umd.edu X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=7.0 KILL_LEVEL=1000.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.35649 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.5 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 08 Jan 2017 02:08:52 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.5 (----) --qtZFehHsKgwS5rPz Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, I have a reliable segfault with (vanilla) sed 4.3 which does not appear on (vanilla) 4.2.2. I've pared it down from the ./configure script (for sed itself) to short working example, but I'm not sure if it's minimal. I should note that this originally showed up on a bit of a snowflake machine (armv7a+musl) when attempting to use any sort of nontrivial =2E/configure, but the my working example triggers the issue on a boring amd64+glibc machine, even though that machine has no problem =2E/configure-ing all sorts of things. That could mean my example is doing bad things that the original case didn't, in which case I'll try to cook up another example. Without further ado (please excuse the UUoc): ----8<--------8<--------8<--------8<--------8<--------8<---- #!/bin/sh # Or wherever you have it sed=3D"/bin/sed" cat < input.txt 1 1 \$LINENO \$LINEN 2 EOF cat input.txt | "${sed}" 's/\$LINENO.*/&-/ t lineno :lineno N :loop s/\$LINENO\(.*\n\)/\1/' > out.txt ----8<--------8<--------8<--------8<--------8<--------8<---- --=20 S. Gilles --qtZFehHsKgwS5rPz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEELOnO+Mgxt5g+LibJo0ftojCuuJ0FAlhxyS4ACgkQo0ftojCu uJ2O3gf8Db3IH9NAViCcNua35VIFnEuadOsFiUhpkKAtuXq9wXntMMs9j7iJG3K0 a6ooxH6hNZCp3IISlXRi0aLDDXfpDeWeDJCWXHfvHaw8QwoU0swcKa5864Wen2Na AAk6+0ubA+XRSbMVY93i/nzUAlj0nT7Wp2w7Bkymtcn8hlAttQDFcAHUMxuDoJ25 ljZGNET03aQN3I5AGmg6dYI/I8cHLKOFJhAK9yBZOuhDAt+dwbfJYK759opIMWCX xMFoq5NFANIERJe9q2fC3PgQgQKNqnixDGMuKrfPxcEin4vyzqggEb6ZaQ+FrX7X ETFjlU5iMf5ld4iu8XTLCMRZrunp0g== =9ckE -----END PGP SIGNATURE----- --qtZFehHsKgwS5rPz-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 08 02:20:49 2017 Received: (at submit) by debbugs.gnu.org; 8 Jan 2017 07:20:49 +0000 Received: from localhost ([127.0.0.1]:46444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQ7mb-0005Pf-EP for submit@debbugs.gnu.org; Sun, 08 Jan 2017 02:20:49 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQ64z-0002VK-Be for submit@debbugs.gnu.org; Sun, 08 Jan 2017 00:31:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cQ64t-0003Be-9l for submit@debbugs.gnu.org; Sun, 08 Jan 2017 00:31:36 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=BAYES_50,RCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35050) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cQ64t-0003BR-6b for submit@debbugs.gnu.org; Sun, 08 Jan 2017 00:31:35 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQ64r-0002dW-U7 for bug-sed@gnu.org; Sun, 08 Jan 2017 00:31:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cQ64o-00039u-QE for bug-sed@gnu.org; Sun, 08 Jan 2017 00:31:33 -0500 Received: from ecemailfilter.ece.umd.edu ([129.2.90.4]:43708 helo=mailfilter.ece.umd.edu) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQ64o-00039q-KR for bug-sed@gnu.org; Sun, 08 Jan 2017 00:31:30 -0500 X-ASG-Debug-ID: 1483853489-04739d10e687c4f0001-EHNGDJ Received: from mail-qk0-f200.google.com (mail-qk0-f200.google.com [209.85.220.200]) by mailfilter.ece.umd.edu with ESMTP id ZDdL5vbEQ6HwvPII for ; Sun, 08 Jan 2017 00:31:30 -0500 (EST) X-Barracuda-Envelope-From: sgilles@math.umd.edu X-Barracuda-Effective-Source-IP: mail-qk0-f200.google.com[209.85.220.200] X-Barracuda-Apparent-Source-IP: 209.85.220.200 Received: by mail-qk0-f200.google.com with SMTP id a16so20324943qkc.6 for ; Sat, 07 Jan 2017 21:31:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fU3noYoIEkhic78oQZdwSIhsx4EGDUvxDS9codgeeBY=; b=JX+NUTeqdumEPccMz+Tg8XigPQyRPlXMtrnIBSGX8i/FdL3/3ZotLrx2I41Unz4WFU Q0MiN1HmpXcT6L1juxsQI0tDBgeBfvlAjE+d7aKZZb5k0S6Xm7/J40pATd/wM9ii8BfC W30s+dYW+wg97keQEvR7Q0iYTjymWKh1IpiW578zOwqlGqU8pRFAxfHLJyY1DOS8CqCi aegxwww4AU5nD/b5PiXg3AwK9zym2w+buDrRkqUlxcSWXcI0EAOn6IdeMAb3QHPgLcvl fdO0UzWeuDWPMEPc1GtLvr9LWr4zmV24qjdVhNRX/3tRSEE2qdKwk8t5sNaks4pcHUmn Hi6g== X-Gm-Message-State: AIkVDXL60tGCFIP9jd0toSl6gHKC8FSB6MKhqC+un4dpHHUICM33mfBL5yfw6j8koZ+XG5HOtyGdSr6dnQq9LRnDom4HTWgynvBzMFwlPRyYeC42rR570ugybu3TC3O0 X-Received: by 10.55.15.231 with SMTP id 100mr75752446qkp.244.1483853489759; Sat, 07 Jan 2017 21:31:29 -0800 (PST) X-Received: by 10.55.15.231 with SMTP id 100mr75752443qkp.244.1483853489639; Sat, 07 Jan 2017 21:31:29 -0800 (PST) Received: from number18.npnth.net (c-50-190-1-87.hsd1.md.comcast.net. [50.190.1.87]) by smtp.gmail.com with ESMTPSA id d15sm1970817qtg.22.2017.01.07.21.31.28 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 07 Jan 2017 21:31:28 -0800 (PST) Date: Sun, 8 Jan 2017 00:31:17 -0500 From: "S. Gilles" To: bug-sed@gnu.org Subject: Re: Segfault with sed 4.3 Message-ID: <20170108053117.GB14227@number18.npnth.net> X-ASG-Orig-Subj: Re: Segfault with sed 4.3 References: <20170108050745.GA14227@number18.npnth.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pQhZXvAqiZgbeUkD" Content-Disposition: inline In-Reply-To: <20170108050745.GA14227@number18.npnth.net> User-Agent: Mutt/1.7.2 (2016-11-26) X-Barracuda-Connect: mail-qk0-f200.google.com[209.85.220.200] X-Barracuda-Start-Time: 1483853489 X-Barracuda-URL: https://mailfilter.ece.umd.edu:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 594 X-Virus-Scanned: by bsmtpd at ece.umd.edu X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=7.0 KILL_LEVEL=1000.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.35649 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.5 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 08 Jan 2017 02:20:47 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.5 (----) --pQhZXvAqiZgbeUkD Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2017-01-08T00:07:58-0500, S. Gilles wrote: > Hi, >=20 > I have a reliable segfault with (vanilla) sed 4.3 which does not appear > on (vanilla) 4.2.2. I've pared it down from the ./configure script (for > sed itself) to short working example, but I'm not sure if it's minimal. Apologies for the immediate follow-up post, but I've bisected (doing a =2E/bootstrap && ./configure && make at each step, which I hope should be sufficient) this crash to commit 5af42765d6d2255a04efa4737870f15e11e149a4 gnulib: update to latest Hopefully this is helpful. --=20 S. Gilles --pQhZXvAqiZgbeUkD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEELOnO+Mgxt5g+LibJo0ftojCuuJ0FAlhxzpwACgkQo0ftojCu uJ0JQAgAj1suMUbhvYcZnDVHOYq+sj6W8zzl6j6IqMMIogd0bZtZbYEcrkzl7n2z kh6TA2+2FEFASAGlSJtSv9jFmuKgI4abaOyiC+F72KqzUEBF93nhchVrVMRj0F7+ gU+x+nS+AZsQQNe4Bk9eir249y4Ur4WFoSw5ffOcZOYL7b5UTW/0CgaG7Df909E9 YZq7Dex+DqqrVMR1wk7lD2rI6o8LAG+BdLRQWOgBjufdEJw/J4/+RtaFWiS9zLHx i52Me15e7A3T3cJ8FwvblXMWq2ragQdjsk69Gkv+gC39HOsbGeA6kGvWm7cGci+r 5W+TGsT0MqMh9b6ArDwCIIMMijdpMQ== =MjSY -----END PGP SIGNATURE----- --pQhZXvAqiZgbeUkD-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 08 12:01:22 2017 Received: (at 25390) by debbugs.gnu.org; 8 Jan 2017 17:01:22 +0000 Received: from localhost ([127.0.0.1]:47026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQGqP-0008UX-Vm for submit@debbugs.gnu.org; Sun, 08 Jan 2017 12:01:22 -0500 Received: from mail-qt0-f196.google.com ([209.85.216.196]:34661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQGqN-0008UF-5h for 25390@debbugs.gnu.org; Sun, 08 Jan 2017 12:01:19 -0500 Received: by mail-qt0-f196.google.com with SMTP id a29so11587324qtb.1 for <25390@debbugs.gnu.org>; Sun, 08 Jan 2017 09:01:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=5cD7aYv7vZvNqyYYESB57h+iylWdEklHZmLAJ27IsSo=; b=KjEQS/jlOQSAhn62M/2HSxL5yuiJmJf2wFrot5jN6EzAMBDNX8pPyf4XpcxForlq0w O47q+/Ll+RI2vjvnzod8OVs0TG+ITxPa4nLxRsH9irMhOwrZQ4VzrTF/u9pl+osxtCO7 kCSZL7PZGoslBDiieAJe4jWS0nT4h8YKxbEqzjRrLhCZXN+xiJ8tYMbb+5jfiKzNWVvj DQ1TNGpnUy+8TDf+1hs+qE1ZEUrc9iX/vb+kCq7wwHY4neu1ZFjnMxPjrE68A8NiyXbC GXDIG5oBxhpQoU9Q1mGh42UC24NIoX2m3FdnacHCyZFtugUf7VY96HaIr1ThB16xkbJ1 2EyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=5cD7aYv7vZvNqyYYESB57h+iylWdEklHZmLAJ27IsSo=; b=HflrWuwqf2/gdonW8RkP3YyaQAYXKVctE8uIGXsNeEhd6+zlqcwjaH7bkHVDTBlo14 Ftp0lBFdvI01c4RfMqFYtj/U9i3Vh8P5PR9KouEtKy54ci/xq3EaIsborpH1Q3q4pNea EnZKhBUXvgcHTvxuYUP7uNZgYtVknqT1xW89zs87RtYybtqJVlkNl12h6BMyCsrlM7cL rta1eKiMtAzBjAwHbZh+2ylg0bKnJM56m1zdhfYRMkIUjPNzklCqUVexHhUzOqcRE71Y 4sjOmrSg2pK2IGFfeU2ilpJtC1zlirLOCJLarT/okwLFvWA73uVrTxD/BxAMps6FQXyp tOiw== X-Gm-Message-State: AIkVDXI7HDiyfsJNLCbrD03Y8V3Q9zblEteR84stKMFq4DktUz9KQSgAT1Pbp7v6vvYldQ== X-Received: by 10.200.37.175 with SMTP id e44mr87620218qte.276.1483894873584; Sun, 08 Jan 2017 09:01:13 -0800 (PST) Received: from ix.home (pool-100-37-92-116.nycmny.fios.verizon.net. [100.37.92.116]) by smtp.gmail.com with ESMTPSA id a141sm940921qkg.12.2017.01.08.09.01.12 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 08 Jan 2017 09:01:12 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Subject: Re: bug#25390: Segfault with sed 4.3 From: Assaf Gordon In-Reply-To: <20170108053117.GB14227@number18.npnth.net> Date: Sun, 8 Jan 2017 12:01:11 -0500 Content-Transfer-Encoding: quoted-printable Message-Id: <9B5E3836-1C2B-4CAD-91A2-CBB9319C1095@gmail.com> References: <20170108050745.GA14227@number18.npnth.net> <20170108053117.GB14227@number18.npnth.net> To: "S. Gilles" X-Mailer: Apple Mail (2.2102) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25390 Cc: 25390@debbugs.gnu.org, "bug-gnulib@gnu.org List" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hello, > On Jan 8, 2017, at 00:31, S. Gilles wrote: >=20 >> I have a reliable segfault with (vanilla) sed 4.3 which does not = appear >> on (vanilla) 4.2.2. Thank you for the report! I can confirm the segfault is reproducible. The immediate cause is somewhere in gnulib's DFA module. A shorter example: printf '$LINENO $LINEN\nB\n' | sed -e 'N;s/\$LINENO\(.*\n\)/\1/' =3D=3D=3D=3D $ printf '$LINENO $LINEN\nB\n' > in.txt $ printf '%s\n' 'N;s/\$LINENO\(.*\n\)/\1/' > prog.sed $ gdb ./sed/sed (gdb) r -f prog.sed in.txt Starting program: /home/gordon/projects/sed/sed/sed -f prog.sed in.txt Program received signal SIGSEGV, Segmentation fault. 0x0000000000412384 in dfaexec_main (d=3D0x6250b0, begin=3D0x623b50 = "$LINENO $LINEN\nB\n", end=3D0x623b60 "\n",=20 allow_nl=3Dtrue, count=3D0x0, multibyte=3Dfalse) at lib/dfa.c:3169 3169 s1 =3D t[*p++]; (gdb) bt #0 0x0000000000412384 in dfaexec_main (d=3D0x6250b0, begin=3D0x623b50 = "$LINENO $LINEN\nB\n",=20 end=3D0x623b60 "\n", allow_nl=3Dtrue, count=3D0x0, multibyte=3Dfalse) = at lib/dfa.c:3169 #1 0x0000000000412833 in dfaexec_sb (d=3D0x6250b0, begin=3D0x623b50 = "$LINENO $LINEN\nB\n",=20 end=3D0x623b60 "\n", allow_nl=3Dtrue, count=3D0x0, = backref=3D0x7fffffffbff7) at lib/dfa.c:3266 #2 0x00000000004128a5 in dfaexec (d=3D0x6250b0, begin=3D0x623b50 = "$LINENO $LINEN\nB\n", end=3D0x623b60 "\n",=20 allow_nl=3Dtrue, count=3D0x0, backref=3D0x7fffffffbff7) at = lib/dfa.c:3287 #3 0x0000000000409359 in match_regex (regex=3D0x623c10, buf=3D0x623b50 = "$LINENO $LINEN\nB\n", buflen=3D16,=20 buf_start_offset=3D0, regarray=3D0x61ff10 , regsize=3D2) at = sed/regexp.c:345 #4 0x0000000000407859 in do_subst (sub=3D0x622500) at = sed/execute.c:1030 #5 0x00000000004086d4 in execute_program (vec=3D0x6224d0, = input=3D0x7fffffffe170) at sed/execute.c:1517 #6 0x0000000000408abc in process_files (the_program=3D0x6224d0, = argv=3D0x7fffffffe3c0) at sed/execute.c:1687 #7 0x0000000000409d88 in main (argc=3D4, argv=3D0x7fffffffe3a8) at = sed/sed.c:377 =3D=3D=3D Looking into it, hope to have fix soon. regards, - assaf From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 08 15:49:53 2017 Received: (at 25390) by debbugs.gnu.org; 8 Jan 2017 20:49:53 +0000 Received: from localhost ([127.0.0.1]:47161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQKPZ-00045q-Bh for submit@debbugs.gnu.org; Sun, 08 Jan 2017 15:49:53 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:48688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQKPX-00045c-5l for 25390@debbugs.gnu.org; Sun, 08 Jan 2017 15:49:52 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 29603160051; Sun, 8 Jan 2017 12:49:44 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id mhSParLmIwLS; Sun, 8 Jan 2017 12:49:42 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D6196160075; Sun, 8 Jan 2017 12:49:42 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id J44qbPNB2m0w; Sun, 8 Jan 2017 12:49:42 -0800 (PST) Received: from [192.168.1.9] (unknown [47.153.178.162]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id ABCB4160051; Sun, 8 Jan 2017 12:49:42 -0800 (PST) Subject: Re: bug#25390: Segfault with sed 4.3 To: Assaf Gordon , "S. Gilles" References: <20170108050745.GA14227@number18.npnth.net> <20170108053117.GB14227@number18.npnth.net> <9B5E3836-1C2B-4CAD-91A2-CBB9319C1095@gmail.com> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <216dfc52-a392-a85f-fa49-fdef9d020949@cs.ucla.edu> Date: Sun, 8 Jan 2017 12:49:42 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <9B5E3836-1C2B-4CAD-91A2-CBB9319C1095@gmail.com> Content-Type: multipart/mixed; boundary="------------30462C36517F87B60C58E023" X-Spam-Score: -3.2 (---) X-Debbugs-Envelope-To: 25390 Cc: 25390@debbugs.gnu.org, Gnulib bugs , GNU grep developers X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) This is a multi-part message in MIME format. --------------30462C36517F87B60C58E023 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Assaf Gordon wrote: > The immediate cause is somewhere in gnulib's DFA module. The bug was introduced in Gnulib, in commit=20 403adf1b40897ba108075008c10bd38d937e1539 dated 2016-11-25 and labeled "df= a:=20 addition of new state on demand". It's not a bug that grep runs into, sin= ce grep=20 doesn't use the newline transition that sed does. I installed the attache= d patch=20 to fix the Gnulib bug. I'll leave Bug#25390 open, as I assume you'll want= to=20 check it for 'sed' and add a test case for 'sed'. --------------30462C36517F87B60C58E023 Content-Type: text/x-diff; name="0001-dfa-fix-reallocation-bug-when-matching-newlines.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0001-dfa-fix-reallocation-bug-when-matching-newlines.patch" =46rom 4257674f36b3e6decd7ad12450753b003960f2f3 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sun, 8 Jan 2017 12:44:29 -0800 Subject: [PATCH] dfa: fix reallocation bug when matching newlines Problem reported for sed by S. Gilles (Bug#25390). * lib/dfa.c (realloc_trans_if_necessary): Move earlier. (dfastate): Reallocate before moving any newline transition ... (build_state): ... instead of reallocating here, where it is too late. --- ChangeLog | 8 +++++ lib/dfa.c | 114 ++++++++++++++++++++++++++++++--------------------------= ------ 2 files changed, 63 insertions(+), 59 deletions(-) diff --git a/ChangeLog b/ChangeLog index 790e41b..79475df 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2017-01-08 Paul Eggert + + dfa: fix reallocation bug when matching newlines + Problem reported for sed by S. Gilles (Bug#25390). + * lib/dfa.c (realloc_trans_if_necessary): Move earlier. + (dfastate): Reallocate before moving any newline transition ... + (build_state): ... instead of reallocating here, where it is too late. + 2017-01-07 Tim R=C3=BChsen (tiny change) =20 Avoid -Wundef warning about undefined WINDOWS_SOCKETS. diff --git a/lib/dfa.c b/lib/dfa.c index 8276db1..141888a 100644 --- a/lib/dfa.c +++ b/lib/dfa.c @@ -2574,6 +2574,40 @@ dfaanalyze (struct dfa *d, bool searchflag) free (merged.elems); } =20 +/* Make sure D's state arrays are large enough to hold NEW_STATE. */ +static void +realloc_trans_if_necessary (struct dfa *d, state_num new_state) +{ + state_num oldalloc =3D d->tralloc; + if (oldalloc <=3D new_state) + { + state_num **realtrans =3D d->trans ? d->trans - 2 : NULL; + ptrdiff_t newalloc1 =3D realtrans ? d->tralloc + 2 : 0; + realtrans =3D xpalloc (realtrans, &newalloc1, new_state - oldalloc= + 1, + -1, sizeof *realtrans); + realtrans[0] =3D realtrans[1] =3D NULL; + d->trans =3D realtrans + 2; + ptrdiff_t newalloc =3D d->tralloc =3D newalloc1 - 2; + d->fails =3D xnrealloc (d->fails, newalloc, sizeof *d->fails); + d->success =3D xnrealloc (d->success, newalloc, sizeof *d->success= ); + d->newlines =3D xnrealloc (d->newlines, newalloc, sizeof *d->newli= nes); + if (d->localeinfo.multibyte) + { + realtrans =3D d->mb_trans ? d->mb_trans - 2 : NULL; + realtrans =3D xnrealloc (realtrans, newalloc1, sizeof *realtra= ns); + if (oldalloc =3D=3D 0) + realtrans[0] =3D realtrans[1] =3D NULL; + d->mb_trans =3D realtrans + 2; + } + for (; oldalloc < newalloc; oldalloc++) + { + d->trans[oldalloc] =3D NULL; + d->fails[oldalloc] =3D NULL; + if (d->localeinfo.multibyte) + d->mb_trans[oldalloc] =3D NULL; + } + } +} =20 /* Return the transition out of state s of d for the input character uc,= updating the slots in trans accordingly. @@ -2810,20 +2844,25 @@ dfastate (state_num s, struct dfa *d, unsigned ch= ar uc, state_num trans[]) } =20 /* Set the transitions for each character in the label. */ + state_num maxstate =3D -1; for (size_t i =3D 0; i < NOTCHAR; i++) if (tstbit (i, &label)) - switch (d->syntax.sbit[i]) - { - case CTX_NEWLINE: - trans[i] =3D state_newline; - break; - case CTX_LETTER: - trans[i] =3D state_letter; - break; - default: - trans[i] =3D state; - break; - } + { + switch (d->syntax.sbit[i]) + { + case CTX_NEWLINE: + trans[i] =3D state_newline; + break; + case CTX_LETTER: + trans[i] =3D state_letter; + break; + default: + trans[i] =3D state; + break; + } + if (maxstate < trans[i]) + maxstate =3D trans[i]; + } =20 #ifdef DEBUG fprintf (stderr, "trans table %td", s); @@ -2840,6 +2879,9 @@ dfastate (state_num s, struct dfa *d, unsigned char= uc, state_num trans[]) free (follows.elems); free (tmp.elems); =20 + /* Reallocate now, to reallocate any newline transition properly. */ + realloc_trans_if_necessary (d, maxstate); + /* Keep the newline transition in a special place so we can use it as a sentinel. */ if (tstbit (d->syntax.eolbyte, &label)) @@ -2851,41 +2893,6 @@ dfastate (state_num s, struct dfa *d, unsigned cha= r uc, state_num trans[]) return trans[uc]; } =20 -/* Make sure D's state arrays are large enough to hold NEW_STATE. */ -static void -realloc_trans_if_necessary (struct dfa *d, state_num new_state) -{ - state_num oldalloc =3D d->tralloc; - if (oldalloc <=3D new_state) - { - state_num **realtrans =3D d->trans ? d->trans - 2 : NULL; - ptrdiff_t newalloc1 =3D realtrans ? d->tralloc + 2 : 0; - realtrans =3D xpalloc (realtrans, &newalloc1, new_state - oldalloc= + 1, - -1, sizeof *realtrans); - realtrans[0] =3D realtrans[1] =3D NULL; - d->trans =3D realtrans + 2; - ptrdiff_t newalloc =3D d->tralloc =3D newalloc1 - 2; - d->fails =3D xnrealloc (d->fails, newalloc, sizeof *d->fails); - d->success =3D xnrealloc (d->success, newalloc, sizeof *d->success= ); - d->newlines =3D xnrealloc (d->newlines, newalloc, sizeof *d->newli= nes); - if (d->localeinfo.multibyte) - { - realtrans =3D d->mb_trans ? d->mb_trans - 2 : NULL; - realtrans =3D xnrealloc (realtrans, newalloc1, sizeof *realtra= ns); - if (oldalloc =3D=3D 0) - realtrans[0] =3D realtrans[1] =3D NULL; - d->mb_trans =3D realtrans + 2; - } - for (; oldalloc < newalloc; oldalloc++) - { - d->trans[oldalloc] =3D NULL; - d->fails[oldalloc] =3D NULL; - if (d->localeinfo.multibyte) - d->mb_trans[oldalloc] =3D NULL; - } - } -} - /* Calculate the transition table for a new state derived from state s for a compiled dfa d after input character uc, and return the new state number. */ @@ -2932,18 +2939,7 @@ build_state (state_num s, struct dfa *d, unsigned = char uc) if (accepts_in_context (d->states[s].context, CTX_NONE, s, d)) d->success[s] |=3D CTX_NONE; =20 - s =3D dfastate (s, d, uc, trans); - - /* Now go through the new transition table, and make sure that the tra= ns - and fail arrays are allocated large enough to hold a pointer for th= e - largest state mentioned in the table. */ - state_num maxstate =3D -1; - for (int i =3D 0; i < NOTCHAR; i++) - if (maxstate < trans[i]) - maxstate =3D trans[i]; - realloc_trans_if_necessary (d, maxstate); - - return s; + return dfastate (s, d, uc, trans); } =20 /* Multibyte character handling sub-routines for dfaexec. */ --=20 2.9.3 --------------30462C36517F87B60C58E023-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 08 20:18:03 2017 Received: (at 25390) by debbugs.gnu.org; 9 Jan 2017 01:18:03 +0000 Received: from localhost ([127.0.0.1]:47290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQOb4-0005vD-Qv for submit@debbugs.gnu.org; Sun, 08 Jan 2017 20:18:02 -0500 Received: from ecemailfilter.ece.umd.edu ([129.2.90.4]:37021 helo=mailfilter.ece.umd.edu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQOb2-0005uo-TO for 25390@debbugs.gnu.org; Sun, 08 Jan 2017 20:18:01 -0500 X-ASG-Debug-ID: 1483924679-04739d10e78a8840001-UQ2Hpi Received: from mail-pf0-f197.google.com (mail-pf0-f197.google.com [209.85.192.197]) by mailfilter.ece.umd.edu with ESMTP id ivR3TElxgTIcDZc3 for <25390@debbugs.gnu.org>; Sun, 08 Jan 2017 20:17:59 -0500 (EST) X-Barracuda-Envelope-From: sgilles@math.umd.edu X-Barracuda-Effective-Source-IP: mail-pf0-f197.google.com[209.85.192.197] X-Barracuda-Apparent-Source-IP: 209.85.192.197 Received: by mail-pf0-f197.google.com with SMTP id 80so15523058pfy.2 for <25390@debbugs.gnu.org>; Sun, 08 Jan 2017 17:17:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JtEdTH9ObeKD1bKX3meHNhhlR2qXKPCjqY7eqCFk9AI=; b=oFn9gjxKmUjfbThAo5YWCn8xU+A2THJ1iCzA3eHWLUdRsckuG9hYe2H5fuQpeND+zP rG0Bk5TTj1smsd7k2JHTYrTgoWKEwbTv1ZW51FoeykI8vZbNIAEPZCZBTpWpDK6KUVWK Mah6I72vCb4YZYvLTcd/E1qLQoyN49A5p0uVDvVxDyNTy7XNprRGDzqeXDYhOMvoKTW6 m5GPB2lgM6Xt8frWyuf77eiSuvxHD0+PWr39fpXRRfyEQ2St5XXnE8qoVoJ5vkau2qcv cVMwytTMfPD+WNqEELNns4K7bxThi/DHcr+eMGM09w+vfDA3+J7TZ1kUhdrwhygY1uGA iurQ== X-Gm-Message-State: AIkVDXLQtNXFvVOnE4tcAOlCmIqTq9kpIfjvLPz7Yawe6nB6LftXlwFA0igtWObPiby5V+4SpOwGF5lZK0W2pwGhHQ03TohdBUsTvzguWgUdngH784cNv2vVO+tsPJAjyw9tDP0o X-Received: by 10.99.99.68 with SMTP id x65mr21004458pgb.126.1483924679515; Sun, 08 Jan 2017 17:17:59 -0800 (PST) X-Received: by 10.99.99.68 with SMTP id x65mr21004439pgb.126.1483924679294; Sun, 08 Jan 2017 17:17:59 -0800 (PST) Received: from number18.npnth.net (c-50-190-1-87.hsd1.md.comcast.net. [50.190.1.87]) by smtp.gmail.com with ESMTPSA id e84sm128901178pfl.79.2017.01.08.17.17.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 08 Jan 2017 17:17:58 -0800 (PST) Date: Sun, 8 Jan 2017 20:17:34 -0500 From: "S. Gilles" To: Paul Eggert Subject: Re: bug#25390: Segfault with sed 4.3 Message-ID: <20170109011734.GA13205@number18.npnth.net> X-ASG-Orig-Subj: Re: bug#25390: Segfault with sed 4.3 References: <20170108050745.GA14227@number18.npnth.net> <20170108053117.GB14227@number18.npnth.net> <9B5E3836-1C2B-4CAD-91A2-CBB9319C1095@gmail.com> <216dfc52-a392-a85f-fa49-fdef9d020949@cs.ucla.edu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OXfL5xGRrasGEqWY" Content-Disposition: inline In-Reply-To: <216dfc52-a392-a85f-fa49-fdef9d020949@cs.ucla.edu> User-Agent: Mutt/1.7.2 (2016-11-26) X-Barracuda-Connect: mail-pf0-f197.google.com[209.85.192.197] X-Barracuda-Start-Time: 1483924679 X-Barracuda-URL: https://mailfilter.ece.umd.edu:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 755 X-Virus-Scanned: by bsmtpd at ece.umd.edu X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=7.0 KILL_LEVEL=1000.0 tests=BSF_SC0_MISMATCH_TO X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.35653 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 BSF_SC0_MISMATCH_TO Envelope rcpt doesn't match header X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25390 Cc: 25390@debbugs.gnu.org, Assaf Gordon , Gnulib bugs , GNU grep developers X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --OXfL5xGRrasGEqWY Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2017-01-08T12:49:42-0800, Paul Eggert wrote: > Assaf Gordon wrote: > > The immediate cause is somewhere in gnulib's DFA module. >=20 > The bug was introduced in Gnulib, in commit > 403adf1b40897ba108075008c10bd38d937e1539 dated 2016-11-25 and labeled "df= a: > addition of new state on demand". It's not a bug that grep runs into, sin= ce > grep doesn't use the newline transition that sed does. I installed the > attached patch to fix the Gnulib bug. I'll leave Bug#25390 open, as I ass= ume > you'll want to check it for 'sed' and add a test case for 'sed'. I applied the patch (after some line number tweaks) on top of the 4.3 release tarball, and I can confirm that this fixes the issue for me. Thanks for the quick fix! --=20 S. Gilles --OXfL5xGRrasGEqWY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEELOnO+Mgxt5g+LibJo0ftojCuuJ0FAlhy5KUACgkQo0ftojCu uJ14Ogf9H3dwMrUrZ0OcY78J2fuPBsqIqfr4UWLiALZjLjgIIJVdqpmGWAMAu0J2 h++a4K4ifjwY87KanXSpCrC1CUEr4nh/JMbWr42A9ZwXAQ9GddciUOoQHuMlkhCu HSUq3i++BAOxFoFW7GATjZ+5txrXOtJg3SezZzbX+UJJVDatuf4sI2PKbcKeXvbm CNhMQ7XhlzdGqpx3rn4TaPYsZTpBe0z9ojbZDCeVm3829QhCtCDT9pE7RqFvqs4p K+ildctX4Pr2O2tCWq6ZmnHxB0hoHHrQJHrTuziDOSkgxJsqfSOYRA/qWPFwoWbm k1TljhvEDKxbz57UWPuza+oxoKmk5w== =Eanm -----END PGP SIGNATURE----- --OXfL5xGRrasGEqWY-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 08 21:39:03 2017 Received: (at 25390) by debbugs.gnu.org; 9 Jan 2017 02:39:03 +0000 Received: from localhost ([127.0.0.1]:47316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQPrS-000881-Iv for submit@debbugs.gnu.org; Sun, 08 Jan 2017 21:39:03 -0500 Received: from mailgw04.kcn.ne.jp ([61.86.7.211]:36196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQPrN-00087N-Op for 25390@debbugs.gnu.org; Sun, 08 Jan 2017 21:39:00 -0500 Received: from mxs02-s (mailgw2.kcn.ne.jp [61.86.15.234]) by mailgw04.kcn.ne.jp (Postfix) with ESMTP id E3065806AC for <25390@debbugs.gnu.org>; Mon, 9 Jan 2017 11:38:50 +0900 (JST) X-matriXscan-loop-detect: 2a8da314530e56092a6619775b2256d2d3ec54d3 Received: from mail05.kcn.ne.jp ([61.86.6.184]) by mxs02-s with ESMTP; Mon, 09 Jan 2017 11:38:43 +0900 (JST) Received: from [10.120.1.61] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail05.kcn.ne.jp (Postfix) with ESMTPA id C82817D0099; Mon, 9 Jan 2017 11:38:42 +0900 (JST) Date: Mon, 09 Jan 2017 11:38:40 +0900 From: Norihiro Tanaka To: Paul Eggert Subject: Re: bug#25390: Segfault with sed 4.3 In-Reply-To: <216dfc52-a392-a85f-fa49-fdef9d020949@cs.ucla.edu> References: <9B5E3836-1C2B-4CAD-91A2-CBB9319C1095@gmail.com> <216dfc52-a392-a85f-fa49-fdef9d020949@cs.ucla.edu> Message-Id: <20170109113813.D4F3.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_5872F3F000000000D4EA_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-matriXscan-Sophos-AV: Clean X-matriXscan-Action: Approve X-matriXscan: Uncategorized X-Spam-Score: -3.2 (---) X-Debbugs-Envelope-To: 25390 Cc: 25390@debbugs.gnu.org, Assaf Gordon , Gnulib bugs , "S. Gilles" , GNU grep developers X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) --------_5872F3F000000000D4EA_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit On Sun, 8 Jan 2017 12:49:42 -0800 Paul Eggert wrote: > Assaf Gordon wrote: > > The immediate cause is somewhere in gnulib's DFA module. > > The bug was introduced in Gnulib, in commit 403adf1b40897ba108075008c10bd38d937e1539 > dated 2016-11-25 and labeled "dfa: addition of new state on demand". > It's not a bug that grep runs into, since grep doesn't use the > newline transition that sed does. I installed the attached patch to > fix the Gnulib bug. I'll leave Bug#25390 open, as I assume you'll > want to check it for 'sed' and add a test case for 'sed'. Thanks for fixing quickly. I wrote two additional patches for dfa. First, derive number of allocation from not argument but number of state in transition table allocation. Second, melt down dfastate() into build_state(). Now, I think that there do not have to be separated. I also wrote a simple test, but the issue are not always caused, as it depends on state of memory. Should we rely to complate the test on valgrind? --------_5872F3F000000000D4EA_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-dfa-simplify-transition-table-allocation.patch" Content-Disposition: attachment; filename="0001-dfa-simplify-transition-table-allocation.patch" Content-Transfer-Encoding: base64 RnJvbSAyYTRhOGIyYjc1ZDA4YzA1ODAzZWEwNTgwZGUxNTIwNTg4NTJhYzA0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBNb24sIDkgSmFuIDIwMTcgMDc6NDY6MTMgKzA5MDAKU3ViamVjdDogW1BBVENIIDEvMl0g ZGZhOiBzaW1wbGlmeSB0cmFuc2l0aW9uIHRhYmxlIGFsbG9jYXRpb24KCiogc3JjL2RmYS5jIChy ZWFsbG9jX3RyYW5zX2lmX25lY2Vzc2FyeSk6IFJlbW92ZSBzZWNvbmQgYXJndW1lbnQuCkl0cyB2 YWx1ZSBpcyBkZXJpdmVkIGZyb20gb3RoZXIgdmFyaWFibGUuICBVcGRhdGUgY2FsbGVycy4KKGRm YXN0YXRlKTogUmVtb3ZlIGNhbGN1bGF0aW9uIG9mIG1heCBudW1iZXIgb2Ygc3RhdGUuCi0tLQog bGliL2RmYS5jIHwgICA0NCArKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQogMSBmaWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAyNCBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9saWIvZGZhLmMgYi9saWIvZGZhLmMKaW5kZXggMTQxODg4YS4uYmRhNDYw MiAxMDA2NDQKLS0tIGEvbGliL2RmYS5jCisrKyBiL2xpYi9kZmEuYwpAQCAtMjU3NiwxNCArMjU3 NiwxNCBAQCBkZmFhbmFseXplIChzdHJ1Y3QgZGZhICpkLCBib29sIHNlYXJjaGZsYWcpCiAKIC8q IE1ha2Ugc3VyZSBEJ3Mgc3RhdGUgYXJyYXlzIGFyZSBsYXJnZSBlbm91Z2ggdG8gaG9sZCBORVdf U1RBVEUuICAqLwogc3RhdGljIHZvaWQKLXJlYWxsb2NfdHJhbnNfaWZfbmVjZXNzYXJ5IChzdHJ1 Y3QgZGZhICpkLCBzdGF0ZV9udW0gbmV3X3N0YXRlKQorcmVhbGxvY190cmFuc19pZl9uZWNlc3Nh cnkgKHN0cnVjdCBkZmEgKmQpCiB7CiAgIHN0YXRlX251bSBvbGRhbGxvYyA9IGQtPnRyYWxsb2M7 Ci0gIGlmIChvbGRhbGxvYyA8PSBuZXdfc3RhdGUpCisgIGlmIChvbGRhbGxvYyA8IGQtPnNpbmRl eCkKICAgICB7CiAgICAgICBzdGF0ZV9udW0gKipyZWFsdHJhbnMgPSBkLT50cmFucyA/IGQtPnRy YW5zIC0gMiA6IE5VTEw7CiAgICAgICBwdHJkaWZmX3QgbmV3YWxsb2MxID0gcmVhbHRyYW5zID8g ZC0+dHJhbGxvYyArIDIgOiAwOwotICAgICAgcmVhbHRyYW5zID0geHBhbGxvYyAocmVhbHRyYW5z LCAmbmV3YWxsb2MxLCBuZXdfc3RhdGUgLSBvbGRhbGxvYyArIDEsCisgICAgICByZWFsdHJhbnMg PSB4cGFsbG9jIChyZWFsdHJhbnMsICZuZXdhbGxvYzEsIGQtPnNpbmRleCAtIG9sZGFsbG9jLAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgLTEsIHNpemVvZiAqcmVhbHRyYW5zKTsKICAgICAg IHJlYWx0cmFuc1swXSA9IHJlYWx0cmFuc1sxXSA9IE5VTEw7CiAgICAgICBkLT50cmFucyA9IHJl YWx0cmFucyArIDI7CkBAIC0yODI1LDYgKzI4MjUsOSBAQCBkZmFzdGF0ZSAoc3RhdGVfbnVtIHMs IHN0cnVjdCBkZmEgKmQsIHVuc2lnbmVkIGNoYXIgdWMsIHN0YXRlX251bSB0cmFuc1tdKQogICAg ICAgICBzdGF0ZV9sZXR0ZXIgPSBzdGF0ZV9pbmRleCAoZCwgJmZvbGxvd3MsIENUWF9MRVRURVIp OwogICAgICAgZWxzZQogICAgICAgICBzdGF0ZV9sZXR0ZXIgPSBzdGF0ZTsKKworICAgICAgLyog UmVhbGxvY2F0ZSBub3csIHRvIHJlYWxsb2NhdGUgYW55IG5ld2xpbmUgdHJhbnNpdGlvbiBwcm9w ZXJseS4gICovCisgICAgICByZWFsbG9jX3RyYW5zX2lmX25lY2Vzc2FyeSAoZCk7CiAgICAgfQog CiAgIC8qIElmIHdlIGFyZSBhIHNlYXJjaGluZyBtYXRjaGVyLCB0aGUgZGVmYXVsdCB0cmFuc2l0 aW9uIGlzIHRvIGEgc3RhdGUKQEAgLTI4NDcsMjIgKzI4NTAsMTggQEAgZGZhc3RhdGUgKHN0YXRl X251bSBzLCBzdHJ1Y3QgZGZhICpkLCB1bnNpZ25lZCBjaGFyIHVjLCBzdGF0ZV9udW0gdHJhbnNb XSkKICAgc3RhdGVfbnVtIG1heHN0YXRlID0gLTE7CiAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwg Tk9UQ0hBUjsgaSsrKQogICAgIGlmICh0c3RiaXQgKGksICZsYWJlbCkpCi0gICAgICB7Ci0gICAg ICAgIHN3aXRjaCAoZC0+c3ludGF4LnNiaXRbaV0pCi0gICAgICAgICAgewotICAgICAgICAgIGNh c2UgQ1RYX05FV0xJTkU6Ci0gICAgICAgICAgICB0cmFuc1tpXSA9IHN0YXRlX25ld2xpbmU7Ci0g ICAgICAgICAgICBicmVhazsKLSAgICAgICAgICBjYXNlIENUWF9MRVRURVI6Ci0gICAgICAgICAg ICB0cmFuc1tpXSA9IHN0YXRlX2xldHRlcjsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAg IGRlZmF1bHQ6Ci0gICAgICAgICAgICB0cmFuc1tpXSA9IHN0YXRlOwotICAgICAgICAgICAgYnJl YWs7Ci0gICAgICAgICAgfQotICAgICAgICBpZiAobWF4c3RhdGUgPCB0cmFuc1tpXSkKLSAgICAg ICAgICBtYXhzdGF0ZSA9IHRyYW5zW2ldOwotICAgICAgfQorICAgICAgc3dpdGNoIChkLT5zeW50 YXguc2JpdFtpXSkKKyAgICAgICAgeworICAgICAgICBjYXNlIENUWF9ORVdMSU5FOgorICAgICAg ICAgIHRyYW5zW2ldID0gc3RhdGVfbmV3bGluZTsKKyAgICAgICAgICBicmVhazsKKyAgICAgICAg Y2FzZSBDVFhfTEVUVEVSOgorICAgICAgICAgIHRyYW5zW2ldID0gc3RhdGVfbGV0dGVyOworICAg ICAgICAgIGJyZWFrOworICAgICAgICBkZWZhdWx0OgorICAgICAgICAgIHRyYW5zW2ldID0gc3Rh dGU7CisgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KIAogI2lmZGVmIERFQlVHCiAgIGZwcmlu dGYgKHN0ZGVyciwgInRyYW5zIHRhYmxlICV0ZCIsIHMpOwpAQCAtMjg3OSw5ICsyODc4LDYgQEAg ZGZhc3RhdGUgKHN0YXRlX251bSBzLCBzdHJ1Y3QgZGZhICpkLCB1bnNpZ25lZCBjaGFyIHVjLCBz dGF0ZV9udW0gdHJhbnNbXSkKICAgZnJlZSAoZm9sbG93cy5lbGVtcyk7CiAgIGZyZWUgKHRtcC5l bGVtcyk7CiAKLSAgLyogUmVhbGxvY2F0ZSBub3csIHRvIHJlYWxsb2NhdGUgYW55IG5ld2xpbmUg dHJhbnNpdGlvbiBwcm9wZXJseS4gICovCi0gIHJlYWxsb2NfdHJhbnNfaWZfbmVjZXNzYXJ5IChk LCBtYXhzdGF0ZSk7Ci0KICAgLyogS2VlcCB0aGUgbmV3bGluZSB0cmFuc2l0aW9uIGluIGEgc3Bl Y2lhbCBwbGFjZSBzbyB3ZSBjYW4gdXNlIGl0IGFzCiAgICAgIGEgc2VudGluZWwuICAqLwogICBp ZiAodHN0Yml0IChkLT5zeW50YXguZW9sYnl0ZSwgJmxhYmVsKSkKQEAgLTMwNDIsNyArMzAzOCw3 IEBAIHRyYW5zaXRfc3RhdGUgKHN0cnVjdCBkZmEgKmQsIHN0YXRlX251bSBzLCB1bnNpZ25lZCBj aGFyIGNvbnN0ICoqcHAsCiAKICAgaW50IHNlcGFyYXRlX2NvbnRleHRzID0gc3RhdGVfc2VwYXJh dGVfY29udGV4dHMgKCZkLT5tYl9mb2xsb3dzKTsKICAgc3RhdGVfbnVtIHMyID0gc3RhdGVfaW5k ZXggKGQsICZkLT5tYl9mb2xsb3dzLCBzZXBhcmF0ZV9jb250ZXh0cyBeIENUWF9BTlkpOwotICBy ZWFsbG9jX3RyYW5zX2lmX25lY2Vzc2FyeSAoZCwgczIpOworICByZWFsbG9jX3RyYW5zX2lmX25l Y2Vzc2FyeSAoZCk7CiAKICAgZC0+bWJfdHJhbnNbc11bZC0+c3RhdGVzW3MxXS5tYl90cmluZGV4 XSA9IHMyOwogCkBAIC0zMTM3LDcgKzMxMzMsNyBAQCBkZmFleGVjX21haW4gKHN0cnVjdCBkZmEg KmQsIGNoYXIgY29uc3QgKmJlZ2luLCBjaGFyICplbmQsIGJvb2wgYWxsb3dfbmwsCiAgICAgfQog CiAgIGlmICghZC0+dHJhbGxvYykKLSAgICByZWFsbG9jX3RyYW5zX2lmX25lY2Vzc2FyeSAoZCwg MCk7CisgICAgcmVhbGxvY190cmFuc19pZl9uZWNlc3NhcnkgKGQpOwogCiAgIC8qIEN1cnJlbnQg c3RhdGUuICAqLwogICBzdGF0ZV9udW0gcyA9IDAsIHMxID0gMDsKLS0gCjEuNy4xCgo= --------_5872F3F000000000D4EA_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0002-dfa-melt-down-dfastate-into-build_state.patch" Content-Disposition: attachment; filename="0002-dfa-melt-down-dfastate-into-build_state.patch" Content-Transfer-Encoding: base64 RnJvbSBjYTQ3YmExNmI5NTlhNDVmZmY3NWIzYjMxZTFhMWRjNGYwYzRhZGI1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBNb24sIDkgSmFuIDIwMTcgMDg6MjE6MjEgKzA5MDAKU3ViamVjdDogW1BBVENIIDIvMl0g ZGZhOiBtZWx0IGRvd24gZGZhc3RhdGUgaW50byBidWlsZF9zdGF0ZQoKKiBzcmMvZGZhLmMgKGRm YXN0YXRlKTogUmVtb3ZlIGl0LgooYnVpbGRfc3RhdGUpOiBJbnNlcnQgY29udGVudCBvZiBkZmFz dGF0ZSgpIHRvIGJvdHRvbS4KLS0tCiBsaWIvZGZhLmMgfCAgIDk3ICsrKysrKysrKysrKysrKysr KysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlcyBjaGFu Z2VkLCA0NSBpbnNlcnRpb25zKCspLCA1MiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saWIv ZGZhLmMgYi9saWIvZGZhLmMKaW5kZXggYmRhNDYwMi4uNjg5NmVkMyAxMDA2NDQKLS0tIGEvbGli L2RmYS5jCisrKyBiL2xpYi9kZmEuYwpAQCAtMjYwOSw4ICsyNjA5LDEwIEBAIHJlYWxsb2NfdHJh bnNfaWZfbmVjZXNzYXJ5IChzdHJ1Y3QgZGZhICpkKQogICAgIH0KIH0KIAotLyogUmV0dXJuIHRo ZSB0cmFuc2l0aW9uIG91dCBvZiBzdGF0ZSBzIG9mIGQgZm9yIHRoZSBpbnB1dCBjaGFyYWN0ZXIg dWMsCi0gICB1cGRhdGluZyB0aGUgc2xvdHMgaW4gdHJhbnMgYWNjb3JkaW5nbHkuCisvKgorICAg Q2FsY3VsYXRlIHRoZSB0cmFuc2l0aW9uIHRhYmxlIGZvciBhIG5ldyBzdGF0ZSBkZXJpdmVkIGZy b20gc3RhdGUgcworICAgZm9yIGEgY29tcGlsZWQgZGZhIGQgYWZ0ZXIgaW5wdXQgY2hhcmFjdGVy IHVjLCBhbmQgcmV0dXJuIHRoZSBuZXcKKyAgIHN0YXRlIG51bWJlci4KIAogICAgRG8gbm90IHdv cnJ5IGFib3V0IGFsbCBwb3NzaWJsZSBpbnB1dCBjaGFyYWN0ZXJzOyBjYWxjdWxhdGUganVzdCB0 aGUgZ3JvdXAKICAgIG9mIHBvc2l0aW9ucyB0aGF0IG1hdGNoIHVjLiAgTGFiZWwgaXQgd2l0aCB0 aGUgc2V0IG9mIGNoYXJhY3RlcnMgdGhhdApAQCAtMjYzOSw4ICsyNjQxLDkgQEAgcmVhbGxvY190 cmFuc19pZl9uZWNlc3NhcnkgKHN0cnVjdCBkZmEgKmQpCiAgICBJZiBhZnRlciBjb21wYXJpbmcg d2l0aCBldmVyeSBncm91cCB0aGVyZSBhcmUgY2hhcmFjdGVycyByZW1haW5pbmcgaW4gQywKICAg IGNyZWF0ZSBhIG5ldyBncm91cCBsYWJlbGVkIHdpdGggdGhlIGNoYXJhY3RlcnMgb2YgQyBhbmQg aW5zZXJ0IHRoaXMKICAgIHBvc2l0aW9uIGluIHRoYXQgZ3JvdXAuICAqLworCiBzdGF0aWMgc3Rh dGVfbnVtCi1kZmFzdGF0ZSAoc3RhdGVfbnVtIHMsIHN0cnVjdCBkZmEgKmQsIHVuc2lnbmVkIGNo YXIgdWMsIHN0YXRlX251bSB0cmFuc1tdKQorYnVpbGRfc3RhdGUgKHN0YXRlX251bSBzLCBzdHJ1 Y3QgZGZhICpkLCB1bnNpZ25lZCBjaGFyIHVjKQogewogICBwb3NpdGlvbl9zZXQgZm9sbG93czsg ICAgICAgICAvKiBVbmlvbiBvZiB0aGUgZm9sbG93cyBvZiB0aGUgZ3JvdXAuICAqLwogICBwb3Np dGlvbl9zZXQgdG1wOyAgICAgICAgICAgICAvKiBUZW1wb3Jhcnkgc3BhY2UgZm9yIG1lcmdpbmcg c2V0cy4gICovCkBAIC0yNjUyLDYgKzI2NTUsNDUgQEAgZGZhc3RhdGUgKHN0YXRlX251bSBzLCBz dHJ1Y3QgZGZhICpkLCB1bnNpZ25lZCBjaGFyIHVjLCBzdGF0ZV9udW0gdHJhbnNbXSkKICAgZnBy aW50ZiAoc3RkZXJyLCAiYnVpbGQgc3RhdGUgJXRkXG4iLCBzKTsKICNlbmRpZgogCisgIC8qIEEg cG9pbnRlciB0byB0aGUgbmV3IHRyYW5zaXRpb24gdGFibGUsIGFuZCB0aGUgdGFibGUgaXRzZWxm LiAgKi8KKyAgc3RhdGVfbnVtICoqcHRyYW5zID0gKGFjY2VwdGluZyAocywgZCkgPyBkLT5mYWls cyA6IGQtPnRyYW5zKSArIHM7CisgIHN0YXRlX251bSAqdHJhbnMgPSAqcHRyYW5zOworCisgIGlm ICghdHJhbnMpCisgICAgeworICAgICAgLyogTUFYX1RSQ09VTlQgaXMgYW4gYXJiaXRyYXJ5IHVw cGVyIGxpbWl0IG9uIHRoZSBudW1iZXIgb2YKKyAgICAgICAgIHRyYW5zaXRpb24gdGFibGVzIHRo YXQgY2FuIGV4aXN0IGF0IG9uY2UsIG90aGVyIHRoYW4gZm9yCisgICAgICAgICBpbml0aWFsIHN0 YXRlcy4gIE9mdGVuLXVzZWQgdHJhbnNpdGlvbiB0YWJsZXMgYXJlIHF1aWNrbHkKKyAgICAgICAg IHJlYnVpbHQsIHdoZXJlYXMgcmFyZWx5LXVzZWQgb25lcyBhcmUgY2xlYXJlZCBhd2F5LiAgKi8K KyAgICAgIGlmIChNQVhfVFJDT1VOVCA8PSBkLT50cmNvdW50KQorICAgICAgICB7CisgICAgICAg ICAgZm9yIChzdGF0ZV9udW0gaSA9IGQtPm1pbl90cmNvdW50OyBpIDwgZC0+dHJhbGxvYzsgaSsr KQorICAgICAgICAgICAgeworICAgICAgICAgICAgICBmcmVlIChkLT50cmFuc1tpXSk7CisgICAg ICAgICAgICAgIGZyZWUgKGQtPmZhaWxzW2ldKTsKKyAgICAgICAgICAgICAgZC0+dHJhbnNbaV0g PSBkLT5mYWlsc1tpXSA9IE5VTEw7CisgICAgICAgICAgICB9CisgICAgICAgICAgZC0+dHJjb3Vu dCA9IDA7CisgICAgICAgIH0KKworICAgICAgZC0+dHJjb3VudCsrOworICAgICAgKnB0cmFucyA9 IHRyYW5zID0geG1hbGxvYyAoTk9UQ0hBUiAqIHNpemVvZiAqdHJhbnMpOworCisgICAgICAvKiBG aWxsIHRyYW5zaXRpb24gdGFibGUgd2l0aCBhIGRlZmF1bHQgdmFsdWUgd2hpY2ggbWVhbnMgdGhh dCB0aGUKKyAgICAgICAgIHRyYW5zaXRlZCBzdGF0ZSBoYXMgbm90IGJlZW4gY2FsY3VsYXRlZCB5 ZXQuICAqLworICAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBOT1RDSEFSOyBpKyspCisgICAgICAg IHRyYW5zW2ldID0gLTI7CisgICAgfQorCisgIC8qIFNldCB1cCB0aGUgc3VjY2VzcyBiaXRzIGZv ciB0aGlzIHN0YXRlLiAgKi8KKyAgZC0+c3VjY2Vzc1tzXSA9IDA7CisgIGlmIChhY2NlcHRzX2lu X2NvbnRleHQgKGQtPnN0YXRlc1tzXS5jb250ZXh0LCBDVFhfTkVXTElORSwgcywgZCkpCisgICAg ZC0+c3VjY2Vzc1tzXSB8PSBDVFhfTkVXTElORTsKKyAgaWYgKGFjY2VwdHNfaW5fY29udGV4dCAo ZC0+c3RhdGVzW3NdLmNvbnRleHQsIENUWF9MRVRURVIsIHMsIGQpKQorICAgIGQtPnN1Y2Nlc3Nb c10gfD0gQ1RYX0xFVFRFUjsKKyAgaWYgKGFjY2VwdHNfaW5fY29udGV4dCAoZC0+c3RhdGVzW3Nd LmNvbnRleHQsIENUWF9OT05FLCBzLCBkKSkKKyAgICBkLT5zdWNjZXNzW3NdIHw9IENUWF9OT05F OworCiAgIC8qIFBvc2l0aW9ucyB0aGF0IG1hdGNoIHRoZSBpbnB1dCBjaGFyLiAgKi8KICAgbGVh Zl9zZXQgZ3JvdXA7CiAgIGdyb3VwLmVsZW1zID0geG5tYWxsb2MgKGQtPm5sZWF2ZXMsIHNpemVv ZiAqZ3JvdXAuZWxlbXMpOwpAQCAtMjg4OSw1NSArMjkzMSw2IEBAIGRmYXN0YXRlIChzdGF0ZV9u dW0gcywgc3RydWN0IGRmYSAqZCwgdW5zaWduZWQgY2hhciB1Yywgc3RhdGVfbnVtIHRyYW5zW10p CiAgIHJldHVybiB0cmFuc1t1Y107CiB9CiAKLS8qIENhbGN1bGF0ZSB0aGUgdHJhbnNpdGlvbiB0 YWJsZSBmb3IgYSBuZXcgc3RhdGUgZGVyaXZlZCBmcm9tIHN0YXRlIHMKLSAgIGZvciBhIGNvbXBp bGVkIGRmYSBkIGFmdGVyIGlucHV0IGNoYXJhY3RlciB1YywgYW5kIHJldHVybiB0aGUgbmV3Ci0g ICBzdGF0ZSBudW1iZXIuICAqLwotCi1zdGF0aWMgc3RhdGVfbnVtCi1idWlsZF9zdGF0ZSAoc3Rh dGVfbnVtIHMsIHN0cnVjdCBkZmEgKmQsIHVuc2lnbmVkIGNoYXIgdWMpCi17Ci0gIC8qIEEgcG9p bnRlciB0byB0aGUgbmV3IHRyYW5zaXRpb24gdGFibGUsIGFuZCB0aGUgdGFibGUgaXRzZWxmLiAg Ki8KLSAgc3RhdGVfbnVtICoqcHRyYW5zID0gKGFjY2VwdGluZyAocywgZCkgPyBkLT5mYWlscyA6 IGQtPnRyYW5zKSArIHM7Ci0gIHN0YXRlX251bSAqdHJhbnMgPSAqcHRyYW5zOwotCi0gIGlmICgh dHJhbnMpCi0gICAgewotICAgICAgLyogTUFYX1RSQ09VTlQgaXMgYW4gYXJiaXRyYXJ5IHVwcGVy IGxpbWl0IG9uIHRoZSBudW1iZXIgb2YKLSAgICAgICAgIHRyYW5zaXRpb24gdGFibGVzIHRoYXQg Y2FuIGV4aXN0IGF0IG9uY2UsIG90aGVyIHRoYW4gZm9yCi0gICAgICAgICBpbml0aWFsIHN0YXRl cy4gIE9mdGVuLXVzZWQgdHJhbnNpdGlvbiB0YWJsZXMgYXJlIHF1aWNrbHkKLSAgICAgICAgIHJl YnVpbHQsIHdoZXJlYXMgcmFyZWx5LXVzZWQgb25lcyBhcmUgY2xlYXJlZCBhd2F5LiAgKi8KLSAg ICAgIGlmIChNQVhfVFJDT1VOVCA8PSBkLT50cmNvdW50KQotICAgICAgICB7Ci0gICAgICAgICAg Zm9yIChzdGF0ZV9udW0gaSA9IGQtPm1pbl90cmNvdW50OyBpIDwgZC0+dHJhbGxvYzsgaSsrKQot ICAgICAgICAgICAgewotICAgICAgICAgICAgICBmcmVlIChkLT50cmFuc1tpXSk7Ci0gICAgICAg ICAgICAgIGZyZWUgKGQtPmZhaWxzW2ldKTsKLSAgICAgICAgICAgICAgZC0+dHJhbnNbaV0gPSBk LT5mYWlsc1tpXSA9IE5VTEw7Ci0gICAgICAgICAgICB9Ci0gICAgICAgICAgZC0+dHJjb3VudCA9 IDA7Ci0gICAgICAgIH0KLQotICAgICAgZC0+dHJjb3VudCsrOwotICAgICAgKnB0cmFucyA9IHRy YW5zID0geG1hbGxvYyAoTk9UQ0hBUiAqIHNpemVvZiAqdHJhbnMpOwotCi0gICAgICAvKiBGaWxs IHRyYW5zaXRpb24gdGFibGUgd2l0aCBhIGRlZmF1bHQgdmFsdWUgd2hpY2ggbWVhbnMgdGhhdCB0 aGUKLSAgICAgICAgIHRyYW5zaXRlZCBzdGF0ZSBoYXMgbm90IGJlZW4gY2FsY3VsYXRlZCB5ZXQu ICAqLwotICAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBOT1RDSEFSOyBpKyspCi0gICAgICAgIHRy YW5zW2ldID0gLTI7Ci0gICAgfQotCi0gIC8qIFNldCB1cCB0aGUgc3VjY2VzcyBiaXRzIGZvciB0 aGlzIHN0YXRlLiAgKi8KLSAgZC0+c3VjY2Vzc1tzXSA9IDA7Ci0gIGlmIChhY2NlcHRzX2luX2Nv bnRleHQgKGQtPnN0YXRlc1tzXS5jb250ZXh0LCBDVFhfTkVXTElORSwgcywgZCkpCi0gICAgZC0+ c3VjY2Vzc1tzXSB8PSBDVFhfTkVXTElORTsKLSAgaWYgKGFjY2VwdHNfaW5fY29udGV4dCAoZC0+ c3RhdGVzW3NdLmNvbnRleHQsIENUWF9MRVRURVIsIHMsIGQpKQotICAgIGQtPnN1Y2Nlc3Nbc10g fD0gQ1RYX0xFVFRFUjsKLSAgaWYgKGFjY2VwdHNfaW5fY29udGV4dCAoZC0+c3RhdGVzW3NdLmNv bnRleHQsIENUWF9OT05FLCBzLCBkKSkKLSAgICBkLT5zdWNjZXNzW3NdIHw9IENUWF9OT05FOwot Ci0gIHJldHVybiBkZmFzdGF0ZSAocywgZCwgdWMsIHRyYW5zKTsKLX0KLQogLyogTXVsdGlieXRl IGNoYXJhY3RlciBoYW5kbGluZyBzdWItcm91dGluZXMgZm9yIGRmYWV4ZWMuICAqLwogCiAvKiBD b25zdW1lIGEgc2luZ2xlIGJ5dGUgYW5kIHRyYW5zaXQgc3RhdGUgZnJvbSAncycgdG8gJypuZXh0 X3N0YXRlJy4KLS0gCjEuNy4xCgo= --------_5872F3F000000000D4EA_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-tests-new-test-for-dfa-crash-bug.patch" Content-Disposition: attachment; filename="0001-tests-new-test-for-dfa-crash-bug.patch" Content-Transfer-Encoding: base64 RnJvbSAwYzM5OGE2OWY2YmY3OTczODhlZTdmNTliZDg1MGRhNGRkZDBiNWZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBNb24sIDkgSmFuIDIwMTcgMDg6NTQ6MjggKzA5MDAKU3ViamVjdDogW1BBVENIXSB0ZXN0 czogbmV3IHRlc3QgZm9yIGRmYSBjcmFzaCBidWcKCk1heWJlIGRmYSBjcmFzaGVzIGlmIG11bHRp LWxpbmVzIGFyZSByZWFkIGluIHBhdHRlcm4gc3BhY2UuICBJdCBpcyBmaXhlZAphdCBjb21taXQg ODIzYjVjYjU4OTM2NmY3Yzg3NDI1MDNhZjk4MDgwM2FmYWQwOTc4ZiBpbiBnbnVsaWIuClJlcG9y dGVkIGJ5IFMuIEdpbGxlcyBpbiBodHRwczovL2J1Z3MuZ251Lm9yZy8yNTM5MAoKKiB0ZXN0c3Vp dGUvbmV3bGluZS5nb29kLCB0ZXN0c3VpdGUvbmV3bGluZS5zZWQsCnRlc3RzdWl0ZS9uZXdsaW5l LnNlZDogTmV3IHRlc3QuCiogdGVzdHN1aXRlL01ha2VmaWxlLnRlc3RzOiBBZGQgdGhlIHRlc3Qu CiogdGVzdHN1aXRlL2xvY2FsLm1rOiBBZGQgdGhlIHRlc3QuCi0tLQogdGVzdHN1aXRlL01ha2Vm aWxlLnRlc3RzIHwgICAgMyArKy0KIHRlc3RzdWl0ZS9sb2NhbC5tayAgICAgICB8ICAgIDYgKysr KystCiB0ZXN0c3VpdGUvbmV3bGluZS5nb29kICAgfCAgICAxICsKIHRlc3RzdWl0ZS9uZXdsaW5l LmlucCAgICB8ICAgIDIgKysKIHRlc3RzdWl0ZS9uZXdsaW5lLnNlZCAgICB8ICAgIDIgKysKIDUg ZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKIGNyZWF0ZSBt b2RlIDEwMDY0NCB0ZXN0c3VpdGUvbmV3bGluZS5nb29kCiBjcmVhdGUgbW9kZSAxMDA2NDQgdGVz dHN1aXRlL25ld2xpbmUuaW5wCiBjcmVhdGUgbW9kZSAxMDA2NDQgdGVzdHN1aXRlL25ld2xpbmUu c2VkCgpkaWZmIC0tZ2l0IGEvdGVzdHN1aXRlL01ha2VmaWxlLnRlc3RzIGIvdGVzdHN1aXRlL01h a2VmaWxlLnRlc3RzCmluZGV4IDAwYTRlYzguLjUzYmQ4M2QgMTAwNjQ0Ci0tLSBhL3Rlc3RzdWl0 ZS9NYWtlZmlsZS50ZXN0cworKysgYi90ZXN0c3VpdGUvTWFrZWZpbGUudGVzdHMKQEAgLTIyLDcg KzIyLDggQEAgU0tJUCA9IDo+JEAuc2tpcDsgZXhpdCA3NwogZW5hYmxlIHNlcCBpbmNsaWIgOGJp dCA4dG83IG5ld2ppcyB4YWJjeCBkb2xsYXIgbm9lb2wgYmtzbGFzaGVzIFwKIG51bXN1YiBoZWFk IG1hZGRpbmcgbWFjLW1mIGVtcHR5IHhieGN4IHhieGN4MyByZWNhbGwgcmVjYWxsMiB4ZW1hY3Mg XAogYXBwcXVpdCBmYXN0cyB1bmlxIG1hbmlzIGxpbmVjbnQga2hhZGFmeSBhbGxzdWIgZmxpcGNh c2Ugc3BhY2UgbW9kdWxvIFwKLXktYnJhY2tldCB5LW5ld2xpbmUgeS16ZXJvIGluc2VydCBicmFj a2V0cyBhbXAtZXNjYXBlIG5ld2xpbmUtYW5jaG9yOjoKK3ktYnJhY2tldCB5LW5ld2xpbmUgeS16 ZXJvIGluc2VydCBicmFja2V0cyBhbXAtZXNjYXBlIG5ld2xpbmUtYW5jaG9yIFwKK25ld2xpbmU6 OgogCSQoU0VERU5WKSAkKFNFRCkgLWYgJChzcmNkaXIpLyRALnNlZCBcCiAJCTwgJChzcmNkaXIp LyRALmlucCB8ICQoZWxpZGVfY3IpID4gJEAub3V0CiAJJChDTVApICQoc3JjZGlyKS8kQC5nb29k ICRALm91dApkaWZmIC0tZ2l0IGEvdGVzdHN1aXRlL2xvY2FsLm1rIGIvdGVzdHN1aXRlL2xvY2Fs Lm1rCmluZGV4IGZhZTYyMjUuLjRiYTAyOTggMTAwNjQ0Ci0tLSBhL3Rlc3RzdWl0ZS9sb2NhbC5t aworKysgYi90ZXN0c3VpdGUvbG9jYWwubWsKQEAgLTEwOSw3ICsxMDksOCBAQCBTRURURVNUUyAr PSB0ZXN0c3VpdGUvYXBwcXVpdCB0ZXN0c3VpdGUvZW5hYmxlIHRlc3RzdWl0ZS9zZXAJCVwKICAg ICAgICAgdGVzdHN1aXRlL2FtcC1lc2NhcGUgdGVzdHN1aXRlL2hlbHAgdGVzdHN1aXRlL2ZpbGUJ CVwKICAgICAgICAgdGVzdHN1aXRlL3F1aWV0IHRlc3RzdWl0ZS9mYWN0b3IgdGVzdHN1aXRlL2Jp bmFyeTMJCVwKICAgICAgICAgdGVzdHN1aXRlL2JpbmFyeTIgdGVzdHN1aXRlL2JpbmFyeSB0ZXN0 c3VpdGUvZGMJCQlcCi0gICAgICAgIHRlc3RzdWl0ZS9uZXdsaW5lLWFuY2hvciB0ZXN0c3VpdGUv emVyby1hbmNob3IKKyAgICAgICAgdGVzdHN1aXRlL25ld2xpbmUtYW5jaG9yIHRlc3RzdWl0ZS96 ZXJvLWFuY2hvcgkJCVwKKyAgICAgICAgdGVzdHN1aXRlL25ld2xpbmUKIAogIyBOb3RlIHRoYXQg dGhlIGZpcnN0IGxpbmVzIGFyZSBzdGF0ZW1lbnRzLiAgVGhleSBlbnN1cmUgdGhhdCBlbnZpcm9u bWVudAogIyB2YXJpYWJsZXMgdGhhdCBjYW4gcGVydHVyYiB0ZXN0cyBhcmUgdW5zZXQgb3Igc2V0 IHRvIGV4cGVjdGVkIHZhbHVlcy4KQEAgLTI3NSw2ICsyNzYsOSBAQCBFWFRSQV9ESVNUICs9IFwK IAl0ZXN0c3VpdGUvbmV3amlzLmdvb2QgXAogCXRlc3RzdWl0ZS9uZXdqaXMuaW5wIFwKIAl0ZXN0 c3VpdGUvbmV3amlzLnNlZCBcCisJdGVzdHN1aXRlL25ld2xpbmUuZ29vZCBcCisJdGVzdHN1aXRl L25ld2xpbmUuaW5wIFwKKwl0ZXN0c3VpdGUvbmV3bGluZS5zZWQgXAogCXRlc3RzdWl0ZS9uZXds aW5lLWFuY2hvci5nb29kIFwKIAl0ZXN0c3VpdGUvbmV3bGluZS1hbmNob3IuaW5wIFwKIAl0ZXN0 c3VpdGUvbmV3bGluZS1hbmNob3Iuc2VkIFwKZGlmZiAtLWdpdCBhL3Rlc3RzdWl0ZS9uZXdsaW5l Lmdvb2QgYi90ZXN0c3VpdGUvbmV3bGluZS5nb29kCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAuLjU4N2JlNmIKLS0tIC9kZXYvbnVsbAorKysgYi90ZXN0c3VpdGUvbmV3bGluZS5n b29kCkBAIC0wLDAgKzEgQEAKK3gKZGlmZiAtLWdpdCBhL3Rlc3RzdWl0ZS9uZXdsaW5lLmlucCBi L3Rlc3RzdWl0ZS9uZXdsaW5lLmlucApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw Li5iMjExODU2Ci0tLSAvZGV2L251bGwKKysrIGIvdGVzdHN1aXRlL25ld2xpbmUuaW5wCkBAIC0w LDAgKzEsMiBAQAorMTIzNDU2Nzg5YWJjZAoreApkaWZmIC0tZ2l0IGEvdGVzdHN1aXRlL25ld2xp bmUuc2VkIGIvdGVzdHN1aXRlL25ld2xpbmUuc2VkCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAuLmU4NTg1MmQKLS0tIC9kZXYvbnVsbAorKysgYi90ZXN0c3VpdGUvbmV3bGluZS5z ZWQKQEAgLTAsMCArMSwyIEBACitOCitzLzEyMzQ1Njc4OWFiY2Rcbi8vCi0tIAoxLjcuMQoK --------_5872F3F000000000D4EA_MULTIPART_MIXED_-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 09 01:12:11 2017 Received: (at 25390) by debbugs.gnu.org; 9 Jan 2017 06:12:11 +0000 Received: from localhost ([127.0.0.1]:47357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQTBj-0005ED-BL for submit@debbugs.gnu.org; Mon, 09 Jan 2017 01:12:11 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:33576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQTBh-0005E1-JP for 25390@debbugs.gnu.org; Mon, 09 Jan 2017 01:12:09 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E7EA1160075; Sun, 8 Jan 2017 22:12:03 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id aLW3TFvSQvo8; Sun, 8 Jan 2017 22:12:03 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 31D2D160090; Sun, 8 Jan 2017 22:12:03 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id anJZwIWoWVO6; Sun, 8 Jan 2017 22:12:03 -0800 (PST) Received: from [192.168.1.9] (unknown [47.153.178.162]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0B791160075; Sun, 8 Jan 2017 22:12:03 -0800 (PST) Subject: Re: bug#25390: Segfault with sed 4.3 To: Norihiro Tanaka References: <9B5E3836-1C2B-4CAD-91A2-CBB9319C1095@gmail.com> <216dfc52-a392-a85f-fa49-fdef9d020949@cs.ucla.edu> <20170109113813.D4F3.27F6AC2D@kcn.ne.jp> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: Date: Sun, 8 Jan 2017 22:12:02 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170109113813.D4F3.27F6AC2D@kcn.ne.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.2 (---) X-Debbugs-Envelope-To: 25390 Cc: 25390@debbugs.gnu.org, Assaf Gordon , Gnulib bugs , "S. Gilles" , GNU grep developers X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) Norihiro Tanaka wrote: > I wrote two additional patches for dfa. First, derive number of > allocation from not argument but number of state in transition table > allocation. Second, melt down dfastate() into build_state(). Now, I > think that there do not have to be separated. Thanks, I installed those two patches into Gnulib. > I also wrote a simple test, but the issue are not always caused, as it > depends on state of memory. Should we rely to complate the test on > valgrind? Yes, I expect the 'sed' folks would prefer the test to use valgrind. You = can=20 look at testsuite/invalid-mb-seq-UMR.sh for an example of a test that doe= s that. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 09 09:04:36 2017 Received: (at 25390) by debbugs.gnu.org; 9 Jan 2017 14:04:36 +0000 Received: from localhost ([127.0.0.1]:47451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQaYn-0002XJ-5A for submit@debbugs.gnu.org; Mon, 09 Jan 2017 09:04:35 -0500 Received: from mailgw06.kcn.ne.jp ([61.86.7.213]:60930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQaYb-0002Wj-PL for 25390@debbugs.gnu.org; Mon, 09 Jan 2017 09:04:27 -0500 Received: from mxs02-s (mailgw2.kcn.ne.jp [61.86.15.234]) by mailgw06.kcn.ne.jp (Postfix) with ESMTP id DE3FEC800F for <25390@debbugs.gnu.org>; Mon, 9 Jan 2017 23:04:10 +0900 (JST) X-matriXscan-loop-detect: b8ee03b93bb03ac9ebfdc649083d1d658da015e1 Received: from mail03.kcn.ne.jp ([61.86.6.182]) by mxs02-s with ESMTP; Mon, 09 Jan 2017 23:04:10 +0900 (JST) Received: from [10.120.1.61] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail03.kcn.ne.jp (Postfix) with ESMTPA id BBF27141009A; Mon, 9 Jan 2017 23:04:09 +0900 (JST) Date: Mon, 09 Jan 2017 23:04:05 +0900 From: Norihiro Tanaka To: Paul Eggert Subject: Re: bug#25390: Segfault with sed 4.3 In-Reply-To: References: <20170109113813.D4F3.27F6AC2D@kcn.ne.jp> Message-Id: <20170109230404.D4FB.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_587397E800000000D50E_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-matriXscan-Sophos-AV: Clean X-matriXscan-Action: Approve X-matriXscan: Uncategorized X-Spam-Score: -3.2 (---) X-Debbugs-Envelope-To: 25390 Cc: 25390@debbugs.gnu.org, Assaf Gordon , Gnulib bugs , "S. Gilles" , GNU grep developers X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) --------_587397E800000000D50E_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit On Sun, 8 Jan 2017 22:12:02 -0800 Paul Eggert wrote: > Norihiro Tanaka wrote: > > I wrote two additional patches for dfa. First, derive number of > > allocation from not argument but number of state in transition table > > allocation. Second, melt down dfastate() into build_state(). Now, I > > think that there do not have to be separated. > > Thanks, I installed those two patches into Gnulib. Thanks. > > I also wrote a simple test, but the issue are not always caused, as it > > depends on state of memory. Should we rely to complate the test on > > valgrind? > > Yes, I expect the 'sed' folks would prefer the test to use valgrind. You can look at testsuite/invalid-mb-seq-UMR.sh for an example of a test that does that. Thanks, I updated the test. The new test uses valgrind. --------_587397E800000000D50E_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-tests-new-test-for-dfa-crash-bug.patch" Content-Disposition: attachment; filename="0001-tests-new-test-for-dfa-crash-bug.patch" Content-Transfer-Encoding: base64 RnJvbSA2MjU0MWZkMGMzOWVkZTRiMzc5NjQxN2IzNGVkYzlkYTkzMzIxNTgyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBNb24sIDkgSmFuIDIwMTcgMDg6NTQ6MjggKzA5MDAKU3ViamVjdDogW1BBVENIXSB0ZXN0 czogbmV3IHRlc3QgZm9yIGRmYSBjcmFzaCBidWcKCk1heWJlIGRmYSBjcmFzaGVzIGlmIG11bHRp LWxpbmVzIGFyZSByZWFkIGluIHBhdHRlcm4gc3BhY2UuICBJdCBpcyBmaXhlZAphdCBjb21taXQg ODIzYjVjYjU4OTM2NmY3Yzg3NDI1MDNhZjk4MDgwM2FmYWQwOTc4ZiBpbiBnbnVsaWIuClJlcG9y dGVkIGJ5IFMuIEdpbGxlcyBpbiBodHRwczovL2J1Z3MuZ251Lm9yZy8yNTM5MAoKKiB0ZXN0c3Vp dGUvbmV3bGluZS5zaDogTmV3IHRlc3QuCiogdGVzdHN1aXRlL01ha2VmaWxlLnRlc3RzOiBBZGQg dGhlIHRlc3QuCiogdGVzdHN1aXRlL2xvY2FsLm1rOiBBZGQgdGhlIHRlc3QuCi0tLQogdGVzdHN1 aXRlL2xvY2FsLm1rICAgfCAgICAxICsKIHRlc3RzdWl0ZS9uZXdsaW5lLnNoIHwgICAzNyArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDM4IGlu c2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA3NTUgdGVzdHN1aXRl L25ld2xpbmUuc2gKCmRpZmYgLS1naXQgYS90ZXN0c3VpdGUvbG9jYWwubWsgYi90ZXN0c3VpdGUv bG9jYWwubWsKaW5kZXggZmFlNjIyNS4uMzI1ZTE4YiAxMDA2NDQKLS0tIGEvdGVzdHN1aXRlL2xv Y2FsLm1rCisrKyBiL3Rlc3RzdWl0ZS9sb2NhbC5tawpAQCAtMzgsNiArMzgsNyBAQCBUID0JCQkJ CVwKICAgdGVzdHN1aXRlL21iLWNoYXJjbGFzcy1ub24tdXRmOC5zaAlcCiAgIHRlc3RzdWl0ZS9t Yi1tYXRjaC1zbGFzaC5zaAkJXAogICB0ZXN0c3VpdGUvbWIteS10cmFuc2xhdGUuc2gJCVwKKyAg dGVzdHN1aXRlL25ld2xpbmUuc2gJCQlcCiAgIHRlc3RzdWl0ZS9ub3JtYWxpemUtdGV4dC5zaAkJ XAogICB0ZXN0c3VpdGUvbnVsbGRhdGEuc2gJCQlcCiAgIHRlc3RzdWl0ZS9wYW5pYy10ZXN0cy5z aAkJXApkaWZmIC0tZ2l0IGEvdGVzdHN1aXRlL25ld2xpbmUuc2ggYi90ZXN0c3VpdGUvbmV3bGlu ZS5zaApuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwLi4xNGQ5MTUwCi0tLSAvZGV2 L251bGwKKysrIGIvdGVzdHN1aXRlL25ld2xpbmUuc2gKQEAgLTAsMCArMSwzNyBAQAorIyEvYmlu L3NoCisjIHNlZCBtYXkgYWNjZXNzIHRvIHVuaW5pdGlhbGl6ZWQgbWVtb3J5IGlmIHRyYW5zaXQg dG8gMTV0aCBkZmEgc3RhdGUKKyMgd2l0aCBuZXdsaW5lLiAgVGhpcyBidWcgYWZmZWN0ZWQgc2Vk IHZlcnNpb24gNC4zLgorCisjIENvcHlyaWdodCAoQykgMjAxNyBGcmVlIFNvZnR3YXJlIEZvdW5k YXRpb24sIEluYy4KKworIyBUaGlzIHByb2dyYW0gaXMgZnJlZSBzb2Z0d2FyZTogeW91IGNhbiBy ZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQorIyBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhl IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQorIyB0aGUgRnJlZSBT b2Z0d2FyZSBGb3VuZGF0aW9uLCBlaXRoZXIgdmVyc2lvbiAzIG9mIHRoZSBMaWNlbnNlLCBvcgor IyAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgorCisjIFRoaXMgcHJvZ3JhbSBp cyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAorIyBidXQg V0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBv ZgorIyBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0Uu ICBTZWUgdGhlCisjIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMu CisKKyMgWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdlbmVyYWwg UHVibGljIExpY2Vuc2UKKyMgYWxvbmcgd2l0aCB0aGlzIHByb2dyYW0uICBJZiBub3QsIHNlZSA8 aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uCisuICIke3NyY2Rpcj0ufS90ZXN0c3VpdGUv aW5pdC5zaCI7IHBhdGhfcHJlcGVuZF8gLi9zZWQKK3ByaW50X3Zlcl8gc2VkCisKK3JlcXVpcmVf dmFsZ3JpbmRfCisKK3ByaW50ZiAnMDEyMzQ1Njc4OWFiY2RcbnhcbicgPiBpbiB8fCBmcmFtZXdv cmtfZmFpbHVyZV8KK3ByaW50ZiAneFxuJyA+IGV4cCB8fCBmcmFtZXdvcmtfZmFpbHVyZV8KK3Zh bGdyaW5kIC0tcXVpZXQgLS1lcnJvci1leGl0Y29kZT0xIFwKKyAgc2VkIC1uICdOO3MvMDEyMzQ1 Njc4OWFiY2Rcbi8vJyBpbiA+IG91dCAyPiBlcnIgfHwgZmFpbD0xCisKKyMgV29yayBhcm91bmQg YSBidWcgaW4gQ2VudE9TIDUuMTAncyB2YWxncmluZAorIyBGSVhNRTogcmVtb3ZlIGluIDIwMTgg b3Igd2hlbiBDZW50T1MgNSBpcyBubyBsb25nZXIgb2ZmaWNpYWxseSBzdXBwb3J0ZWQKK2dyZXAg J3ZhbGdyaW5kOiAuKkFzc2VydGlvbi4qZmFpbGVkJyBlcnIgPiAvZGV2L251bGwgXAorICAmJiBz a2lwXyAneW91IHNlZW0gdG8gaGF2ZSBhIGJ1Z2d5IHZlcnNpb24gb2YgdmFsZ3JpbmQnCisKK2Nv bXBhcmUgZXhwIG91dCB8fCBmYWlsPTEKK2NvbXBhcmUgL2Rldi9udWxsIGVyciB8fCBmYWlsPTEK KworRXhpdCAkZmFpbAotLSAKMS43LjEKCg== --------_587397E800000000D50E_MULTIPART_MIXED_-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 09 09:12:09 2017 Received: (at 25390) by debbugs.gnu.org; 9 Jan 2017 14:12:09 +0000 Received: from localhost ([127.0.0.1]:47465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQag5-0002kJ-TD for submit@debbugs.gnu.org; Mon, 09 Jan 2017 09:12:09 -0500 Received: from mailgw01.kcn.ne.jp ([61.86.7.208]:51676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQafw-0002jc-CT for 25390@debbugs.gnu.org; Mon, 09 Jan 2017 09:12:01 -0500 Received: from mxs02-s (mailgw2.kcn.ne.jp [61.86.15.234]) by mailgw01.kcn.ne.jp (Postfix) with ESMTP id 0F3C84A08C6 for <25390@debbugs.gnu.org>; Mon, 9 Jan 2017 23:11:45 +0900 (JST) X-matriXscan-loop-detect: baebd3024406297b5a40c981dd3d34274ba1629e Received: from mail07.kcn.ne.jp ([61.86.6.186]) by mxs02-s with ESMTP; Mon, 09 Jan 2017 23:11:43 +0900 (JST) Received: from [10.120.1.61] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail07.kcn.ne.jp (Postfix) with ESMTPA id 740A0D50099; Mon, 9 Jan 2017 23:11:42 +0900 (JST) Date: Mon, 09 Jan 2017 23:11:38 +0900 From: Norihiro Tanaka To: 25390@debbugs.gnu.org Subject: Re: bug#25390: Segfault with sed 4.3 In-Reply-To: <20170109230404.D4FB.27F6AC2D@kcn.ne.jp> References: <20170109230404.D4FB.27F6AC2D@kcn.ne.jp> Message-Id: <20170109231121.D4FF.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_5873999F00000000D516_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-matriXscan-Sophos-AV: Clean X-matriXscan-Action: Approve X-matriXscan: Uncategorized X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 25390 Cc: Assaf Gordon , Paul Eggert , Gnulib bugs , "S. Gilles" , GNU grep developers X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.5 (--) --------_5873999F00000000D516_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit On Mon, 09 Jan 2017 23:04:05 +0900 Norihiro Tanaka wrote: > Thanks, I updated the test. The new test uses valgrind. Sorry, I adjusted commit log, New patch does not change testsuite/Makefile.tests. --------_5873999F00000000D516_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="0001-tests-new-test-for-dfa-crash-bug.patch" Content-Disposition: attachment; filename="0001-tests-new-test-for-dfa-crash-bug.patch" Content-Transfer-Encoding: base64 RnJvbSA2N2ExN2Q5NDJiZWI5NDJhY2QyYjJlOTVlYmEyY2MzZDQzYTVlODgzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBNb24sIDkgSmFuIDIwMTcgMDg6NTQ6MjggKzA5MDAKU3ViamVjdDogW1BBVENIXSB0ZXN0 czogbmV3IHRlc3QgZm9yIGRmYSBjcmFzaCBidWcKCk1heWJlIGRmYSBjcmFzaGVzIGlmIG11bHRp LWxpbmVzIGFyZSByZWFkIGluIHBhdHRlcm4gc3BhY2UuICBJdCBpcyBmaXhlZAphdCBjb21taXQg ODIzYjVjYjU4OTM2NmY3Yzg3NDI1MDNhZjk4MDgwM2FmYWQwOTc4ZiBpbiBnbnVsaWIuClJlcG9y dGVkIGJ5IFMuIEdpbGxlcyBpbiBodHRwczovL2J1Z3MuZ251Lm9yZy8yNTM5MAoKKiB0ZXN0c3Vp dGUvbmV3bGluZS5zaDogTmV3IHRlc3QuCiogdGVzdHN1aXRlL2xvY2FsLm1rOiBBZGQgdGhlIHRl c3QuCi0tLQogdGVzdHN1aXRlL2xvY2FsLm1rICAgfCAgICAxICsKIHRlc3RzdWl0ZS9uZXdsaW5l LnNoIHwgICAzNyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAyIGZpbGVz IGNoYW5nZWQsIDM4IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAx MDA3NTUgdGVzdHN1aXRlL25ld2xpbmUuc2gKCmRpZmYgLS1naXQgYS90ZXN0c3VpdGUvbG9jYWwu bWsgYi90ZXN0c3VpdGUvbG9jYWwubWsKaW5kZXggZmFlNjIyNS4uMzI1ZTE4YiAxMDA2NDQKLS0t IGEvdGVzdHN1aXRlL2xvY2FsLm1rCisrKyBiL3Rlc3RzdWl0ZS9sb2NhbC5tawpAQCAtMzgsNiAr MzgsNyBAQCBUID0JCQkJCVwKICAgdGVzdHN1aXRlL21iLWNoYXJjbGFzcy1ub24tdXRmOC5zaAlc CiAgIHRlc3RzdWl0ZS9tYi1tYXRjaC1zbGFzaC5zaAkJXAogICB0ZXN0c3VpdGUvbWIteS10cmFu c2xhdGUuc2gJCVwKKyAgdGVzdHN1aXRlL25ld2xpbmUuc2gJCQlcCiAgIHRlc3RzdWl0ZS9ub3Jt YWxpemUtdGV4dC5zaAkJXAogICB0ZXN0c3VpdGUvbnVsbGRhdGEuc2gJCQlcCiAgIHRlc3RzdWl0 ZS9wYW5pYy10ZXN0cy5zaAkJXApkaWZmIC0tZ2l0IGEvdGVzdHN1aXRlL25ld2xpbmUuc2ggYi90 ZXN0c3VpdGUvbmV3bGluZS5zaApuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwLi4x NGQ5MTUwCi0tLSAvZGV2L251bGwKKysrIGIvdGVzdHN1aXRlL25ld2xpbmUuc2gKQEAgLTAsMCAr MSwzNyBAQAorIyEvYmluL3NoCisjIHNlZCBtYXkgYWNjZXNzIHRvIHVuaW5pdGlhbGl6ZWQgbWVt b3J5IGlmIHRyYW5zaXQgdG8gMTV0aCBkZmEgc3RhdGUKKyMgd2l0aCBuZXdsaW5lLiAgVGhpcyBi dWcgYWZmZWN0ZWQgc2VkIHZlcnNpb24gNC4zLgorCisjIENvcHlyaWdodCAoQykgMjAxNyBGcmVl IFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4KKworIyBUaGlzIHByb2dyYW0gaXMgZnJlZSBzb2Z0 d2FyZTogeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQorIyBpdCB1bmRlciB0 aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBi eQorIyB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBlaXRoZXIgdmVyc2lvbiAzIG9mIHRo ZSBMaWNlbnNlLCBvcgorIyAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgorCisj IFRoaXMgcHJvZ3JhbSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUg dXNlZnVsLAorIyBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1w bGllZCB3YXJyYW50eSBvZgorIyBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJU SUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlCisjIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZv ciBtb3JlIGRldGFpbHMuCisKKyMgWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0 aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UKKyMgYWxvbmcgd2l0aCB0aGlzIHByb2dyYW0u ICBJZiBub3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uCisuICIke3NyY2Rp cj0ufS90ZXN0c3VpdGUvaW5pdC5zaCI7IHBhdGhfcHJlcGVuZF8gLi9zZWQKK3ByaW50X3Zlcl8g c2VkCisKK3JlcXVpcmVfdmFsZ3JpbmRfCisKK3ByaW50ZiAnMDEyMzQ1Njc4OWFiY2Rcbnhcbicg PiBpbiB8fCBmcmFtZXdvcmtfZmFpbHVyZV8KK3ByaW50ZiAneFxuJyA+IGV4cCB8fCBmcmFtZXdv cmtfZmFpbHVyZV8KK3ZhbGdyaW5kIC0tcXVpZXQgLS1lcnJvci1leGl0Y29kZT0xIFwKKyAgc2Vk IC1uICdOO3MvMDEyMzQ1Njc4OWFiY2Rcbi8vJyBpbiA+IG91dCAyPiBlcnIgfHwgZmFpbD0xCisK KyMgV29yayBhcm91bmQgYSBidWcgaW4gQ2VudE9TIDUuMTAncyB2YWxncmluZAorIyBGSVhNRTog cmVtb3ZlIGluIDIwMTggb3Igd2hlbiBDZW50T1MgNSBpcyBubyBsb25nZXIgb2ZmaWNpYWxseSBz dXBwb3J0ZWQKK2dyZXAgJ3ZhbGdyaW5kOiAuKkFzc2VydGlvbi4qZmFpbGVkJyBlcnIgPiAvZGV2 L251bGwgXAorICAmJiBza2lwXyAneW91IHNlZW0gdG8gaGF2ZSBhIGJ1Z2d5IHZlcnNpb24gb2Yg dmFsZ3JpbmQnCisKK2NvbXBhcmUgZXhwIG91dCB8fCBmYWlsPTEKK2NvbXBhcmUgL2Rldi9udWxs IGVyciB8fCBmYWlsPTEKKworRXhpdCAkZmFpbAotLSAKMS43LjEKCg== --------_5873999F00000000D516_MULTIPART_MIXED_-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 10 00:27:19 2017 Received: (at 25390) by debbugs.gnu.org; 10 Jan 2017 05:27:19 +0000 Received: from localhost ([127.0.0.1]:48336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQoxr-0004Ln-5a for submit@debbugs.gnu.org; Tue, 10 Jan 2017 00:27:19 -0500 Received: from mail-qt0-f196.google.com ([209.85.216.196]:33904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQoxp-0004Lb-Kr for 25390@debbugs.gnu.org; Tue, 10 Jan 2017 00:27:18 -0500 Received: by mail-qt0-f196.google.com with SMTP id a29so16904747qtb.1 for <25390@debbugs.gnu.org>; Mon, 09 Jan 2017 21:27:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc:message-id:references :to; bh=RRZPioYglQwNvprdknrhoaJHqaQVVrRo4VEDHI70zQc=; b=T4TsDtpwBIPY/63K0E+nE0QjF3Sv+OX5AOVDNW7sTxcsEYO1vGUY3tZhZmlryzyudZ 582Jbp947W+P8iyZfbHzGMJLylXHIb3aeHlqh3nlklN7SGQaapbVpSvwVHVsjk116Coy e1cKeyXzhV4XUSNFM2C8ISa1OMpjsSyG0hUEOnLeGRv+IgLVZJjHgbOCHXCeCxl0Ljkz kaBAU8UzXcPYSom26kovsKa9ZT3NFZebhkIgnBkorNfuQrHKSjw6uI5ZhiHJIXlDyHw5 EJJEJbsaIdmud9fr2tH5y7HFmoGIiCoTAMIMtDFI6CsqsNZLT2yozSK0ZDttMh4efP5B AmcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=RRZPioYglQwNvprdknrhoaJHqaQVVrRo4VEDHI70zQc=; b=NTedUeiNn1D+jeL26zYEz0T6o0tpwGjz+pnwPdB7aBvVxgIBvn5Sq/mhAmlVPoeX84 GkULcvH/aVsQjqEpuxIRAGqVjr0eMNJK6K6vYYIJ3GchVzS15vrdCC0kyONPHldmXqr5 6MeajGEnmg+MMSljwbgevUDuSDBUtnZikSdktpihZzJqvW+XjB/jEidv/tclmBqQqWVe xaRSH3sDi+/y4gnYqJcW87nDr25z7FXzirNTLlKwvkBj96ZL4yES6J7+/gYjrM2i3rxJ N14IhJv4hw2DP2P5kwW5rFSfrpcN1KjZkLeT9OHLEI4zPJXM0uW+qEHlBSC4FCiCmjCc aDKg== X-Gm-Message-State: AIkVDXJ5e00PbBuyvbIZmkKJQEA99zlbM2kicLrn8dHmtq4863GfDou3j5JkpUCgsU5wcg== X-Received: by 10.237.35.179 with SMTP id j48mr1057554qtc.290.1484026032172; Mon, 09 Jan 2017 21:27:12 -0800 (PST) Received: from ix.home (pool-100-37-92-116.nycmny.fios.verizon.net. [100.37.92.116]) by smtp.gmail.com with ESMTPSA id t62sm635783qkh.26.2017.01.09.21.27.10 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 09 Jan 2017 21:27:11 -0800 (PST) Content-Type: multipart/mixed; boundary="Apple-Mail=_BF13DFA4-9955-4667-8100-70EE57C39E4B" Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Subject: Re: bug#25390: Segfault with sed 4.3 From: Assaf Gordon In-Reply-To: <20170109231121.D4FF.27F6AC2D@kcn.ne.jp> Date: Tue, 10 Jan 2017 00:27:09 -0500 Message-Id: <501BF1A2-6DF5-4F95-8D98-31BC24C35F68@gmail.com> References: <20170109230404.D4FB.27F6AC2D@kcn.ne.jp> <20170109231121.D4FF.27F6AC2D@kcn.ne.jp> To: Norihiro Tanaka X-Mailer: Apple Mail (2.2102) X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 25390 Cc: 25390@debbugs.gnu.org, Paul Eggert , Gnulib bugs , "S. Gilles" , GNU grep developers X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) --Apple-Mail=_BF13DFA4-9955-4667-8100-70EE57C39E4B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hello all, > On Jan 9, 2017, at 09:11, Norihiro Tanaka wrote: >=20 > Sorry, I adjusted commit log, New patch does not change > testsuite/Makefile.tests. > <0001-tests-new-test-for-dfa-crash-bug.patch> Paul, Thank you for the quick fix. Norihiro, Thank you for the dfa improvements and sed-tests. Using your example of: printf '0123456789abcd\nx\n' | valgrind ./sed/sed = 'N;s/0123456789abcd\n//' I wasn't able to trigger the segfault (or even a valgrind warning) on = sed-4.3 / x86_64. I suggest modifying the input just a bit, making it slightly more = similar to the original bug report - with it I'm able to always = reproduce the segfault: printf "abcdefg abcdefg\nB\n" | valgrind ./sed/sed = 'N;s/abcdefg.*\n//' What do you think ? I'm also considering duplicating the test - once with and once without = valgrind. Is this warranted or an overkill ? Attach patch contains updated tests (and slightly modified git-comment). The second commit updates gnulib (comes after adding the tests just = temporarily, to make testing before/after gnulib update easier). comments welcomed, - assaf --Apple-Mail=_BF13DFA4-9955-4667-8100-70EE57C39E4B Content-Disposition: attachment; filename=newline-bug.patch Content-Type: application/octet-stream; name="newline-bug.patch" Content-Transfer-Encoding: quoted-printable =46rom=20bb03809aa8eb577ce8e7747a9ea39d9e594a2c11=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Norihiro=20Tanaka=20=0A= Date:=20Mon,=209=20Jan=202017=2008:54:28=20+0900=0ASubject:=20[PATCH=20= 1/2]=20tests:=20new=20test=20for=20dfa=20crash=20bug=0A=0Ased-4.3=20= would=20segfault=20with:=0A=20=20=20printf=20'$LINENO=20$LINEN\nB\n'=20|=20= sed=20-e=20'N;s/\$LINENO\(.*\n\)/\1/'=0A=0ACulprit=20is=20dfa=20crash=20= if=20multi-lines=20are=20read=20in=20pattern=20space.=0AIt=20is=20fixed=20= at=20gnulib=20commit=20v0.1-1117-g823b5cb=20.=0AReported=20by=20S.=20= Gilles=20in=20https://bugs.gnu.org/25390=0A=0A*=20testsuite/newline.sh:=20= New=20test.=0A*=20testsuite/newline-valgrind.sh:=20Repeat=20above=20= test,=20with=20valgrind.=0A*=20testsuite/local.mk:=20Add=20the=20tests.=0A= ---=0A=20testsuite/local.mk=20=20=20=20=20=20=20=20=20=20=20=20|=20=202=20= ++=0A=20testsuite/newline-valgrind.sh=20|=2038=20= ++++++++++++++++++++++++++++++++++++++=0A=20testsuite/newline.sh=20=20=20= =20=20=20=20=20=20=20|=2028=20++++++++++++++++++++++++++++=0A=203=20= files=20changed,=2068=20insertions(+)=0A=20create=20mode=20100755=20= testsuite/newline-valgrind.sh=0A=20create=20mode=20100755=20= testsuite/newline.sh=0A=0Adiff=20--git=20a/testsuite/local.mk=20= b/testsuite/local.mk=0Aindex=20fae6225..2a5cd4d=20100644=0A---=20= a/testsuite/local.mk=0A+++=20b/testsuite/local.mk=0A@@=20-38,6=20+38,8=20= @@=20T=20=3D=09=09=09=09=09\=0A=20=20=20= testsuite/mb-charclass-non-utf8.sh=09\=0A=20=20=20= testsuite/mb-match-slash.sh=09=09\=0A=20=20=20= testsuite/mb-y-translate.sh=09=09\=0A+=20=20testsuite/newline.sh=09=09=09= \=0A+=20=20testsuite/newline-valgrind.sh=09=09\=0A=20=20=20= testsuite/normalize-text.sh=09=09\=0A=20=20=20testsuite/nulldata.sh=09=09= =09\=0A=20=20=20testsuite/panic-tests.sh=09=09\=0Adiff=20--git=20= a/testsuite/newline-valgrind.sh=20b/testsuite/newline-valgrind.sh=0Anew=20= file=20mode=20100755=0Aindex=200000000..91f1ed1=0A---=20/dev/null=0A+++=20= b/testsuite/newline-valgrind.sh=0A@@=20-0,0=20+1,38=20@@=0A+#!/bin/sh=0A= +#=20sed=20may=20access=20to=20uninitialized=20memory=20if=20transit=20= to=2015th=20dfa=20state=0A+#=20with=20newline.=20=20This=20bug=20= affected=20sed=20version=204.3.=0A+=0A+#=20Copyright=20(C)=202017=20Free=20= Software=20Foundation,=20Inc.=0A+=0A+#=20This=20program=20is=20free=20= software:=20you=20can=20redistribute=20it=20and/or=20modify=0A+#=20it=20= under=20the=20terms=20of=20the=20GNU=20General=20Public=20License=20as=20= published=20by=0A+#=20the=20Free=20Software=20Foundation,=20either=20= version=203=20of=20the=20License,=20or=0A+#=20(at=20your=20option)=20any=20= later=20version.=0A+=0A+#=20This=20program=20is=20distributed=20in=20the=20= hope=20that=20it=20will=20be=20useful,=0A+#=20but=20WITHOUT=20ANY=20= WARRANTY;=20without=20even=20the=20implied=20warranty=20of=0A+#=20= MERCHANTABILITY=20or=20FITNESS=20FOR=20A=20PARTICULAR=20PURPOSE.=20=20= See=20the=0A+#=20GNU=20General=20Public=20License=20for=20more=20= details.=0A+=0A+#=20You=20should=20have=20received=20a=20copy=20of=20the=20= GNU=20General=20Public=20License=0A+#=20along=20with=20this=20program.=20= =20If=20not,=20see=20.=0A+.=20= "${srcdir=3D.}/testsuite/init.sh";=20path_prepend_=20./sed=0A+print_ver_=20= sed=0A+=0A+require_valgrind_=0A+=0A+printf=20'abcdefg=20abcdefg\nB\n'=20= >=20in=20||=20framework_failure_=0A+printf=20'B\n'=20>=20exp=20||=20= framework_failure_=0A+=0A+valgrind=20--quiet=20--error-exitcode=3D1=20\=0A= +=20=20sed=20'N;s/abcdefg.*\n//'=20in=20>=20out=202>=20err=20||=20fail=3D1= =0A+=0A+#=20Work=20around=20a=20bug=20in=20CentOS=205.10's=20valgrind=0A= +#=20FIXME:=20remove=20in=202018=20or=20when=20CentOS=205=20is=20no=20= longer=20officially=20supported=0A+grep=20'valgrind:=20= .*Assertion.*failed'=20err=20>=20/dev/null=20\=0A+=20=20&&=20skip_=20= 'you=20seem=20to=20have=20a=20buggy=20version=20of=20valgrind'=0A+=0A= +compare=20exp=20out=20||=20fail=3D1=0A+compare=20/dev/null=20err=20||=20= fail=3D1=0A+=0A+Exit=20$fail=0Adiff=20--git=20a/testsuite/newline.sh=20= b/testsuite/newline.sh=0Anew=20file=20mode=20100755=0Aindex=20= 0000000..72bb2ec=0A---=20/dev/null=0A+++=20b/testsuite/newline.sh=0A@@=20= -0,0=20+1,28=20@@=0A+#!/bin/sh=0A+#=20sed=20may=20access=20to=20= uninitialized=20memory=20if=20transit=20to=2015th=20dfa=20state=0A+#=20= with=20newline.=20=20This=20bug=20affected=20sed=20version=204.3.=0A+=0A= +#=20Copyright=20(C)=202017=20Free=20Software=20Foundation,=20Inc.=0A+=0A= +#=20This=20program=20is=20free=20software:=20you=20can=20redistribute=20= it=20and/or=20modify=0A+#=20it=20under=20the=20terms=20of=20the=20GNU=20= General=20Public=20License=20as=20published=20by=0A+#=20the=20Free=20= Software=20Foundation,=20either=20version=203=20of=20the=20License,=20or=0A= +#=20(at=20your=20option)=20any=20later=20version.=0A+=0A+#=20This=20= program=20is=20distributed=20in=20the=20hope=20that=20it=20will=20be=20= useful,=0A+#=20but=20WITHOUT=20ANY=20WARRANTY;=20without=20even=20the=20= implied=20warranty=20of=0A+#=20MERCHANTABILITY=20or=20FITNESS=20FOR=20A=20= PARTICULAR=20PURPOSE.=20=20See=20the=0A+#=20GNU=20General=20Public=20= License=20for=20more=20details.=0A+=0A+#=20You=20should=20have=20= received=20a=20copy=20of=20the=20GNU=20General=20Public=20License=0A+#=20= along=20with=20this=20program.=20=20If=20not,=20see=20= .=0A+.=20"${srcdir=3D.}/testsuite/init.sh";=20= path_prepend_=20./sed=0A+print_ver_=20sed=0A+=0A+printf=20'abcdefg=20= abcdefg\nB\n'=20>=20in=20||=20framework_failure_=0A+printf=20'B\n'=20>=20= exp=20||=20framework_failure_=0A+sed=20'N;s/abcdefg.*\n//'=20in=20>=20= out=20||=20fail=3D1=0A+=0A+compare=20exp=20out=20||=20fail=3D1=0A+=0A= +Exit=20$fail=0A--=20=0A2.10.2=0A=0A=0A=46rom=20= 5f611a1b8a980acce339305dc978a2cdd9dd2909=20Mon=20Sep=2017=2000:00:00=20= 2001=0AFrom:=20Assaf=20Gordon=20=0ADate:=20Tue,=20= 10=20Jan=202017=2000:09:54=20-0500=0ASubject:=20[PATCH=202/2]=20gnulib:=20= update=20to=20latest=20(with=20DFA=20fixes=20for=20bug#25390)=0A=0A---=0A= =20gnulib=20|=202=20+-=0A=201=20file=20changed,=201=20insertion(+),=201=20= deletion(-)=0A=0Adiff=20--git=20a/gnulib=20b/gnulib=0Aindex=20= a3fd683..8d3c493=20160000=0A---=20a/gnulib=0A+++=20b/gnulib=0A@@=20-1=20= +1=20@@=0A-Subproject=20commit=20= a3fd683de3decbb58ab5fb5d32ad2e62f74fbf12=0A+Subproject=20commit=20= 8d3c4933ccfae50a15bcb088161bfd33adcdbf6d=0A--=20=0A2.10.2=0A=0A= --Apple-Mail=_BF13DFA4-9955-4667-8100-70EE57C39E4B Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii --Apple-Mail=_BF13DFA4-9955-4667-8100-70EE57C39E4B-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 10 04:11:51 2017 Received: (at 25390) by debbugs.gnu.org; 10 Jan 2017 09:11:51 +0000 Received: from localhost ([127.0.0.1]:48388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQsT8-0001V3-Q5 for submit@debbugs.gnu.org; Tue, 10 Jan 2017 04:11:50 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:52208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQsT5-0001Uo-N9 for 25390@debbugs.gnu.org; Tue, 10 Jan 2017 04:11:49 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D00071600F3; Tue, 10 Jan 2017 01:11:41 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Ui3_csL_JknC; Tue, 10 Jan 2017 01:11:41 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 027FA160101; Tue, 10 Jan 2017 01:11:40 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id UcmQmNQa6pdR; Tue, 10 Jan 2017 01:11:40 -0800 (PST) Received: from [192.168.1.9] (unknown [47.153.178.162]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id B06B41600F3; Tue, 10 Jan 2017 01:11:40 -0800 (PST) Subject: Re: bug#25390: Segfault with sed 4.3 To: Assaf Gordon , Norihiro Tanaka References: <20170109230404.D4FB.27F6AC2D@kcn.ne.jp> <20170109231121.D4FF.27F6AC2D@kcn.ne.jp> <501BF1A2-6DF5-4F95-8D98-31BC24C35F68@gmail.com> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <11c84739-ffc4-fcc3-9c40-5e8a66a43965@cs.ucla.edu> Date: Tue, 10 Jan 2017 01:11:36 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <501BF1A2-6DF5-4F95-8D98-31BC24C35F68@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.2 (---) X-Debbugs-Envelope-To: 25390 Cc: 25390@debbugs.gnu.org, Gnulib bugs , "S. Gilles" , GNU grep developers X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) Assaf Gordon wrote: > I'm also considering duplicating the test - once with and once without valgrind. > Is this warranted or an overkill ? Sounds like overkill to me. If it works with valgrind, it'll work without. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 14 18:41:02 2017 Received: (at 25390) by debbugs.gnu.org; 14 Jan 2017 23:41:02 +0000 Received: from localhost ([127.0.0.1]:54250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cSXwT-0001oW-NY for submit@debbugs.gnu.org; Sat, 14 Jan 2017 18:41:01 -0500 Received: from mail-it0-f66.google.com ([209.85.214.66]:35116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cSXwQ-0001oH-2T for 25390@debbugs.gnu.org; Sat, 14 Jan 2017 18:40:59 -0500 Received: by mail-it0-f66.google.com with SMTP id 203so8819167ith.2 for <25390@debbugs.gnu.org>; Sat, 14 Jan 2017 15:40:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=NNlpSS4ApQ5sNIDRp/0Cwb5QNbtNsOz2JYU1Yaq50F8=; b=GsC6e5SA330m+BKTMYHNhRtZnUywvEiXjGXV5FNXvpM/rhOJeigUzXQHHKbtZNzW3t gqC89m7pTOtGHSpvd+usUdl5UBlpgSHJoPGBPEND5JVdU3N5w7Quo/5rs2g63hTqxEAA Gn2qYyQGJ/5ugkqtwqTbbmbCBD1ldFCNfbpUM+au54sAvDltkDyUJsm8ZvkPGU1ADxpt HiB+dXlCBSbNHdxZvEbfrh48uBDlAzZUqqnDW2YdamNwUi3dptn238j6/2W5H+FdxB9M zesI9IdDFo9ToKVGeHBZ9PPflpXMyV/wmVO1hddhR3gLuMJHnJQ3APr+d8WeFPNKZzx/ 0zbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=NNlpSS4ApQ5sNIDRp/0Cwb5QNbtNsOz2JYU1Yaq50F8=; b=RIIa9Dlsu81fbpuUAPvxeeGkw5K0zvUrjdUrGGng7L1BqVcDYSqD0JVnYfWBgJGVox dfhPDIeYXXNdxCXnfB+HlHSyOYC7aCLM0G+HSZy6JWXMRrbKK7IVhAMJfYlfXkrZpigw ep0UyE/OcYGKUBLMrBi6Lhtvd68TznkXQzD5ogBUh3OK214EIvO3zuEFlKSgQS6e99eh r9KGiDdIA7SemrJM1EJr8YSScr2NZyXIU9AB31oKoGlo1f7fYmRVK/hd64JJT5ePdZFp omq8kNfIov76wO1jmP4230ruIJCSpKPnZTOUZj/8Q7pgBEd+HpmcFY+FH7XCUuaCYbG1 U9Bg== X-Gm-Message-State: AIkVDXKdBAPm6fKVCBzkujx0vqzf2/EGc9SLfPh834tsZuZLT9je/2mv4/gky7JyUv5649LqMTgbYMCsvewXKA== X-Received: by 10.36.39.136 with SMTP id g130mr9480611ita.55.1484437252344; Sat, 14 Jan 2017 15:40:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.191.5 with HTTP; Sat, 14 Jan 2017 15:40:31 -0800 (PST) In-Reply-To: <501BF1A2-6DF5-4F95-8D98-31BC24C35F68@gmail.com> References: <20170109230404.D4FB.27F6AC2D@kcn.ne.jp> <20170109231121.D4FF.27F6AC2D@kcn.ne.jp> <501BF1A2-6DF5-4F95-8D98-31BC24C35F68@gmail.com> From: Jim Meyering Date: Sat, 14 Jan 2017 15:40:31 -0800 X-Google-Sender-Auth: uLJSCKPpyUL_qlYjhYR9Bx25if4 Message-ID: Subject: Re: [Grep-devel] bug#25390: Segfault with sed 4.3 To: Assaf Gordon Content-Type: multipart/mixed; boundary=001a1147c8b61e36c30546167bdb X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25390 Cc: 25390@debbugs.gnu.org, GNU grep developers , Gnulib bugs , Norihiro Tanaka , "S. Gilles" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --001a1147c8b61e36c30546167bdb Content-Type: text/plain; charset=UTF-8 On Mon, Jan 9, 2017 at 9:27 PM, Assaf Gordon wrote: > Hello all, > >> On Jan 9, 2017, at 09:11, Norihiro Tanaka wrote: >> >> Sorry, I adjusted commit log, New patch does not change >> testsuite/Makefile.tests. >> <0001-tests-new-test-for-dfa-crash-bug.patch> > > > Paul, > Thank you for the quick fix. > > Norihiro, > Thank you for the dfa improvements and sed-tests. > > Using your example of: > printf '0123456789abcd\nx\n' | valgrind ./sed/sed 'N;s/0123456789abcd\n//' > I wasn't able to trigger the segfault (or even a valgrind warning) on sed-4.3 / x86_64. > > I suggest modifying the input just a bit, making it slightly more similar to the original bug report - with it I'm able to always reproduce the segfault: > printf "abcdefg abcdefg\nB\n" | valgrind ./sed/sed 'N;s/abcdefg.*\n//' > > What do you think ? > > I'm also considering duplicating the test - once with and once without valgrind. > Is this warranted or an overkill ? > > Attach patch contains updated tests (and slightly modified git-comment). > The second commit updates gnulib (comes after adding the tests just temporarily, to make testing before/after gnulib update easier). Hi Assaf, Thank you for adjusting the tests and commit log. Those look fine. The only problem is that the new newline-valgrind.sh test would fail when run against an ASAN-enabled sed. That is because valgrind just doesn't work when the binary is ASAN-enabled. So I have extemded init.cfg's require_valgrind_ function so that it also detects this case and skips the test. I will push the attached shortly, after which you are welcome to push your commits. --001a1147c8b61e36c30546167bdb Content-Type: text/plain; charset=US-ASCII; name="sed-ASAN-vs-valgrind.diff" Content-Disposition: attachment; filename="sed-ASAN-vs-valgrind.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ixxvkibs1 RnJvbSAxZDdlZTJkNTUzMjkxOGM5NTNhMzM5ZWMxMWYwNjI0YTFiZWIyNjA0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog U2F0LCAxNCBKYW4gMjAxNyAxNTozMjo0MSAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIHRlc3RzOiBz a2lwIHZhbGdyaW5kLXJ1bm5pbmcgdGVzdHMgd2hlbiBBU0FOLWVuYWJsZWQKCiogaW5pdC5jZmcg KHJlcXVpcmVfdmFsZ3JpbmRfKTogU2tpcCB3aGVuIHdlIGRldGVjdCB0aGF0IHRoZQpiaW5hcnkg aXMgQVNBTi1lbmFibGVkLgotLS0KIGluaXQuY2ZnIHwgNyArKysrKysrCiAxIGZpbGUgY2hhbmdl ZCwgNyBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvaW5pdC5jZmcgYi9pbml0LmNmZwppbmRl eCAyNWM2OGQ2Li45MTVhMjYwIDEwMDY0NAotLS0gYS9pbml0LmNmZworKysgYi9pbml0LmNmZwpA QCAtMjMsMTAgKzIzLDE3IEBAIHN0ZGVycl9maWxlbm9fPTkKICMgd2hpY2ggY291bGQgaGFwcGVu IGlmIG5vdCBpbnN0YWxsZWQsCiAjIG9yIGhhc24ndCBzdXBwb3J0IGZvciB0aGUgYnVpbHQgYXJj aGl0ZWN0dXJlLAogIyBvciBoYXNuJ3QgYXBwcm9wcmlhdGUgZXJyb3Igc3VwcHJlc3Npb25zIGlu c3RhbGxlZCBldGMuCisjIG9yIHRoZSBwcm9ncmFtIHVuZGVyIHRlc3Qgd2FzIGNvbXBpbGVkIHdp dGggYWRkcmVzcyBzYW5pdGl6ZXIuCiByZXF1aXJlX3ZhbGdyaW5kXygpCiB7CiAgIHZhbGdyaW5k IC0tZXJyb3ItZXhpdGNvZGU9MSB0cnVlIDI+L2Rldi9udWxsIHx8CiAgICAgc2tpcF8gInJlcXVp cmVzIGEgd29ya2luZyB2YWxncmluZCIKKworICAjIFdlIGNhbm5vdCBhcHBseSB2YWxncmluZCB0 byBhbiBBU0FOLWVuYWJsZWQgZXhlY3V0YWJsZS4KKyAgIyBBbiBBU0FOLWVuYWJsZWQgYmluYXJ5 IHdpbGwgcHJpbnQgdGhpcyBvbiB0aGUgZmlyc3QgbGluZSBvZgorICAjIGl0cyBoZWxwIG91dHB1 dDogQXZhaWxhYmxlIGZsYWdzIGZvciBBZGRyZXNzU2FuaXRpemVyOgorICBBU0FOX09QVElPTlM9 aGVscD0xIHNlZCBxcSAyPiYxIHwgZ3JlcCBBZGRyZXNzU2FuaXRpemVyOiBcCisgICAgJiYgc2tp cF8gJ0FTQU4gZW5hYmxlZCBiaW5hcnkgY2Fubm90IHdvcmsgd2l0aCB2YWxncmluZCcKIH0KCiAj IENhbGwgdGhpcyB3aXRoIGEgbGlzdCBvZiBwcm9ncmFtcyB1bmRlciB0ZXN0IGltbWVkaWF0ZWx5 IGFmdGVyCi0tIAoyLjkuMwoK --001a1147c8b61e36c30546167bdb-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 16 23:53:18 2017 Received: (at 25390) by debbugs.gnu.org; 17 Jan 2017 04:53:18 +0000 Received: from localhost ([127.0.0.1]:56066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cTLlm-0008Qn-7i for submit@debbugs.gnu.org; Mon, 16 Jan 2017 23:53:18 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:32958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cTLlk-0008QZ-SQ for 25390@debbugs.gnu.org; Mon, 16 Jan 2017 23:53:17 -0500 Received: by mail-qt0-f193.google.com with SMTP id n13so18914197qtc.0 for <25390@debbugs.gnu.org>; Mon, 16 Jan 2017 20:53:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=8238Ccz5eIVv8Er9mMigMsHCTXiXuI11Pi/0TE0mfE8=; b=p7lt9D2PPnP+yZwMB64ceu/N89m6ltUKNS3UYR2JHDwF/XjSVCPvAZzE39QQWoOhqt 3QgjCm6ZhokPxpeLI99fzbVHXiy0gXxP4p8FKFEOsXdETriHfqof96VMiX26BVAsb5Vn WIK8cH9F+kpmfAISQiswbQaNpxGq7jplhu0RnCwcEj0JrF1seK9Ise1K+oSnj5SBc/mI ygpy9yEcjgkX6YwVE++x+m5YmTsfaeGqIDtMjraKfeDhye2ThZoEza7uCHAgVKLyuvjd tJ4DoV/iQnHz9Ki+31qjZkeH00CfHeWhw6kEI0B7ogbInaHw2j3+6hS0/pOW45xBbEXX S2yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=8238Ccz5eIVv8Er9mMigMsHCTXiXuI11Pi/0TE0mfE8=; b=nyAtkH5MnznE6t71cbxjMD4Jw93w4hAjmTv3xYqqt8598cG2a744DOEmTJWWVocBRq NTcdPy4kW42WmK9VVaLIcuGMyKuJdxrmpwa9Q0I5pD2NtQv0kHVOA3aUozkaj02/bMNz UPDqfT4umiu8DWKk8wYrLeap0B+QKU/1OvAwSqc8AG++CSc0rDCyBW6dH8bPoO4FYGKR TYRnkktDaXyOZ73Ungry+s3VRMfj3gJmKT1jHvNkq7OiC7Ftp0mbvBPw4zroLYppDswY 0roBNMPHxAVseeVV8LeOaTiu+xhMmtMOIH2RoMNZT86tJhNK46p67pBO7jX26HzWe4VD Y5uw== X-Gm-Message-State: AIkVDXJh939Zny0piOIXFtaisA3FiUa2xOu2L/Cfk5sbBEy2Z11gwwvZqCBzy5hn/ZumBQ== X-Received: by 10.233.235.66 with SMTP id b63mr36625005qkg.144.1484628791136; Mon, 16 Jan 2017 20:53:11 -0800 (PST) Received: from ix.home (pool-100-37-92-116.nycmny.fios.verizon.net. [100.37.92.116]) by smtp.gmail.com with ESMTPSA id m85sm17931548qkl.28.2017.01.16.20.53.09 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 16 Jan 2017 20:53:10 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Subject: Re: bug#25390: Segfault with sed 4.3 From: Assaf Gordon In-Reply-To: Date: Mon, 16 Jan 2017 23:53:08 -0500 Content-Transfer-Encoding: quoted-printable Message-Id: <39FA153D-DC4E-489B-88F8-EC0035986670@gmail.com> References: <20170109230404.D4FB.27F6AC2D@kcn.ne.jp> <20170109231121.D4FF.27F6AC2D@kcn.ne.jp> <501BF1A2-6DF5-4F95-8D98-31BC24C35F68@gmail.com> To: "S. Gilles" X-Mailer: Apple Mail (2.2102) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25390 Cc: 25390@debbugs.gnu.org, GNU grep developers , Gnulib bugs , Norihiro Tanaka , Jim Meyering X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) tag 25390 fixed close 25390 thanks Hello, Thanks again for everyone who reported, fixed and improved sed and = dfa/gnulib. sed's update to latest gnulib is pushed here: = http://git.savannah.gnu.org/cgit/sed.git/commit/?id=3D44d99bf5c98ea77de0ad= df55ad7fe281396de996 followed by the new test: = http://git.savannah.gnu.org/cgit/sed.git/commit/?id=3D0f98f0055e4b505de269= 6bf862798e88a14956f9 I'm thus closing this bug, but discussion can continue by replying to this thread. regards, - assaf =20= From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 24 18:32:30 2017 Received: (at control) by debbugs.gnu.org; 24 Jan 2017 23:32:30 +0000 Received: from localhost ([127.0.0.1]:41080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWAZi-0000uw-62 for submit@debbugs.gnu.org; Tue, 24 Jan 2017 18:32:30 -0500 Received: from mail-qk0-f171.google.com ([209.85.220.171]:36196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWAZh-0000ui-3w for control@debbugs.gnu.org; Tue, 24 Jan 2017 18:32:29 -0500 Received: by mail-qk0-f171.google.com with SMTP id 11so58584990qkl.3 for ; Tue, 24 Jan 2017 15:32:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:message-id:mime-version:content-disposition:user-agent; bh=tGpForb//DT1LalNRZNmuPB1BkHswkrXciNwHlizIlI=; b=Ak8rqMoM7uKC3XNbEehocb9fBoJje9C03tGws8usfD1A4SAKW48c8gGY5Uc0Qbxo2v 6RTW6Qmpqpv8fQVu5rJzJQgJZARqhqyEOZv+88Piwu7UIKwIGvqVeNiUfAxA175dEP01 WK0tQv94wtRqCqezjo9gIO7xDTeCHhh0hxKfoXfR3O941pl2fT88CbuynPL4/wCmNcCV JOVGMCaNMKMA6em5m2RBZsdNzAGd9EV65Bxrhn0/X+pt0QWdsEOBVCrnYXcHAuFBARfl mpT3c9MNvwLbw7+77WNMxxv51djCBwTUGWoL7AOXaCneTGipbyeiCnpxb0k00OSFmIEO /mdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:message-id:mime-version :content-disposition:user-agent; bh=tGpForb//DT1LalNRZNmuPB1BkHswkrXciNwHlizIlI=; b=e0FTMjf5UddyCmuXqswO5EgYSORupSDA/kpZ0BiR61RqMN1JS/RwWBo+KzxKTNaVaD NPQJdD1NNPORDU+DzxjLJOag2uxSSes5NSojY+OUCnnBXwQ2iayVJH482NeFQ1+pYmTc +7GJb7mcsvlKq0hlBMFy6+Art8mLlbibbPB9gnBC1WK0YEI8hPdDQ53PJ+OUxJiQ+3Wh phQBKb+uDg9nRPqFSHNJBJyIesHqQIuv4AG9qYzPzbGFz2qf7xRk97+jt3X046bnTPXr SwZMTVYDnBPuHcNyL6QAszWuc8iyVGvsWVJJZiGJL70zAIdWndTOa/JZKHsqIrRHTi/x N8ng== X-Gm-Message-State: AIkVDXLX8Lt0cybcYamonPqh5Ee+ObGoYdotBm+M5mTTu4YR0yJAwFEsONL8zsXAJxAk7Q== X-Received: by 10.55.148.71 with SMTP id w68mr26274630qkd.130.1485300743495; Tue, 24 Jan 2017 15:32:23 -0800 (PST) Received: from gmail.com (housegordon.org. [104.236.108.240]) by smtp.gmail.com with ESMTPSA id h33sm16008837qtc.42.2017.01.24.15.32.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Jan 2017 15:32:23 -0800 (PST) Date: Tue, 24 Jan 2017 23:31:52 +0000 From: Assaf Gordon To: control@debbugs.gnu.org Message-ID: <20170124233152.GB9668@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.8 (/) tags 20572 notabug close 20572 tags 20684 notabug close 20684 tags 20786 fixed close 20786 tags 22943 notabug close 22943 tags 23415 notabug close 23415 tags 23493 notabug close 23493 tag 23832 notabug close 23832 tag 23848 fixed close 23848 tag 24072 notabug close 24072 tag 25358 fixed close 25358 tag 25371 fixed close 25371 tag 25377 fixed close 25377 tag 25390 fixed close 25390 stop From unknown Fri Jun 20 20:11:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 22 Feb 2017 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator