GNU bug report logs - #25381
sed 4.3: Test suite partially fails to compile when configured with --with-included-regex.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25381 in the body.
You can then email your comments to 25381 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juan Manuel Guerrero <juan.guerrero <at> gmx.de>
To: bug-sed <at> gnu.org
Subject: sed 4.3: Test suite partially fails to compile when configured with
 --with-included-regex.
Date: Sat, 07 Jan 2017 06:29:25 +0100

This is another issue I noted when trying to port sed to FreeDOS using DJGPP
but it may be interesting for other OS too and can be reproduced with linux.
If I configure with the --with-included-regex option at least no one of the
bug-regex*.c files are linked with with libsed.a.  An inspection of the
makefile shows that entries like: testsuite_bug_regex*_DEPENDENCIES are
missing.  This is not he case for get-mb-cur-max.c and test-mbrtowc.c.
There may be more .c files where these specific dependecies are missing.
I have not inevstigated further.  The compilation of the required binaries
fail with the following error message:

depbase=`echo testsuite/bug-regex7.o | sed 's|[^/]*$|.deps/&|;s|\.[^.]*$||'` && \
gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..  -I.. -I../lib -I./lib -I./sed   -g -O2 -MT testsuite/bug-regex7.o -MD -MP -MF $depbase.Tpo -c -o testsuite/bug-regex7.o  ../testsuite/bug-regex7.c; \
if test $? = 0; then mv -f $depbase.Tpo $depbase.Po; \
  else rm -f $depbase.Tpo; false; fi
gcc -std=gnu99  -g -O2   -o testsuite/bug-regex7 testsuite/bug-regex7.o
testsuite/bug-regex7.o: In function `main':
/home/jmg/_shared_folder_/portieren/sed-4.3/_/../testsuite/bug-regex7.c:43: undefined reference to `rpl_re_compile_pattern'
/home/jmg/_shared_folder_/portieren/sed-4.3/_/../testsuite/bug-regex7.c:68: undefined reference to `rpl_re_compile_pattern'
/home/jmg/_shared_folder_/portieren/sed-4.3/_/../testsuite/bug-regex7.c:51: undefined reference to `rpl_re_search'
/home/jmg/_shared_folder_/portieren/sed-4.3/_/../testsuite/bug-regex7.c:76: undefined reference to `rpl_re_match'
collect2: ld returned 1 exit status
make[3]: *** [testsuite/bug-regex7] Error 1
make[3]: Leaving directory `/home/jmg/_shared_folder_/portieren/sed-4.3/_'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/home/jmg/_shared_folder_/portieren/sed-4.3/_'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/home/jmg/_shared_folder_/portieren/sed-4.3/_'
make: *** [check] Fehler 2


Regards,
Juan M. Guerrero

Message #8 received at 25381 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Juan Manuel Guerrero <juan.guerrero <at> gmx.de>
Cc: 25381 <at> debbugs.gnu.org
Subject: Re: bug#25381: sed 4.3: Test suite partially fails to compile when
 configured with --with-included-regex.
Date: Sat, 7 Jan 2017 01:32:53 -0500

[Message part 1 (text/plain, inline)]

Hello,

Thanks for the report!

> On Jan 7, 2017, at 00:29, Juan Manuel Guerrero <juan.guerrero <at> gmx.de> wrote:
> 
> If I configure with the --with-included-regex option at least no one of the
> bug-regex*.c files are linked with with libsed.a. 

Interesting scenario, as I must admit I haven't noticed these tests being used before by anyone or on any system...

Not only the haven't been built correctly, but they wouldn't pass even after being built due to changes in the makefile (switch to non-recursive makefiles).

The attach patch fixes both issues.
However, one test fails.

Not sure if it is relevant or should we disable the test all together.

Will investigate further soon.


regards,
 - assaf

[0001-maint-fix-broken-bug-regex-tests.patch (application/octet-stream, attachment)]

[test-suite.log (application/octet-stream, attachment)]

[Message part 4 (text/plain, inline)]

Message #13 received at 25381-done <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Juan Manuel Guerrero <juan.guerrero <at> gmx.de>
Cc: 25381-done <at> debbugs.gnu.org
Subject: Re: bug#25381: sed 4.3: Test suite partially fails to compile when
 configured with --with-included-regex.
Date: Sat, 28 Oct 2017 21:31:37 -0600

Hello,

These problematic regex tests were recently removed from sed:
https://git.savannah.gnu.org/cgit/sed.git/commit/?id=97478b089

I'm therefore closing this bug.

regards,
 - assaf

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.