From unknown Sun Jun 22 11:33:26 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#25358 <25358@debbugs.gnu.org> To: bug#25358 <25358@debbugs.gnu.org> Subject: Status: Cross Compiling fails because of help2man Reply-To: bug#25358 <25358@debbugs.gnu.org> Date: Sun, 22 Jun 2025 18:33:26 +0000 retitle 25358 Cross Compiling fails because of help2man reassign 25358 sed submitter 25358 Vishal Biswas severity 25358 normal tag 25358 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 04 13:09:38 2017 Received: (at submit) by debbugs.gnu.org; 4 Jan 2017 18:09:38 +0000 Received: from localhost ([127.0.0.1]:41404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOq0H-0004PG-Jt for submit@debbugs.gnu.org; Wed, 04 Jan 2017 13:09:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOok5-0002Rm-Om for submit@debbugs.gnu.org; Wed, 04 Jan 2017 11:48:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOojz-000368-Gg for submit@debbugs.gnu.org; Wed, 04 Jan 2017 11:48:44 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54884) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cOojz-000363-Di for submit@debbugs.gnu.org; Wed, 04 Jan 2017 11:48:43 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOojy-0004PY-8I for bug-sed@gnu.org; Wed, 04 Jan 2017 11:48:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOojt-000331-CA for bug-sed@gnu.org; Wed, 04 Jan 2017 11:48:42 -0500 Received: from nm49-vm10.bullet.mail.bf1.yahoo.com ([216.109.114.251]:34118) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1cOojt-00032b-5A for bug-sed@gnu.org; Wed, 04 Jan 2017 11:48:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ymail.com; s=s2048; t=1483548515; bh=+1cCSpwub0m0s1Bkr80zLFJuAL/kPs6nI3Td1nAKEFA=; h=From:To:Subject:Date:From:Subject; b=la5te2FIErPVK3XlAdB6sTdbFCf1h12jcYQNYS9qqUBcuYvjN1i8m/3FZ5Ybl79kZcOp1KNCnT1TbwZW4Tnqlk1mF4CxLPzXBd3ljzqyYFWAnOqk5xF4B3kAdJIBXdY3xxX8r9+AWCf8tmUW+CT6OJeGwUTBKawzbL2DVwvCid3tVtLSSsGBZVje2PJ2lNCcSydb2IKrrfAD/bD0WGj1XxnoYuTNy0sOSqUzZfoIJDT9s/HdNBukUaGSqgQxfYxCwqnp/Sp0gIM2DehSmXKjQcaNug1xE/JsKz3TpuoExBzuyhhb2XoOGm6uXrhh4mguInOBmORLVNmJlUJKcgSMEQ== Received: from [66.196.81.172] by nm49.bullet.mail.bf1.yahoo.com with NNFMP; 04 Jan 2017 16:48:35 -0000 Received: from [68.142.230.70] by tm18.bullet.mail.bf1.yahoo.com with NNFMP; 04 Jan 2017 16:48:35 -0000 Received: from [127.0.0.1] by smtp227.mail.bf1.yahoo.com with NNFMP; 04 Jan 2017 16:48:35 -0000 X-Yahoo-Newman-Id: 658042.40926.bm@smtp227.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: a9YtYw0VM1nEyksVWPCGsNtpfpfOtXeiNiEwdrOoe9cAoXq ISqkbwIYTrGG5adn.6lHFHr8p7zj5mp0CL8YBpWO3C9ybws9DJKHSsD0UfCm MCMd44mnNs6RN1rQBTb2hGoAtauNAtwwpgXug_y59UBtWnEPxZgheRPCmhzp okp2ME5Ok5QZleOUumXce3.NBn6gygAjwIRDfdNEs4WzFDEUJZbVkOwGPmku xXx2.2WGYGVzK3g5.s2Eh6Pr_G2Ip.5zxSQ5nilBgFK1KXFrkcLH0dQ61Lmv RnkIulozghBgpDkf9D__FSTPmxGWFtzDMF0ZLTWz7aGOQxkQNsKNi.ZN9O_L CHAgGEqmjEVUbzxvSzWgY1f0hmWthZan0CjIoFT5Q.Mu8chcPfeNMz0kk7uu EXkvsEwtRG5BXM17JNjJxXm4yDH30eqT_Npr75K8X3UlozTCDqjXIM04pQJJ _rT.PkFScnueBrqKLe_HOxhLxNIWyzdd1WPZd.RtOSv_Maao0BL81f9jJfqq ZOjcZzWZq_7a2lgdHpgOJyQA.LlYGiSK0Dsc.B0qfCyj_KFHFxf3E9lAQkm4 66zUiTMWSBrd5b4b58G4m X-Yahoo-SMTP: khEzT4aswBBsZ3kCDBezAajPIaHWmdAAiKF0Wf.SfMop From: Vishal Biswas To: bug-sed@gnu.org Subject: Cross Compiling fails because of help2man Date: Wed, 04 Jan 2017 22:18:31 +0530 Message-ID: <4383906.jovR5H9Ice@vishal-pc> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4151647.daDxn0mGQU"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 04 Jan 2017 13:09:36 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --nextPart4151647.daDxn0mGQU Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" GNU sed 4.3 cannot be successfully cross compiled because the Makefile tries to run help2man even if cross compiling. GEN doc/sed.1 help2man: can't get `--help' info from sed/sed make[2]: *** [Makefile:5775: doc/sed.1] Error 126 --nextPart4151647.daDxn0mGQU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEI2YfQqU+EUV0an8bOZznHdcMrKsFAlhtJ18ACgkQOZznHdcM rKtlGRAAjYDDLdU5RjOYhpnGIrIyMJRaCiskuln2Vsyea6Ursnn4L82SOnwmpYUB 2wY7zZRRX5RReG/KzgEJB0LpYUg9aTZG4l/FcaOt2V7usi/aHhl8tbdNPXbBohMt ZuXpbEDzf0LSaBhXMR4UjDVtFrMdhhr6vEOuxkcxygEBU3AeV59HSvmcDXLfjdTt 7fk54l5s8LMrWrCswwdiDSI8BJwfka/E0mmT1SUdJEhHg5iVMY7CtdvfS1jFK/ve /S62txsl6BquW7ZVTgsMGQ8hU+RpQuQt4vHe9rq6pjweXcxVWWFGXE/wwQrpxPpO hk79pXQ872F4Eh71mg4Ao7HAfFX/OLDLv/Bm7lGf4OM1ULLFCUNGx5u0uW/ccUqR aw//oon6+iNNedJFk1gw76r4ctTIgDboQetLOwxqQlOGUP7gqE4iP9yUF42CeChk yrzBjcq55Y55G3NICWMFzhrQmLxe9d9UzCe0QRT9B0H2MwdL7xcyrxJO20NiBGcK C0NawuVYtt8OVdSaAahglt16HD5P+rwQ1vd1CdOtkCqZs/FivYhqYNUnZk6lHfgL l+XVEaUN69AP+VraBVclUnWwWOMG6i1fhARTrXtnXNwJmYqbNquRWYynyyHW/syj V2DHKtOA5dj/UHYkIJDwqgTBtKLpB/J91RUyuyQnLnSgrm70ws0= =krcy -----END PGP SIGNATURE----- --nextPart4151647.daDxn0mGQU-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 04 18:22:59 2017 Received: (at 25358) by debbugs.gnu.org; 4 Jan 2017 23:22:59 +0000 Received: from localhost ([127.0.0.1]:41569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOutX-0005DY-Cv for submit@debbugs.gnu.org; Wed, 04 Jan 2017 18:22:59 -0500 Received: from mail-qt0-f174.google.com ([209.85.216.174]:35559) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOutV-0005DJ-Sg for 25358@debbugs.gnu.org; Wed, 04 Jan 2017 18:22:58 -0500 Received: by mail-qt0-f174.google.com with SMTP id c47so505041268qtc.2 for <25358@debbugs.gnu.org>; Wed, 04 Jan 2017 15:22:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=hD/3a6PJ0iF5FC1IrTgdATkvjzbhH3niTKQEzuuPkaA=; b=vVlb5C+riiqUs1sAtJHPHM/NRd2BjArUzCHUxYyUhpDEciUSjvH24kgJRXakIk/BSX y1iVYdFHb6SYRYpWzQFEN45ZmZeWIcIu8W05puXKaiODCS9otrCJMp8xR/R/1s7ndJt6 6MINlxlrw+T4ZwuCkp7Zbkxcxb4e1TcoYcsu8zUwX5XUhBaS2Cr4d01k14cBZmy/GjWD 4P58hBxKRS6Kayq81iOYWyg5YkF34kYer4BUMtGZi6P2mjrilDwNudUJmS8K/HNGD5Z5 h2rLXEAaD6VfLmEti+kMYxKxoxQod3OgGBm6xrGuvdd6zQfgO2bZnIFZ+jBvY21wPhRM UE8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=hD/3a6PJ0iF5FC1IrTgdATkvjzbhH3niTKQEzuuPkaA=; b=s0yS+OKw5SS9L3zSt+1YOl8IF/3FIZOS5Okn+wh7/q3ebWRmzb6c0Wz8SjtO+BvCBe DW+hI5d627WzHmcsEqKcdqcfRcebjHunpdV53oTRBj9GwRS/qnsWPmaECyuspX4XLN32 v/l7ghS8tD/dleUIg7PuyuEkW0XBLyLa90X1DQLu1xTte8/TFphDmdW9S1iq5ayARIyq oDHUS0iOsTEvadfSzlJmUPIKo29FPdna6EHsssM0SsqqvUhgOgpb3bA49YR8ZF7k2190 iQrxrTKgPJ2ksbsiKwwfqT9aejIqPvhEkk73tEz49fTifOFDgG6VMVPIXZDnrE+oiETR QyAw== X-Gm-Message-State: AIkVDXKoEOSDa6NLpphkNzDd2yJ/ftqsiGaWW7fqp9L5LL3sYnDui20Kc9VkvWMeum4GRA== X-Received: by 10.237.48.139 with SMTP id 11mr63494716qtf.219.1483572172150; Wed, 04 Jan 2017 15:22:52 -0800 (PST) Received: from disco.erlich.nygenome.org ([69.74.14.178]) by smtp.gmail.com with ESMTPSA id o44sm31522656qtc.8.2017.01.04.15.22.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jan 2017 15:22:51 -0800 (PST) Subject: Re: bug#25358: Cross Compiling fails because of help2man To: Vishal Biswas , 25358@debbugs.gnu.org References: <4383906.jovR5H9Ice@vishal-pc> From: Assaf Gordon Message-ID: <29df7d15-5f3e-72dc-9ed6-d85d02731230@gmail.com> Date: Wed, 4 Jan 2017 18:22:51 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <4383906.jovR5H9Ice@vishal-pc> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 25358 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) Hello Vishal, On 01/04/2017 11:48 AM, Vishal Biswas wrote: > GNU sed 4.3 cannot be successfully cross compiled because the Makefile tries to > run help2man even if cross compiling. Thank you for reporting this, it is a bug in the build system. As a temporary work-around (if one is needed): first, the cross-copmiled binary is already successfully built when the help2man error is encountered. Not sure if this is sufficient for you or not. The binary file is 'sed/sed'. second, the 'doc/sed.1' file is already pre-built and included in the 'sed-4.3.tar.xz' file, So running touch doc/sed.1 ; make should 'just work' and complete the build successfully. > GEN doc/sed.1 > help2man: can't get `--help' info from sed/sed > make[2]: *** [Makefile:5775: doc/sed.1] Error 126 The bug in the build system is that 'doc/sed.1' depends on the binary 'sed/sed', even if 'sed.1' already exists in the tarball and there's no need to re-generate it. Jim, I can think of two ways around this: 1. make 'doc/sed.1' depend on 'sed/sed.c' and 'doc/sed.x' instead of the binary 'sed/sed'. The assumption is that if the C source hasn't changed, there's no need to update the man page. 2. make the building of 'doc/sed.1' conditional, depending on wether it is being built from '.git' (then regenerate it) or from a tarball (then it already exists). something like: AM_CONDITIONAL([BUILD_FROM_GIT], [test -d "$srcdir/.git"]) and then in 'doc/local.mk': if BUILD_FROM_GIT doc/sed.1: sed/sed$(EXEEXT) .version $(srcdir)/doc/sed.x ... endif What do you think ? regards, - assaf From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 05 11:41:53 2017 Received: (at 25358) by debbugs.gnu.org; 5 Jan 2017 16:41:53 +0000 Received: from localhost ([127.0.0.1]:44016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPB6v-00026p-Bn for submit@debbugs.gnu.org; Thu, 05 Jan 2017 11:41:53 -0500 Received: from mail-it0-f65.google.com ([209.85.214.65]:35995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPB6t-00026c-BZ for 25358@debbugs.gnu.org; Thu, 05 Jan 2017 11:41:51 -0500 Received: by mail-it0-f65.google.com with SMTP id n68so57675159itn.3 for <25358@debbugs.gnu.org>; Thu, 05 Jan 2017 08:41:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=MeK1sjJMxHB3kGOuk1zc+MIR9qUHQvliooUH9vM3Tak=; b=cL/QM3Odvv3tJCAgYT6TefhxXJZiQWKwI7IkLxTHMpmwj5RuVNOrpVMqaBfPgJqC3f kU+OSG1cYRI+8dE56m4to+KBpoPiELW7TGQjVFkUJuduLMoZzU6O+KkfnMUdw95Mg+T/ FUrHCPfhHo8KaZvs/YYKcei5WRI9soYkX1EJVYme3mog7OWTmNVTabHJIvoM3IE15fU2 AQb7VLKJ3rWkgWrX9fy9kC7tHTUI7uzNPxQcYUTY2qTDAfqPqRFY7lFvpYUG5fhhjewl zW8cogAhWfSFjp5zs9LOBgs16F0f/kL4eckzdeZMrQmxs7uFRwRdUdTgcFSYtqHfTSsc Vn/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=MeK1sjJMxHB3kGOuk1zc+MIR9qUHQvliooUH9vM3Tak=; b=nwMz/nfkmro6UsPniPwYNYW0S9QD1fEe1ORkI/jwst+zy1FY3SBHOJkng1PM7s5f1u CEel+R366wTYy1wLg/i0R0myyMABGBg0B2ebjcdl+OlxUrp4VVY9gNEOQheoaqbudCVT cFmoteSoVVJrQCko2aBFgVQfcp0igVvCdcwdtG0BG2izsBdL+cRrfTnZznCHfvAsh865 rZBx6IbEiOLd2pB+aFBZnN/8MVc0H7xTNaht7DufHlP1x8KmPPkILszfv8kU56girXve b85oWMeMnas9SAt4yrz5kF6EI/XpSKLQLJC7x9aYrjLVghwNfAy78DHtR0zymVewhJ2/ dm8w== X-Gm-Message-State: AIkVDXJjjhc7gybfYBXwt/NAhObBqgFnoEgll70nxV+1YgWHdSVK1BwtvSJOQJc+/X2OYFyn13+83BBhI0Kx/A== X-Received: by 10.36.105.193 with SMTP id e184mr61844573itc.31.1483634505615; Thu, 05 Jan 2017 08:41:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.191.5 with HTTP; Thu, 5 Jan 2017 08:41:24 -0800 (PST) In-Reply-To: <29df7d15-5f3e-72dc-9ed6-d85d02731230@gmail.com> References: <4383906.jovR5H9Ice@vishal-pc> <29df7d15-5f3e-72dc-9ed6-d85d02731230@gmail.com> From: Jim Meyering Date: Thu, 5 Jan 2017 17:41:24 +0100 X-Google-Sender-Auth: 36yC_Hotz7aXFBBD4xFyvCr4eA8 Message-ID: Subject: Re: bug#25358: Cross Compiling fails because of help2man To: Assaf Gordon Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25358 Cc: Vishal Biswas , 25358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Thu, Jan 5, 2017 at 12:22 AM, Assaf Gordon wrote: > Hello Vishal, > > On 01/04/2017 11:48 AM, Vishal Biswas wrote: >> GNU sed 4.3 cannot be successfully cross compiled because the Makefile tries to >> run help2man even if cross compiling. > > Thank you for reporting this, it is a bug in the build system. > > As a temporary work-around (if one is needed): > first, the cross-copmiled binary is already successfully built when the > help2man error is encountered. Not sure if this is sufficient for you or > not. The binary file is 'sed/sed'. > > second, > the 'doc/sed.1' file is already pre-built and included in the > 'sed-4.3.tar.xz' file, So running > touch doc/sed.1 ; make > should 'just work' and complete the build successfully. > >> GEN doc/sed.1 >> help2man: can't get `--help' info from sed/sed >> make[2]: *** [Makefile:5775: doc/sed.1] Error 126 > > The bug in the build system is that 'doc/sed.1' depends on the binary > 'sed/sed', even if 'sed.1' already exists in the tarball and there's no > need to re-generate it. > > Jim, > I can think of two ways around this: > > 1. make 'doc/sed.1' depend on 'sed/sed.c' and 'doc/sed.x' instead > of the binary 'sed/sed'. The assumption is that if the C > source hasn't changed, there's no need to update the man page. Hi Assaf, Thanks for investigating. I'm pretty sure we must retain the dependency, at least when not cross-compiling. If we were to attempt to remove that dependency, I believe that would leave a race condition where help2man may attempt to run the binary before it is built. > 2. make the building of 'doc/sed.1' conditional, depending on wether > it is being built from '.git' (then regenerate it) or from > a tarball (then it already exists). > something like: > > AM_CONDITIONAL([BUILD_FROM_GIT], [test -d "$srcdir/.git"]) > > and then in 'doc/local.mk': > > if BUILD_FROM_GIT > doc/sed.1: sed/sed$(EXEEXT) .version $(srcdir)/doc/sed.x > ... > endif Even when building from a tarball, we should leave as many build rules as we can. How about removing the dependency only when cross-compiling, e.g., via: `if CROSS_COMPILING ...`. This should have the advantage of working also when cross-compiling from a git clone'd working directory. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 05 19:44:39 2017 Received: (at 25358) by debbugs.gnu.org; 6 Jan 2017 00:44:40 +0000 Received: from localhost ([127.0.0.1]:44142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPIe7-0002Oh-KQ for submit@debbugs.gnu.org; Thu, 05 Jan 2017 19:44:39 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:34433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPIe5-0002OQ-8U for 25358@debbugs.gnu.org; Thu, 05 Jan 2017 19:44:37 -0500 Received: by mail-qt0-f193.google.com with SMTP id a29so4273089qtb.1 for <25358@debbugs.gnu.org>; Thu, 05 Jan 2017 16:44:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=jWOewUY2XLTbMRWzKGBkGMEzElx5/HFVm4U3hjwFbLk=; b=PXDDx/TPJgpxMi6JeQw2wdgtf7dOJNvpW9iqq68dU2PmwnSdyCzKbtpnrDvwflwezd 7Ei5K4TEvJNrCR2KqQuhQDHKuCF8DTbryReO01d70yseLSxIxRIMuCMc+87oUpLTAWdE lCNC4OPQQoIf/BGKCoOsgXTB+6RnmVS0Gtd7NtZd344G9KYVczXTipsXL3P0b3dfSvkm 8b+k1cCIbFzYHEZyOWeEKUVqFKbTbgjJ/CA+8VnK5LoUNtAJ8NN9YPwGYrShHuVG6Ge8 3jk75OZOO6QKMM3oVsgLZBfH0uWkcOwifIFKKdJ2/GW4vD9T7VYHNW3PdNSCNSqpXNlR g4UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=jWOewUY2XLTbMRWzKGBkGMEzElx5/HFVm4U3hjwFbLk=; b=q66vvhmh9wP020UZ1s0UcpSd6JS4K2PwKsgY2bAUyBD3t6ARkcv30zI8spQLeOOOd+ Oqr9MlUmB3Jqs1iTmO/Dy+8twGlyitVeTSSXWSGv6K3yb7TGLRH7h++2OJ/dC3u1TUGe HexW2jrrWR5Ff6BVtS4xnhHCvrtgjyQ2lZ5is3jUHbsPiwq2/dWKNrITMNvpvEXOOsbC ANCFLQPZpBj36rSlHasEnOoSz/8FucJVzm0+cnsAt7vtSy3GOFG7+VpZnIcvbjeSJXgF yhGIX9SYDqSddopWtIFinPSjE0GlW3Gz14NctLtgDONTuSXAZSaULSiK5OMTe4abprev OOZw== X-Gm-Message-State: AIkVDXId4oyO6EAK7gZdhDI0ips55hWiR81VxX3epN6rAqwG5A+jnmheAeTsxweb7MXklA== X-Received: by 10.237.60.101 with SMTP id u34mr77434139qte.53.1483663471314; Thu, 05 Jan 2017 16:44:31 -0800 (PST) Received: from ix.home (pool-100-37-92-116.nycmny.fios.verizon.net. [100.37.92.116]) by smtp.gmail.com with ESMTPSA id 5sm49411151qts.47.2017.01.05.16.44.30 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 05 Jan 2017 16:44:30 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Subject: Re: bug#25358: Cross Compiling fails because of help2man From: Assaf Gordon In-Reply-To: Date: Thu, 5 Jan 2017 19:44:28 -0500 Content-Transfer-Encoding: quoted-printable Message-Id: <935000C9-2B9F-4326-900D-F7802A8BAE75@gmail.com> References: <4383906.jovR5H9Ice@vishal-pc> <29df7d15-5f3e-72dc-9ed6-d85d02731230@gmail.com> To: Jim Meyering X-Mailer: Apple Mail (2.2102) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25358 Cc: Vishal Biswas , 25358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Hello Jim and all, > On Jan 5, 2017, at 11:41, Jim Meyering wrote: >=20 >> 1. make 'doc/sed.1' depend on 'sed/sed.c' and 'doc/sed.x'=20 > I'm pretty sure we must retain the dependency, at least when not > cross-compiling. If we were to attempt to remove that dependency, I > believe that would leave a race condition where help2man may attempt > to run the binary before it is built. GNU Make has a good solution for it with its "order-only-prerequisites" (which ensure proper order but ignore timestamp of the dependency): = https://www.gnu.org/software/make/manual/html_node/Prerequisite-Types.html= Too bad it's not portable... >=20 >> 2. make the building of 'doc/sed.1' conditional, depending on wether >> it is being built from '.git' (then regenerate it) >=20 > Even when building from a tarball, we should leave as many build rules > as we can. We do already distribute 'doc/sed.1' in the tarball, and currently = always rebuild it, I wonder if it's worth making an exception in this case? For example in coreutils I think man pages are skipped if there's no = perl. Doing the same in sed will allow building it on system without = perl (BTW this was the cause for bug #25367 - it was a system with = non-working perl). If we do go with only skipping for cross-compilation, does this suffice for 'configure.ac' ? AM_CONDITIONAL([CROSS_COMPILING], [test "$cross_compiling" =3D yes]) In that case, perhaps it's worth adding a test for perl and skipping if = it doesn't exist ? I'm expecting more system will ship without perl as time goes by... regards, - assaf From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 06 10:59:20 2017 Received: (at 25358) by debbugs.gnu.org; 6 Jan 2017 15:59:20 +0000 Received: from localhost ([127.0.0.1]:45290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPWvH-0006KH-Qm for submit@debbugs.gnu.org; Fri, 06 Jan 2017 10:59:20 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:33312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPWvF-0006K4-Mp for 25358@debbugs.gnu.org; Fri, 06 Jan 2017 10:59:18 -0500 Received: by mail-io0-f194.google.com with SMTP id 71so5797282ioe.0 for <25358@debbugs.gnu.org>; Fri, 06 Jan 2017 07:59:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=wG02PNzRRNn5qkNkx+rtUyYV2WfTC9kHO5jcxROOQCk=; b=WfZu08NyIaOPh8TKt9taIRxl9a3ZmzLavHpEmbHIp3IWD+CGVae2RwkqwfjuqpU4nY 1Azyj59vzB8ZDREbpZMjB+JEtl5SPJfttPihjuF/tH22PbAY8Jvv0WrD6jM0ABxVWdg7 NVe1K+pxHyLdhEeMQqjtw1kqZ4DqacCcoWzEFIE6w3Npn1otNoEFOa0tyOipYXRdlqF5 Zu5EOGi50qJj2OzTrzi+z3Gig/+/OWNSKiD/ARggLnE8x1pjs8x+bK9sHTxvEQLqlpqj neVg4NxvH6arzGNux/hOpQM3CbozhIBZpybVUHLDMkn5zU1FAXHYZOwrnF03kUHvtpAU 10ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=wG02PNzRRNn5qkNkx+rtUyYV2WfTC9kHO5jcxROOQCk=; b=Bvea51fo3Ivi2DRN0bLSeDXpxneidjeVwUfNhP1G1eLfpF+RY1gLRTGmG5BlstBqOX xXSxLLMl6V5H6kXWH7yWq4nuM2rkzCJVJU53buXRzdnbmY/iQZNTHVj4S6ICYfZKd7Bi bI1GM+fEY2eP5hiIb64TFCDqPbZDmFbn/tuwtAAY04K7p/vosOVhC+rbxhvZIeLAD47k ynWbpzQW0OLn4IpzDre0UU4CMPYATewW+OL3sdqfI3oFNDqv/3tXZ3XZks59X/3DSlIY BjVYECG6HCNqS49FqXLbPEkUYUScRjxqG+csReg8GlkNeTsqmbLVjaElEUTBd0Atry8M DTOQ== X-Gm-Message-State: AIkVDXIbnIt0DddEFKxfWdx0QjPu4serXXjt/xH/XXW6Zy/dGo2T8EDir7Az7pIlNAQxV4hvMKpj/6/Q3aRnFA== X-Received: by 10.107.164.18 with SMTP id n18mr2289260ioe.29.1483718351813; Fri, 06 Jan 2017 07:59:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.191.5 with HTTP; Fri, 6 Jan 2017 07:58:51 -0800 (PST) In-Reply-To: <935000C9-2B9F-4326-900D-F7802A8BAE75@gmail.com> References: <4383906.jovR5H9Ice@vishal-pc> <29df7d15-5f3e-72dc-9ed6-d85d02731230@gmail.com> <935000C9-2B9F-4326-900D-F7802A8BAE75@gmail.com> From: Jim Meyering Date: Fri, 6 Jan 2017 16:58:51 +0100 X-Google-Sender-Auth: c890H75D7GVlCRKCSdqp8DwE1lY Message-ID: Subject: Re: bug#25358: Cross Compiling fails because of help2man To: Assaf Gordon Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 25358 Cc: Vishal Biswas , 25358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On Fri, Jan 6, 2017 at 1:44 AM, Assaf Gordon wrote: > Hello Jim and all, > >> On Jan 5, 2017, at 11:41, Jim Meyering wrote: >> >>> 1. make 'doc/sed.1' depend on 'sed/sed.c' and 'doc/sed.x' >> I'm pretty sure we must retain the dependency, at least when not >> cross-compiling. If we were to attempt to remove that dependency, I >> believe that would leave a race condition where help2man may attempt >> to run the binary before it is built. > > GNU Make has a good solution for it with its "order-only-prerequisites" > (which ensure proper order but ignore timestamp of the dependency): > > https://www.gnu.org/software/make/manual/html_node/Prerequisite-Types.html > > Too bad it's not portable... Indeed. >>> 2. make the building of 'doc/sed.1' conditional, depending on wether >>> it is being built from '.git' (then regenerate it) >> >> Even when building from a tarball, we should leave as many build rules >> as we can. > > We do already distribute 'doc/sed.1' in the tarball, and currently always rebuild it, > I wonder if it's worth making an exception in this case? I don't feel strongly about this either way. You're welcome to make the call. > For example in coreutils I think man pages are skipped if there's no perl. Doing the same in sed will allow building it on system without perl (BTW this was the cause for bug #25367 - it was a system with non-working perl). > > If we do go with only skipping for cross-compilation, > does this suffice for 'configure.ac' ? > > AM_CONDITIONAL([CROSS_COMPILING], [test "$cross_compiling" = yes]) Since that's all coreutils does, I presume it will work for us. > In that case, perhaps it's worth adding a test for perl and skipping if it doesn't exist ? > > I'm expecting more system will ship without perl as time goes by... This seems worthwhile. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 07 23:23:34 2017 Received: (at 25358) by debbugs.gnu.org; 8 Jan 2017 04:23:34 +0000 Received: from localhost ([127.0.0.1]:46378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQ513-0000qG-Us for submit@debbugs.gnu.org; Sat, 07 Jan 2017 23:23:34 -0500 Received: from mail-qk0-f194.google.com ([209.85.220.194]:35900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQ512-0000q4-BR for 25358@debbugs.gnu.org; Sat, 07 Jan 2017 23:23:32 -0500 Received: by mail-qk0-f194.google.com with SMTP id a20so14991942qkc.3 for <25358@debbugs.gnu.org>; Sat, 07 Jan 2017 20:23:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc:message-id:references :to; bh=JMVmxjZxkaA/zVm5+kCVW11J0lAPRouJHzYD8aLmfIM=; b=c0YykgY06FtM6WNcn+OzpodmxMDVCiFI0atpiofgRu6fP7hlJm4fufPO2/r+95SjVB ISUpSAJ70pjAqAvs5la5PZ5k+Ae555qhAU9gpIfTss+o3JRYXgfAEbxVAPmVgc18BWdL pYyoN7XwfLXro/3+yY2J55tYgy1ka6I+8D8/aGhUkkWqN4pOF8YwvOV7UJn6Qm6zvisr x31EiAtfdCuCUyBJIL+WZcBMIoFxO5I2opKGk3bOsK0gVmagKQ3FH4U7P1gUZPeT0dTb elF4m45iNwh21N4VK/sxWbjN0aL3SMoka9Mdj9EpfDQUWudd14cRB6W8iptyCz6+5Srz xZ/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=JMVmxjZxkaA/zVm5+kCVW11J0lAPRouJHzYD8aLmfIM=; b=q9SYtxiL28nCQUzlUQxV89c/CM4tg9H2OFg1lWVvIlAC5hF11eMC8tobUQjNf4QrcO G9stDwB9xosgtB/y7oCgT10/6N6NcnqSCYaArkDZSy6jwUiPfeYbe8gPTwUbd4wenaLi DUvpvZrIxh+IKaV/lVDGPvDC8e2P7sbSbvWzFhi1WcD9SGEm8I3iy30cGx82gRyHlcW1 bemc04aubQv/JLOp919bloPvJdvF2B7F+htzcvWlK+LbXAvcSffACqscEQHr2Cz+995l 8Avp7H2FJF2isiAtNOxEvW0RSG1RQQiotDbb1kg8QS+7fLsi/Ai5LGTiyOwQqmJGAGH7 KEgA== X-Gm-Message-State: AIkVDXJP9+jKgd1maptkrSOxqZZpr6DTj2oUwUo/T9cfNhAnZ5FK8WmbsbXz4ncbySEGmA== X-Received: by 10.55.24.221 with SMTP id 90mr91237092qky.296.1483849406855; Sat, 07 Jan 2017 20:23:26 -0800 (PST) Received: from ix.home (pool-100-37-92-116.nycmny.fios.verizon.net. [100.37.92.116]) by smtp.gmail.com with ESMTPSA id 33sm54227369qtq.1.2017.01.07.20.23.24 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 07 Jan 2017 20:23:25 -0800 (PST) Content-Type: multipart/mixed; boundary="Apple-Mail=_6DE02C89-21A6-46D6-AE44-F764788A758C" Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Subject: Re: bug#25358: Cross Compiling fails because of help2man From: Assaf Gordon In-Reply-To: Date: Sat, 7 Jan 2017 23:23:22 -0500 Message-Id: References: <4383906.jovR5H9Ice@vishal-pc> <29df7d15-5f3e-72dc-9ed6-d85d02731230@gmail.com> <935000C9-2B9F-4326-900D-F7802A8BAE75@gmail.com> To: Jim Meyering X-Mailer: Apple Mail (2.2102) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25358 Cc: Vishal Biswas , 25358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --Apple-Mail=_6DE02C89-21A6-46D6-AE44-F764788A758C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hello, > On Jan 6, 2017, at 10:58, Jim Meyering wrote: >=20 > On Fri, Jan 6, 2017 at 1:44 AM, Assaf Gordon = wrote: >>=20 >> We do already distribute 'doc/sed.1' in the tarball, and currently = always rebuild it, >> I wonder if it's worth making an exception in this case? >=20 > I don't feel strongly about this either way. You're welcome to make = the call. >=20 >> AM_CONDITIONAL([CROSS_COMPILING], [test "$cross_compiling" =3D = yes]) >=20 > Since that's all coreutils does, I presume it will work for us. >=20 >> In that case, perhaps it's worth adding a test for perl and skipping = if it doesn't exist ? >=20 > This seems worthwhile. The attach suggested patch adds all three cases to 'configure.ac', and 'doc/sed.1' is build conditionally. It leaves one case un-handled: cross-compilation directly from git. If this is needed, then either 'sed' can be first built natively (and = 'doc/sed.1' will be created), or we can add a special case and create a stub doc/sed.1 file. Comments welcomed, - assaf --Apple-Mail=_6DE02C89-21A6-46D6-AE44-F764788A758C Content-Disposition: attachment; filename=0001-build-skip-building-man-page-if-needed.patch Content-Type: application/octet-stream; name="0001-build-skip-building-man-page-if-needed.patch" Content-Transfer-Encoding: quoted-printable =46rom=20a8318355a62077e6f0bd00fec53032c64a78c5d4=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Assaf=20Gordon=20=0A= Date:=20Sat,=207=20Jan=202017=2023:05:07=20-0500=0ASubject:=20[PATCH]=20= build:=20skip=20building=20man=20page=20if=20needed=0A=0ASkip=20building=20= the=20man=20page=20if=20there=20is=20no=20working=20perl,=20if=20the=20= 'sed'=0Abinary=20can't=20be=20run=20(when=20cross-compiling),=20or=20if=20= building=20from=20a=0Atarball,=20where=20the=20'doc/sed.1'=20file=20is=20= pre-built.=0ACross-compilation=20issue=20reported=20by=20Vishal=20Biswas=20= in=0Ahttps://bugs.gnu.org/25358=20.=0AProblematic=20'perl'=20is=20= related=20to=20https://bugs.gnu.org/25367=20.=0A=0A*=20configure.ac:=20= Check=20for=20Perl,=20cross-compilation=20and=20tarball=20build;=0ASet=20= automake=20variable=20BUILD_MAN_PAGE=20accordingly.=0A*=20doc/local.mk=20= (doc/sed.1):=20Build=20conditionally,=20if=20BUILD_MAN_PAGE=20is=20true.=0A= ---=0A=20configure.ac=20|=2021=20+++++++++++++++++++++=0A=20doc/local.mk=20= |=20=202=20++=0A=202=20files=20changed,=2023=20insertions(+)=0A=0Adiff=20= --git=20a/configure.ac=20b/configure.ac=0Aindex=209fcc62b..bcae765=20= 100644=0A---=20a/configure.ac=0A+++=20b/configure.ac=0A@@=20-294,6=20= +294,27=20@@=20if=20test=20"$gl_gcc_warnings"=20=3D=20yes;=20then=0A=20=20= =20AC_SUBST([GNULIB_TEST_WARN_CFLAGS])=0A=20fi=0A=20=0A= +AM_CONDITIONAL([CROSS_COMPILING],=20[test=20"$cross_compiling"=20=3D=20= yes])=0A+=0A+#=20Perl=20is=20needed=20for=20help2man=0A= +AC_PATH_PROG([PERL],=20[perl])=0A+=0A+#=20building=20from=20tarball?=0A= +built_from_tarball=3Dno=0A+test=20-f=20"$srcdir"/.tarball-version=20&&=20= \=0A+=20=20!=20test=20-d=20"$srcdir/.git"=20&&=20\=0A+=20=20= built_from_tarball=3Dyes=0A+=0A+#=20Skip=20building=20the=20man=20page=20= when:=0A+#=201.=20Building=20from=20tarball=20(sed.1=20is=20alread=20= prebuilt)=0A+#=202.=20No=20working=20perl=20(required=20for=20help2man)=0A= +#=203.=20Can't=20execute=20'sed'=20binary=20(called=20by=20help2man)=0A= +AM_CONDITIONAL([BUILD_MAN_PAGE],=0A+=20[test=20"$built_from_tarball"=20= =3D=20no=20&&=20\=0A+=20=20test=20-n=20"$PERL"=20&&=20\=0A+=20=20test=20= "$cross_compiling"=20!=3D=20yes=20])=0A+=0A+=0A=20AC_CONFIG_FILES([=0A=20= =20=20Makefile=0A=20=20=20po/Makefile.in=0Adiff=20--git=20a/doc/local.mk=20= b/doc/local.mk=0Aindex=2009d1719..dfed74a=20100644=0A---=20= a/doc/local.mk=0A+++=20b/doc/local.mk=0A@@=20-22,6=20+22,7=20@@=20SEDBIN=20= =3D=20sed/sed=0A=20=0A=20AM_MAKEINFOHTMLFLAGS=20=3D=20--no-split=0A=20=0A= +if=20BUILD_MAN_PAGE=0A=20doc/sed.1:=20sed/sed$(EXEEXT)=20.version=20= $(srcdir)/doc/sed.x=0A=20=09$(AM_V_GEN)$(MKDIR_P)=20doc=0A=20=09= $(AM_V_at)rm=20-rf=20$@=20$@-t=0A@@=20-31,3=20+32,4=20@@=20doc/sed.1:=20= sed/sed$(EXEEXT)=20.version=20$(srcdir)/doc/sed.x=0A=20=09=20=20=20=20-o=20= $@-t=20$(SEDBIN)=09=09=09=09=09=09\=0A=20=09=20=20&&=20chmod=20a-w=20= $@-t=09=09=09=09=09=09\=0A=20=09=20=20&&=20mv=20$@-t=20$@=0A+endif=0A--=20= =0A2.10.2=0A=0A= --Apple-Mail=_6DE02C89-21A6-46D6-AE44-F764788A758C Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii --Apple-Mail=_6DE02C89-21A6-46D6-AE44-F764788A758C-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 09 09:24:18 2017 Received: (at 25358) by debbugs.gnu.org; 9 Jan 2017 14:24:18 +0000 Received: from localhost ([127.0.0.1]:47480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQarx-00038X-Si for submit@debbugs.gnu.org; Mon, 09 Jan 2017 09:24:18 -0500 Received: from mail-io0-f193.google.com ([209.85.223.193]:34814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQarw-00038H-BC for 25358@debbugs.gnu.org; Mon, 09 Jan 2017 09:24:16 -0500 Received: by mail-io0-f193.google.com with SMTP id c80so6766846iod.1 for <25358@debbugs.gnu.org>; Mon, 09 Jan 2017 06:24:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=nBGLK+SeIQBEOWjI0wk0YSZwSohTGsx7vUrL2GI1CEU=; b=fCNwjVy4yKLI8RVSSo6Pw9cZSGVl7etnRkkOfQ3aPW+EXQi766MbaVGtiJBHToBbC6 4yVJUg1V/d/H2XMLRCPJe4c3sFhcnNHKRH0iwnsQX/XN4Mggy0fBduLJe1818g6ioXp0 0iKXC7ZbVjFYRTVN9DA2ifgksL8n73oBvWA7kAp/5YkLg86RRjw/0c3a3cFOX3Jtiza1 c38NTfYmM0mqWg61EsCs6cViGIFqoNzhfc0cVGn2fWPGZP5DkpNARetwenb/NCWrFgwZ vE2J/OCHyUFNP83nL3NXAowmw5CrKr/0TdpL1HvLkOGRFEojwqwdJSFVNYh1y9m+ycMv bW8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=nBGLK+SeIQBEOWjI0wk0YSZwSohTGsx7vUrL2GI1CEU=; b=TLDAG6gzRLBvzXiebkZsVMGVBL/HPpLB/DV5nN8jumGeUxRaNO8sjRqEzcu6nRKPkV PXX5RW1dxt5Z1Cnv981M+DCcFDOu77BWh0j1lUCx9HaZ0We8vgW0+Rqn0u9hSTPzYUxC 00s24ZQpmeUBPnh0uhLSLEkWOQDEOxecwl6K/lnueI/U2XuZSt4R2Zs6UcP8Hb8cghKX rVn5tz/jJMO4x4U+vnC29zgUyJTVhd4peLPPTMa2UKuNgsfkGZKbLyDslAdy8XHEeA38 zYXcdhnGIXI7nw0DIRmwIGEqzYh6ShQDOZRjEyle4iakMdZIRHUugungGjxFMIDvYRe0 Oofw== X-Gm-Message-State: AIkVDXKbD8O2s6Cmt3TPQOh7NgzSiJcZ4OClMy1utA+7G+Mqor39xL+0PwN3lT0y3Sg0fEsR8bV1b5r2HWjEgg== X-Received: by 10.107.164.18 with SMTP id n18mr12209180ioe.29.1483971850712; Mon, 09 Jan 2017 06:24:10 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.191.5 with HTTP; Mon, 9 Jan 2017 06:23:50 -0800 (PST) In-Reply-To: References: <4383906.jovR5H9Ice@vishal-pc> <29df7d15-5f3e-72dc-9ed6-d85d02731230@gmail.com> <935000C9-2B9F-4326-900D-F7802A8BAE75@gmail.com> From: Jim Meyering Date: Mon, 9 Jan 2017 15:23:50 +0100 X-Google-Sender-Auth: 7WTLsMEbDhyXaVQ6Q57fG6-WvJQ Message-ID: Subject: Re: bug#25358: Cross Compiling fails because of help2man To: Assaf Gordon Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 25358 Cc: Vishal Biswas , 25358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On Sun, Jan 8, 2017 at 5:23 AM, Assaf Gordon wrote: > Hello, > >> On Jan 6, 2017, at 10:58, Jim Meyering wrote: >> >> On Fri, Jan 6, 2017 at 1:44 AM, Assaf Gordon wrote: >>> >>> We do already distribute 'doc/sed.1' in the tarball, and currently always rebuild it, >>> I wonder if it's worth making an exception in this case? >> >> I don't feel strongly about this either way. You're welcome to make the call. >> >>> AM_CONDITIONAL([CROSS_COMPILING], [test "$cross_compiling" = yes]) >> >> Since that's all coreutils does, I presume it will work for us. >> >>> In that case, perhaps it's worth adding a test for perl and skipping if it doesn't exist ? >> >> This seems worthwhile. > > The attach suggested patch adds all three cases to 'configure.ac', > and 'doc/sed.1' is build conditionally. > > It leaves one case un-handled: cross-compilation directly from git. > If this is needed, then either 'sed' can be first built natively (and 'doc/sed.1' will be created), > or we can add a special case and create a stub doc/sed.1 file. Thank you. That looks great. Not sure it's worth it, but adding an "else" block to that "if BUILD_MAN_PAGE" (with a rule that fails with a diagnostic explaining why we cannot build sed.1) may avoid some confusion. Otherwise, all they'll get is a failed build (no rule to make...), and may think it's a bug and report it. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 09 22:28:47 2017 Received: (at 25358) by debbugs.gnu.org; 10 Jan 2017 03:28:47 +0000 Received: from localhost ([127.0.0.1]:48302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQn79-0001IY-Lh for submit@debbugs.gnu.org; Mon, 09 Jan 2017 22:28:47 -0500 Received: from mail-qt0-f194.google.com ([209.85.216.194]:33080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQn78-0001II-84 for 25358@debbugs.gnu.org; Mon, 09 Jan 2017 22:28:46 -0500 Received: by mail-qt0-f194.google.com with SMTP id n13so6808985qtc.0 for <25358@debbugs.gnu.org>; Mon, 09 Jan 2017 19:28:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc:message-id:references :to; bh=05HjxEnxkTQTqpuOVejEgUkqeLaFqKNhiLGNvQrB+RQ=; b=E794dq0Sx1QmoFEEy9hkMVqq699qw9XZ9GOlsVAIk5UoFgN37emjXQBKonWiNpNgpI ehLB3noXzbIzNxywVdgPKApbEZRsOFUFPdD60vzI2KUNLWVNZRVnJqsoOcwSRqlKp/BA lU/h/3+EJ8+LFocf27YNvF/YiVcLHMYFKULcnbcoBdocxpNm2o7ZnYQUhfF8e8MK76W5 6kXEGDx4wCjpANNE7+j+rhujBILktSciahb4cOxPp5A9MMHHXy65ys1NiFS3EB2jpHr5 Ox2eCsiGEQLRj1FOFG/eabvnWyr5qLPZdxZ1i4ABeSPEOM/8yOCgVCsn7vFrSrHZSSb1 WE2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=05HjxEnxkTQTqpuOVejEgUkqeLaFqKNhiLGNvQrB+RQ=; b=P9oM79mzJATBqFCwRVQQJ4dPh4kVPqJrWEuZBOSY9ixZXrLPj7vqft3FBu55hs++k+ vDahDtuVETFXn3CLRD4NDFXa6EeKddKM9aqrnicA24FwGD6joedM9jABH2HlCvJjJPwb cH6mnALqKBQVwneHJGvEwVv/y2gwO9mjcK6PCD0cizVnKVmP1OPOza7EHOiZV17uC+Ez XFpl1jIXR2/dyJGvus7TD2RyNVwgESTrB8cnntMbqqcgICRBUUiEJAbXvjEHO8KhDOWn HBlxyWVl0UEVZyytPW4LRB+uzDfjm017cfwOkxdGE48VKlVcmF95F/Ljx9g89NiPMPz5 83kg== X-Gm-Message-State: AIkVDXIAnCYvZZF6BIW2xj0tUzxQTSQN2m5iDqc6xQK8gkWbPjN4nqtwefcqESuGWt6MPw== X-Received: by 10.237.53.236 with SMTP id d41mr926224qte.135.1484018920854; Mon, 09 Jan 2017 19:28:40 -0800 (PST) Received: from ix.home (pool-100-37-92-116.nycmny.fios.verizon.net. [100.37.92.116]) by smtp.gmail.com with ESMTPSA id r65sm432322qkd.41.2017.01.09.19.28.39 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 09 Jan 2017 19:28:40 -0800 (PST) Content-Type: multipart/mixed; boundary="Apple-Mail=_95DE48BF-1163-4CE6-9F5A-AD4DF626EF47" Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Subject: Re: bug#25358: Cross Compiling fails because of help2man From: Assaf Gordon In-Reply-To: Date: Mon, 9 Jan 2017 22:28:38 -0500 Message-Id: <3D6ED03F-FA9A-4631-A993-79C5FE8FB66C@gmail.com> References: <4383906.jovR5H9Ice@vishal-pc> <29df7d15-5f3e-72dc-9ed6-d85d02731230@gmail.com> <935000C9-2B9F-4326-900D-F7802A8BAE75@gmail.com> To: Jim Meyering X-Mailer: Apple Mail (2.2102) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25358 Cc: Vishal Biswas , 25358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --Apple-Mail=_95DE48BF-1163-4CE6-9F5A-AD4DF626EF47 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hello, > On Jan 9, 2017, at 09:23, Jim Meyering wrote: >=20 > On Sun, Jan 8, 2017 at 5:23 AM, Assaf Gordon = wrote: >> The attach suggested patch adds all three cases to 'configure.ac', >> and 'doc/sed.1' is build conditionally. >=20 > Not sure it's worth it, but adding an "else" block to that "if > BUILD_MAN_PAGE" (with a rule that fails with a diagnostic explaining > why we cannot build sed.1) may avoid some confusion. Otherwise, all > they'll get is a failed build (no rule to make...), and may think it's > a bug and report it. I think that n the case of building from tarball - it won't fail because = 'doc/sed.1' already exists. But in the other cases there will be an clear failure. The attach patch handles these cases specifically, and creates a dummy = man page instead of failing. What do you think ? - assaf --Apple-Mail=_95DE48BF-1163-4CE6-9F5A-AD4DF626EF47 Content-Disposition: attachment; filename=0001-build-skip-building-man-page-if-needed.patch Content-Type: application/octet-stream; name="0001-build-skip-building-man-page-if-needed.patch" Content-Transfer-Encoding: quoted-printable =46rom=20a0a25e3ee35f5071d5f5c2c068cd5d96f1deb3c4=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Assaf=20Gordon=20=0A= Date:=20Sat,=207=20Jan=202017=2023:05:07=20-0500=0ASubject:=20[PATCH]=20= build:=20skip=20building=20man=20page=20if=20needed=0A=0ASkip=20building=20= the=20man=20page=20if=20building=20from=20tarball=20(where=20'doc/sed.1'=0A= is=20already=20prebuilt).=20Build=20a=20stub=20if=20building=20from=20= git=20but=20generating=0Athe=20man=20page=20isn't=20possible=20(if=20= there's=20no=20Perl=20or=20cross-compiling).=0ACross-compilation=20issue=20= reported=20by=20Vishal=20Biswas=20in=0Ahttps://bugs.gnu.org/25358=20.=0A= Problematic=20'perl'=20is=20related=20to=20https://bugs.gnu.org/25367=20= .=0A=0A*=20configure.ac:=20Check=20for=20Perl,=20cross-compilation=20and=20= tarball=20build;=0ASet=20automake=20variable=20BUILD_MAN_PAGE,=20= BUILD_DUMMY_MAN_PAGE=20accordingly.=0A*=20doc/local.mk=20(doc/sed.1):=20= Build=20conditionally=20if=20BUILD_MAN_PAGE=20is=20true;=0ACreate=20a=20= dummy=20man=20page=20if=20BUILD_DUMMY_MAN_PAGE=20is=20true.=0A*=20= doc/sed-dummy.1:=20Stub=20man=20page.=0A---=0A=20configure.ac=20=20=20=20= |=2031=20+++++++++++++++++++++++++++++++=0A=20doc/local.mk=20=20=20=20|=20= 14=20+++++++++++++-=0A=20doc/sed-dummy.1=20|=2017=20+++++++++++++++++=0A=20= 3=20files=20changed,=2061=20insertions(+),=201=20deletion(-)=0A=20create=20= mode=20100644=20doc/sed-dummy.1=0A=0Adiff=20--git=20a/configure.ac=20= b/configure.ac=0Aindex=209974e53..8076382=20100644=0A---=20= a/configure.ac=0A+++=20b/configure.ac=0A@@=20-294,6=20+294,37=20@@=20if=20= test=20"$gl_gcc_warnings"=20=3D=20yes;=20then=0A=20=20=20= AC_SUBST([GNULIB_TEST_WARN_CFLAGS])=0A=20fi=0A=20=0A= +AM_CONDITIONAL([CROSS_COMPILING],=20[test=20"$cross_compiling"=20=3D=20= yes])=0A+=0A+#=20Perl=20is=20needed=20for=20help2man=0A= +AC_PATH_PROG([PERL],=20[perl])=0A+=0A+#=20building=20from=20tarball?=0A= +built_from_tarball=3Dno=0A+test=20-f=20"$srcdir"/.tarball-version=20&&=20= \=0A+=20=20!=20test=20-d=20"$srcdir/.git"=20&&=20\=0A+=20=20= built_from_tarball=3Dyes=0A+=0A+#=20Can=20the=20man=20page=20be=20built?=0A= +#=20Perl=20needed=20for=20help2man,=20executing=20sed=20needed=20for=20= 'sed=20--help'=0A+can_rebuild_man_page=3Dno=0A+test=20-n=20"$PERL"=20&&=20= \=0A+=20=20test=20"$cross_compiling"=20!=3D=20yes=20&&=20\=0A+=20=20= can_rebuild_man_page=3Dyes=0A+=0A+#=20Build=20the=20man=20page=20when=0A= +#=20building=20from=20git=20and=20rebuilding=20is=20possible.=0A= +AM_CONDITIONAL([BUILD_MAN_PAGE],=0A+=20[test=20"$built_from_tarball"=20= =3D=20no=20&&=20\=0A+=20=20=20=20test=20"$can_rebuild_man_page"=20=3D=20= yes])=0A+=0A+#=20Create=20a=20stub=20man=20page=20instead=20of=20failing=20= when=0A+#=20building=20from=20git=20and=20rebuilding=20is=20not=20= possible.=0A+AM_CONDITIONAL([BUILD_DUMMY_MAN_PAGE],=0A+=20[test=20= "$built_from_tarball"=20=3D=20no=20&&=20\=0A+=20=20=20=20test=20= "$can_rebuild_man_page"=20=3D=20no])=0A+=0A+=0A=20#=20This=20is=20needed=20= when=20building=20outside=20the=20source=20dir=0A=20#=20with=20= --disable-dependency-tracking,=20see=20https://bugs.gnu.org/25371=0A=20= AS_MKDIR_P([lib])=0Adiff=20--git=20a/doc/local.mk=20b/doc/local.mk=0A= index=2009d1719..0c5f5de=20100644=0A---=20a/doc/local.mk=0A+++=20= b/doc/local.mk=0A@@=20-16,12=20+16,13=20@@=0A=20info_TEXINFOS=20=3D=20= doc/sed.texi=0A=20doc_sed_TEXINFOS=20=3D=20doc/config.texi=20= doc/version.texi=20doc/fdl.texi=0A=20dist_man_MANS=20=3D=20doc/sed.1=0A= -dist_noinst_DATA=20=3D=20doc/sed.x=0A+dist_noinst_DATA=20=3D=20= doc/sed.x=20doc/sed-dummy.1=0A=20HELP2MAN=20=3D=20= $(top_srcdir)/build-aux/help2man=0A=20SEDBIN=20=3D=20sed/sed=0A=20=0A=20= AM_MAKEINFOHTMLFLAGS=20=3D=20--no-split=0A=20=0A+if=20BUILD_MAN_PAGE=0A=20= doc/sed.1:=20sed/sed$(EXEEXT)=20.version=20$(srcdir)/doc/sed.x=0A=20=09= $(AM_V_GEN)$(MKDIR_P)=20doc=0A=20=09$(AM_V_at)rm=20-rf=20$@=20$@-t=0A@@=20= -31,3=20+32,14=20@@=20doc/sed.1:=20sed/sed$(EXEEXT)=20.version=20= $(srcdir)/doc/sed.x=0A=20=09=20=20=20=20-o=20$@-t=20$(SEDBIN)=09=09=09=09= =09=09\=0A=20=09=20=20&&=20chmod=20a-w=20$@-t=09=09=09=09=09=09\=0A=20=09= =20=20&&=20mv=20$@-t=20$@=0A+else=20!BUILD_MAN_PAGE=0A+=0A+if=20= BUILD_DUMMY_MAN_PAGE=0A+doc/sed.1:=20doc/sed-dummy.1=0A+=09= $(AM_V_at)$(SED)=20\=0A+=09=20=20=20=20=20=20=20=20=20=20=20=20= 's/VERSION/@PACKAGE_VERSION@/'=20$<=20>=20$@-t=09=09\=0A+=09=20=20&&=20= chmod=20a-w=20$@-t=09=09=09=09=09=09\=0A+=09=20=20&&=20mv=20$@-t=20$@=0A= +endif=20BUILD_DUMMY_MAN_PAGE=0A+=0A+endif=20!BUILD_MAN_PAGE=0Adiff=20= --git=20a/doc/sed-dummy.1=20b/doc/sed-dummy.1=0Anew=20file=20mode=20= 100644=0Aindex=200000000..3832baf=0A---=20/dev/null=0A+++=20= b/doc/sed-dummy.1=0A@@=20-0,0=20+1,17=20@@=0A+.TH=20SED=20"1"=20= "VERSION"=20"User=20Commands"=0A+.SH=20NAME=0A+sed=20\-=20stream=20= editor=20for=20filtering=20and=20transforming=20text=0A+.SH=20SYNOPSIS=0A= +.B=20sed=0A+[\fIOPTION\fR]...=20\fI{script-only-if-no-other-script}=20= \fR[\fIinput-file\fR]...=0A+.SH=20DESCRIPTION=0A+.B=20OOOPS!=0A+.B=20sed=0A= +manual=20page=20could=20not=20be=20built=20(missing=20perl=20or=0A= +cross-compilation).=0A+.PP=0A+For=20the=20full=20documentation=20for=0A= +.B=20sed=0A+see=0A+.UR=20http://www.gnu.org/software/sed=0A+GNU=20SED=20= Website=20(http://www.gnu.org/software/sed)=0A--=20=0A2.10.2=0A=0A= --Apple-Mail=_95DE48BF-1163-4CE6-9F5A-AD4DF626EF47 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii --Apple-Mail=_95DE48BF-1163-4CE6-9F5A-AD4DF626EF47-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 10 09:13:10 2017 Received: (at 25358) by debbugs.gnu.org; 10 Jan 2017 14:13:10 +0000 Received: from localhost ([127.0.0.1]:48475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQxAk-0002Rr-3K for submit@debbugs.gnu.org; Tue, 10 Jan 2017 09:13:10 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:36177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQxAh-0002RU-PA for 25358@debbugs.gnu.org; Tue, 10 Jan 2017 09:13:08 -0500 Received: by mail-it0-f67.google.com with SMTP id n68so12827389itn.3 for <25358@debbugs.gnu.org>; Tue, 10 Jan 2017 06:13:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=DTPO5aRA93flxjql98MkruY6JgpLjo7JJfIucJJV7l8=; b=ahoTAlTZ6V0WRe3JgoT3IoqvVuH5k9G/3jvjKo43slsFUqiPafywkg0xXFuM9Q2pD9 vJFhlWIMZ1sN9fIEkG9ZtMCtdWGubQgVT1uyKpFfi349a90NSMK/WIyMFWJaqHjj0Crc /J5JwRZr2hvPtMdDDxg8R/tSNs3z7SXPJzuRgkJvvbaFG6xncD6L1sMnZyzieK6SnJ7F IdcXy8XME+m6qma20Ypdthl06q0cGMUlH3ywpBfxHGy1OpZ07QlKP5H/PV/aEeBvIDh5 OKYxWBlaQUihlJa7qLvXB6E8cXY1gO2fyzszRS1ZgFWPwzEetRtK/S+jktBkMu2ak0yS jomg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=DTPO5aRA93flxjql98MkruY6JgpLjo7JJfIucJJV7l8=; b=pGi4RuBAcCZyr/zASSEXy+f0iC70eVjMl2s975r22i1pwBYX5j0NSAXQVsSUtPDOMs 3FhEuU37Vebh5SywORASfWjZ8aCN/sIyDaKxhnHAwZXwuKc4qz43e7aDypFUBnTDRhS3 CbOlJl6O0g1QNb1+K3EYCJES52c39ujyGNySTrg7wa1VFHm1M9gMzTR/SbKcH0ibxeps VZkOZ67eU01p+V7smk61cCBXz+UyaRt7hKkTq1ubuo4eVjL0TUnm/z5w6flg6IS+VaqY TPhVQRSB2QpmYXZVdAb14UOSz0w9CqPTgHSAPD+D6q5ZgRODTfS51tcAuUQOqcf2UvoE ORpA== X-Gm-Message-State: AIkVDXLHYh5S0envDljomS6U7+huhnD0ZWbpXvLsbQ1mGRWDNsLrDFQd54mS3dQEnsbo4Kb2dxGqDj9BJ+Ri6Q== X-Received: by 10.36.105.193 with SMTP id e184mr3483021itc.31.1484057581811; Tue, 10 Jan 2017 06:13:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.191.5 with HTTP; Tue, 10 Jan 2017 06:12:41 -0800 (PST) In-Reply-To: <3D6ED03F-FA9A-4631-A993-79C5FE8FB66C@gmail.com> References: <4383906.jovR5H9Ice@vishal-pc> <29df7d15-5f3e-72dc-9ed6-d85d02731230@gmail.com> <935000C9-2B9F-4326-900D-F7802A8BAE75@gmail.com> <3D6ED03F-FA9A-4631-A993-79C5FE8FB66C@gmail.com> From: Jim Meyering Date: Tue, 10 Jan 2017 06:12:41 -0800 X-Google-Sender-Auth: RgQEfCCL_vEVOEXNSbkhBmDoM88 Message-ID: Subject: Re: bug#25358: Cross Compiling fails because of help2man To: Assaf Gordon Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25358 Cc: Vishal Biswas , 25358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Mon, Jan 9, 2017 at 7:28 PM, Assaf Gordon wrote: > Hello, > >> On Jan 9, 2017, at 09:23, Jim Meyering wrote: >> >> On Sun, Jan 8, 2017 at 5:23 AM, Assaf Gordon wrote: >>> The attach suggested patch adds all three cases to 'configure.ac', >>> and 'doc/sed.1' is build conditionally. >> >> Not sure it's worth it, but adding an "else" block to that "if >> BUILD_MAN_PAGE" (with a rule that fails with a diagnostic explaining >> why we cannot build sed.1) may avoid some confusion. Otherwise, all >> they'll get is a failed build (no rule to make...), and may think it's >> a bug and report it. > > I think that n the case of building from tarball - it won't fail because 'doc/sed.1' already exists. > But in the other cases there will be an clear failure. > > The attach patch handles these cases specifically, and creates a dummy man page instead of failing. Nice solution. Thank you. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 10 20:10:34 2017 Received: (at 25358) by debbugs.gnu.org; 11 Jan 2017 01:10:34 +0000 Received: from localhost ([127.0.0.1]:49237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cR7Qw-0005Zz-1b for submit@debbugs.gnu.org; Tue, 10 Jan 2017 20:10:34 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:36808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cR7Qt-0005Zm-Ml for 25358@debbugs.gnu.org; Tue, 10 Jan 2017 20:10:32 -0500 Received: by mail-qt0-f195.google.com with SMTP id l7so18256090qtd.3 for <25358@debbugs.gnu.org>; Tue, 10 Jan 2017 17:10:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=/Zmq0zK9Z+d7iwNd5qO4n8tndJHIF5Te1W77b33x/PM=; b=XdW7CK3aDVutLs7yATEgzMNNUgSiy4fM8s4nms2veqBNJbdbAUadLNKddbE0mE12cU HRhVKrcG6mVHEeGCNjO/Ap+dR2/I0QyuJcdmF1riWPnoHhTWpT5RPvRmxs9WPp3sYNsT bqT6xZZ6FUJsy1InUd41nfWQY5myZo1ujIcyE1YwoGFXjUPaNR2rMpLHAAo191CtTMB4 WjUUvmSLEWQp/AawYKhASNCcH/ZVoWoCwPqmHp+VwPPlgLu9SZeiC/ps4SOoZUJdq2WL HgmvR44UOM1yPyP00C8ENg7JTdVwyv2XRZ69C0FRLydqFXOWjinAsrtQpXoamGgidkdG JBqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=/Zmq0zK9Z+d7iwNd5qO4n8tndJHIF5Te1W77b33x/PM=; b=XhWIyybFMkHjcLOe3gd0QR4H6qFf0obMm/bZuQpk2fT3xQgYtbTZrex4hfr0MT0Hou ZeUuixWoePmtE8H3S0zR9qQCTbB0Njgw+sDaL6jiYjF0PzM6lwz/e5AuzXpoRT1jgpUd vULrnD2IGp+PvQp5FpvBbFriYAsRTyuvvGCrCprRCEVVpoAy7cZoWCYdxPiU1zTkU19F UZeWjaGlqlAFC467nqjEe/c/9gySk53fQZZfgY2aaJ1h4bjfbY8ovB0uwr254pn/K6RP n6BTAmDnFm4XFwazHGbl7lkPIFviR35f6LqDhUCs4d8ZJU1m9b6LSswdlMuu83wmVmA8 UJGg== X-Gm-Message-State: AIkVDXL3AcUg4/gBt6XClARPWtWvrrihEL3/Nd4gKZPhpRAXiECLonslm9WduKFpcvwOeg== X-Received: by 10.237.39.99 with SMTP id n90mr5269467qtd.66.1484097026176; Tue, 10 Jan 2017 17:10:26 -0800 (PST) Received: from ix.home (pool-100-37-92-116.nycmny.fios.verizon.net. [100.37.92.116]) by smtp.gmail.com with ESMTPSA id m85sm2839190qkl.28.2017.01.10.17.10.24 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 10 Jan 2017 17:10:25 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Subject: Re: bug#25358: Cross Compiling fails because of help2man From: Assaf Gordon In-Reply-To: Date: Tue, 10 Jan 2017 20:10:22 -0500 Content-Transfer-Encoding: quoted-printable Message-Id: <8BD01734-DA11-4C0B-A2E7-8F373BFD2C8E@gmail.com> References: <4383906.jovR5H9Ice@vishal-pc> <29df7d15-5f3e-72dc-9ed6-d85d02731230@gmail.com> <935000C9-2B9F-4326-900D-F7802A8BAE75@gmail.com> <3D6ED03F-FA9A-4631-A993-79C5FE8FB66C@gmail.com> To: Jim Meyering , Vishal Biswas X-Mailer: Apple Mail (2.2102) X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 25358 Cc: 25358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) tag 25358 fixed close 25358 thanks Thank you for the review. Pushed here: = http://git.savannah.gnu.org/cgit/sed.git/commit/?id=3Da0a25e3ee35f5071d5f5= c2c068cd5d96f1deb3c4 regards, - assaf From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 24 18:32:30 2017 Received: (at control) by debbugs.gnu.org; 24 Jan 2017 23:32:30 +0000 Received: from localhost ([127.0.0.1]:41080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWAZi-0000uw-62 for submit@debbugs.gnu.org; Tue, 24 Jan 2017 18:32:30 -0500 Received: from mail-qk0-f171.google.com ([209.85.220.171]:36196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWAZh-0000ui-3w for control@debbugs.gnu.org; Tue, 24 Jan 2017 18:32:29 -0500 Received: by mail-qk0-f171.google.com with SMTP id 11so58584990qkl.3 for ; Tue, 24 Jan 2017 15:32:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:message-id:mime-version:content-disposition:user-agent; bh=tGpForb//DT1LalNRZNmuPB1BkHswkrXciNwHlizIlI=; b=Ak8rqMoM7uKC3XNbEehocb9fBoJje9C03tGws8usfD1A4SAKW48c8gGY5Uc0Qbxo2v 6RTW6Qmpqpv8fQVu5rJzJQgJZARqhqyEOZv+88Piwu7UIKwIGvqVeNiUfAxA175dEP01 WK0tQv94wtRqCqezjo9gIO7xDTeCHhh0hxKfoXfR3O941pl2fT88CbuynPL4/wCmNcCV JOVGMCaNMKMA6em5m2RBZsdNzAGd9EV65Bxrhn0/X+pt0QWdsEOBVCrnYXcHAuFBARfl mpT3c9MNvwLbw7+77WNMxxv51djCBwTUGWoL7AOXaCneTGipbyeiCnpxb0k00OSFmIEO /mdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:message-id:mime-version :content-disposition:user-agent; bh=tGpForb//DT1LalNRZNmuPB1BkHswkrXciNwHlizIlI=; b=e0FTMjf5UddyCmuXqswO5EgYSORupSDA/kpZ0BiR61RqMN1JS/RwWBo+KzxKTNaVaD NPQJdD1NNPORDU+DzxjLJOag2uxSSes5NSojY+OUCnnBXwQ2iayVJH482NeFQ1+pYmTc +7GJb7mcsvlKq0hlBMFy6+Art8mLlbibbPB9gnBC1WK0YEI8hPdDQ53PJ+OUxJiQ+3Wh phQBKb+uDg9nRPqFSHNJBJyIesHqQIuv4AG9qYzPzbGFz2qf7xRk97+jt3X046bnTPXr SwZMTVYDnBPuHcNyL6QAszWuc8iyVGvsWVJJZiGJL70zAIdWndTOa/JZKHsqIrRHTi/x N8ng== X-Gm-Message-State: AIkVDXLX8Lt0cybcYamonPqh5Ee+ObGoYdotBm+M5mTTu4YR0yJAwFEsONL8zsXAJxAk7Q== X-Received: by 10.55.148.71 with SMTP id w68mr26274630qkd.130.1485300743495; Tue, 24 Jan 2017 15:32:23 -0800 (PST) Received: from gmail.com (housegordon.org. [104.236.108.240]) by smtp.gmail.com with ESMTPSA id h33sm16008837qtc.42.2017.01.24.15.32.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Jan 2017 15:32:23 -0800 (PST) Date: Tue, 24 Jan 2017 23:31:52 +0000 From: Assaf Gordon To: control@debbugs.gnu.org Message-ID: <20170124233152.GB9668@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.8 (/) tags 20572 notabug close 20572 tags 20684 notabug close 20684 tags 20786 fixed close 20786 tags 22943 notabug close 22943 tags 23415 notabug close 23415 tags 23493 notabug close 23493 tag 23832 notabug close 23832 tag 23848 fixed close 23848 tag 24072 notabug close 24072 tag 25358 fixed close 25358 tag 25371 fixed close 25371 tag 25377 fixed close 25377 tag 25390 fixed close 25390 stop From unknown Sun Jun 22 11:33:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 22 Feb 2017 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator