GNU bug report logs - #25351
26.0.50; Testcover doesn't work on code that creates simple lists and modifies them

Previous Next

Package: emacs;

Reported by: Gemini Lasswell <gazally <at> runbox.com>

Date: Wed, 4 Jan 2017 03:07:01 UTC

Severity: normal

Tags: patch

Found in version 26.0.50

Done: Gemini Lasswell <gazally <at> runbox.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Gemini Lasswell <gazally <at> runbox.com>
To: 25351 <at> debbugs.gnu.org
Subject: bug#25351: Patch for bug#25351: 26.0.50; Testcover doesn't work on code that creates simple lists and modifies them
Date: Tue, 26 Sep 2017 14:04:13 -0700
[Message part 1 (text/plain, inline)]
Here is a patch which fixes this bug by making a copy of the result of
the first evaluation of a form to compare with the results of
subsequent evaluations.

This patch is based on the two patches I sent yesterday to bug#25316.

Because Testcover may encounter circular structures in the code it
instruments, I wrote a modified version of copy-tree which can handle
circular structures. It's possibly generally useful enough to belong
in subr.el alongside copy-tree instead of being an internal Testcover
function, but I will submit that idea as a separate wishlist item.

There isn't currently a version of `equal' which works for circular
structures, so Testcover's handling of them is not fully implemented,
but it now avoids stopping the code under coverage with an error
message.

[0001-Stop-Testcover-from-producing-spurious-1value-errors.patch (text/plain, attachment)]

This bug report was last modified 7 years and 228 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.