From unknown Tue Aug 12 08:33:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25349: 25.1.90; erc join -vs- passwords Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jan 2017 00:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25349 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 25349@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.148348795624884 (code B ref -1); Wed, 04 Jan 2017 00:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Jan 2017 23:59:16 +0000 Received: from localhost ([127.0.0.1]:40661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOYz5-0006TI-H5 for submit@debbugs.gnu.org; Tue, 03 Jan 2017 18:59:16 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48867) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOYz3-0006T2-Gy for submit@debbugs.gnu.org; Tue, 03 Jan 2017 18:59:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOYyw-0005K7-OG for submit@debbugs.gnu.org; Tue, 03 Jan 2017 18:59:08 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57079) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cOYyw-0005Jz-KP for submit@debbugs.gnu.org; Tue, 03 Jan 2017 18:59:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOYyu-0006hW-F5 for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2017 18:59:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOYyr-0005H2-AO for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2017 18:59:04 -0500 Received: from gproxy7-pub.mail.unifiedlayer.com ([70.40.196.235]:48159) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1cOYyq-00057S-RX for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2017 18:59:01 -0500 Received: (qmail 1619 invoked by uid 0); 3 Jan 2017 23:58:26 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy7.mail.unifiedlayer.com with SMTP; 3 Jan 2017 23:58:26 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id TzyG1u00l2f2jeq01zyK9Q; Tue, 03 Jan 2017 16:58:22 -0700 X-Authority-Analysis: v=2.1 cv=It+NLtPg c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IgFoBzBjUZAA:10 a=pQs5aej7AAAA:8 a=xGD7EAh91r10B7pJvHwA:9 a=OdvcLBuiQaLYJWf9:21 a=FSjZ6CAghlW15IVe:21 a=Aan7rn3zuj8km_mHUhxA:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From; bh=0gTqQ+e6IyAd7TRC3f0DMhRKvvvbXyK/tPDGGZAVxRo=; b=UTtnbhNFzHTYC4CB09+lx8trdF V6QFajvqA0ClA0S/C47BhTrGDRm1nzR8SSnmSQgFEsqBHQ72LbdcBo1N9p77KUHKpsVGlJjSyXYDU axinQoiV7fhtGvdeZjB3nlsMi; Received: from 174-16-146-181.hlrn.qwest.net ([174.16.146.181]:40478 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cOXdU-0001qf-L7; Tue, 03 Jan 2017 15:32:52 -0700 From: Tom Tromey X-Attribution: Tom Date: Tue, 03 Jan 2017 15:32:48 -0700 Message-ID: <87d1g3u63z.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.146.181 X-Exim-ID: 1cOXdU-0001qf-L7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-146-181.hlrn.qwest.net (pokyo) [174.16.146.181]:40478 X-Source-Auth: tom+tromey.com X-Email-Count: 0 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I'm using erc and joining a channel that has a channel password. I've tried to put the password in my ~/.authinfo. However, there are two erc bugs that prevent this from working. 1. In erc-join.el, various functions do: (or erc-server-announced-name erc-session-server) I think this is backward -- the announced name is the real name of the host, but this can vary, so isn't useful as a .authinfo key. e.g., for me, erc-server-announced-name is currently "belew.mozilla.org" but erc-session-server is "irc.mozilla.org" -- which is what I used to connect and is the name I'd want to use in .authinfo. Changing the instances of this in erc-join.el makes auto-join work for me. 2. erc-cmd-JOIN does not check authinfo at all. Maybe it should share this code with erc-join.el. In GNU Emacs 25.1.90.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.20.9) of 2016-12-15 built on pokyo Repository revision: 467768f64ee109fe127619e75fee7f3b5de1fec1 Windowing system distributor 'Fedora Project', version 11.0.11804000 System Description: Fedora release 24 (Twenty Four) Configured using: 'configure --prefix=/home/tromey/Emacs/install --with-file-notifications=no' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GCONF GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: JS Minor modes in effect: erc-spelling-mode: t erc-truncate-mode: t diff-auto-refine-mode: t shell-dirtrack-mode: t flyspell-mode: t which-function-mode: t projectile-global-mode: t projectile-mode: t erc-notify-mode: t erc-notifications-mode: t erc-services-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-netsplit-mode: t erc-hl-nicks-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t flycheck-mode: t savehist-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t auto-fill-function: do-auto-fill transient-mark-mode: t Recent messages: Expiring articles...done Are you sure you want to quit reading news? (y or n) y Saving Gnus registry (73035 entries) to ~/.gnus.registry.eieio... Saving Gnus registry (size 73035) to ~/.gnus.registry.eieio...done Saving file /home/tromey/.newsrc... Wrote /home/tromey/.newsrc Saving /home/tromey/.newsrc.eld... Saving file /home/tromey/.newsrc.eld... Wrote /home/tromey/.newsrc.eld Saving /home/tromey/.newsrc.eld...done Load-path shadows: /home/tromey/.emacs.d/elpa/bubbles-0.5/bubbles hides /home/tromey/Emacs/install/share/emacs/25.1.90/lisp/play/bubbles Features: (shadow emacsbug debug ffap conf-mode css-mode descr-text gud eieio-opt speedbar sb-image ezimage dframe vc-annotate macros dwarf-mode rust-mode doctor gnus-fun find-dired dxr tabify man perl-mode sh-script smie executable smerge-mode etags xref project git-commit-mode find-file js sgml-mode iso-transl mailalias bbdb-sc supercite regi mail-hist nnir idutils python tramp-sh tramp tramp-compat tramp-loaddefs trampver ucs-normalize git-rebase-mode derived term/xterm xterm org-element org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view jka-compr image-mode org-bibtex bibtex org-bbdb org-w3m org org-macro org-footnote org-pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs log-view gnus-html url-cache mm-url shr-color url-http url url-proxy url-privacy url-history url-auth url-cookie url-domsuf url-gw url-expand url-methods url-util url-parse url-vars shr dom browse-url erc-spelling erc-truncate bbdb-gui bbdb-hooks bbdb-rmail rmailsum rmail vc-mtn vc-hg sort smiley gnus-cite flow-fill mm-archive gnus-async gnus-bcklg qp gnus-ml disp-table gnus-topic nndraft nnmh nnfolder utf-7 bbdb-gnus bbdb-snarf mail-extr bbdb-com network-stream nsm starttls gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache gnus-registry registry eieio-compat eieio-base gnus-art mm-uu mml2015 mm-view mml-smime smime dig mailcap gnus-sum gnus-group gnus-undo smtpmail sendmail gnus-start gnus-cloud nnimap nnmail mail-source tls gnutls utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range gnus-win gnus gnus-ems nnheader dabbrev log-edit message idna rfc822 mml mml-sec epg mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils mailheader pcvs-util copyright misearch multi-isearch add-log bug-reference vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs vc-git diff-mode cc-mode cc-fonts cc-guess cc-menus cc-cmds shell flyspell ispell diminish appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs which-func imenu edmacro kmacro projectile grep compile ibuf-ext ibuffer minimap autorevert filenotify desktop frameset cus-start cus-load erc-notify erc-desktop-notifications notifications dbus xml erc-services erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete pcomplete erc-track erc-match erc-netsplit erc-hl-nicks easy-mmode color erc-button erc-fill erc-stamp wid-edit erc-goodies erc erc-backend erc-compat format-spec auth-source cl-seq eieio gnus-util mm-util help-fns mail-prsvr password-cache thingatpt pp status dired-aux dired-x dired warnings advice vc-dir ewoc vc vc-dispatcher flycheck json map find-func rx subr-x dash cc-styles cc-align cc-engine cc-vars cc-defs bbdb cl timezone ange-ftp comint ansi-color ring server savehist finder-inf bbdb-autoloads dwarf-mode-autoloads eieio-core cl-macs lisppaste-autoloads pydoc-info-autoloads info-look weblogger-autoloads info package epg-config seq byte-opt gv bytecomp byte-compile cl-extra help-mode easymenu cconv cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 4956169 2764016) (symbols 48 147899 536) (miscs 40 49685 30197) (strings 32 1374486 796506) (string-bytes 1 59281313) (vectors 16 171120) (vector-slots 8 4046984 214559) (floats 8 1121 2125) (intervals 56 350578 9418) (buffers 976 761) (heap 1024 613853 395688)) Tom From unknown Tue Aug 12 08:33:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25349: 25.1.90; erc join -vs- passwords Resent-From: Nikolay Kudryavtsev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jan 2017 03:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25349 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tom Tromey , 25349@debbugs.gnu.org Received: via spool by 25349-submit@debbugs.gnu.org id=B25349.148350169412689 (code B ref 25349); Wed, 04 Jan 2017 03:49:01 +0000 Received: (at 25349) by debbugs.gnu.org; 4 Jan 2017 03:48:14 +0000 Received: from localhost ([127.0.0.1]:40707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOcYg-0003Ib-AN for submit@debbugs.gnu.org; Tue, 03 Jan 2017 22:48:14 -0500 Received: from mail-lf0-f52.google.com ([209.85.215.52]:36686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOcYe-0003IO-9D for 25349@debbugs.gnu.org; Tue, 03 Jan 2017 22:48:13 -0500 Received: by mail-lf0-f52.google.com with SMTP id x140so220934lfa.3 for <25349@debbugs.gnu.org>; Tue, 03 Jan 2017 19:48:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=nMlti7s2438xCdmfLUk5kMDc2HolZfx/F7DHsHz/0wA=; b=LvJ138NEpoEW4sB+Yoo0a23Pdeu4jQJrlAh2Uv5qetEDWCl+QtoDdw5mnnHRanKMXV Nc+vkRbEWox5g9m1Zh7fe6uce2rOQCtie5eEwHyol5XUBxCs1FFHpNMZ29iWfQ5q4KiG PH2rDviFoSMm5mY3tsIxnqfmrHQB5QCrrLsx7ZuC8kMYRQ/Rafy+1N1wMYNbE7+765E1 NBMMDDXBsTcFh5I8rIoWpFRHty9s+gES4f0Hw1ce4OCP4wkAwvmy+L1PPQSw83JVVTJR 9yMJvd5DH7q4lbOfwsYB2lHyNK8HP4rk8yD1nHY6vmq0ug6xW8Wv2HX+UwYQ0Beboytt DTIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=nMlti7s2438xCdmfLUk5kMDc2HolZfx/F7DHsHz/0wA=; b=U5WWEsGJf+L5ceHEMGHibhJMdRTJ8vLvHPFNdzhvmfX7vN88KHgZTULWBAFb0ABS2b a+P0jK88kg8w3jJNGUlX+0r5L/77SJKsVzu3bTra5p2kBwy9XIreNqnmKhC5nrPjYhw4 0H9BmyqmGxI9ftc1+89/OkeSZcloYa+2AKO2b/Dnbktd4cIkHHjF+3ywvjiHuWlcepN3 4q3IEMm4yDFKBih1RDlwwpxyatxVtUHy6vrsB9Tbhf/pPnItIpzoYmj9weRyVnXf7p14 S55cTkc1okCO1YoqnFmOfNZjUrybi9y0Y7qPzMIkhS7+wphRUm7JjQmpfhig27Ywrp81 19Hg== X-Gm-Message-State: AIkVDXLPkiNE2tI9XdK+xS6/4Fa/Pq1Rzdeyxl3eM53JyC9OIedp+3lhUbyGwvtKl8ySaw== X-Received: by 10.25.8.6 with SMTP id 6mr17609874lfi.48.1483501685666; Tue, 03 Jan 2017 19:48:05 -0800 (PST) Received: from [192.168.199.6] (broadband-95-84-209-126.nationalcablenetworks.ru. [95.84.209.126]) by smtp.gmail.com with ESMTPSA id t25sm11578109lja.38.2017.01.03.19.48.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jan 2017 19:48:04 -0800 (PST) From: Nikolay Kudryavtsev X-Google-Original-From: Nikolay Kudryavtsev References: <87d1g3u63z.fsf@tromey.com> Message-ID: <02a0b060-c061-4bf6-849b-5c05c5d4b670@gmail.com> Date: Wed, 4 Jan 2017 06:47:59 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <87d1g3u63z.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Using authinfo.gpg works fine for me(and lots of other people). There's probably a problem in your configuration. Try setting auth-source-debug to a more verbose level and see what messages you get. -- Best Regards, Nikolay Kudryavtsev From unknown Tue Aug 12 08:33:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25349: 25.1.90; erc join -vs- passwords Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jan 2017 11:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25349 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Nikolay Kudryavtsev Cc: 25349@debbugs.gnu.org, Tom Tromey Received: via spool by 25349-submit@debbugs.gnu.org id=B25349.148352804721487 (code B ref 25349); Wed, 04 Jan 2017 11:08:02 +0000 Received: (at 25349) by debbugs.gnu.org; 4 Jan 2017 11:07:27 +0000 Received: from localhost ([127.0.0.1]:40751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOjPj-0005aV-93 for submit@debbugs.gnu.org; Wed, 04 Jan 2017 06:07:27 -0500 Received: from gproxy10-pub.mail.unifiedlayer.com ([69.89.20.226]:56606) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1cOjPh-0005aH-SK for 25349@debbugs.gnu.org; Wed, 04 Jan 2017 06:07:26 -0500 Received: (qmail 15042 invoked by uid 0); 4 Jan 2017 11:07:12 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy10.mail.unifiedlayer.com with SMTP; 4 Jan 2017 11:07:12 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id UB781u00F2f2jeq01B7Brd; Wed, 04 Jan 2017 04:07:12 -0700 X-Authority-Analysis: v=2.1 cv=JpVi8qIC c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IgFoBzBjUZAA:10 a=pGLkceISAAAA:8 a=zoGPGCM0qR2P-Oulu-oA:9 a=6kGIvZw6iX1k4Y-7sg4_:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=Q85vOpwBAG1UJgEQCzbT9CECYoVa8319IVfDvRpHxdw=; b=lmrXurOJrKl1+V8/CdOON0CX6i DOWGX0AR80hbblWjuGndirUG5X01YsGgB0bu81W/hugMKk0QWQGyMWgtwJXA4Rvcw+Y+es4arDBTs vhMqPZl3WULMoP6/JDZJgKAR8; Received: from 174-16-146-181.hlrn.qwest.net ([174.16.146.181]:42364 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cOjPQ-0004RV-81; Wed, 04 Jan 2017 04:07:08 -0700 From: Tom Tromey References: <87d1g3u63z.fsf@tromey.com> <02a0b060-c061-4bf6-849b-5c05c5d4b670@gmail.com> X-Attribution: Tom Date: Wed, 04 Jan 2017 04:07:07 -0700 In-Reply-To: <02a0b060-c061-4bf6-849b-5c05c5d4b670@gmail.com> (Nikolay Kudryavtsev's message of "Wed, 4 Jan 2017 06:47:59 +0300") Message-ID: <878tqrt76s.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.146.181 X-Exim-ID: 1cOjPQ-0004RV-81 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-146-181.hlrn.qwest.net (pokyo) [174.16.146.181]:42364 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) >>>>> "Nikolay" == Nikolay Kudryavtsev writes: Nikolay> Using authinfo.gpg works fine for me(and lots of other Nikolay> people). There's probably a problem in your configuration. Nikolay> Try setting auth-source-debug to a more verbose level and see what Nikolay> messages you get. What I did is debug erc-server-join-channel and notice that it was passing in the wrong server name. Are you specifically using authinfo with erc and a channel password? Tom From unknown Tue Aug 12 08:33:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25349: 25.1.90; erc join -vs- passwords Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jan 2017 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25349 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tom Tromey Cc: 25349@debbugs.gnu.org X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.148354290726386 (code B ref -1); Wed, 04 Jan 2017 15:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jan 2017 15:15:07 +0000 Received: from localhost ([127.0.0.1]:41275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOnHO-0006rV-HB for submit@debbugs.gnu.org; Wed, 04 Jan 2017 10:15:06 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOnHM-0006qi-9O for submit@debbugs.gnu.org; Wed, 04 Jan 2017 10:15:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOnHF-00061r-Ns for submit@debbugs.gnu.org; Wed, 04 Jan 2017 10:14:58 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=BAYES_50,RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55135) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cOnHF-00061e-Lf for submit@debbugs.gnu.org; Wed, 04 Jan 2017 10:14:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOnHE-0000UM-BZ for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2017 10:14:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOnHB-0005wh-6D for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2017 10:14:56 -0500 Received: from gproxy10-pub.mail.unifiedlayer.com ([69.89.20.226]:43663) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1cOnHA-0005vV-Qq for bug-gnu-emacs@gnu.org; Wed, 04 Jan 2017 10:14:53 -0500 Received: (qmail 27169 invoked by uid 0); 4 Jan 2017 15:13:26 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy10.mail.unifiedlayer.com with SMTP; 4 Jan 2017 15:13:26 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id UFDJ1u00l2f2jeq01FDMSd; Wed, 04 Jan 2017 08:13:26 -0700 X-Authority-Analysis: v=2.1 cv=JpVi8qIC c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IgFoBzBjUZAA:10 a=zstS-IiYAAAA:8 a=du-0XSF7_GxAfZF4CNEA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=r73ilVUSvA8ZtNyjj38WryY1foTDKIf4huk7HF7lC2k=; b=oOVO3ZMXrw1P7vgIJU6+6RP7iE EgoxeGq8pqnpG7iIBkH/rowwWoGczKOHgZdIKhsjAw7QSdBYiKMPKIPeRC6FA5tE+Qyw5abNmGKrI /cKUJLfDNtKU8ps8QZpY2TWba; Received: from 174-16-146-181.hlrn.qwest.net ([174.16.146.181]:46520 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cOnFe-0008Ci-CG; Wed, 04 Jan 2017 08:13:18 -0700 From: Tom Tromey References: <87d1g3u63z.fsf@tromey.com> X-Attribution: Tom Date: Wed, 04 Jan 2017 08:13:16 -0700 In-Reply-To: <87d1g3u63z.fsf@tromey.com> (Tom Tromey's message of "Tue, 03 Jan 2017 15:32:48 -0700") Message-ID: <871swiuacz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.146.181 X-Exim-ID: 1cOnFe-0008Ci-CG X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-146-181.hlrn.qwest.net (pokyo) [174.16.146.181]:46520 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.5 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.5 (----) >>>>> "Tom" == Tom Tromey writes: Tom> I'm using erc and joining a channel that has a channel password. Tom> I've tried to put the password in my ~/.authinfo. However, there Tom> are two erc bugs that prevent this from working. This patch seems to work for me. Tom diff --git a/lisp/erc/erc-join.el b/lisp/erc/erc-join.el index 151ea15..9474b11 100644 --- a/lisp/erc/erc-join.el +++ b/lisp/erc/erc-join.el @@ -129,7 +129,7 @@ erc-autojoin-after-ident (setq erc--autojoin-timer (erc-cancel-timer erc--autojoin-timer))) (when (eq erc-autojoin-timing 'ident) - (let ((server (or erc-server-announced-name erc-session-server)) + (let ((server (or erc-session-server erc-server-announced-name)) (joined (mapcar (lambda (buf) (with-current-buffer buf (erc-default-target))) (erc-channel-list erc-server-process)))) @@ -166,27 +166,12 @@ erc-autojoin-channels ;; Return nil to avoid stomping on any other hook funcs. nil) -(defun erc-server-join-channel (server channel) - (let* ((secret (plist-get (nth 0 (auth-source-search - :max 1 - :host server - :port "irc" - :user channel)) - :secret)) - (password (if (functionp secret) - (funcall secret) - secret))) - (erc-server-send (concat "JOIN " channel - (if password - (concat " " password) - ""))))) - (defun erc-autojoin-add (proc parsed) "Add the channel being joined to `erc-autojoin-channels-alist'." (let* ((chnl (erc-response.contents parsed)) (nick (car (erc-parse-user (erc-response.sender parsed)))) (server (with-current-buffer (process-buffer proc) - (or erc-server-announced-name erc-session-server)))) + (or erc-session-server erc-server-announced-name)))) (when (erc-current-nick-p nick) (when (and erc-autojoin-domain-only (string-match "[^.\n]+\\.\\([^.\n]+\\.[^.\n]+\\)$" server)) @@ -209,7 +194,7 @@ erc-autojoin-remove (let* ((chnl (car (erc-response.command-args parsed))) (nick (car (erc-parse-user (erc-response.sender parsed)))) (server (with-current-buffer (process-buffer proc) - (or erc-server-announced-name erc-session-server)))) + (or erc-session-server erc-server-announced-name)))) (when (erc-current-nick-p nick) (when (and erc-autojoin-domain-only (string-match "[^.\n]+\\.\\([^.\n]+\\.[^.\n]+\\)$" server)) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index 3dcb7ef..3cc9f52 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -3022,6 +3022,23 @@ erc-cmd-HELP (defalias 'erc-cmd-H 'erc-cmd-HELP) (put 'erc-cmd-HELP 'process-not-needed t) +(defun erc-server-join-channel (server channel &optional secret) + (let* ((secret (or secret + (plist-get (nth 0 (auth-source-search + :max 1 + :host server + :port "irc" + :user channel)) + :secret))) + (password (if (functionp secret) + (funcall secret) + secret))) + (erc-log (format "cmd: JOIN: %s" channel)) + (erc-server-send (concat "JOIN " channel + (if password + (concat " " password) + ""))))) + (defun erc-cmd-JOIN (channel &optional key) "Join the channel given in CHANNEL, optionally with KEY. If CHANNEL is specified as \"-invite\", join the channel to which you @@ -3041,10 +3058,9 @@ erc-cmd-JOIN (if (erc-member-ignore-case chnl joined-channels) (switch-to-buffer (car (erc-member-ignore-case chnl joined-channels))) - (erc-log (format "cmd: JOIN: %s" chnl)) - (erc-server-send (if (and chnl key) - (format "JOIN %s %s" chnl key) - (format "JOIN %s" chnl))))))) + (let ((server (with-current-buffer (process-buffer erc-server-process) + (or erc-session-server erc-server-announced-name)))) + (erc-server-join-channel server chnl key)))))) t) (defalias 'erc-cmd-CHANNEL 'erc-cmd-JOIN) From unknown Tue Aug 12 08:33:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25349: 25.1.90; erc join -vs- passwords Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jan 2017 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25349 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tom Tromey Cc: 25349@debbugs.gnu.org, Nikolay Kudryavtsev Received: via spool by 25349-submit@debbugs.gnu.org id=B25349.148354292726421 (code B ref 25349); Wed, 04 Jan 2017 15:16:02 +0000 Received: (at 25349) by debbugs.gnu.org; 4 Jan 2017 15:15:27 +0000 Received: from localhost ([127.0.0.1]:41278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOnHi-0006s4-U7 for submit@debbugs.gnu.org; Wed, 04 Jan 2017 10:15:27 -0500 Received: from gproxy6-pub.mail.unifiedlayer.com ([67.222.39.168]:34265) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1cOnHh-0006rq-I9 for 25349@debbugs.gnu.org; Wed, 04 Jan 2017 10:15:26 -0500 Received: (qmail 32037 invoked by uid 0); 4 Jan 2017 15:15:17 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy6.mail.unifiedlayer.com with SMTP; 4 Jan 2017 15:15:17 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id UFFD1u00C2f2jeq01FFG83; Wed, 04 Jan 2017 08:15:17 -0700 X-Authority-Analysis: v=2.1 cv=SY5kKJhu c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IgFoBzBjUZAA:10 a=du-0XSF7_GxAfZF4CNEA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=bqC5hdV+ra1iel7946soB6lsUQi1mf0KQuo5/bOAlL0=; b=up9pGU/SmkzqTG6Fp73CWHL9L7 DlPjkBpOLIyScax674lGMJ18Hrvi77qzu5mDiu9hPY1PfkXnTcD1GEdj+Tr/M+eBEoqbFv7EqZADc x41renLs0sQR4n/GX3OP82Sb7; Received: from 174-16-146-181.hlrn.qwest.net ([174.16.146.181]:46554 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cOnHU-0004z4-R7; Wed, 04 Jan 2017 08:15:12 -0700 From: Tom Tromey References: <87d1g3u63z.fsf@tromey.com> <02a0b060-c061-4bf6-849b-5c05c5d4b670@gmail.com> <878tqrt76s.fsf@tromey.com> X-Attribution: Tom Date: Wed, 04 Jan 2017 08:15:10 -0700 In-Reply-To: <878tqrt76s.fsf@tromey.com> (Tom Tromey's message of "Wed, 04 Jan 2017 04:07:07 -0700") Message-ID: <87wpeasvpd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.146.181 X-Exim-ID: 1cOnHU-0004z4-R7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-146-181.hlrn.qwest.net (pokyo) [174.16.146.181]:46554 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) I'm not sure if my earlier patch made it through. This seems to work for me. Tom diff --git a/lisp/erc/erc-join.el b/lisp/erc/erc-join.el index 151ea15..9474b11 100644 --- a/lisp/erc/erc-join.el +++ b/lisp/erc/erc-join.el @@ -129,7 +129,7 @@ erc-autojoin-after-ident (setq erc--autojoin-timer (erc-cancel-timer erc--autojoin-timer))) (when (eq erc-autojoin-timing 'ident) - (let ((server (or erc-server-announced-name erc-session-server)) + (let ((server (or erc-session-server erc-server-announced-name)) (joined (mapcar (lambda (buf) (with-current-buffer buf (erc-default-target))) (erc-channel-list erc-server-process)))) @@ -166,27 +166,12 @@ erc-autojoin-channels ;; Return nil to avoid stomping on any other hook funcs. nil) -(defun erc-server-join-channel (server channel) - (let* ((secret (plist-get (nth 0 (auth-source-search - :max 1 - :host server - :port "irc" - :user channel)) - :secret)) - (password (if (functionp secret) - (funcall secret) - secret))) - (erc-server-send (concat "JOIN " channel - (if password - (concat " " password) - ""))))) - (defun erc-autojoin-add (proc parsed) "Add the channel being joined to `erc-autojoin-channels-alist'." (let* ((chnl (erc-response.contents parsed)) (nick (car (erc-parse-user (erc-response.sender parsed)))) (server (with-current-buffer (process-buffer proc) - (or erc-server-announced-name erc-session-server)))) + (or erc-session-server erc-server-announced-name)))) (when (erc-current-nick-p nick) (when (and erc-autojoin-domain-only (string-match "[^.\n]+\\.\\([^.\n]+\\.[^.\n]+\\)$" server)) @@ -209,7 +194,7 @@ erc-autojoin-remove (let* ((chnl (car (erc-response.command-args parsed))) (nick (car (erc-parse-user (erc-response.sender parsed)))) (server (with-current-buffer (process-buffer proc) - (or erc-server-announced-name erc-session-server)))) + (or erc-session-server erc-server-announced-name)))) (when (erc-current-nick-p nick) (when (and erc-autojoin-domain-only (string-match "[^.\n]+\\.\\([^.\n]+\\.[^.\n]+\\)$" server)) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index 3dcb7ef..3cc9f52 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -3022,6 +3022,23 @@ erc-cmd-HELP (defalias 'erc-cmd-H 'erc-cmd-HELP) (put 'erc-cmd-HELP 'process-not-needed t) +(defun erc-server-join-channel (server channel &optional secret) + (let* ((secret (or secret + (plist-get (nth 0 (auth-source-search + :max 1 + :host server + :port "irc" + :user channel)) + :secret))) + (password (if (functionp secret) + (funcall secret) + secret))) + (erc-log (format "cmd: JOIN: %s" channel)) + (erc-server-send (concat "JOIN " channel + (if password + (concat " " password) + ""))))) + (defun erc-cmd-JOIN (channel &optional key) "Join the channel given in CHANNEL, optionally with KEY. If CHANNEL is specified as \"-invite\", join the channel to which you @@ -3041,10 +3058,9 @@ erc-cmd-JOIN (if (erc-member-ignore-case chnl joined-channels) (switch-to-buffer (car (erc-member-ignore-case chnl joined-channels))) - (erc-log (format "cmd: JOIN: %s" chnl)) - (erc-server-send (if (and chnl key) - (format "JOIN %s %s" chnl key) - (format "JOIN %s" chnl))))))) + (let ((server (with-current-buffer (process-buffer erc-server-process) + (or erc-session-server erc-server-announced-name)))) + (erc-server-join-channel server chnl key)))))) t) (defalias 'erc-cmd-CHANNEL 'erc-cmd-JOIN) From unknown Tue Aug 12 08:33:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25349: 25.1.90; erc join -vs- passwords Resent-From: Nikolay Kudryavtsev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Jan 2017 02:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25349 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tom Tromey Cc: 25349@debbugs.gnu.org Received: via spool by 25349-submit@debbugs.gnu.org id=B25349.14835828323010 (code B ref 25349); Thu, 05 Jan 2017 02:21:02 +0000 Received: (at 25349) by debbugs.gnu.org; 5 Jan 2017 02:20:32 +0000 Received: from localhost ([127.0.0.1]:41622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOxfL-0000mU-Un for submit@debbugs.gnu.org; Wed, 04 Jan 2017 21:20:32 -0500 Received: from mail-lf0-f48.google.com ([209.85.215.48]:36090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOxfK-0000mG-Kn for 25349@debbugs.gnu.org; Wed, 04 Jan 2017 21:20:31 -0500 Received: by mail-lf0-f48.google.com with SMTP id x140so18923691lfa.3 for <25349@debbugs.gnu.org>; Wed, 04 Jan 2017 18:20:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=mu3FjnXW8XvbkX0IsEu+8kZqNMpH0OxxXjtjn7lgLGI=; b=bXJmJUc1E+me4GKlHFlFOjL6D3ec7H0cm14gJ7Jqb5lFROtuwmWMuzMUQoUOx7k5Hz uBnh2MVoJfA7WiyHsxO260CtlkAe9LNEDJkkWFj7ZaQcVZKnwyocuSME2hfxo2OGIg2o z6wVAqQ1nLwBseirUHi0wCh65iaYBXo4mJgHSfpIiZqy6gfeOz4MzPwWPASwYyn6MAdI MLmieukglpHvEzIKkg8MzINugCx1lP/ziZ2aJvroWXwjTIEDux7saggKbq6D/YE0bS55 hfa1TUTkHbq6fJ9x6X6I/AIEyq2535B93c31/yGAgDcBLMh01e+jZ0qg9Cj0cqUR2bMk OViw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=mu3FjnXW8XvbkX0IsEu+8kZqNMpH0OxxXjtjn7lgLGI=; b=FK3fvI3hqFgxJc23QhL9SgmeUtJ6cMvk1Zsk5tWdE15931XFzOx+2RgNepy2emPucO hyLAVVvFbBO0wb4we0DaE++wlYOaolDu2b8/z7iHUZ8ZC2vgnxN5JSa9hGWTgs0N47RQ qyI/wrj6GrWmK4MV/qo4PqFT2rk8wLcqe97gTTL9RoqC3lgEKPC3ATozVIT7WOerphab J0byBzGp41GeyqI8gLs+RYwcdcQ9k5bCAIjngRyIcbZW08bFESF4g6UCI12EYSVvyqat aWSOCiPC39kafzlwwB6Y9So/wAvflvMGpm5Vvh3d6pSOptknbiSsYtu4dXFuHKv+9c01 Pqhw== X-Gm-Message-State: AIkVDXK90JhAl1qLU9MiLu+YAkOTC6c6RSKXrd7UBOitarw1mX5FC8KLoGvFzuhQpZni/w== X-Received: by 10.46.32.158 with SMTP id g30mr15783963lji.31.1483582824588; Wed, 04 Jan 2017 18:20:24 -0800 (PST) Received: from [192.168.199.6] (broadband-95-84-209-126.nationalcablenetworks.ru. [95.84.209.126]) by smtp.gmail.com with ESMTPSA id v17sm17915422lja.43.2017.01.04.18.20.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jan 2017 18:20:24 -0800 (PST) From: Nikolay Kudryavtsev X-Google-Original-From: Nikolay Kudryavtsev References: <87d1g3u63z.fsf@tromey.com> <02a0b060-c061-4bf6-849b-5c05c5d4b670@gmail.com> <878tqrt76s.fsf@tromey.com> Message-ID: <4ff90e92-469e-54c1-f4a5-915d188fea13@gmail.com> Date: Thu, 5 Jan 2017 05:20:16 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <878tqrt76s.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Oh, you're talking about password protected channels specifically. I see. Yeah, this patch makes sense. Though one thing - I'm not sure whether you even need to use "or" here. Would there ever be a case where erc-session-server is nil, but there is erc-server-announced-name? -- Best Regards, Nikolay Kudryavtsev From unknown Tue Aug 12 08:33:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25349: 25.1.90; erc join -vs- passwords Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Jan 2017 04:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25349 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Nikolay Kudryavtsev Cc: 25349@debbugs.gnu.org, Tom Tromey Received: via spool by 25349-submit@debbugs.gnu.org id=B25349.148359141222478 (code B ref 25349); Thu, 05 Jan 2017 04:44:01 +0000 Received: (at 25349) by debbugs.gnu.org; 5 Jan 2017 04:43:32 +0000 Received: from localhost ([127.0.0.1]:41676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOztk-0005qS-79 for submit@debbugs.gnu.org; Wed, 04 Jan 2017 23:43:32 -0500 Received: from gproxy4-pub.mail.unifiedlayer.com ([69.89.23.142]:41875) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1cOztj-0005qE-2o for 25349@debbugs.gnu.org; Wed, 04 Jan 2017 23:43:31 -0500 Received: (qmail 3881 invoked by uid 0); 5 Jan 2017 04:43:16 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy4.mail.unifiedlayer.com with SMTP; 5 Jan 2017 04:43:16 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id UUjA1u00F2f2jeq01UjDP1; Wed, 04 Jan 2017 21:43:15 -0700 X-Authority-Analysis: v=2.1 cv=V+Huj4Xi c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IgFoBzBjUZAA:10 a=pGLkceISAAAA:8 a=22q0stdC_CbrioXq-PgA:9 a=6kGIvZw6iX1k4Y-7sg4_:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=Xyo5cOv6If/aYcOgBePPsgwHShq4Oq6uF32lpw4RikE=; b=aT1IOiWBb7P1C8n75EjcdHt/xk 7B4C/uQupNfGED0aahWcM0H3quJMZqQTWps4dd8JVhVNivgW3scqIh1539mC7r2mLkL+n4exTEas7 z0NyZmwFe7acFQVNQmzdcovf2; Received: from 174-16-146-181.hlrn.qwest.net ([174.16.146.181]:43322 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cOztP-0005Ig-EX; Wed, 04 Jan 2017 21:43:11 -0700 From: Tom Tromey References: <87d1g3u63z.fsf@tromey.com> <02a0b060-c061-4bf6-849b-5c05c5d4b670@gmail.com> <878tqrt76s.fsf@tromey.com> <4ff90e92-469e-54c1-f4a5-915d188fea13@gmail.com> X-Attribution: Tom Date: Wed, 04 Jan 2017 21:43:07 -0700 In-Reply-To: <4ff90e92-469e-54c1-f4a5-915d188fea13@gmail.com> (Nikolay Kudryavtsev's message of "Thu, 5 Jan 2017 05:20:16 +0300") Message-ID: <878tqq5d7o.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.146.181 X-Exim-ID: 1cOztP-0005Ig-EX X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-146-181.hlrn.qwest.net (bapiya) [174.16.146.181]:43322 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) >>>>> "Nikolay" == Nikolay Kudryavtsev writes: Nikolay> Though one thing - I'm not sure whether you even need to use "or" Nikolay> here. Would there ever be a case where erc-session-server is nil, but Nikolay> there is erc-server-announced-name? I don't actually know, so I just swapped them out of paranoia. Tom From unknown Tue Aug 12 08:33:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25349: 25.1.90; erc join -vs- passwords Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Jan 2017 22:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25349 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tom Tromey Cc: 25349@debbugs.gnu.org, Nikolay Kudryavtsev Received: via spool by 25349-submit@debbugs.gnu.org id=B25349.14836561879857 (code B ref 25349); Thu, 05 Jan 2017 22:44:01 +0000 Received: (at 25349) by debbugs.gnu.org; 5 Jan 2017 22:43:07 +0000 Received: from localhost ([127.0.0.1]:44075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPGkU-0002Yv-SF for submit@debbugs.gnu.org; Thu, 05 Jan 2017 17:43:07 -0500 Received: from gproxy1-pub.mail.unifiedlayer.com ([69.89.25.95]:41005 helo=gproxy1.mail.unifiedlayer.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPGkS-0002YQ-Hl for 25349@debbugs.gnu.org; Thu, 05 Jan 2017 17:43:04 -0500 Received: from cmgw4 (cmgw5 [10.0.90.85]) by gproxy1.mail.unifiedlayer.com (Postfix) with ESMTP id 892921791EA for <25349@debbugs.gnu.org>; Thu, 5 Jan 2017 15:36:16 -0700 (MST) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id UmcA1u00k2f2jeq01mcDBR; Thu, 05 Jan 2017 15:36:16 -0700 X-Authority-Analysis: v=2.1 cv=SY5kKJhu c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IgFoBzBjUZAA:10 a=IjYE61P0TLU2ikAQ2iAA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=8/4l264AqW/UT7wyOmrRTM9vFSFeJEdJyxmiCA51V8Y=; b=LquwiTr94+AQpQjYVb4lA+N4Tx 0COlRie7PfdN6dprsSLer9sLHkW8dKeYJgHpVkRoYxqiZsJxtG3zVuNEiGJNJAaVc3NVf58fjSaQE 3xl2gHptxt4ATJ6jA3mWRT0mg; Received: from 174-16-146-181.hlrn.qwest.net ([174.16.146.181]:59424 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cPGdm-0003uG-L2; Thu, 05 Jan 2017 15:36:10 -0700 From: Tom Tromey References: <87d1g3u63z.fsf@tromey.com> <02a0b060-c061-4bf6-849b-5c05c5d4b670@gmail.com> <878tqrt76s.fsf@tromey.com> <87wpeasvpd.fsf@tromey.com> X-Attribution: Tom Date: Thu, 05 Jan 2017 15:36:10 -0700 In-Reply-To: <87wpeasvpd.fsf@tromey.com> (Tom Tromey's message of "Wed, 04 Jan 2017 08:15:10 -0700") Message-ID: <87tw9ddtid.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.146.181 X-Exim-ID: 1cPGdm-0003uG-L2 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-146-181.hlrn.qwest.net (pokyo) [174.16.146.181]:59424 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Tom> I'm not sure if my earlier patch made it through. Tom> This seems to work for me. Well, it worked for an explicit /join, but didn't correctly autojoin. I'll try to debug it some more. Tom From unknown Tue Aug 12 08:33:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25349: 25.1.90; erc join -vs- passwords Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Jan 2017 15:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25349 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tom Tromey Cc: 25349@debbugs.gnu.org, Nikolay Kudryavtsev Received: via spool by 25349-submit@debbugs.gnu.org id=B25349.148371567020154 (code B ref 25349); Fri, 06 Jan 2017 15:15:01 +0000 Received: (at 25349) by debbugs.gnu.org; 6 Jan 2017 15:14:30 +0000 Received: from localhost ([127.0.0.1]:45274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPWDt-0005F0-Lf for submit@debbugs.gnu.org; Fri, 06 Jan 2017 10:14:29 -0500 Received: from gproxy3-pub.mail.unifiedlayer.com ([69.89.30.42]:33486) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1cPWDr-0005El-HI for 25349@debbugs.gnu.org; Fri, 06 Jan 2017 10:14:28 -0500 Received: (qmail 14025 invoked by uid 0); 6 Jan 2017 15:14:15 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy3.mail.unifiedlayer.com with SMTP; 6 Jan 2017 15:14:15 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id V3EB1u0282f2jeq013EEbE; Fri, 06 Jan 2017 08:14:15 -0700 X-Authority-Analysis: v=2.1 cv=SY5kKJhu c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IgFoBzBjUZAA:10 a=FGYh4_cPxCD1kSpL9woA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=ZAFgsE4KfT6EA5hd4FkdCwZVQP7F5dhC/JC4CmPkDk8=; b=w2gCHef9B9M/sA+C7wqUnZz471 DGOMQwOczIsWv6z1ROrdeBKECtW/zz9DOZHw+gZz9SgPdJsFTloc3CtqaFqW25uTtZaN34JbyKSwZ SQxKSXqYVryOS4RnmKYp36fvF; Received: from 174-16-146-181.hlrn.qwest.net ([174.16.146.181]:38440 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cPWDb-0003Ly-Kv; Fri, 06 Jan 2017 08:14:11 -0700 From: Tom Tromey References: <87d1g3u63z.fsf@tromey.com> <02a0b060-c061-4bf6-849b-5c05c5d4b670@gmail.com> <878tqrt76s.fsf@tromey.com> <87wpeasvpd.fsf@tromey.com> <87tw9ddtid.fsf@tromey.com> X-Attribution: Tom Date: Fri, 06 Jan 2017 08:14:07 -0700 In-Reply-To: <87tw9ddtid.fsf@tromey.com> (Tom Tromey's message of "Thu, 05 Jan 2017 15:36:10 -0700") Message-ID: <878tqodxvk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.146.181 X-Exim-ID: 1cPWDb-0003Ly-Kv X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-146-181.hlrn.qwest.net (pokyo) [174.16.146.181]:38440 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Tom> Well, it worked for an explicit /join, but didn't correctly autojoin. Tom> I'll try to debug it some more. erc-autojoin-channels was just using the server that was passed in, but it should have been checking erc-session-server instead, like the other code. The appended works for me for both autojoin and explicit join. I want to check it in, but it would probably be good if someone more familiar with ERC took a look at it. Tom diff --git a/lisp/erc/erc-join.el b/lisp/erc/erc-join.el index 151ea15..aa83ffe 100644 --- a/lisp/erc/erc-join.el +++ b/lisp/erc/erc-join.el @@ -129,7 +129,7 @@ erc-autojoin-after-ident (setq erc--autojoin-timer (erc-cancel-timer erc--autojoin-timer))) (when (eq erc-autojoin-timing 'ident) - (let ((server (or erc-server-announced-name erc-session-server)) + (let ((server (or erc-session-server erc-server-announced-name)) (joined (mapcar (lambda (buf) (with-current-buffer buf (erc-default-target))) (erc-channel-list erc-server-process)))) @@ -155,38 +155,24 @@ erc-autojoin-channels ;; `erc-autojoin-timing' is `connect': (dolist (l erc-autojoin-channels-alist) (when (string-match (car l) server) - (dolist (chan (cdr l)) - (let ((buffer (erc-get-buffer chan))) - ;; Only auto-join the channels that we aren't already in - ;; using a different nick. - (when (or (not buffer) - (not (with-current-buffer buffer - (erc-server-process-alive)))) - (erc-server-join-channel server chan))))))) + (let ((server (or erc-session-server erc-server-announced-name))) + (dolist (chan (cdr l)) + (let ((buffer (erc-get-buffer chan))) + ;; Only auto-join the channels that we aren't already in + ;; using a different nick. + (when (or (not buffer) + (not (with-current-buffer buffer + (erc-server-process-alive)))) + (erc-server-join-channel server chan)))))))) ;; Return nil to avoid stomping on any other hook funcs. nil) -(defun erc-server-join-channel (server channel) - (let* ((secret (plist-get (nth 0 (auth-source-search - :max 1 - :host server - :port "irc" - :user channel)) - :secret)) - (password (if (functionp secret) - (funcall secret) - secret))) - (erc-server-send (concat "JOIN " channel - (if password - (concat " " password) - ""))))) - (defun erc-autojoin-add (proc parsed) "Add the channel being joined to `erc-autojoin-channels-alist'." (let* ((chnl (erc-response.contents parsed)) (nick (car (erc-parse-user (erc-response.sender parsed)))) (server (with-current-buffer (process-buffer proc) - (or erc-server-announced-name erc-session-server)))) + (or erc-session-server erc-server-announced-name)))) (when (erc-current-nick-p nick) (when (and erc-autojoin-domain-only (string-match "[^.\n]+\\.\\([^.\n]+\\.[^.\n]+\\)$" server)) @@ -209,7 +195,7 @@ erc-autojoin-remove (let* ((chnl (car (erc-response.command-args parsed))) (nick (car (erc-parse-user (erc-response.sender parsed)))) (server (with-current-buffer (process-buffer proc) - (or erc-server-announced-name erc-session-server)))) + (or erc-session-server erc-server-announced-name)))) (when (erc-current-nick-p nick) (when (and erc-autojoin-domain-only (string-match "[^.\n]+\\.\\([^.\n]+\\.[^.\n]+\\)$" server)) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index 3dcb7ef..3cc9f52 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -3022,6 +3022,23 @@ erc-cmd-HELP (defalias 'erc-cmd-H 'erc-cmd-HELP) (put 'erc-cmd-HELP 'process-not-needed t) +(defun erc-server-join-channel (server channel &optional secret) + (let* ((secret (or secret + (plist-get (nth 0 (auth-source-search + :max 1 + :host server + :port "irc" + :user channel)) + :secret))) + (password (if (functionp secret) + (funcall secret) + secret))) + (erc-log (format "cmd: JOIN: %s" channel)) + (erc-server-send (concat "JOIN " channel + (if password + (concat " " password) + ""))))) + (defun erc-cmd-JOIN (channel &optional key) "Join the channel given in CHANNEL, optionally with KEY. If CHANNEL is specified as \"-invite\", join the channel to which you @@ -3041,10 +3058,9 @@ erc-cmd-JOIN (if (erc-member-ignore-case chnl joined-channels) (switch-to-buffer (car (erc-member-ignore-case chnl joined-channels))) - (erc-log (format "cmd: JOIN: %s" chnl)) - (erc-server-send (if (and chnl key) - (format "JOIN %s %s" chnl key) - (format "JOIN %s" chnl))))))) + (let ((server (with-current-buffer (process-buffer erc-server-process) + (or erc-session-server erc-server-announced-name)))) + (erc-server-join-channel server chnl key)))))) t) (defalias 'erc-cmd-CHANNEL 'erc-cmd-JOIN) From unknown Tue Aug 12 08:33:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25349: 25.1.90; erc join -vs- passwords Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Jan 2017 03:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25349 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tom Tromey Cc: 25349@debbugs.gnu.org, Nikolay Kudryavtsev Received: via spool by 25349-submit@debbugs.gnu.org id=B25349.14840193445750 (code B ref 25349); Tue, 10 Jan 2017 03:36:01 +0000 Received: (at 25349) by debbugs.gnu.org; 10 Jan 2017 03:35:44 +0000 Received: from localhost ([127.0.0.1]:48310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQnDr-0001Ug-Mr for submit@debbugs.gnu.org; Mon, 09 Jan 2017 22:35:43 -0500 Received: from gproxy7-pub.mail.unifiedlayer.com ([70.40.196.235]:40949) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1cQnDp-0001US-SE for 25349@debbugs.gnu.org; Mon, 09 Jan 2017 22:35:42 -0500 Received: (qmail 26759 invoked by uid 0); 10 Jan 2017 03:35:30 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy7.mail.unifiedlayer.com with SMTP; 10 Jan 2017 03:35:30 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id WTbS1u00n2f2jeq01TbVsX; Mon, 09 Jan 2017 20:35:30 -0700 X-Authority-Analysis: v=2.1 cv=SY5kKJhu c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IgFoBzBjUZAA:10 a=zstS-IiYAAAA:8 a=-Y2DNwbNkJ5nGUCVUVUA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=H6hpH/xKiPjBLKn55igk7Xqkus/YYU1VCK8wArr6lP0=; b=dhx4V7IrPC3uimLTeKAI7yhd/7 r5ZozZsy5NwvZLphG9l1B7dBSMNRWwtgjcCWzu2g6VmY7p1ES2VAmE7mucaGGBozHNxCaOwonmfGQ TBZpOj6TTwV642bMkcoHTx5kB; Received: from 174-16-146-181.hlrn.qwest.net ([174.16.146.181]:54816 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cQnDa-00084e-Iz; Mon, 09 Jan 2017 20:35:26 -0700 From: Tom Tromey References: <87d1g3u63z.fsf@tromey.com> <02a0b060-c061-4bf6-849b-5c05c5d4b670@gmail.com> <878tqrt76s.fsf@tromey.com> <87wpeasvpd.fsf@tromey.com> <87tw9ddtid.fsf@tromey.com> <878tqodxvk.fsf@tromey.com> X-Attribution: Tom Date: Mon, 09 Jan 2017 20:35:21 -0700 In-Reply-To: <878tqodxvk.fsf@tromey.com> (Tom Tromey's message of "Fri, 06 Jan 2017 08:14:07 -0700") Message-ID: <87o9zf1tae.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.146.181 X-Exim-ID: 1cQnDa-00084e-Iz X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-146-181.hlrn.qwest.net (bapiya) [174.16.146.181]:54816 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) >>>>> "Tom" == Tom Tromey writes: Tom> The appended works for me for both autojoin and explicit join. I want Tom> to check it in, but it would probably be good if someone more familiar Tom> with ERC took a look at it. Further testing revealed a bug. The other day, at the end of the day, I did a /gquit in ERC. Then, this morning, I reconnected. Normally this causes ERC to associate the various channel buffers with the new connection to the server. However, with this patch in place, this association did not occur and I was given a new buffer for each channel (the old buffers being "closed"). I haven't tried debugging this any further yet. Tom From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 11 19:32:11 2017 Received: (at control) by debbugs.gnu.org; 12 Jan 2017 00:32:11 +0000 Received: from localhost ([127.0.0.1]:50566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRTJK-0005mf-Vv for submit@debbugs.gnu.org; Wed, 11 Jan 2017 19:32:11 -0500 Received: from mail-it0-f44.google.com ([209.85.214.44]:37511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRTJJ-0005mQ-Nn for control@debbugs.gnu.org; Wed, 11 Jan 2017 19:32:10 -0500 Received: by mail-it0-f44.google.com with SMTP id r185so1751055ita.0 for ; Wed, 11 Jan 2017 16:32:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=FAJRhAFIuRk3PWrA7dAq6hvGfjtl1sRDUdqDzLEDgq8=; b=Sk5X+8rujliw4DMBHEZZfJ5jOS5FJnw85hIyt3cXoh2KGQwxph01ueo/5Nf+xdHHtT CqJ9ONMXWPUa7BAepMpGZ3n7KPVreVwuaARG+h7G78grJfpybu5PBcro0yi31fyeq9xw ed4TM1S22yLpkTLiFQFat/zqt+FqA1IjLAHzZEnIeaeankP6sXBwiK13cqp+GJJVX2l+ r1oikD5kxP1Njl6Oad5W0fgFCfZEC2yHLs0MBZvnrBXnWDCeKV6/XPhd02wYelo3TsC2 U5Bl14JY/nXoH0do5KGRDoqsKdaI1ZD2XCpMQflxffzFApzoyUdOyVlIiC6z33y6ZKC7 63PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=FAJRhAFIuRk3PWrA7dAq6hvGfjtl1sRDUdqDzLEDgq8=; b=ZGGjQz1cxOMfwA3KnVMtkYa53PVWTeF21orZH2Z4d3eimhzm/4ccJ3QALizZbNsF4A cRFUujG0TsNNEcApxKnv4crK4CiH+68Si6pLSBLy4DyDfse9zLfDKHlFcKUf/RP56c8A YSNvjIExVOF823YOp1Bbv7JT+1A9x3y4b8boVlsZgi35kOj3/Qddv5pD6+EATs+mcyr5 ZEBkOCulcsWI5tNsRbfKbcZsxxt3PJreGW9MwjsKGMB7E6pI0QueZQ+zQuX05VOUxCEb XjcVNaNQcnE6g/VRlWBSbg5VcmnpTiGmKfmLdvj2vxjxwRStLNT2wTGu9DBFlAFaghvQ +91g== X-Gm-Message-State: AIkVDXI2F2e1w3JTpO6/U4u003cUBtM+mG1CYlqMdBcL5snhz0pbCq6t8/N3Vijv5YbopA== X-Received: by 10.36.156.132 with SMTP id b126mr10515588ite.91.1484181124059; Wed, 11 Jan 2017 16:32:04 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id c9sm3970684ioc.2.2017.01.11.16.32.02 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Jan 2017 16:32:03 -0800 (PST) From: npostavs@users.sourceforge.net To: control@debbugs.gnu.org Subject: Re: bug#23438: see also bug#25349 References: <87inpmywgm.fsf@tromey.com> Date: Wed, 11 Jan 2017 19:33:07 -0500 In-Reply-To: <87inpmywgm.fsf@tromey.com> (Tom Tromey's message of "Tue, 10 Jan 2017 22:52:41 -0700") Message-ID: <87ziixyv5o.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) merge 25349 23438 quit Tom Tromey writes: > This sounds like bug#25349, which also has a patch and some other > commentary. I don't know how to merge them, or I would. > > Tom From unknown Tue Aug 12 08:33:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25349: 25.1.90; erc join -vs- passwords Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Feb 2017 03:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25349 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tom Tromey Cc: 25349@debbugs.gnu.org, Nikolay Kudryavtsev Received: via spool by 25349-submit@debbugs.gnu.org id=B25349.148591808831552 (code B ref 25349); Wed, 01 Feb 2017 03:02:01 +0000 Received: (at 25349) by debbugs.gnu.org; 1 Feb 2017 03:01:28 +0000 Received: from localhost ([127.0.0.1]:52741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYlAm-0008Ch-3a for submit@debbugs.gnu.org; Tue, 31 Jan 2017 22:01:28 -0500 Received: from gproxy4-pub.mail.unifiedlayer.com ([69.89.23.142]:48592) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1cYlAj-00086H-7c for 25349@debbugs.gnu.org; Tue, 31 Jan 2017 22:01:25 -0500 Received: (qmail 9098 invoked by uid 0); 1 Feb 2017 03:01:13 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy4.mail.unifiedlayer.com with SMTP; 1 Feb 2017 03:01:13 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id fF181u02f2f2jeq01F1Bwa; Tue, 31 Jan 2017 20:01:13 -0700 X-Authority-Analysis: v=2.1 cv=WOnsABcR c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IgFoBzBjUZAA:10 a=zstS-IiYAAAA:8 a=HwPWKdrwA0L0brUVAboA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Fr6Q4HGFkyRg0oCPgU7z7Ei/PSeTsGC/ScymBEoMl1I=; b=WuuaK2TrOf/GqA8iZjsYMwrFvU pddEESNvQEu3ucFzedPo/tOAxYvp4hijS+zizZAh2CfVLFdw+3zKfshKEqww2pXJ492vnvm3kAuy/ ctGGOOkIEulxj9GTaGVqX2w84; Received: from 174-16-146-181.hlrn.qwest.net ([174.16.146.181]:51734 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cYlAS-0007pY-MN; Tue, 31 Jan 2017 20:01:08 -0700 From: Tom Tromey References: <87d1g3u63z.fsf@tromey.com> <02a0b060-c061-4bf6-849b-5c05c5d4b670@gmail.com> <878tqrt76s.fsf@tromey.com> <87wpeasvpd.fsf@tromey.com> <87tw9ddtid.fsf@tromey.com> <878tqodxvk.fsf@tromey.com> <87o9zf1tae.fsf@tromey.com> X-Attribution: Tom Date: Tue, 31 Jan 2017 20:01:05 -0700 In-Reply-To: <87o9zf1tae.fsf@tromey.com> (Tom Tromey's message of "Mon, 09 Jan 2017 20:35:21 -0700") Message-ID: <87k29aboni.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.146.181 X-Exim-ID: 1cYlAS-0007pY-MN X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-146-181.hlrn.qwest.net (bapiya) [174.16.146.181]:51734 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) >>>>> "Tom" == Tom Tromey writes: Tom> Normally this causes ERC to associate the various channel buffers with Tom> the new connection to the server. However, with this patch in place, Tom> this association did not occur and I was given a new buffer for each Tom> channel (the old buffers being "closed"). Subsequent reconnects haven't had this problem, so I haven't been able to debug. Maybe I've just been lucky and haven't been connected to a different server. Tom From unknown Tue Aug 12 08:33:32 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Tom Tromey Subject: bug#25349: closed (fix checked in) Message-ID: References: <87h90yejea.fsf@tromey.com> <87d1g3u63z.fsf@tromey.com> X-Gnu-PR-Message: they-closed 25349 X-Gnu-PR-Package: emacs Reply-To: 25349@debbugs.gnu.org Date: Sat, 06 May 2017 03:48:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1494042481-1463-1" This is a multi-part message in MIME format... ------------=_1494042481-1463-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #25349: 25.1.90; erc join -vs- passwords which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 25349@debbugs.gnu.org. --=20 25349: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25349 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1494042481-1463-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 25349-done) by debbugs.gnu.org; 6 May 2017 03:47:43 +0000 Received: from localhost ([127.0.0.1]:57007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6qh5-0000N8-GV for submit@debbugs.gnu.org; Fri, 05 May 2017 23:47:43 -0400 Received: from gproxy4-pub.mail.unifiedlayer.com ([69.89.23.142]:60495 helo=gproxy4.mail.unifiedlayer.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6qh3-0000Mu-Uw for 25349-done@debbugs.gnu.org; Fri, 05 May 2017 23:47:42 -0400 Received: from cmgw4 (unknown [10.0.90.85]) by gproxy4.mail.unifiedlayer.com (Postfix) with ESMTP id 0B222175D45 for <25349-done@debbugs.gnu.org>; Fri, 5 May 2017 21:47:31 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id GrnT1v00J2f2jeq01rnWPr; Fri, 05 May 2017 21:47:31 -0600 X-Authority-Analysis: v=2.2 cv=QdwWhoTv c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=tJ8p9aeEuA8A:10 a=h0JqVpTDDR_UVJJZ95UA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9royt92FP4AiUfH1Q0/qmoU6DplYlZ3auJzrx6XZSSU=; b=vFO9sF+Tu6+JMt+3MQSRziH4eV P6R9y4QZ/eW8ovwbXjjv0rUkQE2/LBXJUqHRa7ws1ryVRb06nDo4ovAB8RGKfvgPTq/3hJEZ2ol2O 2nteAFzLzZPQG0dWW3aW9pdDM; Received: from 75-166-63-71.hlrn.qwest.net ([75.166.63.71]:56510 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1d6qgp-00049P-Bc; Fri, 05 May 2017 21:47:27 -0600 From: Tom Tromey To: 25349-done@debbugs.gnu.org Subject: fix checked in X-Attribution: Tom Date: Fri, 05 May 2017 21:47:25 -0600 Message-ID: <87h90yejea.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.63.71 X-Exim-ID: 1d6qgp-00049P-Bc X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-63-71.hlrn.qwest.net (bapiya) [75.166.63.71]:56510 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 25349-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) I've checked in the patch. Tom ------------=_1494042481-1463-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Jan 2017 23:59:16 +0000 Received: from localhost ([127.0.0.1]:40661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOYz5-0006TI-H5 for submit@debbugs.gnu.org; Tue, 03 Jan 2017 18:59:16 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48867) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOYz3-0006T2-Gy for submit@debbugs.gnu.org; Tue, 03 Jan 2017 18:59:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOYyw-0005K7-OG for submit@debbugs.gnu.org; Tue, 03 Jan 2017 18:59:08 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57079) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cOYyw-0005Jz-KP for submit@debbugs.gnu.org; Tue, 03 Jan 2017 18:59:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOYyu-0006hW-F5 for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2017 18:59:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOYyr-0005H2-AO for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2017 18:59:04 -0500 Received: from gproxy7-pub.mail.unifiedlayer.com ([70.40.196.235]:48159) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1cOYyq-00057S-RX for bug-gnu-emacs@gnu.org; Tue, 03 Jan 2017 18:59:01 -0500 Received: (qmail 1619 invoked by uid 0); 3 Jan 2017 23:58:26 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy7.mail.unifiedlayer.com with SMTP; 3 Jan 2017 23:58:26 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id TzyG1u00l2f2jeq01zyK9Q; Tue, 03 Jan 2017 16:58:22 -0700 X-Authority-Analysis: v=2.1 cv=It+NLtPg c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IgFoBzBjUZAA:10 a=pQs5aej7AAAA:8 a=xGD7EAh91r10B7pJvHwA:9 a=OdvcLBuiQaLYJWf9:21 a=FSjZ6CAghlW15IVe:21 a=Aan7rn3zuj8km_mHUhxA:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From; bh=0gTqQ+e6IyAd7TRC3f0DMhRKvvvbXyK/tPDGGZAVxRo=; b=UTtnbhNFzHTYC4CB09+lx8trdF V6QFajvqA0ClA0S/C47BhTrGDRm1nzR8SSnmSQgFEsqBHQ72LbdcBo1N9p77KUHKpsVGlJjSyXYDU axinQoiV7fhtGvdeZjB3nlsMi; Received: from 174-16-146-181.hlrn.qwest.net ([174.16.146.181]:40478 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cOXdU-0001qf-L7; Tue, 03 Jan 2017 15:32:52 -0700 From: Tom Tromey To: bug-gnu-emacs@gnu.org Subject: 25.1.90; erc join -vs- passwords X-Attribution: Tom Date: Tue, 03 Jan 2017 15:32:48 -0700 Message-ID: <87d1g3u63z.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.146.181 X-Exim-ID: 1cOXdU-0001qf-L7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-146-181.hlrn.qwest.net (pokyo) [174.16.146.181]:40478 X-Source-Auth: tom+tromey.com X-Email-Count: 0 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I'm using erc and joining a channel that has a channel password. I've tried to put the password in my ~/.authinfo. However, there are two erc bugs that prevent this from working. 1. In erc-join.el, various functions do: (or erc-server-announced-name erc-session-server) I think this is backward -- the announced name is the real name of the host, but this can vary, so isn't useful as a .authinfo key. e.g., for me, erc-server-announced-name is currently "belew.mozilla.org" but erc-session-server is "irc.mozilla.org" -- which is what I used to connect and is the name I'd want to use in .authinfo. Changing the instances of this in erc-join.el makes auto-join work for me. 2. erc-cmd-JOIN does not check authinfo at all. Maybe it should share this code with erc-join.el. In GNU Emacs 25.1.90.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.20.9) of 2016-12-15 built on pokyo Repository revision: 467768f64ee109fe127619e75fee7f3b5de1fec1 Windowing system distributor 'Fedora Project', version 11.0.11804000 System Description: Fedora release 24 (Twenty Four) Configured using: 'configure --prefix=/home/tromey/Emacs/install --with-file-notifications=no' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GCONF GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: JS Minor modes in effect: erc-spelling-mode: t erc-truncate-mode: t diff-auto-refine-mode: t shell-dirtrack-mode: t flyspell-mode: t which-function-mode: t projectile-global-mode: t projectile-mode: t erc-notify-mode: t erc-notifications-mode: t erc-services-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-netsplit-mode: t erc-hl-nicks-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t flycheck-mode: t savehist-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t auto-fill-function: do-auto-fill transient-mark-mode: t Recent messages: Expiring articles...done Are you sure you want to quit reading news? (y or n) y Saving Gnus registry (73035 entries) to ~/.gnus.registry.eieio... Saving Gnus registry (size 73035) to ~/.gnus.registry.eieio...done Saving file /home/tromey/.newsrc... Wrote /home/tromey/.newsrc Saving /home/tromey/.newsrc.eld... Saving file /home/tromey/.newsrc.eld... Wrote /home/tromey/.newsrc.eld Saving /home/tromey/.newsrc.eld...done Load-path shadows: /home/tromey/.emacs.d/elpa/bubbles-0.5/bubbles hides /home/tromey/Emacs/install/share/emacs/25.1.90/lisp/play/bubbles Features: (shadow emacsbug debug ffap conf-mode css-mode descr-text gud eieio-opt speedbar sb-image ezimage dframe vc-annotate macros dwarf-mode rust-mode doctor gnus-fun find-dired dxr tabify man perl-mode sh-script smie executable smerge-mode etags xref project git-commit-mode find-file js sgml-mode iso-transl mailalias bbdb-sc supercite regi mail-hist nnir idutils python tramp-sh tramp tramp-compat tramp-loaddefs trampver ucs-normalize git-rebase-mode derived term/xterm xterm org-element org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view jka-compr image-mode org-bibtex bibtex org-bbdb org-w3m org org-macro org-footnote org-pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs log-view gnus-html url-cache mm-url shr-color url-http url url-proxy url-privacy url-history url-auth url-cookie url-domsuf url-gw url-expand url-methods url-util url-parse url-vars shr dom browse-url erc-spelling erc-truncate bbdb-gui bbdb-hooks bbdb-rmail rmailsum rmail vc-mtn vc-hg sort smiley gnus-cite flow-fill mm-archive gnus-async gnus-bcklg qp gnus-ml disp-table gnus-topic nndraft nnmh nnfolder utf-7 bbdb-gnus bbdb-snarf mail-extr bbdb-com network-stream nsm starttls gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache gnus-registry registry eieio-compat eieio-base gnus-art mm-uu mml2015 mm-view mml-smime smime dig mailcap gnus-sum gnus-group gnus-undo smtpmail sendmail gnus-start gnus-cloud nnimap nnmail mail-source tls gnutls utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range gnus-win gnus gnus-ems nnheader dabbrev log-edit message idna rfc822 mml mml-sec epg mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils mailheader pcvs-util copyright misearch multi-isearch add-log bug-reference vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs vc-git diff-mode cc-mode cc-fonts cc-guess cc-menus cc-cmds shell flyspell ispell diminish appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs which-func imenu edmacro kmacro projectile grep compile ibuf-ext ibuffer minimap autorevert filenotify desktop frameset cus-start cus-load erc-notify erc-desktop-notifications notifications dbus xml erc-services erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete pcomplete erc-track erc-match erc-netsplit erc-hl-nicks easy-mmode color erc-button erc-fill erc-stamp wid-edit erc-goodies erc erc-backend erc-compat format-spec auth-source cl-seq eieio gnus-util mm-util help-fns mail-prsvr password-cache thingatpt pp status dired-aux dired-x dired warnings advice vc-dir ewoc vc vc-dispatcher flycheck json map find-func rx subr-x dash cc-styles cc-align cc-engine cc-vars cc-defs bbdb cl timezone ange-ftp comint ansi-color ring server savehist finder-inf bbdb-autoloads dwarf-mode-autoloads eieio-core cl-macs lisppaste-autoloads pydoc-info-autoloads info-look weblogger-autoloads info package epg-config seq byte-opt gv bytecomp byte-compile cl-extra help-mode easymenu cconv cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 4956169 2764016) (symbols 48 147899 536) (miscs 40 49685 30197) (strings 32 1374486 796506) (string-bytes 1 59281313) (vectors 16 171120) (vector-slots 8 4046984 214559) (floats 8 1121 2125) (intervals 56 350578 9418) (buffers 976 761) (heap 1024 613853 395688)) Tom ------------=_1494042481-1463-1-- From unknown Tue Aug 12 08:33:32 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jim Crossley Subject: bug#23438: closed (fix checked in) Message-ID: References: <87h90yejea.fsf@tromey.com> X-Gnu-PR-Message: they-closed 23438 X-Gnu-PR-Package: emacs Reply-To: 23438@debbugs.gnu.org Date: Sat, 06 May 2017 03:48:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1494042482-1463-3" This is a multi-part message in MIME format... ------------=_1494042482-1463-3 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #25349: 24.5; ERC autojoin should use erc-autojoin-domain-only searching ch= annel keys which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 23438@debbugs.gnu.org. --=20 25349: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25349 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1494042482-1463-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 25349-done) by debbugs.gnu.org; 6 May 2017 03:47:43 +0000 Received: from localhost ([127.0.0.1]:57007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6qh5-0000N8-GV for submit@debbugs.gnu.org; Fri, 05 May 2017 23:47:43 -0400 Received: from gproxy4-pub.mail.unifiedlayer.com ([69.89.23.142]:60495 helo=gproxy4.mail.unifiedlayer.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6qh3-0000Mu-Uw for 25349-done@debbugs.gnu.org; Fri, 05 May 2017 23:47:42 -0400 Received: from cmgw4 (unknown [10.0.90.85]) by gproxy4.mail.unifiedlayer.com (Postfix) with ESMTP id 0B222175D45 for <25349-done@debbugs.gnu.org>; Fri, 5 May 2017 21:47:31 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id GrnT1v00J2f2jeq01rnWPr; Fri, 05 May 2017 21:47:31 -0600 X-Authority-Analysis: v=2.2 cv=QdwWhoTv c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=tJ8p9aeEuA8A:10 a=h0JqVpTDDR_UVJJZ95UA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9royt92FP4AiUfH1Q0/qmoU6DplYlZ3auJzrx6XZSSU=; b=vFO9sF+Tu6+JMt+3MQSRziH4eV P6R9y4QZ/eW8ovwbXjjv0rUkQE2/LBXJUqHRa7ws1ryVRb06nDo4ovAB8RGKfvgPTq/3hJEZ2ol2O 2nteAFzLzZPQG0dWW3aW9pdDM; Received: from 75-166-63-71.hlrn.qwest.net ([75.166.63.71]:56510 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1d6qgp-00049P-Bc; Fri, 05 May 2017 21:47:27 -0600 From: Tom Tromey To: 25349-done@debbugs.gnu.org Subject: fix checked in X-Attribution: Tom Date: Fri, 05 May 2017 21:47:25 -0600 Message-ID: <87h90yejea.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.63.71 X-Exim-ID: 1d6qgp-00049P-Bc X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-63-71.hlrn.qwest.net (bapiya) [75.166.63.71]:56510 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 25349-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) I've checked in the patch. Tom ------------=_1494042482-1463-3 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 May 2016 22:19:35 +0000 Received: from localhost ([127.0.0.1]:35954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1axifG-0000ZH-AC for submit@debbugs.gnu.org; Tue, 03 May 2016 18:19:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1axiN2-00008M-Dy for submit@debbugs.gnu.org; Tue, 03 May 2016 18:00:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axiMm-0003J3-EO for submit@debbugs.gnu.org; Tue, 03 May 2016 18:00:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axiMl-0003HY-9H for submit@debbugs.gnu.org; Tue, 03 May 2016 18:00:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axiMY-000276-5L for bug-gnu-emacs@gnu.org; Tue, 03 May 2016 18:00:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axiMI-00032E-Nu for bug-gnu-emacs@gnu.org; Tue, 03 May 2016 18:00:06 -0400 Received: from mail-io0-x244.google.com ([2607:f8b0:4001:c06::244]:33247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axiMH-0002u8-CW for bug-gnu-emacs@gnu.org; Tue, 03 May 2016 17:59:58 -0400 Received: by mail-io0-x244.google.com with SMTP id x35so3674559ioi.0 for ; Tue, 03 May 2016 14:59:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to; bh=eyLvprk0HJq3GrlhypHeWN2g33MVl76ZToyS5NmzbaQ=; b=PPLE42wOicIY5Mh6SRKKp/mgFOVvaI4BthHHz9v/wu6KibnQ0DApCwkQPKHOj1F1qP D/68O3x67TEh0iGJZ3zXEMfWb8JS7ctWqaLDrYo3um7yX/Hr8tR0BX2b6oduqrGcFNrY HC9Cmy9p2/oHimjnmFSgEK9j4EICIbki4xSEa1iu81Luc7MA2hr5+5V4zi2VvJwHGwhp qjGzgs2v69/PFCdlzQrbcllhl/YIMArWQdDxF8nmHQYcKMFoh9aUZvH7pUHw3Qf9D1xC y5Y0wc1lYPB4mvsn3qUpI1BAPEYWVKAo8Jg0oPFPdwM+rjzxb3OpJAR92RuLwIBQdeiV EJQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:date:message-id:subject:from :to; bh=eyLvprk0HJq3GrlhypHeWN2g33MVl76ZToyS5NmzbaQ=; b=MULYjSsCOAo7d2QeqItp5JTvLtEueWjUbBI1MNUh5tbg2XDvIkKC7inrQ8iV3GQA1c WunPuW6Am3phZvoB2SIIjCOIAR9l4l0SWK3v/MzOxXehpVgNoPzyx9KIzCMS63ff/aZx sRsLUPjGC+KtfhZ2iwjv6QTOVz7XXU7RkgYJiPUsqMjGGtbUMJ6OVD3v5rGhXyWcvLrG ErS9m63fjMW7H5keLogXFsxqVgijWWoZDFipifahMSHVzbc7mOLYPrz7rQ1qDOVNzE8z AcdWzYaCZN/OU3aihikLiKDjdkmnwk5yJE2QbXfP1kPgdvj0GwNCJFak7ENEW6bA/scC xp8w== X-Gm-Message-State: AOPr4FUpsIZ9srmpXjUMp3ogZ0ovh0mtXwgfHoQigc9VLgpHzKE0qcEC+ybzixs/H6nx4sW0gfK3z/4lM8LgXw== MIME-Version: 1.0 X-Received: by 10.107.59.88 with SMTP id i85mr6229583ioa.134.1462312778779; Tue, 03 May 2016 14:59:38 -0700 (PDT) Received: by 10.36.216.136 with HTTP; Tue, 3 May 2016 14:59:38 -0700 (PDT) Date: Tue, 3 May 2016 17:59:38 -0400 X-Google-Sender-Auth: ME0S2S716W_hFWl2C2BVy0Rc02A Message-ID: Subject: 24.5; ERC autojoin should use erc-autojoin-domain-only searching channel keys From: Jim Crossley To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary=94eb2c05be94bad3630531f739be X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 03 May 2016 18:19:33 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) --94eb2c05be94bad3630531f739be Content-Type: text/plain; charset=UTF-8 It's impossible to know what round-robin server you'll actually connect to when connecting to chat.freenode.net, for example. Therefore, it's impossible to include the correct host lines for channel keys in the auth-source files. It would be far better to search for the channel keys using the same name used to query erc-autojoin-channels-alist when erc-autojoin-domain-only is non-nil. I have a patch that works, but I'm not sure where to submit it. In GNU Emacs 24.5.1 (x86_64-redhat-linux-gnu, GTK+ Version 3.18.9) of 2016-04-11 on buildvm-25.phx2.fedoraproject.org Windowing system distributor `Fedora Project', version 11.0.11803000 System Description: Fedora release 23 (Twenty Three) Configured using: `configure --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-dbus --with-gif --with-jpeg --with-png --with-rsvg --with-tiff --with-xft --with-xpm --with-x-toolkit=gtk3 --with-gpm=no build_alias=x86_64-redhat-linux-gnu host_alias=x86_64-redhat-linux-gnu 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic' LDFLAGS=-Wl,-z,relro' Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: hi-lock-mode: t diff-auto-refine-mode: t magit-auto-revert-mode: t auto-revert-mode: t global-git-commit-mode: t async-bytecomp-package-mode: t recentf-mode: t erc-log-mode: t erc-autoaway-mode: t elisp-slime-nav-mode: t paredit-mode: t idle-highlight-mode: t ido-ubiquitous-mode: t erc-spelling-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-netsplit-mode: t erc-hl-nicks-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-keep-place-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t eldoc-mode: t shell-dirtrack-mode: t global-auto-complete-mode: t auto-complete-mode: t global-hl-line-mode: t hl-line-mode: t delete-selection-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t auto-fill-function: do-auto-fill transient-mark-mode: t Recent messages: Saving file /usr/share/emacs/24.5/lisp/erc/erc-join.el.gz... File erc-join.el.gz is write-protected; try to save anyway? (y or n) n basic-save-buffer-2: Attempt to save to a file which you aren't allowed to write Mark set [4 times] Saving file /home/jim/src/.emacs.d/config/irc.el... Wrote /home/jim/src/.emacs.d/config/irc.el Annotating... Redisplaying annotation...done (Spanned from 9681.2 to 123.8 days old) Annotating... done Mark saved where search started Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug sendmail vc-annotate log-view vc vc-dispatcher tabify yasnippet debug eieio-opt speedbar sb-image ezimage dframe misearch multi-isearch jka-compr view mule-util hi-lock vc-git find-things-fast ffap url-parse linum magit-blame magit-stash magit-bisect magit-remote magit-commit magit-sequence magit magit-apply magit-wip magit-log magit-diff smerge-mode diff-mode magit-core magit-autorevert autorevert filenotify magit-process magit-popup magit-mode magit-git crm magit-section magit-utils git-commit log-edit message idna rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log with-editor async-bytecomp async server dash dired recentf tree-widget network-stream starttls tls erc-log erc-autoaway flymake elisp-slime-nav help-mode paredit idle-highlight-mode ido-ubiquitous ido-completing-read+ cus-edit smex erc-spelling flyspell ispell notifications dbus xml erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete erc-track erc-match erc-netsplit erc-hl-nicks color erc-button erc-fill erc-stamp wid-edit erc-goodies erc erc-backend erc-compat pp cl cider tramp-sh cider-debug cider-browse-ns cider-inspector cider-mode cider-interaction etags compile arc-mode archive-mode thingatpt cider-repl cider-resolve cider-test cider-overlays cider-stacktrace cider-doc org-table org org-macro org-footnote org-pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs find-func cal-menu calendar cal-loaddefs cider-grimoire url-vars cider-popup easy-mmode cider-eldoc eldoc cider-client cider-common cider-util clojure-mode align imenu nrepl-client tramp tramp-compat auth-source gnus-util mm-util mail-prsvr password-cache tramp-loaddefs trampver shell pcomplete comint ansi-color ring format-spec queue cider-compat seq seq-24 ewoc spinner windmove epa-file epa derived epg auto-complete-config auto-complete cl-macs gv popup cyberpunk-theme hl-line delsel cus-start cus-load finder-inf paren edmacro kmacro saveplace ido eieio byte-opt bytecomp byte-compile cl-extra cl-loaddefs cl-lib cconv eieio-core advice help-fns info easymenu package epg-config time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind gfilenotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) Memory information: ((conses 16 445819 44140) (symbols 48 45274 0) (miscs 40 482 2072) (strings 32 121056 5951) (string-bytes 1 3136335) (vectors 16 49396) (vector-slots 8 816276 26129) (floats 8 524 484) (intervals 56 7285 660) (buffers 960 62) (heap 1024 44605 3132)) --94eb2c05be94bad3630531f739be Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

It's impossible to know what round= -robin server you'll actually connect
to when connecting to <= a href=3D"http://chat.freenode.net">chat.freenode.net, for example. The= refore, it's
impossible to include the correct host lines for= channel keys in the
auth-source files. It would be far better to= search for the channel keys
using the same name used to query er= c-autojoin-channels-alist when
erc-autojoin-domain-only is non-ni= l. I have a patch that works, but I'm
not sure where to submi= t it.



In GNU Emacs 2= 4.5.1 (x86_64-redhat-linux-gnu, GTK+ Version 3.18.9)
=C2=A0of 201= 6-04-11 on buildvm-25.= phx2.fedoraproject.org
Windowing system distributor `Fedora P= roject', version 11.0.11803000
System Description: Fedora release 23 (Twenty Three)

Configured using:
=C2=A0`configure --build= =3Dx86_64-redhat-linux-gnu
=C2=A0--host=3Dx86_64-redhat-linux-gnu= --program-prefix=3D
=C2=A0--disable-dependency-tracking --prefix= =3D/usr --exec-prefix=3D/usr
=C2=A0--bindir=3D/usr/bin --sbindir= =3D/usr/sbin --sysconfdir=3D/etc
=C2=A0--datadir=3D/usr/share --i= ncludedir=3D/usr/include --libdir=3D/usr/lib64
=C2=A0--libexecdir= =3D/usr/libexec --localstatedir=3D/var
=C2=A0--sharedstatedir=3D/= var/lib --mandir=3D/usr/share/man
=C2=A0--infodir=3D/usr/share/in= fo --with-dbus --with-gif --with-jpeg --with-png
=C2=A0--with-rsv= g --with-tiff --with-xft --with-xpm --with-x-toolkit=3Dgtk3
=C2= =A0--with-gpm=3Dno build_alias=3Dx86_64-redhat-linux-gnu
=C2=A0ho= st_alias=3Dx86_64-redhat-linux-gnu 'CFLAGS=3D-DMAIL_USE_LOCKF -O2 -g
=C2=A0-pipe -Wall -Werror=3Dformat-security -Wp,-D_FORTIFY_SOURCE= =3D2
=C2=A0-fexceptions -fstack-protector-strong --param=3Dssp-bu= ffer-size=3D4
=C2=A0-grecord-gcc-switches -specs=3D/usr/lib/rpm/r= edhat/redhat-hardened-cc1
=C2=A0-m64 -mtune=3Dgeneric' LDFLAG= S=3D-Wl,-z,relro'

Important settings:
=C2=A0 value of $LANG: en_US.UTF-8
=C2=A0 value of $XMODIFIERS:= @im=3Dibus
=C2=A0 locale-coding-system: utf-8-unix
Major mode: Emacs-Lisp

Minor modes in = effect:
=C2=A0 hi-lock-mode: t
=C2=A0 diff-auto-refine-= mode: t
=C2=A0 magit-auto-revert-mode: t
=C2=A0 auto-re= vert-mode: t
=C2=A0 global-git-commit-mode: t
=C2=A0 as= ync-bytecomp-package-mode: t
=C2=A0 recentf-mode: t
=C2= =A0 erc-log-mode: t
=C2=A0 erc-autoaway-mode: t
=C2=A0 = elisp-slime-nav-mode: t
=C2=A0 paredit-mode: t
=C2=A0 i= dle-highlight-mode: t
=C2=A0 ido-ubiquitous-mode: t
=C2= =A0 erc-spelling-mode: t
=C2=A0 erc-list-mode: t
=C2=A0= erc-menu-mode: t
=C2=A0 erc-autojoin-mode: t
=C2=A0 er= c-ring-mode: t
=C2=A0 erc-networks-mode: t
=C2=A0 erc-p= complete-mode: t
=C2=A0 erc-track-mode: t
=C2=A0 erc-tr= ack-minor-mode: t
=C2=A0 erc-match-mode: t
=C2=A0 erc-n= etsplit-mode: t
=C2=A0 erc-hl-nicks-mode: t
=C2=A0 erc-= button-mode: t
=C2=A0 erc-fill-mode: t
=C2=A0 erc-stamp= -mode: t
=C2=A0 erc-irccontrols-mode: t
=C2=A0 erc-nonc= ommands-mode: t
=C2=A0 erc-keep-place-mode: t
=C2=A0 er= c-move-to-prompt-mode: t
=C2=A0 erc-readonly-mode: t
= =C2=A0 eldoc-mode: t
=C2=A0 shell-dirtrack-mode: t
=C2= =A0 global-auto-complete-mode: t
=C2=A0 auto-complete-mode: t
=C2=A0 global-hl-line-mode: t
=C2=A0 hl-line-mode: t
=
=C2=A0 delete-selection-mode: t
=C2=A0 show-paren-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wheel-mode: t=
=C2=A0 file-name-shadow-mode: t
=C2=A0 global-font-loc= k-mode: t
=C2=A0 font-lock-mode: t
=C2=A0 auto-composit= ion-mode: t
=C2=A0 auto-encryption-mode: t
=C2=A0 auto-= compression-mode: t
=C2=A0 column-number-mode: t
=C2=A0= line-number-mode: t
=C2=A0 auto-fill-function: do-auto-fill
=C2=A0 transient-mark-mode: t

Recent message= s:
Saving file /usr/share/emacs/24.5/lisp/erc/erc-join.el.gz...
File erc-join.el.gz is write-protected; try to save anyway? (y or = n) n
basic-save-buffer-2: Attempt to save to a file which you are= n't allowed to write
Mark set [4 times]
Saving file= /home/jim/src/.emacs.d/config/irc.el...
Wrote /home/jim/src/.ema= cs.d/config/irc.el
Annotating...
Redisplaying annotatio= n...done (Spanned from 9681.2 to 123.8 days old)
Annotating... do= ne
Mark saved where search started

Load-= path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug sendmail vc-annotate log-view vc
vc-dispatcher tabify yasnippet debug eieio-opt speedbar sb-image ezim= age
dframe misearch multi-isearch jka-compr view mule-util hi-loc= k vc-git
find-things-fast ffap url-parse linum magit-blame magit-= stash
magit-bisect magit-remote magit-commit magit-sequence magit= magit-apply
magit-wip magit-log magit-diff smerge-mode diff-mode= magit-core
magit-autorevert autorevert filenotify magit-process = magit-popup
magit-mode magit-git crm magit-section magit-utils gi= t-commit log-edit
message idna rfc822 mml mml-sec mm-decode mm-bo= dies mm-encode mail-parse
rfc2231 rfc2047 rfc2045 ietf-drums mail= abbrev mail-utils gmm-utils
mailheader pcvs-util add-log with-edi= tor async-bytecomp async server
dash dired recentf tree-widget ne= twork-stream starttls tls erc-log
erc-autoaway flymake elisp-slim= e-nav help-mode paredit
idle-highlight-mode ido-ubiquitous ido-co= mpleting-read+ cus-edit smex
erc-spelling flyspell ispell notific= ations dbus xml erc-list erc-menu
erc-join erc-ring erc-networks = erc-pcomplete erc-track erc-match
erc-netsplit erc-hl-nicks color= erc-button erc-fill erc-stamp wid-edit
erc-goodies erc erc-backe= nd erc-compat pp cl cider tramp-sh cider-debug
cider-browse-ns ci= der-inspector cider-mode cider-interaction etags
compile arc-mode= archive-mode thingatpt cider-repl cider-resolve
cider-test cider= -overlays cider-stacktrace cider-doc org-table org
org-macro org-= footnote org-pcomplete org-list org-faces org-entities
noutline o= utline org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob
ob-ta= ble ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat
o= rg-macs org-loaddefs find-func cal-menu calendar cal-loaddefs
cid= er-grimoire url-vars cider-popup easy-mmode cider-eldoc eldoc
cid= er-client cider-common cider-util clojure-mode align imenu
nrepl-= client tramp tramp-compat auth-source gnus-util mm-util mail-prsvr
password-cache tramp-loaddefs trampver shell pcomplete comint ansi-color<= /div>
ring format-spec queue cider-compat seq seq-24 ewoc spinner windm= ove
epa-file epa derived epg auto-complete-config auto-complete c= l-macs gv
popup cyberpunk-theme hl-line delsel cus-start cus-load= finder-inf paren
edmacro kmacro saveplace ido eieio byte-opt byt= ecomp byte-compile
cl-extra cl-loaddefs cl-lib cconv eieio-core a= dvice help-fns info
easymenu package epg-config time-date tooltip= electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel x-w= in x-dnd tool-bar dnd
fontset image regexp-opt fringe tabulated-l= ist newcomment lisp-mode
prog-mode register page menu-bar rfn-esh= adow timer select scroll-bar
mouse jit-lock font-lock syntax face= menu font-core frame cham georgian
utf-8-lang misc-lang vietnames= e tibetan thai tai-viet lao korean
japanese hebrew greek romanian= slovak czech european ethiopic indian
cyrillic chinese case-tabl= e epa-hook jka-cmpr-hook help simple abbrev
minibuffer nadvice lo= addefs button faces cus-face macroexp files
text-properties overl= ay sha1 md5 base64 format env code-pages mule
custom widget hasht= able-print-readable backquote make-network-process
dbusbind gfile= notify dynamic-setting system-font-setting
font-render-setting mo= ve-toolbar gtk x-toolkit x multi-tty emacs)

Memory= information:
((conses 16 445819 44140)
=C2=A0(symbols = 48 45274 0)
=C2=A0(miscs 40 482 2072)
=C2=A0(strings 32= 121056 5951)
=C2=A0(string-bytes 1 3136335)
=C2=A0(vec= tors 16 49396)
=C2=A0(vector-slots 8 816276 26129)
=C2= =A0(floats 8 524 484)
=C2=A0(intervals 56 7285 660)
=C2= =A0(buffers 960 62)
=C2=A0(heap 1024 44605 3132))

<= /div>
--94eb2c05be94bad3630531f739be-- ------------=_1494042482-1463-3--