GNU bug report logs - #25340
Save-some-buffers gets called when installing packages.

Previous Next

Package: emacs;

Reported by: Nikolay Kudryavtsev <nikolay.kudryavtsev <at> gmail.com>

Date: Mon, 2 Jan 2017 22:43:01 UTC

Severity: minor

Tags: fixed, patch

Merged with 25964, 26056

Found in version 26.0.50

Fixed in version 26.1

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

Full log


Message #20 received at 25340 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Nikolay Kudryavtsev <nikolay.kudryavtsev <at> gmail.com>
Cc: 25340 <at> debbugs.gnu.org
Subject: Re: bug#25340: Save-some-buffers gets called when installing packages.
Date: Sat, 07 Jan 2017 13:47:41 -0500
Nikolay Kudryavtsev <nikolay.kudryavtsev <at> gmail.com> writes:

> I had the idea of doing this:
>
> (defun byte-recompile-directory (directory &optional arg force
> limit-buffer-saving)
>
> ...
>
> If forth argument LIMIT-BUFFER-SAVING is 'directory, only files within
> DIRECTORY would be saved.  When LIMIT-BUFFER-SAVING is t no existing buffers
> would be checked for modification.
>
>
> But I found out out that having LIMIT-BUFFER-SAVING with value t like
> this would not work without an accompanying change to
> byte-recompile-file - since byte-recompile-file already checks whether
> there's a buffer for that file and that buffer is modified.
>

I don't see where byte-recompile-file is checking that?

> So, since I don't think that doing changes to byte-recompile-file is
> the best idea, here's my current version.
>
> Also, note that the check in byte-recompile-file actually makes
> calling save-some-buffers somewhat redundant.






This bug report was last modified 7 years and 364 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.