GNU bug report logs - #25339
[PATCH] Remove local variables only used as front ends to others.

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Chris Gregory <czipperz <at> gmail.com>
Cc: 25339 <at> debbugs.gnu.org
Subject: bug#25339: [PATCH] Remove local variables only used as front ends to others.
Date: Sat, 07 Jan 2017 10:22:02 +0200

tags 25339 notabug
close 25339
thanks

> From: Chris Gregory <czipperz <at> gmail.com>
> Date: Mon, 02 Jan 2017 14:37:53 -0800
> 
> diff --git a/src/term.c b/src/term.c
> index c067a86d18..d70e2bc9d7 100644
> --- a/src/term.c
> +++ b/src/term.c
> @@ -4161,12 +4161,10 @@ use the Bourne shell command 'TERM=...; export TERM' (C-shell:\n\
>  #ifdef WINDOWSNT
>    {
>      struct frame *f = XFRAME (selected_frame);
> -    int height, width;
> -
> -    initialize_w32_display (terminal, &width, &height);
> +    int height;
>  
> +    initialize_w32_display (terminal, &FrameCols (tty), &height);

Thanks, but I consider these changes not to be for the better.  E.g.,
FrameCols could be a macro (and it actually is in the non-WINDOWSNT
case).  Also, the original code looks more natural to me.

So I don't think we should install these changes.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.