From unknown Wed Jun 18 00:26:22 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#25339 <25339@debbugs.gnu.org> To: bug#25339 <25339@debbugs.gnu.org> Subject: Status: [PATCH] Remove local variables only used as front ends to others. Reply-To: bug#25339 <25339@debbugs.gnu.org> Date: Wed, 18 Jun 2025 07:26:22 +0000 retitle 25339 [PATCH] Remove local variables only used as front ends to oth= ers. reassign 25339 emacs submitter 25339 Chris Gregory severity 25339 wishlist tag 25339 notabug patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 02 17:38:09 2017 Received: (at submit) by debbugs.gnu.org; 2 Jan 2017 22:38:09 +0000 Received: from localhost ([127.0.0.1]:39797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOBF3-0004a6-Ho for submit@debbugs.gnu.org; Mon, 02 Jan 2017 17:38:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOBF1-0004Zu-Lo for submit@debbugs.gnu.org; Mon, 02 Jan 2017 17:38:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOBEv-00041b-6m for submit@debbugs.gnu.org; Mon, 02 Jan 2017 17:38:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56755) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cOBEv-00041T-3z for submit@debbugs.gnu.org; Mon, 02 Jan 2017 17:38:01 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOBEt-00032x-Q3 for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2017 17:38:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOBEq-00040U-Mn for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2017 17:37:59 -0500 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]:36382) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cOBEq-000409-H7 for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2017 17:37:56 -0500 Received: by mail-pg0-x242.google.com with SMTP id n5so31533972pgh.3 for ; Mon, 02 Jan 2017 14:37:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=WOj/9MK58NV0dAgbIwIPg4qtkL3AcMqeXy4htSUUZRY=; b=q6Fw2Ir9HEu9I66PyfTzDX2sb4CpqDii3eEA3orioM+y3AHqmhbeM3Km33I4s5gX4c 4EA17Hi/nrWIwT61YVMmqEEgi8Lr3697NdvpDijOaE8j8EskySxtY/rKwDqdRF7PFvTF U58+MpM1+XF5/rPkE55XBG317p1W+h3Xe/iqsVQEDo7p+s6fa+n0N6HplWOqVyJzImzi pqNRvbZFFkjTmp0s1NLXfG4yroSsFPoEUekeVXWTbokV5Y4OE9xmQ8+nvvzLX22OtF9m BkQsh9kiSjam/PdbqUuFo425voqOVdgJXZx1KW10NTFuXts5f6aWQbSd+OF1AQJqe8jf JkLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=WOj/9MK58NV0dAgbIwIPg4qtkL3AcMqeXy4htSUUZRY=; b=kWdmXLGAz7pmUtMfE/ldNKsUXKoYHWUjYNEIt9hScLpcs9T47lw8W+uLAi1F6KL8O9 CrpgjV7EUBLm3SgWvn6Rh16EgM+zhBpBAVZTeYw72xkGcb7DbQlJ5Cg3yGCJW3wNIwQ6 8XiFsFpeA8z+4x0XMiXlADHuRmoZwUC/QgTCew7DXclrKHCunb4ZiFbXBej/wWAB1kgy y4umeGJXCd9PJz57YffLCsx6iNbmSk6t1/fxYCecGhRzC3WU70m14ZyRIZ8932W6MCSX q77AcF7EBrjgcS+U0iCEny7XwRpu5hUqv0WjVL/Hpc6vkAbzKM8Mncn5pPtIwtqzqAUh T7aw== X-Gm-Message-State: AIkVDXLKue2c49ulA3ZNprjnDupg7omaVvHpMZHykmAfF0aYr1L6lUG/QJK4gDIVnjUoxw== X-Received: by 10.99.253.85 with SMTP id m21mr112116089pgj.38.1483396675416; Mon, 02 Jan 2017 14:37:55 -0800 (PST) Received: from CzipperZeroArch (c-50-139-114-145.hsd1.or.comcast.net. [50.139.114.145]) by smtp.gmail.com with ESMTPSA id n25sm134588803pfi.33.2017.01.02.14.37.54 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Jan 2017 14:37:55 -0800 (PST) From: Chris Gregory To: bug-gnu-emacs@gnu.org Subject: [PATCH] Remove local variables only used as front ends to others. Date: Mon, 02 Jan 2017 14:37:53 -0800 Message-ID: <87bmvpccla.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) -- Chris Gregory diff --git a/src/term.c b/src/term.c index c067a86d18..d70e2bc9d7 100644 --- a/src/term.c +++ b/src/term.c @@ -4161,12 +4161,10 @@ use the Bourne shell command 'TERM=...; export TERM' (C-shell:\n\ #ifdef WINDOWSNT { struct frame *f = XFRAME (selected_frame); - int height, width; - - initialize_w32_display (terminal, &width, &height); + int height; + initialize_w32_display (terminal, &FrameCols (tty), &height); FrameRows (tty) = height; - FrameCols (tty) = width; tty->specified_window = height; FRAME_VERTICAL_SCROLL_BAR_TYPE (f) = vertical_scroll_bar_none; @@ -4176,14 +4174,11 @@ use the Bourne shell command 'TERM=...; export TERM' (C-shell:\n\ } #else /* MSDOS */ { - int height, width; if (strcmp (terminal_type, "internal") == 0) terminal->type = output_msdos_raw; initialize_msdos_display (terminal); - get_tty_size (fileno (tty->input), &width, &height); - FrameCols (tty) = width; - FrameRows (tty) = height; + get_tty_size (fileno (tty->input), &FrameCols (tty), &FrameRows (tty)); tty->char_ins_del_ok = 0; init_baud_rate (fileno (tty->input)); } @@ -4229,12 +4224,7 @@ use the Bourne shell command 'TERM=...; export TERM' (C-shell:\n\ term_get_fkeys (address, terminal->kboard); /* Get frame size from system, or else from termcap. */ - { - int height, width; - get_tty_size (fileno (tty->input), &width, &height); - FrameCols (tty) = width; - FrameRows (tty) = height; - } + get_tty_size (fileno (tty->input), &FrameCols (tty), &FrameRows (tty)); if (FrameCols (tty) <= 0) FrameCols (tty) = tgetnum ("co"); From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 07 03:21:52 2017 Received: (at control) by debbugs.gnu.org; 7 Jan 2017 08:21:52 +0000 Received: from localhost ([127.0.0.1]:45556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPmG8-00080r-Jp for submit@debbugs.gnu.org; Sat, 07 Jan 2017 03:21:52 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPmG7-00080f-23 for control@debbugs.gnu.org; Sat, 07 Jan 2017 03:21:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPmFy-0006DC-2f for control@debbugs.gnu.org; Sat, 07 Jan 2017 03:21:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPmFx-0006D8-Vi; Sat, 07 Jan 2017 03:21:42 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1968 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cPmFx-0005zE-3g; Sat, 07 Jan 2017 03:21:41 -0500 Date: Sat, 07 Jan 2017 10:22:02 +0200 Message-Id: <83zij3b7px.fsf@gnu.org> From: Eli Zaretskii To: Chris Gregory In-reply-to: <87bmvpccla.fsf@gmail.com> (message from Chris Gregory on Mon, 02 Jan 2017 14:37:53 -0800) Subject: Re: bug#25339: [PATCH] Remove local variables only used as front ends to others. References: <87bmvpccla.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.2 (--------) X-Debbugs-Envelope-To: control Cc: 25339@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.2 (--------) tags 25339 notabug close 25339 thanks > From: Chris Gregory > Date: Mon, 02 Jan 2017 14:37:53 -0800 > > diff --git a/src/term.c b/src/term.c > index c067a86d18..d70e2bc9d7 100644 > --- a/src/term.c > +++ b/src/term.c > @@ -4161,12 +4161,10 @@ use the Bourne shell command 'TERM=...; export TERM' (C-shell:\n\ > #ifdef WINDOWSNT > { > struct frame *f = XFRAME (selected_frame); > - int height, width; > - > - initialize_w32_display (terminal, &width, &height); > + int height; > > + initialize_w32_display (terminal, &FrameCols (tty), &height); Thanks, but I consider these changes not to be for the better. E.g., FrameCols could be a macro (and it actually is in the non-WINDOWSNT case). Also, the original code looks more natural to me. So I don't think we should install these changes. From unknown Wed Jun 18 00:26:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 04 Feb 2017 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator