From unknown Sun Aug 17 22:11:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25338: [PATCH] Remove local variable with only one usage Resent-From: Chris Gregory Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Jan 2017 21:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25338 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 25338@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14833938226838 (code B ref -1); Mon, 02 Jan 2017 21:51:01 +0000 Received: (at submit) by debbugs.gnu.org; 2 Jan 2017 21:50:22 +0000 Received: from localhost ([127.0.0.1]:39745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOAUn-0001mE-PA for submit@debbugs.gnu.org; Mon, 02 Jan 2017 16:50:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOAUm-0001lf-62 for submit@debbugs.gnu.org; Mon, 02 Jan 2017 16:50:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOAUf-0003Mn-Sr for submit@debbugs.gnu.org; Mon, 02 Jan 2017 16:50:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58381) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cOAUf-0003MZ-Ot for submit@debbugs.gnu.org; Mon, 02 Jan 2017 16:50:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOAUe-0002yb-CR for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2017 16:50:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOAUZ-0003HC-EP for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2017 16:50:12 -0500 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]:35359) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cOAUZ-0003FC-8w for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2017 16:50:07 -0500 Received: by mail-pg0-x242.google.com with SMTP id i5so31454205pgh.2 for ; Mon, 02 Jan 2017 13:50:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=dNTSzPOp02YNC3gc+6R30ViFZSpioL5UcjBOF8KW/qk=; b=C7zCug3nuUEDDv6gihEIMF8twI6NG4xN8S5nR9CZ5LzGVkkZjoAfp94DJr6MM9OQP9 kHgSMZY1tFbLP3Kn2Mzp5tVV+9IbPVmzRcKsKVaqfdd1iKhtiwduSEvgvO3jwO5kikQn +MgR3rII26UHoV3ZeszUHXY217yj81g1iNH1Cb7xU+mcfNEH/ZIcGVwBWHIqeChhpcbY 3vn+lxcvu5iyRpQEPJNA/Qi6XvNmUd+ezcoivVYQ+dkDP7p8YmMXBqkqDk8Zf1eyQ5I+ 8m1dIonI6v+PAETrQHL7scGf6oL0/0J8AOcQzXXR/UXiCPYhyZPwjnYDf59O1wj5mjKa Eqjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=dNTSzPOp02YNC3gc+6R30ViFZSpioL5UcjBOF8KW/qk=; b=cuGbwuIgXzUlLnPofz4XIxM2Ylq/lrIxVv8ogZdiVrNmsKqSW51tQfJqNQlC8Sbok2 OvXyiA0LPmKaOCUaAC5VRa1sEithkjVyVBhjxPUy+CuY/DucsXeyobd28FcGhv4R8Ems yvIMC9Xe/rTz3NCjy/pCO08TM35ji6a2STr5PoffReEx5OiawVhiPaKfq5u/fgvW3wLC J9AZrA15sV6QKdYruJcekCSpX1SXfmAbD13g7ttc1Y3E4kGMgcz2Yy2HaYbdxfmkhbuV 8Fk03QI4EFzEnNrix5hnpjZ2qdgno3D+ifta48LLDkOjf0/rd8LEXLOYoluQahi+jYvT Lk4Q== X-Gm-Message-State: AIkVDXJZldEH8XnP2c2HNxVGOQydMuq3Q8ReM6eUMF/c6QCaGYpnR92KuY00MqprlIdmhQ== X-Received: by 10.84.195.228 with SMTP id j91mr127413928pld.88.1483393806042; Mon, 02 Jan 2017 13:50:06 -0800 (PST) Received: from CzipperZeroArch (c-50-139-114-145.hsd1.or.comcast.net. [50.139.114.145]) by smtp.gmail.com with ESMTPSA id w5sm134587689pfl.31.2017.01.02.13.50.05 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Jan 2017 13:50:05 -0800 (PST) From: Chris Gregory Date: Mon, 02 Jan 2017 13:50:01 -0800 Message-ID: <87eg0lcet2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) -- Chris Gregory diff --git a/src/term.c b/src/term.c index c067a86d18..0e8ad60de4 100644 --- a/src/term.c +++ b/src/term.c @@ -3426,10 +3426,7 @@ tty_menu_last_menubar_item (struct frame *f) while (i < ASIZE (items)) { - Lisp_Object str; - - str = AREF (items, i + 1); - if (NILP (str)) + if (NILP (AREF (items, i + 1))) break; i += 4; } From unknown Sun Aug 17 22:11:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25338: [PATCH] Remove local variable with only one usage Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jan 2017 08:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25338 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Chris Gregory Cc: 25338@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 25338-submit@debbugs.gnu.org id=B25338.148377759031279 (code B ref 25338); Sat, 07 Jan 2017 08:27:02 +0000 Received: (at 25338) by debbugs.gnu.org; 7 Jan 2017 08:26:30 +0000 Received: from localhost ([127.0.0.1]:45568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPmKb-00088Q-MI for submit@debbugs.gnu.org; Sat, 07 Jan 2017 03:26:29 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPmKa-00088B-KK for 25338@debbugs.gnu.org; Sat, 07 Jan 2017 03:26:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPmKR-00073J-LT for 25338@debbugs.gnu.org; Sat, 07 Jan 2017 03:26:23 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPmKH-00072q-VF; Sat, 07 Jan 2017 03:26:09 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1972 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cPmKG-0006FL-QV; Sat, 07 Jan 2017 03:26:09 -0500 Date: Sat, 07 Jan 2017 10:26:30 +0200 Message-Id: <83y3ynb7ih.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87eg0lcet2.fsf@gmail.com> (message from Chris Gregory on Mon, 02 Jan 2017 13:50:01 -0800) References: <87eg0lcet2.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.2 (--------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.2 (--------) tags 25338 notabug close 25338 thanks > From: Chris Gregory > Date: Mon, 02 Jan 2017 13:50:01 -0800 Thanks. IMO, we are splitting hair here. In an optimized build, a compiler will optimize 'str' and keep the value in a register, so the variable doesn't matter. In a non-optimized build, the existence of the variable allows to look at it in a debugger. And the loop is small enough so that an extra variable local to the loop doesn't make it more complicated. So I'd rather not make this change.