GNU bug report logs - #25337
space after compile-command is a hack

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25337 in the body.
You can then email your comments to 25337 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: space after compile-command is a hack
Date: Tue, 03 Jan 2017 05:39:52 +0800

compile-command is a variable defined in ‘compile.el’.
Its value is "make -k "

You know that trailing space is a hack and shouldn't need to be inserted
by the user.

E.g., I did
(setq compile-command "make")
and now I regret it... I'm now going to have to use
(setq compile-command "make ")

Message #8 received at 25337 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 25337 <at> debbugs.gnu.org
Subject: Re: bug#25337: space after compile-command is a hack
Date: Mon, 02 Jan 2017 16:51:12 -0500

tags 25337 moreinfo
quit

積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> compile-command is a variable defined in ‘compile.el’.
> Its value is "make -k "
>
> You know that trailing space is a hack and shouldn't need to be inserted
> by the user.

I don't understand, the user *doesn't* need to insert it.  They can do
so if they wish...

>
> E.g., I did
> (setq compile-command "make")
> and now I regret it... I'm now going to have to use
> (setq compile-command "make ")

What do you want to be different?

Message #13 received at 25337 <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: npostavs <at> users.sourceforge.net
Cc: 25337 <at> debbugs.gnu.org
Subject: Re: bug#25337: space after compile-command is a hack
Date: Tue, 03 Jan 2017 05:58:12 +0800

If one doesn't insert the space, then you have to add it each time,
else you will execute makea.out instead of make a.out.

Message #16 received at 25337 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 25337 <at> debbugs.gnu.org
Subject: Re: bug#25337: space after compile-command is a hack
Date: Mon, 02 Jan 2017 17:28:28 -0500

積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> If one doesn't insert the space, then you have to add it each time,
> else you will execute makea.out instead of make a.out.

So how do you want Emacs to behave differently?

Message #19 received at 25337 <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: npostavs <at> users.sourceforge.net
Cc: 25337 <at> debbugs.gnu.org
Subject: Re: bug#25337: space after compile-command is a hack
Date: Tue, 03 Jan 2017 07:22:18 +0800

n> So how do you want Emacs to behave differently?

At least in the compile-command docstring mention "be sure to add a
space at the end."

Message #22 received at 25337 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 25337 <at> debbugs.gnu.org
Subject: Re: bug#25337: space after compile-command is a hack
Date: Mon, 02 Jan 2017 19:58:08 -0500

積丹尼 Dan Jacobson <jidanni <at> jidanni.org> writes:

> n> So how do you want Emacs to behave differently?
>
> At least in the compile-command docstring mention "be sure to add a
> space at the end."

I feel like this is redundant.  "If you want a space at the end of the
string, don't remove the space from the end of the string."  It could
apply to any variable.

Message #25 received at 25337 <at> debbugs.gnu.org (full text, mbox):

From: Richard Stallman <rms <at> gnu.org>
To: npostavs <at> users.sourceforge.net
Cc: 25337 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#25337: space after compile-command is a hack
Date: Tue, 03 Jan 2017 18:22:05 -0500

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > I feel like this is redundant.  "If you want a space at the end of the
  > string, don't remove the space from the end of the string."  It could
  > apply to any variable.

I suggest, "It is often useful to leave a space at the end of the
value."

-- 
Dr Richard Stallman
President, Free Software Foundation (gnu.org, fsf.org)
Internet Hall-of-Famer (internethalloffame.org)
Skype: No way! See stallman.org/skype.html.

Message #28 received at 25337 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Richard Stallman <rms <at> gnu.org>
Cc: jidanni <at> jidanni.org, 25337 <at> debbugs.gnu.org
Subject: Re: bug#25337: space after compile-command is a hack
Date: Sun, 08 Jan 2017 12:15:11 -0500

tags 25337 = fixed
close 25337 25.2
quit

Richard Stallman <rms <at> gnu.org> writes:
>
> I suggest, "It is often useful to leave a space at the end of the
> value."

Looks reasonable, I've pushed a patch with that addition to emacs-25.

1: 2017-01-07 09:30:00 -0500 fc38671988d2d9c3ddb865bdc3a44e827fdb23ed
  Add helpful comment to compile-command's docstring

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.