GNU bug report logs - #2533
23.0.90; [PATCH] rmail: improve rmail-add/kill-label docstring

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: Xavier Maillard <xma <at> gnu.org>
Subject: bug#2533 closed by Glenn Morris <rgm <at> gnu.org> (Re: bug#2533: 
 23.0.90; [PATCH] rmail: improve rmail-add/kill-label docstring)
Date: Thu, 05 Mar 2009 05:35:05 +0000

[Message part 1 (text/plain, inline)]

This is an automatic notification regarding your bug report
which was filed against the emacs,rmail package:

#2533: 23.0.90; [PATCH] rmail: improve rmail-add/kill-label docstring

It has been closed by Glenn Morris <rgm <at> gnu.org>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Glenn Morris <rgm <at> gnu.org> by
replying to this email.


-- 
2533: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=2533
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 2533-done <at> debbugs.gnu.org
Subject: Re: bug#2533: 23.0.90; [PATCH] rmail: improve rmail-add/kill-label docstring
Date: Thu, 5 Mar 2009 00:26:32 -0500

tags 2533 notabug wontfix
stop

Glenn Morris wrote (on Thu, 5 Mar 2009 at 00:20 -0500):

> If you try to add mutiple labels without spaces after the comma, it
> won't work right.

And it certainly does not work in the kill case, unless you happen to
specify the labels in the same order as they appear.

It's just a coincidence that these commands may sometimes work for
multiple labels.

[Message part 3 (message/rfc822, inline)]

From: Xavier Maillard <xma <at> gnu.org>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.90; [PATCH] rmail: improve rmail-add/kill-label docstring
Date: Mon, 2 Mar 2009 02:25:03 +0100

When using keys 'a' or 'k' in a `rmail-summary' buffer, it is not
obvious user can type multiple labels as "comma-separated list of
labels". OTOH, it is clearly announced when user wants to
summarize by labels. The patch enclosed tries to clarify this.

Hope that'll help.

ChangeLog proposed:

2009-03-01  Xavier Maillard  <xma <at> gnu.org>

	* mail/rmailsum.el (rmail-summary-add-label)
	(rmail-summary-kill-label): Fix docstrings. Indicate user can type
	multiple comma-separted list of labels.


Patch:

diff --git a/lisp/mail/rmailsum.el b/lisp/mail/rmailsum.el
index 6940f3d..1ae0bd9 100644
--- a/lisp/mail/rmailsum.el
+++ b/lisp/mail/rmailsum.el
@@ -1542,7 +1542,8 @@ Interactively, empty argument means use same regexp used last time."
 
 (defun rmail-summary-add-label (label)
   "Add LABEL to labels associated with current Rmail message.
-Completion is performed over known labels when reading."
+Completion is performed over known labels when reading.
+LABEL may be a comma-separated list of labels."
   (interactive (list (save-excursion
 		       (set-buffer rmail-buffer)
 		       (rmail-read-label "Add label"))))
@@ -1552,7 +1553,8 @@ Completion is performed over known labels when reading."
 
 (defun rmail-summary-kill-label (label)
   "Remove LABEL from labels associated with current Rmail message.
-Completion is performed over known labels when reading."
+Completion is performed over known labels when reading.
+LABEL may be a comma-separated list of labels."
   (interactive (list (save-excursion
 		       (set-buffer rmail-buffer)
 		       (rmail-read-label "Kill label"))))

Recent input:
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <down> <down> <down> 
<down> <down> <down> <up> C-x u C-x u C-SPC C-w C-SPC 
C-a M-w C-x b <return> C-s C-s C-s C-s <return> <down> 
<down> <down> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> C-y <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> C-SPC <right> <right> <right> <right> 
<right> <right> C-w <right> <right> <right> <right> 
<right> <right> <right> <right> C-x b x m a - s u <tab> 
<return> a ' t e s t <return> k g n u <tab> - e m <tab> 
<return> k ' t e <tab> <return> k e <backspace> t e 
s <tab> t SPC <backspace> <backspace> <backspace> <backspace> 
t e s t <return> k <return> <up> <down> SPC C-x C-b 
<up> <up> <return> C-x 1 <right> C-SPC <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> C-w <right> <right> <right> <right> <right> 
<right> C-SPC <right> <right> <right> C-w <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> C-a C-SPC C-e <left> M-w <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <up> C-e <return> C-y <down> <up> C-SPC 
<down> <left> C-w C-x C-s C-x v = <switch-frame> C-x 
1 <down> M-k C-x 1 C-x 1 <right> <left> C-x 0 C-x b 
C-g C-x 1 C-x b <return> C-x 1 C-l / b <switch-frame> 
C-x 5 0 M-x e m <backspace> <backspace> r e p o r t 
- e m <tab> <return>

Recent messages:
Mark activated
Updating buffer list...
Mark set
Updating buffer list...done
Commands: m, u, t, RET, g, k, S, D, Q; q to quit; h for help
Mark set [5 times]
Saving file /home/xma/usr/src/GITed/emacs/lisp/mail/rmailsum.el...
Wrote /home/xma/usr/src/GITed/emacs/lisp/mail/rmailsum.el
Finding changes in /home/xma/usr/src/GITed/emacs/lisp/mail/rmailsum.el...
call-interactively: Attempt to delete minibuffer or sole ordinary window
Quit

	Xavier
-- 
http://www.gnu.org
http://www.april.org
http://www.lolica.org

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.