GNU bug report logs - #25304
Libtool's ltmain.sh should have its shebang preserved

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: ng0 <ng0 <at> pragmatique.xyz>
Subject: bug#26749: closed (Re: bug#25304: Libtool’s
 ltmain.sh still contains a /gnu/store shebang)
Date: Mon, 16 Nov 2020 16:18:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#25304: mask files from shebang patcher (git, libtool and stagit)

which was filed against the guix package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 26749 <at> debbugs.gnu.org.

-- 
25304: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25304
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Miguel Ángel Arruga Vivas <rosen644835 <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 25304-done <at> debbugs.gnu.org
Subject: Re: bug#25304: Libtool’s ltmain.sh still
 contains a /gnu/store shebang
Date: Mon, 16 Nov 2020 17:17:05 +0100

[Message part 3 (text/plain, inline)]

Hi!

Ludovic Courtès <ludo <at> gnu.org> writes:
> Hi!
>
> Miguel Ángel Arruga Vivas <rosen644835 <at> gmail.com> skribis:
>
>> I was looking through the lists because I have a patch that does exactly
>> what you describe here.  I guess this goes to core updates, so this
>> version is on top of it.  WDYT?
>
> Yes, looks like a change for ‘core-updates’.
>
>> From 145273418d3131bcf3b73d416d19f641645cf3f8 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Miguel=20=C3=81ngel=20Arruga=20Vivas?=
>>  <rosen644835 <at> gmail.com>
>> Date: Fri, 13 Nov 2020 15:24:46 +0100
>> Subject: [PATCH] gnu: libtool: Restore shebangs on all libtoolize files.
>
> You can add “Fixes <https://bugs.gnu.org/25304>.”
>
>> * gnu/packages/autotools.scm (libtool)[restore-build-aux-shebang]: New
>> phase after install.
>> [restore-ltmain-shebang]: Remove phase, it is now performed by the phase
>> restore-build-aux-shebang.
>
> LGTM, thanks for digging through old bugs!
>
> Ludo’.

Pushed as 8d263ff254292c9e13a9848f90b52263da52d570 to core-updates with
that line added.  Thanks for the quick review.  :-)

Happy hacking!
Miguel

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: ng0 <ng0 <at> pragmatique.xyz>
To: bug-guix <at> gnu.org
Subject: stagit: do not patch example.sh shebang
Date: Tue, 2 May 2017 16:15:52 +0000

Hi,
I just noticed that stagit's example.sh has a patched shebang.
While I would assume that everyone notices when this fails,
it would probably be good to not make too optimistic assumptions
and keep #!/bin/sh in the file.
-- 
https://pragmatique.xyz
PGP: https://people.pragmatique.xyz/ng0/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.