From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 30 18:34:56 2016 Received: (at submit) by debbugs.gnu.org; 30 Dec 2016 23:34:56 +0000 Received: from localhost ([127.0.0.1]:60716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cN6hL-0007Se-Pg for submit@debbugs.gnu.org; Fri, 30 Dec 2016 18:34:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cN6hK-0007SQ-4R for submit@debbugs.gnu.org; Fri, 30 Dec 2016 18:34:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cN6hE-0002Y7-Bx for submit@debbugs.gnu.org; Fri, 30 Dec 2016 18:34:49 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43876) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cN6hE-0002Xk-9G for submit@debbugs.gnu.org; Fri, 30 Dec 2016 18:34:48 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cN6hD-0003TL-Ax for bug-guix@gnu.org; Fri, 30 Dec 2016 18:34:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cN6hA-0002Uh-03 for bug-guix@gnu.org; Fri, 30 Dec 2016 18:34:47 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cN6h9-0002Uc-Si; Fri, 30 Dec 2016 18:34:43 -0500 Received: from reverse-83.fdn.fr ([80.67.176.83]:53680 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cN6h9-0007Cp-5L; Fri, 30 Dec 2016 18:34:43 -0500 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Ricardo Wurmus Subject: Re: Seeking advice: preparing releases on GuixSD. References: <874m1uvkdz.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> <874m1ty6rd.fsf@elephly.net> <87a8blpeqs.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> <871swxxrzc.fsf@elephly.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 11 =?utf-8?Q?Niv=C3=B4se?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Sat, 31 Dec 2016 00:34:40 +0100 In-Reply-To: <871swxxrzc.fsf@elephly.net> (Ricardo Wurmus's message of "Sat, 24 Dec 2016 16:32:39 +0100") Message-ID: <878tqx7zzj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -8.2 (--------) X-Debbugs-Envelope-To: submit Cc: help-guix@gnu.org, ng0 , bug-guix@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.2 (--------) Hi! Ricardo Wurmus skribis: > =E2=80=9Cltmain.sh=E2=80=9D is instantiated from a template by libtool. = It originally > contains a /bin/sh shebang, and I think it should not be patched when > installed to > > /gnu/store/=E2=80=A6-libtool-2.4.6/share/libtool/build-aux/ltmain.sh > > This seems like a bug to me. Definitely: --8<---------------cut here---------------start------------->8--- $ head -1 $(find $(guix build libtool) -name ltmain.sh) #!/gnu/store/qkw4zrwfybxww8f56nkb6hggxambk89b-bash-4.4.0/bin/sh --8<---------------cut here---------------end--------------->8--- Opening a new bug now. This is with v0.12.0-176-ge087671. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 31 16:01:35 2017 Received: (at control) by debbugs.gnu.org; 31 Jan 2017 21:01:35 +0000 Received: from localhost ([127.0.0.1]:52595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYfYV-0003nO-6F for submit@debbugs.gnu.org; Tue, 31 Jan 2017 16:01:35 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:41606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYfYT-0003nD-5F for control@debbugs.gnu.org; Tue, 31 Jan 2017 16:01:33 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id EEF1BB661 for ; Tue, 31 Jan 2017 22:01:31 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NpbruBPsPNCJ for ; Tue, 31 Jan 2017 22:01:30 +0100 (CET) Received: from ribbon (reverse-83.fdn.fr [80.67.176.83]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 704DAB660 for ; Tue, 31 Jan 2017 22:01:30 +0100 (CET) Date: Tue, 31 Jan 2017 22:01:29 +0100 Message-Id: <8737fzeyfq.fsf@gnu.org> To: control@debbugs.gnu.org From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: control message for bug #25304 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) retitle 25304 Libtool's ltmain.sh should have its shebang preserved From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 31 16:03:33 2017 Received: (at 25304-done) by debbugs.gnu.org; 31 Jan 2017 21:03:33 +0000 Received: from localhost ([127.0.0.1]:52599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYfaP-0003qT-JE for submit@debbugs.gnu.org; Tue, 31 Jan 2017 16:03:33 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYfaN-0003qG-Ot for 25304-done@debbugs.gnu.org; Tue, 31 Jan 2017 16:03:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cYfaH-0007BY-W4 for 25304-done@debbugs.gnu.org; Tue, 31 Jan 2017 16:03:26 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cYfa9-0007AQ-Om; Tue, 31 Jan 2017 16:03:17 -0500 Received: from reverse-83.fdn.fr ([80.67.176.83]:47070 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cYfa9-0006H7-42; Tue, 31 Jan 2017 16:03:17 -0500 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Ricardo Wurmus Subject: Re: bug#25304: Seeking advice: preparing releases on GuixSD. References: <874m1uvkdz.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> <874m1ty6rd.fsf@elephly.net> <87a8blpeqs.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> <871swxxrzc.fsf@elephly.net> <878tqx7zzj.fsf@gnu.org> Date: Tue, 31 Jan 2017 22:03:14 +0100 In-Reply-To: <878tqx7zzj.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 31 Dec 2016 00:34:40 +0100") Message-ID: <87y3xrdjsd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25304-done Cc: 25304-done@debbugs.gnu.org, ng0@libertad.pw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) ludo@gnu.org (Ludovic Court=C3=A8s) skribis: > Ricardo Wurmus skribis: > >> =E2=80=9Cltmain.sh=E2=80=9D is instantiated from a template by libtool. = It originally >> contains a /bin/sh shebang, and I think it should not be patched when >> installed to >> >> /gnu/store/=E2=80=A6-libtool-2.4.6/share/libtool/build-aux/ltmain.sh >> >> This seems like a bug to me. > > Definitely: > > $ head -1 $(find $(guix build libtool) -name ltmain.sh) > #!/gnu/store/qkw4zrwfybxww8f56nkb6hggxambk89b-bash-4.4.0/bin/sh > > Opening a new bug now. This is with v0.12.0-176-ge087671. This was fixed by ng0 in 98341757c8c45fca8d2b53f9972f5c6a32cf2c95. Ludo=E2=80=99. From unknown Sun Aug 10 16:49:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 01 Mar 2017 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From unknown Sun Aug 10 16:49:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Fri, 21 Apr 2017 14:25:01 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 21 10:26:50 2017 Received: (at control) by debbugs.gnu.org; 21 Apr 2017 14:26:50 +0000 Received: from localhost ([127.0.0.1]:60929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1ZWM-0006LK-83 for submit@debbugs.gnu.org; Fri, 21 Apr 2017 10:26:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1ZWL-0006L6-6R for control@debbugs.gnu.org; Fri, 21 Apr 2017 10:26:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d1ZWC-0005AB-Qa for control@debbugs.gnu.org; Fri, 21 Apr 2017 10:26:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d1ZWC-0005A7-N7 for control@debbugs.gnu.org; Fri, 21 Apr 2017 10:26:40 -0400 Received: from [193.50.110.185] (port=53272 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d1ZWC-0000B6-76 for control@debbugs.gnu.org; Fri, 21 Apr 2017 10:26:40 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: control@debbugs.gnu.org Subject: unarchive X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 2 =?utf-8?Q?Flor=C3=A9al?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Fri, 21 Apr 2017 16:26:38 +0200 Message-ID: <87shl125wh.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) unarchive 25304 thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 21 10:30:55 2017 Received: (at 25304) by debbugs.gnu.org; 21 Apr 2017 14:30:55 +0000 Received: from localhost ([127.0.0.1]:60938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1ZaJ-0007Cm-1j for submit@debbugs.gnu.org; Fri, 21 Apr 2017 10:30:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1ZaH-00077E-PL for 25304@debbugs.gnu.org; Fri, 21 Apr 2017 10:30:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d1Za9-0006Xx-EN for 25304@debbugs.gnu.org; Fri, 21 Apr 2017 10:30:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35501) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d1Za9-0006Xt-Au for 25304@debbugs.gnu.org; Fri, 21 Apr 2017 10:30:45 -0400 Received: from [193.50.110.185] (port=53274 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d1Za8-0006gd-PM for 25304@debbugs.gnu.org; Fri, 21 Apr 2017 10:30:45 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: 25304@debbugs.gnu.org Subject: =?utf-8?Q?Libtool=E2=80=99s?= ltmain.sh still contains a /gnu/store shebang X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 2 =?utf-8?Q?Flor=C3=A9al?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Fri, 21 Apr 2017 16:30:43 +0200 Message-ID: <87mvb925po.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25304 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi, Commit 98341757c8c45fca8d2b53f9972f5c6a32cf2c95, which was meant to fix this bug=C2=B9, actually failed to do so: --8<---------------cut here---------------start------------->8--- $ head -1 $(./pre-inst-env guix build libtool)/share/libtool/build-aux/ltma= in.sh #!/gnu/store/k7029k5va68lkapbzcycdzj7m5bjb4b8-bash-4.4.12/bin/sh $ git describe v0.12.0-3136-g7312c62d3 --8<---------------cut here---------------end--------------->8--- I think the problem is that we=E2=80=99re patching ltmain.in when we should really be patching the final file, after the =E2=80=98patch-shebangs=E2=80= =99 phase. Ludo=E2=80=99. =C2=B9 From unknown Sun Aug 10 16:49:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 20 May 2017 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From unknown Sun Aug 10 16:49:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Wed, 18 Mar 2020 20:32:01 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 18 16:31:32 2020 Received: (at control) by debbugs.gnu.org; 18 Mar 2020 20:31:32 +0000 Received: from localhost ([127.0.0.1]:41471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEfLf-0006Jh-Su for submit@debbugs.gnu.org; Wed, 18 Mar 2020 16:31:32 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:57806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEfLe-0006JQ-4P for control@debbugs.gnu.org; Wed, 18 Mar 2020 16:31:30 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jEfLU-0002EE-3x for control@debbugs.gnu.org; Wed, 18 Mar 2020 16:31:20 -0400 Date: Wed, 18 Mar 2020 16:31:19 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net To: control@debbugs.gnu.org Subject: Merging issues for not patching some shebang in examples Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) reopen 25304 severity 25304 important severity 25508 important merge 25508 25304 26749 retitle 26749 mask files from shebang patcher (git, libtool and stagit) From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 18 16:38:00 2020 Received: (at control) by debbugs.gnu.org; 18 Mar 2020 20:38:00 +0000 Received: from localhost ([127.0.0.1]:41477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEfRw-0006U8-LK for submit@debbugs.gnu.org; Wed, 18 Mar 2020 16:38:00 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:57850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jEfRv-0006Tp-6E for control@debbugs.gnu.org; Wed, 18 Mar 2020 16:37:59 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jEfRp-0002PT-OA for control@debbugs.gnu.org; Wed, 18 Mar 2020 16:37:53 -0400 Date: Wed, 18 Mar 2020 16:37:53 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net To: control@debbugs.gnu.org Subject: Merge bugs related to masking files from shebang patcher Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) unarchive 25304 reopen 25304 severity 25304 important merge 25508 25304 26749 thanks From unknown Sun Aug 10 16:49:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Wed, 18 Mar 2020 20:38:01 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 13 10:32:37 2020 Received: (at 25304) by debbugs.gnu.org; 13 Nov 2020 15:32:37 +0000 Received: from localhost ([127.0.0.1]:49111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdb40-0004MZ-Sq for submit@debbugs.gnu.org; Fri, 13 Nov 2020 10:32:37 -0500 Received: from mail-wr1-f46.google.com ([209.85.221.46]:44265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdb3v-0004MH-M6 for 25304@debbugs.gnu.org; Fri, 13 Nov 2020 10:32:35 -0500 Received: by mail-wr1-f46.google.com with SMTP id c17so10308827wrc.11 for <25304@debbugs.gnu.org>; Fri, 13 Nov 2020 07:32:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=kVIiwtgQR9p7+8KPDABZyh/sP7xe1nvhII/zY2YHGzY=; b=RH9E172cUCcxQehcZV5YkuZvpMZFKAMYTt6Y4TxA2hIB1rTL2aDN2SID8WkN7QrvDh VN1dvTMuEyREQRNmenxS+cD9MHoIUqBBeRO1/7a2jhcQ2JpwtmH5MU5JOpCHnHLSHCEk iSdemg7DLgnnzhOdpQJT+435OqOFoSheinnknsVRnlAyyvdWEfXy8os40FJRgP3BkEAS azcQykaaWyEvpPTRE/9eNWXFLnOvuX14fPPfscjm6L+HuLSAdKWh9SelUgbzUrfmbvOl xP23+JVx+WaedjoMuiJpmsI9w6H+1MmXHEQ+phHzBMWjocGUjBUik8iK8iqqZB8qM6vy JnQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=kVIiwtgQR9p7+8KPDABZyh/sP7xe1nvhII/zY2YHGzY=; b=G+pQaAmTAesUF6wsZvXydABpolPbTwvkDAIIJ/4ZznBdrhLnmzgn/hph9pl4invHbZ kt7/c7/IdFvXd7Py4QskRDaazfsHiZ0uoyWRaodthuiKmY501eqSBJt68aaFcgy4aoVY lMKWSHFthSZYZDl2J0Afuqd5X8RDsI8ohOjYHRKBNieyFj2X4FPeUc5587nfUuoccePm D+6mI2tDMaabL7ByPF8WOXGW77DMi1UeDIS7eKPZ1fREASn8nYlW5Ob7J5/e31z4HR5y s1NVhIDvq2outjHVbvZ21Bmj0JvG4GajiPHstkghPcmKuou326muOALaDwat/PhrXFmH U/5w== X-Gm-Message-State: AOAM533o75YM/zyLv697a4RpKjl6IT5hsoFq76uAIh1jjv5sJ10hmBMh IYwJMPmAe/um7i3Q+Q7plm7WxQVEacM= X-Google-Smtp-Source: ABdhPJwtp9qlMnFOOYSDXcacTgc1X0NuOvPX+wfGpP9GKalAzm53jNk+1ty99TcmUU83CzWWWEZk9A== X-Received: by 2002:a5d:4bc7:: with SMTP id l7mr4420619wrt.105.1605281541338; Fri, 13 Nov 2020 07:32:21 -0800 (PST) Received: from unfall (20.134.94.90.dynamic.jazztel.es. [90.94.134.20]) by smtp.gmail.com with ESMTPSA id d3sm11543277wre.91.2020.11.13.07.32.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2020 07:32:20 -0800 (PST) From: =?utf-8?Q?Miguel_=C3=81ngel_Arruga_Vivas?= To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: bug#25304: =?utf-8?Q?Libtool=E2=80=99s?= ltmain.sh still contains a /gnu/store shebang References: <878tqx7zzj.fsf@gnu.org> <87mvb925po.fsf@gnu.org> Date: Fri, 13 Nov 2020 16:32:04 +0100 In-Reply-To: <87mvb925po.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Fri, 21 Apr 2017 16:30:43 +0200") Message-ID: <87v9e9z30r.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 25304 Cc: 25304@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, I was looking through the lists because I have a patch that does exactly what you describe here. I guess this goes to core updates, so this version is on top of it. WDYT? Happy hacking! Miguel ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hi, > > Commit 98341757c8c45fca8d2b53f9972f5c6a32cf2c95, which was meant to fix > this bug=C2=B9, actually failed to do so: > > $ head -1 $(./pre-inst-env guix build libtool)/share/libtool/build-aux/lt= main.sh > #!/gnu/store/k7029k5va68lkapbzcycdzj7m5bjb4b8-bash-4.4.12/bin/sh > $ git describe > v0.12.0-3136-g7312c62d3 > > I think the problem is that we=E2=80=99re patching ltmain.in when we shou= ld > really be patching the final file, after the =E2=80=98patch-shebangs=E2= =80=99 phase. > > Ludo=E2=80=99. > > =C2=B9 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-libtool-Restore-shebangs-on-all-libtoolize-files.patch Content-Transfer-Encoding: quoted-printable Content-Description: 0001-libtoolize.patch From=20145273418d3131bcf3b73d416d19f641645cf3f8 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Miguel=3D20=3DC3=3D81ngel=3D20Arruga=3D20Vivas?=3D Date: Fri, 13 Nov 2020 15:24:46 +0100 Subject: [PATCH] gnu: libtool: Restore shebangs on all libtoolize files. * gnu/packages/autotools.scm (libtool)[restore-build-aux-shebang]: New phase after install. [restore-ltmain-shebang]: Remove phase, it is now performed by the phase restore-build-aux-shebang. =2D-- gnu/packages/autotools.scm | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/gnu/packages/autotools.scm b/gnu/packages/autotools.scm index 96f2925180..c9e1c9bcf1 100644 =2D-- a/gnu/packages/autotools.scm +++ b/gnu/packages/autotools.scm @@ -444,11 +444,19 @@ Makefile, simplifying the entire process for the deve= loper.") (("/bin/sh") (string-append bash "/bin/sh"))) #t))) =2D (add-after 'patch-source-shebangs 'restore-ltmain-shebang =2D (lambda* (#:key inputs #:allow-other-keys) =2D (substitute* "build-aux/ltmain.in" =2D (("^#!.*/bin/sh$") "#!/bin/sh")) =2D #t))))) + ;; These files may be copied into source trees by libtoolize, + ;; therefore they must not point to store file names that would be + ;; leaked with tarballs generated by make dist. + (add-after 'install 'restore-build-aux-shebang + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (dir (string-append out "/share/libtool/build-aux"))) + (for-each (lambda (file) + (format #t "restoring shebang on `~a'~%" file) + (substitute* file + (("^#!.*/bin/sh") "#!/bin/sh"))) + (find-files dir ".*")) + #t)))))) =20 (synopsis "Generic shared library support tools") (description =2D-=20 2.29.2 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEEiIeExBRZrMuD5+hMY0xuiXn6vsIFAl+upvQACgkQY0xuiXn6 vsJ6Xwv9FvnDwhtr63aPHozMYIOWtLuYZaj531dqkbC3vuZjGv9kM+i2qyRA0PPc 80aIWjB3viuQ5/4yLqD23fCNqkkgDKsFWGFPwKv9Lva1iaFurgskwIdsWDBQkp68 Jn0W+hJrMxqEg41PGXGOjnicVBb349M5ruuc65AtqboOFlx7/ETPcZouKd0oWUn4 89CZEIhjbcKf/DbXe1ouUrZMUKoEbpSU1rMVbtz+14fN2leqWfNFKVHNEnHTP3ho VwMQvLwNwzKa2h4ynoDtjq4w/1Ewg/RzyExRRb2EJUFv37KMB4whE+Qj3TfGMaIa 5mY8N8tc6P8wmuQwr0Y5EE5gykJczjM55+1LsctCFDVTbAuJZZNfhmyQdUeDBJ3B s7QwvYTAddFlEwgpPGUSgTTSb1VlGj95qg9YP2QQFTtT1D0jtIh6gE/LqEeOMHkp aARwBxlEqqLJqQtWnJLQ1rh9Flg+KJYb0+MWC+3H4b+BLAJ7DckGHWHxl99AiYIm B9fHHT7d =Gnea -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 06:08:35 2020 Received: (at 25304) by debbugs.gnu.org; 15 Nov 2020 11:08:35 +0000 Received: from localhost ([127.0.0.1]:52626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keFtb-0005Vf-1B for submit@debbugs.gnu.org; Sun, 15 Nov 2020 06:08:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keFtZ-0005VU-On for 25304@debbugs.gnu.org; Sun, 15 Nov 2020 06:08:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41610) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keFtU-0006tr-Cx; Sun, 15 Nov 2020 06:08:28 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=42216 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1keFtU-0001OI-01; Sun, 15 Nov 2020 06:08:28 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Miguel =?utf-8?Q?=C3=81ngel?= Arruga Vivas Subject: Re: bug#25304: =?utf-8?Q?Libtool=E2=80=99s?= ltmain.sh still contains a /gnu/store shebang References: <878tqx7zzj.fsf@gnu.org> <87mvb925po.fsf@gnu.org> <87v9e9z30r.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 25 Brumaire an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 15 Nov 2020 12:08:26 +0100 In-Reply-To: <87v9e9z30r.fsf@gmail.com> ("Miguel =?utf-8?Q?=C3=81ngel?= Arruga Vivas"'s message of "Fri, 13 Nov 2020 16:32:04 +0100") Message-ID: <87v9e6andh.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 25304 Cc: 25304@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Miguel =C3=81ngel Arruga Vivas skribis: > I was looking through the lists because I have a patch that does exactly > what you describe here. I guess this goes to core updates, so this > version is on top of it. WDYT? Yes, looks like a change for =E2=80=98core-updates=E2=80=99. > From 145273418d3131bcf3b73d416d19f641645cf3f8 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Miguel=3D20=3DC3=3D81ngel=3D20Arruga=3D20Vivas?=3D > > Date: Fri, 13 Nov 2020 15:24:46 +0100 > Subject: [PATCH] gnu: libtool: Restore shebangs on all libtoolize files. You can add =E2=80=9CFixes .=E2=80=9D > * gnu/packages/autotools.scm (libtool)[restore-build-aux-shebang]: New > phase after install. > [restore-ltmain-shebang]: Remove phase, it is now performed by the phase > restore-build-aux-shebang. LGTM, thanks for digging through old bugs! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 11:17:23 2020 Received: (at 25304-done) by debbugs.gnu.org; 16 Nov 2020 16:17:23 +0000 Received: from localhost ([127.0.0.1]:56868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kehBz-0002WA-9s for submit@debbugs.gnu.org; Mon, 16 Nov 2020 11:17:23 -0500 Received: from mail-wr1-f53.google.com ([209.85.221.53]:47045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kehBy-0002Vd-GG for 25304-done@debbugs.gnu.org; Mon, 16 Nov 2020 11:17:22 -0500 Received: by mail-wr1-f53.google.com with SMTP id d12so19264035wrr.13 for <25304-done@debbugs.gnu.org>; Mon, 16 Nov 2020 08:17:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jTSztCMWk7DAlHHcYQIilIgVxKHZQ4xfpjIU9n61skQ=; b=VYoVWMDSVat5rSzT4uMLbK/MAczhsVZvVQMrCLQ5oXnRlG/5hMjW27fGXUo0knNVXK KxLV24Y1s87/hbfDFWYOiuPZZTXJhJhdHoy/pvaGHq+D1abb5KXE65m6fmHkcaTVWGBN hdp/YjxkYB7HToKw2MxqXWq0u2Odt32ihoe0jqgGsECQIUWUN5r3xdjhpqcApGQgwZ67 aDLYRMqml5cC0rMrhUDdH/q0zHqF0dkIV0urWHoXYzUympRVF62Pb1Odv1jaUaBbeQx/ DEXXuaWIZIMtP8KIgYnM3tWM6PQ8Su0x+FxFejkFGfjq3eZrsiE3ViUfpxQKf4oI4ox/ OrXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=jTSztCMWk7DAlHHcYQIilIgVxKHZQ4xfpjIU9n61skQ=; b=PgPYOQ7vyPFPk9maIA3to1xHB/jcJWOSqCrxYYWMW7L1Mra1m4hq0fiAVaSCbjRAEN J6UWkGtxGdPWTy5X1l6EyK06TKvBzGabfi+PI0YoQY1tNKeztZd8nPxBXEUwsr7iKXsZ qu4PJdylHxLnP2cYmo+XAkDSZjcln1aTYSzzMkLLwkbKqQpZZ3OhuqwyjYxEyIqyHBbQ Or0A9VJE//aLcBSMnQCKBT8caNW8roFFAeWc6qjllz0tDw+8NCvYRVPgB5SoUrb7KZXy JFZX9r9q+3Nr8unxEfVk3HlSjKq5E3I9sERr/62MBnkaVtzCvkpXd3hFkZiame+PbvEj IZUg== X-Gm-Message-State: AOAM53330oww+l/KyrweYXz7y2Epm50PZ7qiSI2eX2g4pfxvWRM1IYzw Add9dp/xsr9v/2hWl/7hEWAjKwhiL/4= X-Google-Smtp-Source: ABdhPJyzVfXJO6cOKjMpSFuy7sK91E5uOAfv+cCTsrn5CexvvHDAJ/941zWjCxqs1Oh4RR9PZwzYbw== X-Received: by 2002:a5d:5651:: with SMTP id j17mr20273204wrw.221.1605543436286; Mon, 16 Nov 2020 08:17:16 -0800 (PST) Received: from unfall (20.134.94.90.dynamic.jazztel.es. [90.94.134.20]) by smtp.gmail.com with ESMTPSA id b14sm22313824wrq.47.2020.11.16.08.17.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 08:17:15 -0800 (PST) From: =?utf-8?Q?Miguel_=C3=81ngel_Arruga_Vivas?= To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#25304: =?utf-8?Q?Libtool=E2=80=99s?= ltmain.sh still contains a /gnu/store shebang References: <878tqx7zzj.fsf@gnu.org> <87mvb925po.fsf@gnu.org> <87v9e9z30r.fsf@gmail.com> <87v9e6andh.fsf@gnu.org> Date: Mon, 16 Nov 2020 17:17:05 +0100 In-Reply-To: <87v9e6andh.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sun, 15 Nov 2020 12:08:26 +0100") Message-ID: <871rgtxon2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 25304-done Cc: 25304-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! Ludovic Court=C3=A8s writes: > Hi! > > Miguel =C3=81ngel Arruga Vivas skribis: > >> I was looking through the lists because I have a patch that does exactly >> what you describe here. I guess this goes to core updates, so this >> version is on top of it. WDYT? > > Yes, looks like a change for =E2=80=98core-updates=E2=80=99. > >> From 145273418d3131bcf3b73d416d19f641645cf3f8 Mon Sep 17 00:00:00 2001 >> From: =3D?UTF-8?q?Miguel=3D20=3DC3=3D81ngel=3D20Arruga=3D20Vivas?=3D >> >> Date: Fri, 13 Nov 2020 15:24:46 +0100 >> Subject: [PATCH] gnu: libtool: Restore shebangs on all libtoolize files. > > You can add =E2=80=9CFixes .=E2=80=9D > >> * gnu/packages/autotools.scm (libtool)[restore-build-aux-shebang]: New >> phase after install. >> [restore-ltmain-shebang]: Remove phase, it is now performed by the phase >> restore-build-aux-shebang. > > LGTM, thanks for digging through old bugs! > > Ludo=E2=80=99. Pushed as 8d263ff254292c9e13a9848f90b52263da52d570 to core-updates with that line added. Thanks for the quick review. :-) Happy hacking! Miguel --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEEiIeExBRZrMuD5+hMY0xuiXn6vsIFAl+ypgIACgkQY0xuiXn6 vsIeDQwAqgWesDyQq/yKwp+5Tiw746kFAdlRPQDHPzYgTJls4wDGcFYBSfXcj9pA W1sI6/wzYF7TmtZGCJlJHHOQNBrryoAhg8Q/r6TMMTESAiKJUNJt93Je8fZ8RVih O8PqHUxCmLkBliSVUk0tQXsPEigd10uSGxqUBzRU9S15K547LhcqttPF80vkD/1F CtqO2cAtBPje904nUjosRgZaOaSI9ceRLQD0+1+FNcowlDi90XGnf5KZlt1E3dhh i36eTRe+vvwvql6m28Pkwg7BRmzzB6roDsUqHZUdR0n8JpOki8/pq4XXTSR2N6Xa Jn9vc1LPqcY4com/N899M71z7Ad6zCGi4lYVNSjdlC1nj9jOQpipp18aKBeIbgkA fSedbtDtkiyMmffkVz+fTmOwI7I1zn/TUUG0BWsYgxVg4IT0BAuBLcRmbQb3yyfm 8SDEHj0do2bSXIu8a3QTX+ubxOEc5op19pljBq7EqhsdppTT8z+QSnYiak83cT5L 53EzQ1Xt =o+Gy -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 13:11:26 2020 Received: (at 25304) by debbugs.gnu.org; 16 Nov 2020 18:11:26 +0000 Received: from localhost ([127.0.0.1]:57150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keiyL-0007nY-Rz for submit@debbugs.gnu.org; Mon, 16 Nov 2020 13:11:26 -0500 Received: from mail-wm1-f52.google.com ([209.85.128.52]:37618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keiyK-0007nI-7d; Mon, 16 Nov 2020 13:11:25 -0500 Received: by mail-wm1-f52.google.com with SMTP id h21so185470wmb.2; Mon, 16 Nov 2020 10:11:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=t6mHTqOpjD0Rw+3MOX/YWm9ZH4LZHHwtmHBIDD7SnBY=; b=hSyVgf7pzqVA6Rzuyd+oyVq1u99q4I5irhp9VhO7hmy1o17sEEx90fEmXtHTtHhdee JGHQUT8i6wYb6Ho2WnNtuCywPDJ5gj1xgJCu2Rw0Qw5Zo+mliT3P1f/1vi5Mt00fJRhT mJDD7fH46idXIB+RWVGZjSDrs2ypnPTNdos8IO73st5VaXhn18UITemBPMgtw5Z8i6jD +yxGW+QE0OkGqgtM1RAl3p8FDE0AfKDph0j34arwP9wWPzuqC7aiYbVc8XbY5TiF/Zcf hNJjPe6kMhM/nckdAJIxnINZjHzERU75zdCEKUjL6WkrgejvFJqx8kGSZ0TgYiSuE8l5 T5lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=t6mHTqOpjD0Rw+3MOX/YWm9ZH4LZHHwtmHBIDD7SnBY=; b=Z07+gh/lQ79kDIXAtlAvbvLO4O6uP/jAJxDotzmy5qUEpTMl17NlOOkzfmoR1sk44J lgnAZpoKr8t0fFgyNtQaX8E/zLq1piKW6Q2SgFrGLwszzDtRoQlfDdkAuxkG9mWTKQSd D6uzzJthXIPBaeISjnA7CI3cYkolIFRAgceO2FxQCIpUzJbtvK5XyD7LBrbCXX4fazor RuqTpwNMntenqIHv1RDBxBRZz57Cpf5mNQdniPyZHBz6wGddvSSi6T2YcQFvsBrwbmva jj8kTUOYHTEn6XrwIUmxdetOFeZ4QaRpN+L5IMymaKwHVbJpRz/orIFLOT9Pa7KQ+bkP fxkw== X-Gm-Message-State: AOAM530oURmHb4shKfbt1KVGMBfsG3kffjwrIyIuFqBx11CxtlPoEWWv 6iM6JoMMG+xXyDldL55OlDQ= X-Google-Smtp-Source: ABdhPJzHlpJ8yFO8TraNqp/sqX9kJAQvjgHKmbH5dxwo7oYbbdtUf3dI92t+/i6GbGl4FeajXwAoiw== X-Received: by 2002:a7b:ce99:: with SMTP id q25mr131738wmj.35.1605550278448; Mon, 16 Nov 2020 10:11:18 -0800 (PST) Received: from unfall (20.134.94.90.dynamic.jazztel.es. [90.94.134.20]) by smtp.gmail.com with ESMTPSA id b8sm25669015wrv.57.2020.11.16.10.11.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 10:11:17 -0800 (PST) From: =?utf-8?Q?Miguel_=C3=81ngel_Arruga_Vivas?= To: Leo Famulari Subject: Re: bug#25508: Git hook shebangs should not be rewritten References: <20170122232550.GB27876@jasmine> Date: Mon, 16 Nov 2020 19:10:59 +0100 In-Reply-To: <20170122232550.GB27876@jasmine> (Leo Famulari's message of "Sun, 22 Jan 2017 18:25:50 -0500") Message-ID: <87r1otw4ss.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 25304 Cc: 25304@debbugs.gnu.org, 25508@debbugs.gnu.org, John Darrington X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Sorry, I've closed this with the libtool one. The attached patch fixes this one too, should I push it to master (as the last change for git) or to core-updates or staging (as it might seem looking at the dependencies)? Happy hacking! Miguel --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-git-Add-phase-to-restore-hooks-shebang.patch Content-Transfer-Encoding: quoted-printable Content-Description: 0001.patch From=209f0e9eea6d7c338fba234c2f8935ba76b1d94b2c Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Miguel=3D20=3DC3=3D81ngel=3D20Arruga=3D20Vivas?=3D Date: Mon, 16 Nov 2020 19:06:40 +0100 Subject: [PATCH] gnu: git: Add phase to restore hooks shebang. Fixes . * gnu/packages/version-control.scm (git)[arguments]: New phase restore-sample-hooks-shebang. =2D-- gnu/packages/version-control.scm | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-contro= l.scm index 3e46a6162b..1842528ff6 100644 =2D-- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -391,6 +391,16 @@ as well as the classic centralized workflow.") (install-file "contrib/subtree/git-subtree.1" (string-append subtree "/share/man/man1")) #t))) + (add-after 'install 'restore-sample-hooks-shebang + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (dir (string-append out "/share/git-core/templates/hoo= ks"))) + (for-each (lambda (file) + (format #t "restoring shebang on `~a'~%" file) + (substitute* file + (("^#!.*/bin/sh") "#!/bin/sh"))) + (find-files dir ".*")) + #t))) (add-after 'install 'split (lambda* (#:key inputs outputs #:allow-other-keys) ;; Split the binaries to the various outputs. =2D-=20 2.29.2 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > From: John Darrington > Subject: Not patching shebang in git hook samples ? > To: guix-devel@gnu.org > Date: Sun, 22 Jan 2017 14:01:24 +0100 (3 years, 42 weeks, 4 days ago) > > The git package ships with a number of sample hook files. These are shel= l scripts and > therefore the #!/bin/sh line gets substituted at build time. > > However these files get installed into every git repostory that is create= d, and users > are invited to use them as templates for their own hooks. > > This will be fine until both git and bash are updated. Now the original = bash is free > to be garbage collected. If that happens, the path:=20 > #!/gnu/store/qkw4zrwfybxww8f56nkb6hggxambk89b-bash-4.4.0/bin/sh > will no longer exist. > > I suggest what we turn off the shebang patching for the files in share/te= mplates for git. > > J' --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEEiIeExBRZrMuD5+hMY0xuiXn6vsIFAl+ywLQACgkQY0xuiXn6 vsI5hQv+IfRGaTZ7A0Ulzdy54BxcVq/asGgJUcAG8HU/cZbxQDSjmbcWXoIomrI8 PyvVVmoFwm6RVFKvCZCFqFVIeKMzPZOjgWLV2gRLwBH1VR+oQG+1LT7WTULL8fGB 6ToYkKWqE3d7sZnE5J+jFjVclCXUVyzySIW0cCBT8jXei9sOTnO8+nby9/aBwMpT +1sMz2qGZ4XR8arXPQnp1duDaBrqq4hPOcsMUH2NL86Widf3EkJ0F+CskU0z/Bi8 jufRuZcy9OfQXUHqoVOEvS9catdq9IAR4rGaYhRMHUiq796Bka232kATYkpTmjZz pMFxyQNUkDQtRCVt8devE54Xliy6OTPD3w0RRn/3s78XKyCVCim2JQK0+40cDDHh dnrUN1tkZ87ggHw1xth2NVdi4eKlKIqB4mAClH9QRyF2yW0EzGmjE27Lxbb3e9aM +nSZHYo52VbKbUVGVkgmBwT9el9zGG/YcIbfO3oM71Pe18Xmmf7KropfvKgVhqaz AAPVvykG =3IH3 -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 13:42:40 2020 Received: (at 25304) by debbugs.gnu.org; 16 Nov 2020 18:42:40 +0000 Received: from localhost ([127.0.0.1]:57207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kejSa-00008X-9B for submit@debbugs.gnu.org; Mon, 16 Nov 2020 13:42:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kejSW-00008E-2i; Mon, 16 Nov 2020 13:42:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38602) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kejSQ-0001LB-34; Mon, 16 Nov 2020 13:42:30 -0500 Received: from host-37-191-236-253.lynet.no ([37.191.236.253]:34310 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kejSO-0004Ks-Gt; Mon, 16 Nov 2020 13:42:29 -0500 From: Marius Bakke To: Miguel =?utf-8?Q?=C3=81ngel?= Arruga Vivas , Leo Famulari Subject: Re: bug#25304: bug#25508: Git hook shebangs should not be rewritten In-Reply-To: <87r1otw4ss.fsf@gmail.com> References: <20170122232550.GB27876@jasmine> <87r1otw4ss.fsf@gmail.com> Date: Mon, 16 Nov 2020 19:42:26 +0100 Message-ID: <87h7pp9m99.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 25304 Cc: 25304@debbugs.gnu.org, 25508@debbugs.gnu.org, John Darrington X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Miguel =C3=81ngel Arruga Vivas writes: > The attached patch fixes this one too, should I push it to master (as > the last change for git) or to core-updates or staging (as it might seem > looking at the dependencies)? LGTM. Git (+ git-minimal) is below the 300 rebuild limit for 'master' (and I try to keep it that way!). --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCgAtFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl+yyBIPHG1hcml1c0Bn bnUub3JnAAoJEKKgbfKjOlT63K4H/2TqeZuQEnTyDjzDyMHOTuuqaw1Ckbxep04O 9Bp9Dz00OX2qOrJLuviiSbN656G+gtA9phopvZiQhRQrkNt91S202zWQy96tPAHy ikTNlONVqH1d8penErNSW7Ddzmi+IO16MxIvHSyme+wNo+zy3uirdO9LNEcSBr72 TI+YzkuKh3qFUbW7DMFKIKCdeRL4lwBE5pxdhXhsFLn/ecr9iFmHY9ZqI/C6OYIK 7Xi2sFt5vQu/MmP99N/mhqtURYz6AeRt6xQfMBj9HzXoTbYtoDgseVmfAvZfiQiq 7Q7NJnzBAjOGzmhlRcV8+Q0PrshOkfqzBZ4XSAgzQrZhQDYvOqk= =1bUC -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 15:51:54 2020 Received: (at 25304) by debbugs.gnu.org; 16 Nov 2020 20:51:54 +0000 Received: from localhost ([127.0.0.1]:57496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kelTe-0001LN-8T for submit@debbugs.gnu.org; Mon, 16 Nov 2020 15:51:54 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:37749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kelTb-0001L4-R6; Mon, 16 Nov 2020 15:51:52 -0500 Received: by mail-wr1-f51.google.com with SMTP id b6so20311958wrt.4; Mon, 16 Nov 2020 12:51:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=2OkBs4y3WiWUrFLF89+nCfdoMdB013SJPkZ4oqGXHqk=; b=o/XZ+y1mhK+irGcD6XWyNOYhVVi0CqQ/rWABFpmYXL+TG6lNZT+DPxvM8qakRl9IOu HIIluy+2Zli22/Lhc2eiHygQxIZtD9mWWeR3v80KsaLwFxh5wdyp+6zj8tUZhE979Tmc q9Qx6p3/hthaTga3K7rTIiKlj99cDjVG4tEBY8tAO5UZdMwIIOgMAIQEhUMnVRVZ/1iR HpcpbHu0UFoA3ylkEA4Ta3pN9EUHyDSgbVQhgH1Z3LVhNh3dG8B1C5B932gIiK87DeH5 7ZiVsVW7MY83fTf5cEXZ1/NpWGIryE7RxoEH5GU/Y81mrNqItp3HYlLAwepCwMaKcznk 5ZKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=2OkBs4y3WiWUrFLF89+nCfdoMdB013SJPkZ4oqGXHqk=; b=A04gdgPqDvMPVRNsKa9ThpFqG2dfQ8AE9m3PHJ6wodC5IUMSPI+IVmxdvlJHU1/yCX LWZMZp5lJH0r/qjlFEeZ8nAbKbjVI2bxg+BC1hpMs1An6+7yq4n9sKpelgzOy3B4ghHT KRuUjAH7dReE0Ym4zPD09RmGBKObET6Tk6ZwBPNGYALSydwxi7leCG0z+LrlETSyRXGv Yo4JEnF+QQlylIy4i6AUXv4xLkp3myZE63DWULamU4d/dcMZKC6Yf5vEEeaSfuW5LBoe h++4TX2HZyQP8NM1uhWHLlScNVD+LpLxediPogPQedmw4jxqTrMckh1wjWvO2O2Hq2yE 3LIQ== X-Gm-Message-State: AOAM532ku+mJfb37AjhApfLEz/ZyXat/3+alS+/uJ45vakNmXfSX/S9h pHXVWzNUu1yywje3j1l14vM= X-Google-Smtp-Source: ABdhPJxNhxzz5PodEydgmRlJaC32ctb7x+MdfJAkeRPVXKxxiJIF9UdjWm00EpCrJ2WLlE3QKyroJw== X-Received: by 2002:adf:b109:: with SMTP id l9mr20724014wra.279.1605559905922; Mon, 16 Nov 2020 12:51:45 -0800 (PST) Received: from unfall (20.134.94.90.dynamic.jazztel.es. [90.94.134.20]) by smtp.gmail.com with ESMTPSA id t74sm602699wmt.8.2020.11.16.12.51.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 12:51:45 -0800 (PST) From: =?utf-8?Q?Miguel_=C3=81ngel_Arruga_Vivas?= To: Marius Bakke Subject: Re: bug#25304: bug#25508: Git hook shebangs should not be rewritten References: <20170122232550.GB27876@jasmine> <87r1otw4ss.fsf@gmail.com> <87h7pp9m99.fsf@gnu.org> Date: Mon, 16 Nov 2020 21:51:43 +0100 In-Reply-To: <87h7pp9m99.fsf@gnu.org> (Marius Bakke's message of "Mon, 16 Nov 2020 19:42:26 +0100") Message-ID: <87ima5vxcw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 25304 Cc: 25304@debbugs.gnu.org, 25508@debbugs.gnu.org, John Darrington , Leo Famulari X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Marius Bakke writes: > Miguel =C3=81ngel Arruga Vivas writes: > >> The attached patch fixes this one too, should I push it to master (as >> the last change for git) or to core-updates or staging (as it might seem >> looking at the dependencies)? > > LGTM. Git (+ git-minimal) is below the 300 rebuild limit for 'master' > (and I try to keep it that way!). Thanks for the info and the fast review, I wasn't sure if it was 109+242 or just 242. I've pushed it to master as 46ce24fb2d8c9f7dce16c4c08919f0fc108dbfae. Happy hacking! Miguel From unknown Sun Aug 10 16:49:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 15 Dec 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator