GNU bug report logs - #25287
25.1; [WISH] shr-rescale-image: pass window size externally

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25287 in the body.
You can then email your comments to 25287 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christophe Troestler <Christophe.Troestler <at> umons.ac.be>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 25.1; [WISH] shr-rescale-image: pass window size externally
Date: Wed, 28 Dec 2016 17:21:10 +0100

Rendering HTML is sometimes done in temporary buffers which are not 
attached to a frame.  But shr-rescale-image only uses the dimensions of 
the frame of the current buffer.  If would be good if shr-rescale-image 
could be given one additional argument and that shr-put-image flags 
would accept one more value for 'size that would allow to pass the 
desired size.



In GNU Emacs 25.1.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.4)
of 2016-12-01, modified by Debian built on trouble
Windowing system distributor 'The X.Org Foundation', version 
11.0.11900000
System Description:	Debian GNU/Linux testing (stretch)

Configured using:
'configure --build x86_64-linux-gnu --prefix=/usr
--sharedstatedir=/var/lib --libexecdir=/usr/lib
--localstatedir=/var/lib --infodir=/usr/share/info
--mandir=/usr/share/man --with-pop=yes
--enable-locallisppath=/etc/emacs25:/etc/emacs:/usr/local/share/emacs/25.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/25.1/site-lisp:/usr/share/emacs/site-lisp
--with-sound=alsa --build x86_64-linux-gnu --prefix=/usr
--sharedstatedir=/var/lib --libexecdir=/usr/lib
--localstatedir=/var/lib --infodir=/usr/share/info
--mandir=/usr/share/man --with-pop=yes
--enable-locallisppath=/etc/emacs25:/etc/emacs:/usr/local/share/emacs/25.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/25.1/site-lisp:/usr/share/emacs/site-lisp
--with-sound=alsa --with-x=yes --with-x-toolkit=gtk3
--with-toolkit-scroll-bars 'CFLAGS=-g -O2
-fdebug-prefix-map=/build/emacs25-Fs4LPA/emacs25-25.1+1=. -fstack-protector-strong
-Wformat -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time
-D_FORTIFY_SOURCE=2' LDFLAGS=-Wl,-z,relro'
Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11
Important settings:
 value of $LC_MESSAGES: en_US.UTF-8
 value of $LC_NUMERIC: en_US.UTF-8
 value of $LANG: en_US.UTF-8
 locale-coding-system: utf-8-unix

Major mode: Emacs-Lisp

Minor modes in effect:
 shell-dirtrack-mode: t
 diff-auto-refine-mode: t
 TeX-PDF-mode: t
 erc-list-mode: t
 erc-menu-mode: t
 erc-autojoin-mode: t
 erc-ring-mode: t
 erc-networks-mode: t
 erc-pcomplete-mode: t
 erc-track-mode: t
 erc-match-mode: t
 erc-button-mode: t
 erc-fill-mode: t
 erc-stamp-mode: t
 erc-netsplit-mode: t
 erc-irccontrols-mode: t
 erc-noncommands-mode: t
 erc-move-to-prompt-mode: t
 erc-readonly-mode: t
 desktop-save-mode: t
 show-paren-mode: t
 tooltip-mode: t
 global-eldoc-mode: t
 electric-indent-mode: t
 mouse-wheel-mode: t
 menu-bar-mode: t
 file-name-shadow-mode: t
 global-font-lock-mode: t
 font-lock-mode: t
 auto-composition-mode: t
 auto-encryption-mode: t
 auto-compression-mode: t
 column-number-mode: t
 line-number-mode: t
 transient-mark-mode: t

Recent messages:
Mark saved where search started [3 times]
Invalid face reference: nil [40 times]
[mu4e] Retrieving mail...done
[mu4e] Indexing... processed 92000, updated 0
[mu4e] Indexing completed; processed 92597, updated 0, cleaned-up 0
[mu4e] Retrieving mail...done
[mu4e] Indexing... processed 92000, updated 0
[mu4e] Indexing completed; processed 92597, updated 0, cleaned-up 0
Making completion list... [3 times]
Scanning for dabbrevs...done

Load-path shadows:
~/.opam/system/share/emacs/site-lisp/merlin-company hides 
~/.opam/4.03.0/share/emacs/site-lisp/merlin-company
~/.opam/system/share/emacs/site-lisp/merlin-ac hides 
~/.opam/4.03.0/share/emacs/site-lisp/merlin-ac
~/.opam/system/share/emacs/site-lisp/merlin-compat hides 
~/.opam/4.03.0/share/emacs/site-lisp/merlin-compat
~/.opam/system/share/emacs/site-lisp/merlin-iedit hides 
~/.opam/4.03.0/share/emacs/site-lisp/merlin-iedit
~/.opam/system/share/emacs/site-lisp/merlin-cap hides 
~/.opam/4.03.0/share/emacs/site-lisp/merlin-cap
~/.opam/system/share/emacs/site-lisp/merlin hides 
~/.opam/4.03.0/share/emacs/site-lisp/merlin
~/.opam/system/share/emacs/site-lisp/caml-compat hides 
~/software/OCaml/tuareg/caml-mode/caml-compat
~/.opam/system/share/emacs/site-lisp/caml-font hides 
~/software/OCaml/tuareg/caml-mode/caml-font
~/.opam/system/share/emacs/site-lisp/caml-hilit hides 
~/software/OCaml/tuareg/caml-mode/caml-hilit
~/.opam/system/share/emacs/site-lisp/inf-caml hides 
~/software/OCaml/tuareg/caml-mode/inf-caml
~/.opam/system/share/emacs/site-lisp/caml-help hides 
~/software/OCaml/tuareg/caml-mode/caml-help
~/.opam/system/share/emacs/site-lisp/caml-types hides 
~/software/OCaml/tuareg/caml-mode/caml-types
~/.opam/system/share/emacs/site-lisp/caml-xemacs hides 
~/software/OCaml/tuareg/caml-mode/caml-xemacs
~/.opam/system/share/emacs/site-lisp/camldebug hides 
~/software/OCaml/tuareg/caml-mode/camldebug
~/.opam/system/share/emacs/site-lisp/caml hides 
~/software/OCaml/tuareg/caml-mode/caml
~/.opam/system/share/emacs/site-lisp/caml-emacs hides 
~/software/OCaml/tuareg/caml-mode/caml-emacs
/home/trch/software/mu/mu4e/mu4e-headers hides 
/usr/share/emacs25/site-lisp/mu4e/mu4e-headers
/home/trch/software/mu/mu4e/mu4e-contrib hides 
/usr/share/emacs25/site-lisp/mu4e/mu4e-contrib
/home/trch/software/mu/mu4e/mu4e-context hides 
/usr/share/emacs25/site-lisp/mu4e/mu4e-context
/home/trch/software/mu/mu4e/mu4e-message hides 
/usr/share/emacs25/site-lisp/mu4e/mu4e-message
/home/trch/software/mu/mu4e/org-old-mu4e hides 
/usr/share/emacs25/site-lisp/mu4e/org-old-mu4e
/home/trch/software/mu/mu4e/mu4e hides 
/usr/share/emacs25/site-lisp/mu4e/mu4e
/home/trch/software/mu/mu4e/mu4e-mark hides 
/usr/share/emacs25/site-lisp/mu4e/mu4e-mark
/home/trch/software/mu/mu4e/mu4e-compose hides 
/usr/share/emacs25/site-lisp/mu4e/mu4e-compose
/home/trch/software/mu/mu4e/mu4e-draft hides 
/usr/share/emacs25/site-lisp/mu4e/mu4e-draft
/home/trch/software/mu/mu4e/mu4e-lists hides 
/usr/share/emacs25/site-lisp/mu4e/mu4e-lists
/home/trch/software/mu/mu4e/mu4e-meta hides 
/usr/share/emacs25/site-lisp/mu4e/mu4e-meta
/home/trch/software/mu/mu4e/mu4e-view hides 
/usr/share/emacs25/site-lisp/mu4e/mu4e-view
/home/trch/software/mu/mu4e/mu4e-speedbar hides 
/usr/share/emacs25/site-lisp/mu4e/mu4e-speedbar
/home/trch/software/mu/mu4e/mu4e-vars hides 
/usr/share/emacs25/site-lisp/mu4e/mu4e-vars
/home/trch/software/mu/mu4e/org-mu4e hides 
/usr/share/emacs25/site-lisp/mu4e/org-mu4e
/home/trch/software/mu/mu4e/mu4e-utils hides 
/usr/share/emacs25/site-lisp/mu4e/mu4e-utils
/home/trch/software/mu/mu4e/mu4e-proc hides 
/usr/share/emacs25/site-lisp/mu4e/mu4e-proc
/home/trch/software/mu/mu4e/mu4e-main hides 
/usr/share/emacs25/site-lisp/mu4e/mu4e-main
/home/trch/software/mu/mu4e/mu4e-actions hides 
/usr/share/emacs25/site-lisp/mu4e/mu4e-actions
/usr/share/emacs/25.1/site-lisp/debian-startup hides 
/usr/share/emacs/site-lisp/debian-startup
/usr/share/emacs25/site-lisp/flim/md4 hides 
/usr/share/emacs/25.1/lisp/md4
/usr/share/emacs25/site-lisp/flim/hex-util hides 
/usr/share/emacs/25.1/lisp/hex-util
/home/trch/.emacs.d/elpa/soap-client-3.1.1/soap-inspect hides 
/usr/share/emacs/25.1/lisp/net/soap-inspect
/usr/share/emacs25/site-lisp/flim/sasl-cram hides 
/usr/share/emacs/25.1/lisp/net/sasl-cram
/usr/share/emacs25/site-lisp/flim/sasl-ntlm hides 
/usr/share/emacs/25.1/lisp/net/sasl-ntlm
/usr/share/emacs25/site-lisp/flim/sasl hides 
/usr/share/emacs/25.1/lisp/net/sasl
/usr/share/emacs25/site-lisp/flim/hmac-def hides 
/usr/share/emacs/25.1/lisp/net/hmac-def
/home/trch/.emacs.d/elpa/soap-client-3.1.1/soap-client hides 
/usr/share/emacs/25.1/lisp/net/soap-client
/usr/share/emacs25/site-lisp/flim/hmac-md5 hides 
/usr/share/emacs/25.1/lisp/net/hmac-md5
/usr/share/emacs25/site-lisp/flim/ntlm hides 
/usr/share/emacs/25.1/lisp/net/ntlm
/usr/share/emacs25/site-lisp/flim/sasl-digest hides 
/usr/share/emacs/25.1/lisp/net/sasl-digest
/usr/share/emacs25/site-lisp/latex-cjk-thai/thai-word hides 
/usr/share/emacs/25.1/lisp/language/thai-word
/usr/share/emacs25/site-lisp/auctex/toolbar-x hides 
/usr/share/emacs/site-lisp/auctex/toolbar-x
/usr/share/emacs25/site-lisp/auctex/context hides 
/usr/share/emacs/site-lisp/auctex/context
/usr/share/emacs25/site-lisp/auctex/tex hides 
/usr/share/emacs/site-lisp/auctex/tex
/usr/share/emacs25/site-lisp/auctex/tex-style hides 
/usr/share/emacs/site-lisp/auctex/tex-style
/usr/share/emacs25/site-lisp/auctex/prv-emacs hides 
/usr/share/emacs/site-lisp/auctex/prv-emacs
/usr/share/emacs25/site-lisp/auctex/plain-tex hides 
/usr/share/emacs/site-lisp/auctex/plain-tex
/usr/share/emacs25/site-lisp/auctex/font-latex hides 
/usr/share/emacs/site-lisp/auctex/font-latex
/usr/share/emacs25/site-lisp/auctex/tex-jp hides 
/usr/share/emacs/site-lisp/auctex/tex-jp
/usr/share/emacs25/site-lisp/auctex/tex-fold hides 
/usr/share/emacs/site-lisp/auctex/tex-fold
/usr/share/emacs25/site-lisp/auctex/tex-font hides 
/usr/share/emacs/site-lisp/auctex/tex-font
/usr/share/emacs25/site-lisp/auctex/tex-info hides 
/usr/share/emacs/site-lisp/auctex/tex-info
/usr/share/emacs25/site-lisp/auctex/tex-buf hides 
/usr/share/emacs/site-lisp/auctex/tex-buf
/usr/share/emacs25/site-lisp/auctex/multi-prompt hides 
/usr/share/emacs/site-lisp/auctex/multi-prompt
/usr/share/emacs25/site-lisp/auctex/texmathp hides 
/usr/share/emacs/site-lisp/auctex/texmathp
/usr/share/emacs25/site-lisp/auctex/preview hides 
/usr/share/emacs/site-lisp/auctex/preview
/usr/share/emacs25/site-lisp/auctex/tex-mik hides 
/usr/share/emacs/site-lisp/auctex/tex-mik
/usr/share/emacs25/site-lisp/auctex/context-en hides 
/usr/share/emacs/site-lisp/auctex/context-en
/usr/share/emacs25/site-lisp/auctex/latex hides 
/usr/share/emacs/site-lisp/auctex/latex
/usr/share/emacs25/site-lisp/auctex/context-nl hides 
/usr/share/emacs/site-lisp/auctex/context-nl
/usr/share/emacs25/site-lisp/auctex/bib-cite hides 
/usr/share/emacs/site-lisp/auctex/bib-cite
/usr/share/emacs25/site-lisp/auctex/tex-bar hides 
/usr/share/emacs/site-lisp/auctex/tex-bar

Features:
(shadow emacsbug grep qp network-stream nsm starttls tls gnutls
mailalias flow-fill mail-extr sort face-remap dabbrev eieio-opt misearch
multi-isearch debug cus-start cus-load shr-color color shr dom
tramp-cache tramp tramp-compat tramp-loaddefs trampver ucs-normalize
org-element org-rmail org-mhe org-irc org-info org-gnus org-docview
org-bibtex org-bbdb org-w3m smerge-mode latexenc reftex-auc preview
prv-emacs tex-buf reftex-dcr reftex reftex-vars latex tex-style tex-mode
shell lua-mode rx vc-git diff-mode flyspell ispell tuareg_indent tuareg
caml warnings compile smie caml-help font-latex tex dbus crm bibtex
merlin-compat merlin-cap merlin caml-types caml-emacs tq log-edit
pcvs-util add-log erc-list erc-menu erc-join erc-ring erc-networks
erc-pcomplete erc-track erc-match erc-button erc-fill erc-stamp
erc-netsplit erc-goodies erc erc-backend erc-compat pp twittering-mode
url url-proxy url-privacy url-expand url-methods url-history url-cookie
url-domsuf url-util mailcap xml org-mu4e org org-macro org-footnote
org-pcomplete pcomplete org-list org-faces org-entities noutline outline
easy-mmode org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table
ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs
org-loaddefs find-func mu-cite alist std11 pccl pccl-20 pcustom poem
poem-e20 poem-e20_3 pces pces-e20 pces-20 broken poe pym static apel-ver
product advice mu4e-contrib mu4e desktop frameset mu4e-speedbar speedbar
sb-image ezimage dframe mu4e-main mu4e-context mu4e-view thingatpt
comint ansi-color ring mu4e-headers mu4e-compose mu4e-draft mu4e-actions
ido rfc2368 smtpmail sendmail mu4e-mark mu4e-message html2text mu4e-proc
mu4e-utils mu4e-lists mu4e-vars message format-spec rfc822 mml mml-sec
mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045
ietf-drums mailabbrev mail-utils gmm-utils mailheader hl-line mu4e-meta
w3m browse-url doc-view subr-x jka-compr dired image-mode timezone
w3m-hist w3m-fb bookmark-w3m w3m-ems wid-edit w3m-ccl ccl w3m-favicon
w3m-image w3m-proc w3m-util epa-file epa derived epg cl quail edmacro
kmacro paren icalendar diary-lib diary-loaddefs cal-menu calendar
cal-loaddefs server finder-inf url-auth url-parse auth-source cl-seq
eieio eieio-core cl-macs gnus-util mm-util help-fns mail-prsvr
password-cache url-vars info package epg-config seq byte-opt gv bytecomp
byte-compile cl-extra help-mode easymenu cconv cl-loaddefs pcase cl-lib
debian-el debian-el-loaddefs w3m-load preview-latex tex-site auto-loads
time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset
image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode
prog-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese charscript case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote dbusbind inotify dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 606834 206813)
(symbols 48 50421 0)
(miscs 40 1317 1078)
(strings 32 134487 83753)
(string-bytes 1 4118071)
(vectors 16 75091)
(vector-slots 8 2059130 199507)
(floats 8 675 516)
(intervals 56 28395 1788)
(buffers 976 63))

Message #8 received at 25287 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Christophe Troestler <Christophe.Troestler <at> umons.ac.be>
Cc: 25287 <at> debbugs.gnu.org
Subject: Re: bug#25287: 25.1;
 [WISH] shr-rescale-image: pass window size externally
Date: Wed, 28 Dec 2016 17:41:15 +0100

Christophe Troestler <Christophe.Troestler <at> umons.ac.be> writes:

> Rendering HTML is sometimes done in temporary buffers which are not
> attached to a frame.  But shr-rescale-image only uses the dimensions
> of the frame of the current buffer.  If would be good if
> shr-rescale-image could be given one additional argument and that
> shr-put-image flags would accept one more value for 'size that would
> allow to pass the desired size.

What's the use case?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 25287 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Christophe Troestler <Christophe.Troestler <at> umons.ac.be>
Cc: 25287 <at> debbugs.gnu.org
Subject: Re: bug#25287: 25.1;
 [WISH] shr-rescale-image: pass window size externally
Date: Wed, 28 Dec 2016 18:13:23 +0100

(Please keep Cc's.)

Christophe Troestler <Christophe.Troestler <at> umons.ac.be> writes:

> On 2016-12-28, Lars Ingebrigtsen wrote:
>>
>> What's the use case?
>
> mu4e <https://github.com/djcb/mu> allows to specify a function to
> render a temporary buffer containing the HTML source.  I use shr for
> that (with a specific function for cid:// links) and it works well
> except that images are not rescaled properly.  Having a way to pass to
> shr the final frame size would allow to trigger image resizing
> (without having to rewrite shr-put-image and shr-rescale-image).

So mu4e would pass in this size?  Couldn't mu4e just switch to the
correct buffer first and then the scaling would work automatically?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #14 received at 25287 <at> debbugs.gnu.org (full text, mbox):

From: Christophe Troestler <Christophe.Troestler <at> umons.ac.be>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 25287 <at> debbugs.gnu.org, djcb <at> djcbsoftware.nl
Subject: Re: bug#25287: 25.1;
 [WISH] shr-rescale-image: pass window size externally
Date: Wed, 28 Dec 2016 18:30:02 +0100

On 2016-12-28, Lars Ingebrigtsen wrote:
>
> So mu4e would pass in this size?

The size would be passed to the function inserting the content in the 
final buffer.

> Couldn't mu4e just switch to the correct buffer first and then the 
> scaling would work automatically?

The author (added to CC) seems to imply that it is hard 
<https://github.com/djcb/mu/issues/984>.  Maybe the problem is that this 
buffer contains many parts, each with its own rendering.

Message #17 received at 25287 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Christophe Troestler <Christophe.Troestler <at> umons.ac.be>
Cc: 25287 <at> debbugs.gnu.org, djcb <at> djcbsoftware.nl
Subject: Re: bug#25287: 25.1;
 [WISH] shr-rescale-image: pass window size externally
Date: Sat, 21 Jan 2017 16:37:24 +0100

Christophe Troestler <Christophe.Troestler <at> umons.ac.be> writes:

>> Couldn't mu4e just switch to the correct buffer first and then the
>> scaling would work automatically?
>
> The author (added to CC) seems to imply that it is hard
> <https://github.com/djcb/mu/issues/984>.  Maybe the problem is that
> this buffer contains many parts, each with its own rendering.

OK, I have to objection to adding an optional target-width/target-height
pair of parameters to `shr-rescale-image'.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #20 received at 25287 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Christophe Troestler <Christophe.Troestler <at> umons.ac.be>
Cc: 25287 <at> debbugs.gnu.org, djcb <at> djcbsoftware.nl
Subject: Re: bug#25287: 25.1;
 [WISH] shr-rescale-image: pass window size externally
Date: Tue, 24 Jan 2017 21:17:21 +0100

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> OK, I have to objection to adding an optional target-width/target-height
> pair of parameters to `shr-rescale-image'.

I've now added this to the master.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.