From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 25 14:54:32 2016 Received: (at submit) by debbugs.gnu.org; 25 Dec 2016 19:54:32 +0000 Received: from localhost ([127.0.0.1]:54970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cLEsJ-0005AC-Ly for submit@debbugs.gnu.org; Sun, 25 Dec 2016 14:54:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cLEsI-0005A0-9P for submit@debbugs.gnu.org; Sun, 25 Dec 2016 14:54:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cLEsB-0003NS-Nm for submit@debbugs.gnu.org; Sun, 25 Dec 2016 14:54:25 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47875) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cLEsB-0003NO-L1 for submit@debbugs.gnu.org; Sun, 25 Dec 2016 14:54:23 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cLEs9-0002EQ-NQ for bug-gnu-emacs@gnu.org; Sun, 25 Dec 2016 14:54:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cLEs5-0003Mo-PU for bug-gnu-emacs@gnu.org; Sun, 25 Dec 2016 14:54:21 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:41555) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cLEs5-0003Me-IR for bug-gnu-emacs@gnu.org; Sun, 25 Dec 2016 14:54:17 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 55FC8207F9 for ; Sun, 25 Dec 2016 14:54:15 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sun, 25 Dec 2016 14:54:15 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=content-type:date:from:message-id:mime-version:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=VjD pIqK5eg4b5OXTLYupbQqBijM=; b=TyDz2N4gFcJ0ZfUx+j48zqYBX+2UbKNwgkH E1pRrJTPQOlFqXQxYLb1T3yxJ2Tg16hbJJ/MJuz3Z0BRs0Bntoxh7JNb8udvC/pi 98ME7dKnXn7R6i4v0g0KY8RXdhOrffR9/mxOdJQcEnTfABHU3GUaULHu+bX2faXc ucBlvamI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=smtpout; bh=VjDpIqK5eg4b5OXTLYupbQqBijM=; b=mfg5g yauWkIdrl6z3HxYWOvWFynBwrUw8dxqwOHBSc8hcdxgAu7ZHsviEKI+fBTNjLAlc 0lr6UNq0VFNkDLVpiM/0lK/3Bo16EntV669tcJSki1bSahl8zyKfJmkMJ4Tf4kAJ /yek/YNiqZiJ1XxqSCwSWVURIrZB+7qC3XOmkI= X-ME-Sender: X-Sasl-enc: ghb50jZQS8VlfQNCLjEwCLsFpg8uOZ7yNK6iFBKa1nAr 1482695654 Received: from shorty.local (50-1-153-216.dsl.dynamic.fusionbroadband.com [50.1.153.216]) by mail.messagingengine.com (Postfix) with ESMTPA id F28917E59A for ; Sun, 25 Dec 2016 14:54:14 -0500 (EST) Received: from dima by shorty.local with local (Exim 4.87) (envelope-from ) id 1cLEs1-0002nV-PR for bug-gnu-emacs@gnu.org; Sun, 25 Dec 2016 11:54:13 -0800 From: Dima Kogan To: bug-gnu-emacs@gnu.org Subject: 26.0.50; [PATCH] comint-insert-previous-argument logic improvements Date: Sun, 25 Dec 2016 11:54:13 -0800 Message-ID: <87eg0veqe2.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain These patches come from http://lists.gnu.org/archive/html/emacs-devel/2016-11/msg00520.html There are two patches to fix some deficiencies in comint-insert-previous-argument: 1. a prefix argument to comint-insert-previous-argument inserts the INDEX-th argument, not just the last one. bash counts from the beginning of the argument list, but zsh counts from the end. A new variable is added to allow the user to choose the zsh behavior 2. comint-insert-previous-argument had logic to find trailing &, which was buggy and got confused if && was encountered. This logic is not present in bash or zsh, so it was removed, and the bug went away with it. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-comint-insert-previous-argument-counts-args-from-the.patch >From 2d0c476fe02494837c6d0e035807e93dfd54677b Mon Sep 17 00:00:00 2001 From: Dima Kogan Date: Sun, 25 Dec 2016 11:35:26 -0800 Subject: [PATCH 1/2] comint-insert-previous-argument counts args from the start or from the end This function is invoked in shell-mode by the user, and is meant to emulate what M-. does in zsh and bash: it inserts an argument from a previous command. Without a prefix argument, it inserts the last arg from the previous command; with an argument INDEX, it inserts the INDEX-th argument. bash counds from the start, while zsh counts from the end. This patch adds a variable `comint-insert-previous-argument-from-end' that emulates the zsh behavior if non-nil. * lisp/comint.el (comint-arguments): can take in negative arguments to count from the end, same as indexing in python. (comint-insert-previous-argument): if comint-insert-previous-argument-from-end is non-nil, INDEX counts arguments from the end; if nil, from the beginning --- lisp/comint.el | 49 ++++++++++++++++++++++++++++++++++++------------- 1 file changed, 36 insertions(+), 13 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index b9c65b0..171caef 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -1660,12 +1660,13 @@ comint-delim-arg (defun comint-arguments (string nth mth) "Return from STRING the NTH to MTH arguments. -NTH and/or MTH can be nil, which means the last argument. -Returned arguments are separated by single spaces. -We assume whitespace separates arguments, except within quotes -and except for a space or tab that immediately follows a backslash. -Also, a run of one or more of a single character -in `comint-delimiter-argument-list' is a separate argument. +NTH and/or MTH can be nil, which means the last argument. NTH +and MTH can be <0 to count from the end; -1 means last argument. +Returned arguments are separated by single spaces. We assume +whitespace separates arguments, except within quotes and except +for a space or tab that immediately follows a backslash. Also, a +run of one or more of a single character in +`comint-delimiter-argument-list' is a separate argument. Argument 0 is the command name." ;; The first line handles ordinary characters and backslash-sequences ;; (except with w32 msdos-like shells, where backslashes are valid). @@ -1687,7 +1688,7 @@ comint-arguments (count 0) beg str quotes) ;; Build a list of all the args until we have as many as we want. - (while (and (or (null mth) (<= count mth)) + (while (and (or (null mth) (< mth 0) (<= count mth)) (string-match argpart string pos)) ;; Apply the `literal' text property to backslash-escaped ;; characters, so that `comint-delim-arg' won't break them up. @@ -1714,8 +1715,14 @@ comint-arguments args (if quotes (cons str args) (nconc (comint-delim-arg str) args)))) (setq count (length args)) - (let ((n (or nth (1- count))) - (m (if mth (1- (- count mth)) 0))) + (let ((n (cond + ((null nth) (1- count)) + ((>= nth 0) nth) + (t (+ count nth)))) + (m (cond + ((null mth) 0) + ((>= mth 0) (1- (- count mth))) + (t (1- (- mth)))))) (mapconcat (function (lambda (a) a)) (nthcdr n (nreverse (nthcdr m args))) " ")))) @@ -2634,8 +2641,21 @@ comint-previous-prompt (defvar-local comint-insert-previous-argument-last-start-pos nil) (defvar-local comint-insert-previous-argument-last-index nil) -;; Needs fixing: -;; make comint-arguments understand negative indices as bash does +(defvar-local comint-insert-previous-argument-from-end nil + "If nil, the INDEX argument to +`comint-insert-previous-argument' refers to the INDEX-th +argument, counting from the beginning; if non-nil, counting from +the end. This exists to emulate the bahavior of `M-number M-.' +in bash and zsh: in bash, `number' counts from the +beginning (variable in nil), while in zsh it counts from the end. +This variable is buffer-local. To get the zsh behavior in `M-x +shell' sessions, do something like this: + + (add-hook + 'shell-mode-hook + (lambda () + (setq comint-insert-previous-argument-from-end t)))") + (defun comint-insert-previous-argument (index) "Insert the INDEXth argument from the previous Comint command-line at point. Spaces are added at beginning and/or end of the inserted string if @@ -2643,8 +2663,8 @@ comint-insert-previous-argument Interactively, if no prefix argument is given, the last argument is inserted. Repeated interactive invocations will cycle through the same argument from progressively earlier commands (using the value of INDEX specified -with the first command). -This command is like `M-.' in bash." +with the first command). Values of INDEX<0 count from the end, so INDEX=-1 +is the last argument. This command is like `M-.' in bash." (interactive "P") (unless (null index) (setq index (prefix-numeric-value index))) @@ -2654,6 +2674,9 @@ comint-insert-previous-argument (setq index comint-insert-previous-argument-last-index)) (t ;; This is a non-repeat invocation, so initialize state. + (when (and index + comint-insert-previous-argument-from-end) + (setq index (- index))) (setq comint-input-ring-index nil) (setq comint-insert-previous-argument-last-index index) (when (null comint-insert-previous-argument-last-start-pos) -- 2.10.1 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0002-comint-insert-previous-argument-doesn-t-detect-and-i.patch >From 45de3e8dfa8a267c7af7732ef5fc6cb2c1606a66 Mon Sep 17 00:00:00 2001 From: Dima Kogan Date: Sun, 25 Dec 2016 11:49:44 -0800 Subject: [PATCH 2/2] comint-insert-previous-argument doesn't detect and ignore trailing & This function is invoked in shell-mode by the user, and is meant to emulate what M-. does in zsh and bash: it inserts an argument from a previous command. Neither zsh nor bash treat a trailing & specially: M-. simply inserts it if it is encountered. Emacs DID have extra logic to detect and discard trailing &, but this logic was buggy, and a && anywhere in the sequence would confuse it. This patch simply removes that logic to fix the bug and to emulate zsh and bash more closely * lisp/comint.el (comint-insert-previous-argument): don't detect and ignore trailing & --- lisp/comint.el | 3 --- 1 file changed, 3 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index 171caef..83dbce0 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -2692,9 +2692,6 @@ comint-insert-previous-argument (set-marker comint-insert-previous-argument-last-start-pos (point)) ;; Insert the argument. (let ((input-string (comint-previous-input-string 0))) - (when (string-match "[ \t\n]*&" input-string) - ;; strip terminating '&' - (setq input-string (substring input-string 0 (match-beginning 0)))) (insert (comint-arguments input-string index index))) ;; Make next invocation return arg from previous input (setq comint-input-ring-index (1+ (or comint-input-ring-index 0))) -- 2.10.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 01 21:36:51 2018 Received: (at 25271) by debbugs.gnu.org; 2 May 2018 01:36:51 +0000 Received: from localhost ([127.0.0.1]:46220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDghP-0006wM-H2 for submit@debbugs.gnu.org; Tue, 01 May 2018 21:36:51 -0400 Received: from mail-io0-f170.google.com ([209.85.223.170]:39749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDghN-0006wA-Q9 for 25271@debbugs.gnu.org; Tue, 01 May 2018 21:36:50 -0400 Received: by mail-io0-f170.google.com with SMTP id r9-v6so15636362iod.6 for <25271@debbugs.gnu.org>; Tue, 01 May 2018 18:36:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=UEwfaqi3EQ3FEJtFZrxiC0yknOLOiTdqZ31RRoc52d4=; b=RGmgtOWlKj9tDMnMwfBU8FDjJicA0vSmB0W7xT9prahYtGX8bjOy01BkJE4z0/6EwB 2evwU0OBE3yXEFK/kyq4Db7qqC9cpBXCiHmSv+FvDBetsRgh5xaaRBtSjGJVHf4eodjG pSVsHYScLdxO2p0A6pIkKLfKgjOSrSo1SXxeRsjZ6oUiuZBerdMjd+nshPoeW9Jic+RK l1Dc6xAUl9hyFcVMIVmnGeLKwqoQ2oho1bTpy24bKR/UDmcvsO/xutVu8+Z68/nNK47c YyDn94nbBq2vo32hZNv0u/C7+E9V+EcOVe65kjYLRqmsTBk1b2XkRkW4OWtK1txJDEyZ pD2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=UEwfaqi3EQ3FEJtFZrxiC0yknOLOiTdqZ31RRoc52d4=; b=G/wJabugyGtHxUx1je5cSdlwTTNlqUGjRMIgmgJ6x16w70ChBzFBWtvK+PntnHQ1KM NYKmeYPrL3jya2rHb5fVDbMf6GOFQy+gqG9K+jdvZjCk6xHwqubQdLPW+jWjz9rDRTzk 3PV1mBessH8p2VL6VxEblNUMD6XGKdx5J+CPxx4BS6tSqjKkZBhdFeM8kSggL6EhvnIk uMC37apjz6SDcdFFf7/Doou+TM5HaaL3rqJrGvZvp99etP89CmGMhpPdxAL6a/S4iHiV Q/3ty73NSFl+MuBNskO07rjESN42utFgZlLAYgEhuQez9guQqqWisYFFkGhP80Q8dNqy SPYA== X-Gm-Message-State: ALQs6tApTSCy8RZzPNuRxETSD7wDMSdza6L8gp3PnUqL0nOVO/5c89FQ 5qJ/F/9x/NKAhu62kyBCx3NRYQ== X-Google-Smtp-Source: AB8JxZqyDe9acAsl7tLWMl/CDTTmeijbgjBgMj1NEntZ+kTXm2sdWyfUx31TJ2J574s7NgoTj288nw== X-Received: by 2002:a6b:3942:: with SMTP id g63-v6mr18374741ioa.258.1525225004043; Tue, 01 May 2018 18:36:44 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id q21-v6sm5303128itb.4.2018.05.01.18.36.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 May 2018 18:36:42 -0700 (PDT) From: Noam Postavsky To: Dima Kogan Subject: Re: bug#25271: 26.0.50; [PATCH] comint-insert-previous-argument logic improvements References: <87eg0veqe2.fsf@secretsauce.net> Date: Tue, 01 May 2018 21:36:41 -0400 In-Reply-To: <87eg0veqe2.fsf@secretsauce.net> (Dima Kogan's message of "Sun, 25 Dec 2016 11:54:13 -0800") Message-ID: <87in86on2u.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25271 Cc: 25271@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dima Kogan writes: > +(defvar-local comint-insert-previous-argument-from-end nil > +This variable is buffer-local. To get the zsh behavior in `M-x > +shell' sessions, do something like this: > + > + (add-hook > + 'shell-mode-hook > + (lambda () > + (setq comint-insert-previous-argument-from-end t)))") > + Seems simpler to just make it a defcustom. The user could still setq-local if they really want per-buffer settings. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 17 22:25:08 2018 Received: (at 25271) by debbugs.gnu.org; 18 Jun 2018 02:25:08 +0000 Received: from localhost ([127.0.0.1]:54217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUjqu-0005QZ-8y for submit@debbugs.gnu.org; Sun, 17 Jun 2018 22:25:08 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:53161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUjqr-0005QR-W9 for 25271@debbugs.gnu.org; Sun, 17 Jun 2018 22:25:06 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 66BCE21ADF; Sun, 17 Jun 2018 22:25:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 17 Jun 2018 22:25:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=pK1+M1Xklb6RCpGbZyOUrwRW73Ph1GNlqYd8kHhzVHE=; b=ZBKVDlE4 rNE4ghVSw6Gf70jq+dTARqpET4fJPgNygceNEmQdx35zD3co/fnHjEnxnuy0K+u4 zG6EnFq7EqQ8XbPICnldgdBrHBcDmB6u+7hw//k+T5whqhM2056QsuSHWke5R5do 0zl63JGxHoDeRvGuNMq2Nzdz+4DR9z02auj6QwaG0fLa9MooDwhw+YOE8Uvh+r3h HEEbz3Lf8QJIKjtMc6d0/D1sja98/QJp9OX6R4eTQHcEjx0ZCpyyCC0sLwvqY2vq 04UjQjcZPzyb7Ioy1ePi4oRMuZ8/pJLcTln3IKrRTJxgLhzlloFRx2NTr+qB1n6i IwxNioZbCzxhrg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=pK1+M1Xklb6RCpGbZyOUrwRW73Ph1 GNlqYd8kHhzVHE=; b=ASUs0LtQhZkGiqyrokyT2aLsbbfbDRwlr5mL8j0UPqWeS I4H6bDgSwLd2+JD+JvGMa8nq2PoU5STpCy4mV/87I7nTffjN5o5BpeUKZzyjypvX 7FQFflgs6K/BOkiFVFfxi8IQKjMxXUskI6lOjjACr3fNYJxR07tN24BvCJUtifUY 7xFy9P2DiAjjHKwBDye8nnMM3HXe+syiFH50tRDdY3UW4k/SPU4g7VBXuxh2ma9d YrLser1WuwDm124SYqqWo7lT+FVg4BJiic7BLl+eWraEFdkvylIXd5Cl+initgiR /8T/mU6DrNkaSMGN+rPbXioVkIai6mXlVaKoWyfnw== X-ME-Proxy: X-ME-Sender: Received: from scrawny (107-210-213-243.lightspeed.irvnca.sbcglobal.net [107.210.213.243]) by mail.messagingengine.com (Postfix) with ESMTPA id C635FE4154; Sun, 17 Jun 2018 22:25:04 -0400 (EDT) Received: from dima by scrawny with local (Exim 4.90_1) (envelope-from ) id 1fUjqp-0007ob-E0; Sun, 17 Jun 2018 19:25:03 -0700 References: <87eg0veqe2.fsf@secretsauce.net> <87in86on2u.fsf@gmail.com> User-agent: mu4e 0.9.19; emacs 25.2.2 From: Dima Kogan To: Noam Postavsky Subject: Re: bug#25271: 26.0.50; [PATCH] comint-insert-previous-argument logic improvements In-reply-to: <87in86on2u.fsf@gmail.com> Date: Sun, 17 Jun 2018 19:25:03 -0700 Message-ID: <87k1qwltkw.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25271 Cc: 25271@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Noam Postavsky writes: > Dima Kogan writes: > >> +(defvar-local comint-insert-previous-argument-from-end nil > >> +This variable is buffer-local. To get the zsh behavior in `M-x >> +shell' sessions, do something like this: >> + >> + (add-hook >> + 'shell-mode-hook >> + (lambda () >> + (setq comint-insert-previous-argument-from-end t)))") >> + > > Seems simpler to just make it a defcustom. The user could still > setq-local if they really want per-buffer settings. Yes. I agree, actually. Want a new patch, and we can merge this? From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 17 22:30:50 2018 Received: (at 25271) by debbugs.gnu.org; 18 Jun 2018 02:30:50 +0000 Received: from localhost ([127.0.0.1]:54221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUjwO-0005Zu-VN for submit@debbugs.gnu.org; Sun, 17 Jun 2018 22:30:50 -0400 Received: from mail-io0-f177.google.com ([209.85.223.177]:44305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUjwM-0005Zf-Om for 25271@debbugs.gnu.org; Sun, 17 Jun 2018 22:30:47 -0400 Received: by mail-io0-f177.google.com with SMTP id g7-v6so15470108ioh.11 for <25271@debbugs.gnu.org>; Sun, 17 Jun 2018 19:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=8X71B7m2xobrIiQnUMRckSgCEQ+vkT1/DQLStZHdSus=; b=Xd3pxqnFhe7yqrG2QwGBwY3U2MUH2YSOIZrW58AMbiy2CTTNTzJ0BLCBNN8xnHSRk1 pXEplu+qum19BTFqE4f5d4EI4fMAVuiNJioG+hec1TQUmdQeVr0YdhPRMp+6G0/xFAgC AYj0gTDdUJSG9EIggWk67qNPVROu9GnS2r90EhoaGvhLtSY55AwFn6jbrgYQDN4X8lVh rWH1InuFcqjqXjCOKcJuRU/AYa8KKT0ucLmpO7NXRMdkpa1WgnWmphTfD/R86F61VjHC Nqf/8oSo8TLxdJ63mGcaJ+phmEt99o2d5G8xbHrOsKl4Wmk09Lzc2mY4dYLhdYkJsHtz wzmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=8X71B7m2xobrIiQnUMRckSgCEQ+vkT1/DQLStZHdSus=; b=bVmUMNTyJSfzfWlV9YmuMYnCD/0djGVtmVV8rsS0/b2DZ/vLImOIHHB364a0A7wYW6 wLOEmD8hnZLr4YNVQqfxwxqHUpmqg9qxC+ZOmbLcEFZiSoR47UQMP2VnJmoA/Oo3hpl/ 0FgEVTZRKwKi9WCa2hUYMzGfhkvK4SWHvIVwV35H3AnZFI2DZOaUpv5sdP7F0nS/vRbA CfebQ25I167nudSYLmTH/c+uTVbqLT3ITGwVBrZphi0E7UdGwtG+rAgeTokzBwx4YOMp wmM89ozQbfSkdzjayazV0cO0RnBUFK8IoBSdAMBoK3T6nKp2Z/ZxHQwToJg+cC0uD2u6 rcjw== X-Gm-Message-State: APt69E1y1cetlgi5QpkoCLACbqUjUmOYjqL3EfdiXNZUwSXM4rFa+/Xa /f9pfwnO2YHe/fCMzjeiJp4qVQ== X-Google-Smtp-Source: ADUXVKLuFg0Bx51MvILAmX8F7qsKle1NQ4zg1aOSybxM7dkorSy6tO1WsOz9Y5LVhpkjSUNRu7PKBw== X-Received: by 2002:a6b:974c:: with SMTP id z73-v6mr8556799iod.102.1529289041201; Sun, 17 Jun 2018 19:30:41 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id o80-v6sm3926846ito.44.2018.06.17.19.30.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 17 Jun 2018 19:30:40 -0700 (PDT) From: Noam Postavsky To: Dima Kogan Subject: Re: bug#25271: 26.0.50; [PATCH] comint-insert-previous-argument logic improvements References: <87eg0veqe2.fsf@secretsauce.net> <87in86on2u.fsf@gmail.com> <87k1qwltkw.fsf@secretsauce.net> Date: Sun, 17 Jun 2018 22:30:39 -0400 In-Reply-To: <87k1qwltkw.fsf@secretsauce.net> (Dima Kogan's message of "Sun, 17 Jun 2018 19:25:03 -0700") Message-ID: <878t7cu8q8.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25271 Cc: 25271@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dima Kogan writes: >> Seems simpler to just make it a defcustom. The user could still >> setq-local if they really want per-buffer settings. > > Yes. I agree, actually. Want a new patch, and we can merge this? Yeah, please add a NEWS entry for the new option and it should be good to go for master. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 18 02:05:39 2018 Received: (at 25271-done) by debbugs.gnu.org; 18 Jun 2018 06:05:39 +0000 Received: from localhost ([127.0.0.1]:54296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUnIJ-00025l-F3 for submit@debbugs.gnu.org; Mon, 18 Jun 2018 02:05:39 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:36087) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUnIH-00025e-MU for 25271-done@debbugs.gnu.org; Mon, 18 Jun 2018 02:05:37 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9C13721B5F for <25271-done@debbugs.gnu.org>; Mon, 18 Jun 2018 02:05:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 18 Jun 2018 02:05:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secretsauce.net; h=content-type:date:from:message-id:mime-version:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=3qgeDUj9R7iVvgGD5 WseDaVYWfXhOca6k9g0ggvuh0Q=; b=Up6dCQvcgp7XALPvmeOg+6+qCyR/OW63I RkXamaeVPzpHLjsi2xZNiCDoMK+Epdqgea0fvxZphQg+0YUEScvP93F2/mSn7Xiq 1nAurGQFEa4+c9PME+3FBAY/wdm2d4YH+7sI7Tb+9uX+BKzgLJ8UQomCJvJVxw2K ZmpRCHX1SlxJNuaBIyD+Ztx2ZnFYV1TEmCGDDu2FH/fSucu7A5TnnQhgvc2UGY48 5YP4qZ0HMYYHWDyTICp4p8ZrxbTK4/7Ol+zltBvGI/CGBE41zA1xINVxrTv4LTnp 2rPxvg3iBlj1v4dgyfg2QIlWl3tB86hyWuvPRTcoV8vlRRKl93h3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=3qgeDUj9R7iVvgGD5WseDaVYWfXhOca6k9g0ggvuh0Q=; b=jnL3Wjxw FA+OWVgHyO3yvZAh8In7uZlkJ4+BiHsqPmAazO7XlFag4SGCHBRkQcNgawvRmg8x n69jgpJ7Ysp0S5xsQTRPbfO5wrSNW8B6NmSoNYEbOuZOrSGXmKygNdbOvDEnyK0l 89rwrne9oMOHdo7a5Ux/4RAlsqmZs7NQg1EIBlLUKmZiDc/Gpe65a2Uh2pOWBNza U/1aYAKqmlKUMJjJLd8fZauns/Y+TIqBfIMisYXXiWedH62sN/UK1DyfDTlwCcd4 UhZvj3ofgU4p+hDJVgjBG22TZwiwtXMelxbaK9H0hdiHnUwqsMNpKTIvdz9f2MTa DW0zMnubMtSOcA== X-ME-Proxy: X-ME-Sender: Received: from scrawny (107-210-213-243.lightspeed.irvnca.sbcglobal.net [107.210.213.243]) by mail.messagingengine.com (Postfix) with ESMTPA id 388961032F for <25271-done@debbugs.gnu.org>; Mon, 18 Jun 2018 02:05:37 -0400 (EDT) Received: from dima by scrawny with local (Exim 4.90_1) (envelope-from ) id 1fUnIG-0007y5-8B for 25271-done@debbugs.gnu.org; Sun, 17 Jun 2018 23:05:36 -0700 User-agent: mu4e 0.9.19; emacs 25.2.2 From: Dima Kogan To: 25271-done@debbugs.gnu.org Subject: Committed Date: Sun, 17 Jun 2018 23:05:36 -0700 Message-ID: <87bmc8ljdb.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25271-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Patches committed in ba2ddadb5378351e8003c8e172b52bfabaa27554 From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 18 12:29:25 2018 Received: (at 25271) by debbugs.gnu.org; 18 Jun 2018 16:29:25 +0000 Received: from localhost ([127.0.0.1]:55243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUx1x-0007mH-BM for submit@debbugs.gnu.org; Mon, 18 Jun 2018 12:29:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUx1w-0007m3-83 for 25271@debbugs.gnu.org; Mon, 18 Jun 2018 12:29:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fUx1n-0003DK-3g for 25271@debbugs.gnu.org; Mon, 18 Jun 2018 12:29:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41762) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUx1m-0003D3-VH; Mon, 18 Jun 2018 12:29:15 -0400 Received: from [176.228.60.248] (port=4697 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fUx1m-0007Op-FD; Mon, 18 Jun 2018 12:29:14 -0400 Date: Mon, 18 Jun 2018 19:29:13 +0300 Message-Id: <831sd4t5wm.fsf@gnu.org> From: Eli Zaretskii To: Dima Kogan In-reply-to: <87bmc8ljdb.fsf@secretsauce.net> (message from Dima Kogan on Sun, 17 Jun 2018 23:05:36 -0700) Subject: Re: bug#25271: Committed References: <87eg0veqe2.fsf@secretsauce.net> <87bmc8ljdb.fsf@secretsauce.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25271 Cc: 25271@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Dima Kogan > Date: Sun, 17 Jun 2018 23:05:36 -0700 > > Patches committed in ba2ddadb5378351e8003c8e172b52bfabaa27554 Thank you for working on this. In the future, please observe the following minor gotchas (I fixed them for this changeset): . The commit log entries should be full sentences: start with a capital letter and end with a period. . A new or modified defcustom should have a suitable :version tag that records the version where it was introduced or its value changed. . Please update the manual(s) to reflect the changes, otherwise this job is left for the pretest phase, where it delays the release, and also increases the risk of having inaccurate documentation (due to the time that passed and people who forget). . NEWS entries should preferably have their first line a complete sentence that summarizes the entry. This is so NEWS could be usefully read in Outline mode after folding the body of the entries. From unknown Wed Jun 18 23:02:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 17 Jul 2018 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator